GitLab

by adding a flag to ignore path-specific suppression.

This will allow me to file bugs about current suppressions
and just say 'run checklicenses.py --ignore-suppressions some/path to repro'

BUG=28291

Review URL: http://codereview.chromium.org/7979030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102292 0039d316-1c4b-4281-b951-d872f2087c98

We found a better workaround, so removing this one.

BUG=95888
Review URL: http://codereview.chromium.org/7857022

TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/7988006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102289 0039d316-1c4b-4281-b951-d872f2087c98

The reason is to be able to share ownership between PeerConnection and Chromium.

TEST=
BUG=
Review URL: http://codereview.chromium.org/7887002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102286 0039d316-1c4b-4281-b951-d872f2087c98

A lot of UITests were failing due to being run without being logged in,
added code to login before the test are run.

Additionally added the tests that fail on the PFQ and BVT's to the
blacklisted tests list.

BUG=chromium-os:20022
TEST=Tested the BrowserTests and UITests wrapper on a ChromeOS VM.
R=zelidrag@chromium.org,nirnimesh@chromium.org

Review URL: http://codereview.chromium.org/7838033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102285 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of synchronous calls to getting plugins to help with http://codereview.chromium.org/7980011/.

The PluginExceptionsTableModel isn't used anymore.

Change print preview and using Reader with unsupported PDFs to tell the plugin filter which plugin name they want to use, instead of giving it the plugin directly. This makes the former not need to block on getting the plugins. The later still does, to know if Reader is installed or not, however it's trivial to make PDFHasUnsupportedFeature() get the plugins asynchronously because it's just a dispatcher for an async message.
Review URL: http://codereview.chromium.org/7977042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102284 0039d316-1c4b-4281-b951-d872f2087c98

Revert 102282 - committed the wrong cl - Turn off checklicenses until it's done more efficiently. Linux try runs now take an hour. This adds anywhere from 6 mintues to 10 minutes (when it times out), which is an unacceptable time.BUG=28291Review URL: http://codereview.chromium.org/7977043TBR=jam@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102283 0039d316-1c4b-4281-b951-d872f2087c98

Turn off checklicenses until it's done more efficiently. Linux try runs now take an hour. This adds anywhere from 6 mintues to 10 minutes (when it times out), which is an unacceptable time.

BUG=28291
Review URL: http://codereview.chromium.org/7977043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102282 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94240
TEST=Input @ character in a Flash text input with a Danish keyboard
Review URL: http://codereview.chromium.org/7978050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102278 0039d316-1c4b-4281-b951-d872f2087c98

This involved:
- Removing a grit->Chrome dependency that had been added in a unit test;
- Moving the very project-specific resource_ids file to not sit in the same directory as the grit files (albeit in a hacky way; will fix this better later as per TODOs in code); and
- Removing the hard-coding of "project base dir is two directories up from grit.py" and instead making that a parameter of resource_ids (as per TODO in code, this should later move to be a parameter of the .grd file).

Also fixed a minor bug in relpath in misc.py, and fixed line length in grd_runner.py.

The next steps will be to copy the tools/grit folder into http://code.google.com/p/grit-i18n, then in a single commit delete tools/grit from the Chrome repo and add it back in via DEPS.

Follow-up fixes will address some of the TODOs, and later fixes will generalize a few things and add some features available in a different version of grit.

BUG=97420
TEST=trybots should catch any breakage here

Review URL: http://codereview.chromium.org/7976026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102276 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7988003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102275 0039d316-1c4b-4281-b951-d872f2087c98

The old path will be deprecated once developers have migrated.

BUG=67203
TEST=FileUtilTest.IsPathControledByAdmin

Review URL: http://codereview.chromium.org/7718021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102274 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7980063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102273 0039d316-1c4b-4281-b951-d872f2087c98

R=hashimoto@chromium.org
BUG=chromium-os:18955
TEST=Manual


Review URL: http://codereview.chromium.org/7978055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102272 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64263
TEST=None

R=willchan@chromium.org

Review URL: http://codereview.chromium.org/7978039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102271 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102270 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=
TBR=dslomov@chromium.org

Review URL: http://codereview.chromium.org/7990001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102269 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually


Review URL: http://codereview.chromium.org/7983043

TBR=fsamuel@chromium.org
Review URL: http://codereview.chromium.org/7989002

TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/7993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102268 0039d316-1c4b-4281-b951-d872f2087c98

(Vetoed by the UI leads)
BUG=96855TEST=Load chrome://settings/extensionSettings and see that the title format is now Extensions (xx) where xx is the number of installed extensions in the list. Also if there are no extensions loaded then the title should be Extensions.Patch by naveenbobbili@motorola.comReview URL: http://codereview.chromium.org/7932021TBR=naveenbobbili@motorola.com
Review URL: http://codereview.chromium.org/7993001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102267 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually


Review URL: http://codereview.chromium.org/7983043

TBR=fsamuel@chromium.org
Review URL: http://codereview.chromium.org/7989002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102266 0039d316-1c4b-4281-b951-d872f2087c98

If a bubble view was shown immediately after creating a browser window the bubble view would get a deactivate event causing it to close.

The problem was that when the browser window's page was commited it would switch focus to the location bar. This caused the bubble view to lose focus and close.

Fix was to have the browser winodw switch focus to the location bar only if it was the active window. Thus if a bubble view was shown it wouldn't switch focus.

This change also modifies InProcessBrowserTest::CreateBrowserForPopup() to show the browser window before navigating to a blank page. This fixes a problem where the browser window wouldn't become active.

BUG=95146
TEST=


Review URL: http://codereview.chromium.org/7960001

TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/7988001

TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/7991001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7980035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102264 0039d316-1c4b-4281-b951-d872f2087c98

If a bubble view was shown immediately after creating a browser window the bubble view would get a deactivate event causing it to close.

The problem was that when the browser window's page was commited it would switch focus to the location bar. This caused the bubble view to lose focus and close.

Fix was to have the browser winodw switch focus to the location bar only if it was the active window. Thus if a bubble view was shown it wouldn't switch focus.

This change also modifies InProcessBrowserTest::CreateBrowserForPopup() to show the browser window before navigating to a blank page. This fixes a problem where the browser window wouldn't become active.

BUG=95146
TEST=


Review URL: http://codereview.chromium.org/7960001

TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/7988001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102263 0039d316-1c4b-4281-b951-d872f2087c98

Revert 102259 - Revert 102215 - Pull libcros v173

Lots of functions have been deprecated recently.
We should update the DEPS and wait for a while before
removing them.

BUG=chromium-os:20648
TEST=build chrome

Review URL: http://codereview.chromium.org/7980030

TBR=satorux@chromium.org
Review URL: http://codereview.chromium.org/7977046

TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/7983060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102261 0039d316-1c4b-4281-b951-d872f2087c98

R=hashimoto@chromium.org
BUG=chromium-os:19649
TEST=Manual


Review URL: http://codereview.chromium.org/7978054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102260 0039d316-1c4b-4281-b951-d872f2087c98

Lots of functions have been deprecated recently.
We should update the DEPS and wait for a while before
removing them.

BUG=chromium-os:20648
TEST=build chrome

Review URL: http://codereview.chromium.org/7980030

TBR=satorux@chromium.org
Review URL: http://codereview.chromium.org/7977046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102259 0039d316-1c4b-4281-b951-d872f2087c98

and adding ARIA attributes.

BUG=96906
TEST=manual testing

Review URL: http://codereview.chromium.org/7917015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102258 0039d316-1c4b-4281-b951-d872f2087c98

This is almost the same patch [1] as was reverted last week due to flakiness in one of the Win tests, but for one change: MediaStreamManager is not called from MediaStreamDispatcherHost::OnChannelClosing, to avoid shut-down crash. This will be changed as soon as the shut-down issue is solved.

[1] http://codereview.chromium.org/7649016/

Review URL: http://codereview.chromium.org/7948004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102255 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97186
TEST=none


Review URL: http://codereview.chromium.org/7973006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102254 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102253 0039d316-1c4b-4281-b951-d872f2087c98

This also fixes an issue where inferred sections were not being updated after server types were returned.

BUG=93595
TEST=browser_tests --gtest_filter=*DataDrivenHeuristics*16*


Review URL: http://codereview.chromium.org/7981047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102251 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2191
TEST= run ./scons --mode=dbg-host,nacl platform=x86-64 --nacl_glibc run_ppapi_bad_browser_test
Review URL: http://codereview.chromium.org/7979018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102250 0039d316-1c4b-4281-b951-d872f2087c98

[windows] Filter --flag-switches-begin and --flag-switches-end from being sent in the breakpad metadata.

Review URL: http://codereview.chromium.org/7981038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102249 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97409
TEST=Try compiling on Linux with CUPS < 1.4


Review URL: http://codereview.chromium.org/7980036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102248 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97186
TEST=none


Review URL: http://codereview.chromium.org/7971008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102247 0039d316-1c4b-4281-b951-d872f2087c98

Original patch by kalman@chromium.org

BUG=97511
TEST=
TBR=kalman@chromium.org

Review URL: http://codereview.chromium.org/7978053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102246 0039d316-1c4b-4281-b951-d872f2087c98

Original patch by kalman@chromium.org

BUG=97511
TEST=
TBR=kalman@chromium.org

Review URL: http://codereview.chromium.org/7976043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102245 0039d316-1c4b-4281-b951-d872f2087c98

Original patch by kalman@chromium.org.

BUG=97511
TEST=
TBR=kalman@chromium.org

Review URL: http://codereview.chromium.org/7980060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102244 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=1) ran unit_tests with and without touchui=1 2) built touchui=1 image and manually tested it.


Review URL: http://codereview.chromium.org/7976021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102243 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95110
TEST=none


Review URL: http://codereview.chromium.org/7831041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102242 0039d316-1c4b-4281-b951-d872f2087c98

MenuConfig::Create passes HFONT to Font ctor but this HFONT isn't deleted. PlatformFontWin keeps copied HFONT by InitWIthCopyOfHFONT rather than keeping passed HFONT.

BUG=96872
TEST=Manual on Win7


Review URL: http://codereview.chromium.org/7978021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102241 0039d316-1c4b-4281-b951-d872f2087c98