- 11 Apr, 2018 23 commits
-
-
Yuwei Huang authored
Previously we don't bother to implement a keycode mapping logic and we directly send texts to the host to inject. Hosts usually handle text injection very differently than key injection and may end up texts being directly injected to the host without passing through IME. In other words, host side IME doesn't work with our current key injection implementation. The downside of this change is that non-US keyboard user will now get the wrong keyboard output on the host again, which is what we had on the v1 client. For longer term, we can add a new host setting for changing the keyboard layout. NOTRY=true Bug: 830959 Change-Id: Ia34b6894fd7c0a7a07a5b9657aca19c2a878bd4e Reviewed-on: https://chromium-review.googlesource.com/1006065 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#549706}
-
Becca Hughes authored
Since we moved to the image based scrim it looks like image set does not properly provide an image at a high pixel ratio. This provides a quick patch to use media queries instead to provide the high DPI image. A follow up to this CL will be to fix the image set property properly. BUG=830583 Change-Id: I77f3ab695facb23f96dcde9e28c57237034f23d1 Reviewed-on: https://chromium-review.googlesource.com/1003274 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#549705}
-
Fabio Tirelo authored
The goal is to offer a shortcut for cases when tests may either enable or disable a feature based on a condition. Examples that could be simplified if such method exists: - https://cs.chromium.org/chromium/src/components/autofill/core/browser/form_structure_unittest.cc?l=50 - https://cs.chromium.org/chromium/src/ui/app_list/views/search_result_page_view_unittest.cc?l=62 Change-Id: I408cae760aa6a031770498202eb817e3bbd63a6b Reviewed-on: https://chromium-review.googlesource.com/1005421Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#549704}
-
P H authored
This will allow tunneling information that account is child to ARC. Bug: 825298 Change-Id: I92d268c8bc13378de04e4eb4c2eeb69b79946a81 Reviewed-on: https://chromium-review.googlesource.com/980952 Commit-Queue: Patricia Hongo <phongo@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#549703}
-
rbpotter authored
Add key event handling: - Enter key results in print - Ctrl + shift + P brings up system dialog - Escape key and cmd- to close (on Mac) - Arrow keys/page up and down scroll the preview PDF Mostly copied from the existing UI code in print_preview.js and previewarea/preview_area.js. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I78c99c0ddacc09d598766737a3af4cdcbcca741d Reviewed-on: https://chromium-review.googlesource.com/998345 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#549702}
-
Sahel Sharify authored
This cl changes timer-based wheel scroll latching to start a new scroll sequence when no GSU from the current scroll sequence is consumed and the coming wheel event has different scroll delta direction(s). The reason for this fix is the following scenario: Consider a scrollable div currently at its extent inside an unscrollable viewport. If the user starts scrolling the div downward, the scrolling will latch to the viewport and if there is no rubber-banding or glow effect the user wouldn't notice this. Then if the user decides to scroll the div upward within the same scroll sequence, the viewport will try to scroll upward and again due to lack of overscroll notion the user would see the scroll as ignored. With this change the user would see the upward scrolling since direction change would break the timer based latching and the new scroll sequence will latch to the div. Test: *.TimerBasedLatchingBreaksWithDirectionChange Bug: 828751 Change-Id: I0a709aecc1363759a3b0e0622bac8cad72666014 Reviewed-on: https://chromium-review.googlesource.com/998316 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549701}
-
Koji Ishii authored
This patch is a refactor, no behavior nor logic changes. In the last refactoring, list markers are propagated to list item as NGBlockNode and uses static functions of NGListLayoutAlgorithm. This patch refactors NGListLayoutAlgorithm as NGUnpositionedListMarker, that holds the list marker node and positioning functions as instance functions. Also common code are extracted to private functions. Unfortunately, gerrit/git no longer recognize this as rename and that the diff is large, but the logic does not change. This is to prepare for further fixes that include logic changes. Bug: 725277 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic5c411c0ba977d95695b5feea194a422ea3b5d01 Reviewed-on: https://chromium-review.googlesource.com/1001215Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549700}
-
Tom Anderson authored
BUG=822410 TBR=dpranke Change-Id: I8b9922029b0b1cfbf327ba4de4dec346bb01a2ca Reviewed-on: https://chromium-review.googlesource.com/1006168Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#549699}
-
Elly Fong-Jones authored
This is a debugging hack to try to narrow down the root cause of the linked bug. TBR=sky@chromium.org Bug: 828031 Change-Id: Ibdfbd50cdc1bac1ec598f46efba5a63cb0475628 Reviewed-on: https://chromium-review.googlesource.com/1005103 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#549698}
-
rbpotter authored
Port the GCP certificate error messages - Learn more links work - UI shows up in preview area - Destination information has correct styling in destination settings. Also - Ensure invalid printer gets set in PrintPreviewApp so that state is changed - Adjust state transition logic, since the system dialog link is available and can be clicked in most states as long as the OS is not Windows. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id644932123ef570f0d304e5fc7739a9f14d6a7d9 Reviewed-on: https://chromium-review.googlesource.com/998843Reviewed-by:
-
Kenneth Russell authored
Already marked flaky on Linux and Android. NOTRY=true TBR=xlai@chromium.org, trchen@chromium.org, ynovikov@chromium.org Bug: 807742 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I883f6f0e21f20aebdff32071de29d4f02c477c72 Reviewed-on: https://chromium-review.googlesource.com/1006357 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549696}
-
Sonny Sasaka authored
Currently passkey is padded with trailing zeros if it's less than 6 digits. It should be padded with leading zeros instead. Bug: 817574 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3a27412c9c053141d28a6e7e7e609de28729ee20 Reviewed-on: https://chromium-review.googlesource.com/1005616Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#549695}
-
Christopher Grant authored
BUG= R=vollick Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iab04434e20a42a346a762cc61c04ade0e3cf1fc5 Reviewed-on: https://chromium-review.googlesource.com/1005905Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#549694}
-
Annie Sullivan authored
This reverts commit 400c1e29. Reason for revert: This CL caused several performance regressions. Bug: 830776,830790,830792,830794,830802,830806 Original change's description: > Enable presentation feedback on Linux > > Bug: 776877 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I6faa89c42bb8a6bf43c4a9c6fe86826dca316e4f > Reviewed-on: https://chromium-review.googlesource.com/998317 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548803} TBR=penghuang@chromium.org,piman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 776877 Change-Id: I2f4d442305eb6505401e058773338b782c94c3ef Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1005157Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#549693}
-
Robert Ma authored
This test has been deleted in the upstream. Remove its expectation line in advance to save the next WPT import from having to run the LayoutNG try job. TBR=kojii No-Try: True Change-Id: I89850c603dd82429911c5534b3bae4a73874e2c6 Reviewed-on: https://chromium-review.googlesource.com/1006271Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#549692}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic976db8e6fc7ea7f342a8ad6dbe28a725b4db45f Reviewed-on: https://chromium-review.googlesource.com/1006270Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#549691}
-
Saman Sami authored
I removed a DCHECK by mistake in crrev.com/c/995915. Also add a comment. Bug: 815187 Change-Id: I5bffc2b23358a56ebf3a35621c6c9f2970519b58 Reviewed-on: https://chromium-review.googlesource.com/1005785Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#549690}
-
Andrii Shyshkalov authored
R=jchinlee@chromium.org Bug: 731543 Change-Id: I84441f7d1a4b3b3a1ff620518019b4b93ab88b2b No-Try: True Reviewed-on: https://chromium-review.googlesource.com/1006265Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549689}
-
Peter K. Lee authored
ObjCCastStrict<> returns nil if the object being casted is not of the expected type. This offers a saner behavior when for whatever reasons object is not of the expected type. This is a workaround to avoid a growing crash in iOS 11.3 when an object of UIView type is casted to one of CardView type. A later call to -closeButtonFrame results in an exception (crash). Bug: 393230 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6a3f2b66c4ab6a8f268743e1ce8c902ccffaaa05 Reviewed-on: https://chromium-review.googlesource.com/1005562 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#549688}
-
Andrii Shyshkalov authored
TBR=jchinlee@chromium.org No-Try: True Bug: 731365, 764174, 764174, 807149 Change-Id: I44dda43c2ead5edbe6801eb6fc11337ad05e399a Reviewed-on: https://chromium-review.googlesource.com/1006264 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549687}
-
Peter Boström authored
Prevents popup favicon and Developer Tools window Icon from being rendered on top of the incognito badge. Drawing the icon next to the incognito badge was also tested but looked weird (like double icons). The favicon / Developer Tools icon is still the icon used in the Windows window switcher and not the incognito badge. Bug: chromium:829724 Change-Id: Ie850cec31d51e808ad718ba96e32eac6b0942158 Reviewed-on: https://chromium-review.googlesource.com/1003378Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#549686}
-
Kevin Marshall authored
This reverts commit 9638e4f4. Reason for revert: Test suites fail to execute, breaking FYI Original change's description: > Fuchsia: remove "shell" capability and add dynamic libraries to packages. > > Removing the "shell" capability allows packaged apps to load dynamic libraries > from the package. In addition, it prevents the app from using any > system-provided libraries, in favor of the package supplying all of its > data and dynamic library dependencies. > > This CL includes the system libraries from the SDK's "dist" directory in > packages built using the package() GN template. > > Bug: 823927 > Change-Id: I7c0eaef08765f8119bec9a67d381014d07ba4606 > Reviewed-on: https://chromium-review.googlesource.com/985474 > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: James Robinson <jamesr@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549641} TBR=wez@chromium.org,jamesr@chromium.org,kmarshall@chromium.org Change-Id: Id96067185552ed932590c73e87fc57050341dfa5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 823927 Reviewed-on: https://chromium-review.googlesource.com/1005741Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#549685}
-
Asanka Herath authored
Unused but valid looking schemes are a bit confusing. R=juliatuttle@chromium.org Change-Id: If82be15a61bf768cc4fb9f5e496dc52f8ab14aea Reviewed-on: https://chromium-review.googlesource.com/1001597 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#549684}
-
- 10 Apr, 2018 17 commits
-
-
Joel Einbinder authored
This gets the highlighter type from the network UISourceCode, if it exists. For overrides files with no extension, they will stay colorful as long as they are bound. Change-Id: I5f1ff41f54eabb7a7f1abf1aa27b19629529fbfd Reviewed-on: https://chromium-review.googlesource.com/1003875 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#549683}
-
Francois Doray authored
With https://chromium-review.googlesource.com/997892, a task posted via base::PostTaskWithTraitsAndReplyWithResult() can be deleted on the sequence on which it was supposed to run if it can't run because of its shutdown behavior. The constructor of AddressNormalizerImpl uses base::PostTaskWithTraitsAndReplyWithResult() to post a task to which a ChromeStorageImpl is bound. If the task runs before shutdown, the ChromeStorageImpl is returned to the main thread via the reply. However, if the task doesn't run before shutdown starts, it is deleted in the TaskScheduler thread pool (which also means that the ChromeStorageImpl is deleted in the TaskScheduler thread pool). An access race occurs when ~ChromeStorageImpl tries to remove itself from the observer list of its WriteablePrefStore. To fix this race, this CL uses base::OnTaskRunnerDeleter() to ensure that the deletion of ChromeStorageImpl occurs on the right sequence. Bug: 829122 Change-Id: I75ba8eab4a884b0f1ac5e571eaaab18f63599d6b Reviewed-on: https://chromium-review.googlesource.com/1005915Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#549682}
-
Artur Khachatryan authored
ImplicitWaitTest class tests started to fail on Android Chromium build bot. Disabling all tests for this class. Bug: chromedriver:2376 Change-Id: I0691b82fc269b4974d31ffcaabd3251858cd8444 Reviewed-on: https://chromium-review.googlesource.com/1003525Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#549681}
-
Luna Lu authored
s/UseCounter.cpp/use_counter.cc/ Change-Id: I5d079595a3e28de098547d12636dd8f4a8167ffa Reviewed-on: https://chromium-review.googlesource.com/1006039 Commit-Queue: Luna Lu <loonybear@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#549680}
-
Chris Palmer authored
But with a fallback, since it's sometimes necessary. Bug: 828886 Change-Id: I5ca1a6a6377667f2b950a209310230e8031e6043 Reviewed-on: https://chromium-review.googlesource.com/999155Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#549679}
-
Daniel Cheng authored
Declaring move constructors and assignment operators noexcept allows STL containers to use moves instead of copies, which is generally more efficient. Previously, there were compiler issues that prevented this from working [1]. They seem to have mysteriously fixed themselves and testing on https://godbolt.org/g/TqfqtK seems to indicate that the previously highlighted problematic test cases now work. [1] https://groups.google.com/a/chromium.org/forum/#!topic/cxx/ze4WJFg7RvU Bug: 706963 Change-Id: Ieb73b4c53ab4235838265f1d968d2a57aa34a737 Reviewed-on: https://chromium-review.googlesource.com/1003872Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#549678}
-
John Abd-El-Malek authored
Update V4UpdateProtocolManager, V4GetHashProtocolManager and V4LocalDatabaseManager to use SimpleURLLoader. Also add a SharedURLLoaderFactory getter on SafeBrowsingService for IO thread users. Bug: 825242 Change-Id: Ib41699d932469b4bb92130103b5257509d6b2a36 Reviewed-on: https://chromium-review.googlesource.com/1002473Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#549677}
-
Robert Ma authored
The immediate issue this CL tries to fix is crbug.com/830629, which is fixed by using mac_chromium_rel_ng instead of mac10.12_blink_rel for rebaselining on Mac 10.12. After crbug.com/818301, the remaining *_blink_rel bots need to be replaced as well. (NOTE: mac_chromium_rel_ng is planned to be upgraded to 10.13 soon. When that happens, mac_chromium_10.12_rel_ng should be used for 10.12. We are using mac_chromium_rel_ng for now only because of capacity issues of mac_chromium_10.12_rel_ng.) Meanwhile, we take this chance to add support for LUCI Buildbucket as Buildbot (and its "master" concept) is being deprecated. Buildbuckets for each bot can now be specified in builders.json. The special treatment for android_blink_rel is also moved into builders.json to reduce the amount of magic in the code. Bug: 830629 Change-Id: I4c1777f93ff63ccd7bc35abaaea435eafd19e18c Reviewed-on: https://chromium-review.googlesource.com/1003132 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#549676}
-
Amirhossein Simjour authored
Cast dialog was enabled behind a flag in VR. It was a mistake since, the same flag is used to enable some other popups. We should enable cast icon once we VR can support this dilog. Bug: 822090 Change-Id: I6c414f85d7b24a0f5dfaea4d37d541268abb4556 Reviewed-on: https://chromium-review.googlesource.com/1006037Reviewed-by:
-
Joy Ming authored
Handle errors that occur before downloading, including the name being repeated/too long, the location being missing/full, etc. Some of the changes include: - Creating DownloadsLocationDialogType to indicate which type of error- handling dialog to display. - Re-routing DownloadTargetDeterminer to loop back and double check in the case that it was a user-confirmed "new" filename/location. Screenshots: Rename workflow: https://drive.google.com/file/d/1S4Pw8zXy-uZvotx3L8eNZgl2QMzaETfX/view Not enough space option: https://drive.google.com/file/d/1JiCVo5K4kEcGVtZQhdJ4sSrqEQNagdgB/view Bug: 792775, 825929 Change-Id: Ic981343eede2b10a84d383ad429f5ddcbccfd38c Reviewed-on: https://chromium-review.googlesource.com/982530 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#549674}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/39414498..42f2c717 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I286d3362a8cc93153b3c2400f751159cabafaa42 Reviewed-on: https://chromium-review.googlesource.com/1005575Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#549673}
-
Ilya Sherman authored
Clarify that groups only have features automagically associated with them if they don't directly specify *any* associated features. The comment was previously worded for a single feature, and got only partially updated. R=asvitkine@chromium.org Bug: None Change-Id: I6cd7e79fb78112c990a5f9ed6d4ca0d59531f159 Reviewed-on: https://chromium-review.googlesource.com/1005798 Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#549672}
-
John Rummell authored
Now that CDMs use mojo exclusively, remove the Pepper APIs that are now unused. BUG=772160 TEST=compiles Change-Id: I4161d7430f86f5033dd7997fb5f2cc4a04aefa22 Reviewed-on: https://chromium-review.googlesource.com/988254Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#549671}
-
Evan Stade authored
ExtensionStorageMonitor. Bug: 793887 Change-Id: I877a8734b419054da94b307bab5389bada8aab62 Reviewed-on: https://chromium-review.googlesource.com/1000114 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549670}
-
Sunny Sachanandani authored
R=piman CC=zmo BUG=794735 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3919d0e62ed445ae1f254c4b106df721e2139d32 Reviewed-on: https://chromium-review.googlesource.com/1004001Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Jay Civelli authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/f34a90b21090..272be0ac4cae $ git log f34a90b21..272be0ac4 --date=short --no-merges --format='%ad %ae %s' 2018-04-10 jcivelli Make OWNERS file not reference outside of this repo Created with: roll-dep src/third_party/ffmpeg Bug: 831242 Change-Id: I89e269c3b6db30de1318b70bfdc0ae84fcdf1f70 Reviewed-on: https://chromium-review.googlesource.com/1005630Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#549668}
-
Samuel Huang authored
Supersize-archive requires one of '--apk-file', '--elf-file', or '--map-file' followed by filename. To simplify command-line interface for testing, this CL adds '-f' switch, which automatically identifies a given file (relies on external program 'file') to fit one of the above switches, Change-Id: I3806e27a8dbd5c260c1bda54339cef8ce9ae2f1d Reviewed-on: https://chromium-review.googlesource.com/1005729Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#549667}
-
