- 03 Mar, 2020 5 commits
-
-
David Bienvenu authored
If you open app window (e.g., chrome://apps, right click on Youtube, check "open in window", and open it), then left click just to the right of "Youtube" in the title bar of the app window, and then right click, a second context menu gets opened. This CL makes HwndMessageHandler ignore the right click when displaying a system menu opened with left click. Bug: 1053460 Change-Id: I0c32cf30995ce6e970c93d40a2e20b7b2f63d3a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071253Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746167}
-
Dmitry Gozman authored
This reverts commit 2e28f009. Reason for revert: suspecting to cause crashes, http://crbug.com/1052107 Original change's description: > Remove ScriptContext::ScopedFrameDocumentLoader > > This scope is used to map Frame to just-about-to-commit DocumentLoader. > > With https://crrev.com/706529, we now call ReadyToCommitNavigation > after the commit (as opposite to before the commit). Therefore, > WebLocalFrame::GetDocumentLoader is already the right one and we don't > need a scoped mapping. > > Bug: 855189 > Change-Id: I95621b00ee4391986f063e56f20d8d7d25b5c532 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046210 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740198} TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 855189 Change-Id: I7021f96e4c6db2a41f048113b369eee7a21b07ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083390Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#746166}
-
Xinghui Lu authored
FullURLLookupWithToken is enabled when: 1 FullURLLookup is enabled. 2 The user is syncing their browsing history. 3 Custom passphrase is disabled. Bug: 1041912 Change-Id: Ie477512e9cd311d7db8891cc8a0bd7daf0559293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071385 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#746165}
-
gogerald authored
Bug: 1041047 Change-Id: I43fafa456579ab0c760e278f8972bd82b2bc187a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078555 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746164}
-
Takashi Toyoshima authored
Update the file to match actual parameters that was fixed to distribute parameters correctly. Bug: 1001450, 1056037 Change-Id: I387be6a82e3ecc96d0c7b4a1c4975f97dde717ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082222 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#746163}
-
- 02 Mar, 2020 35 commits
-
-
Gang Wu authored
Separate clipboard out of BasicSuggestionProcessor, and create a new processor for clipboard. Bug: 1020708 Change-Id: I9008c6263354562ffbc8232b28c839a45c96fe46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051292 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#746162}
-
Julian Watson authored
Bug: None Change-Id: Ifa311c32d0fa2a0d2cb7c13e107e98b7d046aeed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082423Reviewed-by:
Julian Watson <juwa@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Auto-Submit: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#746161}
-
Tomasz Wiszkowski authored
This CL addresses a bug, where Omnibox content would occasionally get updated with the inaccurate content when browsing the suggestions using Keyboard. Bug: 1054399 Change-Id: Ic00d8e2b6bbf6680de56ca78cfacf4a25d5f8b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081890Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#746160}
-
Tsuyoshi Horo authored
Bug: 1057538 Change-Id: Ic2b014d80a27a07c866e873e82a236d368ac11e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082738Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#746159}
-
Josh Simmons authored
This would happen when the kPerformanceHintsTreatUnknownAsFast flag was enabled but the user opted out of Make Browsing Better. Also fix an issue where we wouldn't reset the value of hint_processed_, which caused us to never log kHintNotReady after the first load. Bug: 1040661 Change-Id: I32f0b8ea475d4d23a9af9e074482b9e009980719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078908 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#746158}
-
Kramer Ge authored
The purpose is to indicate where (0,0) is in an output surface. And replace GLSurface::FlipsVertically() with a descriptive function that returns surface origin. It is nicer if enum SurfaceOrigin is shared between ui/gl/ and components/viz/ so there's no logic for transforming. There is also an instance to change in gpu/command_buffer/common/capabilities.h. Future CL will modify it and IPC definition that uses it. Bug: 1051970 Change-Id: I33254620feba54a77ad51ff3fd6b82d6962d25bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083571Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#746157}
-
Xiaoqian Dai authored
Bug: 1056939 Change-Id: I70acfadf7ad2468e8055f8150759861b892812b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083756Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#746156}
-
Becca Hughes authored
Adds a feeds table that will store feeds in Media History. BUG=1057765 Change-Id: I68e38fdeb608da9f9279c74ffbed3f7efc5037a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082300Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#746155}
-
yilkal authored
This CL ensures that the time limit is shown in the blocking page. Bug: 1056471 Change-Id: Ia283881a8f4645f130679a48301d84bcdd32ad69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083398 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#746154}
-
Xing Liu authored
AutofillAssistantDirectActionHandlerTest#testReportAvailableDirectActions is failing on Android bots, disable it. TBR=mcarlen@chromium.org Bug: 1057806 Change-Id: I73c0ad991b42f3a554c376f43b0f3170205e5935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082224Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746153}
-
John Budorick authored
Bug: 1056325, 1056878 Change-Id: I374d538d7104f8ea60520a40ea15b9661f7d304c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083753 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#746152}
-
Mason Freed authored
Prior to this CL, unrecognized values of the "scrolling" attribute would leave the prior value unchanged. That behavior is counter to the spec [1], and is also confusing to developers, as it introduces state to the "scrolling" attribute. This CL fixes that. [1] https://html.spec.whatwg.org/multipage/rendering.html#the-page Fixed: 1057454 Change-Id: Ib6b4cd4c6952fe580003dc2577c72db2fe622fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083595 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#746151}
-
Xing Liu authored
UserLevelMemoryPressureSignalGeneratorTest.GeneratesWhenOverThreshold has been flaky for a few days, disable it. TBR=dcheng@chromium.org Bug: 1054788 Change-Id: I5c16cdbf17316f6475e43d11d754006d194d970f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083829Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746150}
-
Matt Menke authored
In particular, have it invoke net::RedirectInfo::ComputeRedirectInfo() when an extension injects a redirect so that site-for-cookies, referrer, method, and referrer_policy are all calculated correctly, and have it update NetworkIsolationKey according to the value in request_.trusted_params->update_network_isolation_key_on_redirect. Change-Id: Ied1e0d9825b75110143881d6aac806da1f13baab Fixed: 1053573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057529 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746149}
-
Jinsuk Kim authored
Extends the experiments to M85 so the flag options will be visible. Change-Id: I4643b2dcc0167af9a6e9ad2d0a85ec7ae1d027f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081715 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#746148}
-
Thomas Guilbert authored
Despite hand coded test values, the difference between base::TimeTicks::Now() and the Document's origin time can result in times aligned with a 5 microseconds clock. This is a test failure, because we don't know whether or not the time values were successfully clamped. This CL uses the reference monotonic time instead of base::TimeTicks::Now() when initializing the test values, which guarantees deterministic results. Bug: 1057319 Change-Id: I26ee485545a75ba25bc2e9187e78f032fce767e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083737Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#746147}
-
shrekshao authored
Tested on Pixel 3 XL (with HDR support) (validating) and Nexus 5X (without HDR support)(validating/passthrough) with up-to-date WebGL ASTC test. Not tested with passthrough angle on Pixel 3 XL due to the build config and cmd line settings for passthrough angle not work properly locally (reported to Geoff). But given that angle exposes the extension with the same name as OpenGL it should be fine. Bug: 1049880 Change-Id: Iadc1a78591068927bbed9523131924187f53fe3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080823 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#746146}
-
Wenyu Fu authored
Use criteria helper to wait desire state of UI to reduce flakiness. Bug: 1056985 Change-Id: I8883722a62120cc4228e2fd5d7c3abc8b3ca071d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080470 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746145}
-
Sergey Ulanov authored
ApplicationControllerReceiver protocol is being replaced ApplicationContext. This CL updates CastRunner to use ApplicationContext instead of ApplicationControllerReceiver. Bug: 1028409 Change-Id: I7679ba3238754e994bf9fcc2bec1a30ddcd75389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079808 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746144}
-
Brandon Wylie authored
Bug: 1015174 Change-Id: I356619e74745a31ebd0aef46f64977a025dd099b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078978 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#746143}
-
Raymond Toy authored
In DeferredTaskHandler::BreakConnections, we want to remove finished handlers and break the connection. when a finished handler is removed from active_source_handlers_, it might be deleted, but we were still using that to create the connection. Instead, break the connection first and then remove it. Manually ran test from the bug and it passes with this change. Without this, it failed right away. Bug: 1057593 Change-Id: I3c9346a6842f412100d608876adb268befb80470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083436 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#746142}
-
Gang Wu authored
This reverts commit d9deeea6. Reason for revert: compile error on ios-device build https://ci.chromium.org/p/chromium/builders/ci/ios-device/150149 Original change's description: > Update Crashpad to 11b8eb10d4ad6ed50ee43d3bb50d13967d638dfa > > 9ed829054711 Bring up skeleton crashpad_client_ios > 22701bb0e448 fuchsia: Use zx_system_get_version_string > f79cba47ba0d [lsan][crashpad] Suppress leak sanitizer on crashpad_test > 0c20aeabd37a [UBSan] Temporarily disable UBSan for snapshot and minidump > d632f625a2f2 Fix a Wrange-loop-analysis warning in crashpad > 8bad6f140e0b [UBSan] Temporarily disable UBSan for gtest and file > 11b8eb10d4ad Don’t use the disappearing MSVC_PUSH_DISABLE_WARNING() > macro > > Change-Id: I5f0ba09aae2fcd1a8b91543f91a94ffe093f16b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083654 > Commit-Queue: Mark Mentovai <mark@chromium.org> > Reviewed-by: Joshua Peraza <jperaza@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746133} TBR=thakis@chromium.org,jperaza@chromium.org,mark@chromium.org Change-Id: I48cc6cb41ab563964f50fa02cf3a7570c820a059 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083933Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746141}
-
Mike Reed authored
Bug: skia:9984 Change-Id: I119ce10adcf14000d2f706f7c947f3c3f1da68a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083599Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#746140}
-
Tricia Crichton authored
Prior to complete removal planned for m84, the LaunchApp command will be rejected. As a temporary workaround, a new capability is added to give access to LaunchApp when requested by users. Bug: chromedriver:1778 Change-Id: I93f9aab5fca4593032b5876ddf2fbb52e50c7335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080782Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#746139}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4044.25-1582542147-benchmark-82.0.4072.0-r1 to 82-4044.31-1583145468-benchmark-82.0.4072.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ibeba5967bda1115a7d3dc80e2aaabbdc64f53340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083856Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746138}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I1496ecb101aff65a24a4471eebe8dcb09ca3e6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083343Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#746137}
-
Piotr Bialecki authored
Part 2/2. Previous work: https://crrev.com/c/2067538 Changes: - XRInputSourceDescription now carries additional boolean signifying whether an input source is primary or auxiliary. Additionally, added comment explaining current situation around input source ID reuse. - ArCoreGl now propagates the input source information for non-primary input sources as well. - XRInputSource ignores auxiliary input sources for the purposes of WebXR events. - XRSession ignores auxiliary input sources when determining whether onbeforexrevent will be raised. - Debugging: debug-sources.js now keeps track of input sources by assigning a number to each of them. The order of input sources in the session's input source array is not guaranteed to be stable. Fixed: 1048329 Change-Id: Ie260151cc34e5b937d0c3e16c4be3e5fa8c44783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072596 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746136}
-
Ian Clelland authored
Byte sequences, previously delimited by asterisks, have changed in Structured Headers draft 15 to use ':' as the delimiter. This CL updates the implementation to be in line with the latest draft, while keeping backwards compatiblity with draft 9 for existing uses. Bug: 1048755 Change-Id: I1e8684a016085573ab6815bb078c8f7f3a41870e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073537 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#746135}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4044.15-1582543985-benchmark-82.0.4072.0-r1 to 82-4044.31-1583147204-benchmark-82.0.4072.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5c6a1aa96c5a46a63e2fb8fc305401708de73829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083914Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746134}
-
Mark Mentovai authored
9ed829054711 Bring up skeleton crashpad_client_ios 22701bb0e448 fuchsia: Use zx_system_get_version_string f79cba47ba0d [lsan][crashpad] Suppress leak sanitizer on crashpad_test 0c20aeabd37a [UBSan] Temporarily disable UBSan for snapshot and minidump d632f625a2f2 Fix a Wrange-loop-analysis warning in crashpad 8bad6f140e0b [UBSan] Temporarily disable UBSan for gtest and file 11b8eb10d4ad Don’t use the disappearing MSVC_PUSH_DISABLE_WARNING() macro Change-Id: I5f0ba09aae2fcd1a8b91543f91a94ffe093f16b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083654 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746133}
-
Luciano Pacheco authored
Initial re-style for file grid, updates the size, spaces and some colors in the file grid. Some styles are shared between file list and file grid and also previous look'n'feel and the new one, so CSS selectors are hard to overwrite for new look'n'feel in the file grid. Add":not(files-ng)" to the icon selector to simplify the issue and add "#list-container list" when the rule should apply only to file list. Add a new test: add file-ng flag showGridViewDownloads Test: browser_tests --gtest_filter="*showGridViewDownloads*" Bug: 992822 Change-Id: Ia761775207377a3aa94c5fe1762702cc2afbda62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072685 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#746132}
-
Xing Liu authored
Disable flaky ConfirmManagedSyncDataDialogIntegrationTest# testDialogIsDismissedWhenRecreated. TBR=bsazonov@chromium.org Bug: 1054855 Change-Id: If4303f12d5aec847b7a2d23392dd7c895e767d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081521Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746131}
-
Moe Ahmadi authored
The PZPS header information is expected in the following format in the Chrome suggest response. Every suggestion with a header has a header group id in its respective "google:suggestdetail" dictionary which maps to a header text inside "google:headertexts>a". ... "google:headertexts":{ "a":{ "40009":"Recommended for you" } }, "google:suggestdetail":[ ... { "zl":40009 }, { "zl":40009 } ], ... This CL parses that information and adds the respective header as a |header| field on the first ACMatch in every group of adjacent matches with the same header, unless: 1) Matches with the same header are not adjacent to one another, i.e., are interleaved by matches with different headers or matches without one. 2) Matches without a header come after the ones with headers. Note that the headers do not determine classification or ranking of the matches. They are expected to be valid after the AutocompleteResult is finalized. These error conditions, however, are in place to safeguard the integrity of the displayed headers. Bug: 1052519 Change-Id: Ibbd3a812690605cd13763e41f109197ef75c1727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079303Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746130}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4044.25-1582540590-benchmark-82.0.4072.0-r1 to 82-4044.31-1583148634-benchmark-82.0.4072.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I68aad14edb2a7b81af241a78c3232471acdb6eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083854Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746129}
-
Brandon Wylie authored
When new tab pages are reparented, the view isn't loaded completely. New tab pages have their own logic to restore scroll position, which is the only outstanding state that would change between theme change. Bug: 1052246,1055228 Change-Id: I5c7b42f6daecc30a6499bcdf4bc6ded97795afab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067385 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#746128}
-