- 25 Nov, 2019 16 commits
-
-
Anand K. Mistry authored
When an item is selected using up/down->enter, the dropdown is closed. The only way to re-open it is to tab away and back. Allowing the user to re-open by pressing enter follows the behaviour of the select element. Bug: 851427 Change-Id: I8418b9cdbbcf48873844709d1b0453657dc0d3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921023Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#718509}
-
Evan Stade authored
Set ACCEPT_LANGUAGES based on the entire locale list, rather than just the top locale. It also updates ACCEPT_LANGUAGES when the list changes, rather than just once at startup. Navigator.language and .languages are likewise updated. The ResourceBundle now loads new strings as well, although WebLayer only packs English strings at the moment. Bug: 1025064 Change-Id: I18997eb20c883a976edf624c0a5f45b5f012aff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924722 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#718508}
-
Wei Wang authored
This patch implements ServiceWorkerContainer.onmessageerror and writes WPT test for it. chromestatus: https://chromestatus.com/feature/5699031592337408 Bug: 926102 Change-Id: I60e73dcb69de4a2876cc966dfa1809a30510b5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864409Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Wei4 Wang <wei4.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#718507}
-
Luciano Pacheco authored
Add test that checks that "src" attribute is cleared when closing the quick view, if the "src" isn't cleared the video continues to play, while it's hidden, but the audio is still audible. Bug: 970192, 1005556 Change-Id: I73d628d7d424b7f795622108eb7a1f0c7b7bcc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933671 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#718506}
-
Anand K. Mistry authored
Bug: 1007832 Change-Id: Ie5d38ff2973de77790c12c5ed2664f070704d19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930246Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#718505}
-
Maggie Cai authored
This CL updates the CommonAppsNavigationThrottle to load the icons for the apps from the App Service. BUG=853604 Change-Id: I046f01c199f0821f00e3b84f5caf00f73e5e9f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928515Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#718504}
-
Anand K. Mistry authored
Bug: 1007832 Change-Id: I26bbc7fbd4d86d1f9bfe6e503df0c9d3d811432f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930244Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#718503}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/50299de39976..6c4c685b2b8b git log 50299de39976..6c4c685b2b8b --date=short --no-merges --format='%ad %ae %s' 2019-11-24 benjaminwagner@google.com Remove Debian9 GCC jobs and related code Created with: gclient setdep -r src/third_party/skia@6c4c685b2b8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I36b7728e589e4ea2945118ac105cfab5268f2b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933628Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718502}
-
Sam Fortiner authored
Dumping the wheel event handler region in the layer tab of devtools used cc Layer::position to provide the top and left of the region rect. The only layer that would actually dump this information was the View's LayoutViewport scrolling content layer, which is never set to anything other than 0, 0. Additionally, if one looks at the wheel event handler region pushed to cc's LayerImpl that is used for hit-testing purposes on the compositor thread, one can also see that the pushed region uses 0, 0 for top/left - also consistent with a 0, 0 layer position. Note that this is expected to be changed when https://crbug.com/841364 is fixed and an accurate wheel event handler region is being calculated. The dumping code is expected to be similar to the code used for touch_event_handler_regions when completed. But for now, based on the above, using layer position is not needed for this devtool functionality and this change removes it, replacing it with a hardcoded 0, 0. With this removal, all non-UI code references to cc Layer's position are gone other than the call via GraphicsLayer::GetPosition which is only used to determine if we need to set a new position on the GraphicsLayer via UpdateMainGraphicsLayerGeometry. Since there are no other users of position, removing that logic is now possible. After that, removal of GraphicsLayer::GetPosition/SetPosition itself can be done. Bug: 999336 Change-Id: I001cc91a309fdd18c09fd17c7c227f15d8a0f032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931655 Commit-Queue: Sam Fortiner <samfort@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#718501}
-
Chris Hall authored
Links that used to be of the form wai-aria/states_and_properties#aria-controls Have to be converted to wai-aria/#aria-controls R=aboxhall,dmazzoni Change-Id: I0c129b6d64631dc407a85dae73614f16efeb4581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924339Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#718500}
-
Noel Gordon authored
cr.ui.tree uses this.labelElement.scrollIntoViewIfNeeded() to scroll a tree row into view. However, for the "Recent" item, which is always at the top of the tree, that only scrolls as far as its label, causing it to be drawn cut-off (see example image on the bug). Fix that: by overriding the Recent labelElement.scrollIntoViewIfNeeded to this.scrollIntoView, so the entire Recent box is shown (no cut-off) when cr.ui.tree scrolls to the Recent item. Test: the methods used here are web-apis and Blink tests those. No-presubmit: true No-try: true Bug: 1027973 Change-Id: I21370d3fd9aa34a781a8aff1e9fbc006f8e0053d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933670 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#718499}
-
Min Qin authored
This reverts commit a0af9d91. got enough crash stack to analyze the crash Original change's description: > Add checks to help debug a crash > > BUG=1009839 > > Change-Id: I2307fb1e693a963b9e472d73dd01cc944b0e3306 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929438 > Commit-Queue: Min Qin <qinmin@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717871} TBR=qinmin@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1009839 Change-Id: I30ce8f7232c5fab9ee03d7ad81eadfc7c9a4c31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933449Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718498}
-
Koji Ishii authored
The call to |PaintMask| in |NGBoxFragmentPainter:: PaintBlockFlowContents| is redundant. The only caller to |PaintBlockFlowContents| is |PaintObject|, but it has a call to |PaintMask| and return if the paint phase is |kMask|. This call was originally added in r510289 <crrev.com/c/720082> but was left over when the function structures were changed. Bug: 714962 Change-Id: I2be9e5fd2fb73e90e94fde9543843926c057ad96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930362 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#718497}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL moves PostMessageToClient(), CountFeature() and relevant functions from ServiceWorkerProviderHost to ServiceWorkerContainerHost. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: If15c9606e7a48bdbab40d2fece6a09bcaf4d0eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930363 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#718496}
-
Noel Gordon authored
The piex-wasm RAW image extractor was enabled-by-default since M76 by feature flags (see CL:1616836). M80: time to remove that feature flag and always use piex-wasm in production. The old NaCL implementation has not been used in production since M76 and with the flag removed, redirect the NaCl code to /dev/null. Test: browser_tests --gtest_filter="*FilesApp*QuickViewImageRaw" Bug: 1027017, 935285, 904630, 396702 Change-Id: I68e99597fd0883a2c2648b3a280df38996e03f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930289Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#718495}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/61b3a554547f..856c2a69d235 Created with: gclient setdep -r src-internal@856c2a69d235 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I3a9a346cf4e905defce1bb2bbcdcd49b475c6484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932253Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718494}
-
- 24 Nov, 2019 24 commits
-
-
Noel Gordon authored
No-try: true Tbr: adanilo Bug: 1027963 Change-Id: I0b35851be6e9d96d5ac6cd5d4213b6471c8365cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933585Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#718493}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL removes ServiceWorkerProviderHost::client_type() in favor of ServiceWorkerContainerHost::client_type(). Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I788cd59ff333091668e9fd13c47bcff0d5318b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930361Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#718492}
-
David Vallet authored
The count of user actions to switch keyboard mode (floating, docked). Recorded when the user clicks in the docked/floating keyboard menu option. Bug: 1008331 Change-Id: I9f64fa47221acaa858f6290b715798a26f9122e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921933Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#718491}
-
Mike Jackson authored
Refactored the code to use common methods (which didn't exist when the test was written), and fix the time out in the test. The fix for the time out was to reduce the size of the allocation we were making as data into indexeddb. Change-Id: Id5889c923e421dc195a5a9edf58fedd37e39ca9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927219 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#718490}
-
Kent Tamura authored
from |double| to |base::Optional<base::Time>|. This CL is the first step to stop using |double| for file timestamps in Blink. Though base::Time can be an is_null() value, we apply base::Optional<base::Time> instead of just base::Time because: - In JavaScript, the null base::Time, which represents 1601-01-01 00:00 UTC, is a valid time. We have to use base::Optional<base::Time> in some parts of Blink. - data_element.mojom applies |mojo_base.mojom.Time?| for file timestamps, and it is mapped to |base::Optional<base::Time>| in C++. This CL should have no user-visible behavior changes. Bug: 988343 Change-Id: I91f592b31cf8e61053969530fafc689eea8ff538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930756 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#718489}
-
ishell@chromium.org authored
... by adding use_unaligned=1 to default LSAN_OPTIONS. With pointer compression in V8 the external pointers from V8 heap are guaranteed to be only 4-byte aligned so without this flag LSAN is not able to find all the external pointers. Bug: chromium:328552 Change-Id: I4bb7eb68d023ae4fb4324cf13d317e3ee011669d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926472Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#718488}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fc1dc5a0c78d..61b3a554547f Created with: gclient setdep -r src-internal@61b3a554547f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I2f12f5bf6e2a5850b1ce42a2cb408ef2ce65063f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932245Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718487}
-
Emircan Uysaler authored
This reverts commit 516d3a4f. Reason for revert: Caused a bunch of regressions: crbug.com/1027725 crbug.com/1027878 crbug.com/1027879 crbug.com/1027880 Original change's description: > Reduce min_height_for_gpu_raster_tile for low memory devices > > Bug: 1025408 > Change-Id: I2cc6418f4dbbaf7b91f35fdc11ee8d5093d19fe6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922470 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Commit-Queue: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717815} TBR=jonross@chromium.org,haraken@chromium.org,emircan@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1025408 Change-Id: Ifcf4c012c36325a55deb4807ab985f87a0426bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933447Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718486}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5f29d2eb. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I97c9c50d60994aaf1d3cb72172b7078b31f577b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932835Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718485}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0e7259224a7e..fc1dc5a0c78d Created with: gclient setdep -r src-internal@fc1dc5a0c78d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I837315b48f55780f58403cecff453af992ac3159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933121Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718484}
-
Ken MacKay authored
Bug: internal b/144923441 Change-Id: I0700c880c7600c31de8e5515df5ff1f900ea3568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931755Reviewed-by:
Le-Chun Wu <lcwu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#718483}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0bc2f8e355d2..0e7259224a7e Created with: gclient setdep -r src-internal@0e7259224a7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I3e2e1d97bd9dbdc44ed402697110dcdf8b3f26db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933119Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718482}
-
Tim Schumann authored
Fails on linux-chromeos-rel. BUG: 1027940,1000959 TBR=rockot@chromium.org Change-Id: Ia973627fc1fae89e00c875d9cb6d08ce3ee17736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932660Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#718481}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5ee9a7d5e486..0bc2f8e355d2 Created with: gclient setdep -r src-internal@0bc2f8e355d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I80d9b9d554bc8bf489aac06679a82b8aaacc4f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933118Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718480}
-
Koji Ishii authored
Following bot results are included. 371 379 384 385 388 389 390 391 392 393 394 395 396 397 439 lines were removed and 76 lines were deflaked by consecutive results since 384. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ie96de61574c526c3e64b50a02578e3367d11ea6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930278Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#718479}
-
Tim Schumann authored
As tests are failing on linux-chromeos-dbg (which apparently does not set OS_CHROMEOS so disable the test on linux instead). TBR=yoshiki@chromium.org Change-Id: I4bf298ed79ff4fb20174d493594e61e55c94dfa4 BUG: 1027919 Change-Id: I39ab2707f53185be90781796747e7b20b039202e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932658Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#718478}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5fdf0df32d85..5ee9a7d5e486 Created with: gclient setdep -r src-internal@5ee9a7d5e486 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Idddd2fdc5fda71bf6f81eec1833d1d398f784fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933117Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718477}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 68560574. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I7b81c1f1c64a0ccb72dab3bdb7273f7099ead97b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932828Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718476}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fad83bcb97f9..5fdf0df32d85 Created with: gclient setdep -r src-internal@5fdf0df32d85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Icd5dc86a5c2d02cbcef0ce4752bb533261edef5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932892Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718475}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e4ad9eb5b8dd..fad83bcb97f9 Created with: gclient setdep -r src-internal@fad83bcb97f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I858f42482847b870493500151a693b3b73334e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932890Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718474}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5b50ce5a465a..e4ad9eb5b8dd Created with: gclient setdep -r src-internal@e4ad9eb5b8dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I5bdb2be26e2c4502ea32a25150ace935cdecfe24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932889Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718473}
-
Julien Isorce authored
This resolved the TODO pointed to the below bug. This also fixes the following build error on Desktop Linux when the user adds use_vaapi=true in its gn build args. LINK ./vaapi_unittest FAILED: vaapi_unittest error: undefined symbol: media::LocalGpuMemoryBufferManager::LocalGpuMemoryBufferManager() >>> referenced by vaapi_jpeg_decoder_unittest.cc "ninja -C out chrome" is working but above error is encountered when running "ninja -C out" which builds all targets. Bug: 974437 Change-Id: Ibb36e02138431b1f95fd9f4d6de3e05134ee9751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902667Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#718472}
-
Zinovy Nis authored
Bug: 1025143 Change-Id: I0b2af82249f78831e70ea398ff06da4c79eaf2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920667 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#718471}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/30319dfe..2cab5168 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib8d4f1e517689c90901bcf1c7c81d166b5644098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932823Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718470}
-