- 27 Apr, 2017 40 commits
-
-
tzik authored
base::BarrierClosure calls the given callback object only once upon the Nth invocation of resulting wrapper callback. That means, the wrapped callback should be OnceCallback, and the resulting callback should be RepeatingCallback. BUG=714018 Review-Url: https://codereview.chromium.org/2833293004 Cr-Commit-Position: refs/heads/master@{#467664}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=rdevlin.cronin@chromium.org Review-Url: https://codereview.chromium.org/2836083003 Cr-Commit-Position: refs/heads/master@{#467663}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bartfab@chromium.org Review-Url: https://codereview.chromium.org/2836133002 Cr-Commit-Position: refs/heads/master@{#467662}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2835313002 Cr-Commit-Position: refs/heads/master@{#467661}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ac0e705af1d6..56de05fec3fa $ git log ac0e705af..56de05fec --date=short --no-merges --format='%ad %ae %s' 2017-04-26 mtklein add #defines to limit SkCpu Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I4f6463f27b702185e8fe23fd112e6a9d33f783b0 Reviewed-on: https://chromium-review.googlesource.com/488461Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#467660}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8062a5765bb7..c46500e9c5b7 $ git log 8062a5765..c46500e9c --date=short --no-merges --format='%ad %ae %s' 2017-04-27 lpy [ESLint] Turn on dot-notation. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9ae6aff18aff11e4bfa7639208b935c1208a9be8 Reviewed-on: https://chromium-review.googlesource.com/488481 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#467659}
-
vitaliii authored
TBR=fukino@chromium.org BUG=715961 Review-Url: https://codereview.chromium.org/2844263002 Cr-Commit-Position: refs/heads/master@{#467658}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/05751f9b..594d9c9e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2847713002 Cr-Commit-Position: refs/heads/master@{#467657}
-
fmalita authored
DrawLineForDocumentMarker() only has one client (InlineTextBoxPainter), so it makes sense for it to be a private helper. Then we can also remove the DocumentMarkerLineStyle GC enum. BUG=424655 R=schenney@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2841153002 Cr-Commit-Position: refs/heads/master@{#467656}
-
zakerinasab authored
Currently, ImageBitmapOptions accepts 'none', 'default', 'srgb' and 'linear-rgb' color space conversion modes. This CL adds 'p3' and 'rec2020' to the list according to https://github.com/WICG/canvas-color-space/blob/master/CanvasColorSpaceProposal.md. This CL also uses ColorCanvasParams to keep the color space settings. BUG=714266 Review-Url: https://codereview.chromium.org/2836793002 Cr-Commit-Position: refs/heads/master@{#467655}
-
bratell authored
Some "using" statements that were no longer used lingered in the source code so let us remove them. Review-Url: https://codereview.chromium.org/2841923002 Cr-Commit-Position: refs/heads/master@{#467654}
-
vitaliii authored
Because flaky. TBR=nednguyen@google.com BUG=715962 Review-Url: https://codereview.chromium.org/2849513002 Cr-Commit-Position: refs/heads/master@{#467653}
-
lod authored
TBR=marq@chromium.org, eugenebut@chromium.org NOPRESUBMIT=true NOTRY=true BUG=none Review-Url: https://codereview.chromium.org/2845993002 Cr-Commit-Position: refs/heads/master@{#467652}
-
fdoray authored
Protocol handlers are used for navigation. BUG=667892 Review-Url: https://codereview.chromium.org/2845683002 Cr-Commit-Position: refs/heads/master@{#467651}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bartfab@chromium.org Review-Url: https://codereview.chromium.org/2836143002 Cr-Commit-Position: refs/heads/master@{#467650}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=dewittj@chromium.org TBR=dewittj@chromium.org Review-Url: https://codereview.chromium.org/2840643002 Cr-Commit-Position: refs/heads/master@{#467649}
-
wnwen authored
clipboard_android_unittests.cc was included in //chrome/test:interactive_ui_tests but that test is not run on android (see !is_android gn flag). Removing it since it has not been ported over to jni. This is directly blocking the removal of GetApplicatContext. Any attempt to get the test back should rewrite it on java side with jni. BUG=434620 Review-Url: https://codereview.chromium.org/2839753007 Cr-Commit-Position: refs/heads/master@{#467648}
-
rhalavati authored
Network traffic annotation is added to network request of: storage/browser/fileapi/file_system_dir_url_request_job_unittest.cc storage/browser/fileapi/file_system_url_request_job_unittest.cc storage/browser/fileapi/file_writer_delegate_unittest.cc BUG=656607 Review-Url: https://codereview.chromium.org/2845073002 Cr-Commit-Position: refs/heads/master@{#467647}
-
rego authored
Intent-to-ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V3RNBhQelSg BUG=617371 Review-Url: https://codereview.chromium.org/2840183002 Cr-Commit-Position: refs/heads/master@{#467646}
-
tnagel authored
In https://chromium-review.googlesource.com/#/c/32606/ VPD cache files have been migrated to unencrypted stateful and symlinks have been placed in the original locations for backward compatibility. This CL updates the file locations inside Chrome so that we may eventually get rid of the symlinks and can drop the exceptions for them, cf. https://crbug.com/655606. BUG=none Review-Url: https://codereview.chromium.org/1736493002 Cr-Commit-Position: refs/heads/master@{#467645}
-
vitaliii authored
TBR=yoshiki@chromium.org BUG=715963 Review-Url: https://codereview.chromium.org/2848613002 Cr-Commit-Position: refs/heads/master@{#467644}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2841643003 Cr-Commit-Position: refs/heads/master@{#467643}
-
dvadym authored
This CL has only interface for saving sync passwords in PasswordStore and passing this call to PasswordReuseDetector. Implementation is complex and probably will consist of many CLs, but having interface unblocks other parts. Tests will be added with implementation. BUG=657041 Review-Url: https://codereview.chromium.org/2846823002 Cr-Commit-Position: refs/heads/master@{#467642}
-
fdoray authored
[The CL seems to have been reverted because of flakes when the first patch set was sent to the CQ dry run. These flakes were fixed in the second patch set (the one that landed).] The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=asanka@chromium.org Review-Url: https://codereview.chromium.org/2835303002 Cr-Original-Commit-Position: refs/heads/master@{#467397} Committed: https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc021852585abb0df35b5 Review-Url: https://codereview.chromium.org/2835303002 Cr-Commit-Position: refs/heads/master@{#467641}
-
perezju authored
Story shows a high failure rate on many different perf bots. TBR=nednguyen@google.com BUG=715936 Review-Url: https://codereview.chromium.org/2848573002 Cr-Commit-Position: refs/heads/master@{#467640}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fc61514c..05751f9b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2851453002 Cr-Commit-Position: refs/heads/master@{#467639}
-
vitaliii authored
Revert of Use TaskScheduler instead of blocking pool in file_downloader.cc. (patchset #2 id:20001 of https://codereview.chromium.org/2835303002/ ) Reason for revert: "FileDownloaderTest.DontOverwrite" is flaky. crbug.com/715964 Original issue's description: > Use TaskScheduler instead of blocking pool in file_downloader.cc. > > The blocking pool is being deprecated in favor of TaskScheduler. > > BUG=667892 > R=asanka@chromium.org > > Review-Url: https://codereview.chromium.org/2835303002 > Cr-Commit-Position: refs/heads/master@{#467397} > Committed: https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc021852585abb0df35b5 TBR=asanka@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=667892,715964 Review-Url: https://codereview.chromium.org/2847553004 Cr-Commit-Position: refs/heads/master@{#467638}
-
nednguyen authored
* Fix include: 1) handle cases thread_times = None 2) disable testBlinkPerfTracingMetricsForMeasureTime on Win This CL adds support for tracing metrics with measureTime & measureFrameTime methods in blink_perf harness. If a test has "tracingCategories" & "traceEventsToMeasure" fields specified, Telemetry will enable the specified tracing categories & compute the cpu time of all the specified trace events (one per test run). Detailed examples of how to use this new API are in third_party/WebKit/PerformanceTests/TestData/ BUG=701059, 715822 TBR=wangxianzhu@chromium.org Reviewer: you can see this in action by patching this CL & run: ./tools/perf/run_benchmark --browser=system blink_perf.testing --story-filter=frame --output-format=json [ RUN ] append-child-measure-time.html ... ... CPU times of trace event "UpdateLayoutTree": values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000, 2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms avg 2.0804000000 ms CPU times of trace event "FrameView::layout": values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000, 5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms avg 5.1440000000 ms [ RUN ] color-changes-measure-frame-time.html ... ... CPU times of trace event "FrameView::prePaint": values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000, 6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms avg 6.3357777778 ms CPU times of trace event "FrameView::paintTree": values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000, 30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms avg 30.4702222222 ms After running the command above, the command also produces 2 trace files locally, one for each test. Review-Url: https://codereview.chromium.org/2819343002 Cr-Commit-Position: refs/heads/master@{#467445} Committed: https://chromium.googlesource.com/chromium/src/+/0d2d43615b4553f00ac711f54dbcc0835f04366b patch from issue 2819343002 at patchset 270001 (http://crrev.com/2819343002#ps270001) Review-Url: https://codereview.chromium.org/2844133002 Cr-Commit-Position: refs/heads/master@{#467637}
-
peter authored
BUG=715691 Review-Url: https://codereview.chromium.org/2844043002 Cr-Commit-Position: refs/heads/master@{#467636}
-
zakerinasab authored
* createImageData() and getImageData() must return an ImageData for which the color space and storage format matches those of canvas. If canvas pixel format is "float16", the storage format of the returned ImageData must be "float32". Values must be properly converted from float16 to float32. * putImageData must do the color conversion from the color space and storage format of given ImageData to the color space and matching pixel format of canvas prior to putting data into the canvas. BUG=704155,709777 Review-Url: https://codereview.chromium.org/2797213002 Cr-Commit-Position: refs/heads/master@{#467635}
-
pmarko authored
Enables client certificate patterns for EAP-TLS networks in device ONC policy. Device-wide client certificate patterns are restricted to only match certificates which are present in the system token. This prevents the device from presenting the user's certificates involuntarily. Two supporting changes were made to achieve this: - CertLoader has been extended by the system_cert_list() method to retrieve available certificates which exist on the system token. - The ClientCertConfig struct has a new onc_source member which can be checked to see if the client cert pattern originates from device policy. BUG=655266 TEST=unit_tests && chromeos_unittests Manual test scenario: -- Prerequisites: Install a certificate (subject common name e.g.: “cert_user”) into the user token and a different certificate (subject common name e.g.: “cert_system”) into the system token. Have a EAP-TLS wifi network connected to a radius server which would accept both client certificates. -- Test Case 1: device policy ONC / user token certificate Configure a device policy OpenNetworkPolicy to connect to the EAP-TLS network with "ClientCertPattern": { "Subject": { "CommonName": "cert_user" } Expected result: The device does not try to auto-connect to the wifi network because the ClientCertPattern originating from device policy does not match user certificates. -- Test Case 2: device policy ONC / system token certificate Configure a device policy OpenNetworkPolicy to connect to the EAP-TLS network with "ClientCertPattern": { "Subject": { "CommonName": "cert_system" } Expected result: The device auto-connects to the wifi network because the ClientCertPattern originating from device policy matches certificates present on the system token. It authenticates with cert_system. -- Test Case 3: user policy ONC / user token certificate Configure a user policy OpenNetworkPolicy to connect to the EAP-TLS network with "ClientCertPattern": { "Subject": { "CommonName": "cert_user" } Expected result: The device auto-connects to the wifi network. It authenticates with cert_user. -- Test Case 4: user policy ONC / system token certificate Configure a user OpenNetworkPolicy to connect to the EAP-TLS network with "ClientCertPattern": { "Subject": { "CommonName": "cert_system" } Expected result: The device auto-connects to the wifi network. It authenticates with cert_system. Review-Url: https://codereview.chromium.org/2828713002 Cr-Commit-Position: refs/heads/master@{#467634}
-
altimin authored
Move several safe-looking task types to suspendable task runner. More task types will be moved to suspendable task runner, but we'll start with this set and will monitor any problems (there were some perfbot failures when all task queues were moved to suspendable task runner). R=haraken@chromium.org CC=skyostil@chromium.org BUG=702160 Review-Url: https://codereview.chromium.org/2808273003 Cr-Original-Commit-Position: refs/heads/master@{#464025} Committed: https://chromium.googlesource.com/chromium/src/+/78a049660074003b8e1e602b0e7783ca7f1f4ee0 Review-Url: https://codereview.chromium.org/2808273003 Cr-Commit-Position: refs/heads/master@{#467633}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 Review-Url: https://codereview.chromium.org/2839973002 Cr-Commit-Position: refs/heads/master@{#467632}
-
isandrk authored
In crrev.com/2794803003 I introduced a bug that caused "Load unpacked extension" screen (available under chrome://extensions) to not display any files. This CL fixes it. BUG=707864 Review-Url: https://codereview.chromium.org/2840043002 Cr-Commit-Position: refs/heads/master@{#467631}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/822954dd..fc61514c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2843373002 Cr-Commit-Position: refs/heads/master@{#467630}
-
keishi authored
BUG=699269 Review-Url: https://codereview.chromium.org/2841383002 Cr-Commit-Position: refs/heads/master@{#467629}
-
peconn authored
I think it was accidentally removed in https://codereview.chromium.org/2825133002. BUG= Review-Url: https://codereview.chromium.org/2851433002 Cr-Commit-Position: refs/heads/master@{#467628}
-
maxmorin authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/ce4e632..f66bef3 $ git log ce4e632..f66bef3 --date=short --no-merges --format=%ad %ae %s 2017-04-27 magjed@webrtc.org ObjC: Split out NV12 texture uploading into separate class 2017-04-27 glaznev@webrtc.org Support adding and removing MediaRecorder to camera 2 session. 2017-04-26 deadbeef@webrtc.org Allow a received audio codec's payload type to change. 2017-04-26 henrik.lundin@webrtc.org NetEq: Add a VoidAudioSink tool 2017-04-26 deadbeef@webrtc.org Don't crash if STUN error message is missing ERROR-CODE attribute. 2017-04-26 henrik.lundin@webrtc.org NetEq: Limit payload size for replacement audio input 2017-04-26 philipel@webrtc.org Stashed frames are now retried in a loop rather than recursively. 2017-04-26 henrik.lundin@webrtc.org NetEq: Add functionality to assist with delay analysis and tooling 2017-04-26 oprypin@webrtc.org Fix redirecting to local AppRTC server in video quality test 2017-04-26 sakal@webrtc.org Pause changing surface size when rendering is paused. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2849503002 Cr-Commit-Position: refs/heads/master@{#467627}
-
hayato authored
BUG=715414 Review-Url: https://codereview.chromium.org/2843363002 Cr-Commit-Position: refs/heads/master@{#467626}
-
gambard authored
Add the possibility to have month and years in time format. A year is defined as 365 days. A month is defined as 1year / 12. '1 month' means more than one month and less than two month (same for years). CL mainly made by olivierrobin BUG=694451 Review-Url: https://codereview.chromium.org/2845693002 Cr-Commit-Position: refs/heads/master@{#467625}
-