GitLab

Use the properly-named "WebRuntimeFeatures::enableCSSViewport" method
to enable the CSS viewport feature instead of wrongly-named "setCSSViewportEnabled".

BUG=424459

Review URL: https://codereview.chromium.org/669673003

Cr-Commit-Position: refs/heads/master@{#300264}

BUG=

Review URL: https://codereview.chromium.org/655253003

Cr-Commit-Position: refs/heads/master@{#300263}

BUG=425097
TBR=zhaoqin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/668703002

Cr-Commit-Position: refs/heads/master@{#300262}

Here is the OWP tracking bug: https://code.google.com/p/chromium/issues/detail?id=422984
Here is the link to the entry on the feature dashboard: https://www.chromestatus.com/features/4871530282483712

Currently canvas clips are not antialiased which differs what what other
browsers are doing and what the users expect. This CL starts surfacing
the desired antialiased clipping behavior behind a flag
so developers can start assessing the capability.

This needs to land after the Blink CL: Plumb in flag to enable antialiased clipping in HTML 5 Canvas - https://codereview.chromium.org/652483003/

BUG=crbug.com/424291
BUG=crbug.com/422984

Review URL: https://codereview.chromium.org/650143002

Cr-Commit-Position: refs/heads/master@{#300261}

Prefix CheckLibraryLoadFromApkSupport()'s result log line with
__FUNCTION__, for logging clarity.

Remove stray empty line.

BUG=390618

Review URL: https://codereview.chromium.org/659313005

Cr-Commit-Position: refs/heads/master@{#300260}

BUG=

Review URL: https://codereview.chromium.org/661183003

Cr-Commit-Position: refs/heads/master@{#300259}

Revert of New run shell implementation for DeviceUtils (patchset #8 id:140001 of https://codereview.chromium.org/659533002/)

Reason for revert:
Broke some telemetry telemetry unittests and perf unittests

Original issue's description:
> New run shell implementation for DeviceUtils
>
> The main differences are:
> - it uses AdbWrapper.Shell to actually execute the command.
> - when the cmd is supplied as a list of a command and its arguments,
>   the arguments are quoted to prevent them from being (mis)interpreted
>   by the shell.
> - a new single_line option to check that the output produces contains a single line, and return the value of that line.
>
> BUG=267773
>
> Committed: https://crrev.com/ab18bcca0cc1475cf381211e595e75c1146c9115
> Cr-Commit-Position: refs/heads/master@{#300237}

TBR=jbudorick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=267773

Review URL: https://codereview.chromium.org/666943002

Cr-Commit-Position: refs/heads/master@{#300258}

Cr-Commit-Position: refs/heads/master@{#300257}

When checking a class if it or its part objects don't define GC roots,
avoid looping on part objects that are cyclic. i.e., the part object
containing a collection that refers back to itself.

R=haraken
BUG=424962

Review URL: https://codereview.chromium.org/666473003

Cr-Commit-Position: refs/heads/master@{#300256}

The Web IDL spec specifies Promise<T> syntax. This CL makes the IDL parser
recognize the syntax.

BUG=421539

Review URL: https://codereview.chromium.org/653343002

Cr-Commit-Position: refs/heads/master@{#300255}

Origin database of FileSystem API performs special handling for Apps V2.
This CL updates dump_file_system to support it.

BUG=421330
NOTRY=True

Review URL: https://codereview.chromium.org/636093002

Cr-Commit-Position: refs/heads/master@{#300254}

Port all client of the NOTIFICATION_HISTORY_URL_VISITED to instead be
HistoryServiceObserver or HistoryBackendObserver depending on the thread
they want the notification to be delivered.

Delete the notification and the notification details types.

BUG=373326
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/651193002

Cr-Commit-Position: refs/heads/master@{#300253}

In particular LLVM_SYMBOLIZER_PATH is needed by asan_symbolize.py.

Also explicitly wait for test launcher to finish running and use its return
code as an overall exit code of the test. asan_symbolize.py always returns
0 (if it doesn't crash), not very useful.

BUG=424280
R=earthdok@chromium.org

Review URL: https://codereview.chromium.org/639713009

Cr-Commit-Position: refs/heads/master@{#300252}

Revert of Added quota client for serviceworker. Enables 'clear past <time> data'. (patchset #7 id:300001 of https://codereview.chromium.org/633273002/)

Reason for revert:
causing crashes https://code.google.com/p/chromium/issues/detail?id=424831

Original issue's description:
> Added quota client for serviceworker. Enables 'clear past <time> data'.
>
> BUG=419287
>
> Committed: https://crrev.com/f6916df879bf23bacf994880359c980f4249e324
> Cr-Commit-Position: refs/heads/master@{#299918}

TBR=michaeln@chromium.org,jsbell@chromium.org,sky@chromium.org,dmurph@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=419287

Review URL: https://codereview.chromium.org/654323003

Cr-Commit-Position: refs/heads/master@{#300251}

Remove unnecessary includes for forward-declared classes in both
refcounted_browser_context_keyed_service_factory.h and
browser_context_keyed_service_factory.h.

Fix other header files broken by this cleanup by addding the
missing include.

BUG=419366
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/662803002

Cr-Commit-Position: refs/heads/master@{#300250}

The telemetry test for WebRTC has so far been measuring CPU and memory.
Since there's a stats API for WebRTC (see http://goo.gl/lfQKzE), we try
to use that do extract interesting properties about the call. The
properties we look at are such that we expect them to remain stable, so
a sudden change in any of them will warrant investigation.

This implementation is based on a trick where we instrument the
constructor for webkitRTCPeerConnection. Whenever a peer connection is
constructed, we attach a polling function which periodically polls the
connection for new stats (that's how the stats API works). Then we
make it easy for a measurement to extract this data, aggregate it into
time series and report it through Telemetry.

BUG=412787

Review URL: https://codereview.chromium.org/561803002

Cr-Commit-Position: refs/heads/master@{#300249}

The comment for IPC_ENUM_TRAITS_MAX_VALUE says you should pass the largest
possible value, inclusive. But NTP_NUM_EVENT_TYPES is one larger than the
largest possible NTPLoggingEventType.

Review URL: https://codereview.chromium.org/662823002

Cr-Commit-Position: refs/heads/master@{#300248}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/468b181..93b255b

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/662373002

Cr-Commit-Position: refs/heads/master@{#300247}

BUG=425057
TBR=mflodman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/660473004

Cr-Commit-Position: refs/heads/master@{#300246}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/833fa84..ccbca44

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/666893002

Cr-Commit-Position: refs/heads/master@{#300245}

Hopefully it would fix mysterious crashes of browser_tests under ASAN
on Swarming mac. runtest.py (that is NOT used by Swarming) does set
LLVM_SYMBOLIZER_PATH already. Looks like this bit of logic wasn't copy-pasted
into test_env.py.

BUG=424280
R=earthdok@chromium.org,glider@chromium.org

Review URL: https://codereview.chromium.org/665873002

Cr-Commit-Position: refs/heads/master@{#300244}

This class is no longer needed in anticipation of moving the scheduler
from Blink to the content layer.

BUG=391005

Review URL: https://codereview.chromium.org/640803003

Cr-Commit-Position: refs/heads/master@{#300243}

The adb_logcat_* scripts are extract attached devices names with
pattern 'w+', but it only works for real devices. Emulated devices
have names in form of 'emulator-5554' and '-' sign is not matched
by 'w+' parrent. This causes to logcat output to be missed while
tests are running

R=frankf@chromium.org, craigdh@chromium.org

TEST=Run tests with only emulators attached, ensure that resulting
log contains logcal output

Review URL: https://codereview.chromium.org/661843003

Cr-Commit-Position: refs/heads/master@{#300242}

As a first step just move it from chrome_content_browser client
to the desktop_notification_service.

BUG=392187

Review URL: https://codereview.chromium.org/660293002

Cr-Commit-Position: refs/heads/master@{#300241}

In unit tests for MidiManager, RunLoop was used, and is used to wait
a posted task finished. But, RunUntilIdle() can not be called
multiple times. To avoid this restriction, we can just create new
instance again for another iteration.

TEST=media_unittests

Review URL: https://codereview.chromium.org/656793004

Cr-Commit-Position: refs/heads/master@{#300240}

BUG=none

Review URL: https://codereview.chromium.org/658033003

Cr-Commit-Position: refs/heads/master@{#300239}

Make the 'char' to 'unsigned char' to fix the following build failure.

device/hid/hid_connection_unittest.cc: In member function ‘virtual void device::HidConnectionTest_ReadWrite_Test::TestBody()’:
device/hid/hid_connection_unittest.cc:166:23: error: array subscript has type ‘char’ [-Werror=char-subscripts]
       buffer->data()[j] = i + j - 1;
                       ^
device/hid/hid_connection_unittest.cc:179:285: error: array subscript has type ‘char’ [-Werror=char-subscripts]
       ASSERT_EQ(i + j - 1, read_callback.buffer()->data()[j])

Review URL: https://codereview.chromium.org/664983002

Cr-Commit-Position: refs/heads/master@{#300238}

The main differences are:
- it uses AdbWrapper.Shell to actually execute the command.
- when the cmd is supplied as a list of a command and its arguments,
  the arguments are quoted to prevent them from being (mis)interpreted
  by the shell.
- a new single_line option to check that the output produces contains a single line, and return the value of that line.

BUG=267773

Review URL: https://codereview.chromium.org/659533002

Cr-Commit-Position: refs/heads/master@{#300237}

Chrome4ChromeOS for Linux packages needs pNaCl but it is not part of package
so make it downloadable when running on Linux. In Chrome OS PNaCl is part of
rootfs.

BUG=422121
TEST=manual

Review URL: https://codereview.chromium.org/662713006

Cr-Commit-Position: refs/heads/master@{#300236}

This switch prevents the app list from being dismissed when it loses
focus (which is helpful when testing the app list or a launcher page).
The other dismissal methods (eg Esc) still work. Honoured on Linux and
Windows only.

BUG=405400

Review URL: https://codereview.chromium.org/661003003

Cr-Commit-Position: refs/heads/master@{#300235}

Use 0x00 rather than 0x30 ('0') to pad the DATA frame to be comply with the
HTTP/2 spec.

This lands server change 77448497 by raullenchai.

BUG=345769

Review URL: https://codereview.chromium.org/654253004

Cr-Commit-Position: refs/heads/master@{#300234}

The async result of net_request_->Read() in ServiceWorkerWriteToCacheJob::ReadNetData() is passed to ServiceWorkerWriteToCacheJob::OnReadCompleted().
In current code the case when bytes_read is 0 is not handled correctly.
So when bytes_read is 0 the script loading will hang.

LayoutTest is here: https://codereview.chromium.org/650193003

I hope this patch will reduce the test flakiness :)

BUG=419999
TEST=http/tests/serviceworker/chromium/load-flushed-script.html

Review URL: https://codereview.chromium.org/640923003

Cr-Commit-Position: refs/heads/master@{#300233}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d12af70..468b181

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/662973002

Cr-Commit-Position: refs/heads/master@{#300232}

This patch remembers the observed entries in preferences, so they are restored
after a reboot.

Note, that more tests will come after a refactoring out writing to preferences
from Service, which is coming soon/

TEST=unit_tests, browser_tests: *FileSystemProvider*RememberFileSystem*, *FileSystemProvider*RestoreFileSystem*
BUG=248427

Review URL: https://codereview.chromium.org/658313002

Cr-Commit-Position: refs/heads/master@{#300231}

As discussed on chromium-os-dev [1], if there is no fsync() after writing to the
temp file, atomicity is not guaranteed.  Thus, to be able to guarantee
atomicity, we must check the return value of Flush() and bail in case Flush()
wasn't successful.

I'll update the UMA histogram enum in a separate CL.

[1] https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/chromium-os-dev/Eef8gNIRwjc

BUG=none

Review URL: https://codereview.chromium.org/663463002

Cr-Commit-Position: refs/heads/master@{#300230}

This CL fixes an issue causing the app list to render without any apps
when shown in an RTL language.

BUG=422604

Review URL: https://codereview.chromium.org/656343003

Cr-Commit-Position: refs/heads/master@{#300229}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e862ddb..833fa84

TBR=

Review URL: https://codereview.chromium.org/662303002

Cr-Commit-Position: refs/heads/master@{#300228}

TBR=grt@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/666713002

Cr-Commit-Position: refs/heads/master@{#300227}

Revert of Support modal windows (patchset #4 id:80001 of https://codereview.chromium.org/662763002/)

Reason for revert:
Reverting because this CL because WithOrWithoutTargeter.* introduced a memory leak and made all of the Athena Asan tests fail http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)

Based on tools/lsan/suppressions.txt reverting is now preferred over adding a suppression

Original issue's description:
> Support modal windows
>
> * New ContainerParams
>  -  default_parent to specify the default parent when no
>     transient parent is specified.
>  - modal_container_priority now controls the modal container
>    used for a modal window created for the given container.
>  - if not specified, it will fallback downwards to find one.
>  - if window is specified as always_on_top, it will use top
>    most modal container.
>
> * Changed network selector/shutdown dialog to use the new API.
>
> * Other change:
>  Separated test windows to athena/test/base/test_windows.h
>
> BUG=410499
> TBR=sky@chromium.org,reed@chromium.org
> TEST=coverd by unit tests
>
> Committed: https://crrev.com/4903fd36b2b36f00efeb1b7bba81b7de6e9457a3
> Cr-Commit-Position: refs/heads/master@{#300192}

TBR=mukai@chromium.org,sky@chromium.org,reed@chromium.org,oshima@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410499

Review URL: https://codereview.chromium.org/665803003

Cr-Commit-Position: refs/heads/master@{#300226}

Revert of Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (patchset #1 id:1 of https://codereview.chromium.org/661303002/)

Reason for revert:
The removal of Telemetry's retry logic wasn't the cause of the intermittent crashes on the GPU bots.

Original issue's description:
> Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (patchset #2 id:20001 of https://codereview.chromium.org/659753003/)
>
> Reason for revert:
> Possible cause of gpu telemetry bot flake
>
> Original issue's description:
> > [Telemetry] Set the number of attempts to retry a test to 1
> >
> > **SHERIFFS: if telemetry perf tests on waterfall become more flaky, this patch can be safely reverted.
> >
> > BUG=422339
> >
> > Committed: https://crrev.com/f5b75f261be7779ccca14d09ddaabb3e4ee5ee03
> > Cr-Commit-Position: refs/heads/master@{#299716}
>
> TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=422339
>
> Committed: https://crrev.com/1c141bedc45cdef1ac7b7264ea1288c33e33d106
> Cr-Commit-Position: refs/heads/master@{#300218}

TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com,hendrikw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=422339

Review URL: https://codereview.chromium.org/662963002

Cr-Commit-Position: refs/heads/master@{#300225}