- 29 Jul, 2020 40 commits
-
-
David Roger authored
This CL passes the profile color and the text color from native (C++) to WebUI. The text color is computed to have good contrast with the background. Light color and light mode: https://drive.google.com/file/d/1A1tdffEMp2I0zwk2fofD59_GCSY59s67/view?usp=sharing Light color and dark mode: https://drive.google.com/file/d/1FCTLApc_z5JT1tSC2yzKilSBZyzIUpbP/view?usp=sharing Dark color and light mode: https://drive.google.com/file/d/1HeH2iFhUdRMXFX6yUJOcHX68u5JfGmpF/view?usp=sharing Dark color and dark mode: https://drive.google.com/file/d/1ZYHFAcHIsU1Qa96aMsT0nalZR3an9Yjm/view?usp=sharing Bug: 1076880 Change-Id: I4ee51b8f1d178e57d3e6375b75affa72ae8e5582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324422 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#792670}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0320db93. With Chromium commits locally applied on WPT: 3bd086b0 "Make CSP default-src without 'unsafe-eval' block eval in iframes" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I28b101bf67dbaacf026407ef0ee23fc07549caf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324323Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792669}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a8af6641ce8e..14ca9390e34a 2020-07-29 dberris@chromium.org Revert "auto-triage: Revision range url support non-chromium revision" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1106244 Tbr: eseckler@google.com Change-Id: I987e4fa0e2243998b9eedc32cb1af7e45101fa31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325903Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792668}
-
Oleg Davydov authored
This commit moves expire date of the following histograms: * Extensions.ExtensionCacheCount * Extensions.ExtensionCacheSize Also ownership of these histograms is now in sync with other histograms related to policy-based extensions. This makes sense since cache is used on Chrome OS for them. Bug: 975705, 984259 Change-Id: Ie8d364df4cefeeb5d16ca1d7ef872c8cc7a8dcbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260640 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#792667}
-
Oleh Lamzin authored
Use closure compiler for browser tests. Fix compilation error for MessagePipe.sendMessage since it expect object or undefined. Bug: b:158566609 Change-Id: I0c3cc042d9fbfd6da801d67ac8d6f27b37ffaa48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320593 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#792666}
-
Gauthier Ambard authored
Fixed: 1106735 Change-Id: Ib40832dff0096b0c01788a9209b3bc45f440e8c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317950Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#792665}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4866d0ad5f3c..c34efe0da102 2020-07-29 thestig@chromium.org Fix use of undefined TARGET_OS_SIMULATOR for Non-Metal builds. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I3592e18d1a0f82e1358acad7eecc3c073c0adcf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325896Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0bf57c8f..3bb07848 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I618efa9bf562701eb428357f80491599d59e6700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324508Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792663}
-
David Tseng authored
The change https://chromium-review.googlesource.com/c/chromium/src/+/1980612 explicitly unloads various component extensions deemed to be risky. Unfortunately, the hash for ChromeVox (which was supposed to not be risky) was *wrong*, so it was being unloaded mysteriously. Test: obtain the hash for ChromeVox (extension id mdn....), via logging and print the hex hash. Verify after correcting the hash in profile_helper.cc, on-device, doing things like clicking the "Add Person" button doesn't unloads ChromeVox. Fixed: 1094031 Issue details: On the login screen, invoke the "Add Person" button. result: ChromeVox is unloaded i.e. #2 0x57e72acd8634 content::RenderFrameHostImpl::~RenderFrameHostImpl() #3 0x57e72acd8520 content::RenderFrameHostImpl::~RenderFrameHostImpl() #4 0x57e72b0bb120 content::RenderFrameHostManager::~RenderFrameHostManager() #5 0x57e72acd2449 content::FrameTreeNode::~FrameTreeNode() #6 0x57e72bffe68d content::FrameTree::~FrameTree() #7 0x57e72c20defa content::WebContentsImpl::~WebContentsImpl() #8 0x57e72c20e928 content::WebContentsImpl::~WebContentsImpl() #9 0x57e72c3d2490 extensions::ExtensionHost::~ExtensionHost() #10 0x57e72c3d253c extensions::ExtensionHost::~ExtensionHost() #11 0x57e72c40f857 extensions::ProcessManager::CloseBackgroundHost() #12 0x57e72c40fabe extensions::ProcessManager::OnExtensionUnloaded() #13 0x57e72c3ea211 extensions::ExtensionRegistry::TriggerOnUnloaded() #14 0x57e72c3e8f3a extensions::ExtensionRegistrar::DeactivateExtension() #15 0x57e72c3e8be7 extensions::ExtensionRegistrar::RemoveExtension() #16 0x57e72f781d0b extensions::ExtensionService::RemoveComponentExtension() #17 0x57e72f761c47 extensions::ComponentLoader::Remove() #18 0x57e72cb46908 chromeos::ProfileHelperImpl::ClearSigninProfile() #19 0x57e7304c57c1 chromeos::GaiaScreenHandler::StartClearingCookies() #20 0x57e7304c58dc chromeos::GaiaScreenHandler::ShowGaiaAsync() #21 0x57e72ca0362b chromeos::LoginDisplayHostCommon::ShowGaiaDialogCommon() #22 0x57e72ca04686 chromeos::LoginDisplayHostMojo::ShowGaiaDialog() #23 0x57e72fbfd2ef ash::LoginShelfView::ButtonPressed() #24 0x57e72f27480c views::ButtonController::OnKeyPressed() #25 0x57e72f2c2624 views::View::OnKeyEvent() #26 0x57e72f266a3b ui::ScopedTargetHandler::OnEvent() #27 0x57e72e80f1fc ui::EventDispatcherDelegate::DispatchEvent() #28 0x57e72ebb32d6 ui::EventProcessor::OnEventFromSource() #29 0x57e72e80fd89 ui::EventSource::SendEventToSinkFromRewriter() #30 0x57e72f2cf9e0 views::Widget::OnKeyEvent() #31 0x57e72e80f1fc ui::EventDispatcherDelegate::DispatchEvent() #32 0x57e72ebb32d6 ui::EventProcessor::OnEventFromSource() #33 0x57e72ebb9387 aura::WindowTreeHost::DispatchKeyEventPostIME() #34 0x57e72e8381c3 ui::InputMethodBase::DispatchKeyEventPostIME() #35 0x57e72e85f4fd ui::InputMethodChromeOS::ProcessUnfilteredKeyPressEvent() #36 0x57e72e85f24c ui::InputMethodChromeOS::DispatchKeyEvent() #37 0x57e72ebb217f aura::WindowEventDispatcher::PreDispatchKeyEvent() #38 0x57e72ebb1a28 aura::WindowEventDispatcher::PreDispatchEvent() #39 0x57e72e80eedd ui::EventDispatcherDelegate::DispatchEvent() #40 0x57e72ebb32d6 ui::EventProcessor::OnEventFromSource() #41 0x57e72e80fece ui::EventSource::EventRewriterContinuationImpl::SendEvent() #42 0x57e72c649a27 ui::EventRewriterChromeOS::RewriteKeyEventInContext() #43 0x57e72c6492fe ui::EventRewriterChromeOS::RewriteEvent() #44 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #45 0x57e72fb88588 ash::KeyboardDrivenEventRewriter::RewriteEvent() #46 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #47 0x57e72fb88e9b ash::SpokenFeedbackEventRewriter::RewriteEvent() #48 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #49 0x57e72fbec429 ash::TouchExplorationController::RewriteEvent() #50 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #51 0x57e72fb5e078 ash::AutoclickDragEventRewriter::RewriteEvent() #52 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #53 0x57e72fbdf76b ash::MagnificationController::RewriteEvent() #54 0x57e72e80fd68 ui::EventSource::SendEventToSinkFromRewriter() #55 0x57e72fb9bb93 aura::WindowTreeHostPlatform::DispatchEvent() #56 0x57e72fb9d8dc ash::AshWindowTreeHostPlatform::DispatchEvent() Change-Id: Ibead7896cecddcb3da8bb4a553137f65700248f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324108Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792662}
-
Yutaka Hirano authored
v8::Promise::Resolve can run user code synchronously, which caused a UAF in ScriptPromiseProperty. Fix it. Bug: 1108518 Change-Id: Ia9baec6eef0887323cd88ceb1d3fa0c14fdb77ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325499Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#792661}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/499d49011a1d..501bbf2a9325 2020-07-29 fmayer@google.com Merge "Add --all-heaps to heap_profile script." 2020-07-29 fmayer@google.com Merge "Allow to target all heaps." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1f852b81d468cc696c3e5957486fa153bd10eea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325895Reviewed-by:
-
Marc Treib authored
This CL parameterizes CredentialsFilterTest so that all the tests runs with features::kEnablePasswordsAccountStorage both enabled and disabled. (So far, CredentialsFilter doesn't actually depend on this feature, but it soon will, see linked bug.) Bug: 1105846 Change-Id: I389e80a0880df188c72bfb16056d04e90c029455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324844Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#792659}
-
Nohemi Fernandez authored
Several matchers that are used only within sign-in internal code have been exposed in public APIs. This causes confusion for developers on which is the correct API to use resulting in inconsistent code. Simplify the options by offering a more limited API. Bug: 1103274 Change-Id: I0c476962dd216a0ef79e1c7a17008fbcbf5deeb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324424Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#792658}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/125702be66eb..fbf20a6507ed 2020-07-29 nidhijaju@google.com Removing "other origins" UI from DevTools Service Worker tab 2020-07-29 jacktfranklin@chromium.org Fix invisible border on computed styles. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:807440 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia174692cf17ffa81d8383080ebb9d1acd893ab99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325901Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I74437d49622940df951e2f817a82f7274a383b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324676Reviewed-by:
-
Roman Sorokin authored
This CL fixes the issue when one invalid "password changed" token triggers online reauth two times - on the login screen and in the session. Check in the session happens before the new token is backfilled with the online login triggered on the login screen. So this CL adds backoff time between two consecutive checks. Also moved more relative logic into TokenHandleUtil. Fixed: 1094030 Change-Id: Ica0a9c547f14e8f0bc743fdab87fff7bf49c56c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300441 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Takashi Sakamoto authored
RegisterClient and UnregisterClient methods will be invoked in different threads at the same time. This causes ASAN crashes. Bug: 1092385 Change-Id: I67ed7fd1925bde72770c8c5b4f737258e9564de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324689 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#792654}
-
Benoit Lize authored
This CL has two purposes: - Cleaner separation between the "allocate memory" and the "cookies/tag" parts of the allocator. - Move as much code as possible outside of the spinlock-protected area. The first one is useful to make code clearer, but also to ease experimentation with a thread cache, as it doesn't need to know about tags with this breakdown. The second one improves concurrency, as for instance the zeroing of potentially large allocations (up to 1MiB) doesn't need to be protected by the spinlock. There is a side-effect though: The tag update is no longer protected by the lock. This is not an issue, as tags do not need to be unique globally (they won't anyway, due to the limited tag space). Bug: 998048 Change-Id: I301b1bc1946f01bfcea490e478fbf2bc8383aed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310410 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
Vikas Soni authored
Remove |copy_required| and replace it with an enum |copy_mode|. This is done since in future texture copy will not be always required for webview and hence |copy_required| will not always be true. When AImageReader is enabled, texture copy can be skipped and resource sharing across different context can be achieved via AHardwareBuffer. TBR=dcheng@chromium.org Bug: 1091945 Change-Id: Ie482546cc2f28128b487a55205a3c7411bc2a86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306670 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#792652}
-
Mugdha Lakhani authored
This splits part of chrome_render_frame.mojom into render_frame_prerender_messages.mojom and creates a class PrerenderRenderFrameObserver to handle the StartPrerendering mojom message. The motivation is to remove chrome deps from PrerenderContents so it can be componentized. Bug: 1096088 Change-Id: I60146c2af867e7b57de392c97e010dc481338d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324842 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#792651}
-
Henrik Boström authored
This allows us to run more tests than if we mark a single file as timing out. Important to ensure we don't cause regressions when rolling https://webrtc-review.googlesource.com/c/src/+/180481 into chromium. # TBR since I am just moving things around and want to unblock a reland TBR=hta@chromium.org Bug: chromium:1110833, chromium:1071733 Change-Id: Ib9f9cefe3fd89d764495a41a66422f191761df62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324251Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#792650}
-
Alexander Alekseev authored
DC layers are Windows-only and not useful for Ash. Bug: 1075612 Change-Id: If88a257a6cd2c889ba36914dbbfa290fc7511f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321773Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#792649}
-
dizg authored
Screenshot: https://drive.google.com/file/d/1z0MLt2zTldb5ZQIzoUc06XTQjS5ID5kx/view?usp=sharing Bug: 1105865 Change-Id: Ifccc725b28a2cc1e3d13532e61730633e0c0981c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320673Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Diana Zagidullina <dizg@google.com> Cr-Commit-Position: refs/heads/master@{#792648}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b237356836f2..a8af6641ce8e 2020-07-29 fancl@chromium.org auto-triage: Revision range url support non-chromium revision If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1106244 Tbr: eseckler@google.com Change-Id: I7c2c22f4193aebc840deb994e0c7574a3d48c162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325891Reviewed-by:
-
Philipp Hancke authored
The test does not work as intended in Firefox as described in https://bugzilla.mozilla.org/show_bug.cgi?id=1643050 since Firefox does not use the same fingerprint/certificate for different peerconnections on the same page and puts the fingerprint into the SDP sessionpart. With the change the test connects and gets video on the other end but still fails in Firefox since it relies on connectionState which is not implemented. BUG=None Change-Id: Id6529bcb32f37e657d6f79c8d94a4b69c4d15db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303391Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#792646}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c20449a879c6..592c94cd987f 2020-07-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 150be20d4334 to f9b088fe0dbf (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I06caea7c23335fb642de340290531eded5c60d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325661Reviewed-by:
-
Sergey Poromov authored
Adding OWNERS file for the directory with DLP related classes. Setting ownership to the current members of DLP team. Change-Id: I9e13a5d6f460c0feeebccaceae00d9acbaa5ffdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318226Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#792644}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/150be20d4334..f9b088fe0dbf 2020-07-29 afdx@google.com Avoid use of 'sanity' and 'sanity check' in the code base (#3585) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,tobine@google.com Change-Id: Ie9956cadd51c4258f003ad128ba7460ce1ef661c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325658Reviewed-by:
-
Danil Chapovalov authored
Bug: None Change-Id: Idfbc659b046014c4617b7523436ad5d5cb329f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302173 Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#792642}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/80398c1ad128..125702be66eb 2020-07-29 pfaffe@chromium.org Aria-label the scope entries If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0476053d9eea9af7b43e13ffb26f050e4dcf9c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325669Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9ab49585..0bf57c8f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2e86d830f039a29fcd45bb644bad48fa76c52839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325596Reviewed-by:
-
Roman Sorokin authored
This reverts commit 7930c989. Reason for revert: reasons were reconsidered Original change's description: > Chrome OS: Send board name for the first (owner) user only > > Bug: 967600 > Change-Id: I312ccfd2e11cb1c2290ae05a1c32270035dff7a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632157 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663839} TBR=xiyuan@chromium.org,rsorokin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 967600 Change-Id: I5deae35ef82304f869fada7af445a534858cc13e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325613Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792639}
-
Kim-Anh Tran authored
This removes one test as it is no longer relevant. Otherwise, updating another one following the change in devtools-frontend. Bug: chromium:1105172 Change-Id: I02dfd40dcc926aefe9cdddfa5fdecec318e26c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315857Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#792638}
-
Nick Burris authored
Create the SecurePaymentConfirmationController. In the future this will own the model and view in the MVC model, and unblocks the parallel work between the API and the UI. Bug: 1110322 Change-Id: I8db3bed2e665034fb60755216d0ae15b49253948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324165Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792637}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5b007a519a28..b88b1a15c7e4 2020-07-29 cwallez@chromium.org Revert "dawn_wire: Implement CreateBufferMapped on top of mappedAtCreation" 2020-07-29 tommek@google.com Enabling sampleMask usage in RenderPipelineMTL 2020-07-29 kainino@chromium.org CMake: add -framework Metal to dawn_native 2020-07-28 rharrison@chromium.org Enable WGSL support by default 2020-07-28 kainino@chromium.org Disable "all" warnings when compiling MSL code 2020-07-28 cwallez@chromium.org dawn_wire: Implement CreateBufferMapped on top of mappedAtCreation 2020-07-28 tommek@google.com Rolling shader deps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I568def435c550370b3790ec2bd972d63fe2c668e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325666Reviewed-by:
-
Alex Chau authored
- NearbyConnection object can only be created asynchronously when outgoing connection is created - Changed OnIncomingConnection/NearbyConnectionCallback to return NearbyConnection* as the object should be owned by NearbyConnectionsManagerImpl Bug: 1076008 Change-Id: I1af43ed530acb945b2121fd260c294b75e2e341f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321408 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#792635}
-
Mikel Astiz authored
Overriding HistoryService and BookmarkModel after the profile has been created is problematic and known to cause hard-to-debug test flakiness. Instead, this patch adopts TestingProfile::Builder. In order to do so, there needs to be a way to inject an instance of SSLHostStateDelegate to TestingProfile::Builder. Instead of exposing an explicit setter, the proposal is here is to directly integrate StatefulSSLHostStateDelegateFactory into TestingProfile, but keep the old behavior by default (i.e. delegate is null). Change-Id: I4cde502b5a0434d7023b3c7bb8e00cfe3c041c75 Bug: 1106699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310411Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#792634}
-
Ravjit Singh Uppal authored
Moved the newly added warning message for disallowed settings for flash above the toggle button. Bug: 1110359, 1073883 Change-Id: I0320602fe1deda85b1ebb95ec5a6a990a58e38aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323683Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#792633}
-
Robbie Gibson authored
Bug: 1098722 Change-Id: I70e40b221b228e120ca02e3d2ae0e47b936cb0b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315033 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792632}
-
Rushan Suleymanov authored
This patch introduces a new listener interface which will be used to receive invalidations from an FCM. The patch also implements invalidation message parsing and forwarding it to all listeners. Bug: 1082122 Change-Id: I587259af2eef7687017e40c8e7f059e62b44292a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215855 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
