GitLab

This change fixes several issues that were causing crashes.
- MediaPlayerHostMsg_DemuxerReady_Params was not initializing the xxx_codec
member variables so audio-only or video-only content would randomly be
flagged as A/V content with a random codec ID.
- ChunkDemuxer::Stop() was not being called which could cause the delegate
to be accessed after it was destroyed.
- MediaSourceDelegate was signalling that it had metadata before the 
ChunkDemuxer was even initialized. This caused the HTMLMediaElement to
signal that the load completed way too early and caused play() to be
called when the delegate wasn't ready.

BUG=233420
TEST=webkitmediasource-play.html LayoutTest reliably runs w/o crashing now.

Review URL: https://chromiumcodereview.appspot.com/15898002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202019 0039d316-1c4b-4281-b951-d872f2087c98

This is regression bug of CSS.
This CL rise the priority of CSS section that hides the search box.

BUG=243281
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/15868002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202018 0039d316-1c4b-4281-b951-d872f2087c98

To pass InstantAutocompleteResult::Type back and forth between the browser and renderer, change the data type to be AutocompleteMatchType::Type instead of an opaque string. 

BUG=239173
TEST=none

Review URL: https://chromiumcodereview.appspot.com/15517007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202017 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/15294020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202016 0039d316-1c4b-4281-b951-d872f2087c98

TBR=eseidel@chromium.org
BUG=243648

Review URL: https://codereview.chromium.org/15959005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202015 0039d316-1c4b-4281-b951-d872f2087c98

TopSitesTest was renamed to TopSitesImplTest in crrev.com/197127,
hence references to TopSitesTest no longer make sense.

BUG=180467
TEST=none

Review URL: https://chromiumcodereview.appspot.com/15823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202014 0039d316-1c4b-4281-b951-d872f2087c98

This CL drops non-informative StorageType parameter from GlobalUsageCall.
The value should be known by the original caller that makes the callback.

TEST=should not break existing test
TBR=arv@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15695003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202013 0039d316-1c4b-4281-b951-d872f2087c98

R=dpolukhin@chromium.org

Review URL: https://codereview.chromium.org/15876004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202012 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes races in case of requested reusing of windows. It might happend, that windows are not yet fully initialized and we tried to reuse them. This bug is fixed by waiting for all windows to be initialized by enqueuing the reusing logic.

TEST=Follow the bug's repro steps.
BUG=238412

Review URL: https://chromiumcodereview.appspot.com/15817002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202011 0039d316-1c4b-4281-b951-d872f2087c98

We were calling asserts withing a subroutines. In that case, asserts breaks the current subroutine but not the test case. This patch wraps calls to subroutines with ASSERT_NO_FATAL_FAILURE, which checks if it failed on any asserts, and if so, then terminates the test case.

TEST=browser_tests
BUG=235334

Review URL: https://chromiumcodereview.appspot.com/15771005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202010 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/15745017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202009 0039d316-1c4b-4281-b951-d872f2087c98

When using tile-free renderering, if ActivationStateAsValue() is called
when there is a pending tree it would hit a NULL pointer on tile_manager_.


BUG=

Review URL: https://chromiumcodereview.appspot.com/15743022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202008 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=239337
TEST=unit_tests, manual

Review URL: https://chromiumcodereview.appspot.com/15742018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202007 0039d316-1c4b-4281-b951-d872f2087c98

The "Disconnect your Google Account..." button in the settings page is
supposed to be grayed out when sync setup is in progress, as indicated
by ProfileSyncService::setup_in_progress_. Earlier, we were calling
ProfileSyncService::SetSetupInProgress(false) under all circumstances
from SyncSetupHandler::CloseSyncSetup(), but with r200867, we missed out
on setting the value to false under some conditions. One example of the
flag incorrectly remaining set to true occurs when the user enables
encryption with a custom passphrase and then clears sync data via the
dashboard.

This patch adds a call to ProfileSyncService::SetSetupInProgress(false)
from SyncSetupHandler::CloseSyncSetup() irrespective of why the settings
dialog was closed.

BUG=243078
TEST=Enable custom encryption, do a dashboard clear, and check the settings page

Review URL: https://chromiumcodereview.appspot.com/15742014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202006 0039d316-1c4b-4281-b951-d872f2087c98

The NTP puts the launch of a regular app into a different bucket than the
launch of the special webstore app. This change makes the launcher do something
analogous with the webstore and the chrome app.

Review URL: https://chromiumcodereview.appspot.com/15715003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=243035

Review URL: https://chromiumcodereview.appspot.com/15714003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202004 0039d316-1c4b-4281-b951-d872f2087c98

URLFetcherCore is now responsible to write all data stored in |buffer_|.

BUG=126753
TEST=net_unittests

Review URL: https://chromiumcodereview.appspot.com/15711003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202003 0039d316-1c4b-4281-b951-d872f2087c98

At Chrome build-time, the pnacl_component_crx_gen.py script generates a "resource info" JSON file that's placed alongside the translator nexes. We were not actually reading this file so far, but with this CL, we are. The first use is not hard-coding the ld.nexe and llc.nexe tool names in the plugin code. Instead, the tool names are read from the info file. This will allow us, in the future, to move the tool names into the native client directory so we can change them without touching Chrome at all.


BUG=None

Review URL: https://chromiumcodereview.appspot.com/15697019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202002 0039d316-1c4b-4281-b951-d872f2087c98

Currently this checkbox does nothing. The next CL will add code to request
pairing if it was checked.

BUG=156182

Review URL: https://chromiumcodereview.appspot.com/15685008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202001 0039d316-1c4b-4281-b951-d872f2087c98

Implements proper bubble non-client frame view hit testing.
Use NonClientFrameView::GetHTComponentForFrame hit testing.
(this is similar to the implementation of CustomFrameView)
Remove the |can_drag_| flag, use WidgetDelegate::CanResize().

BUG=166075
TEST=New dialog style windows resize, drag, and generally allow mouse interaction as expected.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15667004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202000 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes WebRequestAction::GetName. This is the only way to guarantee that
it returns the instanceType of the actual action as specified in the JSON
dictionary.

BUG=112155

Review URL: https://chromiumcodereview.appspot.com/15666005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201999 0039d316-1c4b-4281-b951-d872f2087c98

By this CL, TouchFile is now supported on Drive API v2. Note that if the
protocol under drive file system is gdata WAPI, it always fails.

BUG=144369
TEST=Ran unit_tests

Review URL: https://chromiumcodereview.appspot.com/15648007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201998 0039d316-1c4b-4281-b951-d872f2087c98

BUG=151701

Review URL: https://chromiumcodereview.appspot.com/15511009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201997 0039d316-1c4b-4281-b951-d872f2087c98

This CL is a first step towards supporting a build of the Aura
content shell on the native Linux framebuffer device. It sets up
the necessary defines such that an injected surface provider
dependency can vend a native surface.

BUG=178543

Review URL: https://chromiumcodereview.appspot.com/13886018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201996 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionUninstallDialogViews uses Widget::CreateWindow. 
Use DialogDelegate::CreateDialogWidget instead. 
See before/after pics at http://crbug.com/166075#c95
Trigger the dialog by clicking a trash icon at about:extensions

BUG=166075
TEST=Extension uninstall shortcut dialog does not have a black border. 
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15932002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201995 0039d316-1c4b-4281-b951-d872f2087c98

ShowCreate*ShortcutsDialog uses Widget::CreateWindow. 
Use DialogDelegate::CreateDialogWidget instead.
See before/after pics at http://crbug.com/166075#c94
Trigger the dialog by right clicking an app -> "Create Shortcuts."

BUG=166075
TEST=Update create application shortcut dialog does not have a black border.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15519002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201994 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/15974002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201992 0039d316-1c4b-4281-b951-d872f2087c98

If the user selects an autofill data model that we already know about, save that as the new default. Newly added addresses and cards will not be stickied.

Only takes effect if NOT paying with wallet.

BUG=241948

Review URL: https://chromiumcodereview.appspot.com/15500008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201991 0039d316-1c4b-4281-b951-d872f2087c98

Currently when you request an async copy of a layer as a bitmap, we
pass around the raw base::Callback. In order to add functionality to
the copy/readback mechanism, we need to pass along other parameters
such as a size to scale the copy to. Instead of passing along an
ever-growing list of parameters, wrap the base::Callback in a class
called CopyAsBitmapRequest. Then new parameters can be added to this
class.

No change in behaviour here, covered by existing tests.

R=piman
BUG=242571

Review URL: https://chromiumcodereview.appspot.com/15435003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201990 0039d316-1c4b-4281-b951-d872f2087c98

This CL begins to collect spellcheck feedback, but the only feedback actions
are PENDING and NO_ACTION. Feedback sender uploads these actions every 30
minutes. The feedback is cleared from memory when user removes misspellings
from text or every 6 hours. Follow up CLs will add the rest of the actions.

BUG=170514

Review URL: https://chromiumcodereview.appspot.com/15318004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201989 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164227
TEST=Check that LOCATION_REQUEST and LOCATION_EVENT buckets appeared in the dashboard.

Review URL: https://chromiumcodereview.appspot.com/15306005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201988 0039d316-1c4b-4281-b951-d872f2087c98

When the button is in the state of 'active', the shadow effect that makes button
look as pressed is enabled. And originally when the buttons is in the state of
'hover' or in the state of 'focused', the background color is changed.

But some drag operation let the button's state be 'active' but not 'hover' and
not 'focused'. This cause the situation the shadow effect is enabled but the
background color is not changed.

This CL updateds the CSS selector and when the button is in the state of
'active' as well as original condition, the background color is changed.

BUG=243287
TEST=manually
R=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/15873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201987 0039d316-1c4b-4281-b951-d872f2087c98

Refactor out common code between
SpdyStream::Do{SendBodyComplete,Open}().

Add comments and TODOs re. calls to SpdyStream::Delegate::OnResponseReceived() ending up
deleting the stream.

BUG=242288
R=rch@chromium.org

Review URL: https://codereview.chromium.org/15967002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201986 0039d316-1c4b-4281-b951-d872f2087c98

It still defaults to "off". This will enable the user to see synced
notifications on Mac and Linux and Chrome OS.

BUG=242652

Review URL: https://chromiumcodereview.appspot.com/15305016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201985 0039d316-1c4b-4281-b951-d872f2087c98

BUG=176541
R=erikwright, wtc

Review URL: https://chromiumcodereview.appspot.com/15080007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=180083

Review URL: https://chromiumcodereview.appspot.com/14858037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201983 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a feedback type IN_DICTIONARY. Spellcheck will send this feedback
when SpellingServiceClient returns a spellcheck result for a word that is in
user's custom spellcheck dictionary. Upcoming CLs will address collecting and
sending this type of feedback.

BUG=170514

Review URL: https://chromiumcodereview.appspot.com/15934002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201982 0039d316-1c4b-4281-b951-d872f2087c98

R=isherman@chromium.org
BUG=173505
TEST=unit_tests, no sued
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/14904002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201981 0039d316-1c4b-4281-b951-d872f2087c98

How about ?
Access the USB device X from Y

If X is missing:
Access the USB device from Y

If both are missing:
Access the USB device 

BUG=229697

Review URL: https://chromiumcodereview.appspot.com/14473014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201980 0039d316-1c4b-4281-b951-d872f2087c98

Make Autofill SyncableServices use a backend interface for DB work, rather than calling WebDataService directly.

This will (eventually) allow WebDataService to live entirely on the UI Thread, and also ensures that we don't expose any more of the backend functionality than is needed by the SyncableServices.

(depends on: https://codereview.chromium.org/14679005/)

BUG=230920

Review URL: https://chromiumcodereview.appspot.com/14081043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201979 0039d316-1c4b-4281-b951-d872f2087c98