- 09 Mar, 2018 40 commits
-
-
Scott Violet authored
Prior to this a client could only be embeded once. This is because Embed() takes a WindowTreeClient and a pipe can only be used once (well, you could remove the pipe and supply it to embed again, but that effectively cancels the first embedding). This is the following sequence: 1. Client A requests a token from the server. 2. Client A hands the token to client B using some other mechanism. 3. Client B calls EmbedUsingToken with the token from client A. 4. The server notifies Client A it has a new embed point. BUG=none TEST=covered by tests Change-Id: I45ce155a759ae070a34897e515ca3fe0414d0167 Reviewed-on: https://chromium-review.googlesource.com/952092Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#542165}
-
wutao authored
We want to measure the latency between a key event to the time of the presentation of next UI frame. However, we do not save the time stamp in ui::Accelerator. This cl saves the time stamp information when ui::Accelerator is created from KeyEvent. Bug: 817116 Test: AcceleratorTest and AcceleratorStructTraitsTest Change-Id: If4812a491e16371cf32adae8d7074232dc3c05d8 Reviewed-on: https://chromium-review.googlesource.com/956526Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#542164}
-
Ted Choc authored
BUG=817567 Change-Id: Ic9c599df1b2e3245b1d480cea29271c8d0f673a8 Reviewed-on: https://chromium-review.googlesource.com/956253Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#542163}
-
Tom Sepez authored
Controlled by --enable-features=PdfIsolation, default is off. Stricter than required (full origin, not eTLD+1). Add pdf_extension_test for multiple domains. A subsequent patch may attempt to apply this to secure origins only. Bug: 809614 Change-Id: Ic38c2c5074c7723210e38a754b930fb152c031b7 Reviewed-on: https://chromium-review.googlesource.com/953979Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#542162}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d2a27a19. With Chromium commits locally applied on WPT: 946e66a2 "Add http-state cookie tests from abart/http-state github repository" 61d26e9d "[PE] Add "image/apng" to supported image MIME types" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13522 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dgrogan@chromium.org: external/wpt/css/css-tables TBR=foolip No-Export: true Change-Id: I09d96b1eb5f2c972c5aba12e1b0181564064ad24 Reviewed-on: https://chromium-review.googlesource.com/957128 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#542161}
-
Daniel Erat authored
Update PowerManagerClient to listen for the new ScreenBrightnessChanged D-Bus signal emitted by powerd, which contains a protobuf and replaces the earlier BrightnessChanged signal. Also update Chrome to decode protobufs from KeyboardBrightnessChanged signals. Bug: 811138 Change-Id: If313801aa516850d904540736a2dee63bac7d6e7 Reviewed-on: https://chromium-review.googlesource.com/952578 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#542160}
-
mrefaat authored
update comment in it returns a shallow copy of the configuration. WKWebViewConfigurationProvider: :GetWebViewConfiguration to indicate that Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I85286fec068683ebe923e53d3e39b7d852abf281 Reviewed-on: https://chromium-review.googlesource.com/956693Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#542159}
-
prasadv authored
Change-Id: Ic2443109057207e8c31f3747b92f3457cd68998c Reviewed-on: https://chromium-review.googlesource.com/956701Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Prasad Vuppalapu <prasadv@chromium.org> Cr-Commit-Position: refs/heads/master@{#542158}
-
Charles Harrison authored
Currently we copy hosts + other state for every outgoing request to the UI thread before doing per-WebContents aggregation there. This can involve a lot of copying of data around. This CL adds some initial per-frame aggregation beforehand to reduce this. Also, we add a browsertest for this functionality, since none previously existed. Bug: 813445 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I33438bdd5d4cab9caf3fcd07419fef3f7153935e Reviewed-on: https://chromium-review.googlesource.com/951743Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#542157}
-
John Abd-El-Malek authored
Bug: 706030 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I82f817cae6477e2e2bcbb44f266ae0956e55182a Reviewed-on: https://chromium-review.googlesource.com/956091Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#542156}
-
Jose Dapena Paz authored
-Wcomment gives too many false positives in the case a backslash ended comment line is followed by a new line of comments: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61638 Bug: 819294 Change-Id: I3c809aa7ce9f232775b58d153d45d81ad27880e4 Reviewed-on: https://chromium-review.googlesource.com/944409Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#542155}
-
Patrick Monette authored
Bug: 819790 Change-Id: Ib5b1031bf23c211199693abcf614e0b9934214fb Reviewed-on: https://chromium-review.googlesource.com/952202Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#542154}
-
Stephen Chenney authored
The code that set the size of the container for the fallback image is using the missing image's style's width and height, setting it directly on the replaced container. But the style's sizes are zoomed while the replaced container style should be pre-zoom. Fix it. R=pdr@chromium.org BUG=813417 Change-Id: I230f45442dfbd5936e820633bcf85f387a0a82fb Reviewed-on: https://chromium-review.googlesource.com/956502Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#542153}
-
Mohamed Heikal authored
Some resources listed in R.java start with a 0x01 prefix/package id. These resources should not have their package id rewritten when in webview mode. Change-Id: If3957c4bf2b5e34b5ceeb7589f7ca4e960cdd43f Reviewed-on: https://chromium-review.googlesource.com/952097Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#542152}
-
rbpotter authored
Custom margins text boxes were incorrectly not accepting decimal inputs, due to a regression in delimiter value computation. Fix regression and add test. Bug: 819806 Change-Id: I73093bbd0193e388cfc29b92f5397e0b73a9f23d Reviewed-on: https://chromium-review.googlesource.com/954711 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#542151}
-
Hongchan Choi authored
This reverts commit a6bf420a. Reason for revert: Compilation error. https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FAndroid_CFI%2F185%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout TBR=cjgrant Original change's description: > VR: Add initial UI sound support > > This change wires up button hover and click sounds, and adds them to the > asset structure. > > BUG=812026 > R=tiborg > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Iccf113e74663201c62aa220c7e134990369fd755 > Reviewed-on: https://chromium-review.googlesource.com/953962 > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542109} TBR=vollick@chromium.org,cjgrant@chromium.org,tiborg@chromium.org Change-Id: I76dc098547a55502b8d38a96320a55e48132ed05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 812026 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/955827Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#542150}
-
Hongchan Choi authored
This reverts commit 83931b97. Reason for revert: Compilation failure https://ci.chromium.org/buildbot/chromium.memory/Android%20CFI/185 Original change's description: > [vr] Add compatibility to component 1.y, check integrity of WAV files > > Bug: 811987 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I5c33b4210727b62357e0706c7b19800b98bdebc4 > Reviewed-on: https://chromium-review.googlesource.com/956251 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542128} TBR=waffles@chromium.org,cjgrant@chromium.org,tiborg@chromium.org Change-Id: I99aab2f842e064e34ff92cc29501aedc05164b13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811987 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/955828Reviewed-by:
-
Miguel Casas authored
This reverts commit e330bcb6. Reason for revert: typo forced using EGL VaapiPictures, bad! Original change's description: > vaapi: split VaapiDrmPicture into common and ozone/egl parts > > This CL splits VaapiDrmPicture into a common part named > VaapiPictureNativePixmap, and two subclasses, namely: > - VaapiPictureNativePixmapOzone, containing the current > #if defined(USE_OZONE) sandwiched parts, and > - VaapiPixtureNativePixmapEgl with the other parts. > > So the class tree should look like: > > +-----------------+ > | VaapiPicture | > +-----------------+ > ^ ^ > | +----+ > +--------------+ +------------------+ > | VaapiPicture | | VaapiPictureTFP | > | NativePixmap | | (existing on ToT)| > +--------------+ +------------------+ > ^ > +---------------+ > | | > +-------+ +-------+ > | VPNP | | VPNP | > | Ozone | | Egl | > +-------+ +-------+ > > The point here is to reduce the amount of if-defs to one single > point, the VaapiPictureFactory. > > BUILD.gn is changed to reflect that VaapiDrmPicture is > egl-specific (see bug, |use_egl| definition in [1]), while > VaapiDrmPictureOzone is |use_ozone| [2] specific. Note > that |use_egl| can coexist with |use_x11| [3]. > > This CL just moves code around, no new code introduced in > either vaapi_picture*.cc. > > [1] https://cs.chromium.org/chromium/src/ui/gl/features.gni?q=ui/gl/features.gni&sq=package:chromium&dr&l=16 > [2] https://cs.chromium.org/chromium/src/build/config/ui.gni?q=build/config/ui.gni&sq=package:chromium&dr&l=26 > [3] https://cs.chromium.org/chromium/src/build/config/ui.gni?type=cs&sq=package:chromium&l=47 > > Bug: 785201 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I67f6f4d994322ef7f23a8ed255405963a4be0152 > Reviewed-on: https://chromium-review.googlesource.com/951928 > Reviewed-by: Julien Isorce <julien.isorce@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542107} TBR=posciak@chromium.org,kcwu@chromium.org,mcasas@chromium.org,chcunningham@chromium.org,acourbot@chromium.org,julien.isorce@chromium.org Change-Id: If5103a891bcf6f758feea44cc514503457f00fbc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 785201 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/957322Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#542148}
-
Katie D authored
This updates the way STS handles text areas that have a 'value' and no children, i.e. text areas that are in the native UI. Bug: 820184 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id8d9d7609812209920273c8ca1a29ee332532dfc Reviewed-on: https://chromium-review.googlesource.com/956351Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#542147}
-
https://webrtc.googlesource.com/src.git/+log/6d72c3258ff5..5a98049f6abe $ git log 6d72c3258..5a98049f6 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I502fdfa4b4ef5751bcec026de6ee7d824b84e2d8 Reviewed-on: https://chromium-review.googlesource.com/956117Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542146}
-
Antonio Gomes authored
This CL brings no functionality changes, to makes the CL [1] that will bring external window mode capabilities to Mus slightly smaller. In summary it: - removes a loose include in mus_demo_external.h - adds a setter for the WindowTreeHostMus in WindowTreeData class, as a protected member (to be used by WindowTreeDataExternal in [1]) and uses it. - Conditions WindowTreeData::IsInitialized to 'window_delegate_' rather than to 'window_tree_host_'. Reason: after [1], window_tree_host_ will be initialized earlier on, and not reflect a WindowTreeData instance actually be initialized anymore. BUG=666958 [1] https://crrev.com/c/955782 Change-Id: Ifec202d2217cfeafd9a13c7811610fbe450b9937 Reviewed-on: https://chromium-review.googlesource.com/957143Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#542145}
-
erikchen authored
This CL removes several memory metrics that are not being used. These are: * Memory.{ProcessType}Count * Memory.*.Committed * Memory.Renderer{Shrink,Growth}In30Min * Memory.Swap.* The memory metrics actively being used and developed are emitted in ProcessMemoryMetricsEmitter. These are emitted in both UMA and UKM form. The UKM form implicitly includes ProcessType, though with less granularity. Both the UMA and UKMs include PrivateMemoryFootprint, a cross-platform consistent metric that supercedes Memory.*.Committed. There is no replacement for Memory.Renderer{Shrink,Growth}In30Min. Bug: 765470 Change-Id: I857f710eeb3ddf233b63be3139ea90ebe8d9a5c9 Reviewed-on: https://chromium-review.googlesource.com/952985Reviewed-by:Keishi Hattori <keishi@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#542144}
-
Matthew Jones authored
This reverts commit 99c1a2c3. Reason for revert: Causes bugs 820349 & 816858 Original change's description: > Update tab switcher state in ToolbarPhone after animation completes > > Previously onTabSwitcherTransitionFinished was only called when > exiting the tab switcher. This change implements > onOverviewModeFinishedShowing to call this method. > > BUG=710750 > > Change-Id: I1a34551a6cd93a54a9461441c25ce022144efa9e > Reviewed-on: https://chromium-review.googlesource.com/929991 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539205} TBR=dtrainor@chromium.org,tedchoc@chromium.org,mdjones@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 710750 Change-Id: Ia5dd268f289f1fbb5bb0e0614c6242ec905a4ecc Reviewed-on: https://chromium-review.googlesource.com/956937Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#542143}
-
edchin authored
Bug: 804587, 804585 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I108e2c93f2d089133f1f0e1ad065770a032737f1 Reviewed-on: https://chromium-review.googlesource.com/953203 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#542142}
-
Colin Blundell authored
This CL creates //components/services as the canonical location of Mojo services within //components. It adds documentation and an OWNERS file. This CL also moves //components/font_service to //components/services/font as the first step to getting all existing services in //components into the canonical location. The existing code there has a bunch of presubmit warnings. This CL does not attempt to fix them. This CL will be followed by changes to restore naming consistency: - A change that moves the FontService Mojo interface to FontLoader, which is a more appropriate name - A change that renames the font_service service to font and adjusts namespaces accordingly NOPRESUBMIT=true TBR=dcheng@chromium.org Change-Id: I0cd668726d9841e6ef47a703c0042a7ec7d17833 Reviewed-on: https://chromium-review.googlesource.com/948855Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This change: 1) Makes BrowserActionTestUtil into an interface instead of a concrete class; 2) Adds two implementations: BrowserActionTestUtilCocoa (for Cocoa windows) and BrowserActionTestUtilViews (for Views windows); 3) Adds BrowserActionTestUtil::Create as a factory function to create an instance of the appropriate concrete class depending on which browser window type is in use; 4) Migrates all uses of BrowserActionTestUtil's constructors to that factory function; 5) Links both implementations of BrowserActionTestUtil into polychrome builds Bug: 810479, 817408 Change-Id: I68eb74c6dd4fa58d9d064b3b942a620fd0f8a81b Reviewed-on: https://chromium-review.googlesource.com/956026 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542140}
-
Torne (Richard Coles) authored
Some apps will need to use the new APIs added in P to configure their data directories properly, and won't be able to call these on older OS versions until the support library is ready. For now, relax the check to only apply when running on P. Bug: 558377 Change-Id: I57b9889c7e486acb1ebbd6642dfb45eca38b6a06 Reviewed-on: https://chromium-review.googlesource.com/955727Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#542139}
-
Theresa authored
Replace the NTP sections for bookmarks and downloads with buttons. Also enables scroll-to-load when the sections are hidden. Hidden behind a feature flag, UX polish to follow. BUG=818463 Change-Id: I439aabfc75c9857476be9f6f90557f1d000044b3 Reviewed-on: https://chromium-review.googlesource.com/956494 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#542138}
-
Andrew Grieve authored
Failing due to too many classes in the main dex list. TBR=fgorski Bug: 820361 Change-Id: I11f0f913467a77751d267bd51e58210043d666d3 Reviewed-on: https://chromium-review.googlesource.com/956115Reviewed-by:
-
Jay Civelli authored
Adding a test Unzip service that disconnects when accessed to simulate crashers. It will be used in a follow up CL to ensure extension installation deals correctly with the unzip service crashing. Bug: 799220 Change-Id: I511b591e5740ac4c0e64f63d7b28cd32173a4990 Reviewed-on: https://chromium-review.googlesource.com/955930Reviewed-by:
-
Yash Malik authored
Bug: 818266 Change-Id: Ib7a2d04fa8182f623ea07eedf0a6f4aef8516d8d Reviewed-on: https://chromium-review.googlesource.com/955343 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#542135}
-
Geoff Lang authored
BUG=811828 BUG=811794 BUG=811791 BUG=811823 BUG=811871 BUG=811830 BUG=812108 BUG=811867 BUG=811817 BUG=811800 BUG=811826 BUG=811833 BUG=811805 BUG=811824 BUG=811793 BUG=811868 BUG=811783 BUG=811818 BUG=811788 BUG=811784 TBR=jbudorick@chormium.org Change-Id: I30cb916dec2984d5deac4b38ad50425dcf075e97 Reviewed-on: https://chromium-review.googlesource.com/956698Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542134}
-
https://chromium.googlesource.com/catapult.git/+log/8f3d6b77acab..b90b97cf8dec $ git log 8f3d6b77a..b90b97cf8 --date=short --no-merges --format='%ad %ae %s' 2018-03-02 perezju Reland "[Telemetry] Store Android backend settings as namedtuples" Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I7ac217979b7cc88b0247c6fdadab8aa63e416ba7 Reviewed-on: https://chromium-review.googlesource.com/957102Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542133}
-
Josh Karlin authored
Bug: 817365 Change-Id: I106d6b49c78f66b47a37d7f429b62b506ea5a225 Reviewed-on: https://chromium-review.googlesource.com/951823 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#542132}
-
Aaron Leventhal authored
When switching to a tab that has the Omnibox or other UI focused, screen readers do not read the title of the document being navigated to. For the case where a tab is switched, and the UI is about to be focused, fire an extra focus event on the widget's root view so that the document title is read before the UI focus. TBR: tsepez@chromium.org Bug: 791757 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I19a91eaac1c24dfd04ab3458a41aaa0c512a8739 Reviewed-on: https://chromium-review.googlesource.com/938778 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#542131}
-
Fady Samuel authored
In device emulation mode, the top level renderer devtools lies to Blink about the size and scale factor by constructing an emulated ScreenInfo object. Prior to this patch, we propagated that ScreenInfo down to OOPIFs and BrowserPlugins. This caused double scaling of the compositor viewport size in OOPIFs because the top level renderer had already scaled down the surface embedded. This CL instead plumbs down the original ScreenInfo which fixes the device emulation problem. Bug: 819903, 672962 Change-Id: Ie32c2798edcbe8738c463edf86d45c86f33d0d5b Reviewed-on: https://chromium-review.googlesource.com/956554 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542130}
-
Amirhossein Simjour authored
DropdownPopupWindow uses AnchoredPopupWindow instead of using ListPopupWindow. This should potentially fix the positioning problem of DropdownPopupWindow. BUG=809758 Change-Id: I246aca46f28b0c71cccadee3d7d12208f6f58268 Reviewed-on: https://chromium-review.googlesource.com/923426 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
Bug: 811987 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5c33b4210727b62357e0706c7b19800b98bdebc4 Reviewed-on: https://chromium-review.googlesource.com/956251Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542128}
-
Gauthier Ambard authored
This CL changes the creation of the view used to simulate the background of the NTP during stack view animation so it is unvisible at the creation. Bug: 819795 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia59dea3ff4902b21ad1fa097d0bb3c7210d41b93 Reviewed-on: https://chromium-review.googlesource.com/956071Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#542127}
-
Simeon Anfinrud authored
When using a CastWebContentsFragment, the host activity will determine the audio focus state. Only request audio focus in CastWebContentsActivity so that if the activity on Android TV launches while another app is playing media, the old app will stop playing when CastWebContentsActivity becomes visible. Bug: Internal b/73952032 Test: cast_shell_junit_tests Change-Id: I109ef227706c6e2ed9273b70a57029ddd1d6b248 Reviewed-on: https://chromium-review.googlesource.com/956272Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542126}
-
