- 14 Sep, 2018 40 commits
-
-
Robert Ogden authored
This is used to notify the Android ToolbarManager that the LoFi preview was opted-out of and the UI should no longer be shown to the user. Bug: 883388 Change-Id: I8151fa96adeb7d0afe4c0122a3a4cf10bb546e24 Reviewed-on: https://chromium-review.googlesource.com/1222410 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#591527}
-
Adam Langley authored
Change-Id: Ib6c4ae24146e435585fe1ba064e26002d49b8f9c Reviewed-on: https://chromium-review.googlesource.com/1224953Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#591526}
-
Etienne Pierre-Doray authored
Tls affects result of GetLastError on windows. To avoid interaction with base::File, last error is saved and restored in the destructor of ScopedBlockingCall. Bug: 874080 Change-Id: Id17ac4e7ee4ffaf33eda30784b86ad41e21b8b96 Reviewed-on: https://chromium-review.googlesource.com/1220172 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#591525}
-
Kevin Marshall authored
Allows PathService's APP_DATA path to be dynamically overriden, for handling incognito, persistent, and browsertest cases. Remove GetPackageRoot() and replace it with PathService getter calls. Add hooks to allow browser test suites to override how APP_DATA is configured. BUG=798851 Change-Id: I465d5801f3237d37e84011ae2f83b7efa6258c18 Reviewed-on: https://chromium-review.googlesource.com/1227406Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#591524}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6d5f1bc2e846..4a4632264eb9 git log 6d5f1bc2e846..4a4632264eb9 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 dnovillo@google.com Add IR dumping functions to use during debugging. 2018-09-14 antiagainst@google.com Add support for VK_KHR_shader_atomic_int64 in validator Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@4a4632264eb9 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic024fb44b8649e0e8f8f5a5a17f18d543aea8926 Reviewed-on: https://chromium-review.googlesource.com/1227232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591523}
-
Vladislav Kaznacheev authored
Currently ChromeOS is using existing Chrome resource icons to represent Web Store app in the system UI (Launcher and Shelf). There is a new requirement for ChromeOS app icons to be compliant with Material Design guidelines (crbug.com/848007). Adding a set of icons that satisfy the requirement. Bug: 882176 Test: manual Change-Id: Ie6ef8653bf6daac3e514a79610634fd898b7349f Reviewed-on: https://chromium-review.googlesource.com/1219234Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#591522}
-
Alex Moshchuk authored
This CL removes the logic that triggered process swaps in ChromeExtensionsRendererClient::ShouldFork() for the case when the main frame reloads a URL for which a hosted app was just installed or uninstalled. This logic isn't needed with --site-per-process, as that mode will already force a process transfer. This is covered by AppApiTest.ReloadIntoAppProcess and AppApiTest.ReloadIntoAppProcessWithJavaScript, which still pass with that logic removed. This CL also makes a fix on the browser side to keep this logic working even without --site-per-process, by unconditionally checking HasWrongProcessForURL() and forcing a process transfer if needed in IsRendererTransferNeededForNavigation(). This is possible because with PlzNavigate we will always go to the browser process and check for transfers, even without --site-per-process. With that fix, the above two tests also pass without --site-per-process. The above tweak also has a side effect of swapping processes when an app opens a cross-site, non-app popup (also made possible by work on issue 794315) in non-site-per-process mode, which seems acceptable and desirable - no reason for the cross-site popup to be in a process with app permissions. Bug: 883550, 883549, 718516 Test: AppApiTest.ReloadIntoAppProcess and AppApiTest.ReloadIntoAppProcessWithJavaScript keep working, with and without --site-per-process. Change-Id: Ibac63fff3a36318fabceb593ca7ae7967eefad89 Reviewed-on: https://chromium-review.googlesource.com/1226075Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#591521}
-
Kevin Bailey authored
Adds 2 histograms related to tab switch metrics: whether a suggestion offered a tab switch, and whether the offer was accepted. Bug: 854714 Change-Id: I9019909d0435efed3ec5f4dbdd31ebbb63c9db68 Reviewed-on: https://chromium-review.googlesource.com/1220268Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#591520}
-
Mina Almasry authored
Bug: b/115732685 Test: Manual Change-Id: I6ced3f247e2e099c92b9773c09d67fdbe0a7e015 Reviewed-on: https://chromium-review.googlesource.com/1227390 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#591519}
-
Chris Palmer authored
This somewhat relaxes the limitation, enabling more legitimate use-cases while still seemingly being low enough to contain abuse. Also, expressing the limitation in terms of FPS makes the limit less arbitrary. 8 FPS for history modification comports with other performance and functionality goals (like 60 FPS for graphics). Bug: 394296 Change-Id: Ic8edd8c3af57dc4436c71f9c03fb26face4114d7 Reviewed-on: https://chromium-review.googlesource.com/1220042 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#591518}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4dc8c50f81bd..59d2a590a5fc git log 4dc8c50f81bd..59d2a590a5fc --date=short --no-merges --format='%ad %ae %s' 2018-09-14 tsepez@chromium.org Rename FPDF_RenderPage_Retail() to RenderPageWithContext() Created with: gclient setdep -r src/third_party/pdfium@59d2a590a5fc The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3a5001368eea83429b2ce01fa7ebe108eaa46ede Reviewed-on: https://chromium-review.googlesource.com/1227231Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591517}
-
Aga Wronska authored
Skip showing expanded login view and start Public Session right away after user clicks the button on login view. Use default locale and input method. This change applies only to views login. Bug: 882692 Test: Manually + run ash_unittests Change-Id: I85945e813cf61dd84008fab05a4a2dce728d0939 Reviewed-on: https://chromium-review.googlesource.com/1226254 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#591516}
-
Maks Orlovich authored
This should hopefully prevent the writer from falling behind the work queue, and if it does, should limit the memory use --- even if the writer is totally wedged. Credit to Helen Li for the idea. Bug: 809199 Change-Id: Ie9a080b613e3c0fd6a27006e66736e4252d2c920 Reviewed-on: https://chromium-review.googlesource.com/1217039 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#591515}
-
Chris Harrelson authored
This improves BGPT testing to take into account layer position updates due to PAC, and also reduces GraphicsLayer size a little bit. It exposes gfx::PointF directly to some code in core, but that is ok because we already decided that gfx types are ok in core and this is just for SPv1 compositing. Bug: 883949 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6c0423aa66e94c24e96331381e6523ba1fb574b6 Reviewed-on: https://chromium-review.googlesource.com/1227301Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591514}
-
Daniel Cheng authored
This reverts commit 27986c7c. Reason for revert: r590596 should have fixed this in a more robust way. Original change's description: > Speculative fix for additional History DocumentLoader crashes. > > There is no guarantee that the DocumentLoader is always attached [1], > so let's introduce null checks in StateInternal and setScrollRestoration. > > [1] The DocumentLoader may be detached while FrameLoader::PrepareForCommit. > > BUG=879477, 872672 > > Change-Id: I048ad8ff3787fcead262c19fcdb485e9e5a5e3bf > Reviewed-on: https://chromium-review.googlesource.com/1200075 > Commit-Queue: Charlie Reis <creis@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588227} TBR=creis@chromium.org,japhet@chromium.org,kouhei@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 879477, 872672 Change-Id: I1dd77d355f42269b70bb53ce19dcb3e1ecb0f15e Reviewed-on: https://chromium-review.googlesource.com/1227392Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#591513}
-
Dana Fried authored
Bug: 866513 Change-Id: I92abdf6f00cb59ef3c7193a3543a41a2fe4b4b6b Reviewed-on: https://chromium-review.googlesource.com/1227364Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#591512}
-
Robert Ogden authored
This DCHECK is especially annoying when testing on localhost when the server is not HTTPS. This changes the DCHECK to be a lot simpler. Open to other ideas to the same effect but the only alternative seems to be DCHECKing the finch param which doesn't seem better or worse. Bug: 864635 Change-Id: Icf7b12991acd2c6bab2cd13c4a40ff4bef1dcee1 Reviewed-on: https://chromium-review.googlesource.com/1227353Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#591511}
-
Dan Sanders authored
This CL completes plumbing a path for creating a MojoVideoDecoder via a render thread, and uses it to construct an RTCVideoDecoderAdapter if --enable-features=RTCVideoDecoderAdapter,MojoVideoDecoder is configured. Bug: 857111 Change-Id: Ia40b571c07cb7070150ec7c3d35320e051eb75ca Reviewed-on: https://chromium-review.googlesource.com/1226430Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#591510}
-
Alex Moshchuk authored
This only checked for the kContentShellAlwaysFork switch, which seems to be unused. Bug: 883549 Change-Id: Ib9e5e9df79caaa0e2d6cda8457b84cf4d391064c Reviewed-on: https://chromium-review.googlesource.com/1226462Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#591509}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4230d4847fdc..62114aae8550 git log 4230d4847fdc..62114aae8550 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 courtneygo@google.com glBufferSubData: Exit early if size is zero Created with: gclient setdep -r src/third_party/angle@62114aae8550 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I5fc59ba1aeefeb44b62f149eaebbd400b84b80da Reviewed-on: https://chromium-review.googlesource.com/1227371Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591508}
-
Ian Kilpatrick authored
This patch does a few things: 1) Introduces the concept of a "ReplacedPercentageResolutionSize". This is needed as replaced descandants of table cells have a different percentage resolution size than normal descendants. 2) This adds a bunch of special cases for how percentage resolution sizes are handled for table cells. 3) Adds the "scrollable" children of table cell quirk. This is during the "measure" phase, scrollable children contribute nothing to the size of the cell. 4) Adds the "box-sizing: border-box" table cell quirk. That is percentage children, during the layout phase, are sized as if they have box-sizing: border-box on them. It was easier to perform all these changes as a single monolithic patch to ensure correct behaviour. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I881a21662bfdf6b4ab7a0f62df6970143008ebca Reviewed-on: https://chromium-review.googlesource.com/1207890 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#591507}
-
Parastoo Geranmayeh authored
Part of the profile validation pipeline: Previously, we were only doing profile data validation on client side. Now we have two sources of validation: client and server. We need both. (The functions of the autofill profile are renamed accordingly.) Change-Id: Id930c667cacb512858fda4dd78268174d754159a Reviewed-on: https://chromium-review.googlesource.com/1205098 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#591506}
-
Min Qin authored
This serves as a base class for us to send UI updates for both download and offline items Bug: 881499 Change-Id: I54e50191764f9796250be02c7461cb96b9fa85a6 Reviewed-on: https://chromium-review.googlesource.com/1226456 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591505}
-
Chris Palmer authored
Bug: None TBR: rsesek,kinuko,kouhei Change-Id: I2dda1e9ed0bcdf822a3d310a1654fded31eb8038 Reviewed-on: https://chromium-review.googlesource.com/1227355Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#591504}
-
Gang Wu authored
Implement error handling in content storage, and change callback in java to lambda. Bug: 884230 Change-Id: I0dd9999dc221e7fb4d030d2b8f56d16482b04985 Reviewed-on: https://chromium-review.googlesource.com/1226079Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591503}
-
Justin DeWitt authored
It was getting a bit cluttered in ExploreSitesBridge, so this creates an ExploreSitesBridgeExperimental that contains all the code required for the "experiment" version (that is still in use behind a flag.) Bug: None Change-Id: Ie5575d1960ef7016a08f7b4eff56327fa15ce1d7 Reviewed-on: https://chromium-review.googlesource.com/1227216 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#591502}
-
Alexei Filippov authored
During thread exits TLS clears its storage vector. If after that a memory is allocated/deallocated profiler hooks gets triggered and access the TLS which makes it reallocate the storage vector that is then never deallocated. The patch makes profiler do not rely on base::ThreadLocalStorage and use the OS primitives directly. BUG=881352,803276 Change-Id: I8493768e57e4121c9ce38d09c77f8d38b04941b3 Reviewed-on: https://chromium-review.googlesource.com/1225280Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#591501}
-
Wenzhao Zang authored
Because views login hasn't implemented the code path to transition between web-ui OOBE to views-login directly, the web-ui public session pod is shown one-time only right after the enrollment completes. So for this bug, we should implement the web-ui and views versions separately. Bug: 882692 Change-Id: Ia3945b2dbfdb3a2e38db4d59c74248a29004bf37 Reviewed-on: https://chromium-review.googlesource.com/1226256Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#591500}
-
Fady Samuel authored
In a prior CL, GraphicsPipeline Metrics were added to AsyncLayerTreeFrameSink but the browser process does not use that when OOP-D is off. This CL adds those metrics to DirectLayerTreeFrameSink in order to allow us to do comparisons in Finch trial. Bug: 881262 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I8d3a7c41603d1b84e8d72ef530189b7864361c40 Reviewed-on: https://chromium-review.googlesource.com/1227141Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#591499}
-
Kenneth Russell authored
Up to version 7.14.1.1210, per customer report of poor behavior. Bug: 879098 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I29f5b3b501d2ff17572bcab1d490d4c308f398f3 Reviewed-on: https://chromium-review.googlesource.com/1218445 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#591498}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/41562c7c..7a02a8fc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic79b20ecf2943d3f2f64aa99630f0bb98b9bcdb4 Reviewed-on: https://chromium-review.googlesource.com/1227308Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591497}
-
John Chen authored
Update parsing of proxy settings in session capabilities, for W3C compliance. Changes include: * Handle noProxy containing a list of strings. * Handle socksProxy and socksVersion. * Return kInvalidArgument for errors. Bug: chromedriver:2537 Change-Id: I545291b8249e147f75babee5dfe72137bfc4cdca Reviewed-on: https://chromium-review.googlesource.com/1226096Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#591496}
-
Justin DeWitt authored
This is implemented by adding a GetCatalogTask that has a few jobs: * Return the current catalog * Update the current catalog if there is one in the DB and it's the first time the catalog was requested since Chrome started. Also removes the "usable_on_ntp" boolean column from the sql store as it doesn't have a clear use in the design doc. Bug: 867488 Change-Id: I17ff725633f13e57a542e7e48fcf974a1ae1a3d1 Reviewed-on: https://chromium-review.googlesource.com/1226193 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#591495}
-
Evan Stade authored
Some strings are only used by //chrome and can be moved to //chrome/app string targets. Some are used by //chrome and //ash and are moved to //chromeos/chromeos_strings.grd Bug: 756095 Change-Id: If7b3b89486035d36505f6d133b35593d10570f20 Reviewed-on: https://chromium-review.googlesource.com/1213585Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#591494}
-
Caleb Rouleau authored
It is currently set to 10 minutes, which means that test suites will time out first so we don't get a chance to provide a useful error message. It also makes reproing issues difficult because you need to wait for 10 minutes for them. Note that because of various retries, this could amount to 60 seconds of total time because of 2 ChromeDriver retries * 3 higher level retries. Bug: b/115528744 Change-Id: I15753fd5ac27e5d5ec36aa4f81a1a80133f4d6ff Reviewed-on: https://chromium-review.googlesource.com/1227307Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#591493}
-
Min Qin authored
TBR=dtrainor@chromium.org BUG=884280 Change-Id: Idb8b32c3f7418017bd0f6f7bae1e89f14cd2a060 Reviewed-on: https://chromium-review.googlesource.com/1225898Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#591492}
-
Joey Arhar authored
Bug: 877519 Change-Id: I738d6f7f871413e2df493bc7918538be441464e0 Reviewed-on: https://chromium-review.googlesource.com/1219990 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#591491}
-
Khushal authored
In the case where the image cache is used with a color type other than N32, the software cache performs the original decode in the target color type followed by a scale operation. While the GPU cache always decodes to N32, scales it and then performs the color type conversion. Switch the GPU cache to have the same behaviour as software cache. R=ericrk@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0199eefbc19b6038e2439d53946af0608afd498c Reviewed-on: https://chromium-review.googlesource.com/1223337Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#591490}
-
James Cook authored
The test has been disabled for 5 years. Bug: 316334 Change-Id: I34e4e0ebb407220cec9294a513b164f18e2af135 Reviewed-on: https://chromium-review.googlesource.com/1226160Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#591489}
-
Sky Malice authored
Bug: 866126 Change-Id: Ib6af1a8ae3e21354bef52257447dc9c2268aea8a Reviewed-on: https://chromium-review.googlesource.com/1222875 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591488}
-