GitLab

The BackgroundSyncManager is the class that handles registration of
background syncs. This first CL handles storage and retrieval of
registrations and sequential ordering of async operations. Future CLs
will add permission checks and incorporate a scheduler.

Eventually the BackgroundSyncManager will be created and owned by the
BackgroundSyncMessageFilter, which will be owned by the RenderViewHost.

BackgroundSync Design Doc: https://docs.google.com/document/d/1MAuNzV0q5FporLZVJMh7CMrwTHwcZsWX6YUwPwKMGco/

BUG=449443

Review URL: https://codereview.chromium.org/950343006

Cr-Commit-Position: refs/heads/master@{#322375}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/36352bf..ce86687

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1032983002

Cr-Commit-Position: refs/heads/master@{#322374}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a81080d..211c921

TBR=loislo@chromium.org

Review URL: https://codereview.chromium.org/1020743004

Cr-Commit-Position: refs/heads/master@{#322373}

The PIEX library has been submitted to official chrome repository.
The CL let Files.app use the library to load RAW thumbnails.

BUG=396702
TEST=None

Review URL: https://codereview.chromium.org/1034713002

Cr-Commit-Position: refs/heads/master@{#322372}

Cr-Commit-Position: refs/heads/master@{#322371}

BUG=371368, 470848
TBR=eugenis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1038803003

Cr-Commit-Position: refs/heads/master@{#322370}

Revert of Enable distance field text on Android. (patchset #1 id:1 of https://codereview.chromium.org/884793003/)

Reason for revert:
Apparently causing significant perf regressions in thread_times.key_silk_cases.

Original issue's description:
> Enable distance field text on Android.
>
> Sets the Android default for Ganesh-rendered text to use signed distance fields.
> The non-Android default still disables distance fields.
>
> BUG=446722
> OWNERS=jam@chromium.org
>
> Committed: https://crrev.com/58c4e746a47894de46dbfaa978f163d2072df7e0
> Cr-Commit-Position: refs/heads/master@{#320272}

TBR=vangelis@chromium.org,vmiura@chromium.org,djsollen@chromium.org,robertphillips@chromium.org,jam@chromium.org,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=446722

Review URL: https://codereview.chromium.org/1034153002

Cr-Commit-Position: refs/heads/master@{#322369}

Review URL: https://codereview.chromium.org/1036883002

Cr-Commit-Position: refs/heads/master@{#322368}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/05035d4..36352bf

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1014853007

Cr-Commit-Position: refs/heads/master@{#322367}

Reason for revert:
Changing the first output of grd file caused build to fail due to a bad depfile. Now depfile depends on a stampfile instead of first output.
Hence this also adds an additional grit roll from r187 to r188.

Effective grit roll from r186:r188

188: Allow depending on stamp for grit files.
187: Add a Policy template writer that generates Android resources which can be exposed through Android's App Restriction Schema.

Original issue's description:
> Revert of Add i18n support for Android App Restrictions. (patchset #7 id:120001 of https://codereview.chromium.org/865573002/)
>
> Reason for revert:
> Broke some GN builds, e.g.:
>
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/24483/steps/compile/logs/stdio
> http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/11092/steps/compile/logs/stdio
>
> ninja: Entering directory `/mnt/data/b/build/slave/Linux_GN/build/src/out/Release'
> ninja:error: expected depfile 'gen/chrome/policy_templates.d' to mention 'gen/chrome/app/policy/common/html/am/chrome_policy_list.html', got 'gen/chrome/app/policy/linux/examples/chrome.json'
>
>
> Committed: https://crrev.com/27ee0fa9afe9cb97016e532bd0cecd1b011251b9
> Cr-Commit-Position: refs/heads/master@{#319773}

BUG=450548

Review URL: https://codereview.chromium.org/997523002

Cr-Commit-Position: refs/heads/master@{#322366}

Tested with the following command lines on Linux:

$ gn gen out-gn --args=enable_nacl=true
$ ninja -C out-gn nacl_loader_unittests

Note: There are still many link errors with this target. They will be
addressed in followup patches.

BUG=432959
TEST=see above
R=bradn@google.com,dpranke@chromium.org
TBR=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/1034723002

Cr-Commit-Position: refs/heads/master@{#322365}

While the exceptions of the deprecated MEDIASTREAM are no longer used (and were migrated to MEDIASTREAM_MIC and MEDIASTREAM_CAMERA exceptions), the default value is still used.

This CL:
1. Replaces MEDIASTREAM default checks with MIC or CAMERA checks in contexts where only one of the two permissions is required.
2. Replaces MEDIASTREAM default checks with both MIC and CAMERA in contexts where both of the permissions are required.
3. Replaces any write of MEDIASTREAM default with write of both MIC and CAMERA.

This CL does not get rid of the MEDIASTREAM content setting entirely. This is because:
1. There is a mapping between content settings and sections in chrome://settings/content. The media part is mapped to MEDIASTREAM.
2. There is a mapping between content settings and icons shown in the omnibox when the content settings are queried. The icon shown for both camera and microphone is mapped to MEDIASTREAM.

However, after this CL is applied, the MEDIASTREAM content setting will only be used in the above circumstances, never to set or get a value.

To avoid complicated syncing between MEDIASTREAM value on old versions and MEDIASTREAM_MIC, MEDIASTREAM_CAMERA on new versions of Chrome, this CL will not land until crbug.com/452388 is resolved.

TESTED=UI,policy
BUG=464382

Review URL: https://codereview.chromium.org/965103004

Cr-Commit-Position: refs/heads/master@{#322364}

public_configs is the non-deprecated name of direct_dependent_configs.

BUG=None
TEST=gn gen out-gn
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/1034063002

Cr-Commit-Position: refs/heads/master@{#322363}

This test now only use 2 peerconnections. Furthermore, it only creates one mediastream that is sent from pc1 to pc2. When the stream is playing on pc2, it is cloned and sent back to pc1. The purpose of this refactoring is no reduce the CPU requirement and the number of streams sent to fix flakiness problems.

This cl removes the test CanForwardRemoteStream720 since it test the same thing as CanForwardRemoteStream but with a higher video resolution.

BUG=469819

Review URL: https://codereview.chromium.org/1032953002

Cr-Commit-Position: refs/heads/master@{#322362}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c1a6e5d..a81080d

TBR=loislo@chromium.org

Review URL: https://codereview.chromium.org/1008473005

Cr-Commit-Position: refs/heads/master@{#322361}

BUG=470082

Review URL: https://codereview.chromium.org/1015243004

Cr-Commit-Position: refs/heads/master@{#322360}

BUG=464993

Review URL: https://codereview.chromium.org/1035793002

Cr-Commit-Position: refs/heads/master@{#322359}

BUG=

Review URL: https://codereview.chromium.org/1034693003

Cr-Commit-Position: refs/heads/master@{#322358}

No functional change.

Review URL: https://codereview.chromium.org/1038493003

Cr-Commit-Position: refs/heads/master@{#322357}

Currently, when adding an alternative service with a new host, that host will
become the canonical host (if appropriate), override previous canonical hosts
for the same domain.  This CL adds a test to document this behavior.

BUG=392575

Review URL: https://codereview.chromium.org/1006813015

Cr-Commit-Position: refs/heads/master@{#322356}

Revert of precache: Move the java files into //components/precache/android (patchset #5 id:120001 of https://codereview.chromium.org/1031003003/)

Reason for revert:
This broke downstream chrome for android.  Coordination with chrome os is required. See bug for more details.

Original issue's description:
> precache: Move the java files into //components/precache/android
>
> This moves code out of //java/apps/chrome/.../precache into:
>   . //components/precache/android/: classes that provide information about
>     device-state, network connectivity etc.
>   . //chrome/android/.../precache/: precache service and service launchers.
>
> BUG=401552
>
> Committed: https://crrev.com/efb5a13547940947b2c8f42a4e9ed64d45bdd2d2
> Cr-Commit-Position: refs/heads/master@{#322298}

TBR=bengr@chromium.org,yfriedman@chromium.org,thestig@chromium.org,sadrul@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=401552

Review URL: https://codereview.chromium.org/1032273004

Cr-Commit-Position: refs/heads/master@{#322355}

This cl depends on https://codereview.chromium.org/1036743003/.

BUG=466871

Review URL: https://codereview.chromium.org/1030103003

Cr-Commit-Position: refs/heads/master@{#322354}

I'm removing these stats upstream since they aren't used for the
CPU-adaptation mechanism we're using in WebRTC.

BUG=
R=phoglund@chromium.org

Review URL: https://codereview.chromium.org/1032303002

Cr-Commit-Position: refs/heads/master@{#322353}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9b70ee9..c1a6e5d

TBR=loislo@chromium.org

Review URL: https://codereview.chromium.org/1016273008

Cr-Commit-Position: refs/heads/master@{#322352}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b09c6a7d..d125e47c

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=jkummerow@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1032973002

Cr-Commit-Position: refs/heads/master@{#322351}

BUG=469633

Review URL: https://codereview.chromium.org/1021413004

Cr-Commit-Position: refs/heads/master@{#322350}

BUG=452495, 452492

Review URL: https://codereview.chromium.org/1023813003

Cr-Commit-Position: refs/heads/master@{#322349}

Revert of Update V8 to version 4.3.56. (patchset #1 id:1 of https://codereview.chromium.org/1005693012/)

Reason for revert:
number of crashes in DevTools layout tests

3605	  if (p->owner()->identity() != CODE_SPACE) return false;
(gdb) bt
#0  IsOnInvalidatedCodeObject (addr=<optimized out>) at ../../v8/src/heap/mark-compact.cc:3605
#1  v8::internal::SlotsBuffer::UpdateSlotsWithFilter (this=0x51d8988d820, heap=0x51d892af040) at ../../v8/src/heap/mark-compact.cc:4725
#2  0x0000000001bf4a3f in UpdateSlotsRecordedIn (heap=0x51d892af040, buffer=<optimized out>, code_slots_filtering_required=<optimized out>) at ../../v8/src/heap/mark-compact.h:330
#3  v8::internal::MarkCompactCollector::EvacuateNewSpaceAndCandidates (this=0x51d892b4fc8) at ../../v8/src/heap/mark-compact.cc:3761
#4  0x0000000001be8838 in v8::internal::MarkCompactCollector::SweepSpaces (this=0x51d892b4fc8) at ../../v8/src/heap/mark-compact.cc:4448
#5  0x0000000001be745f in v8::internal::MarkCompactCollector::CollectGarbage (this=0x51d892b4fc8) at ../../v8/src/heap/mark-compact.cc:377
#6  0x0000000001bb662b in v8::internal::Heap::MarkCompact (this=0x51d892af040) at ../../v8/src/heap/heap.cc:1274
#7  0x0000000001bb4d31 in v8::internal::Heap::PerformGarbageCollection (this=0x51d892af040, collector=v8::internal::MARK_COMPACTOR, gc_callback_flags=v8::kNoGCCallbackFlags) at ../../v8/src/heap/heap.cc:1159
#8  0x0000000001bb46b2 in v8::internal::Heap::CollectGarbage (this=0x51d892af040, collector=<optimized out>, gc_reason=<optimized out>, collector_reason=<optimized out>, gc_callback_flags=<optimized out>)
    at ../../v8/src/heap/heap.cc:894
#9  0x0000000001bb3a46 in CollectGarbage (space=v8::internal::OLD_POINTER_SPACE, gc_reason=0x0, callbackFlags=v8::kNoGCCallbackFlags, this=<optimized out>) at ../../v8/src/heap/heap-inl.h:567
#10 CollectAllGarbage (this=0x51d892af040, flags=0, gc_callback_flags=v8::kNoGCCallbackFlags, gc_reason=<optimized out>) at ../../v8/src/heap/heap.cc:784
#11 v8::internal::Heap::HandleGCRequest (this=0x51d892af040) at ../../v8/src/heap/heap.cc:735
#12 0x0000000001b5804b in v8::internal::StackGuard::HandleInterrupts (this=0x51d892b54c8) at ../../v8/src/execution.cc:663
#13 0x0000000001fff9ac in __RT_impl_Runtime_StackGuard (isolate=<optimized out>, args=...) at ../../v8/src/runtime/runtime-internal.cc:119
#14 v8::internal::Runtime_StackGuard (args_length=<optimized out>, args_object=0x1139a18f7c28, isolate=<optimized out>) at ../../v8/src/runtime/runtime-internal.cc:109

Original issue's description:
> Update V8 to version 4.3.56.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/c5443d75..b09c6a7d
>
> Please follow these instructions for assigning/CC'ing issues:
> https://code.google.com/p/v8-wiki/wiki/TriagingIssues
>
> TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
> BUG=
>
> Committed: https://crrev.com/16408c2845040574d5e458703f848aa04b2bb629
> Cr-Commit-Position: refs/heads/master@{#322237}

TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/997883003

Cr-Commit-Position: refs/heads/master@{#322348}

The current use-cases of the tests only consist of either running all the tests, or running individually specified tests. The information about which tests are disabled and which are supposed to pass, is therefore not useful, and making the scripts more complicated than needed.

This CL removes the support for disabling the Python tests.

BUG=369521

Review URL: https://codereview.chromium.org/1012863006

Cr-Commit-Position: refs/heads/master@{#322347}

Currently DeleteAndStartOver() is tested in memory storage (MemEnv)
supported by LevelDB for performance, but it seems preferable to test
it on real environment, that is, on disk storage because the recovery
process can be affected by characteristics of lower filesystem.

BUG=468926
TEST=content_unittests --gtest_filter=ServiceWorkerContextTest.DeleteAndStartOver

Review URL: https://codereview.chromium.org/1022363002

Cr-Commit-Position: refs/heads/master@{#322346}

BUG=none

Review URL: https://codereview.chromium.org/1037723002

Cr-Commit-Position: refs/heads/master@{#322345}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f2ec400..9b70ee9

TBR=loislo@chromium.org

Review URL: https://codereview.chromium.org/1016273007

Cr-Commit-Position: refs/heads/master@{#322344}

The previous check location was forcing all apps and extensions which call
the chrome.fileSystem.requestFileSystem API, to have "fileBrowserHandler"
permission as well.

That however doesn't make much sense, as those apps are not always handlers.
This CL moves the check to FileBrowserHandler::GetHandler() so simply the
permission has to be used only if the app wants to be a handler.

TEST=unit_test: FileBrowserHandlerManifestTest.GetHandlersRequiresPermission
BUG=470494

Review URL: https://codereview.chromium.org/1030133002

Cr-Commit-Position: refs/heads/master@{#322343}

WebRTC 8857:8862
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/edd91ff..70e3d3d

Libjingle 8855:8863
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/bb52e6e..f4031d6

TBR=mcasas@chromium.org

Review URL: https://codereview.chromium.org/1034073003

Cr-Commit-Position: refs/heads/master@{#322342}

Otherwise the worker could get stopped if the timer happens to expire between
events while it's in a flurry of events.

BUG=462096

Review URL: https://codereview.chromium.org/1038763005

Cr-Commit-Position: refs/heads/master@{#322341}

The behavior is controlled by Finch. If user clicks "Not save" n times in row then the default value for the button becomes "Never for this site".
The previous experiment didn't pop up the bubble occasionally. We collected enough statistics and stopped it few months ago.

BUG=431739

Review URL: https://codereview.chromium.org/1022843003

Cr-Commit-Position: refs/heads/master@{#322340}

BUG=466848

Review URL: https://codereview.chromium.org/1030263002

Cr-Commit-Position: refs/heads/master@{#322339}

BUG=None

Review URL: https://codereview.chromium.org/1031253002

Cr-Commit-Position: refs/heads/master@{#322338}

BUG=none

Review URL: https://codereview.chromium.org/1008563004

Cr-Commit-Position: refs/heads/master@{#322337}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/40f80cc..f2ec400

TBR=jchaffraix@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/1034133002

Cr-Commit-Position: refs/heads/master@{#322336}