- 01 May, 2012 18 commits
-
-
maruel@chromium.org authored
Revert r134607 "Revert r134508 "Revert 134507, broke the main builders:"" Overall, this reapplies r134507. The dependencies were retrieved with trace_inputs.py and merged with merge_isolate.py. Manual edits: - Added <(EXECUTABLE_SUFFIX) to two executables: unit_tests and xdisplaycheck. - Removed testserver.log and unit_tests.log. - Added copyright. - Removed *.db-journal files. TBR=rogerta@chromium.org BUG=98636 TEST= Review URL: http://codereview.chromium.org/10269019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134667 0039d316-1c4b-4281-b951-d872f2087c98
-
craigdh@chromium.org authored
Added a new automation hook ExecuteJavascriptInOOBEWebUI() to permit executing abitrary javascript prior to login on chromeos. Change-Id: If96d94bb22ac5bd25fa4ab1e3a4c3ba52ea47370 BUG=chromium-os:29466,chromium-os:20709 TEST=functional/chromeos_login.py (testExecuteJavascriptInOOBEWebUI) Review URL: http://codereview.chromium.org/10257015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134666 0039d316-1c4b-4281-b951-d872f2087c98
-
jamiewalch@google.com authored
BUG=125568 TEST=Manual Review URL: https://chromiumcodereview.appspot.com/10274022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134665 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
realized the old implementation was over-complicated and could fail if two objects had interleaved, rather than nested, scope. BUG=none TEST=manual Review URL: http://codereview.chromium.org/10269008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134663 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/10268021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134660 0039d316-1c4b-4281-b951-d872f2087c98
-
kevers@chromium.org authored
BUG=102482 TEST= Review URL: http://codereview.chromium.org/10266010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134659 0039d316-1c4b-4281-b951-d872f2087c98
-
jamiewalch@google.com authored
BUG=None TEST=Manual Review URL: https://chromiumcodereview.appspot.com/10271025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134658 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
page action. BUG=124605 Review URL: http://codereview.chromium.org/10264004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134657 0039d316-1c4b-4281-b951-d872f2087c98
-
jennb@chromium.org authored
This bug was introduced by r10170037 which waited until mouse was released to truly end a grab. BUG=crash when clicking on titlebar to restore a minimized panel TEST=minimize a panel. click on titlebar to restore. verify no crash. Review URL: https://chromiumcodereview.appspot.com/10266021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134655 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
R=aa@chromium.org BUG=124477 Review URL: http://codereview.chromium.org/10177006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134654 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
the original way (installed then loaded). I originally switched the order so I could dispatch the onInstalled event, but doing so in a PostTask is a better solution to that. BUG=no TEST=no Review URL: http://codereview.chromium.org/10274013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134653 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134652 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@chromium.org authored
BUG= TEST=tree Review URL: https://chromiumcodereview.appspot.com/10260027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134651 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
HostPortAllocator is a PortAllocator specific to Chromoting host. BUG=103991 Review URL: https://chromiumcodereview.appspot.com/10160013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134650 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134649 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@chromium.org authored
BUG= TEST=tree Review URL: https://chromiumcodereview.appspot.com/10264018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134648 0039d316-1c4b-4281-b951-d872f2087c98
-
bryner@chromium.org authored
BUG=125471 TEST=none Review URL: http://codereview.chromium.org/10268019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134647 0039d316-1c4b-4281-b951-d872f2087c98
-
noel@chromium.org authored
BUG=None TEST=Right-click #include "qms.h" in VS2010 works. Review URL: http://codereview.chromium.org/10271005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134646 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Apr, 2012 22 commits
-
-
jennyz@chromium.org authored
http://www.corp.google.com/~kenmoore/mocks/chromeos/Misc_2012/Menus/markup1/menu4.html Menu text enabled color, button enabled text color, label enabled text color are set to #222. Menu text disabled color, button disabled text color, label disabled text color are set to #999. Menu keyboard shortcut text color is set to #999. Menu item hover background color is set to #f1f1f1. BUG=122858 TEST=Menu spec for all the color is implemented, see code review description for details. Review URL: http://codereview.chromium.org/10270021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134645 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
BUG=119511 TEST=none TBR=reed Review URL: https://chromiumcodereview.appspot.com/10262024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134644 0039d316-1c4b-4281-b951-d872f2087c98
-
dyu@chromium.org authored
Installed the root certificate on each of the chrome-qa bots and ran the disabled SSL tests to verify. Only managed to install the root certificate on the windows bots on the chromium waterfall. TEST=Verified in each chrome-qa bot. BUG=119110,119173 Review URL: https://chromiumcodereview.appspot.com/10271021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134643 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
R=ben@chromium.org TBR=thestig@chromium.org Review URL: https://chromiumcodereview.appspot.com/10170045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134642 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
Revert 134625 - Transmit a X-Chrome-UMA-Enabled bit to Google domains from clients that have UMA enabled. Causing startup crash on Linux chromeos bot. This requires a change to the ChromeNetworkDelegate where we feed the incognito state (a bool) into the object at creation time, so we can check that field when doing our header setting. BUG=123609 TEST=With UMA enabled (not Chromium), visit www.google.com and ensure that the request header includes X-Chrome-UMA-Enabled with value "1". Ensure that disabling UMA also disables the transmission of this header entirely. Also, ensure that unit_tests GoogleUtilTests all pass. TBR=ivankr@chromium.org Review URL: http://codereview.chromium.org/10108026 TBR=stevet@chromium.org Review URL: https://chromiumcodereview.appspot.com/10264023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134641 0039d316-1c4b-4281-b951-d872f2087c98
-
tbreisacher@chromium.org authored
BUG=none TEST=crash reporting still works (need to build Chrome, not Chromium) and dbeam%40%20doesn't%20go%20crazy%20trying%20to%20read%20it Review URL: https://chromiumcodereview.appspot.com/10007040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134640 0039d316-1c4b-4281-b951-d872f2087c98
-
garykac@chromium.org authored
This archive is referred to by our canary link to the webapp. BUG=none TEST=none Review URL: http://codereview.chromium.org/10271019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134639 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
This makes Chrome listen for messages from the power manager asking it to dim or undim the screen. We'll use this on desktop devices with external displays to dim the screen just before blanking it when the user is idle. BUG=125176 TEST=added, also did manual testing with powerd changes Review URL: http://codereview.chromium.org/10263011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134638 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
LibjingleTransport transport instances will be sharing a single PortAllocator, so config needs to be passed to TransportFactory. BUG=103991 Review URL: https://chromiumcodereview.appspot.com/10160012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134637 0039d316-1c4b-4281-b951-d872f2087c98
-
garykac@chromium.org authored
Review URL: http://codereview.chromium.org/10266019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134636 0039d316-1c4b-4281-b951-d872f2087c98
-
jianli@chromium.org authored
In this patch, I moved more panel-specific logic out of the base classes: * Title decoration to draw the title with pango markup * SendEnterNotifyToCloseButtonIfUnderMouse I overrode UsingCustomPopupFrame in PanelBrowserWindowGtk to always return false. That way, panels are always painted with custom frame. Now no matter which theme the user picks and which state (drawing attention or not) the panel is at, we paint the frame in the same code path. I also fixed the extra line shown in title-only panel by adding IsMinimized check to BrowserWindowGtk::ShouldDrawContentDropShadow. BUG=117205 TEST=Manual test by verifying panels being painted with correct theme Review URL: https://chromiumcodereview.appspot.com/10180011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134635 0039d316-1c4b-4281-b951-d872f2087c98
-
simonmorris@chromium.org authored
The typos are caught by jscompile. Review URL: https://chromiumcodereview.appspot.com/10262013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134633 0039d316-1c4b-4281-b951-d872f2087c98
-
hshi@google.com authored
Ben recently added support in cros-disks for an optional mount label. (https://gerrit.chromium.org/gerrit/#change,21171) Make use of this option to display a user-friendly file name for the mounted archive, instead of the actual file name of the cache blob "<resource_id>.<md5>.mounted". BUG=chromium-os:28678 TEST=Tested mounting archives (both local and on gdata). Review URL: http://codereview.chromium.org/10231010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134632 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
Review URL: http://codereview.chromium.org/10261017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134631 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@google.com authored
Below are a few tests that are crashing (the list is not complete): compositing/plugins/composited-plugin.html compositing/plugins/1x1-composited-plugin.html compositing/plugins/small-to-large-composited-plugin.html compositing/plugins/large-to-small-composited-plugin.html This allows us to show a nicer placeholder when loading a plug-in fails then the one coming from WebKit. BUG=123580 TEST=manual Review URL: http://codereview.chromium.org/10093011 TBR=bauerb@chromium.org Review URL: https://chromiumcodereview.appspot.com/10274020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134630 0039d316-1c4b-4281-b951-d872f2087c98
-
garykac@chromium.org authored
Addresses follow-up comments from 10197005. Review URL: http://codereview.chromium.org/10221027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134629 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
To be re-enabled tomorrow. R=dennisjeffrey@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10265019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134628 0039d316-1c4b-4281-b951-d872f2087c98
-
benwells@chromium.org authored
This broke as a result of r134028, where we iterate all RVHs associated with an extension instead of just ExtensionHosts. BUG=125306 TEST=Test hosted app menus, extension popup menus and platform app popups work correctly. Review URL: http://codereview.chromium.org/10253021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134627 0039d316-1c4b-4281-b951-d872f2087c98
-
cevans@chromium.org authored
BUG=125635 Review URL: https://chromiumcodereview.appspot.com/10260024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134626 0039d316-1c4b-4281-b951-d872f2087c98
-
stevet@chromium.org authored
This requires a change to the ChromeNetworkDelegate where we feed the incognito state (a bool) into the object at creation time, so we can check that field when doing our header setting. BUG=123609 TEST=With UMA enabled (not Chromium), visit www.google.com and ensure that the request header includes X-Chrome-UMA-Enabled with value "1". Ensure that disabling UMA also disables the transmission of this header entirely. Also, ensure that unit_tests GoogleUtilTests all pass. TBR=ivankr@chromium.org Review URL: http://codereview.chromium.org/10108026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134625 0039d316-1c4b-4281-b951-d872f2087c98
-
sullivan@chromium.org authored
This copy was fetched from: hg.mozilla.org/projects/kraken/ Modifications made: The python script make-hosted.py was run to update the hosted/ directory, and the unused tests, sunspider, and sunspider-compare-results files were deleted. BUG= TEST= Review URL: http://codereview.chromium.org/10070009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134624 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
Instead use GetFileInfoByPathAsync(). This is in preparation for making FindEntryByPathAsync() private. Along the way, get back |file_name| field in GDataFileProto, which was once removed in crrev.com/134405, as this info was needed. BUG=chromium-os:30251 TEST=can open both regular files hosted documents on gdata as before Review URL: https://chromiumcodereview.appspot.com/10270025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134623 0039d316-1c4b-4281-b951-d872f2087c98
-