GitLab

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049

Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Commit-Position: refs/heads/master@{#481225}
Committed: https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e9ceb72d29c8e
Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#481692}

ProxyConfigServiceLinux.

BUG=689520
TBR=jochen@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2944313003
Cr-Commit-Position: refs/heads/master@{#481691}

BUG=704929
TEST=covered by unit test

Review-Url: https://codereview.chromium.org/2950083002
Cr-Commit-Position: refs/heads/master@{#481690}

This reverts commit af16f316.

Reason for revert: Speculative revert to see if it fixes crbug/735659.

Original change's description:
> Don't take a mutex around certificate verifications on Android.
> 
> We use a worker pool to verify certificates, but then undo it all in
> Android by locking around the entire operation. However, Android's
> X509TrustManager implementations are already thread-safe. We do some
> work on top which must be synchronized, mostly around reloading various
> caches.
> 
> Instead, lock only around acquiring the current instance of the caches.
> When we need to invalidate, we drop the pointer. Any pending tasks
> will continue using the old state (as they would have before this
> change as they'd be holding the lock), but all verifications after the
> invalidation will use a fresh set of state.
> 
> A completely unscientific (I checked about:histograms after startup)
> suggest that this speeds up the mean startup cert verification time
> by about 40%.
> 
> Bug: 
> Change-Id: I3cddb798f3dfd51a2f1d2e529127c39f521e93de
> Reviewed-on: https://chromium-review.googlesource.com/531973
> Reviewed-by: Matt Mueller <mattm@chromium.org>
> Commit-Queue: David Benjamin <davidben@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#480472}

TBR=davidben@chromium.org,mattm@chromium.org

Bug: 735659
Change-Id: Ib84eb5b0a03d674565a075ad1003828904aebe24
Reviewed-on: https://chromium-review.googlesource.com/545057Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481689}

This is a reland of afc31e81
Fixed Windows x64 build failure. DLL export needs to be specified on
individual explicit template instantiation:
https://docs.microsoft.com/en-us/cpp/cpp/general-rules-and-limitations

Original change's description:
> [SPv2] Rework GeometryMapper transform computation
> 
> When computing the conversion matrix between two spaces, there are two
> types of conversion that are commonly used, but with slightly different
> semantics:
> 
> m1 = destination_to_screen ^ -1 * source_to_screen
> m2 = flatten(destination_to_screen) ^ -1 * flatten(source_to_screen)
> 
> The former computes the space conversion, which is useful for mapping
> 3D points from one space to 3D points in another space. The latter
> computes the "projection through screen", which is useful for mapping
> 2D points from a plane to a backing that is expected to be drawn onto
> the screen.
> 
> To illustrate the difference, see the following example:
> <div style="transform:rotateY(45deg)">A</div>
> <div style="transform:rotateY(-45deg)">B</div>
> 
> The space conversion from A to B is equal to rotateY(90deg), but the
> projection between the two planes is identity.
> 
> Prior to this CL, GeometryMapper implemented a mixed semantics. This is
> okay because all existing code only make queries that are co-planar, in
> which case, either version returns identical result. This is because we
> only make intra-compositing-layer queries, and 3D transform makes a
> compositing boundary.
> 
> This CL changed the implementation to strictly return the "projection
> through screen". The algorithm runs in amortized O(1) by caching the
> matrix between a node and its nearest coplanar ancestor that has a
> invertible projection.
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: Ia526dc6feb60c902f27589d73e78dfea235c6a93
> Reviewed-on: https://chromium-review.googlesource.com/534899
> Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
> Reviewed-by: Chris harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481049}

Change-Id: I067a0f40f2e41a9fc282c4014975f144417d7d3b
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/543897
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481688}

Enabled by feature flag only. Only trims out HTTPs, since we already
trim HTTP, and other schemes do not seem appropriate to trim out.

BUG=732582
TEST=unit and manual

Review-Url: https://codereview.chromium.org/2940973002
Cr-Commit-Position: refs/heads/master@{#481687}

Revert of [Offline Pages] Cleans up DEPS in offline_pages (patchset #2 id:20001 of https://codereview.chromium.org/2950113002/ )

Reason for revert:
This seems to have broken checkdeps

Original issue's description:
> [Offline Pages] Cleans up DEPS in offline_pages
>
> This moves DEPS into prefetch that were put on core.
>
> BUG=NONE
>
> Review-Url: https://codereview.chromium.org/2950113002
> Cr-Commit-Position: refs/heads/master@{#481555}
> Committed: https://chromium.googlesource.com/chromium/src/+/4bd9a54564189647e023fce848681bfd82ca4d01

TBR=jochen@chromium.org,dimich@chromium.org,dewittj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=NONE

Review-Url: https://codereview.chromium.org/2948923004
Cr-Commit-Position: refs/heads/master@{#481686}

The PendingTreeDuration currently captures the time the pending tree
has to wait after notifying that it was activated, while the raster
work required for activation has finished. Add a seperate UMA to
capture only the raster duration for required for activation work.

R=ericrk@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2946223003
Cr-Commit-Position: refs/heads/master@{#481685}

Since it is possible for the Reader Mode infobar to appear while a
tab is in fullscreen mode, activating the feature should exit
fullscreen. This change toggles fullscreen mode just before navigating
to reader content.

BUG=735383

Change-Id: Ic6133a3423767583df0efcc2df3e6ae3d0c915ef
Reviewed-on: https://chromium-review.googlesource.com/544076Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481684}

I ran it locally, and it now seems to be having no problems

TBR=perezju@chromium.org

Bug: 664661
Change-Id: Ia8201db53d9687f4cc23736e29f3e45a1a2062fa
Reviewed-on: https://chromium-review.googlesource.com/544905Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481683}

Whether the body box has scrolling overflow or not depends on the
computed overflow of the html element.

The HasOverflowClip flag, along with creating and removing a paint
layer on LayoutBlock is updated as part of SetStyle. However, if the
html element is recalculated, its overflow changing causing the
viewport defining element to change, but body did not need a recalc,
the overflow clip flag and paint layer is not updated for body.

This CL forces a SetStyle on the body LayoutObject to trigger the
necessary update after recalc when when the viewport defining element
changes.

This fixes scrollingElement.html in wpt/cssom-view.

Bug: 665927
Change-Id: I146c3e976edef28074bde6531fe4c6ec65ecb090
Reviewed-on: https://chromium-review.googlesource.com/544958
Commit-Queue: Rune Lillesveen <rune@opera.com>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481682}

Moving hiding of the form validation bubble to the browser process has
the following benefits:
- It allows simplifying/removing code from Blink (in particular it
  allows removing some of the code added in r459701).
- It makes the hiding immune against compromised renderers.
- It makes the hiding work even if ViewHostMsg_HideValidationMessage IPC
  gets filtered out (i.e. see CanSendWhileSwappedOut method in
  content::SwappedOutMessages).  This in turn will allow relanding
  of r479538.

BUG=733940
TEST=Manually verified that bugs 733940, 704560, 673163 are still fixed.

Review-Url: https://codereview.chromium.org/2949593003
Cr-Commit-Position: refs/heads/master@{#481681}

Use GL_TEXTURE_2D instead of GL_TEXTURE_EXTERNAL_OES with GMBs
when texture is used as a target for drawing. GL_TEXTURE_EXTERNAL_OES
should only be used when the buffer is only used for sampling. This
is also consistent with the buffer queue that is using GL_TEXTURE_2D.

BUG=680851
TEST=chrome --enable-features=Pepper3DImageChromium

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0e0ab013a474eaaaf6af10c79c7dd4e98a4351d1
Reviewed-on: https://chromium-review.googlesource.com/544236Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481680}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/33a6a6490c5e..6b73d036d392

$ git log 33a6a6490..6b73d036d --date=short --no-merges --format='%ad %ae %s'
2017-06-22 eakuefner [Telemetry] Delete camel_case shim
2017-06-22 benjhayden Make netlog_viewer/bin/run_dev_server_tests executable.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I0e4833f53d99466c7add032606ef4e1a00a5ac40
Reviewed-on: https://chromium-review.googlesource.com/544800
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481679}

This CL gets rid of the MemoryDumpManager::RequestGlobalDump(),
and moves the existing code to use the service. This allows to
cleanup all the odd callback proxy required to match the base vs
mojo callbacks.
Also, this moves the dump id generation responsibility to the
service, which is now the only one dealing with global dumps.

At this point the only knowledge left in base::MemoryDumpManager
about "global" dumps is only the |request_dump_function|, which
is required to keep the periodic dump scheduler and peak detector
working. This can be removed once those two are moved to the service.

BUG=720352

Change-Id: I25c22157234e1e627c5aeafa189df01944354e7d
Reviewed-on: https://chromium-review.googlesource.com/536952
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Reviewed-by: siddhartha sivakumar <ssid@chromium.org>
Reviewed-by: Hector Dearman <hjd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481678}

R=eae@chromium.org

Change-Id: I18bfe4d6b3a85fe582b7cb00e30c2e4efb5af833
Reviewed-on: https://chromium-review.googlesource.com/544318Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481677}

When switching from gpu<->software caches, the checker tracker assumes
it has a valid decode, but it doesn't since the decode cache itself is
destroyed. So ask the tracker to drop its decodes as well.

R=vmpstr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2948033005
Cr-Commit-Position: refs/heads/master@{#481676}

This caused it to be included in about 3400 compilation units. Removing this
dependency reduces the number to about 1000.

Compiling ComputedStyle.h takes almost 6 seconds here (which is worth an
investigation on its own).

Some changes elsewhere were required because of this, because they
inadvertently depended on things included via ComputedStyle.h . Keeping
Blob & co merely forward-declared in IDBValueWrapping.h required some
extra work.

The dependency was introduced here:

https: //codereview.chromium.org/2821193003
Change-Id: I5323c12821ae7e5408f6f5f1fee17222a0acf511
Reviewed-on: https://chromium-review.googlesource.com/543155
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Reviewed-by: Rune Lillesveen <rune@opera.com>
Reviewed-by: nainar <nainar@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481675}

Memory coordinator is going to focus on how/when to request tab
discarding and won't replace existing MemoryPressureListeners except for
TabManager. We shouldn't disable MemoryPressureListeners.

BUG=696844

Review-Url: https://codereview.chromium.org/2943953002
Cr-Commit-Position: refs/heads/master@{#481674}

Revert of build: Remove build system support for gold plugin, except under ChromeOS. (patchset #5 id:80001 of https://codereview.chromium.org/2891843002/ )

Reason for revert:
Suspecting this CL for generate_build_files failure: https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/18593

Original issue's description:
> build: Remove build system support for gold plugin, except under ChromeOS.
>
> R=thakis@chromium.org,brettw@chromium.org
> TBR=mseaborn@chromium.org
> BUG=607968
>
> Review-Url: https://codereview.chromium.org/2891843002
> Cr-Commit-Position: refs/heads/master@{#481656}
> Committed: https://chromium.googlesource.com/chromium/src/+/84bbf436692e8b91ba238f11a4749fd2c4d99cb7

TBR=brettw@chromium.org,thakis@chromium.org,mseaborn@chromium.org,yunlian@chromium.org,pcc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607968

Review-Url: https://codereview.chromium.org/2953953002
Cr-Commit-Position: refs/heads/master@{#481673}

Bug: 108009
Change-Id: I5758b9b0dfec8c2cb2148cee17b3c68ae7832c08
Reviewed-on: https://chromium-review.googlesource.com/544621
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481672}

DOM CodeString comes from scancode, so SendInput should use scancode instead of
virtual-key if the key is associated with a DOM CodeString.
With this change, test cases in https://codereview.chromium.org/2922773002/
should pass.

A KeyboardEventCodeInteractiveTest is also added to ensure KeyboardEvent.code
can be correctly set by using ui_test_utils::SendKeyPressSync().
KeyboardEventCodeInteractiveTest starts a web page to record all the
KeyboardEvent.code it received, sends several key presses through
ui_test_utils::SendKeyPressSync() and verifies whether the record is expected.

BUG=680809

Review-Url: https://codereview.chromium.org/2939283002
Cr-Commit-Position: refs/heads/master@{#481671}

This CL adds @autoreleasepool to ios/chrome/app/chrome_exe_main.mm, and
serves as a parent CL of https://codereview.chromium.org/2887413002/
so that ios/chrome/app:main can be converted to ARC.

Bug: 624363
Change-Id: Ibe55897f1869643deee85723c97b0062146b01d0
Reviewed-on: https://chromium-review.googlesource.com/540701
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481670}

After https://chromium-review.googlesource.com/521162 the API is quite
closely aligned with the standard, although the rendering bits still are
not.

Enabling it will make it easier to test, and might shake out compat
problems in the wild earlier.

Bug: 383813
Change-Id: I0c9add3bdc77f689deeafb207022e5c9fea1e3bd
Reviewed-on: https://chromium-review.googlesource.com/544303
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481669}

This patch sets RenderViewTest's initial size to be 400x300 instead of
0x0 so scrolling can work. This is in preparation for a future patch
that asserts scroll layers have non-zero dimensions.

The following test changes were required:
1) RenderViewTest.MacTestCmdUp: removed a TODO hack that made the document
non-empty for scrolling.
2) PasswordGenerationAgentTest.FillTest previously used a gesture to focus
an initial element but this gesture event failed because the window size
was empty. This patch removes the gesture event so the test still has no
initial focused element.
3) RenderViewImplTest.NavigateSubframe no longer wraps "hello world".
4) RenderFrameImplTest.FrameResize has been changed so it does change the
viewport instead of leaving it with a 0,0 size, and a new test proves it.

Bug: 723263
Change-Id: Ie1d56dcbf09ddf6250011a8a59e6c07fafd60346
Reviewed-on: https://chromium-review.googlesource.com/541982Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481668}

Changes:
This is basically a refactor of code to support more than one wallpaper
prominent color extracting.
(1) group LumaRange and SaturationRange to ColorProfile, and a vector
of color_profiles are passed as parameter for calculation.
(2) updated UMA for Ash.Wallpaper.ColorExtractionResult to enumeration.

R=xdai@chromium.org, bruthig@chromium.org, estade@chromium.org,
danakj@chromium.org, isherman@chromium.org, jamescook@chromium.org
BUG=734761
TEST=covered by tests

Review-Url: https://codereview.chromium.org/2943333003
Cr-Commit-Position: refs/heads/master@{#481667}

ERR_IPC_WITH_NO_RELEVANT_LOAD and ERR_IPC_FROM_BAD_URL_SCHEME are
errors that help to understand when we receive messages from a
render process that aren't expected in the browser process.

Historically, we only tracked main frames, so it made sense to
log these on all IPCs.

As of https://codereview.chromium.org/2859393002, we receive
IPCs from both main and child frames.

It is valid and expected to receive these IPCs from a child
frame when we aren't tracking a main frame, as render tracking
policy is purely per frame and has no awareness of the main
frame's URL etc.

Thus, we update the code that logs these errors to only do so
for messages received from main frames.

Bug: 736075
Change-Id: Ifc7f2dd758fc244de8e7098a3c553f8bb2ad05ee
Reviewed-on: https://chromium-review.googlesource.com/545016Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481666}

This checks to see if an editable address item in the UI is complete. If it
is not then the address editor will be shown. If it is complete the address
will be selected whether its for billing or shipping.

Address fields incomplete: http://imgur.com/a/1hEVK
Filling out first card: http://imgur.com/a/Eupai
Second card leads to editor: http://imgur.com/a/OFNHi

Bug: 602666
Change-Id: Ic9c1e731b6c989b289cde4e47ed36543df734a20
Reviewed-on: https://chromium-review.googlesource.com/534673
Commit-Queue: Randall Raymond <rayraymond@google.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Reviewed-by: mahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481665}

BUG=None
TEST=Ran trybots.

Change-Id: I629a44b1dc0f58118a6526e1047e7bb31ec1d82e
Reviewed-on: https://chromium-review.googlesource.com/544721Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481664}

CompositorProxy is a used by CompositorWorker which is being superseded by
AnimationWorklet. Given that AnimationWorklet is not going to use
CompositorProxy we are removing it and other related classes.

This also means removing tests that where mainly associated with  CompsitorProxy
functionality.


Bug: 686897, 619042
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7fa749c83e74fa65e8271d2111ebc9ae2e872ebb
Reviewed-on: https://chromium-review.googlesource.com/527455
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481663}

The previous format was unspecified, untested, and using the older
category_filters format. This is incompatible with the newer included/excluded
categories format.

The new format is the same as the TraceConfig format. This CL also adds tests.

BUG=chromium:735124

Review-Url: https://codereview.chromium.org/2948033004
Cr-Commit-Position: refs/heads/master@{#481662}

This reverts commit 31c39d8d.

Reason for revert: Trying again.

Original change's description:
> Revert "Add new gn arg for Linux builds on chromium.perf"
> 
> This reverts commit b81f0267.
> 
> Reason for revert: Might have totally broken the builder.
> 
> Original change's description:
> > Add new gn arg for Linux builds on chromium.perf
> > 
> > It appears there's a way to disable using the gnome keyring
> > service on linux, which has been causing our bots issues. Try setting
> > this gn arg to see what happens.
> > 
> > Bug: 732463
> > Change-Id: Iaa1ff400e506ae6245346741d4bcdeaaa695fd4f
> > Reviewed-on: https://chromium-review.googlesource.com/542015
> > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#481143}
> 
> TBR=dpranke@chromium.org,kbr@chromium.org,nednguyen@google.com,martiniss@chromium.org
> 
> Change-Id: I96533c8eb48da571ff289834a478f9b896dc414a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 732463
> Reviewed-on: https://chromium-review.googlesource.com/543537
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481213}

TBR=dpranke@chromium.org,kbr@chromium.org,nednguyen@google.com,martiniss@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 732463
Change-Id: I0cf5ee9662adaffcc629832d19c8fcbab0b0c834
Reviewed-on: https://chromium-review.googlesource.com/544686Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481661}

1. Provide interfaces in app_list::SearchResult to set price and rating
for instant and play store apps based on specs.
2. Change the layouts of SearchResultTileItemListView and
SearchResultTileItemView to show price and rating properly based on
specs.

Specifications:
https://screenshot.googleplex.com/AFQ5HnrMYch
https://screenshot.googleplex.com/0opcNunaJrZ

The screenshot: https://screenshot.googleplex.com/Kv0xzOVZLqs

BUG=734841

Review-Url: https://codereview.chromium.org/2949733002
Cr-Commit-Position: refs/heads/master@{#481660}

We should not create a HistogramTester while stopping the ServiceWorker.

Bug: 735814
Change-Id: Ie3d8197b90605162d78d219c130028e7fbb321fb
Reviewed-on: https://chromium-review.googlesource.com/544359Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481659}

Setting the openerTabId param of any tab to its own tab id via
chrome.tabs API should not be allowed. For example, if tab 1 opened
tab 2, tab 2's openerTabId value should not be allowed to be 2.

This can lead to crashes, for example, when if openerTabId equals the
tab's id and the tab is closed.

This patch prevents the aforementioned from occurring and throws a
console error to inform the developer.

Bug: 709961
Change-Id: I8513091b11088447477f4709ec605b78dafe7b0a
Reviewed-on: https://chromium-review.googlesource.com/544224
Commit-Queue: catmullings <catmullings@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481658}

BUG=706832
TEST=Remove -Wno-shift-negative-values from Chrome OS build.
TEST=Build Chrome for Chrome OS, no warnings/errors.

Change-Id: Icb4f50452d87a8b2dc680752a2bb965f31c33639
Reviewed-on: https://chromium-review.googlesource.com/544198Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481657}

R=thakis@chromium.org,brettw@chromium.org
TBR=mseaborn@chromium.org
BUG=607968

Review-Url: https://codereview.chromium.org/2891843002
Cr-Commit-Position: refs/heads/master@{#481656}

This is the first CL to migrate the touch event
paths to pointerevents.

BUG=625841

Review-Url: https://codereview.chromium.org/2860663006
Cr-Commit-Position: refs/heads/master@{#481655}

Bug: 689520
Change-Id: I7434993ce90e2433f1f19becf6aaefd6fa2dffec
Reviewed-on: https://chromium-review.googlesource.com/535622Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481654}

ash to Chrome, this will enables using DevTools in Window and Linux
platform.

BUG=711343

Review-Url: https://codereview.chromium.org/2887003003
Cr-Commit-Position: refs/heads/master@{#481653}