GitLab

We've seen multiple crashes in autocomplete code that point to timing
mismatches in Java state of autocomplete and C++ state for autocomplete
results. Specifically, we indicate user-chosen results via an index into
the result list, which may get updated.

Ensure that any result used on C++ side is matching the java result we
wanted to select. Added a histogram to figure out how often mismatches
occur. This can guide us to overhaul the implementation to fix this
problem (if happens a fair bit) or remove this checking (if never
happens).

Bug: 818761
Change-Id: I9123e22404d10f87da4cf039e0a6e49922d02d7f
Reviewed-on: https://chromium-review.googlesource.com/1008410
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550533}

Windows does not necessarily change the last-modified time of files that
are modified via a r/w file mapping. This CL explicitly sets the
last-modified time on PE files (.exes and .dlls) modified by
alternate_version_generator.exe. This is significant because it appears
that the Windows loader does some caching of data about an .exe and
doesn't flush this cache if a new file with the same last-modified time
as an old file appears. This caused Chrome launches to fail with
STATUS_OBJECT_NAME_NOT_FOUND (0xC0000034).

BUG=461856
R=huangs@chromium.org, mmeade@chromium.org

Change-Id: Ic0e0f68ef9ca62e02bb828267352c2f7052ff908
Reviewed-on: https://chromium-review.googlesource.com/1009705
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550532}

This patch adds ToPositionInDOMTreeWithAffinity() and
ToPositionInFlatTreeWithAffinity() to make PwA conversion easier.

It is also a preparation patch for adding NG line functions.

Change-Id: I4a802a183288fb7a1003ac9cf6e02fe7cad1d4a5
Reviewed-on: https://chromium-review.googlesource.com/1011392Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550531}

This is a preparation CL for enabling to establish WebSocket connections off the
main thread.

Before this CL, WebSocketSafeBrowsingThrottle is created by
ChromeContentRendererClient::CreateWebSocketHandshakeThrottle(). This prevents
the off-main-thread WebSocket because the function is bound with the main thread
(render thread) and the throttle cannot be created from both the main thread and
worker threads.

To avoid it, this CL makes a new path to create the throttle in a thread-safe
way. Specifically, this introduces WebSocketSafeBrowsingThrottleProvider that is
created on the main thread, passed to a worker thread, and then provides the
throttle on the thread. DocumentWebSocketChannel[*] accesses the throttle
provider via FrameFetchContext/WorkerFetchContext.

After this CL, WebSocket for Document and DedicatedWorker go through the new
path by default. However, WebSocket for SharedWorker and ServiceWorker still go
through the old path via WorkerShadowPage. This will be switched to the new path
when the runtime flag is enabled.

In addition, to test the new path, this CL makes
safe_browsing_service_browsertest run with the off-main-thread WebSocket flag.

[*] Although it's prefixed with "Document", DocumentWebSocketChannel is used for
workers when the off-main-thread WebSocket is enabled. It'll be renamed to
WebSocketChannel etc after the new architecture is enabled by default.

Change-Id: If9e64e3291ab86ee4c836a66afede1fde9b24789
Bug: 825740
Reviewed-on: https://chromium-review.googlesource.com/985334
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550530}

This removes 'use_once_callback = false' flag from BUILD.gn from
cr/br/engagement, and fixes all implementations of the interface.

Tbr: tommycli@chromium.org
Bug: 714018
Change-Id: Ic139ba25eb020caa384735292ee62ddfb1272ba9
Reviewed-on: https://chromium-review.googlesource.com/1002220
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550529}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1c21a5af2ec..53a115e67e50

$ git log b1c21a5af..53a115e67 --date=short --no-merges --format='%ad %ae %s'
2018-04-12 asanka Add a '--inject-current' option to 'git new-branch'
2018-04-12 petermayo Remove petermayo from OWNERS
2018-04-03 ehmaldonado Reland "presubmit support: Run all tests in parallel."
2018-04-12 ehmaldonado gclient: Don't parse DEPS files that we won't recurse into.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:819774,chromium:830306


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I9f5c9eed3ed2ee72ff566d0ff08f6e751e4d89d8
Reviewed-on: https://chromium-review.googlesource.com/1011301
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550528}

Known failures:
- all: computed value is always "", it should compute to something...
- animation-name: <custom-ident> not mentioned in typed om spec.
- cursor: 'grab' and 'grabbing' are still webkit prefixed.
- list-style-type: Blink implements something different to the spec.
- page: computed value is always "", <custom-ident> not mentioned in
        typedom spec
- perspective: '0' seems to compute to none.
- perspective-origin: Blink doesn't support 'none' keyword
- quotes: computed value is always ""
- size: computed value is always ""
- speak: Blink implements something different to the spec.
- transform-box: Blink doesn't support 'border-box' keyword
- z-index: computed value is always 'auto' (might be something to do
           with stacking context)

Bug: 820299
Change-Id: I629dda1c4bcac92f59cae3bddf11bd375f98e5c2
Reviewed-on: https://chromium-review.googlesource.com/1003434
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550527}

https://pdfium.googlesource.com/pdfium.git/+log/9e625db795ca..7afdad5ab7a1

$ git log 9e625db79..7afdad5ab --date=short --no-merges --format='%ad %ae %s'
2018-04-13 dsinclair Make CFX_XMLInstruction a subclass of CFX_XMLNode
2018-04-12 tsepez Add AsSpan() convenience method to fxcrt strings.
2018-04-12 thestig Rename one CPDF_Color::SetValue() variant.
2018-04-12 ralf.sippl Add index parameter to quadpoints getter and setter.
2018-04-12 thestig Make some CPDF_StreamContentParser methods const.
2018-04-12 thestig More CPDF_Color improvements.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I9438b0696cafab79929cef2bd97329cc9b0d6d38
Reviewed-on: https://chromium-review.googlesource.com/1011298Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550526}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/d2c34b35c8b1..70bb7daa4183

$ git log d2c34b35c..70bb7daa4 --date=short --no-merges --format='%ad %ae %s'
2018-04-12 pwang chromeos_config: kevin-arcnext in CQ/Android PFQ/Chrome PFQ
2018-04-12 laszio AutoFDO: more profile sources
2018-04-06 laszio afdo: refactoring to support multiple source of profiles

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:829170,chromium:829170


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I725a6507963a3fa6e26222b62b5fddbcaffb6027
Reviewed-on: https://chromium-review.googlesource.com/1011822
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550525}

Change-Id: I40593ec453e1cc5275703fa9d9fedc85528d4f32
Reviewed-on: https://chromium-review.googlesource.com/1010143Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550524}

As specified, RequestInit.body should be stringified, i.e.,
{toString(): () => 'hi!'} should be treated as same as 'hi!'.

Bug: 831076
Change-Id: I4118c0faa9535d62b3db2529bf23716fdc25a997
Reviewed-on: https://chromium-review.googlesource.com/1004561Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550523}

This is a reland of fef93a84

There is no change in the reland CL, the previous attempt collided with
another CL that was reverted at 348808c0


Original change's description:
> Extensions: Rename DictionaryBuilder::SetBooean -> Set. Same for ListBuilder.
>
> The overload resolution failure isn't any issue anymore after
> https://chromium.googlesource.com/chromium/src/+/723fb47254fc5f49bda577df447303dc3554beb9,
> so bool overload can be provided for DictionaryBuilder::Set and ListBuilder::Append.
>
> Bug: None
> Test: Internal only change.
> Change-Id: Id55283aeaa8868cf533f206b006c3c909a835df1
> Reviewed-on: https://chromium-review.googlesource.com/1009489
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550475}

TBR=avi@chromium.org,lazyboy@chromium.org,rdevlin.cronin@chromium.org

Bug: None
Change-Id: I2896a13c9421b1c08076bb5f756b7630f050c404
Reviewed-on: https://chromium-review.googlesource.com/1011711Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550522}

It introduces new permission, IDL and skeleton of implementation.

This privacy API is used to upload browsers and devices status that
are collected by extension to the admin console.


Bug: 826298
Change-Id: I60780d76c9e7680843acef38ce906e9cbe150025
Reviewed-on: https://chromium-review.googlesource.com/976819Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550521}

Using wpt-import in Chromium 0d969695.
With Chromium commits locally applied on WPT:
47f17dae "[css-typed-om] Support offset-rotate."
2c0351ed "Allow feature policy to be used in opaque origins."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15488

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bjonesbe@adobe.com:
  external/wpt/css/css-shapes
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
jfernandez@igalia.com:
  external/wpt/css/css-align
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=danyao

No-Export: true
Change-Id: If94238ecb93e85e017a4ac9cff893b56249e1523
Reviewed-on: https://chromium-review.googlesource.com/1011120
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550520}

They're currently backwards.

Bug: 829974
Change-Id: I67440b14df2ad143e22741e4adf2b9055d4dd683
Reviewed-on: https://chromium-review.googlesource.com/1010057Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550519}

Bug:831762,783383

Change-Id: I3aea3afb2669f83f0d40674218c82a4f399b4e6f
Reviewed-on: https://chromium-review.googlesource.com/1008270
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550518}

With this change, you can query the visibility of an element, even if
it was elided from a tree walk. It remains an error to use IsVisible
until computed opacity has been updated.

Bug: None
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3f6e3259cbbf79fe1cc9255f3cee339d057c58b9
Reviewed-on: https://chromium-review.googlesource.com/1008823
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550517}

Fix the context menu for Team Drives in Files.app to show all available
options, but greyed out. Later, these will become available if the user
has the necessary permissions for that team drive.

This also fixes a bug where selecting 'New Folder' for a Team Drive
would not target the name of the new folder for editing. Now, creating
a new folder under a team drive using the context menu correctly focuses
the name text area for the new folder.

Bug: 825725
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I785e381369c892caa48a1a9141d296c8e7888d44
Reviewed-on: https://chromium-review.googlesource.com/996832
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550516}

Previously, the files app wouldn't check for changes to the flag on startup.
This patch introduces a check in change_list_loader.cc that forces a fetch
of the team drives listing on both a delta and full fetch.

files app again. Team drives should appear.

Test: Open the files app, change the flag, restart chrome, then open the
TBR: fukino
Bug: 723141
Change-Id: I8310b39b916609181de332622def975b8f02a8e2
Reviewed-on: https://chromium-review.googlesource.com/979375
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550515}

This CL fixes the anchor point for permission bubbles in hosted app
windows where there is no location bar to anchor to. Instead they
anchor to the app menu button in the title bar. Previously they would
anchor to the top left of the window.

Before:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=333976&signed_aid=xJPvJxrv89kmG6kAZhF0BQ==&inline=1

After (without location bar):
https://bugs.chromium.org/p/chromium/issues/attachment?aid=333977&signed_aid=9OR5wJQecvy4ZcBjUBU7hA==&inline=1

After (with location bar):
https://bugs.chromium.org/p/chromium/issues/attachment?aid=334359&signed_aid=dcPRBhCpeAmfmG5ixtDJ_w==&inline=1

This change does not affect regular tabbed browser windows.

Bug: 814532
Change-Id: I51f87b710764d4f156834e4fa9ce0e7e10450ad8
Reviewed-on: https://chromium-review.googlesource.com/1004886Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550514}

Intent-to-implement-and-ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/zCQe7UkR07w

Bug: 819482
Change-Id: I5645d5711d7fe1323992533e6c73593ba59d1bca
Reviewed-on: https://chromium-review.googlesource.com/1009450Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550513}

Unfortunately this builder seems to have a recipe bug with
analyze and the way it runs one of the test suites.

R=jchinlee@chromium.org, tandrii@chromium.org
TBR=jbudorick@chromium.org

Bug: 832483
Change-Id: I64d774535b52a92981a597d6c23e45659ae6aae1
Reviewed-on: https://chromium-review.googlesource.com/1011825Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550512}

The KeywordHintView should be dark in incognito mode in touch. Fix.

This patch also fixes a bug where the KeywordHintView would not update itself if
the browser window was resized with it showing.

See screenshots -
https://drive.google.com/file/d/1RM2TC9Wg3Js6UCrntkWc808pj_S3A59b/view?usp=sharing

Bug: 830328
Change-Id: If9bb98d447454d34448cd9d63d31e6afc471cecc
Reviewed-on: https://chromium-review.googlesource.com/1004714Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550511}

conformance2/transform_feedback/too-small-buffers.html
on Win NVIDIA OpenGL no_passthrough

BUG=832238
TBR=kbr@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie44d23e20053e06e7c355b2b20609a37b3d049ba
Reviewed-on: https://chromium-review.googlesource.com/1011597
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550510}

Should cancel the stated showing menu animation for repeat power button
releases. Otherwise, the ongoing animation will run the callback function
SetShowMenuAnimationDone to start |pre_shutdown_timer_|
OnImplicitAnimationFinished after release the power button. This will lead
to device power off.

Bug: 831915
Change-Id: I07753f4156dfc7ba299c37f8fd7a7551d5ec858a
Reviewed-on: https://chromium-review.googlesource.com/1009485Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550509}

Disable overscroll history navigation on Windows Touchpad with
feature flag. This CL also wraps all changes in crrev/c/98210
and crrev/c/1003214 behind this flag.

This CL also disable overscroll history navigation on Linux
Touchpad since we will set has_precise_delta for Linux soon.

Bug: 647140
Change-Id: Id08654bf20b3ada7b5e75f2308a915efeed0e934
Reviewed-on: https://chromium-review.googlesource.com/1002866
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550508}

This change adds an emoji icon to be shown along with the menu text.
https://screenshot.googleplex.com/LO3aKXYwaqc.

For more details, see http://go/chrome-emojisertion.

Bug: 827404

Change-Id: I2b480a7a60ca92ceeb042bdc347ebb5441fd71f7
Reviewed-on: https://chromium-review.googlesource.com/1010978Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550507}

Expecting readyStateChanged() to quit the message loop and do
nothing else appears to be unreliable due to us having configured
our ScopedTaskEnvironment for asynchronous execution. Switching to
a manually queued version would be painfully verbose given all the
happenings of the underlying demuxers and decoders; so instead
wait for loading to complete instead of quitting mid-way through
the loading process.

BUG=831566
TEST=tests don't flake under tsan.

Change-Id: If59ab647bb349bf996050545bb63b0e65cc471e2
Reviewed-on: https://chromium-review.googlesource.com/1011642
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550506}

Changes the color from 212121 to 202124. This also makes sure that the
site permission (page info) icons are rendered close to their correct
GG700 by default (they are derived from this text color).

Bug: chromium:820531, chromium:821996
Change-Id: Ic1c52198e5a8a3d958684bb1ddb61e0510311ec1
Reviewed-on: https://chromium-review.googlesource.com/1011548Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550505}

This method is used from ToolbarActionsBar to see if
BrowserActionsContainer is larger than all visible actions (and needs
to be downsized).

Per a recent change this was clamping to the ToolbarActionsBar max size
which would make ToolbarActionsBar think it's already the appropriate
full size and not not animate it to the smaller new full size.

Bug: chromium:831977
Change-Id: I1a8b3a83504a4f0afcf6e72146bef0e85ecc4fd9
Reviewed-on: https://chromium-review.googlesource.com/1011343Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550504}

Bug: 831004
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I55a1de65656bb646b9954dfafa5199dc3667867e
Reviewed-on: https://chromium-review.googlesource.com/1010913Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550503}

Also changes Installable to an enum class to avoid accidental
implicit casts to bools.

Bug: 801940
Change-Id: I186d878b338375e339b3b5eb24fa5f2abd6c975a
Reviewed-on: https://chromium-review.googlesource.com/981835Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550502}

Bug: 820883
Change-Id: Id1fe9224d8a0a39104a44205799ddc9d9093dc89
Reviewed-on: https://chromium-review.googlesource.com/1005637
Commit-Queue: Paul Dyson <pdyson@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550501}

This CL will parse the rich entity image dominant color and the image
URL. The data is not yet used on the client, that will happen in a later
CL. (Similar to the prior CLs which moved the values from the
CompleteServer to GWS; then from GWS to Chrome; now this moves the values
from the received JSON data to closer to the GUI code).

TBR=mpearson@chromium.org

Bug: 798631
Change-Id: I1d4a31e4b149669c058340ad856ebf89f0663147
Reviewed-on: https://chromium-review.googlesource.com/994129Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550500}

This depends on crrev.com/990203.

UI spec: page 10 in
https://docs.google.com/presentation/d/1Kp8trbUeYH8W04pX14WHi99u7_QdSIx7QpuaH3idCeg/edit?usp=sharing

Screenshot:
https://drive.google.com/file/d/19AvhiZCyinocnfpoaa5HxEo3m1kSJ6d2/view?usp=sharing

This also change UpdateAutoHideFrame to check if it's maximized/fullscren or pinned
so that autohide happens when the state switched to maximized.

I also fixed TestClientControlledStateDelegate::HandleBoundsRequest. It should commit only if
it has something to commit.

BUG=b/33693796
TEST=manual. covered by unittest.

Change-Id: I0ac1b9a57112c0e7d86745f990fa16ab1c7d7945
Reviewed-on: https://chromium-review.googlesource.com/1009205Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550499}

With the WebGL conformance roll in
https://crrev.com/d5fd79c66c041e669cb7cc0d0a41dbcdac886649 , this test should
be passing reliably.

Tbr: kainino@chromium.org
Bug: 818336
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I3fbff79ce0cd11afc562870dd4f05ed06303bafd
Reviewed-on: https://chromium-review.googlesource.com/1011593Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550498}

These tests no longer exist.

Bug: 715640
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I51cf81a18df2b3740613b0c08c8eceb64424e747
TBR: shimazu
Reviewed-on: https://chromium-review.googlesource.com/1011524Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550497}

the overhead associated with seeding the generator.

One can do ~18 M (~26 M) calls per second when using
unifom_int_distribution on top of Mersene engine versus <1M (~ 8M) calls
per second when using the current implementation on POSIX and Windows,
respectively.

Note that these figures are obtained when the generator is seeded once,
otherwise the figure obtained for the suggested implementation would
be <1M (this is for POSIX, we don't have the figure for windows).
To that end, we use thread's local storage to seed the generator once.

Change-Id: I628d2e0ab882a9703e52b4007d53fa5cf49d4d47
Reviewed-on: https://chromium-review.googlesource.com/982115
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550496}

This CL corrects the initialization value of |display_id| from -1
(which is bad) to what it used to have before the CL reviewed in

https://chromium-review.googlesource.com/c/chromium/src/+/970085/23/ui/ozone/platform/drm/common/drm_util.cc#b385

The -1 it breaks (at least) amd64-generic-tot-chromium-pfq-informational
(see bug).

TBR=dnicoara@chromium.org since it's a trivial fix and has been verified.

Bug: 832136
Change-Id: I3c1db741979f20877483880b87f2d052b2a02cf9
Reviewed-on: https://chromium-review.googlesource.com/1010517
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550495}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/20586d941c23..d2c34b35c8b1

$ git log 20586d941..d2c34b35c --date=short --no-merges --format='%ad %ae %s'
2018-04-04 cmtice [clang-tidy-builder] Fix some issues with builder not finding logs.
2018-02-28 phobbs cidb: Remove status arg from latest build requests

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:831200,chromium:None


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I8b28b7da1eaa3ffaf2f4053403ac9c80b5a1e2bf
Reviewed-on: https://chromium-review.googlesource.com/1011219
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550494}