- 26 Nov, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8e8781a2b944..a1cb75450db1 Created with: gclient setdep -r src-internal@a1cb75450db1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I30ba281689d14e96127bf73f1a537f8d64ab3274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935083Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719123}
-
Dominic Farolino authored
Bug: N/A Change-Id: Ie297ab97852df2694e205ae977ef97f279d7b0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935815Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#719122}
-
Friedrich Horschig authored
This change adjusts the bottom sheet behavior when closing. The main problem was that the half state would always be skipped when swiping down. Since the previous state was guessed during a scroll, this allows for unpredictable behavior, e.g.: - scroll a sheet in half state up for 3 pixels but don't release - scroll the sheet down for 2 pixels Instead of bobbing back into place, the sheet would skip the half state. This CL stores the start of the scrolling which fixes this. Additionally, skipping the half state isn't always intended (see linked bug). This CL keeps this default behavior but allows BottomSheetContent objects to override it. Bug: 1024213 Change-Id: I108f2e1069f13731b856b73a915d91741d8a176d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931076 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#719121}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5069a6c9..e78d04eb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3a157aaa4c29aae9982d0019387de53f292879b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936390Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719120}
-
Mohamed Abdelhalim authored
Make the callback function boolean, that return true to skip the On*ChecksComplete functions. And use |state| instead of |complete_callback| to determine the right function to call. Bug: 916537 Change-Id: I4ae0af25e687868d121a238c31632b89b0c0df2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919210Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#719119}
-
Greg Thompson authored
This verifies that a mapped file cannot be deleted, but can still be moved as long as it was opened with appropriate sharing settings. It happens to be the case that the Windows loader uses compatible sharing settings, so a mapped file can ordinarily be moved from one name to another on the same volume. This change also disables the whole test suite, as it is an educational experience and doesn't need to be run on the bots all the time. BUG: None Change-Id: I47b4c76e97ab159c484aa1ca3ee6d4e7e6bfa4b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768764Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#719118}
-
Peter Marshall authored
A lot of our tests don't await promises which means they can rely on ordering of tasks in the backend which is not guaranteed. Upcoming work on the inspector task scheduler makes some of these tests start to flake because they expect events to happen in a certain order, even when they don't await those events. These tests might already be flaky because of this but it's hard to tell. These aren't the only tests that don't await protocol messages but I focused on tests that use Target.setAutoAttach or runIfWaitingForDebugger as they trigger the flakiness. Change-Id: I4709c47256ad7ff557a34d0def1721ceaa8af706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936289 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#719117}
-
Felipe Andrade authored
Replaces the usage of banned method (std::to_string) on authpolicy credentials manager files by the appropriated one. In this case, since the notification_id is not an user-visible string, the locale-independent method base::NumberToString will be used. Bug: 1027241 Change-Id: I7884f0dbeabefa315d4b1c096c89654d4f5e9719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929811 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719116}
-
Francois Beaufort authored
This CL replaces the vectorized icon for NFC settings with png images so that it can be decoded in the Page Info UI. Without this, icon was not visible. Screenshots: https://photos.app.goo.gl/k7wz55v9ELVTS19i8 Bug: 520391 Change-Id: I356a15a24e4cfdb9d236cb92b6b45355564e3327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932541Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#719115}
-
Rohit Rao authored
Resources in //components can be shared by desktop and iOS. BUG=1027249 Change-Id: I8f262f7b5cba0bb500b596340b63ee518d6552f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929554 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719114}
-
Andreas Haas authored
With a recent change, ArrayBuffers are allowed to have nullptr as their `Data` pointer. However, a condition in ArrayBuffer::Transfer bailed out if Data() was nullptr. I changed the condition now, and added a test. R=haraken@chromium.org Bug: chromium:1027937 Change-Id: I2fe466bcfe016d850f11211f2ef8104f1f27d41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932791 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#719113}
-
Tanmoy Mollik authored
Closing out these bugs as they are either not used in production code anymore or are simple renaming that seems unnecessary now. Bug: 1010878 Change-Id: I1a0def462163d989f60bd0d5ad429a8db3e1ef76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930565Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#719112}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da4c7cba65d0..8e8781a2b944 Created with: gclient setdep -r src-internal@8e8781a2b944 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I4c85e6143c0b0d531f98b909e4102343cbb10308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935789Reviewed-by:
-
Andreas Haas authored
Again I added a checked getter of return type unsigned for legacy code. We will replace uses of that getter eventually. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I3e7b8aa82cc4f98e44320276d4156c337054af21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932902Reviewed-by:
-
Colin Blundell authored
This CL ports WebLayer to share the //components-level SSLBlockingPage rather than having a custom fork. Changes to enable this: - The configuration done in //weblayer's SSLBlockingPage::Create() is moved to //weblayer's SSLErrorHandler::ShowSSLInterstitial() Differences between //weblayer's ssl_blocking_page.cc and the //components-level ssl_blocking_page.cc mainly relate to the latter's usage of CertReportHelper, which helps report invalid certificate chains: - The latter calls CertReportHelper::PopulateExtendedReportingOption() in its PopulateInterstitialStrings() method - The latter calls CertReportHelper::HandleReportingCommands() in its CommandReceived() method - The latter inherits SSLBlockingPageBase::OnInterstitialClosing(), which calls UpdateMetricsAfterSecurityInterstitial() and CertReportHelper::FinishCertCollection() [the //weblayer version's impl of OnInterstitialClosing() is empty] A final difference is that the latter inherits SSLBlockingPageBase::OverrideRendererPrefs(), which takes action if |renderer_pref_callback_| is non-null. In the //weblayer context |renderer_pref_callback_| *is* null as SSLBlockingPageBase::set_renderer_pref_callback() is never invoked, so this particular difference won't have any behavioral impact. Bug: 1025059 Change-Id: I64795ed164cc9e3d778d5ef6d9d505badc9d741a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924570 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#719109}
-
Olya Kalitova authored
Adds configuration step to Crostini installer dialog steps. That step is present only when CrostiniAnsibleInfrastructure feature flag is enabled. Bug: 1022784 Change-Id: Ia0201eb75780be5691774a9546ae2c43c91c8b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910232 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#719108}
-
Wenxiang Qian authored
This fuzzer will test sqlite3 FTS3 shadow tables and related functions by implementing a custom structure aware fuzzing. It will try to generate some grammatical correct queries to manipulate shadow tables, or to execute some built-in functions of FTS3 to find memory corruption vulnerabilities. Bug: 1025467 Change-Id: I809fe02efd43449bee8a072e490309175e533d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924174 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719107}
-
Eldar Rello authored
Re-enable testing of wpt/webrtc/RTCPeerConnection-setRemoteDescription-rollback.html and improve some test cases Bug: chromium:1025557 Change-Id: I5be63e394c830faf55442d62a053e100875de5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932793 Commit-Queue: Eldar Rello <elrello@microsoft.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#719106}
-
Chris Blume authored
This reverts commit ea6b9281. Reason for revert: It turns out the V8 team needs the MSVC build. :) I tried installing the Clang compiler as part of Visual Studio 2017 and 2019 but neither of them became options in the toolchain. I'll need to spend more time figuring out how to get Clang on Windows. Original change's description: > Remove use of inline ASM in insert_string_sse > > It seems that some years ago clang@Windows didn't have the > proper intrinsic required, which prompted the use of inline > ASM. > > It has a side effect in that it will allow compilation of the > optimized function within the same compilation unit while using regular > compiler flags (i.e. 'crc32' instruction on x86 requires some special > compiler flags). > > Main issue is that inline ASM is blocked on dependencies (e.g. 'base') > that will be linked to NaCl. > > The main idea here is to allow the whole Chromium code base to use the > highly optimized checksums in zlib (e.g. crc32 and Adler-32), exported > through an interface (i.e. base::Crc32()). > > This patch fixes this issue by removing the use of inline ASM. > > The workaround is to use clang/gcc 'target attributes' to instruct the > backend to use different code generation options for the optimized > function, see: > https://clang.llvm.org/docs/AttributeReference.html#target > > Bug: 902789 > Change-Id: I0d139268aefb8335310c0e3f6533006be9af6470 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931272 > Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org> > Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718788} TBR=cavalcantii@chromium.org,cblume@chromium.org,mtklein@chromium.org,adenilson.cavalcanti@arm.com Change-Id: I6b3fcce10197121b548300855710e99f7048f1ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936189Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#719105}
-
Oriol Brufau authored
The specification added a step to increase sizes to accommodate spanning items crossing flexible tracks instead of ignoring their contents completely. This is done after handling all grid items that don't cross such tracks, and this time items are considered together, not grouped by their span size. This is a reland of r705228, which was reverted due to a performance regression. The main problem was that non-spanning items in flex tracks have to be handled with a variant of the algorithm for arbitrary spans, which was much slower. But now that has been greatly improved by r714511 and r715665. I have also refactored the patch to avoid worsening the performance of spanning items that don't cross flex tracks. However, the algorithm for arbitrary spans is still a bit slower than the one for span of 1. Therefore the nested-grid perf test will decrease by ~5%. This is expected since it has lots of non-spanning items in flexible tracks, that will now be handled with the arbitrary span algo. Spec: https://drafts.csswg.org/css-grid/#algo-spanning-flex-items BUG=935102 TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001.html TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002.html TEST=third_party/blink/web_tests/fast/css-grid-layout/flex-and-content-sized-resolution-columns.html TEST=third_party/blink/web_tests/fast/css-grid-layout/grid-gutters-and-flex-content.html Change-Id: I4dfae4a0293aea611b04b59738cfced5e4fe8d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913406 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#719104}
-
Antonio Gomes authored
BUG=787254, 939192 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ic4d7594070d71ca8ca9153ca197a8d9b4ade053f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932089 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#719103}
-
Mikel Astiz authored
Sync change events are posted in the background thread and BookmarkPromoHeader is not intended to be used in the background thread, so task-posting is required. Bug: None Change-Id: If2998f82fef6f66101d176bc8932c2a3a7b6c1ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929056 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#719102}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2ed1ad81. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Idc03c1a7fbbd04cb6c71fededccc0d8557d8b904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936387Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719101}
-
Tim Schumann authored
TBR=rockot@google.com BUG: 1027940 Change-Id: Icbcb8571b994c8de778c952654037095f7578bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936215Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#719100}
-
Mark Cogan authored
This CL updates the page control assets for Incognito with the updated designs used elsewhere in the app. Also, this CL removes all of the (unneeded) 1x assets from the tab grid, removing the associated parts of the Contents.json and BUILD.gn files. Bug: 1021891 Change-Id: I9f790a89233748e644133676057d900590db8aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929234 Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#719099}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/72e6cb0b3f54..d5e2f215d65d git log 72e6cb0b3f54..d5e2f215d65d --date=short --first-parent --format='%ad %ae %s' 2019-11-26 handellm@webrtc.org VideoRtpTrackSource: implement encoded source methods. Created with: gclient setdep -r src/third_party/webrtc@d5e2f215d65d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1013590 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I16c7adc64bba9e1c1d2e820839a433534b2261bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936126Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719098}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/52e6614e..5069a6c9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I20b49f0341aee78fac27f1044f387d6a2d8abc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936388Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/070dba7c5d32..da4c7cba65d0 Created with: gclient setdep -r src-internal@da4c7cba65d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1023605 Tbr: jbudorick@google.com Change-Id: Ie9878fd1ce77d1e54bb549a38218f870c39653c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936123Reviewed-by:
-
Fergal Daly authored
This makes the Fake usable in more circumstances and is in line with the real implementation. Bug: 1024716 Change-Id: I7ca40f3df08f4575255c0008e9db010888e1788e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928108Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#719095}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f2637d0dd7eb..ae3c27d5c5c3 git log f2637d0dd7eb..ae3c27d5c5c3 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 bclayton@google.com Merge changes I672a4d28,I4a74212f,I5c51e8aa,I323ea936 Created with: gclient setdep -r src/third_party/swiftshader@ae3c27d5c5c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I851697aa16d7f54df98b752c1ffc50b03c16fabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936118Reviewed-by:
-
Maksim Ivanov authored
This removes the "Learn more" link from the <security-token-pin> Polymer element, which is shown during SAML-based login when the smart card authentication is used. The link was a placeholder anyway, and, now that it was negotiated with UX and Product that we won't have any help article for it, we're removing it from the UI. Bug: 1024251 Change-Id: I23cfc4e69e650e97e84353ec53c562dd6b0a91fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932665Reviewed-by:
-
Ewann authored
- Deletes margin. - screenshots: https://photos.app.goo.gl/KrJZVkFKRnb4Avxk8 Bug: 1021893, 1022450 Change-Id: Ic598ef50fc69384824bc969f1930efd23fa45586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904084 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719092}
-
Yuta Kasai authored
This patch is a part of FetchEvent WorkerTiming patches. This feature enables a service worker to attach PerformanceMark/PerformanceMeasure timings to a request during the fetch event handler. The timings will then be exposed to the page using blink::PerformanceResourceTiming. This patch passes a Mojo pending receiver for WorkerTimingContainer to blink::PerformanceResourceTiming by TakePendingWorkerTimingReceiver() when the request is completed. In order to achieve it, this patch adds receiver to blink::ResourceTimingInfo as a mutable member variable and extends all AddResourceTiming() to pass receivers. The reason of the mutable variable is that it must be passed to blink::PerformanceResourceTiming by move semantics but blink::ResourceTimingInfo is passed only by const reference. blink::ResourceTimingInfo can't be changed to pass by value because blink::ResourceTimingInfo is created by scoped_refptr and it passes its pointer to PerformanceNavigationTiming now. Explainer : https://github.com/wanderview/fetchevent-worker-timing/blob/master/explainer.md Design doc: https://docs.google.com/document/d/1-ebnv7OFiVd3k2-jbtQGO5s3BKHIp7lRx3ujhgNKvB0 Bug: 900700 Change-Id: I04bee9dc1990564db3c102b5f2ce64266cb76a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923869 Commit-Queue: Yuta Kasai <yutakasai@google.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#719091}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f65b212492ec..ab63fd28450a git log f65b212492ec..ab63fd28450a --date=short --first-parent --format='%ad %ae %s' 2019-11-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 39b3005ba560..6f6e3371c92a (1 commits) Created with: gclient setdep -r src/third_party/angle@ab63fd28450a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: cwallez@google.com Change-Id: I778ff3f6384f519621570e6846b43ab81a20d7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936114Reviewed-by:
-
Felipe Andrade authored
Replace auth_policy by authpolicy on files and variables names to make them consistent across the codebase Bug: 964911 Change-Id: I291c8ed90512136dc312fd69699ff5d7c974cad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929245Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#719089}
-
Tim Schumann authored
Fails on linux-chromeos-dbg. TBR=yoshiki@chromium.org BUG: 1027919 Change-Id: I9006192cdc5a8c850f61d9d127b68092bbbf9dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936214Reviewed-by:
-
Jiewei Qian authored
Bug: 1021813 Change-Id: Ie148398f2e670164c3acd82c666335c9d2a71781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921600 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#719087}
-
Jiewei Qian authored
Report system web app install error codes by profile category. Also report CRX Install errors (if occurs) and DisableReason if SWA is disabled somehow. Bug: 1021813 Change-Id: Id46bc63e451784b7ddf1d3bb8628af91bec98c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921599 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platforms where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: Ie59fa348b9715a95c1030a66d0316897f967e360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930822 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: I3c96dc4acd12ed1bb848b384086065afa52e9149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930825 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#719084}
-
