- 22 Nov, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df6d992630bc..f406080c7dee Created with: gclient setdep -r src-internal@f406080c7dee The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibb871b4c5e54f2ea1161eb5c1695f42a6d8dd8f9 Reviewed-on: https://chromium-review.googlesource.com/c/1348009Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610401}
-
Anders Hartvoll Ruud authored
TBR=scottmg@chromium.org Bug: 907862 Change-Id: I3fa8fbb2e75b4744cf47031f233bfd4ce613a38d Reviewed-on: https://chromium-review.googlesource.com/c/1348056Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#610400}
-
Peter E Conn authored
When a TWA leaves the verified origin, the Custom Tabs top bar is displayed and the user can see a close button. This close button would on a normal custom tab close the Activity. On Trusted Web Activities, this should return us to the verified origin instead. Bug: 907535 Change-Id: I9f652a3255afdd23072b32c44db5680172ea33f2 Reviewed-on: https://chromium-review.googlesource.com/c/1346463 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#610399}
-
Owen Min authored
Bug: 904983 Change-Id: I340ccaeaf679bf1d63276daa223b360e80daad2b Reviewed-on: https://chromium-review.googlesource.com/c/1345411Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610398}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 157ff273. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org: external/wpt/mediacapture-streams NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia1a06f523153ba570d0c2ba8ebfde12670770ecc Reviewed-on: https://chromium-review.googlesource.com/c/1347783 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610397}
-
DongJun Kim authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I902571315f77562eecb45dc641d15c03af9fc1fa Reviewed-on: https://chromium-review.googlesource.com/c/1343877 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#610396}
-
Mikel Astiz authored
A server shouldn't be capable of returning network errors; that belongs some other layer that represents the network. This patch moves this support to FakeServerHttpPostProvider which is arguably an improvement already. Bug: 774180 Change-Id: I1e5ebae89ff82f2a1ece78555b79c9732a71ee02 Reviewed-on: https://chromium-review.googlesource.com/c/1348030 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#610395}
-
Alex Clarke authored
This can lead to nested messageloops and it's working by accident currently due to the interactions with the way the SequenceManager and the MessageLoop work. Bug: 863341, 891670 Change-Id: I7b01059638e2ba8a136a7daac387467aab517a3c Reviewed-on: https://chromium-review.googlesource.com/c/1347353Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#610394}
-
Lowell Manners authored
This CL deletes unused includes of ProfileOAuth2TokenService from profiles_state.cc. This aids in the conversion of the codebase from ProfileOAuth2TokenService to IdentityManager. Bug: 904406 Change-Id: Ibb8f9ca0c7d27b51857ce5932600972db109682b Reviewed-on: https://chromium-review.googlesource.com/c/1346452Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#610393}
-
Esmael El-Moslimany authored
buttons wrap, show scroll Bug: 905991 Change-Id: I63668926091cb84a9ba11c2c4a8310f54883ccbf Reviewed-on: https://chromium-review.googlesource.com/c/1347200 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#610392}
-
Yutaka Hirano authored
IDL defined ReadableStream was not extendable because it didn't use provided |info.Holder()| as its wrapper. Instead, it creates a new wrapper in Create functions. This CL solves the issue by making the constructor "custom". The custom constructor creates a blink::ReadableStream first, then associates it to the wrapper, and then calls the appropriate Init function. Bug: 906476 Change-Id: I91a7fec1cf4ee5e08704a944b0af852584d1679e Reviewed-on: https://chromium-review.googlesource.com/c/1347643 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#610391}
-
Victor Costan authored
This CL should not introduce any behavior changes. Change-Id: Ia2555accf1b2b8ef48c52e79d915e69ba834e6e3 Reviewed-on: https://chromium-review.googlesource.com/c/1342860Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#610390}
-
Sergio Villar Senin authored
It was using the SigninManager API to check whether the primary account was authenticated and an authentication was in progress. We can use the IdentityManager and PrimaryAccountMutator APIs to perform the same operations. Bug: 890801 Change-Id: Ia2567a567481a4d67b68eee6b714aab72c537b5a Reviewed-on: https://chromium-review.googlesource.com/c/1346467Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL makes it fully legal that bridges can call Delete() or UntrackEntityForStorageKey() of the processor for keys that are not in sync or are already deleted. This was the case even before but this CL removes misleading comments, unnecessary DLOGs and extends documentation in the interface. Bug: NONE Change-Id: I305c7301f35543908813ef6fa78b2d018222c594 Reviewed-on: https://chromium-review.googlesource.com/c/1347368Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#610388}
-
Vladislav Kuzkokov authored
Bug: 891174 Change-Id: I9418e996b6b9401f2c70403b2451c0fe40ab17ac Reviewed-on: https://chromium-review.googlesource.com/c/1343116 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#610387}
-
Sebastien Marchand authored
I'm making some changes to SystemMonitor in a separate CL that make it require that a TaskScheduler instance exists, and as some of these tests use SystemMonitor they need to be modified to use a ScopedTaskEnvironment. Change-Id: I900f8c999f8b16259299b6502145b11e348070ff Reviewed-on: https://chromium-review.googlesource.com/c/1346909Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#610386}
-
Mikel Astiz authored
They verify the very basic requirement of progress markers being peristed and loaded upon restart, which prevents clients to fetch all data from scratch from the server. This also surfaces a bug with USS bookmarks that should be addressed in a follow-up patch. Bug: 856696 Change-Id: I924249579f2d5790f25be6809b03f50d5c421ffc Reviewed-on: https://chromium-review.googlesource.com/c/1347366 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
SigninManager::Observer::GoogleSignedOut had two overload one taking a AccountInfo, and one taking two std::string. The latter is deprecated in favor of the former. As all overrides of the latter version are in components/signin or services/identity, convert them in one CL and remove the old method (that is now unused). Bug: none Change-Id: I1e65e9d182f7e48e75ed86f43647a57f65bf3d0e Reviewed-on: https://chromium-review.googlesource.com/c/1344094 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
The HTML spec requires SharedWorkerGlobalScope.name has [Replaceable]: https://html.spec.whatwg.org/multipage/workers.html#shared-workers-and-the-sharedworkerglobalscope-interface This CL also fixes a test expectation of wpt/workers/interfaces/SharedWorkerGlobalScope/name/setting.html. The name attribute is now replaceable, so the result should be replaced. Firefox fails the test because of this wrong expectation: https://wpt.fyi/results/workers/interfaces/SharedWorkerGlobalScope/name/setting.html?label=stable&aligned&q=%2Fname%2Fsetting.html Bug: 875714 Change-Id: Id04ae30895a2de4a07e30f49dc1189bb9742f6b9 Reviewed-on: https://chromium-review.googlesource.com/c/1347962Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#610383}
-
Stephane Zermatten authored
This change introduces support for interrupts. Interrupts can be run as part of wait_for_dom with allow_interrupts=true. Interrupts can also run manually, by clicking on a chip, but only if they have a name. Interrupts can run automatically if they have autostart=true. Autostart interrupts are handled differently from normal autostart, as they can happen at any time. Running an autostart interrupt does not prevent runnig a normal interrupt. I tried to keep changes to the main, non-interrupt, path and refactorings to a minimum in this change. The result puts all the complexity into the script executor. I'd like to get it to work, then find a good code split in a follow-up change. The code has resisted all my attempts at reorganization so far... Change to the main, non-interrupt path: - The responsibility for updating the script status is moved to ScriptExecutor, even though the script status map stays in ScriptTracker.This allows tracking script state changes caused by interrupts running. - The WaitForDom now uses the same wait code as ActionDelegate::WaitForElement instead of rolling up its own Limitations: - The payload from interrupts is never sent back to the server. This doesn't allow interrupts to change variables - If an interrupt fails, the failure of the main script is not reported to the server; from the server's point of view, the main script just never finishes. - There's no "prompt" action yet, so interrupts cannot ask questions. Bug: 806868 Change-Id: I12165965783ba479688c4c5b44ab72477ad4ae2b Reviewed-on: https://chromium-review.googlesource.com/c/1340309 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610382}
-
Tsuyoshi Horo authored
I introduced skip_other_interceptors flag in crrev.com/c/1278433 to skip the service worker handling of the synthesized redirection of signed exchange. But this was wrong. We need to call ServiceWorkerProviderHost::SetDocumentUrl() and SetTopmostFrameUrl() even after SignedExchangeRequestHandler started handling the response to reject the service worker API calls from the page in the signed exchange correctly. And also we need to call SetControllerRegistration(null) to reset the controller state. Bug: 894755,907712 Change-Id: Iace762636982429c23ec24d9af6a466468e4b9fb Reviewed-on: https://chromium-review.googlesource.com/c/1347954Reviewed-by:
-
Kent Tamura authored
User-visible changes: - ElementInternals interface has |form| IDL attribute - form.elements and fieldset.elements contain form-associated custom elements Implementation: - ElementInternals inherits from ListedElement, which has logic and data for form-association. A form-associated custom element requires an ElementInternals instance regardless of calling HTMLElement.prototype.attachInternals(). ElementInternals is created on demand, and is stored in ElementRareData. - Hook CustomElementDefinition::Upgrade to handle form association and HTMLCollection invalidation. Bug: 905922 Bug: https://github.com/w3c/webcomponents/issues/187 Change-Id: Ic7828741c112c3c7339eee43b814d23ff706818b Reviewed-on: https://chromium-review.googlesource.com/c/1347950 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#610380}
-
Fredrik Söderquist authored
Per: https://drafts.fxtf.org/filter-effects/#InterfaceSVGFEBlendElement All other browsers expose these already. Bug: 906612 Change-Id: I4be6185d4832d980a5d7c6518dcb0b2ccca2ce82 Reviewed-on: https://chromium-review.googlesource.com/c/1341846Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#610379}
-
Friedrich Horschig authored
This CL ensures Infobars are listening to the keyboard when updating their visibility. Before this CL, they were only listening to layout changes (which is the indirect, less reliable way to achieve the same). Bug: 907062 Change-Id: Ide81fd0c1712b8f22f4de0b4e5a3f2a4203d90af Reviewed-on: https://chromium-review.googlesource.com/c/1346129 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#610378}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9f379f493cd7..efe061bd4f9d git log 9f379f493cd7..efe061bd4f9d --date=short --no-merges --format='%ad %ae %s' 2018-11-22 jie.a.chen@intel.com Optimize HLSL zero initializer 2018-11-22 jmadill@chromium.org Don't use gl::Error in validation. 2018-11-21 jmadill@chromium.org Vulkan: Cache pipelines with Shader Programs. Created with: gclient setdep -r src/third_party/angle@efe061bd4f9d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:898030 TBR=geofflang@chromium.org Change-Id: I125a89563af417fed5d630b2be87b29d98f396f2 Reviewed-on: https://chromium-review.googlesource.com/c/1347083Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610377}
-
Boris Sazonov authored
This CL adds Signin.AndroidGetAccountIdsTime histogram that tracks how much time it takes to get account ids for all accounts on the device. Bug: 906713 Change-Id: Ie59e815fcb469ced15fe308378e7c3fbc07d776a Reviewed-on: https://chromium-review.googlesource.com/c/1342997 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#610376}
-
Anders Hartvoll Ruud authored
TBR=kyleju@chromium.org Bug: 856601 Change-Id: I4ab0da613ba282fab128206a91805593952ba0ff Reviewed-on: https://chromium-review.googlesource.com/c/1347362Reviewed-by:
-
Hans Wennborg authored
The warning still fires when targeting Fuchsia, but the rest should be clean now. Bug: 890307 Change-Id: I65db88d025b3d4744f43d5a742fbb4cdb3ae6d40 Reviewed-on: https://chromium-review.googlesource.com/c/1347279Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#610374}
-
Ken Rockot authored
Migrates audio service and related test code away from using deprecated service APIs (ServiceContext, ServiceTest, etc) in favor of better ones. Bug: 891780,906239 Change-Id: Iba655baf597fabd85fc0151d89cd32cb4b92578f Reviewed-on: https://chromium-review.googlesource.com/c/1345548 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
-
Olivier Robin authored
This reverts commit d15dd85f. Reason for revert: <INSERT REASONING HERE> Original change's description: > [Reland] Block resources in FormStructureBrowserTest. > > The files used for FormStructureBrowserTest are snapshots of real web > sites. They can have link to online resources but should not need them > for the test to pass. > But if the network is really bad, the page can wait for the resource > loading to finish and timeout. > Preventing the resource loading will make the test faster and more > robust. > > Bug: 896173 > Change-Id: I16b02e1d7defd4d950e6ee4cd21bd0133b9ac957 > Reviewed-on: https://chromium-review.googlesource.com/c/1346462 > Commit-Queue: Olivier Robin <olivierrobin@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610366} TBR=eugenebut@chromium.org,olivierrobin@chromium.org Change-Id: I6628a9daa5b9d5a28b3cd9cda86272fe22dec8c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896173 Reviewed-on: https://chromium-review.googlesource.com/c/1347284Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610372}
-
Kent Tamura authored
* window_tiemrs.idl -> window_or_worker_global_scope.idl * dom_window_timers.{cc,h} -> window_or_worker_global_scope.{cc,h} * blink::DOMWindowTimers -> blink::WindowOrWorkerGlobalScope in order to match to the HTML standard. This CL has no behavior changes. Bug: 701499 Change-Id: Iec6fd1cca6d62d4292f6067047c97440d1d31a33 Reviewed-on: https://chromium-review.googlesource.com/c/1347968Reviewed-by: -
Leszek Swirski authored
Start streaming ScriptResources when they are fetched, so that they can start streaming during preload, before the script tag is seen. This is enabled with a new ScriptStreamingOnPreload flag. Bug: chromium:865098 Change-Id: I4a2874bce857a538f4bd35a818254ca9617f1a72 Reviewed-on: https://chromium-review.googlesource.com/c/1185185 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#610370}
-
Christian Dullweber authored
This reverts commit a4831e9b. Reason for revert: still flaky :( Original change's description: > Reland "Update BrowsingDataRemoverBrowserTest to include MediaLicenses" > > Original change's description: > > MediaLicenses can be cleared from the ClearBrowsingData dialog, so update the > > BrowsingDataRemoverBrowserTest to check them as well. This uses the test-only > > External Clear Key CDM to store the license in the file system, if it is > > available. > > This reverts commit e9fc38c7. > > The original CL was flaky due to Mac's only saving file timestamps to > second granularity. As a result it was possible for the newly created license > to be saved with a timestamp prior to the current actual time, and deleting > "old" licenses would include it in the deletion. Change is to wait for some > time on Macs only to ensure that the "new" license has a later timestamp. > > BUG=808690,879812 > TEST=new browser_tests pass > > Change-Id: Ibd7cf65b468f98af9aa583d3f320e54c8f3f223e > Reviewed-on: https://chromium-review.googlesource.com/c/1345248 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: John Rummell <jrummell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610211} TBR=jrummell@chromium.org,dullweber@chromium.org Change-Id: I31ee32ae7bb490ce799c92244f352e5a9a627552 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 808690, 879812, 907799 Reviewed-on: https://chromium-review.googlesource.com/c/1347367Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#610369}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e89f85283d4c..df6d992630bc Created with: gclient setdep -r src-internal@df6d992630bc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5a2b6ee2ccfb1e2019c887d30a9cf0a097a550ce Reviewed-on: https://chromium-review.googlesource.com/c/1347727Reviewed-by:
-
Andreas Haas authored
The new implementation landed already some time ago and is stable, so we can delete the old implementation now. R=mlippautz@chromium.org Bug: chromium:860637 Change-Id: I3cffd1ef0f879d144c5705618165ca52542f3e15 Reviewed-on: https://chromium-review.googlesource.com/c/1345969Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#610367}
-
Olivier Robin authored
The files used for FormStructureBrowserTest are snapshots of real web sites. They can have link to online resources but should not need them for the test to pass. But if the network is really bad, the page can wait for the resource loading to finish and timeout. Preventing the resource loading will make the test faster and more robust. Bug: 896173 Change-Id: I16b02e1d7defd4d950e6ee4cd21bd0133b9ac957 Reviewed-on: https://chromium-review.googlesource.com/c/1346462 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#610366}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5128eeb5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/cookies NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I69eb363f7926d16bed5d03ec85e1df4eb7cfb8cd Reviewed-on: https://chromium-review.googlesource.com/c/1347781 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Vaclav Brozek authored
The new FormData->PasswordForm parser lacks a fall-back pass for local heuristics, if all passwords end up disqualified. This CL implements that according to the design in https://goo.gl/ERvoEN Bug: 906584 Change-Id: I3d0fa466699d2472ad687a14b920943443e06d0f Reviewed-on: https://chromium-review.googlesource.com/c/1344431 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#610364}
-
Anders Ruud authored
This reverts commit 2bbd27e2. Reason for revert: Suspected cause for media-related crashes: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/6886 Original change's description: > Remove synchronous blocking from PipelineImpl::Stop(). > > We should be able to avoid this with careful use of a trampoline > through the media thread after PipelineImpl::Stop() completes. > > BUG=905506 > TEST=passes cq. > > Change-Id: I6a9c1a0e578c48a66af85588879346d26009d2ab > Reviewed-on: https://chromium-review.googlesource.com/c/1336659 > Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610327} TBR=dalecurtis@chromium.org,xhwang@chromium.org,hubbe@chromium.org,sandersd@chromium.org Change-Id: Icc496d243065d76268ac22c87a03cf959d1e4948 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905506 Reviewed-on: https://chromium-review.googlesource.com/c/1347365Reviewed-by:
-
Victor Costan authored
https://crrev.com/c/1315959 and https://crrev.com/c/1341921 made it possible to use SQLITE_DEBUG for SQLite fuzzers, which has uncovered bugs. Unfortunately, the CLs unintentionally removed ENABLE_SQLITE_API_ARMOR from non-fuzzing builds, reducing our ability to catch API misuse. This CL re-instates ENABLE_SQLITE_API_ARMOR for non-fuzzing builds, for the reasons described above. It also removes -Wno-implicit-function-declaration in return for a less intrusive workaround in sqlite3_shim.c. Bug: 900910 Change-Id: I6327fdcee173c384da0b3b62c1414b7b6126473f Reviewed-on: https://chromium-review.googlesource.com/c/1345649 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610362}
-
