GitLab

BUG=728116
TEST=crash no longer repros

Review-Url: https://codereview.chromium.org/2919593005
Cr-Commit-Position: refs/heads/master@{#476306}

This CL makes MainActivity#getStartUrl() and
WebApkUtils#getHostBrowserPackageName() share code.

BUG=None
NOPRESUBMIT=true

Change-Id: Ic6aa3f1a959a0f342979aa24c9c7bdcea293983d
Reviewed-on: https://chromium-review.googlesource.com/517563
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476305}

All GetPartAsBytes() callers request data from the beginning of the buffer,
so the method doesn't need a position argument.  Then it essentially turns
into GetAsBytes(), and we can consolidate the two.

(the hidden motivation here is to remove SharedBuffer random-access
semantics, to facilitate future refactoring).

BUG=728627

Change-Id: I63f9ff2f87a01cc4980d38526531dc9118dd87c8
Reviewed-on: https://chromium-review.googlesource.com/519682Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476304}

When a recording does SaveLayerAlpha followed by a single drawing op
and a Restore, we can optimize that as drawing the single op with a
modified alpha. When we can't do this optimization, we were sometimes
throwing away the bounds of the SaveLayerAlpha. This would make a
different set of calls for SaveLayerAlpha-Draw-Draw-Restore vs
SaveLayerAlpha-Draw-Restore, where the latter would not use the
bounds but the former would.

Because we were dropping bounds, we've accrued code that gave
incorrect bounds and relied on them being dropped. I've fixed that
in PaintGeneratedImage in this CL to give correct LayoutTest results.
This change is verified by layout tests such as
http/tests/csspaint/background-image-alpha.html
which would fail with this CL if we didn't make the change, as this
CL would cause us to clip things outside the incorrect bounds.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2914863003
Cr-Commit-Position: refs/heads/master@{#476303}

If the active tab is currently null (e.g. Chrome Home NTP is showing)
use OfflinePageBridge#getForProfile() rather than
OfflinePageBridge#scheduleDownload() to avoid the need for a
WebContents.

BUG=725375

Change-Id: I8fb5778402a0e107f481e8a49a5a264876967ac6
Reviewed-on: https://chromium-review.googlesource.com/520622Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Theresa Wellington <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476302}

This CL adds an animation that keeps the resuming Activity hidden for 500ms while 
starting up to allow time for us to draw the black overlay, also added in this CL,
and prevent 2D UI from being shown while entering VR.

This also performs some cleanup around VR entry (now that it's even more async than
before) to ensure that we don't continue trying to enter VR after we try to exit
VR (like when the activity is paused, etc.).

Bug: 728148
Change-Id: I344ad661b632bde74764b134e9d9f70f6258d68d
Reviewed-on: https://chromium-review.googlesource.com/519483Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476301}

Only CrHome is implementing this feature and requires it to be enabled
by default.

In order to disable it on demand for other platforms, the feature is not
deleted (yet).

BUG=703994

Review-Url: https://codereview.chromium.org/2920773002
Cr-Commit-Position: refs/heads/master@{#476300}

The view.width and view.height return the viewport width and height
*excluding* any classic scrollbars. These values are in CSS pixels. The
current implementation of these functions would subtract out the
scrollbar thickness but failed to apply browser-zoom to the scrollbar
(it does correctly apply pinch-zoom though). This patch scales the
subtracted thickness by the browser-zoom factor.

Bug: 728460
Change-Id: I35a3a033ac2909e4191da12cad173ace492f4218
Reviewed-on: https://chromium-review.googlesource.com/520666Reviewed-by: David Tapuska <dtapuska@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476299}

Setting min_size to 32px for fetching favicons from a Google server
increased failure rate in Chrome M60 3x.

This CL is an emergency fix (merge candidate) to be able to proceed with
rollout of this feature in M59. The CL:
 - sets enforced min_size in LargeIconService to 16px,
 - specifies desired_size in SnippetArticleViewHolder as 32px, and
 - fixes a minor bug in ContentSuggestionsService that blocked 
   propagating desired_size to LargeIconService.

Bug: 728518
Change-Id: I9347fe239a58777c4b1d97ceded19e7587f54e28
Reviewed-on: https://chromium-review.googlesource.com/521082Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476298}

Per https://codereview.chromium.org/2902603002/#msg28, we are only going to
enable network time queries on non-ChromeOS desktop browsers.

BUG=725232

Review-Url: https://codereview.chromium.org/2911263002
Cr-Commit-Position: refs/heads/master@{#476297}

This was added back in crrev.com/329674 and appears unused.

R=mgersh@chromium.org
B=716108
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2918663005
Cr-Commit-Position: refs/heads/master@{#476296}

https://chromium.googlesource.com/angle/angle.git/+log/63d8c26..9216a6e

BUG=chromium:727318

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: Iea289d65c9904d1b956e1e39a2e2c4e100778ad7
Reviewed-on: https://chromium-review.googlesource.com/519643Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476295}

FrameView was renamed LocalFrameView which broke our perf tests.
This patch updates the trace names to use LocalFrameView. The
indentation in this patch follows the javascript style guide.

The perf unittests (benchmarks.blink_perf_unittest.BlinkPerfTest) had
a bug where GetRepresentativeNumber was missing parens which is how
this got through.

BUG: 728011
Change-Id: I48ec4efd38ec82338143f931364e7d203a0c771c
Reviewed-on: https://chromium-review.googlesource.com/520711Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476294}

And instead uses ViewTracker

BUG=727934
TEST=covered by tests

Change-Id: Ib9a1f6c894d91053526c85d81ee3a2be849ff955
Reviewed-on: https://chromium-review.googlesource.com/520266
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476293}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

TBR=hashimoto@chromium.org

Review-Url: https://codereview.chromium.org/2907223002
Cr-Commit-Position: refs/heads/master@{#476292}

Preparing PresentationController to be used from modules/remoteplayback/

BUG=517102
TEST=run existing tests

Change-Id: I14f1c431eea6bbf4722f2568393c1bb5d8d45d85
Reviewed-on: https://chromium-review.googlesource.com/518682
Commit-Queue: Anton Vayvod <avayvod@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476291}

leftView bug appears fixed in iOS 9 and 10.

BUG=546295
TEST=make sure tapping near (usually 50px to the right) the omnibox leftView (page info) doesn't incorrectly fire it.

Review-Url: https://codereview.chromium.org/2917703003
Cr-Commit-Position: refs/heads/master@{#476290}

Stories are flaking with occasional WPR redirect errors.

Bug: 726301
Change-Id: I6df1767a4a069dc9a76c4f56432f21f04c9516ce
Reviewed-on: https://chromium-review.googlesource.com/516708Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476289}

Crash team is preparing to switch stats from being tracked using
histograms to the stability proto. We would like to be confident that we
will not lose accuracy when migrating the old stability proto metric to
a new histogram.

Bug: 726513
Change-Id: I0e3b6eac219b731e9eb815723e882c7d45bfdbe4
Reviewed-on: https://chromium-review.googlesource.com/517864Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476288}

https://skia.googlesource.com/skia.git/+log/3f3075819f24..baf41bd1c8d9

$ git log 3f3075819..baf41bd1c --date=short --no-merges --format='%ad %ae %s'
2017-05-31 iannucci Convert last step.context stragglers.
2017-06-01 borenet Fix missing CIPD package for Valgrind perf bots
2017-05-31 mtklein reland: We can mask load and store with just AVX
2017-05-31 robertphillips Disable deferred proxies for M60 branch

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: Ibf8637cad87af9bd8590800d87bcd92a53651a97
Reviewed-on: https://chromium-review.googlesource.com/520713Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476287}

For some reason 8.3 now requires documentation to accept the license.

BUG=

Review-Url: https://codereview.chromium.org/2873863002
Cr-Commit-Position: refs/heads/master@{#476286}

The VirtualKeyboardTray button was attaching to a KeyboardController instance
that was being replaced without attaching itself as an observer to the new one.

BUG=726273
TEST=manual

Review-Url: https://codereview.chromium.org/2916653002
Cr-Commit-Position: refs/heads/master@{#476285}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=justinlin@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2914593002
Cr-Commit-Position: refs/heads/master@{#476284}

Many of these are only one or two pointers large anyway (e.g. AtomicString,
Vector), so using the heap doesn't save memory, and just adds a pointer
indirection to each access.

Change-Id: If63b228bd0b5f8040c7b13134f063c1e26322f85
Reviewed-on: https://chromium-review.googlesource.com/519846Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476283}

RenderWidgetHostViewGuest resends unconsumed GestureScrollUpdates to
its embedder (via BrowserPluginGuest::ResendEventToEmbedder) which
are then individually wrapped by RenderWidgetHostImpl with
GestureScrollBegins and GestureScrollEnds. Hence OverscrollController
(a) sees a GestureScrollEnd immediately following every
GestureScrollUpdate and ends the overscroll gesture, and (b) does not
see GestureScrollUpdates consumed by the plugin, so
OverscrollController starts an overscroll gesture even though the
content of the plugin was scrolled. Also, OverscrollController does
not have a chance to filter the plugin's gesture events, so even if
an overscroll gesture has started, the plugin can start consuming
scroll updates again.

We now notify OverscrollController (as well as the Mac history
swiper) of the ACKed gesture events from the plugin, so that it
can update its state correctly and allow it to filter the gesture
events of the plugin. They also ignore the wrapper
GestureScrollBegins and GestureScrollEnds as they do not indicate
the beginning/end of the user's gesture.

Note that OOPIF-based guests do not use this resending logic. They
instead rely on RenderWidgetHostViewChildFrame's scroll bubbling
logic. Ensuring this is correct w.r.t. overscroll is being tracked
in crbug.com/713368 .

BUG=694393
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2815823003
Cr-Commit-Position: refs/heads/master@{#476282}

This is needed to be able to run disk_cache_perftest on the platform.

This just uses the Linux implementation, but provides a syscall wrapper
since NDK won't provide one at the API level we build for.

BUG=722885

Review-Url: https://codereview.chromium.org/2885423002
Cr-Commit-Position: refs/heads/master@{#476281}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implicitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=finnur@chromium.org

Review-Url: https://codereview.chromium.org/2915523002
Cr-Commit-Position: refs/heads/master@{#476280}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=sergeyu@chromium.org

Review-Url: https://codereview.chromium.org/2911893003
Cr-Commit-Position: refs/heads/master@{#476279}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=mathp@chromium.org

Review-Url: https://codereview.chromium.org/2908973003
Cr-Commit-Position: refs/heads/master@{#476278}

Story is failing consistently on mac retina bot.

TBR=nenguyen@google.com

Bug: 728576
Change-Id: I6706b20a0465300f969a720c6f23170fab5d8eb5
Reviewed-on: https://chromium-review.googlesource.com/521047Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476277}

This CL adds new GooglePlayInstallResults to better determine the install
failure reason when IPlayInstallService#installPackage() fails immediately

BUG=718475

Review-Url: https://codereview.chromium.org/2906363002
Cr-Original-Commit-Position: refs/heads/master@{#475537}
Review-Url: https://codereview.chromium.org/2917543002
Cr-Commit-Position: refs/heads/master@{#476276}

Currently the results for "blink_gc" in the summary struct are always 0
since we don't actually call the BlinkGC dump provider as it is not
whitelisted. This whitelists the dump provider so we start getting
results.

Bug: 726753
Change-Id: I5228253fcce1baf0ee738d87c70e95ac1c6f9281
Reviewed-on: https://chromium-review.googlesource.com/518115
Commit-Queue: Hector Dearman <hjd@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476275}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2907303002
Cr-Commit-Position: refs/heads/master@{#476274}

After disconnecting some input devices, the next midiInGetNumDevs()
call invokes a callback with MIM_LONGDATA for the disconnected device,
and never returns until the callback completes.
This is unexpected control dependency, and causes a deadlock.

BUG=725448

Change-Id: I39733e4df31223de8f2b7f8e031711496e10ff4a
Reviewed-on: https://chromium-review.googlesource.com/519083Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476273}

This policy should like most other FilePath policies parse variables
in its content before storing its value in its backing pref.

BUG=726007
TEST=unit_tests

Review-Url: https://codereview.chromium.org/2912353003
Cr-Commit-Position: refs/heads/master@{#476272}

This is a refactor-only change. Moved WebTouchPoint & WebMouseEvent
coordinates to WebPointerProperties after renaming the WebTouchPoint
fields.

Bug: 508283
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: If670e3be3cd67d23a2f266a8d37d5eaba204ba18
Reviewed-on: https://chromium-review.googlesource.com/517888Reviewed-by: David Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476271}

For multicol, PageLogicalHeightForOffset() would normally figure out what to
return by consulting the flow thread, which would find the appropriate column
set, which in turn would find the appropriate fragmentainer group and return
its height.

We used to treat a 0 value as "unknown" most of the time (but there were also
cases where we'd accept it as a column height). We now always have to call
IsPageLogicalHeightKnown() first to tell whether it's known or not. This is
reasonable, since the calling code always has to act upon the situation of not
knowing the height (typically skip some steps, since fragmentation is
impossible until height is known).

It is now forbidden to call PageLogicalHeightForOffset() if height is unknown
(there are DCHECKs). The height is unknown in many cases in the first multicol
balancing pass. The height will be known once we have made a column height
estimate. It doesn't have to be the final and correct height. This CL doesn't
change anything in that regard, but now we are required to be sure that we
have some clue at all before dealing with fragmentainer heights.

MultiColumnFragmentainerGroup now has a flag that tells whether the logical
height is known or not. We need the flag, because the logical height may
actually end up as 0, e.g. when a multicol container just has zero-height
content, or when the multicol container itself has a specified height of 0.
This unclamped height will be used as block progression for the column row,
which will contribute to the final height of the multicol container. The
actual column height will be clamped to not be less than 1px. This is in
accordance with the spec [1]. We previously used to treat truly zero-height
fragmentainer groups as having an unknown height in some parts of the code,
while in other parts of the code we'd just accept it and end up dividing by
it (to convert a flow thread offset to a column index, for instance).

This is a clean-up CL that happens to fix bugs.

[1] https://drafts.csswg.org/css-break/#breaking-rules

BUG=722041,722754

Change-Id: I63550d804bef073a5c24570d63bd55176ec5e396
Reviewed-on: https://chromium-review.googlesource.com/514049
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476270}

BUG=728527
NOTRY=true
TBR=smcgruer@chromium.org

Change-Id: Ia880080ed5b84dc6cebe5bf73e84fc100ad5074a
Reviewed-on: https://chromium-review.googlesource.com/520386Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476269}

There was one case that didn't update the FocusManager
correctly. Specifically in ~NativeViewHost it didn't update the
FocusManager. This meant if the NativeViewHost was hosting a child
widget and focus was in a view contained in the child widget, then the
FocusManager was left referencing a view it would never be told to
remove. This fixs that case.

I'm also leaving the ViewObserver case in the code as I think there
are other weird cases like this that are difficult to deal with from a
ViewRemoved perspective. I would really like to remove the explicit
calls to the FocusManager (e.g. ViewRemoved), but that would require
some changes to ViewObserver and WidgetObserver that I suspect would
be tricky to get right.

BUG=687232
TEST=covered by tests

Change-Id: I7ce7bf819f474eb975f74dc7fa1ed4708be2cf0b
Reviewed-on: https://chromium-review.googlesource.com/518542
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476268}

This change ends the WebUSB Origin Trial and enables the feature by
default.

Intent to Ship thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/KuXx_k2KIis/-g-75FScBgAJ

Bug: 492204
Change-Id: I8af69ccd39c9eb0d7200f0fb25566ad189d5f42e
Reviewed-on: https://chromium-review.googlesource.com/513366Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476267}