- 25 Mar, 2015 40 commits
-
-
mostynb authored
BUG=466848 Review URL: https://codereview.chromium.org/1016473003 Cr-Commit-Position: refs/heads/master@{#322250}
-
garykac authored
BUG= Review URL: https://codereview.chromium.org/1032553008 Cr-Commit-Position: refs/heads/master@{#322249}
-
sandersd authored
This does not move all of the previously static methods into the interface yet, just those used by WebEncryptedMediaClientImpl. The rest can be migrated as necessary. This CL also includes a fixes for 457384 and 374751 (containers and codecs must match media type), because it was convenient along with the new interface for checking codec support. BUG=468912,457384,374751 Review URL: https://codereview.chromium.org/1023863002 Cr-Commit-Position: refs/heads/master@{#322248}
-
nednguyen authored
Previously, webpagereplay stores all the stdout & stder of the wpr subprocess to a fix log file path location. It then parses the log lines to get replay server port assignment. When there are multiple telemetry processes running in parallel, this cause a concurrency problem. This patch addresses the issue by create a temp location for the log file path. This is to make sure that different telemetry processes will write & read to different log files. BUG=469296 Review URL: https://codereview.chromium.org/1025553008 Cr-Commit-Position: refs/heads/master@{#322247}
-
rch authored
To facilitate landing actual QuicServer support in Chromium using Chromium's MessageLoop and friends. Merge internal change: 89526581 Review URL: https://codereview.chromium.org/1006193003 Cr-Commit-Position: refs/heads/master@{#322246}
-
afakhry authored
This is a retry CL after making these tests ChromeOS-only tests and disabling them in the official build. Original CL: https://codereview.chromium.org/1026513005/ In order to avoid future regressions on ChromeOS. BUG=469235 TEST=interactive_ui_tests --gtest_filter=AcceleratorInteractiveUITest.* Review URL: https://codereview.chromium.org/1005093004 Cr-Commit-Position: refs/heads/master@{#322245}
-
rkaplow authored
This class write the Net.SocketIdleTimeBeforeNextUse_ReusedSocket Net.SocketIdleTimeBeforeNextUse_UnusedSocket Net.SocketInitErrorCodes Net.SocketRequestTime Net.SocketType histograms. This histograms are all unowned, and have a large cumulative load on user bandwidth and internal google servers. Are these histograms used at all? It appears they have not been used for some time (based on lack of ownership) BUG=469288 Review URL: https://codereview.chromium.org/1027693004 Cr-Commit-Position: refs/heads/master@{#322244}
-
estade authored
If you are not signed into sync or have unchecked "Autofill" then the option should be hidden. BUG=468987 Review URL: https://codereview.chromium.org/1020303007 Cr-Commit-Position: refs/heads/master@{#322243}
-
robertshield%chromium.org authored
BUG=NONE TEST=NONE NOTRY=true Review URL: https://codereview.chromium.org/1006373006 Cr-Commit-Position: refs/heads/master@{#322242}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/aa09e3e..862b1f1 TBR=jchaffraix@chromium.org,loislo@chromium.org Review URL: https://codereview.chromium.org/1034763003 Cr-Commit-Position: refs/heads/master@{#322241}
-
mostynb authored
BUG=466848 Review URL: https://codereview.chromium.org/1004933003 Cr-Commit-Position: refs/heads/master@{#322240}
-
lfg authored
Review URL: https://codereview.chromium.org/1032913002 Cr-Commit-Position: refs/heads/master@{#322239}
-
mostynb authored
BUG=466848 Review URL: https://codereview.chromium.org/1032553009 Cr-Commit-Position: refs/heads/master@{#322238}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c5443d75..b09c6a7d Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org BUG= Review URL: https://codereview.chromium.org/1005693012 Cr-Commit-Position: refs/heads/master@{#322237}
-
xdai authored
Clean up ClearObsoleteWallpaperPrefs() function. It was used to migrate wallpaper data from a very old version of Chrome (probably M32). It should be safe to remove this function now. BUG=171694 Review URL: https://codereview.chromium.org/1003363008 Cr-Commit-Position: refs/heads/master@{#322236}
-
davidben authored
Follow-up to https://codereview.chromium.org/859213006. The DVLOG lines are unnecessary and CertificateSelected implicitly calls StopObserving. BUG=none Review URL: https://codereview.chromium.org/1030233002 Cr-Commit-Position: refs/heads/master@{#322235}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/e523d4f..114912d CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=hcm@google.com Review URL: https://codereview.chromium.org/1015533017 Cr-Commit-Position: refs/heads/master@{#322234}
-
andresantoso authored
Both task_manager_view and task_manager_cocoa define ShowTaskManager(Browser*). http://crrev.com/987483003 mistakenly causes both to get linked when building for Mac. This patch undoes that by moving the task manager files to Cocoa and Views sources. They are no longer inside enabled_task_manager condition check, but they are still excluded from Android this way. BUG=425229 Review URL: https://codereview.chromium.org/1003323005 Cr-Commit-Position: refs/heads/master@{#322233}
-
tommi authored
Revert of Revert of Clean up libjingle.gyp and remove references to libpeer_target_type. (patchset #1 id:1 of https://codereview.chromium.org/1025003002/) Reason for revert: Relanding libjingle.gyp update that removes libpeer_target_type references. The issue on Android has been fixed. Original issue's description: > Revert of Clean up libjingle.gyp and remove references to libpeer_target_type. (patchset #1 id:1 of https://codereview.chromium.org/1008023002/) > > Reason for revert: > See if this caused errors on Android. > > Original issue's description: > > Clean up libjingle.gyp and remove references to libpeer_target_type. > > This variable isn't supported any longer. > > > > BUG=446865 > > > > Committed: https://crrev.com/fd22585c501bdd46f0a511fa5346fc9be1b85f88 > > Cr-Commit-Position: refs/heads/master@{#321371} > > TBR=kjellander@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=446865 > > Committed: https://crrev.com/5e83cd0937a248f3d544800797b0dcbcba6eb13b > Cr-Commit-Position: refs/heads/master@{#321614} TBR=kjellander@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=446865 Review URL: https://codereview.chromium.org/1007063003 Cr-Commit-Position: refs/heads/master@{#322232}
-
pcc authored
This saves a cast and makes this code -fsanitize=cfi-unrelated-cast clean. BUG=457523 R=danakj@chromium.org,weiliangc@chromium.org Review URL: https://codereview.chromium.org/1032803002 Cr-Commit-Position: refs/heads/master@{#322231}
-
alemate authored
BUG=449582 TEST=manual Review URL: https://codereview.chromium.org/1018523007 Cr-Commit-Position: refs/heads/master@{#322230}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/7dd2b95..aa09e3e TBR=jchaffraix@chromium.org,loislo@chromium.org Review URL: https://codereview.chromium.org/1034713003 Cr-Commit-Position: refs/heads/master@{#322229}
-
jdduke authored
This change was reverted in r322170 due to WebView breakage. The ApplicationStatus dependency has been made optional, allowing WebView to opt-out of its use. Original description: ---------------------------- Currently, when an activity is stopped, we explicitly hide the foreground Tab. This is problematic, as current hiding semantics might clear the visual front buffer before the window is hidden. This in turn causes an unpleasant flickering during activity transitions, e.g., when backgrounding Chrome or locking the screen. Wire Activity onPause/onResume notifications to WindowAndroidObservers, allowing the foreground tab to preserve its front buffer while hiding its web content. If the tab is explicitly hidden, or the root window is lost, the front buffer will be cleared as usual. BUG=462752,434401 Review URL: https://codereview.chromium.org/1001573003 Cr-Commit-Position: refs/heads/master@{#322228}
-
anandc authored
BUG=470158 Review URL: https://codereview.chromium.org/1031213002 Cr-Commit-Position: refs/heads/master@{#322227}
-
tfarina authored
It is more traditional (and recommended) to have GN targets closer to the source files it builds. BUG=432959 TEST=gn gen out-gn && ninja -C out-gn compositor_model_bench R=sievers@chromium.org, dpranke@chromium.org Review URL: https://codereview.chromium.org/1032193002 Cr-Commit-Position: refs/heads/master@{#322226}
-
ananta authored
Proposed fix is to discard all unsupported representations (Read fractional scales) in the Extension icon image when the icon is loaded. This ensures that stale caches are invalidated and the correct icons are loaded when the cache is regenerated. BUG=461958 Review URL: https://codereview.chromium.org/1025513004 Cr-Commit-Position: refs/heads/master@{#322225}
-
earthdok authored
Too flaky. BUG=468980 TBR=hirono@chromium.org Review URL: https://codereview.chromium.org/1034813002 Cr-Commit-Position: refs/heads/master@{#322224}
-
xiyuan authored
- Update ProfileAuthData to transfer cookie from sign-in webview; - Passing back usingSAML flag for auth code authentication and use it to set has_auth_cookie flag when SAML is used; - Update UserCloudPolicyManagerChromeOS to fetch initial policy from correct auth request context; - Enable SAMLPolicyTest for WebView; BUG=461505 Review URL: https://codereview.chromium.org/1021383002 Cr-Commit-Position: refs/heads/master@{#322223}
-
rouslan authored
This re-enables spellcheck feedback by reverting commit http://crrev.com/60f701a, because the server is ready to process the feedback. BUG=466794 Review URL: https://codereview.chromium.org/1006953003 Cr-Commit-Position: refs/heads/master@{#322222}
-
holte authored
BUG=410493 Review URL: https://codereview.chromium.org/993813002 Cr-Commit-Position: refs/heads/master@{#322221}
-
danakj authored
This makes the CullSet check into an early out instead of an if-block wrapping a whole function. It also moves the |visible_| early out to the same place from PaintCommon(). This hints at combining Paint() and PaintCommont(). This also moves the |visible_| early out to the other caller of PaintCommon() which is OnPaintLayer(), and can early out before doing the solid color clear. BUG=466426 Review URL: https://codereview.chromium.org/1037513002 Cr-Commit-Position: refs/heads/master@{#322220}
-
sandersd authored
BUG=442586,460616 Review URL: https://codereview.chromium.org/1005903003 Cr-Commit-Position: refs/heads/master@{#322219}
-
sky authored
I want to keep around a MotionEventGeneric and mutate it over time. Since this class is an implementation detail (public API takes MotionEvent) it seems fine to allow consumers of it to mutate it directly. BUG=none TEST=covered by test R=tdresser@chromium.org Review URL: https://codereview.chromium.org/1035793003 Cr-Commit-Position: refs/heads/master@{#322218}
-
jeremyim authored
- Permit DRP RequestOptions to take auth credentials instead of always internally generating them. - Permit DRP Config to perform a reload of the configuration - Create a new DRP MutableConfigValues class which can have its underlying values updated. - Add a configuration refresh timer to DRP ConfigServiceClient, along with backoff logic. BUG=466753 Review URL: https://codereview.chromium.org/1024553009 Cr-Commit-Position: refs/heads/master@{#322217}
-
bnc authored
Add field trial parameters for independently enabling SPDY/3.1, HTTP/2 draft-14, and HTTP/2 protocols. Add a field trial group prefix to trigger parsing parameters, so that behavior of current field trial groups is preserved. Refactor SPDY parameter parsing code to make it similar to QUIC code, also in tests. Write tests for new functionality, for default behavior, and for command line parsing. BUG=469181 Review URL: https://codereview.chromium.org/1020363003 Cr-Commit-Position: refs/heads/master@{#322216}
-
rtenneti authored
Populate slowstart numbers in stats. Merge internal change: 89048638 https://codereview.chromium.org/1030083002/ Add a QUIC connection option(BWMX) to resume to the max bandwidth instead of the last. Merge internal change: 89046643 https://codereview.chromium.org/1037633002/ Populate RTT info in TransportConnectionStats. Moved RttStatsPeer class into a separate file. Merge internal change: 89043159 https://codereview.chromium.org/1009633003/ Deprecate FLAGS_quic_enable_bandwidth_resumption_experiment. Merge internal change: 89021133 https://codereview.chromium.org/1032483003/ Add an extra newline after "Response:" in quic_client's output. Merge internal change: 88898832 https://codereview.chromium.org/1019793009/ QUIC - small formatting changes to keep code in sync with internal source. Merge internal change: 88795283 https://codereview.chromium.org/1037623002/ Low-impact. Dispatcher now uses QuicServerSession, not QuicSession This is a preparatory step for a group of upcoming changes with regards to Stateless Rejects. For stateless rejects, we'd like the dispatcher to access QuicServerSession server-specific information within the session. In order to do that, we need the dispatcher to contain a QuicServerSession object, rather than just a generic QuicSession object. Merge internal change: 88758328 https://codereview.chromium.org/1028633006/ Limit QUIC's send algorithm max CWND by the peer's receive buffer and disable usage of the receive buffer in QuicSentPacketManager. Flag protected by FLAGS_quic_limit_max_cwnd_to_receive_buffer. Merge internal change: 88747441 https://codereview.chromium.org/1023203004/ Improve tests. Correct things clang_tidy complains about. Make QuicTimeWaitListManager::AddConnectionIdToTimeWait virtual so it can be mocked. Correct things clang_tidy complains about. Make a method virtual so it can be mocked. Merge internal change: 88744988 https://codereview.chromium.org/1029463003/ R=rch@chromium.org Review URL: https://codereview.chromium.org/1037643002 Cr-Commit-Position: refs/heads/master@{#322215}
-
danakj authored
We can then merge Paint and PaintCommon. Subclasses should use OnPaint to override display behaviour. R=sky BUG=466426 Review URL: https://codereview.chromium.org/1029943002 Cr-Commit-Position: refs/heads/master@{#322214}
-
dschuff authored
This pulls in the following Native Client changes: a019a57: (dschuff@chromium.org) Update revision for PNaCl bac8dffa: (stichnot@chromium.org) Add pnacl-translate --sz flag to enable Subzero. 81b0050: (mtrofin@chromium.org) Enable using the toolchain (llvm) provided FileCheck. 3ce68ce: (sbc@chromium.org) Cleanup .gitignore file 7a7bed5: (shinyak@chromium.org) FixPath in CheckObjectSize. 26f4998: (sbc@chromium.org) Remove legacy prep_nacl_sdk.py script 2aa5524: (mtrofin@chromium.org) Updated component revisions. 2d8b0bb: (dschuff@chromium.org) Add lint check for IRT sandbox base address hiding. Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/cc3597c9c13978079ef85a31d78dc4bf7f18000c..2d8b0bb6ffaf871fdc1f902d38778b2df8c6ff0d BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build Review URL: https://codereview.chromium.org/1030213002 Cr-Commit-Position: refs/heads/master@{#322213}
-
rdevlin.cronin authored
Field trials can only be initialized once, so the FactoryGet() method cannot be called each time to check the value of the trial. BUG=470278 Review URL: https://codereview.chromium.org/1023673011 Cr-Commit-Position: refs/heads/master@{#322212}
-
dtu authored
As part of the Telemetry public API refactor, I wrote a tool that sorts imports. The tool will be checked in separately, but here's all the import changes in Telemetry and its dependencies. It'll be easier to test the refactor tool if we do the import sorting in advance, so it doesn't clutter the diffs for the module moves. Style guide rule: "Within each grouping, imports should be sorted lexicographically, ignoring case, according to each module's full package path." BUG=449308 TEST=trybots (tools/telemetry/run_tests; tools/perf/run_tests) Review URL: https://codereview.chromium.org/1029263003 Cr-Commit-Position: refs/heads/master@{#322211}
-