- 21 May, 2020 40 commits
-
-
Jeremy Roman authored
It is unclear why this returns a rectangle via out-param. Change-Id: Ic83f7feb8a7a9cf95e017c1b3d72453c55afaad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212481 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#771068}
-
Toby Huang authored
This CL removes an unnecessary period in a tooltip string. Bug: None Change-Id: I1fd78a559e1a867d1478ec5cca3062b0350d0d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211090Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771067}
-
Garrett Beaty authored
M81 is no longer an active milestone. Change-Id: I5e772550fa52ac5ec2d56b5560e3e3b2e95d5e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211121 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#771066}
-
Geoff Lang authored
Remove failure supression for deqp/functional/gles3/framebufferblit/default_framebuffer_00.html TBR=kbr@chromium.org BUG=angleproject:4632 Change-Id: I5baf02a8a80601dbadd5404fe8c3c3bde6bcc1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209332Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771065}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/8b78f8815623..7f483b5ee54c $ git log 8b78f8815..7f483b5ee --date=short --no-merges --format='%ad %ae %s' 2020-05-20 renjietang In QUIC, instead of looking up QuicConnection states, consult the session on whether the connection should be closed on STATELESS_RESET. 2020-05-20 nharper Handle 0-RTT in TlsClientHandshaker 2020-05-20 dschinazi Compute maximum transport parameter size upfront 2020-05-20 dschinazi Remove obsolete stateless reset token length override 2020-05-20 wub In quicconnection::sendallpendingacks, update instead of set the ack alarm. protected by --gfe2_reloadable_flag_quic_update_ack_alarm_in_send_all_pending_acks. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Iee3a7d338f52619e7afc9dd5029f3604587b39e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206922 Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771064}
-
Meredith Lane authored
Adds a setting to implement the Mac specific behaviour for aria-modal="true". The accessibility tree must be pruned of background content, as outlined in the spec: https://www.w3.org/TR/core-aam-1.1/#ariaModalTrue Eventually, this setting may be enabled on other platforms (such as Android). Followups to this CL include: - add blink tests and inspector protocol tests - consolidate logic with HTMLDialogElement AX-Relnotes: Adds support for aria-modal on Mac, to correctly expose modal dialogs to AT. Bug: 1050904 Change-Id: I76b7070e91a71ca7ee890886d9a6aa398911f118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065779 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#771063}
-
Raymond Toy authored
In WaveShaperCurveValues(), there are 5 work arrays that used to be allocated on the audio thread. Move these to the class so we don't do that anymore. And while we're at it, make them AudioFloatArray's so they're appropriately aligned for best SIMD/NEON performance. Running Spotify's Web Audio Benchmark shows that we get 10% improvement in speed for WaveShaper-1x, and about 3-4% for WaveShaper-2x and 4x. No functional changes; all tests pass. Bug: 1013118 Change-Id: Ide6340ee79d567068e0661abd0b20f14bb064166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210821 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771062}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/52fe4b9946f7..8ae7f6e09a0b 2020-05-21 chrome-bot@chromium.org Update config settings by config-updater. 2020-05-21 jeroendh@google.com chrome_util: Copy libondeviceassistant.so when deploying Chrome 2020-05-21 bpastene@chromium.org gs: Update known AUTHORIZATION_ERRORS. 2020-05-21 richardfung@google.com Remove android-container-rvc targets 2020-05-20 vapier@chromium.org cros_mark_as_stable: relax self-repo checks in older branches 2020-05-20 wonderfly@google.com chromeos_config: Stand up master-lakitu-release on R81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I1fb18ebebc31a217403e36a0a22ee849e94fd318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212352Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771061}
-
Henrique Ferreiro authored
//ui/base:base is a big component with many conditional dependencies, making it difficult to check the correctness of its deps and public_deps. This CL moves ui/base/cursor/ files into the //ui/base/cursor:cursor component, to make it easier to add/remove files and check their dependencies. As part of this reorganization, this target is limited to Aura builds. Also, includes were reviewed. Bug: 1085358 Change-Id: Ic835d0c79492c6a0945b12a82f538733f7e90fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181210 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#771060}
-
David Bokan authored
[Reland] - This is effectively a reland, first patchset is unchanged https://crrev.com/74f12a609316ba81 so compare to that for changes. That iteration provided some interesting data but used a triggering time of 5 seconds. I've since learned that there's a myriad of known edge-cases in which events might have delays of 1-20 seconds (!). In our case, we're specifically looking for issues at the upper end of the UMA metric (60+ seconds) so this caused some unrelated noise. This CL relands with a higher threshold and some minor changes to the crash keys. Add a DumpWithoutCrash to KeyPress events where the timestamp of the OS differs from the current time by more than 60 seconds. We see in UMA that we often see events in the 95% percentile reaching many seconds of difference. Hopefully the crash stacks will reveal something about what's causing this. A previous iteration of this investigation in https://crrev.com/c/2111782 showed that we sometimes redispatch events that have been reinjected back from the renderer. This should never happen. This CL adds crash keys to dump some of the related app state to help explain how this happens. However, not all such stack traces showed reinjection so that can't be the cause of all these bad timestamps. This CL also adds some timing information to the existing crash key in NSApp:sendEvent which might reveal something. Bug: 1039833 Change-Id: If49b7b8a918f880ed00a7adf219e589ed66daf6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210867 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
This CL converts FrameMsg_TransferUserActivationFrom to RemoteFrame interface. The |source_routing_id| is also converted to |source_frame_token| as a UnguessableToken type. Additionally, this CL renames TransferUserActivationFrom to TransferUserActivationToRenderer in order to avoid confusing the existing TransferUserActivationFrom in FrameHost interface. Bug: 10833390 Change-Id: I08223aa7e9620e899753e3322a01ce0792739beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208870 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#771058}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b37105ea6cca..d1285b131bcf 2020-05-21 kjlubick@google.com Upgrade CanvasKit emscripten to version 1.39.16. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: If9468294797d5590b2500d98c2f474a6210e26bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212351Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4e15df5d5da..10792279b603 2020-05-21 treehugger-gerrit@google.com Merge "protozero: Add ProtoZero vs protolite benchmark" 2020-05-21 hjd@google.com Merge "ui: Merge global async slice tracks by name" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6edd5805618779e6155c3879ed9028bddc252f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212350Reviewed-by:
-
Henrique Ferreiro authored
This is a precursor CL before moving the rest of the ui/base/cursor/ files to the target //ui/base/cursor:cursor. Bug: 1085358 Change-Id: I46811aa42d8ed5688ff10fd24b3dbaab8531c259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211781Reviewed-by:
-
Sonny Rao authored
Update the following histograms since we're using them to monitor crash rates. Platform.AnyCrashesDaily Platform.AnyCrashesWeekly Platform.KernelCrashesWeekly Platform.KernelCrashesPerCpuYear Platform.KernelCrashesDaily Platform.KernelCrashInterval Platform.KernelCrashesPerActiveYear Platform.KernelCrashesSinceUpdate Bug: 1084069, 1084072 Change-Id: I45eba9b60aa91cfed2da7916c04caf4d017c6f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211471Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#771054}
-
Gabriel Charette authored
e.g. chrome/browser/previews/previews_offline_helper.cc: base::PostDelayedTask( FROM_HERE, {base::MayBlock(), content::BrowserThread::UI, base::TaskPriority::LOWEST, base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN}, base::BindOnce(&PreviewsOfflineHelper::RequestDBUpdate, weak_factory_.GetWeakPtr()), base::TimeDelta::FromSeconds(30)); While such traits don't make sense. It'll be easier to fix them once the migration is complete. Hence allow them temporarily to unblock the migration. R=altimin@chromium.org Bug: 1026641 Change-Id: I737e4a874520adc851e808bdc8dad2f0947fe920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208814Reviewed-by:Alexander Timin <altimin@chromium.org> Reviewed-by:
-
James Cook authored
The parameter |window_tree_host| is always null and isn't needed. It was added for mash/mustash, but that project ended over a year ago. Bug: none Change-Id: Ie6f30ccd07c28d40b15985d640df8f727d7f01a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211128Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#771052}
-
Peter E Conn authored
This CL makes three changes: 1) The TWA disclosure notifications have different IDs depending on whether they are the initial or subsequent showing. This should prevent any messiness with subsequent notifications inherit the channel from the initial notification. 2) The notification has a bigText style set so it can be expanded. 3) The initial channel has sound suppressed and we also set sound to null on the notification for pre-O devices. Bug: 1068106 Change-Id: I7090e0e7e0e7eae339476006520a9b8276406623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207457 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Auto-Submit: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771051}
-
Mohamed Amir Yosef authored
This is a purely mechanical CL that adds the "const" modifier to the the following methods in ComboboxModel: 1- GetItemAt() 2- GetDropDownTextAt() 3- IsItemSeparatorAt() Change-Id: I11ac3034bbed85a1a9e288b6f0ce41343170c84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212044Reviewed-by:
-
Andrew Grieve authored
1. Add error banner 2. Show the failing target 3. Show which targets to add rather than which .jar files to add 4. Show all errors rather than the first from each class. Example error: ============================= Dependency Checks Failed ============================= Target: //base:base_java Direct classpath is incomplete. To fix, add deps on: * com_android_support_support_compat_java * android.support.v4.view.ViewCompat (needed by org.chromium.base.ApiCompatibilityUtils and 1 more) Bug: None Change-Id: I26c6ea94d4df4167737519ad181131f8efecc00b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208813 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#771049}
-
Wenbin Zhang authored
This CL puts the testers for android pixel 2 and pixel 2 webview in perf to 'lightweight' mode with 'skip-perf'. In this case the tester will no longer upload the perf data. Bug: chromium:1045256 Change-Id: Ib69183462f4530b208c3a410c4ed474199ecdc56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209615 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#771048}
-
Mike Wittman authored
This reverts commit a6207513. Reason for revert: causing build failures on https://ci.chromium.org/p/chromium/builders/try/android_compile_x64_dbg/1504 Original change's description: > Roll src/third_party/libunwindstack/ dfd3f3d84..de5bb5ebd (1 commit) > > https://chromium.googlesource.com/chromium/src/third_party/libunwindstack.git/+log/dfd3f3d84cfc..de5bb5ebd6d7 > > $ git log dfd3f3d84..de5bb5ebd --date=short --no-merges --format='%ad %ae %s' > 2020-05-19 wittman [Sampling profiler] Include AsmGetRegs asm functions on x86/x64 > > Created with: > roll-dep src/third_party/libunwindstack > > Bug: 1004855 > > R=etiennep@chromium.org > > Change-Id: If6c111aae6dbfb4bf474b57dba6274e63fb8cbb4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210496 > Commit-Queue: Mike Wittman <wittman@chromium.org> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Auto-Submit: Mike Wittman <wittman@chromium.org> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770701} TBR=wittman@chromium.org,etiennep@chromium.org Change-Id: I73b4a976214f47e3347cee7483ce7aebe7ec4662 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1004855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212443Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#771047}
-
Mike Wittman authored
This reverts commit 01b9624c. Reason for revert: first of two reverts to fix https://ci.chromium.org/p/chromium/builders/try/android_compile_x64_dbg/1504 Original change's description: > [Sampling profiler] Provide unwinder in stack_unwinder DFM > > Implements the Android native/Java stack unwinder within the stack_unwinder > dynamic feature module. > > Adds visibility/assert_no_deps constraints to //base/BUILD.gn to avoid > leaking module implementation types into general Chrome code, which > would defeat the purpose of using the module to avoid Chrome binary size > increase. > > Adds required stub declarations/implementation for MemoryRegionsMap. > > Bug: 1083530, 1004855 > Change-Id: If9d31c4e1b9d214bb0baabe3afa8475ba7adef4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209297 > Commit-Queue: kylechar <kylechar@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Auto-Submit: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771018} TBR=wittman@chromium.org,kylechar@chromium.org,etiennep@chromium.org Change-Id: I992dcf2c36b13ef51d323a44fef840e1e04bdd7b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1083530, 1004855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211927Reviewed-by:
-
Miguel Casas-Sanchez authored
crrev.com/c/2195334 just landed PowerObserver::OnThermalStateChange, this CL listens to it from MediaStreamManager and logs it in the WebRTC log. The utility function PowerMonitorSource::DeviceThermalStateToString gets #if DCHECK_IS_ON() removed to be used from the new code, which runs also in non-dcheck_always_on builds. Bug: 1071431 Change-Id: I5641ae5a96e4ca9504498821ffb3ea91adbec18a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207410Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#771045}
-
Nick Diego Yamane authored
Until now, both code that deals with the Wayland DND protocol and logic for handling regular drag and drop operations has been living in the same component, WaylandDataDevice (which also has code for handling Clipboard operations). As a means of supporting alternative DND use cases, mainly Window/Tab dragging, this patch introduces DragDelegate interfaces into DataDevice and DataSource classes, and shifts most of the use-case specific responsibility to them. WaylandDataDragController implements these brand new interfaces for the usual "data" drag and drop operations, basically containing most of the code previously in WaylandDataDevice. A second implementation for them will be introduced in follow up CLs, aimed at supporting tab dragging. Bug: 896640 Change-Id: I07ff12722230c1f5c065de857e77b086c75c18e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205881Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#771044}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c5b1b3a9278..4d042c5649f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: vasilii@google.com Change-Id: I44e7c5d6cb46b6bc0de040967501c46d6bb3d3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212344Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771043}
-
Jeremy Roman authored
This is already available as content::WebContents::GetNativeView. Fixed: 1085304 Change-Id: I15152e073db6750e8b82ca9d94467fff68a9ff1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208815Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#771042}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f045c636f9b4..50cdbe3343ad 2020-05-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7a5df33715ba7fc2ed354b015b69bb43b6cd0802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212347Reviewed-by:
-
Lukasz Anforowicz authored
Consider the example fixed by this CL in tests/basics-original.cc: struct MyStruct { SomeClass *ptr_field1, *ptr_field2; }; Before this CL, the rewriter would generate a separate replacement for |ptr_field1| and another one for |ptr_field2|. Such replacements would cover overlapping ranges of the source file, leading to butchered, incorrect edits. Note that in the example above |git cl format| places the "*" character above next to the field names (e.g. |*ptr_field1|) rather than next to the type name (e.g. |SomeClass*|). For a single field |git cl format| places the "*" character next to the type name, but the CL adds a single-field test to also cover the non-standard placement. After this CL: *) apply_edits.py detects overlapping replacements and reports them as an error. Simple unit tests have been added to apply_edits_test.py *) RewriteRawPtrFields.cpp defines and uses a custom |hasUniqueTypeLoc| matcher that can be used to ignore fields with a non-unique type location *) RewriteRawPtrFields.cpp tweaks slightly the |replacement_range| and |replacement_text| so that non-standard placement of the "*" character is handled correctly. Bug: 1069567 Change-Id: I5e0a90de6d8c7dc5d16ef68012509508c84b6ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157992 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#771040}
-
Gavin Williams authored
This should have been created in camel case because this is a JSON variable. Bug: 1059607 Change-Id: Id434236900ce5e234dcc2cc3a6381035c995c500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203136 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#771039}
-
Ramin Halavati authored
OffTheRecord profile use in LoadingPredictorConfig unittest is updated and a test is added for non-primary OffTheRecord profiles. Bug: 1060940 Change-Id: Ieba3efeb75e7af40b356d9e656b8d8246b4d7a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212161 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#771038}
-
Cheng Zhao authored
In this code: base::PostTaskAndReplyWithResult( task_runner_.get(), FROM_HERE, base::BindOnce(&InitializeDictionaryLocation, language_), base::BindOnce(&InitializeDictionaryLocationComplete, weak_ptr_factory_.GetWeakPtr())); When |SpellcheckHunspellDictionary| is destroyed before |InitializeDictionaryLocation| is finished, the |InitializeDictionaryLocationComplete| method would not be called, and the returned |DictionaryFile| will be destroyed on UI thread, with its |base::File| member. It would then result in a DCHECK like this: [904:0518/140618.257:FATAL:thread_restrictions.cc(78)] Check failed: !g_blocking_disallowed.Get().Get(). Function marked as blocking was called from a scope that disallows blocking! If this task is running inside the ThreadPool, it needs to have MayBlock() in its TaskTraits. Otherwise, consider making this blocking work asynchronous or, as a last resort, you may use ScopedAllowBlocking (see its documentation for best practices). g_blocking_disallowed currently set to true by base::debug::CollectStackTrace [0x00007FF6805435C2+18] (o:\base\debug\stack_trace_win.cc:284) base::debug::StackTrace::StackTrace [0x00007FF68049BCC2+18] (o:\base\debug\stack_trace.cc:203) logging::LogMessage::~LogMessage [0x00007FF6804AF447+215] (o:\base\logging.cc:605) logging::LogMessage::~LogMessage [0x00007FF6804B0190+16] (o:\base\logging.cc:598) base::internal::AssertBlockingAllowed [0x00007FF680514B33+163] (o:\base\threading\thread_restrictions.cc:85) base::ScopedBlockingCall::ScopedBlockingCall [0x00007FF6805103EB+155] (o:\base\threading\scoped_blocking_call.cc:40) base::File::Close [0x00007FF680549E4B+139] (o:\base\files\file_win.cc:42) SpellcheckHunspellDictionary::DictionaryFile::~DictionaryFile [0x00007FF680071DDE+194] (o:\chrome\browser\spellchecker\spellcheck_hunspell_dictionary.cc:102) base::OnceCallback<void (SpellcheckHunspellDictionary::DictionaryFile)>::Run [0x00007FF6800749BF+75] (o:\base\callback.h:100) To avoid have |base::File| destroyed on UI thread, we should make sure the file is closed in the destructor of |DictionaryFile|. Bug: 1085227 Change-Id: I1dba3b36661ec7968b22cf6d7835e41a81a313cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206199Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771037}
-
Thomas Lukaszewicz authored
Removed the use of ViewHierarchyChanged() to update native view properties when added to a view hierarchy. Changed to use AddedToWidget() instead. Currently the logic in ViewHierarchyChanged() requires the view be in a Widget hierarchy. This should not be assumed in ViewHierarchyChanged(). Instead, having the logic in AddedToWidget() helps to make the assumptions more clear. Bug: 1083822 Change-Id: Ia393fd0141a863212e5c9e30e364fbc4d2b2d7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206215Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#771036}
-
Lukasz Anforowicz authored
Bug: 1080832 Change-Id: I95435ef51b4231a2f08368af722a6bff6b8c4c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208542Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fe49ce29c3e1..b37105ea6cca 2020-05-21 egdaniel@google.com Remove support for manual memory management in GrVkMemory. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I0c07af9a8a62b4eb48bd1faa07a2c8725a23addf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212348Reviewed-by:
-
Andrew Grieve authored
Changes it into an analysis step rather that runs at the same time as errorprone. Removes ability to output .jar files from bytecode_processor. It now outputs a stamp file. TBR=agrieve # Renamed build variable. Bug: 1080670 Change-Id: If98eb4e3673ccdfa47c151370b3f98aa23488a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210873 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#771033}
-
Adrienne Walker authored
I'm in the process of documenting what we need to move cache storage to storage service. Some of these dependencies are easier to clean up than to document, hence this patch. Most of these includes seem vestigal. I tried to be careful to not remove things that were IWYU and transitively included elsewhere. Change-Id: Ib9e599a4336f65949d1aeaaf15a9a827e36be218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211229 Auto-Submit: enne <enne@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#771032}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/66bd749aed4d..c4e15df5d5da 2020-05-21 ilkos@google.com Merge "Revisit fixing RSS captured after heap dump was taken" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ied361e72daf7b405ead5450445fa913ac14841a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212346Reviewed-by:
-
Sam Maier authored
* Fixes optimization bug (see linked bug) * Introduces enum simplification * Adds command-line support for L8 optimizations Bug: 1077307 Change-Id: I85e4bba61253c9056d4544cbd849ec0d9bcd97a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210792Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#771030}
-
Rouslan Solomakhin authored
Before this patch, the desktop logic for checking whether the payment app is waiting for a price update from the merchant was defined in the desktop controller, which prevented from sharing this logic across platforms and in different types of payment apps. This patch moves PaymentHandlerHost.is_waiting() check from payment_request.cc to service_worker_payment_app.cc. After this patch, the logic for checking whether the payment app is waiting for a price update is defined in the potentially cross-platform payment app interface. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1083242 Change-Id: Idde2f1c9396641835f154be19ac7d2901c1c1d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207973 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#771029}
-
