GitLab

BUG=303491

Review URL: https://codereview.chromium.org/137663008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251993 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342106

Review URL: https://codereview.chromium.org/171583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251992 0039d316-1c4b-4281-b951-d872f2087c98

This CL centers the app list for ChromeOS when the --enable-experimental-app-list flag
is on as a followup to https://codereview.chromium.org/162753002 .

BUG=344442

Review URL: https://codereview.chromium.org/168733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251991 0039d316-1c4b-4281-b951-d872f2087c98

chrome.windows.create has been obsolete and should not be used.

BUG=343317
TEST=manually tested

Review URL: https://codereview.chromium.org/171563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251990 0039d316-1c4b-4281-b951-d872f2087c98

Earlier versions of ISO 14496-12 indicated that the upper 2 bits of
the sample_info was reserved and must be 0. The current version of
ISO 14496-12:2012 now allows these bits to be non-zero so we need to
remove the check so the content will play. The new non-zero values are
not needed by the current code so we don't need any extra logic.

BUG=344737

Review URL: https://codereview.chromium.org/166323005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251989 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343835

Review URL: https://codereview.chromium.org/166263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251988 0039d316-1c4b-4281-b951-d872f2087c98

Generated using:
> git grep -l pp_ifdef | xargs sed -i "s:pp_ifdef('\([^']\+\)'):\1:g"

BUG=343235

Review URL: https://codereview.chromium.org/171763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251987 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds an IPC for iframe parameter initialization when it has
been swapped out for out of process rendering.

It changes where CrossProcessFrameConnector is being created because
it was being created too late; it is much more useful for it to be able
to receive messages from the swapped out frame as soon as that frame is
swapped out.

There is currently no mechanism for dynamically changing the size of an
iframe. It is not yet clear how this will be implemented in Blink.

Dependency on Blink CL: https://codereview.chromium.org/135163006/

R=creis@chromium.org, jam@chromium.org
BUG=325803

Review URL: https://codereview.chromium.org/132383005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251986 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251985 0039d316-1c4b-4281-b951-d872f2087c98

The leak was caused by the modular testing not forcing the run-and-clear of
clean-up callbacks.  This left a callback owned by the object which increment
the refcount of the object.  These callbacks should be removed and a different
method of ensuring cleanup should be employed.

Ideally we can find a way to get rid of the ref-counting on the object to avoid
this sort of issue in the future, but currently the operation manager lives on
the IO thread and the Operation must work on the FILE thread.  A sequenced task
queue or a worker may be useful.

Previous CL: https://codereview.chromium.org/149313003/

BUG=292956
BUG=337883
BUG=335404

Review URL: https://codereview.chromium.org/170713007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251984 0039d316-1c4b-4281-b951-d872f2087c98

Also updated Udacity Mobile Web Development Course link

Review URL: https://codereview.chromium.org/170753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251983 0039d316-1c4b-4281-b951-d872f2087c98

Rename some functions to be more meaningful:
- RWHVMac::scale_factor -> RWHVMac::ViewScaleFactor
- RWHVCocoa::deviceScaleFactor_ -> RWHVMac::backing_store_scale_factor
- ::ScaleFactor(NSView*) -> ScaleFactorForView(NSView*)

Move code to update the scale factor of the backing store from
being in RWHVCocoa::updateTabBackingStoreScaleFactor to be
in RWHVMac::UpdateBackingStoreScaleFactor.

Work around a bug where updating the contentsScale of a
CAOpenGLLayer that dynamically changes its isAsynchronous
property results in corruption by re-creating the CAOpenGLLayer
when a change in scale factor is detected.

BUG=245900

Review URL: https://codereview.chromium.org/171763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251982 0039d316-1c4b-4281-b951-d872f2087c98

When using a non X11 build with Ozone, we still have dependencies on
X11. This patch tries to hide X11 and related dependencies when
use_x11=0

Review URL: https://codereview.chromium.org/148643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251981 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Cast: Added a EncodingEventSubscriber to cast sender app. (https://codereview.chromium.org/162103002/)

Reason for revert:
Broke 32 bit bots, printf() usage is non-portable.

Original issue's description:
> Cast: Added a EncodingEventSubscriber to cast sender app.
> 
> - Logs encoded uncompressed raw events for the first X seconds to a file path Y, where X and Y
>   can be specified by the user.
> - Also outputs some basic stats.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251972

TBR=hclam@chromium.org,imcheng@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/170283009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251980 0039d316-1c4b-4281-b951-d872f2087c98

The Indexed DB page cycler has been replaced by a real benchmark. So we no
longer need the age-old hacks to do idb testing via a page cycler.

BUG=196406
TBR=cmumford@chromium.org

Review URL: https://codereview.chromium.org/148093016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251979 0039d316-1c4b-4281-b951-d872f2087c98

With dev-mode highlighting (on stable/beta channel, or with the --force-dev-mode-highlighting=1 flag), in Views, unpacked extension browser action iicons (such as the ones in this test) are given a different background. Adjust our test expectations accordingly.

This patch also cleans up the other BrowserActionApiTests somewhat.

BUG=333008
TEST=browser_tests --gtest_filter=BrowserActionApiTest.DynamicBrowserAction --force-dev-mode-highlighting=1

Review URL: https://codereview.chromium.org/170843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251978 0039d316-1c4b-4281-b951-d872f2087c98

X86_32 is never used assembly files(*.asm, *.inc), define ARCH_X86_64 or
ARCH_X86_32 instead.

BUG=None
TEST=build and run chrome and content_shell with media tests.

Review URL: https://codereview.chromium.org/170073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251977 0039d316-1c4b-4281-b951-d872f2087c98

This moves it from webkit/child to content/child, since src/webkit is
dying and it is a trivial move. WorkerTaskRunner has no
dependencies besides base, and nobody in webkit/ is using it, just
content.

BUG=265753
TEST=content_shell and content_unittests
R=jochen@chromium.org,jam@chromium.org,darin@chromium.org
TBR=darin

Review URL: https://codereview.chromium.org/165373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251975 0039d316-1c4b-4281-b951-d872f2087c98

BUG=264124

Review URL: https://codereview.chromium.org/171433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251974 0039d316-1c4b-4281-b951-d872f2087c98

- RTP timestamps in the maps of EncodingEventSubscribers (map keys, rtp timestamp fields in protos) are now relative to the first RTP timestamp seen since last Reset().
- The two GetXXXEventsAndReset() functions have been combined into one. In addition, it will now return the first RTP timestamp seen since the last Reset(). It will also reset the first RTP timestamp seen.
- There are two motivations for this change:
-- 1. RTP timestamps wrap around easily - around every 12 hours or so. If we do not use relative RTP timestamps, the ordering in the map, as well as general order of the events by frame, will be messed up.
-- 2. Using relative values will be more compact in variable-length encoding of the RTP timestamp fields.

Review URL: https://codereview.chromium.org/168933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251973 0039d316-1c4b-4281-b951-d872f2087c98

- Logs encoded uncompressed raw events for the first X seconds to a file path Y, where X and Y
  can be specified by the user.
- Also outputs some basic stats.

Review URL: https://codereview.chromium.org/162103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251972 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/168823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251971 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333288

Review URL: https://codereview.chromium.org/167893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251970 0039d316-1c4b-4281-b951-d872f2087c98

Puts the DirectoryCommitContributor and DirectoryUpdateHandler
classes behind interfaces.  These classes were always intended
to form the basis of an abstract interface.  Now we can start
to introduce alternate implementations of them.

This CL includes one such alternate implementation.  It adds
the MockUpdateHandler and uses it to remove some unnecessary
boilerplate from the download unit tests.

This CL also resolves an old TODO.  It renames the SyncDirectory*
classes to Directory*, since the 'Sync' part of the name is redundant.

This should have no effect on program behavior.

BUG=278484

Review URL: https://codereview.chromium.org/161253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251969 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251968 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r12776: (noelallen) Replace x86 with arm toolchain in bionic tarball.
r12777: (dschuff) pnacl-translate: Don't do module splitting when using QEMU
r12778: (jvoung) Make save-temps work with pnacl-translate's split modules
r12779: (mseaborn) Provide an API for constructing an IRT, for embedders of NaCl to use

BUG=none
TEST=browser_tests and nacl_integration
TBR=jvoung@chromium.org

Review URL: https://codereview.chromium.org/170783008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344710
TBR=dzhioev@chromium.org

Review URL: https://codereview.chromium.org/171013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251966 0039d316-1c4b-4281-b951-d872f2087c98

Avoid sudo for stopping network-manager if already stopped.

BUG=

Review URL: https://codereview.chromium.org/169513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251965 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/163183012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251964 0039d316-1c4b-4281-b951-d872f2087c98

The OverScroller used to generate fling updates on Android works in pixel space.
Consequently, GestureFlingStart velocities were forwarded also in pixel space.
This exceptional case is unnecessary and confusing, as all other gestures
components are provided as DIPs.  Adopt DIPs for GestureFlingStart, instead
scaling the velocity to pixels when generating the OverScroller object.

BUG=332418

Review URL: https://codereview.chromium.org/170993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251963 0039d316-1c4b-4281-b951-d872f2087c98

Since we care touch scroll latency more than mouse wheel scroll latency,
lets change the default gesture source type to be touch.
If we need to monitor mouse wheel scroll latency in the future, we can
then setup a new perf bot running telemetry smoothness test with mouse
event selected.

BUG=246034
TEST=telemetry smoothness test on CrOS now shows mean_touch_scroll_latency
     instead of mean_mouse_wheel_scroll_latency.

Review URL: https://codereview.chromium.org/164023004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251962 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245025

Review URL: https://codereview.chromium.org/155623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251961 0039d316-1c4b-4281-b951-d872f2087c98

JumpListUpdater encapsulates the boilerplate for updating Windows
jump lists. Most of this code was moved out of jumplist_win for
reuse by app windows. COM interface definitions were removed from
jumplist_win.cc.

BUG=339253
TEST=Right-click on the Chrome icon in the Windows 7+ taskbar and
verify that the functionality has not changed.

Review URL: https://codereview.chromium.org/168583011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251960 0039d316-1c4b-4281-b951-d872f2087c98

The motivation here is to introduce the volume slider tray UI into
Windows Ash.

This change does not actually add tray audio UI to other platforms,
only moves some non-chromeos specific things out of the chromeos
platform folders, so that we can hook in the native Audio APIs
of other platforms to the tray UI.

At a high level, this change does the following:

1) Move tray_audio out of chromeos/ so that other platforms can
use the UI that it provides.
2) Decouples TrayAudio from CrasAudioHandler by introducing a
new delegate, in a similar vein to what is done with all the other
handlers (e.g. the BluetoothHandler)
3) Move the additional views (VolumeView, etc) to their own files
so they can be used by other platforms as well.

TEST=
 On CrOS physical device, verified that:
 1) Keyboard volume buttons function appropriately and display the
    volume view
 2) AudioDetailView still is accessible at the correct times
 3) Adjusting the volume (via the keyboard shortcuts or via the
    slider) correctly change the output volume.
 4) UI still behaves correctly (e.g. icons update as the volume
    changes, mute button works, etc).

BUG=227247

Review URL: https://codereview.chromium.org/163953007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251959 0039d316-1c4b-4281-b951-d872f2087c98

Callers use ExtensionPrefs::Get instead of depending on
ExtensionService for access. Where appropriate, other
nearby, unnecessary references to ExtensionService have
also been removed.

BUG=341181
TBR=benwells@chromium.org,benjhayden@chromium.org,akalin@chromium.org,pkotwicz@chromium.org,stevenjb@chromium.org,sky@chromium.org,dbeam@chromium.org,finnur@chromium.org

Review URL: https://codereview.chromium.org/156843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251958 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/168293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251957 0039d316-1c4b-4281-b951-d872f2087c98

This CL centers the app list for Linux when the --enable-experimental-app-list-flag
is on as a followup to https://codereview.chromium.org/162753002 .

BUG=344442

Review URL: https://codereview.chromium.org/170183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251956 0039d316-1c4b-4281-b951-d872f2087c98

r248477 made pkg-config.py print a 5-tuple. Change the default output accordingly.

BUG=none
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/171993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251955 0039d316-1c4b-4281-b951-d872f2087c98

Added a list of permissions to the app info dialog, as well as the app's
shortcut icon and some basic app information (name, version and description).

Context menu option to open the dialog is still behind the flag
--enable-app-list-app-info.

BUG=266739

Review URL: https://codereview.chromium.org/146583010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251954 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342593
TEST=manually tested

Review URL: https://codereview.chromium.org/165983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251953 0039d316-1c4b-4281-b951-d872f2087c98