GitLab

with the same username exist.

I believe r285140 should have fixed any possible underlying issue here.
Unfortunately even before this I could not devise a test that would fail in the
expected way, but we should still have a test verifying this behavior going
forward.

BUG=395190

Review URL: https://codereview.chromium.org/431893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287958 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn extensions:unittsts
R=brettw@chromium.org,kalman@chromium.org
TBR=keybuk@chromium.org # for device

Review URL: https://codereview.chromium.org/434243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287957 0039d316-1c4b-4281-b951-d872f2087c98

The instance owns the engine via its engine_ scoped_ptr, so if the engine is 
being destroyed via the scoped_ptr destructor, it may not be safe to access 
anything in the instance since the instance may be partially destroyed. Instead,
destroy the engine as the first step in the process so the instance is still
intact.

BUG=392956

Review URL: https://codereview.chromium.org/427583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287955 0039d316-1c4b-4281-b951-d872f2087c98

Instantiate RenderFrameProxyHost objects for remote frames when using
--site-per-process.

BUG=357747, 399709, 399775, 400594
TBR=kenrb, creis, kalman

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287557

Review URL: https://codereview.chromium.org/444503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287954 0039d316-1c4b-4281-b951-d872f2087c98

The function is called ~20,000 times on a fresh launch of Chrome on my MacBook
Pro. Adding a dumb cache to reduce redundant fetches reduced cpu cycles in the
function by 75% (profiled by DTrace).

The class FontFamilyCache performs the caching, and the observation of the
PrefService to ensure that the cache does not become stale.

The Profile owns the FontFamilyCache to ensure that the cache does not
outlive the PrefService.

BUG=308095

Review URL: https://codereview.chromium.org/439913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287953 0039d316-1c4b-4281-b951-d872f2087c98

Reason for the bug is painting code in the pdf plugin which converts back and forth from pixels to DIP
and back to pixels causing us to draw over the scrollbars. Division and multiplication with fractional scales
Is a lossy operation.


BUG=399150
TEST=Tested manually with fractional scales on Windows.

Review URL: https://codereview.chromium.org/437873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287952 0039d316-1c4b-4281-b951-d872f2087c98

Create an ExtensionActionView class which represents the core of either a
PageActionView or a BrowserActionView. The goal here is to move all logic for
executing the action itself into ExtensionActionView, so that
PageActionImageView and BrowserActionButton (the current implementation classes)
become nothing more than a view wrapper for the ExtensionActionView.

This should allow us to show page actions in the now-incorrectly-named
BrowserActionsContainer and have them render in the same fashion as the current
browser actions.

BUG=397259

Review URL: https://codereview.chromium.org/431173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287951 0039d316-1c4b-4281-b951-d872f2087c98

This makes ui::Compositor no longer in charge of
scheduling commits and draws, deferring it to cc::Scheduler.

Other compositors that use SingleThreadProxy are left calling composite
synchronously and now pass a flag to indicate that this is their
intention.  This patch doesn't remove synchronous composite, but now
makes it mutually exclusive with scheduling.

BUG=329552, 287250

Review URL: https://codereview.chromium.org/134623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287950 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391334
TEST=visual

Review URL: https://codereview.chromium.org/437213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287949 0039d316-1c4b-4281-b951-d872f2087c98

View.getWindowVisibleDisplayFrame() and View.getLocationOnScreen()
sometimes return abnormal values in MultiWindow mode.

BUG=387668

Review URL: https://codereview.chromium.org/437423006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287948 0039d316-1c4b-4281-b951-d872f2087c98

Blink now has the real implementations of these files in their repo:

platform -> https://src.chromium.org/viewvc/blink?view=rev&revision=172998
wtf ->  https://src.chromium.org/viewvc/blink?view=rev&revision=172321

BUG=None
TEST=trybots
R=brettw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/420113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287947 0039d316-1c4b-4281-b951-d872f2087c98

None of chromecast/ is part of chrome binary.

R=lcwu@chromium.org,maruel@chromium.org
BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/448903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287946 0039d316-1c4b-4281-b951-d872f2087c98

Ozone mimics the same display layout as X11, so use the same logic when
converting the position.

BUG=398888
NOTRY=true

Review URL: https://codereview.chromium.org/440133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287945 0039d316-1c4b-4281-b951-d872f2087c98

This is done by refactoring some tests to observe focus changes in a
cross-platform manner, and by converting some custom-crafted events to
use the cross-platform event generator.

For now, the code that is only enabled on Windows is unchanged. This
still has aura dependencies, but I hope to enable some of these tests on
Mac in future.

BUG=399191

Review URL: https://codereview.chromium.org/444583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287944 0039d316-1c4b-4281-b951-d872f2087c98

This is part of allowing interactive_ui_tests to compile on MacViews for
initial coverage on the bots (while still using Cocoa UI). That is, the
goal here is to get interactive_ui_tests to link so that other tests can
run (initially).

BUG=399191

Review URL: https://codereview.chromium.org/440833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287943 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392310

Review URL: https://codereview.chromium.org/376333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287942 0039d316-1c4b-4281-b951-d872f2087c98

Continuation of https://chromiumcodereview.appspot.com/444013002/


BUG=400960
TEST=python tools/telemetry/run_tests ippet

Review URL: https://codereview.chromium.org/444163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287941 0039d316-1c4b-4281-b951-d872f2087c98

Converted iTunes and iPhotos parser to use it.
BUG=302745

Review URL: https://codereview.chromium.org/436293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287940 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/444823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287939 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287938 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179632:179654&mode=html
TBR=jbroman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/447913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287937 0039d316-1c4b-4281-b951-d872f2087c98

For the time being I have to duplicate these. Separately I'm going to
investigate centralizing these exclusions.

BUG=401201
TEST=none
TBR=sbc@chromium.org

Review URL: https://codereview.chromium.org/445133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287936 0039d316-1c4b-4281-b951-d872f2087c98

When running from outside chrome (e.g. in athena), 'app' and 'webstore' api
implementations are not available. So check to see if the API is available
before registering the corresponding bindings.

BUG=391478
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/443723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287935 0039d316-1c4b-4281-b951-d872f2087c98

If MD is enabled, add a value to the config dictionary passed to the page.

BUG=400332
TEST=manual

Review URL: https://codereview.chromium.org/447033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287934 0039d316-1c4b-4281-b951-d872f2087c98

This CL merges navigation list (the very left pane) and directory tree (middle pane).
In the conbined tree, the first-level children are VolumeItem or ShortcutItem, which correspond to NavigationModelItem.
Only Drive volume has children and the Drive volume. They are DirectoryItem and the behavior is similar to previous directory tree.

BUG=390848,397222
TEST=run browser_tests

Review URL: https://codereview.chromium.org/441233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287933 0039d316-1c4b-4281-b951-d872f2087c98

These were missed by the big renaming CL
https://codereview.chromium.org/356713005/.

R=rch@chromium.org,asargent@chromium.org,lcwu@chromium.org
TBR=twilson@chromium.org
BUG=

Review URL: https://codereview.chromium.org/430673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287932 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rkc@chromium.org
BUG=None.

Review URL: https://codereview.chromium.org/448943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287931 0039d316-1c4b-4281-b951-d872f2087c98

(due to direct_dependent include_dirs)

R=brettw@chromium.org
TBR=thestig@chromium.org
BUG=354261

Review URL: https://codereview.chromium.org/448743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287930 0039d316-1c4b-4281-b951-d872f2087c98

The first version of the Safe Browsing interstitial used a SBInterstitial counter. It was subsequently replaced by two histograms: SB2.InterstitialAction and SB2.InterstitialActionDetails. This deprecates the SBInterstitial counter.

BUG=346120

Review URL: https://codereview.chromium.org/439683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287921 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379148

Review URL: https://codereview.chromium.org/441013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287920 0039d316-1c4b-4281-b951-d872f2087c98

* Renaming AccountInfo to AccountMapping.
* Adding status and timestamp of it's last change
* Removing last message timestamp, as with introduction of
  message ack event, it is no longer needed

BUG=374969
R=zea@chromium.org

Review URL: https://codereview.chromium.org/443573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287919 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rkc@chromium.org
BUG=None.

Review URL: https://codereview.chromium.org/445243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287918 0039d316-1c4b-4281-b951-d872f2087c98

These histograms are derived from OmniboxEvent log entries.

Some new types are appearing in some new logs nowadays.

TBR=vadimb

BUG=

Review URL: https://codereview.chromium.org/443873007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287916 0039d316-1c4b-4281-b951-d872f2087c98

This will make setAcceleratedCompositingForCanvasEnabled always be
true. There are separate settings to turning canvas on/off entirely.

R=piman@chromium.org
BUG=364908

Review URL: https://codereview.chromium.org/445123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287913 0039d316-1c4b-4281-b951-d872f2087c98

A refactor of FileDownloader (r284961) broke the caching behavior for nexes
that were translated from pexes; the cache would always end up with entries of
length 0, breaking future loads of the pexe. This is the translated nexe was
written to the wrong file handle, preventing caching of the result.

This change causes the translated nexe to be written to the correct file
handle, fixing the caching behavior.

I manually tested this change on the "game of life" demo at
https://gonativeclient.appspot.com/demo/life, verifying that a cached
translated nexe for the pexe was successfully loaded.

BUG=401121

Review URL: https://codereview.chromium.org/447013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287912 0039d316-1c4b-4281-b951-d872f2087c98

The Java DistilledPagePrefs observers are wrapped in a
native observer, which is only deleted when the observer is
removed again. Since the reference to this native observer
wrapper is kept in a Java map with the real Java observer as
the key, the second time addObserver(foo) is called with the
same observer, the first reference is lost, and the native
object is leaked. 

For example, the following would leak a native object:
addObserver(foo);
addObserver(foo);
removeObserver(foo);
removeObserver(foo);

It is already safe to remove an observer if it is not
currently an observer, and this CL ensures that an observer
can only be added once, so the second calls to
addObserver(foo) and removeObserver(foo) will be no-ops.

addObserver and removeObserver will return a boolean based
on whether they have successfully completed the operation.

BUG=383630

Review URL: https://codereview.chromium.org/426153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287911 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391071

Review URL: https://codereview.chromium.org/442173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287910 0039d316-1c4b-4281-b951-d872f2087c98

BUG=223859

Review URL: https://codereview.chromium.org/447923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287906 0039d316-1c4b-4281-b951-d872f2087c98

Ports most of the sync GYP targets to GN.  Adds comments in the original
GYP files pointing to the new GN targets.  Fixes some TODOs in other
files that were blocked on sync GN support.

Adds several new linkable targets to the GN build.

The android-specific parts of sync have not been converted yet.

TBR=nyquist,rogerta
BUG=

Review URL: https://codereview.chromium.org/439533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287905 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/443703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287904 0039d316-1c4b-4281-b951-d872f2087c98