- 19 Apr, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/773c5423460e..8c5646485a95 Created with: gclient setdep -r src-internal@8c5646485a95 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I667c18d93fd405dcc7e09a73f5d99c3697f2988b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575646Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652561}
-
Daniel Kay authored
Expand the visibility restrictions to allow the libassistant project to depend on absl targets even when built in the context of chromium. Bug: b/119188101 Test: manually verified Change-Id: I518eb2ee85ba6186c81d7c28af2f7d81ab9e382b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572543Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Daniel Kay <danielkay@google.com> Cr-Commit-Position: refs/heads/master@{#652560}
-
Chris Hall authored
crrev.com/f08ad04a changed the id from underscore-style to hyphen-style but did not update one of the selectors. R=dtseng,aboxhall,sarakato Bug: 928185 Change-Id: Ic5053d0f73b0d6793125ee9981b6b4719b205d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565734 Auto-Submit: Chris Hall <chrishall@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#652559}
-
Min Chen authored
Bug: 937907 Change-Id: Ib49153233e54cc6be09fff64a73fcd2e38bbbc93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566615Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#652558}
-
Sinan Sahin authored
Bug: 953103, 953105 Change-Id: I576f1098f25f03c1e60017a1da25815032b79f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574247Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#652557}
-
Ramin Halavati authored
Sandbox prioritized origin database creates an on-disk file for the prioritized origin. This is disabled for in-memory file system to avoid writing file mappings to the disk. Bug: 93417 Change-Id: Ie6a251e7fae40b513bc2247ce07e09052ce469a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572401Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#652556}
-
James Cook authored
When the device owner changes the locale, the new value is stored in both local state and a profile pref. However, when a non-owner changes the locale, the value is only stored in profile prefs. Bug: 510455 Change-Id: I3acbff94896c0aa96c7ce09af7e1d4b2ca752290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575682Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#652555}
-
Bill Budge authored
This reverts commit a10bfe51. Reason for revert: Breaks deterministic build product check (expectations need to be adjusted.) https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux/22416 Original change's description: > [ppapi] Remove PPB_TrueTypeFont resource. > > - UMA shows this interface has no usage. > > Change-Id: Ifcb68620aceab0d8a857b4a3a0c768990bf47905 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546762 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Raymes Khoury <raymes@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Sam Clegg <sbc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652404} TBR=raymes@chromium.org,sky@chromium.org,bbudge@chromium.org,sbc@chromium.org,binji@chromium.org,tsepez@chromium.org Change-Id: Iec735dd2220b443b0e8fddc93c7795e46dc7c0f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574294Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#652554}
-
Mitsuru Oshima authored
Bug: 954510 Test: covered by unittest Change-Id: I954bd6b9b928b5d765e0d646cf77ebb6fca3745a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574285Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#652553}
-
Eugene But authored
These tests are not failed on simulator and should only be disabled on devices. Also Added TODOs that reference the bugs. Bug: 954231, 954232 Change-Id: If1aa247e5686211187fddbc1b82c8051f71ab4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574287 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#652552}
-
Frank Kastenholz authored
https://quiche.googlesource.com/quiche.git/+log/3f0f679307af..075a3dbe833c $ git log 3f0f67930..075a3dbe8 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 fkastenholz Fix test so it compiles in chromium 2019-04-19 fayang gfe-relnote: In QUIC, terminate Google QUIC connections (<= v43) similar as IETF QUIC connection. Protected by gfe2_reloadable_flag_quic_terminate_gquic_connection_as_ietf. 2019-04-18 renjietang Change HTTP/3 frame type from 1 byte integer to variable length integer, and allow partial delivery. 2019-04-18 quiche-dev Inject a random number generator into QuartcEndpoint and SendAlgorithms. 2019-04-18 dschinazi Do not ACK when encryption keys are missing 2019-04-18 danzh gfe-relnote: n/a(test only code) switch from unordered_set to multimap. 2019-04-18 danzh gfe-relnote: n/a(code clean up) Inline WallTimeNowInUsec(). 2019-04-18 danzh gfe-relnote: n/a(code clean up) make epoll_server_test.cc platform independent. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: Ia235dd52984c098af6b754bc4790b5550d0be7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575680Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652551}
-
Nico Weber authored
Adds visualizers for: - array - deque - forward_list - initializer_list - list - multimap - multiset - priority_queue - queue - set - stack Also: - slightly improve the map visualizer to cast the size to the right type in all cases, so that it shows with a type like "unsigned int" and not some __compressed_pair - add a DisplayString to vector Bug: 947911 Change-Id: I547d8ccdf27377f91913ff73d639fc826967a0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575679 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#652550}
-
Dan Harrington authored
Change-Id: I516016274fa18099048858d3be0df32bb4a50f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574783Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#652549}
-
Caleb Raitto authored
This is the Java-side followup to the rename request in the native API made here [1]. [1] https://crrev.com/c/1496296/26/components/cronet/native/engine.h#71 Bug: 879208 Change-Id: I0eb0bcc8c7e7f1a2376c271e45f56b9f457c22f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574227Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#652548}
-
Chan Li authored
This reverts commit 8ca571cb. Reason for revert: This change caused blink_platform_unittests failing on multiple builders sample build: https://analysis.chromium.org/waterfall/failure?url=https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/52324 Original change's description: > blink/bindings: Check that decompression is correct, and add UTF-16 testing. > > There are crashes in ParkableString decompression, which are assumed to be OOM > conditions. Add a check to make sure this is the case, and add testing for UTF16 > strings to make sure that this doesn't instead come from such strings. > > Bug: 946203 > Change-Id: Iaafde8c3c7b9c79bf87de67e6c5de5b71e1a310a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575499 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652513} TBR=haraken@chromium.org,lizeb@chromium.org Change-Id: Id697c7df2b13d7ff8a40e68a80b3189600f781c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 946203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574286Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#652547}
-
Sergey Kuznetsov authored
Android already depends on 'update_client' component. 'update_client' component uses 'patch::Patch' in 'DeltaUpdateOpPatch::DoRun'. But the underlying service for 'patch::Patch' - PatchService isn't create for Android (btw it is declared in manifest and it is required capability). This CL fixes this issue by creating PatchService on Android. Change-Id: I011e80833a48bf755006d9c6d9a3133aed287ed4 Bug: 948169 Binary-Size: Increase needed to support delta updates in 'component_update' component on Android. To properly support delta updates the whole library ("//components/services/patch:lib") is needed. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541095 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#652546}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3126b113b51e..773c5423460e Created with: gclient setdep -r src-internal@773c5423460e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I85a09ebd5ed9b91db18246033275aa6c5a0ebbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575643Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652545}
-
Javier Ernesto Flores Robles authored
Bug: 951359, 951300 Change-Id: I838be733ab333b437f2ee22694207b52ef73d40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575500 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#652544}
-
Toni Barzic authored
IdentityAccessorImpl uses and observes identity manager, which is scoped to profile, so it should not outlive the profile it's assigned to (before this IdentityAccessorImpl instances were leaked, never removed themselves from IdentityManager observer list, and were causing DCHECK failures during IdentityManager's observer_list_) BUG=None Change-Id: I6d7966d0d2a2db859c08e9a938a3cf73302ee37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573169Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#652543}
-
Sylvain Defresne authored
Change internal implementation of two methods of AuthenticationService to remove unnecessary allocations. 1. AuthenticationService::MigrateAccountsStoredInPrefsIfNeeded is only interested in whether the system has stored refresh token for an account by account_id, so use HasAccountWithRefreshToken instead of fetching the whole AccountInfo 2. AuthenticationService::ReloadCredentialsFromIdentities only need to check whether the system has a primary account set, and is not interested in the email address, so use IsAuthenticated instead of GetAuthenticatedUserEmail Bug: none Change-Id: If5de15711ef2d2d96dc935162b11aa17c4b245fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569122 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#652542}
-
Paul Jensen authored
Change-Id: I6127ef918487ba441a5b7f2b86d83d609aa83ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574378Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#652541}
-
sczs authored
Makes changes to TableViewTextButton so it can be used with the Password Infobar Modal. Adds these buttons to InfobarPasswordTableViewController and hooks them to their actions. Screenshot: https://drive.google.com/open?id=1CAJc2tT_oyL9Xyrm6b6krtZo1fxcey7T Bug: 945478 Change-Id: Iadfdec6081a5742ec786102e040cf7a38396c17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572962Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#652540}
-
Javier Ernesto Flores Robles authored
This reverts commit 7eacffe7. Reason for revert: Underlying issue has been fix. Original change's description: > Revert "[iOS][Alert] Add alert controller to Showcase" > > This reverts commit 2410dcb9. > > Reason for revert: Bug 954134 > > Original change's description: > > [iOS][Alert] Add alert controller to Showcase > > > > Bug: 951301, 951300 > > Change-Id: If0af93103f0038ad35770cee09b94b455aeca92b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561109 > > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > Reviewed-by: edchin <edchin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#652122} > > TBR=edchin@chromium.org,javierrobles@chromium.org > > Bug: 954134 > Change-Id: I4f4d441cf3fa9ea5651a0b0bc01ef41e9bd0f277 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 951301, 951300 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573639 > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652127} TBR=fdoray@chromium.org,edchin@chromium.org,javierrobles@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 954134, 951301, 951300 Change-Id: I1740cd09d71efea1f982b8617eb4b7c940efa26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574720Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#652539}
-
Yuki Shiino authored
Adds a missing check of exception_state.HadException(). Comment about crbug.com/939598 is not correct because of unrestricted float (Web IDL) => ToFloat (Blink) float (Web IDL) => ToRestrictedFloat (Blink) In case of 'unrestricted float', it shouldn't throw an exception. Bug: 939598 Change-Id: Ibda1cb445b630f38a8e3ab52c6839a49020d6941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574997Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#652538}
-
Pâris MEULEMAN authored
Follow up of https://crrev.com/c/1569716 Bug: 953251 Change-Id: I6b441d72c673381236dbef1b0794a3a56c49da26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575579 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#652537}
-
Michael Giuffrida authored
When using Kiosk Next Shell, AppListController might not exist. Also adds tests for these cases. Bug: 954317 Change-Id: I5da308b5be540f56d11136c0456b455654f6da98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574952 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652536}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7dd3889f2cf7..97035bde89e6 git log 7dd3889f2cf7..97035bde89e6 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 bclayton@google.com Switch SIMD::Pointer::base from a Float* to Byte* 2019-04-19 bclayton@google.com SpirvRoutine: Use SIMD::Pointers for pointers map. Created with: gclient setdep -r src/third_party/swiftshader@97035bde89e6 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ie4c274226844bec100f5bc5b77f09635f4bc69b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575642Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652535}
-
Elly Fong-Jones authored
Per email discussion, we aren't interested in shipping this feature any time soon. Bug: 954201 Change-Id: I28b4701d1f7fd9e56f1ced71d6eb3fb1d886ed57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572706 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#652534}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9096e11484e..3126b113b51e Created with: gclient setdep -r src-internal@3126b113b51e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I4a33e042acf212c977cc4b3788740efcdab2d557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575638Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652533}
-
manuk authored
This is the 11th refactoring CL aimed at reducing duplication and inconsistency for classifying omnibox results. ZeroSuggest suggestions to not match user text or bold their texts. Their contents are styled URL; their descriptions are styled NONE. Previously, `ClassifyLocationInString` was invoked with trivial parameters in order to create these length 1 (or length 0 for empty text) classifications. With this CL, we instead use the recent `ClassifyTermMatches` method. This doesn't reduce complexity but helps moves towards using the same methods for all providers' classifications. Bug: 366623 Change-Id: Ie91c6b595776c5d46bb4f6700a938216dea2bbd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573811Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#652532}
-
Frank Kastenholz authored
https://quiche.googlesource.com/quiche.git/+log/2c5386eab92a..3f0f679307af $ git log 2c5386eab..3f0f67930 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 dschinazi Fix compilation of QUIC transport_parameter_test on Windows 2019-04-18 ianswett Override << for QUIC's LostPacket Struct to make failing tests easier to debug. No functional change, not flag protected. 2019-04-18 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_set_transmission_type_for_next_frame. 2019-04-18 fkastenholz Make a number unsigned in order to compile in Chromium 2019-04-18 fkastenholz Make test target unsigned so that it compiles on chromium. 2019-04-18 wub gfe-relnote: (n/a) Stop including unused quic_flags.h in quic_packet_number.h. Cleanup only. 2019-04-17 dschinazi Fix iOS compilation of transport parameters 2019-04-17 quiche-dev Send a PING frame at the start of QuartcPeer tests so that probing works. 2019-04-17 dschinazi Make TLS encryption levels match the QUIC ones 2019-04-17 dschinazi Update QUIC TLS transport parameters to IETF draft 18 2019-04-17 quiche-dev Create a RandomDelayLink (and symmetric version) and use it in QuartcBidiTest. 2019-04-17 quiche-dev Create a PacketFilter for random loss and use it in QuartcBidiTest. 2019-04-17 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_always_reset_short_header_packets. 2019-04-17 danzh gfe-relnote: n/a(code clean-up) Remove un-used #include. 2019-04-17 danzh gfe-relnote: n/a(code clean-up) Remove unused #include. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Update flags file to remove flag that has been deleted. R=rch@chromium.org Change-Id: Ide594ef9da61cd8dcb612b47e82c7e5336215af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574150Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652531}
-
Findit authored
This reverts commit cb019fe8. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 652424 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2IwMTlmZTgxYmFmNjM5MmQzZGY4ZjY0M2U1N2VmZmIzODNiNjFjOQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/WebKit%20Linux%20Trusty%20MSAN/14010 Sample Failed Step: webkit_layout_tests Sample Flaky Test: http/tests/devtools/a11y-axe-core/elements/main-tool-test.js Original change's description: > DevTools: aXe core linting for main Elements tools > > This change adds aXe Core linting to the following components of > the main Elements tool: > > - DOM tree > - Breadcrumbs > - Styles pane > - Computed Styles pane > > Change-Id: I247d9a4d4883db936f09c4d252a0558e63295edf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566689 > Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> > Reviewed-by: Joel Einbinder <einbinder@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652424} Change-Id: Ie703a128289530af6313a7c61f09216fd4e6bb7f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574280 Cr-Commit-Position: refs/heads/master@{#652530}
-
Lily Chen authored
This CL changes the default net::CookieSameSite value to UNSPECIFIED (it was previously NO_RESTRICTION). The default is used when the cookie does not specify a SameSite attribute, or if the given SameSite attribute does not specify a valid value. Support is added for the new `SameSite=None` option, which parses as CookieSameSite::NO_RESTRICTION. Support is also added for the new `SameSite=Extended` option, which for now is identical to Lax mode. Bug: 953306, 953995 Change-Id: I96ee07f5e626a2f99e65e9c27260a8f6e5b6b9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573081 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#652529}
-
Javier Ernesto Flores Robles authored
As mentioned by kkhorimoto@ the background view is not needed. And the chrome shouldn't be constraint to the safe areas, but cover the presenting view controller. Bug: 951300 Change-Id: I3097c8dc6ceaaf60c1d0f6ad817a87ef910e5991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574799Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#652528}
-
Javier Ernesto Flores Robles authored
Making init available again so it can compile with xcode clang. UIAlertAction also has this method available. Bug: 951301, 951300, 954134 Change-Id: Ie5b5e9d5f95694a38277ba25a1bed03bfdf1e355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573621Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#652527}
-
Minggang Wang authored
Currently, the operation of getting service worker infos is asynchronous, during which the task manager may have stopped updating. In this case we have to invalidate the weak pointers to avoid the invoking of the callbacks. BUG=953432 Change-Id: I7f5bc3c0203008175264eb5a8f31ab5236d40d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572648Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#652526}
-
Javier Ernesto Flores Robles authored
Bug: 951361, 951300 Change-Id: Ic653d533b927774f0d78de10c7fb4d5ab8dfa3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565006Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#652525}
-
Sébastien Séguin-Gagnon authored
The delegate's documentation mentions that returning true should close the infobar. Bug: 954339 Change-Id: Ibbe75f180f828afebd72c4c7953045da9249b7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574443Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652524}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f2976d2e4dec..f9096e11484e Created with: gclient setdep -r src-internal@f9096e11484e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I2d83e8b1e52cb00c894efa9f568ec407c441cf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575417Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652523}
-
Alexander Timin authored
Track pages controlled by service workers. R=haraken@chromium.org,kinuko@chromium.org CC=falken@chromium.org BUG=933147 Change-Id: I27c2665bf6c484df7748a97ea5260c7407bbae90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571693 Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#652522}
-