- 01 Apr, 2020 40 commits
-
-
Stepan Khapugin authored
Moves the first run UI flag to SceneState, and updates MainController to look for any scene showing first run UI. Bug: 1045660 Change-Id: Ia3cc3b6db9b4899e96c8c7098c336c72ee5c9704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129538Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755354}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c839d063efb6..7108574e87d0 git log c839d063efb6..7108574e87d0 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 aerotwist@chromium.org [e2e] Fails tests on in-page errors 2020-04-01 aerotwist@chromium.org Revert "Show unbound breakpoints as disabled" Created with: gclient setdep -r src/third_party/devtools-frontend/src@7108574e87d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iba252e472ef35829073ba99daabcdc9c1d7ec91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132171Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755353}
-
David Bertoni authored
The ServiceWorkerBasedBackgroundTest.Basic test is no longer flaky. See the bug for more details regarding testing. Bug: 1003244 Change-Id: I3cc6a02409086af691fe6d3f0d6270b307c702dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130782Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#755352}
-
Ioana Pandele authored
This CL disables waiting for server predictions in tests and makes sure to wait for the text field to be filled before comparing the generated password to the text in the field. A previous attempt at unflaking the entire test suite was made at crrev.com/c/1995273, but the fix uncovered other flakes for the manual generation tests. This is why this CL is only scoped to the automatic generation cases, which are simpler. Bug: 1064960 Change-Id: I3c4c60cebbeef0ce73f4e3dddbd4747b89e5f61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132248Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#755351}
-
sauski authored
As part of the Friendly Settings privacy settings redesign a new Safe Browsing control was introduced. This controls offered a new way of interacting with existing Safe Browsing settings and supported the new "Enhanced" SB mode. This CL adds a C++ handler to provide the current managed state of the new controls for immediate display by JavaScript. Bug: 1061947 Change-Id: Ib52d2a8f52747fcb19d45dc950cabd548e72210e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124750 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#755350}
-
Anastasiia Nikolaienko authored
TBR=xiyuan@chromium.org Bug: 1043108 Change-Id: Icbed69edd08040f2d92d91811b14361b2db93c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132130Reviewed-by:
Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#755349}
-
Javier Ernesto Flores Robles authored
This reverts commit b010b7f5. Reason for revert: Reason for revert is fixed now. Original change's description: > Revert "[ios] Add data to CPE password list in showcase" > > This reverts commit 0fb67af0. > > Reason for revert: This broke the tree by indirectly compiling > ios_internal/chrome/credential_provider_extension/internal_account_verification_provider/account_verification_provider > which is broken at the moment. See https://critique.corp.google.com/#review/303938281 for its fix. > > Original change's description: > > [ios] Add data to CPE password list in showcase > > > > No styling yet. > > > > Bug: 1045454 > > Change-Id: I05155cd76c88cdaf828c62627914dffc0a1a7475 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129536 > > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > Reviewed-by: edchin <edchin@chromium.org> > > Commit-Queue: David Jean <djean@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#755278} > > TBR=edchin@chromium.org,javierrobles@chromium.org,djean@chromium.org > > Change-Id: I2fbc8f6c95f535a2db997954d3782f9b25792b2c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1045454 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130279 > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755297} TBR=edchin@chromium.org,javierrobles@chromium.org,djean@chromium.org Change-Id: I5fd47ee4cfa8eef908e4c93103cf3917e4d1f82b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132368Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#755348}
-
Liquan (Max) Gu authored
Before: * PaymentSuccessCallback#onIsReadyToPayServiceResponse After: * PaymentSuccessCallback#onPaymentSuccess Before: * PaymentErrorCallback#onError After: * PaymentErrorCallback#onPaymentError Change-Id: I5a6d3176865edf34393c63f78fd844a12b076396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123627Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#755347}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/784630f0e63e..e283d1ca64c6 git log 784630f0e63e..e283d1ca64c6 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 philipp.hancke@googlemail.com add tcptype to prflx tcp candidates 2020-04-01 philipp.hancke@googlemail.com doc: remove mention of obsolete relayserver target 2020-04-01 phensman@webrtc.org Remove some more instances of IP logging. 2020-04-01 marinaciocea@webrtc.org Insert audio frame transformer between depacketizer and decoder. Created with: gclient setdep -r src/third_party/webrtc@e283d1ca64c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5359b7b14037acdf64695d037da9046a161f66c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132169Reviewed-by:
-
ckitagawa authored
This CL attempts to re-implement ui/base/clipboard/clipboard_android_unittests.cc which was deleted in http://crrev.com/2839753007 as part of removing GetApplicationContext. This CL does 2 things 1. clipboard_unittests.cc was made part of interactive_ui_tests (for context see crbug/434620); however, this target is not run on Android. Since gtests aren't sharded on Android (no clipboard contention) we can include clipboard_unittests.cc in an Android specific target to cover clipboard_android.{h|cc}. Note that this requires disabling some tests in clipboard_test_template.h that work with TestClipboard but not ClipboardAndroid (see inline bugs). 2. This adds the Android platform specific ClipboardAndroidTest.java with a testcase that simulates another application copying to the clipboard and correctly propagating that to Chrome's clipboard. This test needs to be driven from Java as per the re-implementation discussion in crbug/715619. Also related from crbug/434620 is the request for a last modified time testcase. However, this appears to reference preference-related functions which no longer exist. Bug: 434620, 715619, 1064968 Change-Id: I5e1b74711c638b947dde0dd205f575dd07cdb436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121045 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755345}
-
Nina Satragno authored
Fix the empty allowCredentials credentials.get() WPT. The test was expecting the browser to return a non-resident credential with an undefined allowCredentials list (which defaults to empty). Moreover, the test helper itself was failing because it was expecting a credential to be added to the test. Instead, move the test to its own file that sets up the test environment to support resident keys and add rk support to the helper with the isResidentKeyTest flag that avoids appending credentials to allowCredentials. Bug: 875444 Change-Id: I8baefa3a74c2a707227df430712a09935c1fbbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130671Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#755344}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/98a3c0a4..0301269a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8dc321679762f78d7867bff043c4c76d322597ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132027Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755343}
-
nancy authored
BUG=1061843 Change-Id: I25a5dc2f46bab171ea48b38c5b2a6824e84a2ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123576Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755342}
-
Viktor Semeniuk authored
This change adds reminder about compromised credentials found during password check to the autofill page. Also, this change implements PasswordCheckBehavior to reduce code duplication in password_check passwords_section and autofill_page files. Mock: https://docs.google.com/presentation/d/1yWuZO-fjXhdRp64nWRbnHEyzpFd1KOMS3u1_1XMdGuA/edit#slide=id.g7c9229dfe2_9_1 Bug: 1047726 Change-Id: I48e3e2b999d4f521f5018fb3ca0b0376d66eefa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120417Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Luke Zielinski authored
external/wpt/paint-timing/fcp-only/fcp-typographic-pseudo.html virtual/paint-timing/external/wpt/paint-timing/fcp-only/fcp-typographic-pseudo.html Bug: 1066848 Change-Id: I193c9df05f690be9e37b877965a005624bcfa7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132286 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#755340}
-
Anatoliy Potapchuk authored
This test have been failing on debug build. It has been already disabled for half a year on release build. Example failure:https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17887 TBR: msramek@chromium.org Bug: 1028676 Change-Id: I349a36319f321ab1654fe8b78f11e5461e7b9d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132210Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#755339}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46ee73e065c6..38df4ab61807 git log 46ee73e065c6..38df4ab61807 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src e157435c1e77..1fff36235504 (1 commits) 2020-04-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src fd773eb50d62..c37c94929bf5 (1 commits) 2020-04-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src d712a6b03b9e..7844b9b4e180 (1 commits) Created with: gclient setdep -r src/third_party/angle@38df4ab61807 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I665d28e8b943cddc07f1ee38556a68e05cfad786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131724Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: If322db58f1b45e17b2e968351a4ba13a5c4402de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130818Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755337}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a3358c80b6e..0f5e7581a004 git log 7a3358c80b6e..0f5e7581a004 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 reed@google.com can we remove these entirely? Created with: gclient setdep -r src/third_party/skia@0f5e7581a004 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: Id4c66b62b0c0652e49ffaa84391e3bdc3dc1bce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132167Reviewed-by:
-
Anatoliy Potapchuk authored
This test have been recently failing on Mac10.13 Tests (dbg) Example build failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/17748 The flakiness seems to appear after crrev.com/c/2036772, but it is difficult to cleanly revert. TBR=beccahughes@chromium.org Bug=1066853 Change-Id: I9444133768fd5c395922734336dc3cad371679ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132187Reviewed-by:
-
David Van Cleve authored
A previous review comment [*] pointed out this conditional doesn't do anything, but it looks like I marked the comment as resolved without addressing it. [*] https://chromium-review.googlesource.com/c/chromium/src/+/2116014/11/third_party/blink/renderer/core/html/html_iframe_element.cc#270 R=jbroman Bug: 1062396 Change-Id: I88169236039269435d0c0499e3324f5d3958bfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131410Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#755334}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2ced406be1ce..c839d063efb6 git log 2ced406be1ce..c839d063efb6 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 wolfi@chromium.org Round design for logpoint icon 2020-04-01 aerotwist@chromium.org [Experience] Adds layout shifts to performance timeline 2020-04-01 aerotwist@chromium.org [e2e] Fix selection after delete 2020-04-01 leese@chromium.org Show unbound breakpoints as disabled Created with: gclient setdep -r src/third_party/devtools-frontend/src@c839d063efb6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1041830,chromium:1054381,chromium:1054447 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia9019fa5e5b81e02624a49ab6838b1b4e0c45c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132166Reviewed-by:
-
Donn Denman authored
The whole ContextualSearchManagerTest has been disabled due to flakiness involving the focus moving into the Omnibox. This CL implements a workaround by removing a delay after loading the test page, which should not be needed anyway. BUG=1058362 Change-Id: Ia4d7e5a65d36ec4c4c32d4b4e0eec2c8225e07af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131347Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#755332}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3da19b843ffd..a0afd3158504 git log 3da19b843ffd..a0afd3158504 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 cwallez@chromium.org Separate device lost from internal errors. Created with: gclient setdep -r src/third_party/dawn@a0afd3158504 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ie7fc772c5354960885b8efb2e7550750ce1b277f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131725Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/00b46f7f2ad1..784630f0e63e git log 00b46f7f2ad1..784630f0e63e --date=short --first-parent --format='%ad %ae %s' 2020-04-01 deadbeef@webrtc.org Changing from hard to soft error when temporary DTLS buffer is full. 2020-04-01 sprang@webrtc.org Make prioritized RTX padding default again Created with: gclient setdep -r src/third_party/webrtc@784630f0e63e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1063834,chromium:1066442 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ice4c62b54ddbfe2248214d2939d6bf252493acec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131719Reviewed-by:
-
Tanmoy Mollik authored
This cl creates the new UI for advanced sync flow to be shown under the MobileIdentityConsistency feature flag Screenshot: https://crbug.com/1061047#c4 Bug: 1061047 Change-Id: Ia36aefe8b1672d91d87efc0795357374d242a0b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111153 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#755329}
-
Sean Harrison authored
Bug: 1032584 Change-Id: I89fa54cd86fbe13eade7e85efc86b15ec99474fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126932 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ec9040a110fb..0ab04c72210a Created with: gclient setdep -r src-internal@0ab04c72210a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie60cc1934b3be04c1eda153a40f8fe795cace819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131722Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755327}
-
Marian Fechete authored
This CL updates the layout and informational messages for the AA onboarding screen. Please see screenshots in the bug. Bug: b/150927780 Change-Id: Id1ac924486ac40b9072477923d44b53884cc2a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128320Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#755326}
-
Rohit Rao authored
Only enables the core policy infrastructure. The handlers that parse policy data will remain disabled by default. BUG=1024115 Change-Id: I57d38c44313a6b545353eb1f8c0d1a55b92a5e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127946Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#755325}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d540359a..98a3c0a4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic3bf776634f4b611e3741a91c5b6fa4eb06d36b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131748Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7e5ebf014b5e..2ced406be1ce git log 7e5ebf014b5e..2ced406be1ce --date=short --first-parent --format='%ad %ae %s' 2020-04-01 aerotwist@chromium.org [e2e] Skips flaky network datagrid tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@2ced406be1ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066813 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifa72e22d1eb54bb7fa5c6e88792c5df1b657c58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131723Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 1066803 Change-Id: I559b6f45f84b9ca587257acdcb51236838caf17f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131914 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Richard Knoll authored
Because of crbug.com/1064558 we can not update Windows native notifications. Instead, we'll just show an initial indefinite progress notification and replace it with the final image after all processing is done. Bug: 1059290 Change-Id: Ic42173ebe2bed7930e837fcdf2fd8875c043bedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130792Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#755321}
-
Jan Wilken Dörrie authored
This change improves the shown string to Password Check users that run out of quota and are redirected to the Password Checkup in their Google Account. Translation Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/5276cc79879bda188d7e8de493be26e482e77ac8 Fixed: 1062264 Change-Id: Ifd89029b2968e544eb679500b696738efad3f79d Bug: 1062264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128078 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#755320}
-
Yifan Luo authored
1. Use space instead of a dot. 2. Use HTMLScriptElement and SVGScriptElement instead of script. 3. Use `|` instead of ` ` between sink name and string value. Bug: 1058446 Change-Id: I84b555b50dcb839cc8455612f08d53f028fc607f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120495 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#755319}
-
Dominik Röttsches authored
Remove DCHECK(it.ValueCount()); as this appears flaky on the Win 7 dbg bot and RegistryValueIterator does occasionally not return values. Remove this DCHECK as the test is restarted anyway in each run on the bots and the DCHECK is not essential to ensuring that DWriteFontLookupTableBuilder runs and indexes fonts. Bug: 1065344, 1066801 Change-Id: I95f45c55ab9342512af6becfe7d4c8074d1c186b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130854Reviewed-by:
-
Camillo Bruni authored
--enable-logging practically only supports stderr or the empty string as values. Print a warning if any other value is used. Change-Id: If854af4a910794f72fd1f246a4e039306153c5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106587 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#755317}
-
Johann authored
The new wrapper changed the behavior slightly during the migration. The wrapper defines a default ContextDestroyed method. If some other cleanup method tries to access the receiver_ it may crash. This change reverts to the pre-migration behavior. BUG=chromium:1049056 Change-Id: Id6e5d9fd7405b490afe13764f340dbcccc5e3210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131797Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#755316}
-
Daniel Vogelheim authored
Make URLs used to construct workers TrustedScriptURLs. Minor rework of how to get the execution context in the generated bindings, because the old method assumed presence of an "impl" object, which is only created at the end in case of constructors. So instead, implement a method with which we can always obtain the execution context from the v8::FunctionCallbackInfo. Bug: 1059684e Change-Id: I00e3e52cad5c3736105289a9fda1eeca15fd6f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105339 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#755315}
-
