- 30 Sep, 2020 40 commits
-
-
Randy Rossi authored
When a node with scopes_route flag is added, perform a depth first search for a child with names_route flag. If found, that node should receive focus and be spoken. Subsequent updates for a the node should not speak or refocus. When a scopes node is removed, refocus a names node under the last scopes node unless there is none. Refocused nodes after a removed node should not be spoken, only focused. If there is no scopes node found, focus on the first focusable node in the tree. This is used by flutter alert dialogs and drawers that require the user's attention if the screen reader is enabled. Bug: None Test: Local display assistant and unittest Change-Id: I69b0205d47269ec75265ca1af56400cc28faea56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436768Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812086}
-
David Black authored
This will enable the new Assistant timers experience by default which adds system notifications for the entire lifetime of a timer. Bug: b:149570650 Change-Id: Id3f6675bdc020b56d21f1cd7418ed287aa0d979f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439424 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#812085}
-
Ali Juma authored
This CL fixes WebStateObserverTest.FailedSslConnection with committed interstitials. This also makes CRWWebControllerTest.SslCertError early-return when committed interstitials are enabled, since it tests behavior that is specific to the old interstitials workflow. Bug: 921916 Change-Id: I6bf4b0ff40ae0f7ee7f0ce91967aa3abc79ffb13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438890Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#812084}
-
Yann Dago authored
Add the IPolicyStatus2 interface and both PolicyStatusUserClass and PolicyStatusMachineClass classes. Replace usages of the old PolicyStatusClass by PolicyStatusMachineClass Bug: 1119703, 1106637 Change-Id: Ie147e1c2d100fc5273fa9ee641078f96c7b8f91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380735 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#812083}
-
Rohit Agarwal authored
The "Close incognito tabs" notification we show in Android also closes the incognito tabs opened in CCT. This CL: 1) Disallows the close incognito notification for tabs opened in incognito CCT. 2) For regular incognito "tabbed" Activity there's no change of behaviour when the user clicks on the notification i.e we will continue to close the incognito tabs opened by the Chrome "tabbed" Activity. 3) From Point 2) clicking on the notification wouldn't affect any incognito CCT tabs. This CL also adds instrumentation tests. Bug: 1131844 Change-Id: Ia375bb61b6f54940c1315c0512921b0407d27aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426433Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#812082}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dbb090f41f9b..fa082bb58ba7 2020-09-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from c6ca885c0b4a to fcb22ecf0f7e (1 revision) 2020-09-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from db992e60cc7a to e2b329a75b6a (1 revision) 2020-09-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 44be0942f9a8 to b042f4e70879 (15 revisions) 2020-09-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 2bfd6a752dc6 to c5c6265c026e (3 revisions) 2020-09-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 8fdc21e4078d to 0c0ac2c6c458 (1 revision) 2020-09-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3049a95d to 18cdc317 (353 revisions) 2020-09-30 syoussefi@chromium.org Vulkan: Unresolve depth/stencil MSRTT attachments 2020-09-30 jdarpinian@chromium.org Support EXT_color_buffer_half_float on WebGL 2.0 contexts 2020-09-30 jmadill@chromium.org trigger.py: Add launching of Android tests. 2020-09-29 timvp@google.com Vulkan: Don't modify mReadOnlyDepthStencilMode in syncState() 2020-09-29 m.maiya@samsung.com Add Samsung to ANGLE vendor list 2020-09-29 timvp@google.com Check angle_enable_abseil in Abseil group and config 2020-09-29 jmadill@chromium.org Disable Mock ICD perf tests on Android. 2020-09-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b94db86cf9b3 to 44be0942f9a8 (2 revisions) 2020-09-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 4b07d50cd9a0 to c6ca885c0b4a (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1133459 Tbr: jonahr@google.com Test: Test: CQTest: Test: Manual verification of Skia 'gn gen' on Windows Change-Id: I9a44c78b2447dd28222b3c4f0a4e9e3e1c335ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440455Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812081}
-
Esmael El-Moslimany authored
Bug: 1110069, 1130863 Change-Id: I74f43f32819ca55766dec170a017c2340d6a8226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437932 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#812080}
-
Ulan Degenbaev authored
This CL also makes V8DetailedMemoryReporterImplTest more robust by replacing array allocation with a typed array nested in an object. Bug: 1131491 Change-Id: If5fec7cc81aac0f33f068ecff3b928a1ceb7ede2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438372Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812079}
-
Nohemi Fernandez authored
Currently Chrome stores whether it should show a sign-in promo on accounts.google.com in the CHROME_CONNECTED cookie. Once the promo is displayed it no longer requires this information and we should remove the cookie. This will not affect existing functionality since the CHROME_CONNECTED cookie is used for signed-in users and the promo will only be displayed to signed out users. Bug: 1125631 Change-Id: I504974aaebf8e7e71a596342726c5f5df0f189c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440596Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#812078}
-
Changhao Han authored
DevTools frontend CL: https://crrev.com/c/2438385 Bug: chromium:1133675 Change-Id: If6bfcfe09eb588671b7616bce9fd0528ceca1b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439071 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812077}
-
Josh Nohle authored
Background: We enroll with CryptAuth as long as at least one multi-device feature is allowed according to AreAnyMultiDeviceFeaturesAllowed(). Before this CL, this function only checked the "is-allowed" pref for each feature. For enterprise/EDU users, all features should be prohibited by default, so the function should return false and no enrollment should occur. However, the WIP features Phone Hub and Wi-Fi Sync have not yet been hooked up to the admin console, so their is-allowed bits are not false by default for enterprise/EDU users yet. Solution: In this CL, we do not consider a feature "allowed" if its feature flag is disabled. Bug: 1133334 Change-Id: I87e1c3d39ac0edd198329e856e44c6d094448abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436677 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#812076}
-
Yutaka Hirano authored
https://github.com/WICG/web-transport/pull/135 Bug: 1133613 Change-Id: I14911ebe519f7426d7ef4f98138a98629075b3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438081 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#812075}
-
Lukasz Anforowicz authored
Bug: 1128008 Change-Id: Ib98d031b7537caf3ba685d0911fb8b78b3c5be9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432446Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#812074}
-
arthursonzogni authored
From the patch: https://chromium-review.googlesource.com/c/chromium/src/+/2426465 Revert the changes to the file: chrome/android/java/src/org/chromium/.. ../chrome/browser/sync/AndroidSyncSettings.java This caused several tests to fail: ``` ClearBrowsingDataFragmentTest#testDialogAboutOtherFormsOfBrowsingHistory IdentityDiscControllerTest#testIdentityDiscWithSignInState IdentityDiscControllerTest#testIdentityDiscWithSwitchToIncognito RecentTabsPageTest#testPersonalizedSigninPromoInRecentTabsPage RecentTabsPageTest#testPersonalizedSigninPromoInRecentTabsPage RecentTabsPageTest#testPersonalizedSyncPromoInRecentTabsPage RecentTabsPageTest#testPersonalizedSyncPromoInRecentTabsPage SigninSignoutIntegrationTest#testSignIn SigninSignoutIntegrationTest#testSignOut SigninSignoutIntegrationTest#testSignOutNonManagedAccountWithDataW[..] SigninSignoutIntegrationTest#testSignOutNonManagedAccountWithoutWi[..] SigninSignoutIntegrationTest#testSignOutNonManagedAccountWithoutWi[..] SyncErrorCardPreferenceTest#testSyncErrorCardForAuthError__NightMo[..] ... ``` With the error: org.chromium.components.strictmode.StrictModePolicyViolation: DISK_READ from AndroidSyncSettings.setChromeSyncEnabled TBR=jkrcal@chromium.org Bug: 1133401 Change-Id: I15ddf7716356655f8480572f807d2e020c555964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438500 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#812073}
-
Yi Gu authored
See bug for sample logs. TBR=rhalavati@chromium.org Bug: 1130131 Change-Id: I3b83ce92f6c9c2a8c1a7401c392bd4d76c56f720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438735Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#812072}
-
Lukasz Anforowicz authored
This CL renames the FileURLLoaderFactory in an anonymous namespace in //chrome/browser/chrome_content_browser_client.cc to SpecialAccessFileURLLoaderFactory (to distinguish it from the content::FileURLLoaderFactory). This CL introduces SpecialAccessFileURLLoaderFactory::Create static method that allows creating a SpecialAccessFileURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<SpecialAccessFileURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: If5d9731ceee4d62144e12c18f67dda7df4379b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358058Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#812071}
-
Alexander Surkov authored
Bug: 1131921 Change-Id: I6fb257c7521e6a85ca734b6606e6ea499e696492 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435818Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#812070}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/53a6a132f50c..a528cef8c93e 2020-09-29 jophba@chromium.org Fix PEM_read calls 2020-09-29 jophba@chromium.org Add friendly, model name command line args If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: If7836b27718373b520795c9de41ce5152c5e9324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439497Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ie84dc285fdec4ff2bf17c0d0f03621a7a6c4d650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439782Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812068}
-
Tanmoy Mollik authored
As per recent UI review change the string to "Tap to set up sync" Screenshot: https://crbug.com/1133691#c1 Bug: 1133691 Change-Id: I369a2e9f79074fcdebd975662e299483eeeec6ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440520 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#812067}
-
Rakina Zata Amni authored
Ensures visibilitychange fires before pageshow to follow the spec at https://html.spec.whatwg.org/multipage/browsing-the-web.html#session-history-document-visibility-change-steps Also ensures we would fire visibiltychange after pagehide, consistent with non-bfcache navigations. (Current attempt to change the spec to fire visibilitychange before pagehide is deemed to be a bit risky, see I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/R7h6InVXzcI/m/FNSaab_GCAAJ) TBR=altimin@chromium.org Bug: 1133363 Change-Id: I2d99bffc8710deea6ca4e0de09544bf7f5218496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435142 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#812066}
-
dpapad authored
Fixed: 1133417 Change-Id: Ic18c3f8410dccb03afd1ba14fec4d9f1ff3407e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437818 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#812065}
-
David Black authored
Fix pin toggle bounds in HoldingSpaceItemScreenshotView: The bounds of the pin toggle button were being stretched to match the full height of its parent container. Fix context menu bounds: Context menu should be below the associated view (when space allows). Fix long press gesture: When long pressing, the pressed view should become the selection just prior to showing the context menu. Fix crash in HoldingSpaceTrayBubble: If closing bubble due to ESC, bubble widget should only be closed if it exists and hasn't already been marked closed. Fix drag behavior: The holding space bubble should be closed during drag events. Bug: 1131262, 1131267, 1129981 Change-Id: I5a1f0536ae6badeed841e0a6106e9c423cbf3781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436671Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#812064}
-
Wei Lee authored
This CL follows the spec mentioned in crbug.com/1133088. Bug: 1133088 Test: Manually Change-Id: I143bbf67ebec4c2757fffb4db9b2ab1b3d856e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437995Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#812063}
-
Yoshifumi Inoue authored
This patch changes |NGInlineNodeEditor| to reuse |ShapeResult| before and after changed region by equality of substring instead of calculating it from offsets to handle generated line break markers, e.g. leading spaces in pre-wrap, and increase chance to reuse, e.g. replacing "abc" with "abX", before this patch we reuse nothing but after this patch we reuse "ab". This patch also gets rid of |NGInlineNodeData::can_use_flag_editing_| because we don't use it. Bug: 1131315 Change-Id: Ic4471340245522ced6b2a4d3d8bf43b23a2ff077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437831 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#812062}
-
My Nguyen authored
View when flag is on: http://screen/4hzTLaxE66FMnce Normally, this would link to the full Languages and Inputs page. But with Languages and Inputs being in separate page, UX thinks linking to Inputs directly is more suitable as users are in Keyboard section. Bug: 1113439 Test: Manual test Change-Id: I6087e7ff4d974daf6648b2bc45638e5f27805815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437717Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#812061}
-
Ehimare Okoyomon authored
Add utility function and enum to get a WebsitePermissionsType from a ContentSettingsType because they can take on different objects. Then use these additions to simplify WebsitePermissionsFetcher logic. Bug: 1077766 Change-Id: Ifd69d3a32df1193e295835d7c0fd2ce292e31570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421498 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#812060}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601423519-0313967a598efe443ce9d62f0d47f5b337e79203.profdata to chrome-mac-master-1601445309-ef3a210184e0709141a76a88c5c5e3ff88eb52a6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Idc0f57fcb5dfd5a390d27b33cee6a00513db7703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438314Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I516bd348ce9ba63a9aad5b3d210d7ddb84185034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438874Reviewed-by:
-
Antonio Gomes authored
This CL executes phases 5 on the design document [1]. [1] https://docs.google.com/document/d/19Zk6Fv1E-6QTQ2c33rpBjDNEkzlsSKvjb3hWkvZAE80/ It also adds triggers the generation of blink bindings by //media//fuchsia/mojom. BUG=787252 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ic2a1ffaea1f9647d9c2c18d298fc23c58d5cc5bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436749 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812057}
-
Xida Chen authored
Paint worklet already works with custom property animation running on the compositor thread, the requirement is that we need “will-change: transform” for the paint worklet element. Without that, the custom property animation will run on the main thread, such as this example: https://output.jsbin.com/muwiyux/quiet. This CL makes changes such that a custom property animation will always be composited as long as it is used by paint worklet, even if the element doesn't have "will-change: transform". The change is actually small, there are only two things we need: 1. Start the animation on compositor. 2. Ensure the compositor ticks the animation. For #1, we add a "has_paint_worklet_with_custom_prop_anim" in the Animation::PreCommit, when it is true, we always composite the animation. For #2, we give a special ElementId which is uint64_t::max() to the paint worklet element, and on the CC side, once we see that element id, we know that the animation associated with that should be ticking even if the element id doesn't have anything associated on the property tree. Bug: 987969 Change-Id: Ia849640065470e529a2b8d23a4b7b74339831c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359370Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812056}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601289755-benchmark-87.0.4275.0-r1 to 87-4265.0-1601289755-benchmark-87.0.4277.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Icbbba133c8c90f882091feb70c2894a42fec64b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439864Reviewed-by:
-
Ken Rockot authored
The sharing service does a bunch of blocking on various threads during shutdown. This can interfere with normal Mojo SharedRemote operation when the backing pipe is bound on such threads. This CL moves the SharedRemote bindings to the IO thread so that these blocking operations cannot interfere with IPC behavior and cause deadlocks. Bug: 1130069 Change-Id: I553d0d8de354afa125542ea49801eabd63cac507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439440 Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
-
My Nguyen authored
Spec: http://go/cros-lang-settings-figma Current view: http://screen/4EAq4TaqjwEyuTq New view: http://screen/5F8LUQDoHnAYZ2W Bug: 1113439 Change-Id: Ic3236e1bf3877c17ab6a5149bd865492619ba8ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437309Reviewed-by:
-
Martynas Sinkievic authored
Change-Id: Iabdb2116b294e668d366375e68ff8f7d14855d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438418Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#812052}
-
David Black authored
We would like to understand approximately how many screenshots users are taking per day and per week. This will inform how may screenshots we choose to show in the holding space feature currently under development. Note that we are also adding similar histograms to ScreenshotController so these metrics may also be useful to measure impact of capture mode. Bug: 1131266 Change-Id: Iddab5573aba57402f21ab270f8467c710d9affec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438679 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#812051}
-
Maxim Kolosovskiy authored
This CL also renames |has_script| to |has_startable_script| as the flag is true only if the username is not empty and password sync is on. Bug: 1132230 Change-Id: I27493c04629a61af788e20f4a6c81ddd542e590a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436339 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#812050}
-
Hiroki Nakagawa authored
PrerenderProcessorImpl etc should not trust an initiator origin passed from a renderer process that can be compromised. Instead of the passed origin, this CL makes the prerender components use the origin given by RenderFrameHostImpl::GetLastCommittedOrigin(). Bug: 1133185 Change-Id: I47b8ea93f9e73099fc1c1ef82eb19d8f9b71d86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437713Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#812049}
-
Victor Hugo Vianna Silva authored
By adding a title tag to the underlying web page, we ensure that the title of the dialog is read even though the Yes button is focused. Screencast of final state: crbug.com/1097085#c11 Bug: 1097085 Change-Id: I7969418715fe4d75d1d41283bb2146165155f8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440056Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#812048}
-
George Burgess IV authored
`row.normalized_term` is a `string16`, but the RHS here is an int64. This means the string16 is being assigned to a single-char string, where the char has a value of: `(uint16_t)statement.ColumnInt64(2)`. This probably isn't what was intended. Bug: 1130867 Change-Id: Id7b692a2901514b2f3cd1d5833ce145074b41983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424814Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#812047}
-
