- 06 Jun, 2018 40 commits
-
-
Christopher Lam authored
This CL fixes an issue where the First Run Dialog didn't show up with the switch enabled because the user was not considered new, which skips the First Run UI. Bug: 849551 Change-Id: Ibef80187dada0a2b99f932bf8f1256b1bf6034c2 Reviewed-on: https://chromium-review.googlesource.com/1086684Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#564767}
-
liberato@chromium.org authored
Previously, WMPI checked the video rotation and didn't enable overlays if it was nonzero. During the switch to AndroidOverlay, this is now the decoder's job. This CL tells MCVD to do that. Bug: 847338 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic76c91db1dd37e7e4160e5e7a17e2951b000884b Reviewed-on: https://chromium-review.googlesource.com/1085691Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#564766}
-
Sadrul Habib Chowdhury authored
Use the presentation-time for measuring the tab-switching times, both for the browser process, and the renderer process (when the renderer needs to submit new content because of the switch, if its content had been evicted while it was in the background). This removes the usage of ui::LatencyInfo for measuring the tab-switching time, and TAB_SHOW_COMPONENT is no longer needed. So TAB_SHOW_COMPONENT is removed, and IPCs are updated to not carry a ui::LatencyInfo anymore. BUG=849182 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ie6d695ebc2ffaed321e061b965615cee8564430d Reviewed-on: https://chromium-review.googlesource.com/1083862 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Brian Anderson <brianderson@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#564765}
-
Weidong Guo authored
Changes: 1. Define "page break" item as an indicator to create a new page in app launcher. 2. Add function to add "page break" item in item list and sync it to backend. 3. Add function to remove redundant "page break" items. See details at go/applist-gap BUG=843709 Change-Id: I23efb2d833e93683be873a0aff92fe15938075fa Reviewed-on: https://chromium-review.googlesource.com/1079453Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#564764}
-
Noel Gordon authored
Adding a file to a path's basic file entry set is common in these test fixtures: common enough to warrant a helper routine. Also don't bother sorting the row entries: remoteCall.waitForFiles does that. Bug: 847172 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I529015eb9a5aa7fda59d9e33babee752875db5ab Reviewed-on: https://chromium-review.googlesource.com/1087189Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#564763}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3857fbf..7d43296 git log 3857fbf..7d43296 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 7ba3f42..d197803 (1 commits) Created with: gclient setdep -r src/third_party/skia@7d43296 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: I94622dc4310a670462bb64b6b29717d75951c149 Reviewed-on: https://chromium-review.googlesource.com/1087614Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564762}
-
Carlos Knippschild authored
The publish code from OfflinePageModelTaskified was deleting the instance of OfflinePageArchiver right after requesting the publishing of pages instead of waiting until they were done. This CL addresses that by changing both the internal and external implementation of the publish methods to use pending_archivers_ to store that instance until the action callback is received. This bug was also partially hidden away because test code was not post-tasking the callback but calling it directly instead. So that has also been changed to more closely mimic the runtime code. Nonetheless the runtime code has alse been made more resistant to the cases where the non-post-task callback happens. Bug: 847630 Change-Id: I1df933ed43a54fa4dccf342fcd7da46403d1a0ea Reviewed-on: https://chromium-review.googlesource.com/1077656Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#564761}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/99a065d..36d4a47 git log 99a065d..36d4a47 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 dtu@chromium.org [pinpoint] Add testapp to the global TestCase. Created with: gclient setdep -r src/third_party/catapult@36d4a47 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I74719af3b3395369900c131d3a1e77707ba801eb Reviewed-on: https://chromium-review.googlesource.com/1087636Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564760}
-
Tetsui Ohkubo authored
This CL adds UnifiedSystemTrayTestApi, which implements mojom::SystemTrayTestApi for UnifiedSystemTray. TEST=browser_tests --enable-features=SystemTrayUnified BUG=847104 Change-Id: I278ec8d381aa9f7c13121088a892419dc627b655 Reviewed-on: https://chromium-review.googlesource.com/1086674 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#564759}
-
Kyle Horimoto authored
This class is based on the chromeos::tether::BleScanner class, but it has several key distinctions: (1) It must support scanning for devices which belong to multiple accounts, so it supports having more than one "local device". The function used to direct BleScanner to start or stop scanning is SetScanFilters(). (2) It only has a single listener, so I've changed the Obsever pattern to a Delegate pattern. (3) Since SecureChannelService cannot be temporarily disabled, there is no longer a need for the asynchronous shutdown flow, so the OnDiscoverySessionStateChanged() callback is no longer needed. (4) The artificial limit of 2 devices has been removed. In SecureChannel, it should be possible to scan for as many nearby devices as the client requests. Bug: 824568, 752273 Change-Id: Idaf6b65a6465d41e7979a81d8024b162a32b9b49 Reviewed-on: https://chromium-review.googlesource.com/1084319 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#564758}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3c46387..784bb7f git log 3c46387..784bb7f --date=short --no-merges --format='%ad %ae %s' 2018-06-05 vapier@chromium.org cros lint: rework extension/linter lookups 2018-06-05 bmgordon@chromium.org cros_build_lib: Catch additional gethostbyaddr exception 2018-06-05 bpastene@chromium.org chromite: Roll third_party/gn_helpers forward. 2018-06-05 vapier@chromium.org qemu: fix bug in registration logic 2018-06-05 vapier@chromium.org qemu: add more logging around registration Created with: gclient setdep -r src/third_party/chromite@784bb7f The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:824808,chromium:824808 TBR=chrome-os-gardeners@chromium.org Change-Id: I122486e1710bce26bd16709b9d5c6d401cdb9f38 Reviewed-on: https://chromium-review.googlesource.com/1087637Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564757}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/57776df..88482c3 BUG=chromium:849217 chromium:846693 TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ifd196a7e538ee5280f3af78db9e95913ad8365ac Reviewed-on: https://chromium-review.googlesource.com/1087786 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#564756}
-
Robert Ogden authored
Allows a non-Chromium dev to notice when a bad ClientConfig has been given. Only does LOG(ERROR) in non-debug builds though since DCHECK is otherwise sufficent. Bug: 724242 Change-Id: Id3b7138e81329c296e0aaeac326e2e212e4362e6 Reviewed-on: https://chromium-review.googlesource.com/1087513Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#564755}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7edcf2c..c22d671 git log 7edcf2c..c22d671 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 tsepez@chromium.org Introduce IJS_Runtime::ScopedEventContext helper class. Created with: gclient setdep -r src/third_party/pdfium@c22d671 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4b64cfad08ab67e2978e8700179642778a34d7ba Reviewed-on: https://chromium-review.googlesource.com/1087635Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564754}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5316b1cb. With Chromium commits locally applied on WPT: e8832df8 "webrtc wpt: remove test_state_change_event" a558107e "[LayoutNG] Fix flex BODY in quirks mode" be0ac4b3 "Reland "WaveShaper must output non-zero values even if input is silent"" b9e5f3f7 "[css-contain] Disable layout containment for certain elements" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19096 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB kozyatinskiy@chromium.org: external/wpt/console meade@chromium.org: external/wpt/web-animations mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy mstensho@chromium.org: external/wpt/css/css-multicol worker-dev@chromium.org: external/wpt/workers yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=foolip No-Export: true Change-Id: I1f55148a4bd1008c33abc33271fe21abafe17787 Reviewed-on: https://chromium-review.googlesource.com/1087824 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#564753}
-
Sunny Sachanandani authored
GetLastError returns the HRESULT of the last win32 API call and not the last failed call so this UMA doesn't work as expected. Replace with GPU.DirectComposition.SwapBuffersFailed boolean UMA that just counts number of failures. Bug: 837378 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idee2ad507316823d31f95405e4431287f9aef5ee Reviewed-on: https://chromium-review.googlesource.com/1072692 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#564752}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7ba3f42..d197803 git log 7ba3f42..d197803 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 jmadill@chromium.org Roll dEQP (June 2018). Created with: gclient setdep -r src/third_party/angle@d197803 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Idf7c2cd8887abafba4306ca79840824dc3573bf9 Reviewed-on: https://chromium-review.googlesource.com/1087633Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564751}
-
David Trainor authored
Adds support for items querying thumbnails. This is the same capability that exists in the current downloads home. This change has the following details; - Exposes a callback to get and cancel visual requests to the View layer through the model. - Adds the concept of a ViewHolder that knows how to request for thumbnail assets. - Connects the thumbnail request to the ThumbnailProviderImpl and propertly interacts with the download backend and the OfflineContentProvider backends. Bug: 842345 Change-Id: I884a9d46bcece9dba08707f97f40a5b15936ddf0 Reviewed-on: https://chromium-review.googlesource.com/1084077 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#564750}
-
Tim Zheng authored
This change avoids set window bounds twice. BUG=chromium:843001 TEST=Manual test on an eve device. Change-Id: If08f8e4fd7b8e91db43f265fa8fdc46c3da6eb86 Reviewed-on: https://chromium-review.googlesource.com/1087844Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#564749}
-
Tommy Steimel authored
This CL adds CSS to change the overflow menu and list item sizes based on the sizing-* CSS class to match the new mocks. Bug: 839107, 839088, 837027 Change-Id: I82a633b88c787e200d1b088fb51d7fed2c066e56 Reviewed-on: https://chromium-review.googlesource.com/1087796Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#564748}
-
Andrew Grieve authored
Change-Id: I7885292bd9d125c45fa7aec61f657df47c2c4fc6 Reviewed-on: https://chromium-review.googlesource.com/1087173 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#564747}
-
Henrique Grandinetti authored
Bug: 849759 Change-Id: I932a5530cf213660c85009f63970fe3edb8ed039 Reviewed-on: https://chromium-review.googlesource.com/1072587 Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Cr-Commit-Position: refs/heads/master@{#564746}
-
Ryan Hansberry authored
Bug: 824568, 752273 Change-Id: Iae40dd308ad057b08d4f3a6ad4433794243f4cce Reviewed-on: https://chromium-review.googlesource.com/1086710Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#564745}
-
Ryan Sturm authored
This adds a previews type state to the pingback that represents that no preview was served due to the blacklist acting on one of its rules. The states are still mutually exclusive. Bug: 849328 Change-Id: I40235d318b68e9674b67ae40df30153c30aba178 Reviewed-on: https://chromium-review.googlesource.com/1086242 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#564744}
-
Tarun Bansal authored
In data reduction proxy, add a mechanism to disable the caching of the canary check result. The goal is to determine if the caching of the result is the root cause for the drop in page load count when data saver probing experiment is enabled. Bug: 849292 Change-Id: I5b62defa8b7fca1a0791c7da345385cc82afe496 Reviewed-on: https://chromium-review.googlesource.com/1086355 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#564743}
-
Josh Karlin authored
What: 0. Create PrioritizedTaskRunner which provides 2^32 priority levels for a given TaskRunner. 1. Plumb net::RequestPriority into the disk_cache::Entry. 2. Implement support for priorities in the SimpleCache (mem cache doesn't need it because it's synchronous and maybe we'll get to block cache later). 3. Remove worker_pool_ from SimpleCacheBackend since we can use PrioritizedTaskScheduler instead. 4. Add a feature for field trials. SimpleCache prioritizes first by RequestPriority and second by request age. ((net::RequestPriority::MAXIMUM_PRIORITY - request_priority_) * 10000) + entry_priority_; Where request_priority is the net::RequestPriority and entry_priority_ is the count of entries that have been created at the point of entry creation. Why: Today, low priority new requests have as much priority in the cache worker pool as high priority old requests. This causes TTFB to suffer for high priority, early requests in the page. Delayed TTFB means time that the consumer (the renderer) isn't streaming bytes. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I22121c6091e67ee995e12951560413cf7bdd0352 Reviewed-on: https://chromium-review.googlesource.com/1064506Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#564742}
-
Stefan Zager authored
TBR=eae@chromium.org NOTRY=true Change-Id: Ib155a375fd2fea85895b7a031e9e4f8afadfe181 Reviewed-on: https://chromium-review.googlesource.com/1087642Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#564741}
-
David Black authored
AssistantBubbleController is a sub-controller of AssistantController. A follow up CL will pull interaction logic out of AssistantController into another sub-controller called AssistantInteractionController. This is part of an effort to clean up and simplify AssistantController. Bug: b:80542452 Change-Id: I57dca92433d37140f5138923e1d35df7fa79d785 Reviewed-on: https://chromium-review.googlesource.com/1086362 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#564740}
-
Michael Spang authored
When a rotation is set, a very tiny error is introduced in the root window transform due to use of trig functions in computing the transform. This small error is later turned into a full pixel error when the root window updates its transform. Avoid trig functions in the display rotation transform. Use of a scale factor can still cause similar problems, but this should fix most problems at 1x scale. Bug: b/78781894 Test: cast_graphics_unittests with new test in next patch Change-Id: I1ac5d50ef56a1627f2698a47f5d4a2692446332f Reviewed-on: https://chromium-review.googlesource.com/1087805Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#564739}
-
Tetsui Ohkubo authored
A mask layer should always have the same bounds as its parent's. TrayBubbleView sets a mask layer to layer()->parent(), but used the bounds of layer() for its mask layer. It caused DCHECK. Previously, https://crrev.com/c/663422 tried to fix this by using GetBubbleBounds(), but it still doesn't return the correct bounds in some cases e.g. |corner_radius| and |has_shadow| = false are set. TEST=TrayEventFilterTest BUG=847104,764428 Change-Id: I677a0df7fc5342e7f722c97c30fc0b87f25b23f4 Reviewed-on: https://chromium-review.googlesource.com/1084530Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564738}
-
Peter Collingbourne authored
The lack of swarming was the most likely cause of mysterious test failures that weren't affecting any other builder. Bug: 849868 Change-Id: I6ee8b78886dce01a319062b3d6526381bb25ecf3 Reviewed-on: https://chromium-review.googlesource.com/1087818Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#564737}
-
Liquan(Max) Gu authored
Due to the possible absence of frame or document loader from the performance object, it's not guaranteed that processing start would be always earlier than onload. Reuse existing code to refactor the buffering-before-onload logic. Bug: 847496 Change-Id: If3fae54e90747572956610bedadd7963463a5dcc Reviewed-on: https://chromium-review.googlesource.com/1080131 Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#564736}
-
Sadrul Habib Chowdhury authored
Re-enable the tab-switching benchmark on linux after the tabs-metric fix in crrev.com/c/1083790. BUG=842732 Change-Id: Iac9ae2f83ccf6082bb3cf1e7223ccb89bf517f85 Reviewed-on: https://chromium-review.googlesource.com/1084056Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#564735}
-
Steven Bennetts authored
This CL removes kChromeUITermsOemURL (chrome://chrome://terms/oem) which is unused in the MD UI and non functional. This CL also disables: WebviewClientCertsLoginTest.ClientCertRequestedInOtherWebView (See comment for details). Bug: 647411 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4bae3abfadd6261fd37a449dcda4a1f37ba4850a Reviewed-on: https://chromium-review.googlesource.com/1080174 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#564734}
-
Aga Wronska authored
It makes it clear that including users' emails in activity report is a diffrent thing than reporting list of device users. Follow up for: https://chromium-review.googlesource.com/c/chromium/src/+/1034120 Test: Run DeviceStatusCollectorTest and ConsumerDeviceCollectorTest Change-Id: I7b749c5abefb3a892aeb21113647a75feeae1255 Reviewed-on: https://chromium-review.googlesource.com/1080171Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#564733}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d566165..6563513 Created with: gclient setdep -r src-internal@6563513 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0b87ffe84cd06dd03945e155af1af16f44be4144 Reviewed-on: https://chromium-review.googlesource.com/1087638Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564732}
-
Wez authored
LaunchProcess was previously implemented using "launchpad", which is being replaced for SDK users by the fdio_spawn*() APIs. - Migrate call-sites off the old |options.clone_flags|. - Add the fdio_spawn*() header file to our GN package rule for "fdio". - Add TODO to "launchpad" package definition for it to be removed once all dependency repos have been updated (e.g. gtest, crashpad). Bug: 848028 Change-Id: I2d871a0f77bd9cba0d16217371069989fdef17f3 Reviewed-on: https://chromium-review.googlesource.com/1081078Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#564731}
-
Kyle Horimoto authored
Now, this class takes a DeviceIdPair rather than a single device ID. This is in preparation for integrating this class with SecureChannel. Bug: 824568, 752273 Change-Id: I21f355967590bbcda699e3f155ab93cd47959af4 Reviewed-on: https://chromium-review.googlesource.com/1086512Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#564730}
-
Matt Falkenhagen authored
It's also failing on ASAN which I guess isn't part of [ Debug ]. Bug: 849670, 789111 Change-Id: I93ceceb4c4c84390dc2253132a29c1cccde722fc NOTRY: true TBR: horo Reviewed-on: https://chromium-review.googlesource.com/1087195Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#564729}
-
Xi Cheng authored
Change-Id: I2168bf5f55cb30f4cb7098a6a98fe3b9176682e6 Reviewed-on: https://chromium-review.googlesource.com/1087404 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#564728}
-