- 03 Mar, 2020 40 commits
-
-
Alison Maher authored
Add fragmentation support for fieldset content (excluding the legend). Tests added to NGFieldsetLayoutAlgorithmTest. Bug: 875235 Change-Id: I0e61bbac924be00cc389adc77abc73390ccfa1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071582 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#746471}
-
Ana Salazar authored
Add a metrics reporter for Layer Animations within the navigation widget. Bug: 1049705 Change-Id: I1ade5e327b926856a940fc72ae50bf9928097fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049824 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#746470}
-
Anqing Zhao authored
Use a new class 'UserSessionInitializer' to handle common initialization logics in 'ChromeSessionManager' and 'UserSessionManager'. Whenever profiles are loaded, corresponding methods in the observer will be triggered. Bug: 977489 Change-Id: Ida1c7cae0406a42edfe62ebf192dfd9bbcbe1301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085253Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#746469}
-
rajendrant authored
This CL setup command line params to skip optimization guide models to trigger lite page redirect preview. Bug: 1049675 Change-Id: I2dbcbf6af4ceddf302785c9e6b0514e1ec7e2f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081844Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#746468}
-
Steven Bennetts authored
TBR=stevenjb@chromium.org Change-Id: If16478a59069f8a3df61e2341222e51a07eb6913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083568 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746467}
-
Alexander Timin authored
PrerenderTabHelper at the moment listens to a number of methods, including DidStartNavigation and DidRedirectNavigation without using them. Delete them as they are not needed. R=tbansal@chromium.org Change-Id: I4c9de8c10aab644b165e49399088c05b99f80043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066790 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#746466}
-
Nazerke authored
This CL modernizes the LocationBarCoordinator - to use |browser| in the initializer - to use self.browser to get browserstate, webstatelist and dispatcher values. Bug: 1029346, 1048686 Change-Id: I87e10f13748c477b841dadb42249bfd89860d9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078453Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#746465}
-
Mark Pearson authored
The previous advice was too strict about emitting at a regular interval when at the end of event is perfectly okay. Inspired by https://chromium-review.googlesource.com/c/chromium/src/+/2049824/16 Change-Id: I93b3f44a9c91d623e08c9327d902e7ca6af36263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083683 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#746464}
-
Donn Denman authored
BUG=1048827 TBR=mastiz@chromium.org Change-Id: I95387295890b0df545a03314f55e822503a36eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084715 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#746463}
-
Łukasz Anforowicz authored
This reverts commit 68e96adf. Reason for revert: See https://crbug.com/966223#c28 Original change's description: > Document origin for neither-GET-no-HEAD request made by extensions > > Bug: 1036458, 966223 > Change-Id: Ia32c5256376bd7ead965b0ade24f48e76b35acb9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980655 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729209} TBR=yhirano@chromium.org,rdevlin.cronin@chromium.org,lukasza@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1036458, 966223 Change-Id: Ib76bda52d3c173f9dd7140e408185b5820163f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082607Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#746462}
-
Collin Baker authored
Other functions in the class do similar null checks. See bug report for crashes on frame_connector_->GetParentRenderWidgetHostView() call. Bug: 1041922 Change-Id: Ifbd3023aa24bd307841bc97dbc03ed444a8bc85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083739Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#746461}
-
Stephen Roe authored
This makes it easier to estimate Fuchsia ARM64 CI builder test stability before turning on CI tests. After Fuchsia ARM64 CI builder tests are turned on, the fuchsia-fyi-arm64-rel exceptions can be relaxed to debug flakey tests before enabling them in CI. Note that there are a lot of changes in generated files like ci.json that are unrelated to the test_suite_exceptions.pyl changes. Could earlier changes to source files have been checked in without updating the generated files? Bug: 1042512 Change-Id: I9abf23fef24243f0c60fdd85c108720906aaa60d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083342 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#746460}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c3655c3a7d55..f8b286781636 git log c3655c3a7d55..f8b286781636 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 xiaoxuan.liu@arm.com Vulkan: Add support for VK_EXT_index_type_uint8 Created with: gclient setdep -r src/third_party/angle@f8b286781636 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: I0805a5d0d6e2be9b9d341ed75c1ee13f3f8ce233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085016Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746459}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5f37cd3c..65b70d61 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I72ca9ea8bf78f6b012b5ef03a54d9ca60c5150e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084832Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746458}
-
Mikel Astiz authored
The USS implementation of bookmark sync launched with M77 and most code has already been cleaned up. Transaction versions embedded in BookmarkModel are no longer used and can also be deleted. Change-Id: Icfe2ab727edce293c73b7b3ae521df66a71d843a Bug: 933756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081426Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746457}
-
Tim Dresser authored
Bug: 1051558 Change-Id: Iea32652052262e5ac4454fe07ee1bcaacec285cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084712Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#746456}
-
Kurt Horimoto authored
Bug: none Change-Id: I12c62918c78a9cd8249396b6cfe33a5bb544c254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084714 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746455}
-
Ken Rockot authored
This enables the unsandboxed out-of-process Storage Service for separate runs of browser_tests, content_browsertests, extensions_browsertests, and interactive_ui_tests on Linux and Windows FYI bots. Once these remain green for a bit, they can just move to the main waterfall. Bug: 994911 Change-Id: I565e6ba067d3dced10df5c5faa92031db766e8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083844Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#746454}
-
Tim van der Lippe authored
This were replaced by e2etests in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2062588 and https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2062603 TBR=aerotwist@chromium.org Bug: 1044632 Change-Id: I857c07937cb753cf452d9fcef84a9f3f56eee1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085191Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#746453}
-
John Lee authored
Previously, the swipe animation was mapped to where the user's pointer would be and would make the tab element disappear before the close event was confirmed. This CL sets it up such that the animation does not progress and only detects when a swipe happens. This is to address a bug where the front-end is not able to confirm whether the tab was successfully closed, due to an unload dialog. Bug: 1050747 Change-Id: Ia0a4658260ebd73a05bd616b4a8df5d4c4e2525e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083403Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#746452}
-
Nohemi Fernandez authored
Adds a gradient layer aligned with the UnifiedConsent embedded screen that will hide part of text if the device size is small to give the illusion that it is hidden further down on the device. Updates the anchors of the confirmation and skip sign-in buttons. Bug: 971989 Change-Id: I20cde343820af0d4ab5de3f45a374eaed48190b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080367 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#746451}
-
Robbie Gibson authored
Before, if there were suggestions on the NTP, they would immediately appear. The better animation is to scroll the fakebox up to the top of the screen and then present the suggestions. To do this, when entering the omnibox from NTP, we only focus the location bar, which causes the scrolling animation. -fakeboxFocused is already called in the animation completion block, which does the actual work to make the omnibox text field first responder, causing the suggestions to appear. To finish off, the -locationBarDidBecomeFirstResponder code now only focuses the location bar if we are not on the regular NTP. Bug: 1057643 Change-Id: I472ee1ee5693fa4102717275bf266f4ab97e121a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082556 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Garrett Beaty authored
Mac Builder Next doesn't use a builderless machine; there's one machine that is allocated to it. When the machine was updated to Mac 10.15, its tasks started expiring because the machine no longer matched the os dimension. Change-Id: I039c61f381d0a65204a62b9c1333b1f6b652a416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083561 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
AdvancedSettingsSigninCoordinator present the advanced settings during sign-in process. This patch add the implementation of AdvancedSettingsSigninCoordinator, and removes the old implementation. See http://go/chrome-ios-signin-migration Bug: 971989 Change-Id: Id60834f575284ba48cdafc4a3b9a8e227a2a43ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050568 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d5ae9bf042df..f57a5e85c09d git log d5ae9bf042df..f57a5e85c09d --date=short --first-parent --format='%ad %ae %s' 2020-03-03 aerotwist@chromium.org [e2e] Migrates http/tests/devtools/user-metrics-perf.js to e2e 2020-03-03 sigurds@chromium.org [Issues] Add revealer for issues 2020-03-03 tvanderlippe@chromium.org Fix jsdoc for ls function 2020-03-03 gabriel.luong@gmail.com Typecheck common/Console.js with TypeScript 2020-03-03 tvanderlippe@chromium.org Reland "Typecheck Object.js" 2020-03-03 szuend@chromium.org Prepare ResourceMapping.js for asynchronous live locations 2020-03-03 tvanderlippe@chromium.org Add tests to verify sources panel shows lazy-loaded files 2020-03-03 jacktfranklin@chromium.org Remove `String#reverse` in favour of a utility function 2020-03-03 aerotwist@chromium.org [e2e] Adds licences; updates expectations 2020-03-03 szuend@chromium.org [utilities] Use Map + Set instead of Object + Array in ExtensionServer 2020-03-03 liviurau@chromium.org Exception cannot be converted to string 2020-03-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-03 wolfi@chromium.org Add button to clear filter in network tab Created with: gclient setdep -r src/third_party/devtools-frontend/src@f57a5e85c09d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1032016,chromium:1032561,chromium:1044632,chromium:1046784,chromium:1050549,chromium:1057642,chromium:1057979 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie39bf2e24076850c7ed2670fb870c9dd07fbbf53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085018Reviewed-by:
-
Jose Lopes authored
This is a repeating callback because it's called from a while loop: * https://cs.chromium.org/chromium/src/media/formats/mp2t/es_adapter_video.cc?rcl=3ebd977605c09c89a0205af40d95c4814eed78f0&l=138 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I2a8a3c8a75fd8d2ac73ae71082dadf4f0f40af0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080240 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#746446}
-
Xing Liu authored
This reverts commit 60d219b6. Reason for revert: breaks android downstream. https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8886827242049965872/+/steps/compile/0/stdout Original change's description: > [webauthn] Don't adjust timeout when testing > > Move the timeout adjustment from blink to the browser and avoid > adjusting it if we detect a discovery factory override is in place. > > This change makes authenticator browser tests and WPTs 3X faster. > > Fixed: 976428 > Change-Id: Iaea88f356a6d090c14474151b29c04e912c471b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079043 > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#746432} TBR=kenrb@chromium.org,nsatragno@chromium.org,jsaul@google.com Change-Id: Iab40100ead5acdbc6dc631461470314f9eafc815 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083564Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746445}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/176f3a3dbbc9..abc7a30a06c7 git log 176f3a3dbbc9..abc7a30a06c7 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 capn@google.com Fix ASTC support for GN build Created with: gclient setdep -r src/third_party/swiftshader@abc7a30a06c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic3790a24502823869e16cc3268d9688b8752aa0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085015Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db533a37a8ca..f8a16ac6d467 Created with: gclient setdep -r src-internal@f8a16ac6d467 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifacdc85ce44f0b57c1254ccdff9cb0d6ea1b5471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085013Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746443}
-
Andrew Grieve authored
Stack is: Caused by: android.util.AndroidRuntimeException: Calling startActivity() from outside of an Activity context requires the FLAG_ACTIVITY_NEW_TASK flag. Is this really what you want? at android.app.ContextImpl.startActivity (ContextImpl.java: 952) at android.content.ContextWrapper.startActivity (ContextWrapper.java: 405) at org.chromium.chrome.browser.ChromeApplication.startActivity (ChromeApplication.java: 206) at org.chromium.chrome.browser.ChromeApplication.startActivity (ChromeApplication.java: 199) at org.chromium.chrome.browser.DelayedScreenLockIntentHandler.onReceive (DelayedScreenLockIntentHandler.java: 40) at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0$LoadedApk$ReceiverDispatcher$Args (LoadedApk.java: 1550) ... From history on DelayedScreenLockIntentHandler, repro steps involve launching a page via NFC while locked. This restriction is listed as a new one in Android P: https://developer.android.com/about/versions/pie/android-9.0-changes-all#fant-required Bug: 1034440 Change-Id: Ibe13fb99a34d36a15e266d9369393dd6060a1e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972135 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#746442}
-
Daniel Vogelheim authored
This CL renames/refactors three loosely related things: - renames API methods from GetStringFrom(Specific)?TrustedXXX to TrustedTypesCheckForXXX. - renames the SpecificTrustedType enum class values (removes the redundant 'Trusted', since C++ enum classes are always used with their class name, and are hence naturally unambiguous) - re-writes the union-type methods in terms of the string-based ones. The earlier implementation used the union-type methods as the core implementation, and all other methods called those. This made the code a bit more complicated, and will make subsequent work harder because we will eliminate the union types. This re-works this so that the core checking logic is always in the string-based methods, and all union-type based ones call those instead. This is follow-on work from review crrev.com/c/2066730. Bug: 739170 Change-Id: I8716b5310e6c2d9f419efe2c5a3b660ad4d1af42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078254Reviewed-by:
Yifan Luo <lyf@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#746441}
-
Gabriel Charette authored
Analysis of experiment results: https://docs.google.com/document/d/13PIBPuSPJbrgHAgyRbY22EWAfH2narnxpa_CgBmZbSY/edit#heading=h.4fo2tzjehwu7 Updated documentation accordingly. The Java changes should be no-ops (the previous Java default was left as USER_VISIBLE unintentionally in crrev.com/664726 but never kicked in when !mPrioritySetExplicitly). R=fdoray@chromium.org Fixed: 1022972 Change-Id: Iab8219e68ab703e0cc9ceeb16ef70b78cf43a50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063150 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#746440}
-
John Delaney authored
Moves the expiry for these flags from M82->M85 as this feature is still under experiment. Change-Id: Ibbe51f5347b659886264838b1cb62cd706a1767e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083450Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#746439}
-
Vasiliy Telezhnikov authored
After BeginWrite was moved out of critical path SkiaOutputDeviceBufferQueue::Image is often in the middle of write. When resize or reallocation of display happen (e.g rotate screen on Android) we need to call EndWrite on the image before destruction to ensure all necessary semaphores are submitted. Bug: 1056221 Change-Id: Id55c25f43cbb4bf082ad3e3ef6cd1b59e164937d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083835 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#746438}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia29f89b3066ea48480a59b9a56482e44758e6970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085017Reviewed-by:
-
Anders Hartvoll Ruud authored
I forgot to actually set the CSSValue (i.e. cache key), which means the cache was never used. This CL adds a performance test for this which should catch regressions in the future. The test works by specifying a couple of shorthands, each of which has a large number of var() references that needs resolving. Local testing on my machine shows ~170ms with the cache enabled, and over 500ms with the cache disabled. Change-Id: I867679969bb6617219388e0b6f28adc3ae223f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080262Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#746436}
-
Maksim Ivanov authored
This fixes the UX glitch that pressing the "Back" button in the SAML smart card PIN dialog (<security-token-pin> Polymer element) was triggering the "Network Error" screen. The underlying issue is that cancelling the PIN dialog indeed aborts the TLS handshake with an error, but it doesn't make sense to show this error to the user. The proposed fix is to remember whether the PIN dialog was canceled during the current authentication attempt, and suppress the network error in that case. Bug: 1052409 Test: start SAML login via a smart card, proceed to PIN dialog, press "Back", verify that no Network Error screen is shown Change-Id: If54dbd067da763afca7ceec4957bebf0d748da9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069542 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#746435}
-
Rune Lillesveen authored
Sadly, we do SetInlineStyleProperty() for UA shadow DOM during style recalc in some cases. Make sure that we don't schedule any invalidation while in style reacalc as that would leave use with a dirty tree for style invalidations after UpdateStyle(). This fixes a regression introduced in [1] where we unified the invalidation code for the various ways of changing the inline style. [1] https://crrev.com/2faf55836255e6762141712d943c47f3208c8ac4 Bug: 1057210 Change-Id: I0edab4acc03baefe0fb386c15dce78e0f8e041ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082382 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#746434}
-
Reilly Grant authored
This is a follow-up to r689238 which makes sure that the file descriptor watchers are always removed before closing the serial port. The previous fix handled most cases but left open the possibility that a watcher was still registered if there wasn't a pending read or write operation to cancel. Bug: 1057858 Change-Id: I0c760b84cbad2ec4632c9d99e8c5b2550d770ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083922 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#746433}
-
Nina Satragno authored
Move the timeout adjustment from blink to the browser and avoid adjusting it if we detect a discovery factory override is in place. This change makes authenticator browser tests and WPTs 3X faster. Fixed: 976428 Change-Id: Iaea88f356a6d090c14474151b29c04e912c471b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079043 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#746432}
-
