- 25 Mar, 2011 40 commits
-
-
ggaren@apple.com authored
Reviewed by Dan Bernstein. Add a simplified normal flow layout path optimization for overflow recomputation and for positioned objects inside relative positioned containers. Currently there is an optimized code path for positioned objects, but as soon as we encounter a normal flow object in the containing block chain, we lose the optimization. This patch adds a new type of style difference called SimplifiedLayout that is returned when only overflow needs to be recomputed. Whenever a transform changes, this is the hint returned now instead of a full layout. In addition, when positioned objects need layout and start marking up the containing block chain, we now propagate the fact that the layout is simplified all the way up to the root, even when we encounter normal flow containing blocks. The layoutOnlyPositionedObjects function has been renamed to simplifiedLayout() and is now used for all of these cases (in addition to what it handled before). The simplified layout optimization (even in ToT) did not work correctly when static distances needed to be recomputed. In order to make static distance computations work with simplified layout, positioned objects now always compute their static offsets, even if they explicitly specify left/top. That way normal flow layout never has to re-run when the positioned object moves. This makes movement of a positioned object along a single non-auto axis much faster when the other axis is auto. Because this code kicked in more often for absolutely positioned objects whose original display was inline, I went ahead and fixed the trailing space issue with those objects. This causes a bunch of layout tests to progress. Added fast/block/positioning/static-inline-position-dynamic.html and trailing-space-test.html. * animations/dynamic-stylesheet-loading-expected.txt: * animations/keyframe-timing-functions-expected.txt: * fast/block/positioning/static-inline-position-dynamic.html: Added. * fast/block/positioning/trailing-space-test.html: Added. * fast/dynamic/ancestor-to-absolute-expected.txt: * fast/forms/input-appearance-elementFromPoint-expected.txt: * fast/forms/input-hit-test-border-expected.txt: * platform/mac/fast/block/positioning/002-expected.png: * platform/mac/fast/block/positioning/003-expected.png: * platform/mac/fast/block/positioning/004-expected.png: * platform/mac/fast/block/positioning/005-expected.png: * platform/mac/fast/block/positioning/006-expected.png: * platform/mac/fast/block/positioning/007-expected.png: * platform/mac/fast/block/positioning/008-expected.png: * platform/mac/fast/block/positioning/009-expected.png: * platform/mac/fast/block/positioning/010-expected.png: * platform/mac/fast/block/positioning/011-expected.png: * platform/mac/fast/block/positioning/012-expected.png: * platform/mac/fast/block/positioning/013-expected.png: * platform/mac/fast/block/positioning/014-expected.png: * platform/mac/fast/block/positioning/015-expected.png: * platform/mac/fast/block/positioning/016-expected.png: * platform/mac/fast/block/positioning/017-expected.png: * platform/mac/fast/block/positioning/018-expected.png: * platform/mac/fast/block/positioning/019-expected.png: * platform/mac/fast/block/positioning/020-expected.png: * platform/mac/fast/block/positioning/021-expected.png: * platform/mac/fast/block/positioning/022-expected.png: * platform/mac/fast/block/positioning/023-expected.png: * platform/mac/fast/block/positioning/024-expected.png: * platform/mac/fast/block/positioning/025-expected.png: * platform/mac/fast/block/positioning/026-expected.png: * platform/mac/fast/block/positioning/027-expected.png: * platform/mac/fast/block/positioning/028-expected.png: * platform/mac/fast/block/positioning/029-expected.png: * platform/mac/fast/block/positioning/030-expected.png: * platform/mac/fast/block/positioning/031-expected.png: * platform/mac/fast/block/positioning/032-expected.png: * platform/mac/fast/block/positioning/033-expected.png: * platform/mac/fast/block/positioning/034-expected.png: * platform/mac/fast/block/positioning/035-expected.png: * platform/mac/fast/block/positioning/036-expected.png: * platform/mac/fast/block/positioning/037-expected.png: * platform/mac/fast/block/positioning/038-expected.png: * platform/mac/fast/block/positioning/039-expected.png: * platform/mac/fast/block/positioning/040-expected.png: * platform/mac/fast/block/positioning/041-expected.png: * platform/mac/fast/block/positioning/042-expected.png: * platform/mac/fast/block/positioning/043-expected.png: * platform/mac/fast/block/positioning/044-expected.png: * platform/mac/fast/block/positioning/045-expected.png: * platform/mac/fast/block/positioning/046-expected.png: * platform/mac/fast/block/positioning/047-expected.checksum: * platform/mac/fast/block/positioning/047-expected.png: * platform/mac/fast/block/positioning/048-expected.png: * platform/mac/fast/block/positioning/049-expected.png: * platform/mac/fast/block/positioning/050-expected.png: * platform/mac/fast/block/positioning/056-expected.txt: * platform/mac/fast/block/positioning/061-expected.png: * platform/mac/fast/block/positioning/062-expected.png: * platform/mac/fast/block/positioning/auto/005-expected.txt: * platform/mac/fast/block/positioning/auto/006-expected.txt: * platform/mac/fast/block/positioning/auto/007-expected.png: * platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.txt: * platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.txt: * platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.checksum: * platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.png: * platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.txt: * platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.txt: * platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.checksum: * platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.png: * platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt: * platform/mac/fast/block/positioning/inline-block-relposition-expected.checksum: * platform/mac/fast/block/positioning/inline-block-relposition-expected.png: * platform/mac/fast/block/positioning/inline-block-relposition-expected.txt: * platform/mac/fast/block/positioning/move-with-auto-width-expected.png: * platform/mac/fast/block/positioning/negative-rel-position-expected.png: * platform/mac/fast/block/positioning/relative-overconstrained-expected.png: * platform/mac/fast/block/positioning/relative-overflow-block-expected.txt: * platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.checksum: Added. * platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.png: Added. * platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.txt: Added. * platform/mac/fast/block/positioning/trailing-space-test-expected.checksum: Added. * platform/mac/fast/block/positioning/trailing-space-test-expected.png: Added. * platform/mac/fast/block/positioning/trailing-space-test-expected.txt: Added. * platform/mac/fast/clip/001-expected.txt: * platform/mac/fast/clip/004-expected.txt: * platform/mac/fast/clip/006-expected.txt: * platform/mac/fast/clip/007-expected.txt: * platform/mac/fast/clip/008-expected.txt: * platform/mac/fast/clip/009-expected.txt: * platform/mac/fast/clip/010-expected.txt: * platform/mac/fast/clip/011-expected.txt: * platform/mac/fast/clip/012-expected.txt: * platform/mac/fast/clip/013-expected.txt: * platform/mac/fast/clip/014-expected.txt: * platform/mac/fast/clip/nestedTransparencyClip-expected.txt: * platform/mac/fast/clip/outline-overflowClip-expected.txt: * platform/mac/fast/forms/input-appearance-preventDefault-expected.txt: * platform/mac/fast/invalid/014-expected.txt: * platform/mac/fast/layers/layer-visibility-expected.txt: * platform/mac/fast/repaint/layout-state-scrolloffset-expected.txt: * platform/mac/fast/repaint/layout-state-scrolloffset2-expected.txt: * platform/mac/fast/repaint/layout-state-scrolloffset3-expected.txt: * platform/mac/tables/mozilla/bugs/bug51140-expected.txt: 2011-03-25 Geoffrey Garen <ggaren@apple.com> Reviewed by Oliver Hunt. Crash when paused at a breakpoint caused by inaccurate Activation records. https://bugs.webkit.org/show_bug.cgi?id=57120 * runtime/JSActivation.cpp: (JSC::JSActivation::symbolTableGet): (JSC::JSActivation::symbolTablePut): (JSC::JSActivation::getOwnPropertyNames): (JSC::JSActivation::symbolTablePutWithAttributes): git-svn-id: svn://svn.chromium.org/blink/trunk@81994 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
bfulgham@webkit.org authored
Add stubs for WK2 cookie handling with cURL. * WebProcess/Cookies/curl: Added. * WebProcess/Cookies/curl/WebCookieManagerCurl.cpp: Added. (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): (WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy): * win/WebKit2.vcproj: git-svn-id: svn://svn.chromium.org/blink/trunk@81993 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
https://bugs.webkit.org/show_bug.cgi?id=56909hyatt@apple.com authored
Reviewed by Dan Bernstein. Add a simplified normal flow layout path optimization for overflow recomputation and for positioned objects inside relative positioned containers. Currently there is an optimized code path for positioned objects, but as soon as we encounter a normal flow object in the containing block chain, we lose the optimization. This patch adds a new type of style difference called SimplifiedLayout that is returned when only overflow needs to be recomputed. Whenever a transform changes, this is the hint returned now instead of a full layout. In addition, when positioned objects need layout and start marking up the containing block chain, we now propagate the fact that the layout is simplified all the way up to the root, even when we encounter normal flow containing blocks. The layoutOnlyPositionedObjects function has been renamed to simplifiedLayout() and is now used for all of these cases (in addition to what it handled before). The simplified layout optimization (even in ToT) did not work correctly when static distances needed to be recomputed. In order to make static distance computations work with simplified layout, positioned objects now always compute their static offsets, even if they explicitly specify left/top. That way normal flow layout never has to re-run when the positioned object moves. This makes movement of a positioned object along a single non-auto axis much faster when the other axis is auto. Because this code kicked in more often for absolutely positioned objects whose original display was inline, I went ahead and fixed the trailing space issue with those objects. This causes a bunch of layout tests to progress. Added fast/block/positioning/static-inline-position-dynamic.html and trailing-space-test.html. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::adjustPositionedBlock): (WebCore::RenderBlock::simplifiedNormalFlowLayout): (WebCore::RenderBlock::simplifiedLayout): * rendering/RenderBlock.h: * rendering/RenderBlockLineLayout.cpp: (WebCore::setStaticPositions): (WebCore::RenderBlock::findNextLineBreak): * rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::positionLineBox): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::styleWillChange): * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox): * rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::adjustStyleDifference): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::styleDidChange): * rendering/RenderObject.h: (WebCore::RenderObject::needsLayout): (WebCore::RenderObject::needsPositionedMovementLayoutOnly): (WebCore::RenderObject::needsSimplifiedNormalFlowLayout): (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout): (WebCore::RenderObject::markContainingBlocksForLayout): * rendering/RenderTable.cpp: (WebCore::RenderTable::layout): * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): * rendering/style/RenderStyleConstants.h: * rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): LayoutTests: Add a simplified normal flow layout path optimization for overflow recomputation and for positioned objects inside relative positioned containers. Reviewed by Dan Bernstein. Currently there is an optimized code path for positioned objects, but as soon as we encounter a normal flow object in the containing block chain, we lose the optimization. This patch adds a new type of style difference called SimplifiedLayout that is returned when only overflow needs to be recomputed. Whenever a transform changes, this is the hint returned now instead of a full layout. In addition, when positioned objects need layout and start marking up the containing block chain, we now propagate the fact that the layout is simplified all the way up to the root, even when we encounter normal flow containing blocks. The layoutOnlyPositionedObjects function has been renamed to simplifiedLayout() and is now used for all of these cases (in addition to what it handled before). The simplified layout optimization (even in ToT) did not work correctly when static distances needed to be recomputed. In order to make static distance computations work with simplified layout, positioned objects now always compute their static offsets, even if they explicitly specify left/top. That way normal flow layout never has to re-run when the positioned object moves. This makes movement of a positioned object along a single non-auto axis much faster when the other axis is auto. Because this code kicked in more often for absolutely positioned objects whose original display was inline, I went ahead and fixed the trailing space issue with those objects. This causes a bunch of layout tests to progress. Added fast/block/positioning/static-inline-position-dynamic.html and trailing-space-test.html. * animations/dynamic-stylesheet-loading-expected.txt: * animations/keyframe-timing-functions-expected.txt: * fast/block/positioning/static-inline-position-dynamic.html: Added. * fast/block/positioning/trailing-space-test.html: Added. * fast/dynamic/ancestor-to-absolute-expected.txt: * fast/forms/input-appearance-elementFromPoint-expected.txt: * fast/forms/input-hit-test-border-expected.txt: * platform/mac/fast/block/positioning/002-expected.png: * platform/mac/fast/block/positioning/003-expected.png: * platform/mac/fast/block/positioning/004-expected.png: * platform/mac/fast/block/positioning/005-expected.png: * platform/mac/fast/block/positioning/006-expected.png: * platform/mac/fast/block/positioning/007-expected.png: * platform/mac/fast/block/positioning/008-expected.png: * platform/mac/fast/block/positioning/009-expected.png: * platform/mac/fast/block/positioning/010-expected.png: * platform/mac/fast/block/positioning/011-expected.png: * platform/mac/fast/block/positioning/012-expected.png: * platform/mac/fast/block/positioning/013-expected.png: * platform/mac/fast/block/positioning/014-expected.png: * platform/mac/fast/block/positioning/015-expected.png: * platform/mac/fast/block/positioning/016-expected.png: * platform/mac/fast/block/positioning/017-expected.png: * platform/mac/fast/block/positioning/018-expected.png: * platform/mac/fast/block/positioning/019-expected.png: * platform/mac/fast/block/positioning/020-expected.png: * platform/mac/fast/block/positioning/021-expected.png: * platform/mac/fast/block/positioning/022-expected.png: * platform/mac/fast/block/positioning/023-expected.png: * platform/mac/fast/block/positioning/024-expected.png: * platform/mac/fast/block/positioning/025-expected.png: * platform/mac/fast/block/positioning/026-expected.png: * platform/mac/fast/block/positioning/027-expected.png: * platform/mac/fast/block/positioning/028-expected.png: * platform/mac/fast/block/positioning/029-expected.png: * platform/mac/fast/block/positioning/030-expected.png: * platform/mac/fast/block/positioning/031-expected.png: * platform/mac/fast/block/positioning/032-expected.png: * platform/mac/fast/block/positioning/033-expected.png: * platform/mac/fast/block/positioning/034-expected.png: * platform/mac/fast/block/positioning/035-expected.png: * platform/mac/fast/block/positioning/036-expected.png: * platform/mac/fast/block/positioning/037-expected.png: * platform/mac/fast/block/positioning/038-expected.png: * platform/mac/fast/block/positioning/039-expected.png: * platform/mac/fast/block/positioning/040-expected.png: * platform/mac/fast/block/positioning/041-expected.png: * platform/mac/fast/block/positioning/042-expected.png: * platform/mac/fast/block/positioning/043-expected.png: * platform/mac/fast/block/positioning/044-expected.png: * platform/mac/fast/block/positioning/045-expected.png: * platform/mac/fast/block/positioning/046-expected.png: * platform/mac/fast/block/positioning/047-expected.checksum: * platform/mac/fast/block/positioning/047-expected.png: * platform/mac/fast/block/positioning/048-expected.png: * platform/mac/fast/block/positioning/049-expected.png: * platform/mac/fast/block/positioning/050-expected.png: * platform/mac/fast/block/positioning/056-expected.txt: * platform/mac/fast/block/positioning/061-expected.png: * platform/mac/fast/block/positioning/062-expected.png: * platform/mac/fast/block/positioning/auto/005-expected.txt: * platform/mac/fast/block/positioning/auto/006-expected.txt: * platform/mac/fast/block/positioning/auto/007-expected.png: * platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.txt: * platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.txt: * platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.checksum: * platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.png: * platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.txt: * platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.txt: * platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.checksum: * platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.png: * platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt: * platform/mac/fast/block/positioning/inline-block-relposition-expected.checksum: * platform/mac/fast/block/positioning/inline-block-relposition-expected.png: * platform/mac/fast/block/positioning/inline-block-relposition-expected.txt: * platform/mac/fast/block/positioning/move-with-auto-width-expected.png: * platform/mac/fast/block/positioning/negative-rel-position-expected.png: * platform/mac/fast/block/positioning/relative-overconstrained-expected.png: * platform/mac/fast/block/positioning/relative-overflow-block-expected.txt: * platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.checksum: Added. * platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.png: Added. * platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.txt: Added. * platform/mac/fast/block/positioning/trailing-space-test-expected.checksum: Added. * platform/mac/fast/block/positioning/trailing-space-test-expected.png: Added. * platform/mac/fast/block/positioning/trailing-space-test-expected.txt: Added. * platform/mac/fast/clip/001-expected.txt: * platform/mac/fast/clip/004-expected.txt: * platform/mac/fast/clip/006-expected.txt: * platform/mac/fast/clip/007-expected.txt: * platform/mac/fast/clip/008-expected.txt: * platform/mac/fast/clip/009-expected.txt: * platform/mac/fast/clip/010-expected.txt: * platform/mac/fast/clip/011-expected.txt: * platform/mac/fast/clip/012-expected.txt: * platform/mac/fast/clip/013-expected.txt: * platform/mac/fast/clip/014-expected.txt: * platform/mac/fast/clip/nestedTransparencyClip-expected.txt: * platform/mac/fast/clip/outline-overflowClip-expected.txt: * platform/mac/fast/forms/input-appearance-preventDefault-expected.txt: * platform/mac/fast/invalid/014-expected.txt: * platform/mac/fast/layers/layer-visibility-expected.txt: * platform/mac/fast/repaint/layout-state-scrolloffset-expected.txt: * platform/mac/fast/repaint/layout-state-scrolloffset2-expected.txt: * platform/mac/fast/repaint/layout-state-scrolloffset3-expected.txt: * platform/mac/tables/mozilla/bugs/bug51140-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81992 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
slewis@apple.com authored
FontPlatformData.h bits. Patch by Martin Robinson <mrobinson@igalia.com> on 2011-03-25 * platform/graphics/FontPlatformData.h: Include the proper old font headers. (WebCore::FontPlatformData::FontPlatformData): Eliminate GTK+ specific bits of this file which reference our obsolete font implementation. (WebCore::FontPlatformData::hash): Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@81991 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrobinson@webkit.org authored
Fix the GTK+ build until we can implement the new cross-platform FontPlatformData.h bits. * platform/graphics/FontPlatformData.h: Include the proper old font headers. (WebCore::FontPlatformData::FontPlatformData): Eliminate GTK+ specific bits of this file which reference our obsolete font implementation. (WebCore::FontPlatformData::hash): Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@81990 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
sfalken@apple.com authored
Reviewed by Brian Weinstein. Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll https://bugs.webkit.org/show_bug.cgi?id=57119 <rdar://problem/9054148> This plug-in from Microsoft links against xpcom.dll, which is a Firefox-specific DLL not available in WebKit. The plug-in is fairly widespread, since it was included in a Windows Update push at one point. * plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::isPluginBlacklisted): Blacklist npwpf.dll. 2011-03-25 Steve Falkenburg <sfalken@apple.com> Reviewed by Brian Weinstein. Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll https://bugs.webkit.org/show_bug.cgi?id=57119 <rdar://problem/9054148> This plug-in from Microsoft links against xpcom.dll, which is a Firefox-specific DLL not available in WebKit. The plug-in is fairly widespread, since it was included in a Windows Update push at one point. * UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::PluginInfoStore::shouldUsePlugin): Blacklist npwpf.dll. git-svn-id: svn://svn.chromium.org/blink/trunk@81989 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
tony@chromium.org authored
Try to fix the chromium mac build. We used the mac FontPlatformData on chromium mac. * WebCore.gyp/WebCore.gyp: * WebCore.gypi: * platform/graphics/FontPlatformData.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81988 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
jam@chromium.org authored
Reviewed by Dimitri Glazkov. [chromium] Add setters for various client interfaces, and add WebSpellCheckClient https://bugs.webkit.org/show_bug.cgi?id=57070 * public/WebSpellCheckClient.h: Added. (WebKit::WebSpellCheckClient::spellCheck): (WebKit::WebSpellCheckClient::requestCheckingOfText): (WebKit::WebSpellCheckClient::autoCorrectWord): (WebKit::WebSpellCheckClient::showSpellingUI): (WebKit::WebSpellCheckClient::isShowingSpellingUI): (WebKit::WebSpellCheckClient::updateSpellingUIWithMisspelledWord): (WebKit::WebSpellCheckClient::~WebSpellCheckClient): * public/WebView.h: * public/WebViewClient.h: * src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::checkSpellingOfString): (WebKit::EditorClientImpl::requestCheckingOfString): (WebKit::EditorClientImpl::getAutoCorrectSuggestionForMisspelledWord): (WebKit::EditorClientImpl::updateSpellingUIWithMisspelledWord): (WebKit::EditorClientImpl::showSpellingUI): (WebKit::EditorClientImpl::spellingUIIsShowing): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setWebDevToolsAgentClient): (WebKit::WebViewImpl::setWebAutoFillClient): (WebKit::WebViewImpl::setWebSpellCheckClient): (WebKit::WebViewImpl::WebViewImpl): * src/WebViewImpl.h: (WebKit::WebViewImpl::spellCheckClient): git-svn-id: svn://svn.chromium.org/blink/trunk@81987 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
ggaren@apple.com authored
Reviewed by Oliver Hunt. Crash in debugger beneath MarkStack::drain @ me.com, ibm.com https://bugs.webkit.org/show_bug.cgi?id=57080 <rdar://problem/8525907> * inspector/debugger/debugger-activation-crash-expected.txt: Added. * inspector/debugger/debugger-activation-crash.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@81986 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dglazkov@chromium.org authored
Skip the test added in r81970 on WebKit2, because its harness doesn't yet support printing hooks. * platform/mac-wk2/Skipped: Added printing/page-count-layout-overflow.html. git-svn-id: svn://svn.chromium.org/blink/trunk@81985 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
bfulgham@webkit.org authored
* win/tools/vsprops/common.vsprops: git-svn-id: svn://svn.chromium.org/blink/trunk@81984 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ggaren@apple.com authored
Reviewed by Oliver Hunt. Crash in debugger beneath MarkStack::drain @ me.com, ibm.com https://bugs.webkit.org/show_bug.cgi?id=57080 <rdar://problem/8525907> The crash was caused by changes in the executable after recompilation. The fix is for the activation to copy the data it needs instead of relying on the data in the executable. SunSpider and v8 report no change. * runtime/Arguments.h: (JSC::JSActivation::copyRegisters): Use our own data members instead of reading data out of the executable. * runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation): Initialize our data members. (JSC::JSActivation::markChildren): (JSC::JSActivation::symbolTableGet): (JSC::JSActivation::symbolTablePut): (JSC::JSActivation::getOwnPropertyNames): (JSC::JSActivation::symbolTablePutWithAttributes): (JSC::JSActivation::isDynamicScope): (JSC::JSActivation::argumentsGetter): Use our own data members instead of reading data out of the executable. * runtime/JSActivation.h: Added new data members to track data previously tracked by the executable. Since I've removed the executable pointer, on a 64bit system, I've only made activations bigger by an int. git-svn-id: svn://svn.chromium.org/blink/trunk@81983 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
tony@chromium.org authored
Build fix: have chromium and qt use the correct FontPlatformData.h https://bugs.webkit.org/show_bug.cgi?id=57115 * platform/graphics/FontPlatformData.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81982 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
https://bugs.webkit.org/show_bug.cgi?id=57057bdakin@apple.com authored
areas paint behind positive z-index content -and corresponding- <rdar://problem/9070500> Reviewed by Dave Hyatt. Since overlay scrollbars don't clip the scrollable content like other scrollbars do, the only way to get them to paint on top of all possible scrollable content is to make them paint on top of everything. To do this, this patch adds a second trip through the layer tree if it contains overlay scrollbars that need painting. After calling paint() on the rootLayer, call paintOverlayScrollers() if containsDirtyOverlayScrollbars() is true. * page/FrameView.cpp: (WebCore::FrameView::paintContents): RenderLayer has two new member variable. m_containsDirtyOverlayScrollbars is a bool that is set on the root layer when it has child layers that need overlay scrollbars to be painted. m_cachedOverlayScrollbarOffset is an IntPoint to cache the tx and ty of the overlay scrollbars on the first (normal) pass through the layer tree. This prevents us from having to re-enter the render tree during the second (overlay-only) pass. Finally, there is also a new paint flag: PaintLayerPaintingOverlayScrollbars. * rendering/RenderLayer.h: (WebCore::RenderLayer::containsDirtyOverlayScrollbars): (WebCore::RenderLayer::setContainsDirtyOverlayScrollbars): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintOverlayScrollbars): (WebCore::RenderLayer::paintLayer): git-svn-id: svn://svn.chromium.org/blink/trunk@81981 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jberlin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=50780 Reviewed by Sam Weinig. Source/WebCore: * platform/network/cf/CookieStorageCFNet.cpp: (WebCore::privateCookieStorage): Rename privateBrowsingCookieStorage to privateCookieStorage. (WebCore::currentCookieStorage): Ditto. (WebCore::setCurrentCookieStorage): Ditto. (WebCore::setCookieStoragePrivateBrowsingEnabled): Ditto. (WebCore::defaultCookieStorage): Return the default cookie storage. (WebCore::privateBrowsingCookieStorage): Return privateCookieStorage().get() * platform/network/cf/CookieStorageCFNet.h: Source/WebKit2: * Shared/HTTPCookieAcceptPolicy.h: Added. * UIProcess/API/C/WKAPICast.h: (WebKit::toHTTPCookieAcceptPolicy): (WebKit::toAPI): * UIProcess/API/C/WKCookieManager.cpp: (WKCookieManagerSetHTTPCookieAcceptPolicy): Call through to WebCookieManagerProxy. (WKCookieManagerGetHTTPCookieAcceptPolicy): Ditto. * UIProcess/API/C/WKCookieManager.h: * UIProcess/WebCookieManagerProxy.cpp: (WebKit::WebCookieManagerProxy::invalidate): Invalidate the get http cookie accept policy callbacks. (WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy): Send a message to the Web Process with the new value. (WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy): Keep track of the callback and send a message to the Web Process. (WebKit::WebCookieManagerProxy::didGetHTTPCookieAcceptPolicy): Invoke the callback. * UIProcess/mac/WebCookieManagerProxyMac.mm: Added. (WebKit::WebCookieManagerProxy::persistHTTPCookieAcceptPolicy): On Mac, also set the policy in the UI Process because the sandboxed Web Process cannot persist the policy. * UIProcess/WebCookieManagerProxy.h: * UIProcess/WebCookieManagerProxy.messages.in: * WebKit2.pri: * WebKit2.pro: * WebKit2.xcodeproj/project.pbxproj: * win/WebKit2.vcproj: * win/WebKit2Common.vsprops: * WebProcess/Cookies/WebCookieManager.cpp: (WebKit::WebCookieManager::setHTTPCookieAcceptPolicy): Call platformSetHTTPCookieAcceptPolicy. (WebKit::WebCookieManager::getHTTPCookieAcceptPolicy): Send the result of platformGetHTTPCookieAcceptPolicy to the UI Process. * WebProcess/Cookies/WebCookieManager.h: * WebProcess/Cookies/WebCookieManager.messages.in: * WebProcess/Cookies/cf: Added. * WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp: Added. (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): Set the policy on both the default cookie storage and any Private Browsing cookie storage. (WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy): * WebProcess/Cookies/mac: Added. * WebProcess/Cookies/mac/WebCookieManagerMac.mm: Added. (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): Set the policy on the default cookie storage and add a FIXME to set it on any Private Browsing cookie storage. (WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy): * WebProcess/Cookies/gtk: Added. * WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp: Added. (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): (WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy): * WebProcess/Cookies/qt: Added. * WebProcess/Cookies/qt/WebCookieManagerQt.cpp: Added. (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): (WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy): Tools: Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2. The test is named "CookieManager" so that we can eventually exercise more of the CookieManager functionality in the test. * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added. (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy): Assert that the policy returned is equal to the policy set in didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy. (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy): Set the policy to something different than the user's policy and get the policy again. (TestWebKitAPI::didFinishLoadForFrame): Get the user's policy so that it can be restored at the end of the test. (TestWebKitAPI::TEST): Load about:blank so that the Web Process gets instatiated (needed to get the CookieManager). * TestWebKitAPI/win/TestWebKitAPI.vcproj: Add CookieManager.cpp. git-svn-id: svn://svn.chromium.org/blink/trunk@81980 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Dimitri Glazkov. Add CGBitmapContext.h include to WebViewImpl.cpp https://bugs.webkit.org/show_bug.cgi?id=57097 No tests. Exposes no new functionality. * src/WebViewImpl.cpp: git-svn-id: svn://svn.chromium.org/blink/trunk@81979 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
eae@chromium.org authored
Reviewed by Dimitri Glazkov. Text field "onchange" event is triggered if actual value unchanged https://bugs.webkit.org/show_bug.cgi?id=36314 Add tests for text field change events. * fast/events/onchange-text-form-field-expected.txt: Added. * fast/events/onchange-text-form-field.html: Added. 2011-03-25 Emil A Eklund <eae@chromium.org> Reviewed by Dimitri Glazkov. Text field "onchange" event is triggered if actual value unchanged https://bugs.webkit.org/show_bug.cgi?id=36314 Change RenderTextControl::subtreeHasChanged to only return true if the subtree has changed since the last event was triggered. * html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::insertedIntoDocument): (WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent): * html/HTMLFormControlElement.h: (WebCore::HTMLTextFormControlElement::setTextAsOfLastFormControlChangeEvent): * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::setValue): * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): (WebCore::HTMLTextAreaElement::setNonDirtyValue): git-svn-id: svn://svn.chromium.org/blink/trunk@81978 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
bfulgham@webkit.org authored
is used across all ports. This first patch works for the Windows build (both CG and WinCairo), and Cocoa. Reviewed by David Hyatt. * WebCore.vcproj/WebCore.vcproj: * platform/graphics/FontPlatformData.cpp: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): * platform/graphics/FontPlatformData.h: Added. (WebCore::toCTFontRef): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hfont): (WebCore::FontPlatformData::useGDI): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::cgFont): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::isColorBitmapFont): (WebCore::FontPlatformData::orientation): (WebCore::FontPlatformData::textOrientation): (WebCore::FontPlatformData::widthVariant): (WebCore::FontPlatformData::setOrientation): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::fontFace): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::hashTableDeletedFontValue): * platform/graphics/cg/FontPlatformData.h: Removed. * platform/graphics/cocoa/FontPlatformData.h: Removed. * platform/graphics/cocoa/FontPlatformDataCocoa.mm: (WebCore::~FontPlatformData): (WebCore::FontPlatformData::platformDataInit): (WebCore::FontPlatformData::platformDataAssign): * platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::platformDataInit): (WebCore::FontPlatformData::platformDataAssign): * platform/graphics/win/FontPlatformDataCairoWin.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::platformDataInit): (WebCore::FontPlatformData::platformDataAssign): * platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): * platform/graphics/win/cairo/FontPlatformData.h: Removed. git-svn-id: svn://svn.chromium.org/blink/trunk@81977 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jberlin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=55579 Unreviewed, skipping all the websocket tests on Windows to get the bots green. * platform/win/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@81976 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
bweinstein@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=57109 <rdar://problem/9184590> Reviewed by Alexey Proskuryakov. Check for a trailing Windows path separator, not a Unix path separator. * UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformInitializeWebProcess): git-svn-id: svn://svn.chromium.org/blink/trunk@81975 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enrica@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=57107 <rdar://problem/9084267> Reviewed by Oliver Hunt. If the selection is at the beginning of content inside an anchor tag we move the selection start to include the anchor. * platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): Modified to change the selection start according to the new rule. git-svn-id: svn://svn.chromium.org/blink/trunk@81974 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by David Levin. [chromium] Remove deprecated overload of openFileSystem for workers https://bugs.webkit.org/show_bug.cgi?id=57062 * public/WebCommonWorkerClient.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81972 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: refactor Network domain's frame tree API https://bugs.webkit.org/show_bug.cgi?id=57103 * inspector/Inspector.json: * inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForFrameResource): (WebCore::buildObjectForCachedResource): (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): (WebCore::buildObjectForFrame): (WebCore::buildObjectForFrameTree): (WebCore::InspectorResourceAgent::didCommitLoad): (WebCore::InspectorResourceAgent::enable): * inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.requestContent): (WebInspector.NetworkDispatcher): (WebInspector.NetworkDispatcher.prototype.willSendRequest): (WebInspector.NetworkDispatcher.prototype.didReceiveResponse): (WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkDispatcher.prototype.frameDetachedFromParent): (WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame): (WebInspector.NetworkDispatcher.prototype.didCreateWebSocket): (WebInspector.NetworkDispatcher.prototype._appendRedirect): (WebInspector.NetworkDispatcher.prototype._addFramesRecursively): (WebInspector.NetworkDispatcher.prototype._createResource): * inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.ResourceTreeModel.prototype._clearResources): * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.addOrUpdateFrame): (WebInspector.ResourcesPanel.prototype.addResourceToFrame): git-svn-id: svn://svn.chromium.org/blink/trunk@81971 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dglazkov@chromium.org authored
Reviewed by Adele Peterson. REGRESSION(r77257): Only first page of a document is printed https://bugs.webkit.org/show_bug.cgi?id=56958 * printing/page-count-layout-overflow-expected.txt: Added. * printing/page-count-layout-overflow.html: Added. 2011-03-25 Dave Hyatt <hyatt@apple.com> Reviewed by Adele Peterson. REGRESSION(r77257): Only first page of a document is printed https://bugs.webkit.org/show_bug.cgi?id=56958 Test: printing/page-count-layout-overflow.html * page/FrameView.cpp: (WebCore::FrameView::forceLayoutForPagination): Moved clearing of overflow to the right place. git-svn-id: svn://svn.chromium.org/blink/trunk@81970 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
ddkilzer@apple.com authored
JSC::createStackOverflowError(JSC::ExecState*) was originally exported in r60057, then duplicated in r60392. * JavaScriptCore.exp: Removed duplicate entry. git-svn-id: svn://svn.chromium.org/blink/trunk@81969 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
benjamin.poulain@nokia.com authored
https://bugs.webkit.org/show_bug.cgi?id=57087 Reviewed by Andreas Kling. Use explicit conversion for string to avoid depending on the default codec installed by the user code. * Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::create): * Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp: (WebKit::initializeGTK): * UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp: (tst_QGraphicsWKView::loadEmptyPage): (tst_QGraphicsWKView::loadEmptyUrl): * UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp: (tst_QWKPage::loadEmptyUrl): * UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::ProcessLauncher::launchProcess): * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::getPluginDisplay): * WebProcess/qt/WebProcessMainQt.cpp: (WebKit::EnvHttpProxyFactory::initializeFromEnvironment): (WebKit::WebProcessMainQt): git-svn-id: svn://svn.chromium.org/blink/trunk@81968 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
benjamin.poulain@nokia.com authored
https://bugs.webkit.org/show_bug.cgi?id=57087 Reviewed by Andreas Kling. Use explicit conversion for string to avoid depending on the default codec installed by the user code. * bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapToDataUrlMethod::invoke): (JSC::Bindings::QtPixmapInstance::valueOf): * platform/qt/LanguageQt.cpp: (WebCore::platformDefaultLanguage): * platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeSelection): * plugins/qt/PluginPackageQt.cpp: (WebCore::initializeGtk): * plugins/qt/PluginViewQt.cpp: (WebCore::getPluginDisplay): git-svn-id: svn://svn.chromium.org/blink/trunk@81967 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
bfulgham@webkit.org authored
after r81924. * win/WebKit2.vcproj: Restore lost $(WebKitVSPropsRedirectionDir) git-svn-id: svn://svn.chromium.org/blink/trunk@81966 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Ryosuke Niwa. rename Node::isContentEditable and all call sites to rendererIsEditable https://bugs.webkit.org/show_bug.cgi?id=54290 This is part of the effort to separate JS API HTMLElement isContentEditable from internal Node::rendererIsEditable. Code refactoring. No new tests. * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isReadOnly): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): * dom/Document.cpp: (WebCore::acceptsEditingFocus): * dom/Node.cpp: (WebCore::Node::rendererIsEditable): (WebCore::Node::shouldUseInputMethod): (WebCore::Node::canStartSelection): (WebCore::Node::rootEditableElement): * dom/Node.h: (WebCore::Node::isContentEditable): (WebCore::Node::rendererIsEditable): (WebCore::Node::rendererIsRichlyEditable): * dom/Position.cpp: (WebCore::nextRenderedEditable): (WebCore::previousRenderedEditable): (WebCore::Position::atEditingBoundary): (WebCore::Position::parentEditingBoundary): (WebCore::Position::upstream): (WebCore::Position::downstream): (WebCore::Position::isCandidate): * dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate): * editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::AppendNodeCommand): (WebCore::AppendNodeCommand::doApply): (WebCore::AppendNodeCommand::doUnapply): * editing/ApplyStyleCommand.cpp: (WebCore::containsNonEditableRegion): (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): * editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): (WebCore::enclosingDeletableElement): * editing/DeleteFromTextNodeCommand.cpp: (WebCore::DeleteFromTextNodeCommand::doApply): (WebCore::DeleteFromTextNodeCommand::doUnapply): * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode): * editing/Editor.cpp: (WebCore::Editor::canDeleteRange): (WebCore::Editor::markMisspellingsOrBadGrammar): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): * editing/EditorCommand.cpp: (WebCore::verticalScrollDistance): * editing/FormatBlockCommand.cpp: (WebCore::enclosingBlockToSplitTreeTo): * editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph): * editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::doApply): (WebCore::InsertIntoTextNodeCommand::doUnapply): * editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): (WebCore::InsertNodeBeforeCommand::doApply): (WebCore::InsertNodeBeforeCommand::doUnapply): * editing/JoinTextNodesCommand.cpp: (WebCore::JoinTextNodesCommand::doApply): (WebCore::JoinTextNodesCommand::doUnapply): * editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::doApply): (WebCore::MergeIdenticalElementsCommand::doUnapply): * editing/RemoveNodeCommand.cpp: (WebCore::RemoveNodeCommand::doApply): (WebCore::RemoveNodeCommand::doUnapply): * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): * editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::setSelectionFromNone): * editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::executeApply): (WebCore::SplitElementCommand::doUnapply): * editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::doApply): (WebCore::SplitTextNodeCommand::doUnapply): (WebCore::SplitTextNodeCommand::doReapply): * editing/SplitTextNodeContainingElementCommand.cpp: (WebCore::SplitTextNodeContainingElementCommand::doApply): * editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition): * editing/WrapContentsInDummySpanCommand.cpp: (WebCore::WrapContentsInDummySpanCommand::doUnapply): (WebCore::WrapContentsInDummySpanCommand::doReapply): * editing/htmlediting.cpp: (WebCore::highestEditableRoot): (WebCore::lowestEditableAncestor): (WebCore::isEditablePosition): (WebCore::isRichlyEditablePosition): (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::extendRangeToWrappingNodes): (WebCore::enclosingNodeWithTag): (WebCore::enclosingNodeOfType): (WebCore::highestEnclosingNodeOfType): (WebCore::canMergeLists): * editing/visible_units.cpp: (WebCore::previousLeafWithSameEditability): (WebCore::previousLinePosition): (WebCore::nextLeafWithSameEditability): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::supportsFocus): (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive): (WebCore::HTMLAnchorElement::canStartSelection): (WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType): * html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::supportsFocus): * html/HTMLElement.cpp: (WebCore::HTMLElement::supportsFocus): (WebCore::HTMLElement::isContentEditable): (WebCore::HTMLElement::contentEditable): * html/HTMLElement.h: * page/DragController.cpp: (WebCore::DragController::operationForLoad): (WebCore::DragController::canProcessDrag): * page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::selectCursor): * page/FocusController.cpp: (WebCore::relinquishesEditingFocus): * rendering/HitTestResult.cpp: (WebCore::HitTestResult::isContentEditable): * rendering/RenderBlock.cpp: (WebCore::positionForPointRespectingEditingBoundaries): (WebCore::RenderBlock::hasLineIfEmpty): * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::addOverflowFromInlineChildren): * rendering/RenderBox.cpp: (WebCore::RenderBox::canBeProgramaticallyScrolled): * rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition): * rendering/RootInlineBox.cpp: (WebCore::isEditableLeaf): * svg/SVGAElement.cpp: (WebCore::SVGAElement::supportsFocus): 2011-03-25 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. rename Node::isContentEditable and all call sites to rendererIsEditable https://bugs.webkit.org/show_bug.cgi?id=54290 This is part of the effort to separate JS API HTMLElement isContentEditable from internal Node::rendererIsEditable. * src/WebNode.cpp: (WebKit::WebNode::isContentEditable): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::setComposition): (WebKit::WebViewImpl::confirmComposition): 2011-03-25 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. rename Node::isContentEditable and all call sites to rendererIsEditable https://bugs.webkit.org/show_bug.cgi?id=54290 This is part of the effort to separate JS API HTMLElement isContentEditable from internal Node::rendererIsEditable. * WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent): 2011-03-25 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. rename Node::isContentEditable and all call sites to rendererIsEditable https://bugs.webkit.org/show_bug.cgi?id=54290 This is part of the effort to separate JS API HTMLElement isContentEditable from internal Node::rendererIsEditable. * WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent): git-svn-id: svn://svn.chromium.org/blink/trunk@81965 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
mjs@apple.com authored
Reviewed by Antti Koivisto. Crash when a wbr element is inserted inside mroot https://bugs.webkit.org/show_bug.cgi?id=56352 * mathml/wbr-in-mroot-crash-expected.txt: Added. * mathml/wbr-in-mroot-crash.html: Added. 2011-03-25 Maciej Stachowiak <mjs@apple.com> Reviewed by Antti Koivisto. Crash when a wbr element is inserted inside mroot https://bugs.webkit.org/show_bug.cgi?id=56352 Test: mathml/wbr-in-mroot-crash.html * rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::layout): Look for the first box model child of the first child, instead of just assuming. git-svn-id: svn://svn.chromium.org/blink/trunk@81964 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
benjamin.poulain@nokia.com authored
https://bugs.webkit.org/show_bug.cgi?id=56098 Patch by Jarred Nicholls <jarred@sencha.com> on 2011-03-25 Reviewed by Ariya Hidayat. Need to link advapi32.lib for jsc.exe since wtf/OSRandomSource.cpp uses the Win32 Crypto API * jsc.pro: git-svn-id: svn://svn.chromium.org/blink/trunk@81963 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Pavel Feldman. XML Viewer: extensions can't render original XML https://bugs.webkit.org/show_bug.cgi?id=56263 Added source xml to transformed document, renamed onload function. * fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt: * fast/encoding/dumpAsText/utf-16-no-bom-expected.txt: * http/tests/xmlviewer/dumpAsText/wml-expected.txt: * http/tests/xmlviewer/dumpAsText/xlink-expected.txt: * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251-expected.txt: * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8-expected.txt: * http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt: * http/tests/xmlviewer/dumpAsText/xul-expected.txt: * platform/chromium-linux/http/tests/xmlviewer/dumpAsText/wml-expected.txt: * platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt: * svg/hixie/error/dumpAsText/004-expected.txt: * svg/hixie/error/dumpAsText/005-expected.txt: * xmlviewer/extensions-api-expected.txt: Added. * xmlviewer/extensions-api.html_disabled: Added. * xmlviewer/resources/sample.xml: Added. 2011-03-25 Vsevolod Vlasov <vsevik@chromium.org> Reviewed by Pavel Feldman. XML Viewer: extensions can't render original XML https://bugs.webkit.org/show_bug.cgi?id=56263 Added source xml to transformed document, renamed onload function. * xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView): * xml/XMLViewer.xsl: git-svn-id: svn://svn.chromium.org/blink/trunk@81962 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
benjamin.poulain@nokia.com authored
Reviewed by Andreas Kling. [Qt] Get rid of the invalid string conversion with ::fromAscii() https://bugs.webkit.org/show_bug.cgi?id=57102 Replace ::fromAscii() with ::fromLatin1() to make sure the codec does not depend on the user code. * platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): * platform/qt/CookieJarQt.cpp: (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): git-svn-id: svn://svn.chromium.org/blink/trunk@81961 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Dirk Schulze. SVG <use> element performance improvement https://bugs.webkit.org/show_bug.cgi?id=57077 Add a manual test case which is from http://upload.wikimedia.org/wikipedia/commons/4/4e/Sierpinski_carpet_6.svg for svg <use> element performance test. * PageLoad/svg/files/Sierpinski_carpet_6.svg: Added. * PageLoad/svg/svg.pltsuite: git-svn-id: svn://svn.chromium.org/blink/trunk@81960 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Andreas Kling. [Qt] The keyboard shortcuts during fullscreen playback do not work. https://bugs.webkit.org/show_bug.cgi?id=57095 We need to explicitely set the focus on the widget in order to receive the keyboard events. * WebCoreSupport/FullScreenVideoWidget.cpp: (WebCore::FullScreenVideoWidget::show): git-svn-id: svn://svn.chromium.org/blink/trunk@81959 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
aroben@apple.com authored
r81925 made Windows match Mac on this test. New Windows results were checked in, but they were generated using the wrong fonts. Since we match Mac now, we don't need Windows-specific results at all. * platform/win/fast/css/percentage-non-integer-expected.checksum: Removed. * platform/win/fast/css/percentage-non-integer-expected.png: Removed. * platform/win/fast/css/percentage-non-integer-expected.txt: Removed. git-svn-id: svn://svn.chromium.org/blink/trunk@81958 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Unreviewed, rolling out r81953. http://trac.webkit.org/changeset/81953 https://bugs.webkit.org/show_bug.cgi?id=57096 "inspector test breakage: part 2/2" (Requested by apavlov on #webkit). * inspector/styles/get-set-stylesheet-text-expected.txt: Removed. * inspector/styles/get-set-stylesheet-text.html: Removed. * inspector/styles/styles-new-API.html: 2011-03-25 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r81953. http://trac.webkit.org/changeset/81953 https://bugs.webkit.org/show_bug.cgi?id=57096 "inspector test breakage: part 2/2" (Requested by apavlov on #webkit). * inspector/Inspector.json: * inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getAllStyles): * inspector/InspectorCSSAgent.h: * inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::buildObjectForStyleSheet): * inspector/InspectorStyleSheet.h: * inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun): * inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleSheet): (WebInspector.CSSStyleSheet.prototype.setText): git-svn-id: svn://svn.chromium.org/blink/trunk@81957 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Unreviewed, rolling out r81954. http://trac.webkit.org/changeset/81954 https://bugs.webkit.org/show_bug.cgi?id=57094 "inspector test breakage: part 1/2" (Requested by apavlov on #webkit). * inspector/styles/resources/get-set-stylesheet-text.css: Removed. git-svn-id: svn://svn.chromium.org/blink/trunk@81956 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
mnaganov@chromium.org authored
Roll forward Chromium deps to r79379 to pick up V8 3.2.4.2. * DEPS: git-svn-id: svn://svn.chromium.org/blink/trunk@81955 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
apavlov@chromium.org authored
Unreviewed, build fix. Add file missing from r81953 * inspector/styles/resources/get-set-stylesheet-text.css: Added. (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2): git-svn-id: svn://svn.chromium.org/blink/trunk@81954 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
