- 31 Jul, 2018 40 commits
-
-
Gabriel Marin authored
The Linux config file was generated by autoconf and manually edited to define PC_FROM_UCONTEXT for ARM, change size_t printf format specifiers to zd instead of ld, and add a GCC compiler guard around the HAVE_BUILTIN_EXPECT macro definition. The file is being committed into the repository for the purpose of cross-platform compilation. The Windows config file was copied from an older version of tcmalloc and must be manually inspected before being used with the new tcmalloc version. The Android and FreeBSD config files are just stubs and must be generated by autoconf on those respective platforms before they can be used. Added windows/mingw.h and windows/port.h to the list of allowed include rules of the DEPS file in the top tcmalloc dir. BUG=724399,b:70905156 Change-Id: Ib18197d03824d0e9cca8c1002cedb25363dc8b03 Reviewed-on: https://chromium-review.googlesource.com/1130673 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#579602}
-
Peter Kvitek authored
Change-Id: Iec45bb977b603eef79ac91f4cb243c4e13d7e103 Reviewed-on: https://chromium-review.googlesource.com/1157247Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579601}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e782f8472f61..f107a2fd014c git log e782f8472f61..f107a2fd014c --date=short --no-merges --format='%ad %ae %s' 2018-07-31 halcanary@google.com SkUTF 2018-07-31 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms f80f027f8ac9..dc97dc542b6d (1 commits) Created with: gclient setdep -r src/third_party/skia@f107a2fd014c The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: If2d30238685c0f690e84be76bce2e28a3545dfc1 Reviewed-on: https://chromium-review.googlesource.com/1156915Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579600}
-
Carlos Knippschild authored
Expose to Java Offline Prefetch flag and configurations to allow the upcoming work on Android UI and settings to access them. Bug: 850588 Change-Id: I697e944b57ebae57df73def9bffc8059b13eaa5d Reviewed-on: https://chromium-review.googlesource.com/1154144Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#579599}
-
Siddhartha authored
The CFI unwinder only works for chrome stack frames. Write a hybrid unwinder which can use libunwind for android and CFI unwinder for chrome. Does not support unwinding in x86 and arm 64bit builds. It supports pausing a different thread and unwinding frames on that thread. This will be useful for UMA sampling profiler and tracing profiler. BUG=859260 Change-Id: I208b9b21c8f6a73a4d593f1446095da92c0cb848 Reviewed-on: https://chromium-review.googlesource.com/1132144 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#579598}
-
Scott Violet authored
AccessibilityManager is always created, so the mash conditional is not needed. BUG=none TEST=none Change-Id: Iab76b0e63a89ec5fa296ba308e5d3b52d3288dcb Reviewed-on: https://chromium-review.googlesource.com/1157223Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#579597}
-
Lukasz Anforowicz authored
Bug: 869193 Change-Id: I911ec71a13c432a0111bdd8ec9da0f5ab679d082 Reviewed-on: https://chromium-review.googlesource.com/1155828 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#579596}
-
Scott Violet authored
AccessibilityManager is always created, so the mash conditional is not needed. The conditional dates back to early on in mash when the AccessibilityManager was not created. BUG=none TEST=none Change-Id: I3a8945aa8659703d8a2edec03a1a46ec3513505a Reviewed-on: https://chromium-review.googlesource.com/1157214Reviewed-by:
-
Lu Chen authored
Add recording of AnchorElementMetrics.Visible.HrefEngagementScore2. Bug: 850624 Change-Id: I5291067e2b9f1edfb8dd4e23fca3df802a153228 Reviewed-on: https://chromium-review.googlesource.com/1156000 Commit-Queue: Lu Chen <chelu@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#579594}
-
Michael Spang authored
Since HardwareDisplayControllers are never moved between DRM devices, it's much simpler to manage the cursor buffers there - we never need to reallocate them due to a device change. This will also allow us to remove the refcounting. Bug: 868010 Change-Id: Ie7e3615b4c653ea6250a4a4a45510c84badabe9c Reviewed-on: https://chromium-review.googlesource.com/1155915 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#579593}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2eb65034db71..8c1508bc0b4f git log 2eb65034db71..8c1508bc0b4f --date=short --no-merges --format='%ad %ae %s' 2018-07-31 courtneygo@google.com Update name of ANGLE Android apk to match expectations 2018-07-31 jmadill@chromium.org Context: Cache attributes masks. 2018-07-31 ianelliott@google.com Add Android-specific version struct to GetSystemInfo results. 2018-07-31 oetuaho@nvidia.com Allow reads from a multiview framebuffer with one view Created with: gclient setdep -r src/third_party/angle@8c1508bc0b4f The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ieb9485799b5e0b84bbce7222ad97560ac44c696b Reviewed-on: https://chromium-review.googlesource.com/1156908Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579592}
-
Sam Maier authored
Currently, the AsyncTask that creates the SecureRandom is on the SERIAL_EXECUTOR - this is causing a lot of ANRs. Since it doesn't appear to require any synchronus guarantees with anything else in the SERIAL_EXECUTOR, we can move this to the THREAD_POOL_EXECUTOR. This means when we block on SecureRandom creation using get(), we don't have to wait on all tasks currently in the SERIAL_EXECUTOR finishing. Bug: 866998 Change-Id: I771724a184bf501b2da55f7d42a93b3943e7a058 Reviewed-on: https://chromium-review.googlesource.com/1157211Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#579591}
-
Malay Keshav authored
This patch adjusts the shelf width such that in pixel space there is no gap left between the shelf and the edge of the display. The adjustment is done via a utility method which can be used to adjust any bounds to ensure that they cover the edge of the display or screen. Bug: 843354 Change-Id: Ica9adfe6e21e7ae71ef8206e20507a372317c105 Component: Screen util, shelf Reviewed-on: https://chromium-review.googlesource.com/1154040 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#579590}
-
Reid Kleckner authored
In this expression, the reference would be bound to the member of a temporary object returned from GetContainerBounds(): const gfx::Size& view_size = shell()->web_contents()->GetContainerBounds().size(); Clang has become smarter about the lifetimes of temporary objects like these, so ASan now reports this as a use-afer-scope. The fix is to copy the small gfx::Size object. TBR=sergeyu@chromium.org Bug: 869067 Change-Id: Ie15d45d8698d7024c8755980725fdedaa0ccaaad Reviewed-on: https://chromium-review.googlesource.com/1157274 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#579589}
-
xlou authored
When sending URLs to the PDF plugin, the page index in the URL needs to be the page index for the displayed PDF document. When N-up > 1, this will not match the page index from the selected pages in the UI, since the N-up page numbers will be recalculated using the number of pages selected and pagesPerSheet Value. The new number of pages will be ceil(#pages selected/pagesPerSheet), and the index of the N-up pages will start from 0. Hence changing the function onPagePreviewReady_ to use the N-upped document index when pagesPerSheet > 1. In printing, 2-up, 3-up, or more generally N-up refers to a page layout strategy in which multiple pages are composited onto a single page. Bug: 775999 Change-Id: I1488431713815b573eb2798e23b011417b9fa46d Reviewed-on: https://chromium-review.googlesource.com/1155906 Commit-Queue: Shirleen Lou <xlou@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#579588}
-
Eric Orth authored
Generally just applies the mapping to the input HostPortPair and passes on to the wrapped implementation. Some special handling for when the input is mapped to an error. Bug: 821021 Change-Id: I0d108976e363993ebb36b8081948ef410894fa47 Reviewed-on: https://chromium-review.googlesource.com/1156856Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#579587}
-
Michael Spang authored
Prepare for removing mock framebuffers by moving the class into MockDrmFramebufferGenerator. We don't need a mock framebuffer type. Bug: 869206 Change-Id: I8a909d385f455fde0776e3cf5ad8d24791753e23 Reviewed-on: https://chromium-review.googlesource.com/1155913 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8b8cc1cc..15016c7f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id4c0b59e6a43ce82a7bdcf6374ba3d4ed9dc8f4d Reviewed-on: https://chromium-review.googlesource.com/1157130Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579585}
-
Fabrice de Gans-Riberi authored
This reverts commit de31a634. Reason for revert: This has made the Mac10.12 Tests content_unittests fail on the following tests: WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationLess180 WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationGreater360 WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationLess90 WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationLess360 WebInputEventBuilderMacTest.BuildWebTouchEvents See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14711 Original change's description: > Make pen inputs behave like touch inputs on MacOS > > Currently on MacOS the pen behaves like a mouse input, because we > generate mouse events for the pen input. We agreed that the pen input > should behave like a touch input, so we now send touch events instead. > > Bug: 854354 > Change-Id: Iac7910e250020a8125a57fb6055fb282db3faf0e > Reviewed-on: https://chromium-review.googlesource.com/1136721 > Commit-Queue: Lan Wei <lanwei@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579482} TBR=meacer@chromium.org,tdresser@chromium.org,lanwei@chromium.org,nzolghadr@chromium.org Change-Id: I51b85daec63d39ef9aebb9dd727def7dfd7ca432 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854354 Reviewed-on: https://chromium-review.googlesource.com/1157304Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#579584}
-
Ben Pastene authored
They were accidentally re added in https://chromium-review.googlesource.com/c/chromium/src/+/1145768 Bug: 869456 Change-Id: Ifb991ccc82980e2f51d38ad29ae1b3b7f206d5ad Reviewed-on: https://chromium-review.googlesource.com/1157188Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#579583}
-
Lu Chen authored
Finch is used to control the scales of each feature when calculating navigation scores. This CL is blocked on 1132680. Bug: 850624 Change-Id: I422f1e7f9f9db17530694d7445ab1233976f5930 Reviewed-on: https://chromium-review.googlesource.com/1152037 Commit-Queue: Lu Chen <chelu@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Mao Huang authored
dump. Original CLs: - http://codereview.chromium.org/6532051 Fix heap profiler to always append the process id to the heap dump. To run Chrome: HEAP_PROFILE_ALLOCATION_INTERVAL=1000000 HEAPPROFILE=heapprof out/Debug/chrome To analyze: pprof --text out/Debug/chrome heapprof.21026.0039.heap pprof --gv out/Debug/chrome heapprof.21026.0039.heap (pprof is slooow) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86273 - https://codereview.chromium.org/8957007 Change the heap file names to be Cleanup'ed in third_party/tcmalloc/chromium. In spite of Chromium's changing heap file names dumped in heap-profiler.cc:DumpProfileLocked(), the file names cleaned-up in heap-profile-table.cc:HeapProfileTable::CleanupOldProfiles are not modified. (See the difference between third_party/tcmalloc/chromium/src/heap-profiler.cc and .../vendor/src/heap-profiler.cc) This patch is originally from http://codereview.chromium.org/7865021/. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114777 BUG=724399,b:70905156 Change-Id: Iab590a6a34f3e3922b0958460169e517accef7df Reviewed-on: https://chromium-review.googlesource.com/1130782 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
-
Hector Carmona authored
Bug: 832938 Change-Id: Ie3cec973be983a74aff44a3e77e99a3789044fec Reviewed-on: https://chromium-review.googlesource.com/1145596 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#579580}
-
Reid Kleckner authored
The temporary base::Optional<PersistentWindowInfo> object is destroyed at the end of the full expression in this statement: const auto& persistent_window_info = *window_state->persistent_window_info(); Avoid the lifetime issue by making a copy of the small struct. This bug was found by ASan after a clang change to more accurately track the lifetime of temporaries like these. TBR=afakhry@chromium.org Bug: 869067 Change-Id: Ibb4cd6761ec29fc09cd42c75b8d7bb13844f5352 Reviewed-on: https://chromium-review.googlesource.com/1157256Reviewed-by: -
Yao Xiao authored
Bug: 863889 Change-Id: Ib1c68ca3053f3dfea5e06e40127a74634e45f6da Reviewed-on: https://chromium-review.googlesource.com/1140204Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#579578}
-
sczs authored
Changes the title and subtitle contentCompressionResistancePriority to prevent them from being compressed by the stackView. Bug: 862744 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0587b639cb76215c7f1c5b3bc26fdf87a21ab7c3 Reviewed-on: https://chromium-review.googlesource.com/1157197 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#579577}
-
Wei-Yin Chen (陳威尹) authored
Parameters |white_list| and |black_list| in FilterSourceFile() take iterables of strings, and they don't have to be tuples. Single-entry tuples are harder to read. The trailing comma could be confusing, especially in a list of arguments. They are converted to lists in this CL. Bug: None Change-Id: Iec5ed2f1e2d25bacf444165b734f76eaa3375aff Reviewed-on: https://chromium-review.googlesource.com/1155708 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#579576}
-
Sarah Hu authored
Also added strings and image for fingerprint unlock UI. Bug: 835357 Change-Id: I8b7f1de78121cdef8b831f1fe2373674705cee7b Reviewed-on: https://chromium-review.googlesource.com/1157064 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#579575}
-
Sam Maier authored
maybeMergeTabs is called on cold starts. It's an expenisve operation, and doesn't appear to do anything except in the case when there is a process restarted, as in https://bugs.chromium.org/p/chromium/issues/detail?id=657418 Testing: followed the Testing Multi-Instance Merging testing doc. https://docs.google.com/document/d/1KDykYo9M63O0zFeDdrV9BUYtomQl4dVnbVgssCyydng Bug: 867596 Change-Id: I1a0a42fe75d2487dfc71382d7fb55bbc0636e5a7 Reviewed-on: https://chromium-review.googlesource.com/1153438Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#579574}
-
Michael Spang authored
This test is broken - it's trying to verify that non-matching modifiers will cause screen manager to reject the current buffer for modesetting, but currently we do accept the buffer. The only reason the test passes is because the EXPECT_NE() checks that the framebuffer id doesn't match the current framebuffer, when it should check the opaque framebuffer id. Bug: 868010 Change-Id: I1f2312e6bc698f68f3806afd79ac07c19c3027cb Reviewed-on: https://chromium-review.googlesource.com/1155914 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
-
Stephen Martinis authored
Uses the bit.ly/chromium-build-naming naming scheme. Re-land which shouldn't break builders. Depends on https://crrev.com/c/1155263 Bug: 867725 Change-Id: I230121d1e531de5aeaeb34f09e2b1b6432008eff Reviewed-on: https://chromium-review.googlesource.com/1153616Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#579572}
-
Sam Maier authored
Currently, the AsyncTask that creates the Calendars is on the SERIAL_EXECUTOR - this is causing a lot of ANRs. Since it doesn't appear to require any synchronus guarantees with anything else in the SERIAL_EXECUTOR, we can move this to the THREAD_POOL_EXECUTOR. This means when we block on calendar creation using get(), we don't have to wait on all tasks currently in the SERIAL_EXECUTOR finishing. Bug: 866998 Change-Id: I3eb3a9c3b59771f4696fa1e17856e6fcb192388a Reviewed-on: https://chromium-review.googlesource.com/1157195Reviewed-by:
-
Kurt Horimoto authored
This prevents voice over from scrolling to these screens when they aren't visible. Bug: 865938 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4b27176c59a496fc0bb38468cfe11670c79529bd Reviewed-on: https://chromium-review.googlesource.com/1152366 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579570}
-
Michael Spang authored
ScanoutBuffer is used to wrap a framebuffer, so call it that. Bug: 869206 Change-Id: Idf748e60b4bbaed774cd91e9c3d35cb3778bae26 Reviewed-on: https://chromium-review.googlesource.com/1155912 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2a99c0bf6765..45a4c41eda90 git log 2a99c0bf6765..45a4c41eda90 --date=short --no-merges --format='%ad %ae %s' 2018-07-31 mbonadei@webrtc.org Never invoke rtc::LogMessage::SetLogToStderr outside of main. Created with: gclient setdep -r src/third_party/webrtc@45a4c41eda90 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I31947d2e4aa6ee452ffb9b836522635cc5bd16bd Reviewed-on: https://chromium-review.googlesource.com/1156910Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579568}
-
Dirk Pranke authored
At one point we were capacity-constrained on the Mac CQ, and so in order to switch running the tests from 10.9 to something newer, I was forced to split the tests between 10.12 and 10.13. Really, they should all be on 10.13 since the CQ is configured to mirror the 'Mac 10.13 Tests' bot. This CL starts to fix that by configuring traffic splitting using the multi-dimension trigger script; this should start shifting the layout tests to 10.13. Eventually we'll rebalance the pools and run them exclusively on 10.13 when we have enough capacity. R=jbudorick@chromium.org, kbr@chromium.org BUG=853356 NOTRY=true Change-Id: I549c5e5b9e149d78606e692679d03e055be14ab7 Reviewed-on: https://chromium-review.googlesource.com/1111030 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Sky Malice authored
Bug: 831648 Change-Id: I3a9525384ca17c05f38748fc3592af3f46f742db Reviewed-on: https://chromium-review.googlesource.com/1089930 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#579566}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c2ace4e71f59..a52306a4a7f2 git log c2ace4e71f59..a52306a4a7f2 --date=short --no-merges --format='%ad %ae %s' 2018-07-31 michaschwab@google.com Overview Brush Timeline Created with: gclient setdep -r src/third_party/perfetto@a52306a4a7f2 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I18d7f9dcd8969be782638e64667a1669e36c2ecb Reviewed-on: https://chromium-review.googlesource.com/1156913 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579565}
-
Trent Apted authored
Doing so requires it to detached and re-attached as a child window of the browser. Even though the status bubble has NSWindowCollectionBehaviorTransient, this triggers a space switch due to rdar://9037452 . Note the status bubble can still be hidden implicitly in other ways. E.g. Cmd+h, or miniaturizing the browser window. Bug: 866760, 31821 Change-Id: Iaf6220bf39bb62cb6002ebd372b96abb10db4f38 Reviewed-on: https://chromium-review.googlesource.com/1155274Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#579564}
-
Trent Apted authored
Normally drags initiated via views::View::ProcessMouseDragged() complete in views::View::DoDrag() once exceeding their drag distance threshold. However, DownloadItemView doesn't set a views::DragController or override View::GetDragOperations(). Instead, it runs its own drag in an override of View::OnMouseDragged(). This drag code path isn't aware of the Widget::SetCapture() call done in Widget::OnMouseEvent(), which needs to be released before an OS-level drag can take place. Usually this is done by views::DragDropClientMac, which gets skipped. To fix, ensure the custom OS-level drag codepath in download_item_drag_mac.mm releases capture instead. Bug: 863377 Change-Id: Ib2f7c80a00dd3b38fe5a98475bddb4e595f3f83c Reviewed-on: https://chromium-review.googlesource.com/1156192Reviewed-by:
-
