GitLab

- The 'Learn More' button on the incognito NTP either opens a new
  activity or a new non-icognito tab. Both is not supported in VR.
  As a workaround for now, request to exit VR and if we succeed show the
  'Learn More' page in 2D.

Bug: 742668
Change-Id: I23b9a2447ab297468dd9612c3e3e351ef59b3e40
Reviewed-on: https://chromium-review.googlesource.com/578169
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488487}

Bug: 734150
Change-Id: I8b6aac965c5b627197f62f9f732f154452bfe3d4
Reviewed-on: https://chromium-review.googlesource.com/579607
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488486}

Move all tablet mode related events from shell observer to a new tablet mode observer.

Test: all trybots especially ash tests
Bug: 743148
Change-Id: Idbc601cbf59476c3928fa7ba63ef1dd58fb83893
Reviewed-on: https://chromium-review.googlesource.com/572053
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488485}

Hopefully, this can help to make your code reviews slightly less
bottleneck-y.

Bug: 
Change-Id: Ic56d9c213927e97d4e756e8e4cf52d8b8c38b412
Reviewed-on: https://chromium-review.googlesource.com/580504Reviewed-by: Mike Baxley <baxley@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488484}

Follow up to https://chromium-review.googlesource.com/c/579937/ which
removes //tools/auto_bisect. Reason: These are no longer used and will
no longer work after removing //tols/auto_bisect.

Change-Id: Ibe90a9ced87ee34a6673cd7f77645eb20b735f9f
Reviewed-on: https://chromium-review.googlesource.com/580492Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488483}

BUG=726972

Review-Url: https://codereview.chromium.org/2978713002
Cr-Commit-Position: refs/heads/master@{#488482}

Bug: 740070
Change-Id: I9d0a7371c22856a641ad88910d55ba844aca4191
Reviewed-on: https://chromium-review.googlesource.com/572332
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488481}

This CL adds support for specifying a short blacklist of hosts in a
field-trial param of the Client-side LoFi field trial, which will
prevent Client LoFi from being used on those hosts.

TBR=petewil@chromium.org

Bug: 745032
Change-Id: I55a7ae8b3ebcdb5a98c7229a9f714757754b7d29
Reviewed-on: https://chromium-review.googlesource.com/578588Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488480}

This CL moves some hardcoded texts into remoting_string.grd so that
they can be localized.

Bug: 747091
Change-Id: Id9f57bd7d48338635d2c7d0567df1b8e24a83b0b
Reviewed-on: https://chromium-review.googlesource.com/578949
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488479}

Adds a call to hideKeyboard when the sheet is closed

Bug: 746803
Change-Id: Ib9d7a6a4696e7bf8f1864d0aaf3d6d3bb734f8d5
Reviewed-on: https://chromium-review.googlesource.com/579790
Commit-Queue: Daniel Park <danielpark@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488478}

Make our git diffs decent!
Preparation for:
https://chromium-review.googlesource.com/c/572164/

Bug=667560

Review-Url: https://codereview.chromium.org/2982263002
Cr-Commit-Position: refs/heads/master@{#488477}

When I added this method, I had added some extra logic for the case where we
have a collapsed selection to make it find spell check markers the caret is
touching an endpoint of. This was to support the spell check menu on Android,
where tapping the endpoint of a word brings up the menu (on other platforms you
need to right-click in the interior of the word for spell check options to
appear in the context menu).

Upon further reflection, we decided we should put this logic somewhere else.
We're going to keep this method around though because we're going to make use of
it in ContextMenuClient::SelectMisspellingAsync().

I'm renaming this method to GetSpellCheckMarkerUnderSelection() to try to make
the name less misleading.

BUG=736181

Review-Url: https://codereview.chromium.org/2954763002
Cr-Commit-Position: refs/heads/master@{#488476}

This adds UMA histograms for keeping track of how long it takes for
the Chrome Cleaner to scan and clean user's machines as well as the
time it takes for users to interact with the Chrome Cleaner prompt
dialog.

Bug: 746987
Change-Id: If4d70c196f68c462834cb0c1e8a82a8bfaa6ea05
Reviewed-on: https://chromium-review.googlesource.com/580087
Commit-Queue: Ali Tofigh <alito@chromium.org>
Reviewed-by: Robert Shield <robertshield@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488475}

Instead of transitioning to HALF or FULLSCREEN_SEARCH whenever the
search query is not empty, transition only when the query is not empty
and contains some non-whitespace characters.

This will be changed when Zero Query State is introduced, at a later
date.

for-Commit-Position: refs/heads/master@{#487254}
Bug: 746048
Change-Id: I78a2eb73589d3a13c2213d9f4f1d26f2c6162dc8
Reviewed-on: https://chromium-review.googlesource.com/578470Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488474}

Change some of the strings on the palette tray buble.

Test: none
Bug: 747148
Change-Id: I22a2a2480f2884091bffb1f5b9ac4bd04581990c
Reviewed-on: https://chromium-review.googlesource.com/580365Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488473}

Bug: 742990
Change-Id: Ibe303f5e0f5a94015adad2b0d90de963b25d61fb
TBR: tsepez (removing params from ipc message)
Reviewed-on: https://chromium-review.googlesource.com/572222
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488472}

BUG=738495

Review-Url: https://codereview.chromium.org/2962353002
Cr-Commit-Position: refs/heads/master@{#488471}

This allows transitions on UiElements to leverage visibility animations.

Bug: None
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5c362d2d6b90de5fa9702660ef7b3decaa0c0ff2
Reviewed-on: https://chromium-review.googlesource.com/579827
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488470}

Drive-by: Fix Save profile button alignment
Change-Id: I2ebafe68d006ec070285b1e6b2cda593e4101486
Reviewed-on: https://chromium-review.googlesource.com/579797Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488469}

This reverts commit 95176184.

Reason for revert: Revert code for investigation before going to beta,
as planned.

Original change's description:
> Add CHECK()s to investigate Issue 737392
> 
> ImageResourceContent::content_status_ is suspected to be reset to
> kNotStarted (i.e. 0) during ImageResourceContent::UpdateImage(),
> but therer is no code that sets content_status_ to kNotStarted
> explicitly.
> 
> This CL adds CHECKs() to
> - Check whether |this| is garbage collected unexpectedly during
>   UpdateImage(), and
> - Investigate where |content_status_| becomes kNotStarted precisely.
> 
> This is to be reverted before going to beta.
> 
> Bug: 737392
> Change-Id: I2879bc54771a295a2dd77fed6808c1c08668e262
> Reviewed-on: https://chromium-review.googlesource.com/572036
> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486986}

TBR=kinuko@chromium.org,yoav@yoav.ws,haraken@chromium.org,hiroshige@chromium.org,japhet@chromium.org,kouhei@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 737392
Change-Id: Ia13efe886e50873f3ad0c2375ac12819a0cfb46f
Reviewed-on: https://chromium-review.googlesource.com/580427Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488468}

Also update the browser_tests for renewal messages to verify that at least
one renewal message was actually received.

BUG=
TEST=browser_tests for renewal still work

Change-Id: Idad0059aec02dae4f0910fd9f39846c0a4ac660f
Reviewed-on: https://chromium-review.googlesource.com/569198Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488467}

Bug: 746294
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie50a57965ca0cea2d5415ac3a6ffea88d6d38201
Reviewed-on: https://chromium-review.googlesource.com/578294Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488466}

Enables compiling Media Remoting code on Android.
Uses remoting::RendererController to get updates on the WMPI data source and
pass the information as well as the codec compatibility info to RemotePlayback.

Bug: 517102
Change-Id: I064a223854c1d857434ff228fe47dc89849a0af8
Reviewed-on: https://chromium-review.googlesource.com/538338
Commit-Queue: Anton Vayvod <avayvod@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488465}

TBR=phajdan.jr@chromium.org

Change-Id: I37975dc4f4db873685696955e7739305b2be8b7f
Reviewed-on: https://chromium-review.googlesource.com/579067
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488464}

The feature is described in https://github.com/WICG/device-memory
and the intent to ship is here:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8qlTjzRY9Mc

Bug: chromium:710702,chromium:718622
Change-Id: If738affc6e171c60ad4b4540c2fec19959a1561a
Reviewed-on: https://chromium-review.googlesource.com/579795Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488463}

TBR=bmcquade

Change-Id: Id0933c23c20b818dc322ca7f487d1a242df61b4b
Reviewed-on: https://chromium-review.googlesource.com/530095
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488462}

RGB texture backed by native GMB cannot be bound to FBO on Intel, but BGR
texture backed by native GMB can be bound.

When GL_EXT_texture_format_BGRA8888 is supported, as-is chromium doesn't allow
BGRA and glTexStorage2D together, because the extensions doesn't define BGRA8
storage format.

Now native GBM needs BGR for WebGL hardware overlay, so this CL allows
both of them for WebGL context.

It's safe because WebGL API doesn't expose BGRA, and DrawingBuffer never use
glTexStorage2D(BGRA8).

BUG=746069
TEST=run WebGL Aquarium on eve
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0e74f738beff16826dcc7af5684791712923851c
Reviewed-on: https://chromium-review.googlesource.com/576967
Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
Cr-Commit-Position: refs/heads/master@{#488461}

It was landed almost a year ago, but was never used. If it turns out we
really do need it, can bring it back.

Bug: none
Change-Id: I8635219b8a3af3c46711ff7931403bf32854f351
Reviewed-on: https://chromium-review.googlesource.com/580387Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488460}

This service is currently used only within the same process, and
potentially large amounts of data are transfered over its interfaces, so
this seems a prime candidate for lazy serialization, and should help
some with mojo localstorage performance.

Bug: 730475
Change-Id: Iff573b33f1bfda2193d6bfb5366b9d24f8190150
Reviewed-on: https://chromium-review.googlesource.com/580509Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488459}

This reverts commit 8a8b48bb.

Reason for revert: Speculative revert to fix broken WebUIWebViewBrowserTests, see http://crbug.com/747125

Original change's description:
> Enable field trial testing config for GuestViewCrossProcessFrames.
> 
> Bug: 655753
> Change-Id: I756aada2893846878657fe33b405bdb70b23df54
> Reviewed-on: https://chromium-review.googlesource.com/576207
> Commit-Queue: James MacLean <wjmaclean@chromium.org>
> Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487966}

TBR=asvitkine@chromium.org,lfg@chromium.org,wjmaclean@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 655753, 747125
Change-Id: Id7486ff811442a5fd5e639deaef152e4382a70bc
Reviewed-on: https://chromium-review.googlesource.com/580547Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488458}

This CL is a refactor and has no intended behavior change.

By default, TestUkmRecorder no longer sets itself as the global UkmRecorder,
which doesn't work for browser tests. TestAutoSetUkmRecorder has the same
behavior as the previous TestUkmRecorder. All previous instances of
TestUkmRecorder were replaced by TestAutoSetUkmRecorder.

Bug: 
Change-Id: I10da73ff030c0d62cb7c9b1b9d6b4512572ad846
TBR: jam@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/580147
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488457}

Almost all callsites specify the |ok| argument. We should not use default
argument for rare cases.

Bug: 746157
Change-Id: I1cbc3491a510666a4269a6c993e0d811c29ecf5c
Reviewed-on: https://chromium-review.googlesource.com/579108Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488456}

The PDF plugin can receive a request to display a print preview with a 0
page count. It is a special meaning reserved for when the source of the
print preview is a PDF. In which case, just load the preview PDF in one
shot, instead of loading it incrementally.

BUG=746789

Change-Id: I3f9d99ebddffe9cedcc977dca03ccc2638f45011
Reviewed-on: https://chromium-review.googlesource.com/580495Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488455}

- This API can be used to exit VR when we encounter an unsupported
  feature.
- Make unhandled page info request use this API.

Change-Id: I974466cc40241f570aecb1ac08bb15b510bd57d2
Reviewed-on: https://chromium-review.googlesource.com/578209Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488454}

Previously, the importer would sometimes abandon a potential import
even when it passed CQ if there were any failing (flaky) jobs.

This CL should make it so that when deciding whether the CQ passed,
importer looks only at the latest builds for each builder.

Bug: 739119
Change-Id: I126e33191ddc24797501f97ff0834e3f9e45d4bc
Reviewed-on: https://chromium-review.googlesource.com/578141
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488453}

SurfaceManager::RequestSurfaceResolution and
SurfaceDependencyTracker::RequestSurfaceResolution take in an unused
SurfaceDependencyDeadline parameter. This CL removes it.

Bug: none
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I914cd1f45423ef231f76a5b58a29a178a8bbb941
Reviewed-on: https://chromium-review.googlesource.com/580528Reviewed-by: John Bauman <jbauman@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488452}

Existing layout is bizarre. Margins for a child are calculated inside the
childs layout. This includes the auto margins calculation as far as we
can tell.

This just does the "simple" margin calculation (no auto etc) as auto margins
etc only occur within block layout, which we now control.

We may have to refine this to include more behaviour if we discover other
cases we don't cover.

Bug: 635619
Change-Id: I944ae3435074441f06e118c59f8d2ad317227b32
Reviewed-on: https://chromium-review.googlesource.com/580291
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488451}

https://pdfium.googlesource.com/pdfium.git/+log/77417ec9e131..3f753f20e9c5

$ git log 77417ec9e..3f753f20e --date=short --no-merges --format='%ad %ae %s'
2017-07-20 rharrison Change length calculation in CFX_StringCTemplate constructor
2017-07-20 art-snake Use enum for pdf object type
2017-07-20 npm Upgrade LibTIFF to 4.0.8

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Iedf571faf2d80398ea6a3fb126fc57d53d8d0446
Reviewed-on: https://chromium-review.googlesource.com/580352
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488450}

This adds the chrome://safe-browsing/ WebUI page to WebView. This allows
WebView to hardcode URLs for testing Safe Browsing. This includes the
resources for the basic chrome://safe-browsing page.

As part of this, this adds WebUI to WebView for the first time.

This contains 2 changes to get things running for our tests:

 - Changes a DCHECK_EQ in content layer. This assumption doesn't
   hold for single process, so it crashes tests running in single
   process mode.
 - Adds more SandboxedProcessServices for the test shell. No change is
   needed for the actual WebView apk, because it already has more than
   enough SandboxedProcessServices (20).

The additional resources result in the following APK size increases for
the system_webview_google_apk target:

 - en-US.pak: 6896 -> 6947 (+51 bytes)
 - resources.pak: 434005 -> 436285 (+2280 bytes)

Bug: 709626
Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest#testSafeBrowsingHardcodedUrls
Change-Id: Ie312521b323a5ba5ec37f8c44eaa1f0427587e34
Reviewed-on: https://chromium-review.googlesource.com/576404Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488449}

Increasing timeout (https://codereview.chromium.org/2826253004)
lowered the failure rate. This indicates the tests are not inherently
flaky. They just run for longer.

Bug: 713172, 747073
Change-Id: I20a039776aa2aa9f70560e8d688f27ef34e6eb6a
Reviewed-on: https://chromium-review.googlesource.com/580256Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488448}