GitLab

BUG=167722
TEST=unit_tests --gtest_filter="DriveSystemServiceTest.InitialFeedFetch"

Review URL: https://codereview.chromium.org/11775014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175319 0039d316-1c4b-4281-b951-d872f2087c98

The condition file_watchers_.empty() does not hold if user signed out
with Files.app opened (onunload looks intentionally suppressed
http://crbug.com/123107 in this case). So DCHECK is not appropriate.

That said, the check can be useful to detect possible future regressions
to forget unregistering the file watch. So keeping it as DLOG should be useful.

BUG=126275

Review URL: https://codereview.chromium.org/11776018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175317 0039d316-1c4b-4281-b951-d872f2087c98

And switch to the existing AlternateNavInfoBar[Delegate] classes.

BUG=164772
R=pkasting@chromium.org
TBR=ben@chromium.org
NOTRY=True # ios_dbg_simulator seems to be broken in lkgm?

Review URL: https://codereview.chromium.org/11721003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175313 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124444
TBR=apatrick@chromium.org

Review URL: https://codereview.chromium.org/11779015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175312 0039d316-1c4b-4281-b951-d872f2087c98

In BookmarkTree.handleMoved(), moved tree item (bookmark folder) is unregistered by BookmarkTree.remove(), which overrides Tree.remove() and deletes child folder node from node id to node map, treeLookup[].

This causes subsequent move operation for moved tree item doesn't update BookmarkTree UI. Because moved tree item no longer in BookmarkTree look up table.

This patch removes override method BookmarkTreeItem.remove() for keeping removed node in treeLookup[].

BUG=123535

Review URL: https://codereview.chromium.org/11635038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175311 0039d316-1c4b-4281-b951-d872f2087c98

> Make RenderWidget responsible for the composited view's lifetime
> 
> Chromium side of https://bugs.webkit.org/show_bug.cgi?id=105071.
> content::RenderWidget constructs a WebLayerTreeView when WebKit
> asks it and then retains ownership. This has to be destroyed
> before the WebWidget is closed since the WLTVClient is (currently)
> a WebKit object.
> 
> BUG=156175
> TBR=piman@chromium.org for content/content_renderer.gypi
> 
> Review URL: https://codereview.chromium.org/11575049

TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/11794018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175304 0039d316-1c4b-4281-b951-d872f2087c98

Chromium side of https://bugs.webkit.org/show_bug.cgi?id=105071.
content::RenderWidget constructs a WebLayerTreeView when WebKit
asks it and then retains ownership. This has to be destroyed
before the WebWidget is closed since the WLTVClient is (currently)
a WebKit object.

BUG=156175
TBR=piman@chromium.org for content/content_renderer.gypi

Review URL: https://codereview.chromium.org/11575049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175303 0039d316-1c4b-4281-b951-d872f2087c98

Restructured this code quite a bit to use the new shortcut magic.

Added tests which turned out to expose edge cases that I think weren't covered by the previous implementation (i.e. would potentially update shortcuts when unecessary -- flashing the desktop in the process -- or not do it when necessary).

NOTRY=TRUE
(Actually dis use CQ at first, but iOS is messes up at LKGR looks like...)
BUG=142980
TEST=Pin Desktop shortcut to Start Screen or pin chrome.exe directly to the start screen via context menu.
Notice that there are now multiple shortcuts of Chrome (non-tiled; 1 for each "Pin to Start" action; upon launching Chrome those should all be merged down to one Chrome tile shortcut (not on the file system, but visually on the Start Screen itself).
Note: if you do try this; there is an intentional 15s delay before the migration kicks in to avoid delaying Chrome startup; so be patient, it will work ;)!

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175230

Review URL: https://chromiumcodereview.appspot.com/11712003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175302 0039d316-1c4b-4281-b951-d872f2087c98

> Windows: Remove content's dependency on d3dx9_43.dll.
> 
> ANGLE doesn't need this loaded anymore.
> 
> Review URL: https://chromiumcodereview.appspot.com/11737027

TBR=apatrick@chromium.org
Review URL: https://codereview.chromium.org/11791013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175301 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168128,168129
TEST=Added unittests; demo page works.

Review URL: https://codereview.chromium.org/11787012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175300 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168128,168129
TEST=Added unittests; demo page works.

Review URL: https://codereview.chromium.org/11745026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175299 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175298 0039d316-1c4b-4281-b951-d872f2087c98

I see these accidentally leak into codereview sometimes, and it'd be nice to
just have it automatically be prevented.

NOTRY=true
R=danakj@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/11794017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175296 0039d316-1c4b-4281-b951-d872f2087c98

Previously, we'd activate the pending tree if there were similar numbers of
checkerboards, but this could cause unfortunate flashing.  Now, only activate
the tree if all the tiles in the 'now' bin (high-res, visible) are ready.

NOTRY=true
R=nduca@chromium.org
BUG=155209


Review URL: https://chromiumcodereview.appspot.com/11734007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175295 0039d316-1c4b-4281-b951-d872f2087c98

Let's not contribute to spamming the console with messages.

NOTRY=true
R=danakj@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/11778009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175294 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175287 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175285 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175284 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/11794014
Patch from Terry Anderson <tdanderson@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175283 0039d316-1c4b-4281-b951-d872f2087c98

Fix regression with audio mirroring due to observers being added while iterating over the list of observers which causes an infinite loop.

BUG=168362


Review URL: https://chromiumcodereview.appspot.com/11785002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175282 0039d316-1c4b-4281-b951-d872f2087c98

Adjusted the padding and vertical justification of elements in the
notification view to match specifications and mock-ups.

BUG=161101,164292


Review URL: https://chromiumcodereview.appspot.com/11578060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175281 0039d316-1c4b-4281-b951-d872f2087c98

I've fixed the dependencies, so we can now support building the sandbox and running the tests as part of a normal Win64 build.

BUG=168414

Review URL: https://chromiumcodereview.appspot.com/11788002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175278 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11761031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175277 0039d316-1c4b-4281-b951-d872f2087c98

directory

Review URL: https://chromiumcodereview.appspot.com/11788003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175276 0039d316-1c4b-4281-b951-d872f2087c98

When a parent compositor is present (ie, ubercompositor), throttle to a single
pending frame.

Tests:
LayerTreeHostTestMaxPendingFrames.DelegatingRenderer
LayerTreeHostTestMaxPendingFrames.GLRenderer

BUG=123444
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11747002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175275 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168084


Review URL: https://chromiumcodereview.appspot.com/11776006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175274 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11789002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175273 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11784005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175272 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168200


Review URL: https://chromiumcodereview.appspot.com/11775005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175270 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11734034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175269 0039d316-1c4b-4281-b951-d872f2087c98

New members in LaunchOptions will allow to redirect stdin and stdout on
Windows.

This change was originally implemented by eaugusti@chromium.com in
crrev.com/10918255 .

BUG=142915


Review URL: https://chromiumcodereview.appspot.com/11419267

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175268 0039d316-1c4b-4281-b951-d872f2087c98

It's still all terribly manual and fragile, but that'll be taken care of
separately.


Review URL: https://chromiumcodereview.appspot.com/11797002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175267 0039d316-1c4b-4281-b951-d872f2087c98

More new year's cleanup.  These scripts haven't been useful for a long time.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11779006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175266 0039d316-1c4b-4281-b951-d872f2087c98

Log the following data through UMA:
* Frame rate over 10s
* Histogram of capture time
* Percentage of frame drops over 5mins
* Histogram of view size (per kilopixels)

BUG=163469


Review URL: https://chromiumcodereview.appspot.com/11565052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=dcheng@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11794006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175264 0039d316-1c4b-4281-b951-d872f2087c98

Revision 170633 added --disable-pepper-threading and enabled threading
for canary channel only.  Enable on all channels, remove
--enable-pepper-threading, but keep the --disable flag for now for
debugging purposes.

BUG=161286


Review URL: https://chromiumcodereview.appspot.com/11659032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175263 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11794011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175262 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122753

Review URL: https://codereview.chromium.org/11746012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168168,78283
TEST=none


Review URL: https://chromiumcodereview.appspot.com/11742028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175260 0039d316-1c4b-4281-b951-d872f2087c98

This also removes the warning shown when running Unity 2D
desktop - it's been working fine for quite a while.


BUG=168374


Review URL: https://chromiumcodereview.appspot.com/11791002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175259 0039d316-1c4b-4281-b951-d872f2087c98