- 16 Jun, 2020 40 commits
-
-
dpapad authored
Bug: 1091516 Change-Id: I9dd3708416b1ea120f23238050e8ab6c52cdc77b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244194 Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#778985}
-
Victor Costan authored
The feature has been enabled by default since https://crrev.com/c/2090451 which landed in M83. The feature has been enabled at 100% in Chrome via the field trials infrastructure since March. At this point, it's fair to expect the feature is here to stay. This CL cleans up the feature flag. No behavior change is expected. Change-Id: Ie30a758f453c3a9d9fd96d43ae53d9c3893e0bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244654 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#778984}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If7ef8c6f826cf8793c885da2d21a6ad00acb3604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778983}
-
Sadrul Habib Chowdhury authored
If a main-thread takes too long to respond, and the compositor does not have any updates, then create a 'dropped frame' trace event, so that it is possible to correctly detect all the frames that were dropped. BUG=1095186 Change-Id: I6b53d06c1f1a829c841eefa6afafe5c861381dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245296 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#778982}
-
Gang Wu authored
Bug: 1095702 Change-Id: Iac00fb9480c5ad8005e6145abdaea99d3d87a922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248174Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#778981}
-
edchin authored
This CL adds utils for creating UIDragItems. Two types of items can be dragged from Chrome: 1) A tab (from tab grid, tab strip, and omnibox) 2) An URL (from bookmarks, history, recent tabs, and reading list) This CL is one in a series to add drag and drop functionality in a multi-window world. A tab drag item has enough information to locate a tab and move it from one window to another. These util methods will be used in future CLs to fulfill drag delegate protocol methods to create drag items. Bug: 1087844 Change-Id: Ib56c287e6d8b631d275528430cd7ae1102044642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246178 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#778980}
-
Stephanie Kim authored
This reverts commit c9a4b939. Reason for revert: Reland change with mb_config fix Original change's description: > Revert "android-binary-size-generator ci bot setup" > > This reverts commit 79472ed7. > > Reason for revert: Forgot mb configs > > Original change's description: > > android-binary-size-generator ci bot setup # Not skipping CQ checks because this is a reland. Bug: 1078460 Change-Id: I69114c62a459bcf0c9bfce8f2cd77685bda0ed84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248070 Commit-Queue: Stephanie Kim <kimstephanie@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#778979}
-
Clark DuVall authored
This view was missed in http://crrev.com/c/2243579, and is referred to in one of the layouts moved in that CL. Bug: 1019922 Change-Id: I212c624fa7a37f9969d9e4cde01ec4b8e59c38b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247267Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#778978}
-
David Maunder authored
Suggestions for grouping tabs together or closing tabs are made to the user. Grouping suggestions should be given precedence over closing suggestions. Bug: 1095182 Change-Id: Iba648eef8ec704e5687fb5ee02f1dd1f91ce350f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247241 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#778977}
-
Teresa Kang authored
With the logic that preserves acceleration regardless of the RasterModeHint given in ShouldAccelerate, GetOrCreateResourceProvider will try to create a gpu resource provider even if the hint is kPreferCPU, in which case re-creation should try to happen through Restore() first. The hint should not have an effect on whether or not to use Restore(). Bug: 1090180 Change-Id: Ia87b081ef611021a4c94a7ac0232c380fca3a143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246788Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Teresa Kang <teresakang@google.com> Cr-Commit-Position: refs/heads/master@{#778976}
-
Bo Liu authored
In Rect::Intersect and throughout the code, when an intersection result is empty, the origin is thrown away. Which means the resulting Rect may not be contained in either of the original intersected Rects. So relax the check in draw_quad and serialization checks to explicitly allow this. Fixed: 1095559 Bug: 1072407 Change-Id: I13c9fb9255141466909d99eafba3255d9c7a1c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248162Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#778975}
-
Ken Rockot authored
Outside of Chrome OS mojoms there are still a few places using deprecated interface type syntax. This fixes those. Bug: 955171 Change-Id: I1cd2eb4ac99e8f47f0eaf76d0595cb050372c926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248163Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#778974}
-
Allen Bauer authored
LaserPointerView, CursorView Bug: 1044687 Change-Id: I2637a56faf87639467c65f2a5f06a42878ab6f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222863 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#778973}
-
Christopher Cameron authored
Move the allocation of the service GL texture to after the GLImage allocation in CreateSharedImageInternal. This is significant because it will allow us to create a SharedImageBackingGLImage immediately and then lazily allocate a GL texture. Bug: 1092155 Change-Id: Iccf182cdcd8c7df3442485494a67fc9ae21e6343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245687 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#778972}
-
Himanshu Jaju authored
The current rate of metrics collection suggests that it might take ~8 weeks for ~1k metrics for webrtc. Bumping up the expiry milestone to collect more data. Bug: 1072600 Change-Id: I5825effe9ef7c268e28b7fbe43117c54f9e37129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246513Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#778971}
-
Mitsuru Oshima authored
* Changed the ArcNotificationManager so that it can be injected to MessageCenterController instead of creating it inside * Moved arc notification impl to ash/public/cpp/external_arc/message_center * Moved arc notification interfaces and constants to ash/public/cpp/message_center AX-Relnotes: n/a. Bug: 1090616 Change-Id: I995fc5749ab0fbe18d43b451e6553b8d82728e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244656 Commit-Queue: Mitsuru Oshima (slow:gardening) <oshima@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#778970}
-
Taylor Bergquist authored
Change-Id: I45e2d76fc1940724fa938c80c6edf6c28d0e106c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248489Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#778969}
-
Daniel Rubery authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2226974 The crash stack indicated that I never set the PaintPreviewTracker appropriately. This CL sets the tracker and relands the original CL. Bug: 1068617 Change-Id: I6ffae2cc0b15ad3b812c5f07588922510fb5a6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243353Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#778968}
-
George Burgess IV authored
In ``` void foo(std::unique_ptr<Bar> x) { x->run(std::move(x)); } ``` The order in which `x->run` is 'evaluated' is unsequenced with the `move` out of `x` into a param. Force the intended order here by grabbing the intended pointer in a prior statement. Bug: None Change-Id: Iab0af546c6f0640dfc6977256d7a6a55277dbbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202971Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#778967}
-
Vadim Shtayura authored
It is needed to support ResultDB which uses Realms ACLs exclusively. Eventually it will be used by all LUCI services as a single source of ACLs. It is not enforced anywhere other than ResultDB yet, so this change should be safe. BUG=1013316 R=gbeaty@chromium.org, nodir@chromium.org, CC=robertocn@chromium.org, tikuta@chromium.org Change-Id: Id7cd5f14e83d591cc0e689da93307f0aa712f855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248543Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Cr-Commit-Position: refs/heads/master@{#778966}
-
edchin authored
This CL adds a function MoveTab() to perform a tab move from one Browser to another. This CL is one in a series to add drag and drop functionality in a multi-window world. The algorithm looks for the source browser from which to detach the tab. This code inefficiently loops through a browser list to find the source browser. In practice, this is not that bad since 1) this activity is not often performed, and 2) the number of browsers in a browser list is probably small. Bug: 1087844 Change-Id: I2534e3232178fc1391156f862b0a9fabb0ec9004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246783 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#778965}
-
Nate Chapin authored
Change-Id: Ic7d586abc3e33476dd5847e788926263cfdd81f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227049 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#778964}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8e0b4634..ad327885 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id70698cb30e583b0e762f65559a7a9c253c7afe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248578Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778963}
-
Haiyang Pan authored
This is to help debug the timeout issue as tracked in crbug.com/1093602 Bug: 1093602 Change-Id: I41457d827f9792deb62a94567039e3a03a9e9190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246189 Commit-Queue: Haiyang Pan <hypan@google.com> Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#778962}
-
Wenyu Fu authored
Bug: 1094938, 1094926 Change-Id: Ib62d93d8d1ea668eb1a2542df3c54b234798fa59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248546 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#778961}
-
Ben Joyce authored
Bug: 1005891 Change-Id: I0e7b9fe291ebca3b797a27cd7db6dfbe788d2645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247122Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#778960}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I7af453fb3f8ae8c5de3b46f3d649c6d5fa466444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248171Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#778959}
-
Lin Sun authored
- Remove fixed suppressions that are related to closed bugs. - Add driver tag for the Intel driver issues that are fixed on new graphics driver. - Add more detailed tags for some suppressions to restrict the failure condition. Bug: 602688, 1018028, 1021428, 1048861 Bug: 1060012, 1063472, 1081973, 1081978 Bug: 1082533, 1084864, 1082525, 1082565 Bug: angleproject:2291, angleproject:3469 Bug: angleproject:4417, angleproject:4242 Change-Id: I44688fcf483e6c74d1f2bd0f7233bb50340819d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240891 Commit-Queue: Lin Sun <lin.sun@intel.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#778958}
-
Ben Joyce authored
Bug: 1005891 Change-Id: Idd6ec5663f1dae158579a59ae05e93f6657d4bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248541Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#778957}
-
Ben Joyce authored
Adds androidx_test_runner_java as dep to cronet_sample_test_apk. Bug: 1005891 Change-Id: I7a06afd3174451915c7ed277f6d4ca7dd7b6e001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245688Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#778956}
-
Ben Joyce authored
covers chrome/android/javatests/e* through chrome/android/javatests/p* Bug: 1005891 Change-Id: I0599b86528a9a506453c3777a375e7e9f705a1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248544Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#778955}
-
Vikas Soni authored
Make ImageReaderGLOwner::ScopedHardwareBufferImpl safe to be used on any thread. This does not make this class thread safe in the sense it can not be used by multiple threads in parallel. It is made safe to be accessed/destroyed on any thread. Bug: 1091945 Change-Id: Ibbf3abde59fbc15770bd6175015c7a9bd6662ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247265Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#778954}
-
Nigel Tao authored
JSONReader::Read is a static method, but JSONReader::GetErrorMessage is not. If invalid JSON is passed, GetErrorMessage() will not return anything useful. Bug: 1070409 Change-Id: Ib83396c7c3824235e36273a0a7bfbe8f9c6c4103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247924Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#778953}
-
Vladimir Levin authored
This patch ensures that when we increase the size of elements to determine whether we should descend into them to find a deep anchor, we avoid descending into elements with layout and paint containment that are otherwise off-screen. In other words, we don't adjust their size because any overflow would not be visible. R=chrishtr@chromium.org Change-Id: Id06e4db3625ded3ad43c5e57aeb5b2e40c7ed68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245186 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#778952}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/002fa6dcfa6a..959037e082f6 2020-06-16 jmadill@chromium.org Vulkan: Preserve RPs on XFB changes when possible. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I2c3f78ddd766c563f2dfb6d0cff88db255256afd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248438Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778951}
-
Sebastien Marchand authored
This reverts commit bf9634ae. Original change's description: > Revert "Remove support for Tab Freezing" > > This reverts commit d0332c34. > > Reason for revert: Introduced failure on browser_tests DiscardsTest.All > > First failure here: > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19162 > [9313:9313:0615/094609.344774:INFO:CONSOLE(1065)] "Running TestCase DiscardsTest.All", source: file:///b/s/w/ir/chrome/test/data/webui/test_api.js (1065) > [9313:9313:0615/094609.353925:WARNING:CONSOLE(34)] "Error: Assertion failed: Unsupported sort key: canFreeze > at assert (chrome://resources/js/assert.m.js:26:19) > at assertNotReached (chrome://resources/js/assert.m.js:64:3) > at compareTabDiscardsInfos (chrome://discards/discards_tab.js:73:3) > at chrome://test/discards/discards_test.js:42:22 > at Array.forEach (<anonymous>) > at Context.<anonymous> (chrome://test/discards/discards_test.js:41:10) > at callFn (file:///b/s/w/ir/third_party/mocha/mocha.js:5342:21) > at Test.Runnable.run (file:///b/s/w/ir/third_party/mocha/mocha.js:5334:7) > at Runner.runTest (file:///b/s/w/ir/third_party/mocha/mocha.js:5990:10) > at file:///b/s/w/ir/third_party/mocha/mocha.js:6108:12", source: chrome://resources/js/assert.m.js (34) > [9313:9313:0615/094609.364579:ERROR:CONSOLE(49)] "Mocha test failed: discards CompareTabDiscardsInfo > Error: Assertion failed: Unsupported sort key: canFreeze > at assert (chrome://resources/js/assert.m.js:26:19) > at assertNotReached (chrome://resources/js/assert.m.js:64:3) > at compareTabDiscardsInfos (chrome://discards/discards_tab.js:73:3) > at chrome://test/discards/discards_test.js:42:22 > at Array.forEach (<anonymous>) > at Context.<anonymous> (chrome://test/discards/discards_test.js:41:10) > ", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49) > > Original change's description: > > Remove support for Tab Freezing > > > > This feature has been abandoned. > > > > Bug: 844426 > > Change-Id: I777dcb72edd7941778374cc2fbff1e2c966bdac1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239374 > > Reviewed-by: Will Harris <wfh@chromium.org> > > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#778280} > > TBR=avi@chromium.org,kenrb@chromium.org,fdoray@chromium.org,asvitkine@chromium.org,wfh@chromium.org,sebmarchand@chromium.org > > Change-Id: I3dafddea7f11bffea171cd8a80ea51368943dd83 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 844426 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246920 > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778411} TBR=avi@chromium.org,flackr@chromium.org,kenrb@chromium.org,fdoray@chromium.org,asvitkine@chromium.org,wfh@chromium.org,sebmarchand@chromium.org # Not skipping CQ checks because this is a reland. Bug: 844426 Change-Id: I40be29e8c38f4af699537b62cd5b7176721b6bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246865Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#778950}
-
Matt Menke authored
The NetworkIsolationKey is used for DNS lookups and proxy connection sharing. content/ still needs to be updated to pass in the correct NetworkIsolationKey. Bug: 1085022 Change-Id: I3e56fdf19e32d71a659e2961a5327e9262870aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241613Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#778949}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592318647-c846006b87aca0f87b5615080933ac03d3857a36.profdata to chrome-win64-master-1592324603-595a5101027449adb0c10d8dfc4b4a112ba8b2ae.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I66a6386b334bfbab262cd9e9e1d6d2276162f15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248462Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778948}
-
Justin Miron authored
This replaces instances of blacklist, whitelist with blocklist and allowlist, respectively to make wording more inclusive. BUG=842296. Change-Id: Ibd90877dff886830ebe569095ccea16b291b3e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240049 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#778947}
-
Mohamed Amir Yosef authored
Screenshot: https://screenshot.googleplex.com/NdctJthyEtR Bug: 1044038 Change-Id: I32a70d3ab46302c1fd2311f79b48c8558fee2e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220048Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#778946}
-