- 06 Dec, 2018 12 commits
-
-
Peter Boström authored
Makes sure that a lot of animation-related code is bypassed when the new-tab-animation flag is off. This should hopefully fix a couple of performance regressions that have not yet been root caused so that they don't go out with M72. Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265 Change-Id: Id3f131db427eb3ee1618d6c9683fd5e47dc134e8 Reviewed-on: https://chromium-review.googlesource.com/c/1364212Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#614199}
-
braveyao authored
In a recent change, we added a check to tabCapture methods that the target browser must be tabbed. This cause a problem to cast a popup window which is not opened as tabbed. See https://crbug.com/911868 for more details. This cl is to remove the check to fix the regression. Bug: 911868 Change-Id: I1f140371861f694a06c42602ad4eba9f10366ba5 Reviewed-on: https://chromium-review.googlesource.com/c/1364214Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#614198}
-
Ryan Tseng authored
And remove blink::ToIsolate(ExecutionContext) altogether. Bug: 889542 Change-Id: I33e787acbde47b76cceb77288c82356bc5fa8411 Reviewed-on: https://chromium-review.googlesource.com/c/1355944Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#614197}
-
Tatiana Buldina authored
Change-Id: I23b0b7bd64eb36e5cf7d791758395d7fa6431df1 Reviewed-on: https://chromium-review.googlesource.com/c/1363975 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#614196}
-
Clark DuVall authored
These should never be null, add CHECKs to see if this is why we're crashing. Bug: 912217 Change-Id: Ie46b9cd263899a9a437da0976c2133b16d37c786 Reviewed-on: https://chromium-review.googlesource.com/c/1363834Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#614195}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 642609c7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I576f0aa8b2e78482fe492b8d69ba2dcbe5cf45a3 Reviewed-on: https://chromium-review.googlesource.com/c/1363896Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614194}
-
siyua authored
If uploading of a card failed, in the feedback dialog, we will show a string 'invalid' and a trash can button. If the user clicks the button, that card will be deleted from browser and will disappear in the feedback dialog. If all invalid cards are deleted in the dialog, the dialog will be updated to the 'finished' state. If all cards failed, we will not show the "View cards button". Uploaded screenshots in the bug (comment #10 and comment #26). Bug: 897998 Change-Id: Iae7780027932ac530bcb2f0c643be1ec94d1f334 Reviewed-on: https://chromium-review.googlesource.com/c/1314129Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#614193}
-
Sadrul Habib Chowdhury authored
Simplify the decision making of whether accelerated compositing is enabled or not. Instead of requiring a WebWidgetClient override to turn on accelerated compositing, make it an input parameter during construction. TBR=dcheng@, danakj@ for the mechanical changes in components/ content/shell extensions/ media/ Bug: none Change-Id: Icfdba3febcd4f9ac3263be7d8796517a38776976 Reviewed-on: https://chromium-review.googlesource.com/c/1357942 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#614192}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/56411745b6a9..247c822ca9a2 Created with: gclient setdep -r src-internal@247c822ca9a2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2a7d865a50aeb42b8c9a91e9f530b82baceae6f0 Reviewed-on: https://chromium-review.googlesource.com/c/1363305Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614191}
-
Max Moroz authored
Bug: 910235 Change-Id: I3b66b45ebe6ea28b4c5b80463fadfe5f1d8c315d Reviewed-on: https://chromium-review.googlesource.com/c/1364058 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#614190}
-
Ben Pastene authored
This has been blocking LKGM updates for a while now. Disable it while we work on a proper fix. Bug: 909975 Change-Id: I850e49137a68e013e745dff42507767bb8e4b798 Reviewed-on: https://chromium-review.googlesource.com/c/1363805Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#614189}
-
Chris Harrelson authored
Also, make the overflow_ method of LayoutBox private and adjust callsites to use proper methods on it rather than manipulating the object directly. Bug: 892347 Change-Id: I764d09c5bac41ead4694690748057d2f4d8405ab Reviewed-on: https://chromium-review.googlesource.com/c/1363962Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#614188}
-
- 05 Dec, 2018 28 commits
-
-
Ricardo Quesada authored
Send DPI information based on display size and not bounds Both Portrait and Landscape orientation when in Tablet mode report the same DPI values. Bug: b/120413640 Test: Launched com.vapps.screeninfo on Caroline running ARC N. Change-Id: Ic06c9f8a5f5195fb5fd9c88f5efd62efc6dedb5b Reviewed-on: https://chromium-review.googlesource.com/c/1364078Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Cr-Commit-Position: refs/heads/master@{#614187}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c3def54e..f5137533 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I439029435626301984e0df36219ae22eb1c958b8 Reviewed-on: https://chromium-review.googlesource.com/c/1364056Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614186}
-
Esmael El-Moslimany authored
Bug: 911594 Change-Id: If0e561781dc97676b228b0a069b234c84cb75523 Reviewed-on: https://chromium-review.googlesource.com/c/1361641Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#614185}
-
Joel Hockey authored
Bug: 911861 Change-Id: I064324537de34cfe513145e4a9a1f56b6a25a76a Reviewed-on: https://chromium-review.googlesource.com/c/1361755Reviewed-by:
Chirantan Ekbote <chirantan@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#614184}
-
Kristi Park authored
Delete thumbnail data from the user profile on startup. NTP thumbnails have been deprecated as of M69. This should be removed after a couple of milestones. Bug: 893362 Change-Id: Id280f8129dc7e9a6b11f143aa4b382424e9dd10b Reviewed-on: https://chromium-review.googlesource.com/c/1359473 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#614183}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I5d1dd956e155402052648bc656347ac041bb34eb Reviewed-on: https://chromium-review.googlesource.com/c/1363311Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614182}
-
Tony de Luna authored
BUG=891950,863618 Change-Id: Ie52e4939e39ae26c01e64ba119ddd0933f0a8e69 Reviewed-on: https://chromium-review.googlesource.com/c/1356942 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#614181}
-
Bence Béky authored
This CL removes some of the divergences in //net/third_party/http2/ with the internal codebase. Bug: 488484 Change-Id: I8679667efcd8c60139079e8ddc469b39a277b5cf Reviewed-on: https://chromium-review.googlesource.com/c/1363444Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#614180}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2fa1bbcf3c4c..19207476fc1d git log 2fa1bbcf3c4c..19207476fc1d --date=short --no-merges --format='%ad %ae %s' 2018-12-05 jvanverth@google.com Revert "Fallback mipmap creation for YUVA images." 2018-12-05 reed@google.com add simple docs for textencoding in SkPaint 2018-12-05 jvanverth@google.com Fallback mipmap creation for YUVA images. 2018-12-05 bsalomon@google.com Bypass interval tracking and assignment of read-only texures in GrResourceAllocator. 2018-12-05 bsalomon@google.com Mark wrapped textures imported into SkImages as "read only". 2018-12-05 bsalomon@google.com Use unnormalized coords all the way through with GL_TEXTURE_RECTANGLE textures. 2018-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 81a880aaeb57..96bd8fdf36e5 (1 commits) 2018-12-05 reed@google.com add bench for textblobbuilder Created with: gclient setdep -r src/third_party/skia@19207476fc1d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: If804bd76922da0239a145708056e7f3b8e725b09 Reviewed-on: https://chromium-review.googlesource.com/c/1364010Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d2a67111a818..9ac1758ffa0c git log d2a67111a818..9ac1758ffa0c --date=short --no-merges --format='%ad %ae %s' 2018-12-05 dgarrett@google.com chromeos_config: Create postsubmit for every release board. 2018-12-05 dgarrett@google.com workspace_stages: Create dual sync stage. 2018-12-05 dgarrett@google.com config_lib: Remove buildslave_type. Created with: gclient setdep -r src/third_party/chromite@9ac1758ffa0c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifbe18aaf91ec6e9f427ab0693e4fb2d4e1d9e227 Reviewed-on: https://chromium-review.googlesource.com/c/1363309Reviewed-by:
-
Alan Cutter authored
This change adds a new executable to Windows called chrome_proxy.exe which opens chrome.exe with all arguments forwarded. In a future patch bookmark app shortcuts will be updated to point to chrome_proxy.exe instead of chrome.exe so they don't pick up the chrome.VisualElementsManifest.xml file when pinned to the Windows 10 start menu. This fixes a bug where pinned bookmark app shortcuts all use the Chrome logo instead of their own. Bug: 732357 Change-Id: I551093f6f111041b424d30ec3f829fa6a06a265c Reviewed-on: https://chromium-review.googlesource.com/c/1362695Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#614177}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/176c0f8ca7cf..b5fbf5116279 git log 176c0f8ca7cf..b5fbf5116279 --date=short --no-merges --format='%ad %ae %s' 2018-12-05 thestig@chromium.org Clean up CBC_ReedSolomonGF256Poly::Init(). 2018-12-05 thestig@chromium.org Fix up CBC_PDF417ErrorCorrection. 2018-12-05 thestig@chromium.org Remove a custom implementation of wcstod(). 2018-12-05 thestig@chromium.org Remove an unused function. 2018-12-05 thestig@chromium.org Remove unused CBC_ReedSolomonGF256Poly::EvaluateAt(). 2018-12-05 thestig@chromium.org Get rid of some sizeof() calculations. 2018-12-05 tsepez@chromium.org Remove more ScriptAttributeString() wrappers, part 3 2018-12-05 thestig@chromium.org Add delete_output_on_success option to test_runner.py. Created with: gclient setdep -r src/third_party/pdfium@b5fbf5116279 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ieef246775106ebaf94c7e841aaf632a5f83d3458 Reviewed-on: https://chromium-review.googlesource.com/c/1363306Reviewed-by:
-
Xiaocheng Hu authored
InlineBoxPosition is a class that works only in legacy layout. Hence, this patch disables LayoutNG in InlineBoxPositionTest so that the tests can pass on the NG bot. Change-Id: Ieeea2f1b3413bce46adc7e9aa5358d58648a1707 Reviewed-on: https://chromium-review.googlesource.com/c/1364064Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#614175}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/96bd8fdf36e5..eae081c6682a git log 96bd8fdf36e5..eae081c6682a --date=short --no-merges --format='%ad %ae %s' 2018-12-05 syoussefi@chromium.org Vulkan: Fix ASTC_12x12_SRGB_BLOCK support Created with: gclient setdep -r src/third_party/angle@eae081c6682a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I1bbe74351484b6c9fa420cca95a30077e97b0aeb Reviewed-on: https://chromium-review.googlesource.com/c/1364011Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4a817f6e6f88..75726f2852b3 git log 4a817f6e6f88..75726f2852b3 --date=short --no-merges --format='%ad %ae %s' 2018-12-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 92bac9a6..48afe1fc (613922:614046) Created with: gclient setdep -r src/third_party/webrtc@75726f2852b3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I358ff6db8504b8f920c6a37e33dcf7b8836fedf1 Reviewed-on: https://chromium-review.googlesource.com/c/1363308Reviewed-by:
-
Patrick Noland authored
Check against android_sdk_release instead of sdk_version, which is not always defined. Bug: 912353 Change-Id: Ic14b89a7d7491893497e549eac82049f75fa7c19 Reviewed-on: https://chromium-review.googlesource.com/c/1364213Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#614172}
-
Mohsen Izadi authored
GPU service uses GpuPreferences::texture_target_exception_list when allocating memory buffers for clients. This info needs to be passed to GPU when it is initialized. Currently, this is not happening in Multi-Process Mash. This CL passes in this information for in-process GPU mode which is currently the default mode in Multi-Process Mash. BUG=906171 Change-Id: I58616db0cba949c3aad8e850aec2c4a8651bab6d Reviewed-on: https://chromium-review.googlesource.com/c/1342940Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#614171}
-
Dmitry Gozman authored
- Remove ResetSourceLocation. We can do it locally in DocumentLoader::StartLoading instead. - Move commit call out of LoadDataURL to CommitNavigation. - Remove some code duplication in CommitNavigation. - Add weak_this check which was missing in LoadDataURL path. Bug: 855189 Change-Id: I1d97a6f28ff574d47b0eb2f592705dfcf8daf026 Reviewed-on: https://chromium-review.googlesource.com/c/1352527Reviewed-by:
-
Frank Kastenholz authored
Change the PATH_CHALLENGE data buffer to be a dynamic buffer, allocated when a PATH_CHALLENGE is issued and deleted when a matching PATH_RESPONSE arrives. This ensures that the buffer is checked if and only if it is valid, eliminating a bug where an uninitialized buffer could be checked if an orphan PATH_RESPONSE arrived. gfe-relnote: N/A, only affects IETF QUIC/Version 99 Bug:906383 R=rch@chromium.org Change-Id: I95873ed7e34fedba75be8c87c1d7e73f5722084e Reviewed-on: https://chromium-review.googlesource.com/c/1363809Reviewed-by:
-
Lukasz Anforowicz authored
As we attempt to limit the uses of blink::Platform’s CreateDefaultURLLoaderFactory, it makes sense to avoid using it from EmptyLocalFrameClient - this CL disallows the default EmptyLocalFrameClient from making network requests. This CL assumes that WebPagePopupImpl, InspectorOverlayAgent, ValidationMessageOverlayDelegate should not make any network requests. After this CL, these classes will continue using EmptyLocalFrameClient and if they attempt to make fetch a subresource over network, then they will hit the new NOTREACHED (and probably crash shortly after when dereferencing the returned, null URLLoaderFactory). This CL preserves the behavior of SVGImage::SVGImageLocalFrameClient, DummyPageHolder (test code) and PingLocalFrameClient (test code) to continue calling blink::Platform's CreateDefaultURLLoaderFactory. Bug: 891872 Change-Id: I5132fcc66929ff14b25ce2ce636011e1463244f4 Reviewed-on: https://chromium-review.googlesource.com/c/1359051 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#614168}
-
Dominic Mazzoni authored
In particular, we want to make it possible to jump from an aura Window in the ash tree to a proxy window's corresponding client window in the client tree. Bug: 911945 Change-Id: I7713ed0f808f5b5a79804eb7c50510a148639edf Reviewed-on: https://chromium-review.googlesource.com/c/1362013 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Zhiqiang Zhang authored
This is the CAF-version of CL https://crrev.com/c/1263615 The original CL description is as follows: Currently, the new RemotePlayback path always plays videos from the beginning. It also disregard the current play/pause state and always autoplays. This CL fixes both issues by delaying the call to load, until we get our first seek or play command, and by loading the video with the current time. The case when a video that has was never played is cast will be re-examined in a follow up CL (the user intent when casting a video is probably to watch it, so it is probably best to start playback, rather than to force the user to cast and then press play). Bug: 711860 Change-Id: I8f039f7607519a44712554e2907551d7177c425c Reviewed-on: https://chromium-review.googlesource.com/c/1363974 Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#614166}
-
Brad Hall authored
> Add 10.13 as an optional dimension for layout tests > > This will allow them to try 10.13 first and fall back to 10.12 > if there aren't any hosts available. Bug: 853356 Change-Id: I2a23e3abacc747d888a88af1e0f27df235a60512 Reviewed-on: https://chromium-review.googlesource.com/c/1363647Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Brad Hall <bradhall@google.com> Cr-Commit-Position: refs/heads/master@{#614165}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ff8b67eeebce..f3fa19fcd28e git log ff8b67eeebce..f3fa19fcd28e --date=short --no-merges --format='%ad %ae %s' 2018-12-05 primiano@google.com Merge "Fix battery counter test" 2018-12-05 lalitm@google.com Merge "trace_processor: extract RowIterator into its own file" 2018-12-05 lalitm@google.com trace_processor: add support for filtering on nullable types 2018-12-05 hjd@google.com Merge "trace_processor: Use constant for static strings" 2018-12-05 lalitm@google.com Merge "perfetto: fix proto lints in downstream users" Created with: gclient setdep -r src/third_party/perfetto@f3fa19fcd28e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia0b5968e4bd990fc14b061960521d2e27bab7fc2 Reviewed-on: https://chromium-review.googlesource.com/c/1363304Reviewed-by:
-
Steven Bennetts authored
The keyboard pref observer does not have any particular reason to be associated with the launcher controller; we should move it. This moves SetVirtualKeyboardBehaviorFromPrefs from ChromeLauncherController to ChromeKeyboardControllerClient Bug: 826391 Change-Id: I1b8680ea7c29e902763c3fce76590c55b1042928 Reviewed-on: https://chromium-review.googlesource.com/c/1361643 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#614163}
-
Ehsan Karamad authored
The RenderWidgetHostView::WasOccluded and ~::WasUnOccluded are not overridden. On MacOSX minimizing the browser leads to calling WebContents::WasOccluded which is therefore not triggering the visibility of child RenderWidgets. This CL implements the methods for RWHVCF and adds a test which verifies requestAnimationFrame is throttled for occluded child renderer processes. Bug: 903455 Change-Id: If836a872e6372abf31017cc81dcaa3e7d31d65b9 Reviewed-on: https://chromium-review.googlesource.com/c/1357303Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#614162}
-
Jinsuk Kim authored
https://chromium-review.googlesource.com/c/chromium/src/+/1272779 had a couple of bugs in |ToolbarButtonInProductHelpController|: 1) Ignored |profile| passed into |maybeShowDownloadContinuingIPH()| and always used Profile.getLastUsedProfile() 2) |OnDismissListener| was instantiated (and menu got highlight for the text bubble) every time |setupAndMaybeShowIPHForFeature| is called, even when the method doesn't meet the condition for IPH text bubble and has to early out. The CL got reverted due to numerous regressions . This CL fixes them and relands it. This reverts commit d436a7a2. Bug: 889682, 907502, 907503, 907770, 907505, 907602 Change-Id: Id6de148a9fd4fd91ad7df986ca0ba78ed18e79e4 Reviewed-on: https://chromium-review.googlesource.com/c/1349142Reviewed-by:
-
Stuart Langley authored
This should be enforced by DriveFS, but currently they have a bug so we can do the same thing in the files app, by marking the individual computer roots as read only. Bug: 912287 Change-Id: I6df7c598315000fb87a221fd530545298cdb2ce1 Reviewed-on: https://chromium-review.googlesource.com/c/1363731Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#614160}
-
