- 30 Jan, 2020 40 commits
-
-
Thomas Guilbert authored
This CL changes video fullscreen tests to wait on one frame being painted, in an attempt to make them more reliable. The CL also updates the test expectations. Bug: 1025291 Change-Id: I80de51215b1d009f6e5ae99e2808c9223cb89ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025932Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#737049}
-
Danyao Wang authored
Before this CL, autofill payment apps are always ranked below other types of payment apps, including just-in-time installable (but not yet installed) service-worker based pyament handler. This CL introduces a new payment app ranking order behind a feature flag such ranks payment apps first by types: 1. Installed 3rd-party payment handlers 2. Complete autofill instruments 3. Just-in-time installable 3rd-party payment handlers 4. Incomplete autofill instruments Within each group, payment apps are sorted by frecency as before. Bug: 1046875 Change-Id: I34ed0fec1f7b6fc4fbf8c6984d0893c3fad73443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028740 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737048}
-
Mikel Astiz authored
There are various "indices" and hence the name |index_| is somewhat ambiguous. Instead, let's be consistent with the class type it refers to, which is TitledUrlIndex. Change-Id: I0f2c38fdfe7b0a98d9d0b63c2526605c82bfaf40 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030769Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#737047}
-
Xiaoqian Dai authored
if mohnstrudel (#webui-tab-strip) is enabled. Mohnstrudel (#webui-tab-strip) will enabled on krane from M81 and other boards from M82. So window dragging from top and tab dragging will be disabled on krane from M81 and other boards from M82. Bug: 1041928 Change-Id: I1b071a190a669374906ff6ec16493dbec879d2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031668Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#737046}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/60ca7defc0eb..cf899c949229 git log 60ca7defc0eb..cf899c949229 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 tsepez@chromium.org Remove unused CPDF_TextState::GetShearAngle(), GetFontSizeV() 2020-01-30 tsepez@chromium.org Null out CXFA_FF* layout item reference in layout item dtor. Created with: gclient setdep -r src/third_party/pdfium@cf899c949229 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042915 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I9caf79477e70d79c4558e69ec3f17b7840bed12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031611Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737045}
-
Dominic Mazzoni authored
On Android, the virtual views in web content mimic their corresponding Android classes, and that includes returning the name of an Android class name as a string. This change fixes the class name for a static text node - it should correspond to an android.widget.TextView. That will enable the Accessibility Scanner to detect color contrast issues. Bug: 1046651 Change-Id: Ia579b83dafa0ce814be059282c594136a37bf33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026670Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#737044}
-
Chris Hamilton authored
This migrates all of the code in chromecast/ to use blink::WebMessagePort instead of directly manipulating Mojo pipes, and manually encoding messages. It preserves the existing APIs so that downstream dependents can migrate. A further CL will rip out the deprecated API. BUG=803242 Change-Id: I6f3b03dd982e4093804a63f8ad6086f14c2b58b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028148 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#737043}
-
Roger McFarlane authored
Bug: 1006806 Change-Id: I8cf16db179f7fc215db5f2a1bec81ce982663b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031670Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#737042}
-
Weiliang Chen authored
When OverlayProcessorAndroid tries to create the gpu thread part of processor, wait at the initialization to make it synchronous. R=khushal Bug: 979788, 1044671 Change-Id: I6f9c65a6710d7af30a096958b471f250b156722f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025643 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#737041}
-
Xinghui Lu authored
Currently on Android, there is only one button on the password reuse warning dialog, so only saved passwords are supported. It can be expanded to other types of passwords after another button is added. Bug: 1045495 Change-Id: I0570a3907c0ed3ef91228119ca5e73281198aaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026593Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737040}
-
Nicolas Ouellet-Payeur authored
Previously, CQ would pass if extractor.py failed at parsing the C++ declaration. With this CL, parsing errors make CQ turn red (to avoid committing code that will make linux-annotator-rel fail). Also, always rerun extractor.py when there's an error to get stderr contents. Previously, when running with --error-resilient, it wouldn't re-run the Clang tool. This saved several minutes on CQ, but didn't report a useful error message. Since extractor.py is _much_ faster, the tradeoff is different: the error message is more important than the couple of seconds saved. Finally: slightly improve extractor.py's error reporting when it fails to parse the annotation declaration. This makes it more actionable and gives better context to the CL author. TESTED=traffic_annotation_auditor_unittests, extractor_test.py, annotation_tokenizer_test.py Bug: 1046794 Change-Id: Id397dcfcced39fbebf72ffcdc6d6549c66c2910f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028707 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#737039}
-
Theodore Dubois authored
Ties are broken between rules with the same priority based on the action type. Add a test for this. Bug: 1026733 Change-Id: Ie5fcdad3c8843ba535619b0cb3ac4956bdd5a818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025082 Commit-Queue: Theodore Dubois <tbodt@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#737038}
-
Ben Pastene authored
Bug: 1047347 Change-Id: I0a2579e3c8458541b5800af9c1d45c2190296b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031558 Auto-Submit: Ben Pastene <bpastene@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#737037}
-
Xiaocheng Hu authored
Two WPT use CSSNumericValue.parse() to parse CSS pixel values, which makes the tests basically Chrome-only. This patch changes them to use parseFloat() directly so that other browsers can pass. Bug: 441925 Change-Id: I01d6d2999cf4266bd6d3bda521d2bdfc8732ab7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031932Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#737036}
-
Kenneth Russell authored
On macOS in particular, WebGL contexts allocated with alpha:false use RGBA textures bound to IOSurfaces behind the scenes, and on Intel GPUs, multisampled RGBA renderbuffers rather than RGB (the disable_webgl_rgb_multisampling_usage workaround). When the dynamic GPU switching handling logic for integrated -> discrete transitions reallocates the multisampled renderbuffer, clear its alpha channel to 1.0, as is done during framebuffer resizing. Add a new Pixel_WebGLLowToHighPowerAlphaFalse test which catches this bug, and make the previous Pixel_WebGLLowToHighPower test more correct and robust. Bug: 1034019 Change-Id: Ifb45cdad5a1b88f04700b429b774b6c4f49c6d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024279 Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#737035}
-
Oleg Davydov authored
After this commit: * For non-webstore policy force-installed extensions, write computed_hashes.json on installation. * If (according to computed_hashes.json) extension's resource is detected corrupted, this extension will be disabled and reinstalled. This applies only for policy force-installed extensions, and for webstore extensions it worked before this commit. This commit will NOT change behavior for already-installed extension. So, if some (non-webstore) extension was already corrupted, it will not be detected. The reason for this is that there is no source of truth for resources of already-installed non-webstore extension. It's possible to reinstall all previously-installed non-webstore extensions, but it's out of scope of this commit. See the bug for more details. Bug: 958794 Change-Id: Ie9c014e7fd998f4eae6e852a59bd692d57ff7d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012964 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#737034}
-
Alex Cooper authored
This simplifies the steps of ArCoreInstallHelper by: * Simplifying methods for steps that are not currently needed * Removing wrapper methods that only called one JNI method * Removing callbacks to private member methods, rather than having the Java-called-back method directly handle the result Bug: 1043224 Change-Id: I4f27ebe215ac3e3c8efa9b2ac80d56e46afa108a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029187 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#737033}
-
Reilly Grant authored
This change promotes the WebUSB chooser and notification interaction metrics to never expire as they are key indicators of how users are interacting with this feature. The WebUSB detector initialization time metric is retired as it is no longer measuring anything useful. Bug: 1037415 Change-Id: I528073e75548ee0abd4ff9cd2d955659df8cc5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028855 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#737032}
-
Sophie Chang authored
Bug: 1047082 Change-Id: I27478217a1723ff0b62ec7fa64e9ac2092554e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031535 Auto-Submit: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#737031}
-
Toni Barzic authored
On tablet mode start, update target app list visibility if app list is in show or showing state, and home should not be considered visible (e.g. because it's behind an app window). This handles an edge case where the app list starts showing in clamshell mode, and tablet mode switches before the app list animation finishes (i.e. before the app list gets focus). Given that there is no focus change when the app list view moves behind the app window, we do not update the app list visibility, and app list controller keeps thinking the home screen is visible (until the next focus change). BUG=1047430 Change-Id: I283fe9748dbd6fe83635babc9a141d7020f09f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029997 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#737030}
-
Austin Eng authored
This test is no longer flaky. Bug: 846547 Change-Id: Ia8062aa23eca080a7904a6ced767ffff888ff39f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029493 Auto-Submit: Austin Eng <enga@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#737029}
-
Zach Trudo authored
Gaia ID was incorrectly reported previously: 1. It was stored as an int when the obfuscated Gaia ID cannot be converted to an int. 2. It was then converted to an int64 in the proto. The proto symbol for Gaia ID will be deprecated and it's identifier will be reserved for future use. Removing the Gaia ID prior to deprecation. Bug: 1045967 Change-Id: I4c3477005788046408e3ae81f8ee37cfc1df17d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028211 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
-
Charlene Yan authored
This reverts commit f5a4e592. Reason for revert: Relanding with memory issues addressed Original change's description: > Revert "[Tab Groups] Implement time to switch histogram." > > This reverts commit 19b7b019. > > Reason for revert: Likely causing failures for TabHoverCardBubbleViewBrowserTest.WidgetNotVisibleOnClick > TabHoverCardBubbleViewBrowserTest.WidgetNotVisibleOnMousePressAfterTabFocus on Linux MSan > > Bug:1047172 > > Original change's description: > > [Tab Groups] Implement time to switch histogram. > > > > Records the amount of time in ms from the cursor entering the tabstrip > > to tapping on a tab to switch. > > > > Bug: 1040657 > > Change-Id: I438f53c3d3a83cead9a3feb0c62356e1322cf1c6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023396 > > Reviewed-by: Jesse Doherty <jwd@chromium.org> > > Reviewed-by: Connie Wan <connily@chromium.org> > > Commit-Queue: Charlene Yan <cyan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#736721} > > TBR=jwd@chromium.org,cyan@chromium.org,connily@chromium.org > > Change-Id: Iff213feb375e247f59ce79c72616abaf164a35d1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1040657 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030664 > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736842} TBR=jwd@chromium.org,ioanap@chromium.org,cyan@chromium.org,connily@chromium.org Change-Id: I6ebcffc8f0b0307ce0a3ff5598fab64a870af43b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047172, 1040657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031562Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737027}
-
John Chen authored
Rebaseline to fix a few web test failures on MacOS 10.14, due to added padding to input text related types introduced by r736729, which was submitted before MacOS 10.14 became a default trybot. TBR=wangxianzhu@chromium.org Bug: 1028242 Change-Id: I707514ef4cfd3e24cf6bbccf4d44b66c41a29772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031708Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737026}
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityAccessor::GetPrimaryAccountInfo() assumes the user has consented to browser sync. Assistant has its own consent. Drive doesn't have (or need) consent separate from Google account creation and sign-in. Switch to using the "unconsented" primary account, which exists whether or not the user has consented to browser sync. See go/cros-sync-mock and go/cros-primary-account for details. Bug: 1042400 Test: updated existing unit tests Change-Id: Ib368939c3a25ebd21db62955c1394197bf4f8d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023304Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#737025}
-
Mark Yacoub authored
1. Use const and pass by reference when appropriate. 2. Convert NULL to nullptr in the modified files. 3. Fix some file formatting to match clang. 4. Use default and explicit constructors where they should be 5. Remove unused SetCrtc overload. BUG=987274 TEST=HardwareDisplayControllerTest, HardwareDisplayPlaneManager*Test Change-Id: Ic0f019bfa862a5160805ecbfd22dc391e6f9f418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031864 Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#737024}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2f79dd4c2c7..7ea79fbc6f6f Created with: gclient setdep -r src-internal@7ea79fbc6f6f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046904 Tbr: jbudorick@google.com Change-Id: Idd406a06ebca19bfc23792133c4664a237ac3d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031636Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737023}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/670af2692e5d..8e998f17e0ce git log 670af2692e5d..8e998f17e0ce --date=short --first-parent --format='%ad %ae %s' 2020-01-30 srte@webrtc.org Fixes stall in SimulatedProcessThread 2020-01-30 ilnik@webrtc.org [VP9] Shift spatial layers on RTP level to always start from 0. Created with: gclient setdep -r src/third_party/webrtc@8e998f17e0ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4308d855a0fcc1f34504cdad5d4768e01d7aaa22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031635Reviewed-by:
-
Akihiro Ota authored
This change is a follow up to this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2018094 1. We remove the tree_id() method from the TreeWrapper and use GetTreeID() instead. 2. We use wrapper->GetNodeFromTree() instead of wrapper->tree()->GetFromId(). 3. We overload GetNodeFromTree to take fewer parameters. Change-Id: Icb2dd678ca10f1faf67ddc536351f1b51728f02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028734 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#737021}
-
Sahel Sharify authored
PaymentRequest.TransactionAmount.[Completed|Triggered] UMA metric records transaction amounts after converting them to USD and mapping them to one of the following three categories: 0$, <= 1$, or > 1$ This cl adds UKM for the same metric to enable analyzing transaction categories per origin. Bug: 970597 Change-Id: I6de11b41e4af4cf59a8c1422a39a17fb391ea4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025872Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737020}
-
Darwin Huang authored
Miscellaneous spellfixes. No functional changes. Mostly instances of "clipboard" and "synchronous", and one of "currently". Change-Id: Ic313394247301698afee43e6c96bdb5de3f38bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029458 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Ovidio Henriquez authored
This change adds the http/tests/devtools/persistence/persistence-move-breakpoints-on-reload.js web test to TestExpectations in order to allow the Mac10.13 Tests (dbg) Builder to be green. Bug: 1047420 TBR=ioanap@chromium.org,szuend@chromium.org,sigurds@chromium.org Change-Id: I86ccdb09994d7894176caf0968bc7fb8c63afca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031928Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#737018}
-
Mohamed Heikal authored
In addition to .pak files, //tools/grit/pak_util.py outputs .info files. This however is not reflected in the gn template list of outputs. This can cause errors with running ninja with '-d explain' after a successful build which the trybots do. Bug: 1045024 Change-Id: Id4e8915cff182f5d7c55cb947f4f2aa513ccc2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031530 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#737017}
-
Philip Rogers authored
The following tests need to be rebaselined after https://crrev.com/736729: fast/forms/form-element-geometry.html fast/forms/select/menulist-appearance-basic.html paint/invalidation/caret-subpixel.html paint/invalidation/details-open-repaint.html paint/invalidation/float-offscreen.html paint/invalidation/multi-layout-one-frame.html paint/invalidation/search-field-cancel.html paint/invalidation/subtree-root-skipped.html paint/invalidation/clip/caret-ancestor-clip-change.html paint/invalidation/scroll/caret-invalidation-in-overflow-scroll.html paint/invalidation/scroll/invalidate-caret-in-composited-scrolling-container.html paint/invalidation/scroll/invalidate-caret-in-non-composited-scrolling-container.html paint/invalidation/selection/selection-in-composited-scrolling-container.html paint/invalidation/selection/selection-in-non-composited-scrolling-container.html The following tests are newly failing and now have bugs filed: http/tests/subresource_filter/ad-highlight-frame-resized.html paint/pagination/composited-paginated-outlined-box.html Change-Id: Iee55b2d42925b77ac750e44c876b058c7c3e16bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031561 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Kevin Ellis authored
When there are composited animations in the process of being started, we defer the start of main thread animations in order to synchronize the start times. This process can lead to main thread animations getting stranded in the pending state if composited animations are being continuously generated. With this patch, main thread animations queued up in a previous frame will no longer get blocked waiting to synchronize with a fresh batch of composited animations. Bug: 666710 Change-Id: I21eb1184bbf636230991e09691498a190ccf8f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024476 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#737015}
-
nancy authored
The reason is CL:2006847 adds the checking whether the app exists in AppService. However, unrecognised Crostini apps should still load icons using AppServiceProxy, though they doesn't exist in AppService. So update the checking condition, and special handle the unrecognised Crostini apps, similar with the icon loading function. BUG=1047036 Change-Id: I80a3ae3704a9cc6e2e57df1fef53867aa731552a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029470 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/65137d177ac2..60ca7defc0eb git log 65137d177ac2..60ca7defc0eb --date=short --first-parent --format='%ad %ae %s' 2020-01-30 thestig@chromium.org Change JpegModule::LoadInfo() to return an optional struct. 2020-01-30 thestig@chromium.org Merge ICC components validation code into CPDF_ColorSpace. Created with: gclient setdep -r src/third_party/pdfium@60ca7defc0eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I891cd02e891e2d0a2bb60db83be422e6272da698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031632Reviewed-by:
-
Mehran Mahmoudi authored
This CL implements async desalinization of PaintPreviewProto in PaintPreviewBaseService. This can be used by implementers of PaintPreviewBaseService, if they store the proto on disk. Bug: 1043267 Change-Id: I6739b3122ef23a9b6a47c1358013f55dca7301fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006256 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#737012}
-
Meilin Wang authored
This change enables the mode switch between signed-in and signed-out for Liassbistant when user enters/exits the ambient mode, so that we can further explore the behavior of signed-out mode. Bug: none. Test: run unittest added in this change Change-Id: Idcb4903401173b8f86a3428a0f452b5ce9b7a5ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995804 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#737011}
-
Joshua Bell authored
The type was refcounted, but only ever had a single owner (StoragePartitionImpl). Change the ownership to unique_ptr and slightly simplify the class. Change-Id: Idaed9b5b0443982731b6a78c0027a959014d354c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028731 Commit-Queue: Joshua Bell <jsbell@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Reviewed-by:
-
