GitLab

Apps cannot handle files via WebIntents declarations anymore.

BUG=173194


Review URL: https://chromiumcodereview.appspot.com/12218136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182329 0039d316-1c4b-4281-b951-d872f2087c98

BUG=176122
TBR=kalman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/12256025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182328 0039d316-1c4b-4281-b951-d872f2087c98

xp-release-single-core/intl1/times: http://build.chromium.org/f/chromium/perf/xp-release-single-core/intl1/report.html?history=150&rev=178582

TBR=cmp@chromium.org
BUG=176133
Review URL: https://codereview.chromium.org/12253016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182327 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182324 0039d316-1c4b-4281-b951-d872f2087c98

Getting rid of SpdyFramer::GetControlFrameStreamId(), which cleans up the code and also makes it easier to move forward with SPDY 4 work.

This lands server change 42008414.

Review URL: https://codereview.chromium.org/12207148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182323 0039d316-1c4b-4281-b951-d872f2087c98

Revert 182318 - Broke linux build: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Builder/builds/18695/steps/compile/logs/stdio
> ExtensionInstallDialog should create the accept button if it requested in prompt.GetDialogButtons().
> 
> BUG=175897
> TEST=NONE
> 
> Review URL: https://chromiumcodereview.appspot.com/12208144

TBR=ncj674@motorola.com
Review URL: https://codereview.chromium.org/12207163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182322 0039d316-1c4b-4281-b951-d872f2087c98

1570: mac strip test: Update expectations for Xcode 4 toolchain.
1571: xcodebuild: Fix most rebuild tests on Xcode 4.
1572: xcode tests: Update exit codes for Xcode 4.
1573: Fix test/mac/gyptest-app.py with Xcode 4.2.
1574: xcode: Add support for storyboard files
1575: Detect all ninja's include dirs in Eclipse generator.

BUG=none
TBR=mark

Review URL: https://codereview.chromium.org/12261016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182321 0039d316-1c4b-4281-b951-d872f2087c98

On OS_CHROMEOS when the permission_broker checks a set of devices the
UsbService needs to wait for the async work to complete before responding.
This worked on OS_CHROMEOS desktop builds because the stub implementation of
PermissionBrokerClient wasn't racing to modify the devices vector.

BUG=chromium-os:38836

Review URL: https://chromiumcodereview.appspot.com/12226137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182320 0039d316-1c4b-4281-b951-d872f2087c98

Pyauto is deprecated. We'll add some of these tests back as browser
tests. Some don't make sense because they are very specific to Google
and not Chrome Instant generally (such as the case insensitivity test).

We're not losing much test coverage here because many of these tests
already exist as browser tests (e.g.: testing that Instant doesn't
preview URLs, testing a non-Instant supporting engine).

BUG=165843,168809
R=phajdan.jr@chromium.org
TEST=none

Review URL: https://chromiumcodereview.appspot.com/12223125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182319 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionInstallDialog should create the accept button if it requested in prompt.GetDialogButtons().

BUG=175897
TEST=NONE

Review URL: https://chromiumcodereview.appspot.com/12208144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182318 0039d316-1c4b-4281-b951-d872f2087c98

Browsers built prior to r176905 don't support the tracing mechanism used by telemetry.
Prevent the test from failing, since this is an expected scenario.

BUG=170284
TEST=tools/telemetry/run_tests --browser=android-content-shell testGotTrace -vv


Review URL: https://chromiumcodereview.appspot.com/11931015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182317 0039d316-1c4b-4281-b951-d872f2087c98

* Browser has new properties supports_extensions and extensions (of type ExtensionDict)
* BrowserBackend ctor takes additional arg supports_extensions. 
* BrowserBackend has new properties supports_extensions and extension_dict_backend (of type ExtensionDictBackend)
* BrowserBackend._WaitForBrowserToComeUp waits for all extensions to load and be interactive.
* BrowserBackend.ExtensionsNotSupportedException is raised for android browser and content shell.
* Add class ExtensionToLoad which is a wrapper for an extension_path.
* Add extension_to_load (of type ExtensionToLoad) to BrowserOptions.
* Add SupportsOptions to PossibleBrowser, to test extensions support. Returns False for android and content_shell when BrowserOptions.extensions_to_load is not empty 
* Add ExtensionPage which derives from WebContents
* Add ExtensionDictBackend which is a dictionary of ExtensionPage instances with extension ids as keys.
* Add ExtensionDict which passes through to ExtensionDictBackend, except it uses ExtensionToLoad instances as keys.
* Import crx_id for determining extension id from extension path.
* Simple extension manifest.json and background.js for unit tests.
* Unit tests for single and multiple extensions.

BUG=169954
TEST=browser test.
Review URL: https://codereview.chromium.org/11882033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182316 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182315 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175935
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/12255014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182314 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=run_tests
Review URL: https://codereview.chromium.org/12253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182313 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/12217143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182312 0039d316-1c4b-4281-b951-d872f2087c98

it's failing flakily on the Chrome OS ASAN bots.

BUG=176082
TBR=satorux@chromium.org

Review URL: https://codereview.chromium.org/12257015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182311 0039d316-1c4b-4281-b951-d872f2087c98

Storing MPEG-4 B-frames in AVI has always been a bit of a hack and by default av_read_frame() will return non-timestamped video packets for such content. AVFMT_FLAG_GENPTS takes advantage of AVI's constant framerate to generate presentation timestamps at the expense of parsing delay.

BUG=169570

Review URL: https://codereview.chromium.org/12209111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182310 0039d316-1c4b-4281-b951-d872f2087c98

This has to be committed *after* https://codereview.chromium.org/12221127/

BUG=161094


Review URL: https://chromiumcodereview.appspot.com/12218109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182309 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174097
TEST=manually checked on goobuntu

Review URL: https://codereview.chromium.org/12248012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182307 0039d316-1c4b-4281-b951-d872f2087c98

This is split out from https://codereview.chromium.org/11881042

BUG=124830
TEST=None

Review URL: https://codereview.chromium.org/12087017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182305 0039d316-1c4b-4281-b951-d872f2087c98

BUG=173262

Review URL: https://codereview.chromium.org/12263016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182304 0039d316-1c4b-4281-b951-d872f2087c98

> Verify the signature on user cloud policy downloads.
> 
> The signature on the user cloud policy blob is already verified by the session
> manager on ChromeOS, but should also be verified by Chrome before storing new
> policy, and after loading policy from the cache.
> 
> BUG=174015
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12183017

TBR=joaodasilva@chromium.org
Review URL: https://codereview.chromium.org/12255017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182302 0039d316-1c4b-4281-b951-d872f2087c98

A Callback decides when it is constructed whether it needs to do a weak pointer
check when called.  Therefore, pass the weak pointer of NetErrorTabHelper to
base::Bind when we create the callback instead of binding it later in
StartDnsProbe.

BUG=174720

Review URL: https://chromiumcodereview.appspot.com/12223080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182301 0039d316-1c4b-4281-b951-d872f2087c98

Random changes have been breaking Android bots. It turns
out async uploads isn't the issue, but rather simply that
old ICS Imagination drivers crash on glTexSubImage2D (very
consistantly).

This enables async uploads again, but also puts in a
work-around in our work-around :). When we fallback
to glTexSubImage2D, we use glTexImage2D instead.

BUG=174440
NOTRY=True

Review URL: https://codereview.chromium.org/12221161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182299 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 182242
> > Files.app: Add missing JSdoc for member methods/variables #1.
> > 
> > All the changes are in comment. No semantics are changed.
> > 
> > BUG=175657
> > TEST=none
> > TBR=mtomasz@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/12254009
> 
> TBR=yoshiki@chromium.org
> Review URL: https://codereview.chromium.org/12254015

TBR=rdsmith@chromium.org
Review URL: https://codereview.chromium.org/12262017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182298 0039d316-1c4b-4281-b951-d872f2087c98

This improves the performance of removing a tile from the list to O(1) from O(n).  The O(n) removal time was showing up as lag spikes in a trace.

BUG=175939

Review URL: https://codereview.chromium.org/12207146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182297 0039d316-1c4b-4281-b951-d872f2087c98

Fix for change in crrev.com/182280. These files are not used in any
upstream build.

BUG=

Review URL: https://codereview.chromium.org/12258017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182295 0039d316-1c4b-4281-b951-d872f2087c98

> Ensure that when themes in desktop chrome AURA on Windows use the opaque browser frame view.
> 
> To achieve this we need to mimic the implementation in BrowserFrameWin::ShouldUseNativeFrame in the
> DesktopBrowserFrameAura::ShouldUseNativeFrame override.
> 
> The code in BrowserFrameWin::ShouldUseNativeFrame has been moved to a helper function in the browser namespace
> ShouldUseNativeFrame in the newly added files browser_frame_common_win.h/.cc. This is invoked from BrowserFrameWin
> and from the BrowserDesktopRootWindowHostWin::ShouldUseNativeFrame override which is invoked via the
> DesktopBrowserFrameAura::ShouldUseNativeFrame override for AURA
> 
> BUG=175372
> R=sky
> Review URL: https://codereview.chromium.org/12251010

TBR=ananta@chromium.org
Review URL: https://codereview.chromium.org/12257014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182294 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes the chrome://policy page respect embedded line breaks in
long policy values, fixing the appearance of pretty-printed string policy
values.

BUG=175999
TEST=Manual


Review URL: https://chromiumcodereview.appspot.com/12230012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182293 0039d316-1c4b-4281-b951-d872f2087c98

Adding guillemotleft, guillemotright and degree condition into
KeyboardCodeFromXKeysym.
These KeySym is used in Canadian French keyboard.

BUG=175624
TEST=Checked with typing international-backslash key on Canadian French keyboard.


Review URL: https://chromiumcodereview.appspot.com/12211127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182292 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175760
TBR=jianli@chromium.org

Review URL: https://codereview.chromium.org/12223100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182290 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/12211102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182288 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158004
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12209094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182287 0039d316-1c4b-4281-b951-d872f2087c98

> Files.app: Add missing JSdoc for member methods/variables #1.
> 
> All the changes are in comment. No semantics are changed.
> 
> BUG=175657
> TEST=none
> TBR=mtomasz@chromium.org
> 
> Review URL: https://codereview.chromium.org/12254009

TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/12254015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182285 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/12223082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182284 0039d316-1c4b-4281-b951-d872f2087c98

This will also help when deploying SPDY wire format changes,
such as those upcoming in SPDY 4.

This lands server change 41941878.

Review URL: https://codereview.chromium.org/12224137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182283 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nirnimesh@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12217137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182282 0039d316-1c4b-4281-b951-d872f2087c98

To achieve this we need to mimic the implementation in BrowserFrameWin::ShouldUseNativeFrame in the
DesktopBrowserFrameAura::ShouldUseNativeFrame override.

The code in BrowserFrameWin::ShouldUseNativeFrame has been moved to a helper function in the browser namespace
ShouldUseNativeFrame in the newly added files browser_frame_common_win.h/.cc. This is invoked from BrowserFrameWin
and from the BrowserDesktopRootWindowHostWin::ShouldUseNativeFrame override which is invoked via the
DesktopBrowserFrameAura::ShouldUseNativeFrame override for AURA

BUG=175372
R=sky
Review URL: https://codereview.chromium.org/12251010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182281 0039d316-1c4b-4281-b951-d872f2087c98

To implement CertVerifyProc on Android we refer to the Java 
side to query the platform trust managers. Currently the 
information we get from the platform is binary - each 
certificate chain is either identified as trusted or not, in 
which case we assume that this is due to not-trusted root.

This patch provides better granularity distinguishing the 
following cases: expired, not yet valid, incorrect (could not 
be parsed), not trusted root.

This allowed to reenable two net unittests:
- CertVerifyProcTest.ExtraneousMD5RootCert
- CertVerifyProcTest.IntermediateCARequireExplicitPolicy

The following net unittest had to be disabled as it joins 
the club of CertVerifyProc tests failing on bots with 
incorrect time/date settings:
- CertVerifyProcTest.InvalidKeyUsage

BUG=169762

Review URL: https://chromiumcodereview.appspot.com/12212135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182280 0039d316-1c4b-4281-b951-d872f2087c98