GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271970 0039d316-1c4b-4281-b951-d872f2087c98

Syncs to head as of bebce653e5601ceafa004db0eb6b2c7d4d16f0c0.  The
roll requires us to stop using some deprecated features:
- Replaces av_get_frame_defaults() with av_frame_unref() per docs.
- Switches FFmpegVideoDecoder to use ref-counted frames.
- Removes error concealment settings and disables error resilience
for all platforms except ChromeOS (since it's required for mpeg4).

Avoiding these also allows us to disable some deprecated features
wholesale via #defines.

BUG=119020,236611
TEST=all tests (and regression tests) pass under asan
NOTRY=true
R=jrummell@chromium.org, wolenetz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271945

Review URL: https://codereview.chromium.org/286953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271969 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/296153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271968 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=armansito@chromium.org, kalman@chromium.org

Review URL: https://codereview.chromium.org/275863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271967 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the logic to determine whether the Translate bubble is
to be shown. Before this CL, it is not considered the case when the
contents web view is NOT focused. This CL changes this logic to show the
bubble when the content webview and an input element is focused and the
user is NOT trying to show the bubble explicitly. The latter condition
is checked by GetLocationBarView()->IsMouseHovered() because just after
clicking the Translate icon on the Omnibox, the content web view might
still be focused.

BUG=372755
TEST=manual

Review URL: https://codereview.chromium.org/289983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271966 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TBR=armansito

Review URL: https://codereview.chromium.org/294163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271965 0039d316-1c4b-4281-b951-d872f2087c98

Mark conformance/context/context-lost-restored.html as fail on win.

(although it's win debug only, we haven't been able to separate debug from release yet)

BUG=374378
TEST=win debug bots
TBR=bajones@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/299713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271964 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375840
TBR=haitaol@chromium.org

Review URL: https://codereview.chromium.org/292153007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375894
TBR=zea@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/294903009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271962 0039d316-1c4b-4281-b951-d872f2087c98

The issue was that we were posting an asynchronous accessibility event on
the menu item view, and the menu item view was still around after the menu
closed (just hidden, and owned by the menu runner), but the menu item view's
delegate (the menu model adapter) had gone out of scope.

BUG=327510
NOTRY=true

Review URL: https://codereview.chromium.org/295903006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271961 0039d316-1c4b-4281-b951-d872f2087c98

Check whether the extension exists again in OnImageLoaded before
showing the unstall dialog.

R=mek@chromium.org,kalman@chromium.org
BUG=375036
TEST=manual

Review URL: https://codereview.chromium.org/293603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271960 0039d316-1c4b-4281-b951-d872f2087c98

Before, if a modification time was InvalidDate, then it caused a crash on
a DCHECK converting a string date to base::Time.

Providers may return an incorrect date, and we shouldn't crash. This patch
resolves this issue by removing the DCHECK and passing the invalid date
to fileapi.

TEST=unit_test: *FileSystemProvider*GetMetadata*
BUG=248427

Review URL: https://codereview.chromium.org/295933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271959 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271958 0039d316-1c4b-4281-b951-d872f2087c98

TEST=manual: Force a reset (manually edit a protected pref).
Expect to see reset UI in chrome://settings,
dismiss it, restart Chrome, expect no reset UI.
BUG=374360

Review URL: https://codereview.chromium.org/294123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271957 0039d316-1c4b-4281-b951-d872f2087c98

Broke gclient runhooks on Linux ChromiumOS Builder on Blink waterfall.
Bugs 119020 and 236611 will be updated with details.

> Roll FFmpeg for M37.
> 
> Syncs to head as of bebce653e5601ceafa004db0eb6b2c7d4d16f0c0.  The
> roll requires us to stop using some deprecated features:
> - Replaces av_get_frame_defaults() with av_frame_unref() per docs.
> - Switches FFmpegVideoDecoder to use ref-counted frames.
> - Removes error concealment settings and disables error resilience
> for all platforms except ChromeOS (since it's required for mpeg4).
> 
> Avoiding these also allows us to disable some deprecated features
> wholesale via #defines.
> 
> BUG=119020,236611
> TEST=all tests (and regression tests) pass under asan
> NOTRY=true
> R=jrummell@chromium.org, wolenetz@chromium.org
> 
> Review URL: https://codereview.chromium.org/286953005

TBR=dalecurtis@google.com

Review URL: https://codereview.chromium.org/296483012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271956 0039d316-1c4b-4281-b951-d872f2087c98

Changes from the first submit:
- Submit a binary image file separately by dcommit in advance

Original description:
On Android, permission infobar appears for Web MIDI permission,
but correct icon is not used. This change add a proper icon.

BUG=339767

Review URL: https://codereview.chromium.org/292743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271955 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375853
TEST=This is test. Ran tests manually.

Review URL: https://codereview.chromium.org/288263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271954 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271953 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271952 0039d316-1c4b-4281-b951-d872f2087c98

These are disabled currently in the Android ARM GYP build. This patch disables it for all ARM builds since the warning appears when cross-compiling to ARM on Linux without Android (this isn't something people normally compile, so probably nobody noticed).

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/299663014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271951 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174386:174434&mode=html
TBR=
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/294153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271950 0039d316-1c4b-4281-b951-d872f2087c98

Most code uses PLOG with the same effect.

TBR=bradchen
NOTRY=true

Review URL: https://codereview.chromium.org/281223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271949 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374942

Review URL: https://codereview.chromium.org/295803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271948 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:399

All of the code reviews for this patch were written against https://codereview.chromium.org/251933005/ . I used the wrong email address to create said patch, so I have created this one with the correct email address.

Review URL: https://codereview.chromium.org/288193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271947 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271946 0039d316-1c4b-4281-b951-d872f2087c98

Syncs to head as of bebce653e5601ceafa004db0eb6b2c7d4d16f0c0.  The
roll requires us to stop using some deprecated features:
- Replaces av_get_frame_defaults() with av_frame_unref() per docs.
- Switches FFmpegVideoDecoder to use ref-counted frames.
- Removes error concealment settings and disables error resilience
for all platforms except ChromeOS (since it's required for mpeg4).

Avoiding these also allows us to disable some deprecated features
wholesale via #defines.

BUG=119020,236611
TEST=all tests (and regression tests) pass under asan
NOTRY=true
R=jrummell@chromium.org, wolenetz@chromium.org

Review URL: https://codereview.chromium.org/286953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271945 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375910
R=zea@chromium.org

Review URL: https://codereview.chromium.org/296933004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271944 0039d316-1c4b-4281-b951-d872f2087c98

Remove chrome_official_builder's dependency on pdf. I don't see why it's needed, since the chrome target depends on pdf.

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/293083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271943 0039d316-1c4b-4281-b951-d872f2087c98

--fatal-warnings don't seem to be supported. This also adds support for mach_logging files which were added recently.

BUG=
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/295023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271942 0039d316-1c4b-4281-b951-d872f2087c98

Adds a protobuf target and a template for defining protos. This handles doing host builds of protoc when cross-compiling.

The command buffer sevice wants more optimization on Android, so this patch generalizes the solution. Normally Android, like Windows, optimizes for size. This now adds support on Android for speed optimization just like Windows does. Mac & Linux always optimize for speed.

Removes the declare_args call around the gcc_version. This was parameterized to be different if is_android was set, which isn't valid because build parameters can't vary across toolchains. Since this value is derived from the environment, I just removed the declare_args call.

BUG=
R=piman@chromium.org

Review URL: https://codereview.chromium.org/289953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271941 0039d316-1c4b-4281-b951-d872f2087c98

This appears to be a vestigal part of some StreamAsFile() operation that no
longer exists. It's not necessary to cache this file info in the plugin, as we
only ever return it once.

I've split this off from a bigger StreamAsFile() refactoring to make the diff
smaller, to help debug Windows failures on that patch.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/297763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271940 0039d316-1c4b-4281-b951-d872f2087c98

This is not perfect, as some function names are still to long. But it improves
most of them.

I've also added the ability to specify the chromesite template to use from
within the .rst file.

BUG=374811
TEST=locally ran the server
R=kalman@chromium.org, sbc@chromium.org

Review URL: https://codereview.chromium.org/299753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271937 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/298563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271936 0039d316-1c4b-4281-b951-d872f2087c98

Fixes dependency ordering to get libjingle style overrides working for webrtc. See http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Linux/builds/5887/steps/compile/logs/stdio. Tested it locally.

BUG=N/A
R=hellner@chromium.org

Review URL: https://codereview.chromium.org/293983009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271935 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271934 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=62&start=14827

R=reed@google.com
TBR=reed@google.com, robertphillips@google.com, zea@chromium.org

Review URL: https://codereview.chromium.org/294903008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271933 0039d316-1c4b-4281-b951-d872f2087c98

Fails flakily on Android.

BUG=375838
R=johnme@chromium.org

Review URL: https://codereview.chromium.org/296933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271929 0039d316-1c4b-4281-b951-d872f2087c98

Per discussion, allows kInfiniteDuration() for the front DiscardPadding
value.  When there's no decoder delay, this ensures accuracy when
discarding.  If decoder delay is present, the code falls back to using
the duration as an estimation.

BUG=371633
TEST=new unittests
NOTRY=true
R=wolenetz@chromium.org

Review URL: https://codereview.chromium.org/293053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271928 0039d316-1c4b-4281-b951-d872f2087c98

Changes in preparation for upcoming preroll_buffer() method.

BUG=none
TEST=none
NOTRY=true
R=wolenetz@chromium.org

Review URL: https://codereview.chromium.org/294043007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271927 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Unload all apps / extensions when deleting a profile. (https://codereview.chromium.org/266343002/)

Reason for revert:
Caused crash in official builds when deleting profiles while the chrome:chrome-signin tab is open

BUG=374683
TBR=kalman, sky

Original issue's description:
> Unload all apps / extensions immediately when deleting a profile.
>
> Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile.
>
> Relanding patch: ShutdownStartupCycle failed in build [49353], this patch was speculatively reverted in r269383 [49355], but ShutdownStartupCycle failed again in [49362] after the revert had landed.
>
> [49353] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49353
> [49355] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49355
> [49362] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49362
>
> BUG=368684
> TEST=Manual testing as described on http://crbug.com/368684#c1
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269343
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270890

Review URL: https://codereview.chromium.org/289283013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271926 0039d316-1c4b-4281-b951-d872f2087c98