GitLab

Fails TouchEditableImplAuraTest.TouchCursorInTextfieldTest on Win7. See
http://crbug.com/377561#c4 for details.

> Enable touch text selection tests on all Aura platforms
> 
> In order to make touch text selection ready for Windows and other Aura
> platforms, a prerequisite is to enable tests. Following tests are
> enabled:
>  - TouchSelectionControllerImplTest in views_unittests;
>  - TouchEditableImplAuraTest in content_browsertests.
> 
> BUG=377561
> 
> Review URL: https://codereview.chromium.org/304883002

TBR=mohsen@chromium.org

Review URL: https://codereview.chromium.org/304253007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273805 0039d316-1c4b-4281-b951-d872f2087c98

Disabled the test on all platforms now because it fails on ChromeOS now as
well.

BUG=375910
TBR=sergiu@chromium.org

Review URL: https://codereview.chromium.org/304233008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273803 0039d316-1c4b-4281-b951-d872f2087c98

When docking is possible, but main window is undocked, we show toolbox
web contents. This means that undocked DevTools has two web contents
at the same time: one in a separate window, and one near the inspected tab.

BUG=327641

Review URL: https://codereview.chromium.org/294903014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273802 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/304393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273801 0039d316-1c4b-4281-b951-d872f2087c98

These executables are failing on Windows in Debug mode, very likely
because they're missing the Visual Studio runtime DLLs.

BUG=378021
TBR=maruel@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/302003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273800 0039d316-1c4b-4281-b951-d872f2087c98

'pending version' seems outdated naming and the current spec uses
'installing version' or 'waiting version' instead.
This renames them mechanically.

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/


BUG=379012
TEST=compile

Review URL: https://codereview.chromium.org/309453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273799 0039d316-1c4b-4281-b951-d872f2087c98

Reverting due to failing memory bots, see http://crbug.com/235263#c42 for
details.

> Add garbage collection for shared extensions on Chrome OS
> 
> Chrome OS specific garbage collection in addition to profile specific
> clean up also cleans up shared location but only once regardless number
> of logged in users.
> 
> BUG=235263
> TEST=unittest
> 
> Review URL: https://codereview.chromium.org/303693011

TBR=dpolukhin@chromium.org

Review URL: https://codereview.chromium.org/306023007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273798 0039d316-1c4b-4281-b951-d872f2087c98

BUG=n/a
TEST=lint

Review URL: https://codereview.chromium.org/308663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273797 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/302063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273796 0039d316-1c4b-4281-b951-d872f2087c98

This patch enables the following switches for mac:
--enable-ephemeral-apps
--enable-linkable-ephemeral-apps

BUG=375027
TEST=browser_tests, unit_tests

Review URL: https://codereview.chromium.org/303053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273795 0039d316-1c4b-4281-b951-d872f2087c98

When Files.app receives 'dragstart', it cancels file drag operation in some situations.
In these cases, 'dragend' or other drag-related events won't be dispatched.
Missing 'dragend' causes this issue.
'drag' is dispatched only when 'dragstart' is not cancelled, so we can take it as start of user's drag operation.

BUG=326981
TEST=manually confirmed

Review URL: https://codereview.chromium.org/307863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273794 0039d316-1c4b-4281-b951-d872f2087c98

This removes an aura dependency in webview/web_dialog_view.cc and is a
step towards getting the views_examples target compiling on Mac.

NativeWidget::GetEventHandler isn't used elsewhere.

Pre-Aura Win would use ::DefWindowProc() in
WebDialogView::HandleKeyboardEvent(), so NativeWidget feels like the
right place for this.

BUG=366007
TEST=Just refactoring

Review URL: https://codereview.chromium.org/307623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273793 0039d316-1c4b-4281-b951-d872f2087c98

Once this CL is committed, we need to change the server side config to include
new trial types and remove the expid.

BUG=None

Review URL: https://codereview.chromium.org/300063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273792 0039d316-1c4b-4281-b951-d872f2087c98

Get the default command if there was no Linux Aura command.
Similar to RenderWidgetHostViewAura::ForwardKeyboardEvent
(forwards the raw key event if there is no matching command)

TODO(followup): Add more complete GTK command coverage.
(Elliot noted this might not be worthwhile at the moment)

BUG=377355
TEST=[Shift+]Ctrl+Z invokes Undo/Redo in the Linux Aura omnibox.
R=oshima@chromium.org,erg@chromium.org

Review URL: https://codereview.chromium.org/307783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273791 0039d316-1c4b-4281-b951-d872f2087c98

This switch is not used. Remove it.

Review URL: https://codereview.chromium.org/302633012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273790 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378911

Review URL: https://codereview.chromium.org/306923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273788 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378050,245025

Review URL: https://codereview.chromium.org/294393009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273787 0039d316-1c4b-4281-b951-d872f2087c98

Windows stores system color profiles on disk. To avoid disk reads
and the jank that that can cause, add a color profile cache keyed
by device name.

Here define/implement the cache interface. Make the cache thread-
safe to allow safe access from any blocking pool thread.

The cache key is a wide string for now and I might change that to
an int64 device id in a subsequent patch, we'll see.

BUG=368694

Review URL: https://codereview.chromium.org/293393008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273786 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378012

Review URL: https://codereview.chromium.org/304083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273785 0039d316-1c4b-4281-b951-d872f2087c98

Use the local state instead of a pref belonging to a Profile.
Save the time mapping when the network time is updated, load the saved time in the ctor.
Delay initialization of BrowserProcess::network_time_tracker_ to access the local state.

BUG=371470
TEST=git cl try

Review URL: https://codereview.chromium.org/291333009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273784 0039d316-1c4b-4281-b951-d872f2087c98

Make the VideoDetector FullscreenWindow test use
GetWindowState() to access WindowState objects. Otherwise,
the WindowStates don't get unregistered as WindowObservers
when they're destroyed. This was responsible for the test
crashes that resulted in r266681 being reverted.

BUG=365364

Review URL: https://codereview.chromium.org/303163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273783 0039d316-1c4b-4281-b951-d872f2087c98

Modified the certificate details viewers to include the timezone in the certificates validity dates.

Now when you check the certificate details and go to validity you will find the creation and expiration times reported in UTC timezone.

BUG=200243
R=jww@chromium.org

Review URL: https://codereview.chromium.org/299323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273782 0039d316-1c4b-4281-b951-d872f2087c98

This is consistent with FramedBrowserWindow.

This also skips drawing the frame of frameless windows.

On OSX 10.7, if NSTexturedBackgroundWindowMask is set, NSGrayFrame is
used to draw the frame. If not, NSThemeFrame is used. Since we swizzle
drawing methods on NSGrayFrame on 10.7, the app windows should all use
NSGrayFrame.

BUG=378581

Review URL: https://codereview.chromium.org/307843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273781 0039d316-1c4b-4281-b951-d872f2087c98

It would be nice to know if a notification is pending, so this patch
adds this ability. This would be used in RenewTreePriority to detect
whether we should be in smoothness mode or same priority mode. That is,
if we have an expiration from smoothness pending, then we should still
be in smoothness mode.

R=reveman

Review URL: https://codereview.chromium.org/302003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273780 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds a utility function which converts a base::File::Error code
to a human readable form. It will be used for logging request errors in the
File System Provider API.

TEST=Not used yet.
BUG=376095

Review URL: https://codereview.chromium.org/308613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273779 0039d316-1c4b-4281-b951-d872f2087c98

Give untyped bookmarked URLs a boost.
(Change the default value of an untyped visit to a bookmark from 1 to 10.  A typed visit still scores 20.)

This has evaluated positively.

BUG=330214,247715

Review URL: https://codereview.chromium.org/307003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273778 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373275

Review URL: https://codereview.chromium.org/307733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273777 0039d316-1c4b-4281-b951-d872f2087c98

Revert of cc: Make heavy layer tree test more realistic (https://codereview.chromium.org/305903003/)

Reason for revert:
Actually what we had was working fine.

Original issue's description:
> cc: Make heavy layer tree test more realistic
> 
> The heavy layer tree test is supposed to simulate a complex layer tree
> with transform animation. Currently it does so by forcing repaint of all
> layers, but we should only really animate layer transforms to better
> match reality.
> 
> BUG=348100
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273646

TBR=enne@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=348100

Review URL: https://codereview.chromium.org/306023006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273776 0039d316-1c4b-4281-b951-d872f2087c98

Reverting due to several memory leaks. See http://crbug.com/322707#c11 for
details.

> Change instances of s.IsCorruption() to leveldb_env::IsCorruption(s).
> 
> LevelDB sometimes returns Status::InvalidArgument() when it encounters
> corruption. But LevelDB doesn't provide a Status::IsInvalidArgument()
> accessor so we need to indirectly detect it.
> 
> This patch revealed that IndexedDBDatabaseOperationTest.CreatePutDelete
> had been passing by accident. In order to make it continue to pass, this
> patch adds a method to IndexedDBFakeBackingStore.
> 
> BUG=322707
> 
> Review URL: https://codereview.chromium.org/303073002

TBR=dgrogan@chromium.org

Review URL: https://codereview.chromium.org/301973008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273773 0039d316-1c4b-4281-b951-d872f2087c98

Make the contextual search flag tri-state.  This allows users to opt-out even if they're in the Finch trial.

BUG=378999

Review URL: https://codereview.chromium.org/304253005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273772 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379002

Review URL: https://codereview.chromium.org/307943008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273771 0039d316-1c4b-4281-b951-d872f2087c98

In order to make touch text selection ready for Windows and other Aura
platforms, a prerequisite is to enable tests. Following tests are
enabled:
 - TouchSelectionControllerImplTest in views_unittests;
 - TouchEditableImplAuraTest in content_browsertests.

BUG=377561

Review URL: https://codereview.chromium.org/304883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273770 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378516
NOTRY=true

Review URL: https://codereview.chromium.org/304093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273769 0039d316-1c4b-4281-b951-d872f2087c98

See crbug.com/363459 for details.

TBR=jiayl@chromium.org

Review URL: https://codereview.chromium.org/307063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273767 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/304423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273766 0039d316-1c4b-4281-b951-d872f2087c98

This allows most callers to pass string literals or results of ASCIIToUTF16(),
rather than construct error-prone character arrays that must be manually
nul-terminated.

Also cleans up various bits of the callers.

BUG=104260
TEST=none

Review URL: https://codereview.chromium.org/296593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273765 0039d316-1c4b-4281-b951-d872f2087c98

We shouldn't be dispatching RenderFrameCreated for swapped out frames.

BUG=378889

Review URL: https://codereview.chromium.org/301973006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273764 0039d316-1c4b-4281-b951-d872f2087c98

Chrome OS specific garbage collection in addition to profile specific
clean up also cleans up shared location but only once regardless number
of logged in users.

BUG=235263
TEST=unittest

Review URL: https://codereview.chromium.org/303693011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273763 0039d316-1c4b-4281-b951-d872f2087c98

This will allow Blink-side to provide a body in its responses to
fetch events.

BUG=374123
R=michaeln@chromium.org, mmenke@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/293083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273762 0039d316-1c4b-4281-b951-d872f2087c98

BUG=358657
R=yurys@chromium.org
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/299693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273761 0039d316-1c4b-4281-b951-d872f2087c98