GitLab

Test: Manually installed packages to make sure no conflict

This is a reland of 5b267c0c
Original change's description:
> Add libdconf-dev to to install-build-deps.sh
> 
> This is the first step in moving from using gconf to dconf.
> 
> Bug: 768027
> Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e
> Reviewed-on: https://chromium-review.googlesource.com/691097
> Commit-Queue: Tim Brown <timbrown@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505183}

Bug: 768027
Change-Id: I151d1c1e708fa763f3d2d5a4a18b44bfdbe351fd
Reviewed-on: https://chromium-review.googlesource.com/692616Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505437}

AdjustStyleForHTMLElement might set display:none. This can happen for a HTMLImageElement
that returns true for IsCollapsed(). Therefore the condition should be checked again.

Bug: 768546
Change-Id: I77b441a19f713018b89afa4f460501f9ca96275a
Reviewed-on: https://chromium-review.googlesource.com/683006Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Balazs Kelemen <b.kelemen@samsung.com>
Cr-Commit-Position: refs/heads/master@{#505436}

Transport streams allow for zero-length packets, while
the es_parser does not. I was not able to find out which
is correct from the spec, so I chose the change that
is most permissive and allow the zero-length packets.

Bug: 768114
Change-Id: I34fd1a7f1adf68367ce4cce1d9da5bbcc01cd561
Reviewed-on: https://chromium-review.googlesource.com/691182
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505435}

The old sizes.py perf test used to check for a whole set of performance
regressions. This is now handled elsewhere with the exception of the SI
check. The SI check is fairly simple, however, and doesn't require all
of the the perf_expectations infrastructure which is now obsolete.

This CL removes the obsolete perf_expectations, hard codes the expected
number of SIs in the script, and removes the windows and android code
as it doesn't actually do anything.

Bug: 572393
Change-Id: I960cb8fec63e25c489e8c4e90f670c7e35dd4fd6
Reviewed-on: https://chromium-review.googlesource.com/654178Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505434}

With the new test framework, all of the console messages in the regular
console tests are displaying object preview. This closes the gap in coverage
by testing the formatting of console messages fired before DevTools is open
(these messages don't have object preview.)

Note: This is a combination of console-format.js, console-format-es6.js,
console-format-table.js, and console-format-collections.js. (Which helps
explain why this test is slow).

Bug: 667560
Change-Id: Ibe5317570030c8964486121fddc1f5af29d387d2
Reviewed-on: https://chromium-review.googlesource.com/691042Reviewed-by: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505433}

Removed CRWRequestTrackerDelegate and SSLCarrier classes because no one
implements CRWRequestTrackerDelegate protocol after moving to WKWebView.

Bug: 585700, 579697
Change-Id: I1895ed00a6134a9e4d08f7a511b1f451c2f2a841
Reviewed-on: https://chromium-review.googlesource.com/691216Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505432}

TBR=torne@chromium.org, bengr@chromium.org, rdsmith@chromium.org, agrieve@chromium.org

Bug: 
Change-Id: If9445cec0bebb3854be34ceef27297d2d3e5b265
Reviewed-on: https://chromium-review.googlesource.com/693003Reviewed-by: Selim Gurun <sgurun@chromium.org>
Commit-Queue: Selim Gurun <sgurun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505431}

This is a reland of 251a3311, possible now
that the Creators Update SDK (10.0.15036) is now required when building
Chrome.

Original change's description:
> Implemented changes to Sid class for AC support.
> 
> This CL implements changes to the sandbox Sid class to support the creation
> of Capability Sid objects. It also contains a few refactoring efforts to
> cleanup up older code.
> 
> Bug: 760977
> Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng
> Change-Id: Id9c05b8017abb81896c1bc30f23599441812d1fd
> Reviewed-on: https://chromium-review.googlesource.com/649026
> Commit-Queue: James Forshaw <forshaw@chromium.org>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Reviewed-by: Penny MacNeil <pennymac@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501229}

Bug: 760977
Change-Id: I4d3f61190f8f34bc638cf2c48646bfc66a6508af
Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/691114Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505430}

These tests were not functioning correctly because `assert_throws` was
not being passed an Error.  Furthermore, the use of the `expected.txt`
file is brittle since it includes a warning output with a line number.

BUG=769404

Change-Id: Ie867e6b99fc87d7c9b8b7259684f2ddd3cdc37a2
Reviewed-on: https://chromium-review.googlesource.com/688295Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505429}

This adds a flag to guard SetPrimaryUserBluetoothPowerSetting if the
power state change on adapter is initiated by Chrome in the first place,
since the user preference has been saved. By guarding
SetPrimaryUserBluetoothPowerSetting, the following scenario can be
prevented.

Issue:
Double-setting the user preference is OK in the normal case where it
takes BlueZ < 1 second to power on/off the adapter. In some cases, it
takes BlueZ > 3 seconds to finish powering off adapter. Within that > 3
seconds window if an user turns on Bluetooth from Chrome Bluetooth
setting, the power-on request will be fulfilled by BlueZ and enqueued to
the to-be-send-to-android request queue while Android is still dealing
with the previous power-off request. Afterward, Android gets back to
Chrome about finishing power-off request, but since the current state is
powered-on in preference on Chrome, the power-off state will be stored
to preference again, which will then trigger a power-on request from
Chrome. And this toggling will go on and on.

BUG=769981
TEST=Check that bluetooth power change from Chrome OS doesn't get
re-applied by ARC bluetooth.

Change-Id: I57b530518ba380eb6945000baf6f4ff6c0fdc27a
Reviewed-on: https://chromium-review.googlesource.com/691276Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505428}

Using wpt-import in Chromium d0e58aaf.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2520

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio
hta@chromium.org:
  external/wpt/webrtc
phoglund@chromium.org:
  external/wpt/mediacapture-streams

TBR=qyearsley@chromium.org

No-Export: true
Change-Id: I9e603e10706aef135d3476f931571fd8f13ac8d3
Reviewed-on: https://chromium-review.googlesource.com/692094
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505427}

Surround untranslatable strings with <ph> tags.
Fix typos.

Bug: none
Change-Id: Ia2c6db897af1dfdc76a24426d6b29c841ca9d29d
Reviewed-on: https://chromium-review.googlesource.com/679255Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505426}

According from ARIA 1.1 [1],
default value of aria-level was changed to 2.

We will return 2 as default in aria-level
if not otherwise specified.

[1] https://www.w3.org/WAI/ARIA/wiki/ARIA_1.1_Changes

Bug=688581

Change-Id: Ib03c23f96b74814fe9f52f196c6e0e417059112f
Reviewed-on: https://chromium-review.googlesource.com/670539Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505425}

- Updates fuzzer to support both versions.
- Adds v2 specific fields.
- Update fuzzer dictionary.

BUG=chromium:22532

Change-Id: Ia125300bfbe38820ca2401bbddb71e6e6e655680
Reviewed-on: https://chromium-review.googlesource.com/632896
Commit-Queue: Zentaro Kavanagh <zentaro@google.com>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505424}

WebContents::GetRenderProcessHost is an API that doesn't behave as
expected with out-of-process iframes, as multiple processes can be
associated with a single WebContents.  This CL replaces callers of this
API, so that they go through an equivalent API that explicitly selects
which frame's process is needed.

This CL was started by using an ad-hoc clang-plugin that replaced
existing callsites of WebContents::GetRenderProcessHost() with a call to
something like wc->GetMainFrame()->GetProcess().  This was followed-up
by manually adding an include of render_frame_host.h and git cl format
and git cl lint and then a self-review with small tweaks (e.g. sometimes
using a wc->GetRenderViewHost()->GetProcess() is more appropriate).

This CL was uploaded by git cl split.

R=estade@chromium.org

Bug: 666525
Change-Id: Ia364e50c35362c9fd1f4bfecd59d022e1dd42dc2
Reviewed-on: https://chromium-review.googlesource.com/688229Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505423}

When migration policy is changed during the user session, it might
enable ARC for user with unpredictable consequences. This change caches
the migration policy value for the session and uses the cached value.

Bug: b:67013794
Test: Manual
Change-Id: Id2f8c5173b8b63045a50531ec7e8d271d8df41da
Reviewed-on: https://chromium-review.googlesource.com/692195
Commit-Queue: Igor <igorcov@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505422}

Setting the paper size by ID does not work for custom user sizes, which
have values >= DMPAPER_USER = 256. Set the width and length directly in
these cases.

Bug: None
Change-Id: I7c23c656920ac6287c680e2408554c5da716871d
Reviewed-on: https://chromium-review.googlesource.com/690698Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505421}

This adds a queue to the write and read sides of
MojoDecoderBufferConverter, allowing for multiple concurrent buffers to
be processed.

Writes are no longer guaranteed to fail as soon as the pipe is closed,
since no write is attempted immediately. Since there is no error
reporting mechanism on the write side, the only guarantee is that
*eventually* writes will fail. Since MojoDecoderBufferConverter is not
a primary communication channel, this isn't likely to cause
complications.

Bug: 751926
Change-Id: I11c985d8aba3acc8fba6453f5bcf22555334b5b0
Reviewed-on: https://chromium-review.googlesource.com/679735
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505420}

bertholdherrmann08@googlemail.com reported this issue for WebRTC
and it seems easy to just add
r'C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise'
to the predefined paths.

BUG=webrtc:8299

Change-Id: I3bec73e2ef48e1a2b7e05a4df38faed2efc5ebfc
Reviewed-on: https://chromium-review.googlesource.com/691730Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505419}

In the situations when the visible rect is scrolled far enough away,
we can start experiencing floating point precision issues in the aa
path of the gl renderer. To avoid this, this patch shifts the quads
up and adjusts the quad_to_target_transform in the opposite direction.

In effect, the quads still appear in the same place, but the absolute
numbers involved in the calculation are smaller thus avoiding floating
point problems.

R=enne@chromium.org

Bug: 765297
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib93ddc0fa367116d53b4d471c9523fcce518e0bd
Reviewed-on: https://chromium-review.googlesource.com/690848Reviewed-by: enne <enne@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505418}

We previously reverted the SolidColorAnalyzer patch because
of mask tiling regressions:

Some texts are rendered blurry when mask tiling is enabled
along with this patch. This patch was reverted because
bisect points at this one.

But actually, it turns out that the root cause is that ca
layers cannot work with solid color mask layer correctly,
there is nothing wrong with this patch. So we are relanding
it.

We also disabled mask tiling in
https://chromium-review.googlesource.com/c/chromium/src/+/661072,
and are fixing the bug in
https://chromium-review.googlesource.com/c/chromium/src/+/685716.

This reverts commit 8d1900b0.

Reason for revert: The original bug will not reproduce again since mask tiling is disabled. We're also landing the patch that fixes the root cause of the bug. The reverted patch proves to be correct. The solid color analyzer change can be re-land.

Original change's description:
> Manually revert: cc: Support ClipRRect in SolidColorAnalyzer
> 
> This CL reverts a previous CL here:
> https://chromium-review.googlesource.com/c/chromium/src/+/591913
> 
> The previous CL caused a regression on Mac. GL renderer has
> difficulties dealing with RPDQs converted from
> SolidColorDrawQuads, this CL will make mask layer produce
> solid quads. We need to keep it reverted before we fix the
> gl renderer bug.
> 
> NOTRY=true
> 
> Bug: 760807
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I844d02886329acbbbebd98200f8d2f90681adb8a
> Reviewed-on: https://chromium-review.googlesource.com/653317
> Commit-Queue: Xida Chen <xidachen@chromium.org>
> Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
> Reviewed-by: Xianda Sun <sunxd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#500036}

TBR=flackr@chromium.org,vmpstr@chromium.org,chrishtr@chromium.org,wkorman@chromium.org,xidachen@chromium.org,sunxd@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 760807
Change-Id: I96969d458f14bc1129d8a9b4b7b22bd562806a92
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/674790Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Xianda Sun <sunxd@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505417}

Adding additional parameters to PlaybackImageProvider ctor causes a
regression in total raster time on some mac configs. In order to address
this, break out these settings to a separate struct which can optionally
be given to the provider. The params are modified on the Settings
object post construction.

R=enne@chromium.org

Bug: 768538, 768543
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0e7fc0df225826e5a26f0f9d09c106a6b2d1f640
Reviewed-on: https://chromium-review.googlesource.com/691206Reviewed-by: enne <enne@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505416}

Allows the declaration in an unencrypted part of a stream of an intent
to use sample-aes encryption later. This allows the decoding backend to
be properly initialized with the appropriate encryption scheme.
This involves prefixing a subset of the encryption metadata that is used
to indicate encryption, but omits the key id and IV.

This will typically be used in a live stream, when tuning in during
an unencrypted part, e.g. a commercial.

BUG=568326

Review-Url: https://chromiumcodereview.appspot.com/2783703002
Cr-Commit-Position: refs/heads/master@{#505415}

This CL changes a default LoadingPredictorConfig limit for a maximum 
number of tracked hosts. Since the whole database is loaded into the 
memory at startup, it'd be better to keep the database size reasonably 
small. New setting is closer to that is used in net::Predictor
(see Predictor::kMaxReferrers with a comment).

A number of maximum origins per entry also could be reconsidered 
after experimenting in canary in dev.

Bug: 699080
Change-Id: Iae7ea78cda0910aba7ee4a7ad938cc0c1616e32a
Reviewed-on: https://chromium-review.googlesource.com/692274
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505414}

This patch reverts commit 496fe9b7
(https://chromium-review.googlesource.com/c/chromium/src/+/685457)
and commit 902a2b75
(https://chromium-review.googlesource.com/c/chromium/src/+/688751).

I suspect that the former broke the deterministic builder
(https://build.chromium.org/p/chromium.linux/builders/Deterministic%20Linux/builds/7150)
and the latter prevented reverting the former.

TBR=dcheng@chromium.org,rockot@chromium.org,lhchavez@chromium.org,yzshen@chromium.org

Bug: 673417, 770102
Change-Id: Ic463ed5d56f5535fc4697dd4aa9a219338350214
Reviewed-on: https://chromium-review.googlesource.com/691795Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505413}

This is a reland of e9d46063
Original change's description:
> Reland "Make SECURITY_DCHECK play with Albatross."
> 
> This is a reland of 06d64c00
> Original change's description:
> > Make SECURITY_DCHECK play with Albatross.
> > 
> > In Albatross builds, DCHECKs can be compiled in, but non-fatal. See
> > https://docs.google.com/a/chromium.org/document/d/1QY4IbbJ8X6G-6-cMheEkP_mT7ZNPCuUJIW2sr_mEiH4
> > 
> > Bug: 596231
> > Change-Id: I84198f1d3f4122ac7a5bd8a90ed5ea96286b9022
> > Reviewed-on: https://chromium-review.googlesource.com/685498
> > Reviewed-by: Wez <wez@chromium.org>
> > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#504638}
> 
> Bug: 596231
> Change-Id: I2c1223ba264dbdb06e814b92b84adfe9c3c619b7
> Reviewed-on: https://chromium-review.googlesource.com/687874
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505025}

TBR: jochen@chromium.org
Bug: 596231
Change-Id: I942bdcfac1b48a666095c8b7b76db6b3ae4f6fe7
Reviewed-on: https://chromium-review.googlesource.com/690814
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505412}

This is an attempt to fix https://bugs.chromium.org/p/chromium/issues/detail?id=763040,
which shows font loads ending with a null ExecutionContext. I don't have a repro to
work with, but I suspect this is due to font fallback occurring in the middle of
ResourceFetcher shutdown and outliving its ExecutionContext. I previously attempted to fix
this in ResourceFetcher in:
https://chromium.googlesource.com/chromium/src.git/+/fb8a2de8d8190bacdaf53689c7762c9491f654ee

Bug: 
Change-Id: I1fc2e6d8b1e1f7ed1cac49929ad3b7721489f428
Reviewed-on: https://chromium-review.googlesource.com/682454Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505411}

use it to wrap a weak pointer to enforce "No callback after destruction"
guarantees.

Bug: 761319
Change-Id: I34a8f10cbf40ac0f19f11e3d98c89e729a599567
Reviewed-on: https://chromium-review.googlesource.com/670002
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505410}

If |focusedPod_| is already set, and it is the same with |podToFocus|,
early return is hit in focusPod(), however we should force a focus
update in order to ensure the correct wallpaper is set.

Bug: 769492
Change-Id: I820a523c863d693663411e436be2baa8b62fa178
Reviewed-on: https://chromium-review.googlesource.com/691046Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505409}

WebContents::GetRenderProcessHost is an API that doesn't behave as
expected with out-of-process iframes, as multiple processes can be
associated with a single WebContents.  This CL replaces callers of this
API, so that they go through an equivalent API that explicitly selects
which frame's process is needed.

This CL was started by using an ad-hoc clang-plugin that replaced
existing callsites of WebContents::GetRenderProcessHost() with a call to
something like wc->GetMainFrame()->GetProcess().  This was followed-up
by manually adding an include of render_frame_host.h and git cl format
and git cl lint and then a self-review with small tweaks (e.g. sometimes
using a wc->GetRenderViewHost()->GetProcess() is more appropriate).

This CL was uploaded by git cl split.

R=treib@chromium.org

Bug: 666525
Change-Id: Iff2b7f18d4c593b10846eac3c8ec5a03a0b0ef6d
Reviewed-on: https://chromium-review.googlesource.com/689114Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505408}

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I95a121d90642a3abbe51407ba14a90313f90322f
Reviewed-on: https://chromium-review.googlesource.com/691214Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505407}

This CL splits the xml file used to implement the promo view in 2
different files: one contains the header of the promo (the image and the
dismiss button) and the other contains the description and the signin
buttons. This change is necessary in order to provide custom paddings
and margins for the header of the promo.

Bug: 737743
Change-Id: I76532407444ca62d808dddbd874642fb1aa788e5
Reviewed-on: https://chromium-review.googlesource.com/691659Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Iulia Harasim <iuliah@google.com>
Cr-Commit-Position: refs/heads/master@{#505406}

Sometimes useful to have the unstripped library. E.g. when attempt to
disassemble.

Change-Id: Id06beb836525810f3508eed265c6018b06a18a5e
Reviewed-on: https://chromium-review.googlesource.com/692815Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505405}

Previously, it was possible specify an ARGB value via the
PATH_COLOR_ARGB command, which takes an alpha as well as RGB properties
as parameters. However, there was no command to specify a change in
opacity without also specifying the color to use.

This presented a problem for system notification. When displayed
on a notification, these icons are drawn in blue or red, depending on
the warning level of the notification, and when displayed in the black
bar at the bottom of the UI, they are drawn in white. Thus, for
notification icons which need to be displayed in a single color with
different opacities, a new command was needed.

This CL introduces the PATH_COLOR_ALPHA command, which takes a single
parameter expressing the opacity of the path. It will be used
immediately in a follow-up CL:
https://chromium-review.googlesource.com/c/chromium/src/+/685304

Bug: 759257, 672263
Change-Id: I00a5dbb28a06de41239cda2fe1c608754f190bf6
Reviewed-on: https://chromium-review.googlesource.com/690706Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505404}

Bug: 646711
Change-Id: I82c20d2db71c9cec7363c395af4f348be3b6a6de
Reviewed-on: https://chromium-review.googlesource.com/688220
Commit-Queue: Philippe Hamel <hamelphi@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505403}

Make the menu item handle click events on its icon view.
(support clicking on a radio/check icon in a menu item)

Bug: 768449
Test: See bug.
Change-Id: I1da3ce9baad36b1e35278e3a7c466e96c4e00876
Reviewed-on: https://chromium-review.googlesource.com/691175Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505402}

Although metalayer selection is constructed from stylus
input points, it can sometimes cross the screen bounds.

For example, when a horizontal stroke is recognized, its
bounding rectangle is inflated to guarantee minimal
height and generally be closer to the visual image of
the stroke.

This patch introduces necessary clipping to make sure
that clients do not have to do that.

Bug: b:67021526
Test: ash_unittests HighlighterControllerTest.SelectionInsideScreen
Change-Id: I09d67c8b9f1176ea083a40f581b8a46536152296
Reviewed-on: https://chromium-review.googlesource.com/691278
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505401}

Without our new(ish) scheme of bytecode-rewriting asserts, the system
property isn't used.

NOTRY=true  # Doesn't affect bots

Change-Id: Ie0f9f2e9bb8674bba52380fc7983a13f54ae65f9
Reviewed-on: https://chromium-review.googlesource.com/692816Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505400}

WebContents::GetRenderProcessHost is an API that doesn't behave as
expected with out-of-process iframes, as multiple processes can be
associated with a single WebContents.  This CL replaces callers of this
API, so that they go through an equivalent API that explicitly selects
which frame's process is needed.

This CL was started by using an ad-hoc clang-plugin that replaced
existing callsites of WebContents::GetRenderProcessHost() with a call to
something like wc->GetMainFrame()->GetProcess().  This was followed-up
by manually adding an include of render_frame_host.h and git cl format
and git cl lint and then a self-review with small tweaks (e.g. sometimes
using a wc->GetRenderViewHost()->GetProcess() is more appropriate).

This CL was uploaded by git cl split.

R=ekaramad@chromium.org

Bug: 666525
Change-Id: I8c9c9436301eabd31b5bfe1054956c63d5457dfc
Reviewed-on: https://chromium-review.googlesource.com/689107Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505399}

Remove the std::unique_ptr<> members from ExternalInstallInfoFile and
ExternalInstallInfoUpdateUrl. These were used to hold the version and
url members, but each of these will never be null and are cheaply 
copyable (or, in the case of GURL, movable), so have no reason to
be pointers.

Bug: 770007
Change-Id: I4b9c3ef8c9888a2d460ab082a9fa3339423a5ee6
Reviewed-on: https://chromium-review.googlesource.com/691045
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505398}