- 26 Nov, 2020 40 commits
-
-
Curtis McMullan authored
Add the assistive multi word suggestions flag to CrOS. BUG=1146266 Change-Id: I0409a4efd5de44a7ad4c20e422691b248c317af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560702Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Cr-Commit-Position: refs/heads/master@{#831271}
-
Lukasz Anforowicz authored
The feature has been in the disabled state since r731113 (Jan 2020) and we don't have any plans to change this - we plan to continue attaching `Origin: chrome-extension://...` request header to POST requests initiated from an extension background page. Bug: 966223 Change-Id: If82600be0f615afd3b5737a8bdc5e3f5b130440a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557732Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#831270}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ib92daffdf39d2d8287e168e60b3b9158ec85b057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561829Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831269}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606316157-945260897cb0815b47df3e1edecdf8b6cf6cb896.profdata to chrome-win64-master-1606348564-2a10d807907a5e3f733f66553645eebe78051ddf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie914725eb5494621640a999ceb73a13da5139d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559978Reviewed-by:
-
Bartek Nowierski authored
There are PartitionRoot::Re/DecommitSystemPages functions that wrap base::Re/DecommitSystemPages and update total_size_of_committed_pages, thus suitable for data pages (as opposed to meta-data, bitmaps, ...). However, the wrappers weren't always used where they could, and this CL makes it more consistent. Also, rename them, to disambiguate from base:: APIs. Change-Id: I0e0e21dc71408294d5f59e3395a133c5a70a1d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552328 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#831267}
-
Ramin Halavati authored
Web Applications tests are updated to cover ephemeral Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Ie60624795a286f0cfbcb6dfed2e8c605d61e6136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560125Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#831266}
-
Austin Tankiang authored
Bug: 1139247 Change-Id: I462fcdf8c6c7674fe5b7b5ef03937cd1f7ad80fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560346Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#831265}
-
Yunke Zhou authored
Bug: 1152763 Change-Id: I325417cca237f876c77619a22be9ed095b098d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560626Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#831264}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b9a5e83e55ee..e62621d2eb86 2020-11-26 yyanagisawa@chromium.org Roll out new goma client binary VERSION=209 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: If9aefe38a36085f918f9c1016ea0c663ee1f8f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560677Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I2316b6d53e9c98417998416839a4bd505c6c9041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559981Reviewed-by:
-
Yutaka Hirano authored
...as a preparation step to the Transferable Streams optimization. Bug: 1146396 Change-Id: Iaec17e0e96bfc0a9dc0f96f0c0dd2245c5d56db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546312 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#831261}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4dba276776bd..939fcd1a14f5 2020-11-26 syoussefi@chromium.org Vulkan: Pass in emulated alpha value to ConvertVertex If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I12cfadeab826ab19f0d26382ab24eec57457750f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561827Reviewed-by:
-
Bartek Nowierski authored
Super pages and direct map have been so far allocated in a fully committed state and most of the pages are made inaccessible immediately after. This CL reverses the process and commits only necessary pages. Change-Id: I136c6ac4e1a0d96564739542e82d65ee1562b2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531796 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
-
Leo Lai authored
The fact that InstallAttributes gets the owner password could lead potential leak of such an important secret. Thus, while replacing the crypthome API with tpm manager's, we use a more light-weighted status query to only tell if the owner password s present. To test the CL, some test items were added and they are: 1. check the UMA of interest gets reported w/ ownre password. 2. check the UMA of interest gets reported w/o ownre password. 3. fail to check TPM status. BUG=b:172748724 BUG=b:168852740 TEST=chromeos_unittests. Change-Id: I804d94cd0c6a86149ebda293a053d4ffb3cc0492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557938 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#831258}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/28a1c2ec8223..dee1cdf147f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mxcai@google.com Change-Id: If22c2766be538da500fd9604aacb748d28f07c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559979Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831257}
-
Maggie Cai authored
This reverts commit 2b9c5c7c. Reason for revert: This CL is likely the root cause for build failure for linux-chromeos-dbg, starting from https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21474 The failed tests are: InputMethodManagerImplTest.SetLoginDefaultWithAllowedKeyboardLayouts InputMethodManagerImplTest.TestEnableLayoutsNonUsHardwareKeyboard InputMethodManagerImplTest.TestEnableMultipleHardwareKeyboardLayout Original change's description: > Always inject mocks for more hemertic InputMethodManagerImpl unit tests. > > Six InputMethodManagerImpl tests are failing in specific environments > due to mixed usage of test data and CrOS prod configs. Partly caused by > inconsistent usage of MockComponentExtensionIMEDelegateManager. In > particular, parts of Setup() are run without this mock injected. The fix > here ensures the mock and its test data are consistently used throughout. > > With this we manage to un-fail 4 out of 6 tests, but another new test > starts failing! It's unsurprising because these tests still indirectly > depend on deprecated input_methods.txt configs (remnant from before the > migration to extension-based input methods circa 2011). This issue will > be addressed in the next steps. > > Bug: 970790 > Change-Id: I3e76708e34f2b4e021f763654714d157f48a3925 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550152 > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: John Palmer <jopalmer@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831198} TBR=ynovikov@chromium.org,shend@chromium.org,tranbaoduy@chromium.org,jopalmer@chromium.org Change-Id: I4fea5ebf6f46f66ba837d693f7970a0ac8949054 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 970790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560527Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#831256}
-
Maggie Cai authored
This reverts commit f42aaef1. Reason for revert: The parent CL of this CL (https://crrev.com/c/2550152) is likely the root cause for build failure for linux-chromeos-dbg, starting from https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21474 The failed tests are: InputMethodManagerImplTest.SetLoginDefaultWithAllowedKeyboardLayouts InputMethodManagerImplTest.TestEnableLayoutsNonUsHardwareKeyboard InputMethodManagerImplTest.TestEnableMultipleHardwareKeyboardLayout Original change's description: > Remove unnecessary ime_list_ in InputMethodManagerImpl unit tests. > > Bug: 1134465 > Change-Id: I32cb2d5d67e6bd102f17578d824028527d1c9bdc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551869 > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: Jing Wang <jiwan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831202} TBR=shend@chromium.org,tranbaoduy@chromium.org,jiwan@chromium.org Change-Id: I25712769e78d54920f7a80edf316433250012f1d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1134465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560280Reviewed-by:
-
Maggie Cai authored
This reverts commit d1224786. Reason for revert: Suspect this CL breaks the build android-archive-rel. First failure: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/16867 Compile error message: expand_owners.Error: The histogram Event.WaylandDragDrop.IncomingDataTransferTime must have a valid primary owner, i.e. a Googler with an @google.com or @chromium.org email address. Original change's description: > [ozone/wayland] Introduced the histogram to track time on data transfer. > > When data is dragged from another application into Chromium, there is a > delay between mouse pointer crossing the window border and the actual > OnDragEnter() called on the window. The delay happens because the > drag drop controller has to get the data, which implies at least one > request to the Wayland server (the actual number of requests equals > number of MIME types available in the data offer). > > Here a histogram is introduced to know what the real delays will be > there in the wild. > > Bug: 1147413 > Change-Id: I2f3acc067f718ccb29d98ea1bf98b9f03efc2f7d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552864 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Alexander Dunaev <adunaev@igalia.com> > Cr-Commit-Position: refs/heads/master@{#831251} TBR=rjkroege@chromium.org,asvitkine@chromium.org,adunaev@igalia.com Change-Id: I8a9f113d12f7c8ef7e71989cdb3949696a683901 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1147413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561958Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I477d29831237a85412b22624a7578ec34858efb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561828Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ie5b1855392623cf850736cb248f05ad31130ccc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559977Reviewed-by:
-
Alexander Dunaev authored
When data is dragged from another application into Chromium, there is a delay between mouse pointer crossing the window border and the actual OnDragEnter() called on the window. The delay happens because the drag drop controller has to get the data, which implies at least one request to the Wayland server (the actual number of requests equals number of MIME types available in the data offer). Here a histogram is introduced to know what the real delays will be there in the wild. Bug: 1147413 Change-Id: I2f3acc067f718ccb29d98ea1bf98b9f03efc2f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552864Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#831251}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/81585eced14b..abee7cf3a989 2020-11-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I28d1712509be0d4aa980faa4e4c31a37ee9b8cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561051Reviewed-by:
-
Clark DuVall authored
This makes sure DFM resources are merged even when the chrome module is disabled. Bug: 1151538 Change-Id: I5f73ee21fbfbec401c8f5a9c0255c5fb85ebf994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561759Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#831249}
-
Jing Wang authored
The metrics were added in https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2497369 Bug: 1132699 Change-Id: Ice9f49732f3daf682a7ac60838f061de2f5fecea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521976 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ib8b338ed98e027ac6799f27f2c17f3f7739e2a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561052Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831247}
-
Maggie Cai authored
This reverts commit 4fc657cd. Reason for revert: This CL is likely the cause for bot failures for Linux ChromiumOS MSan Tests and Linux Chromium OS ASan LSan Tests (1) First fail occurance: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38932 and https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21447 Failed tests: DockedMagnifierE2ETest.MovesDockedMagnifierToActiveDescendant Original change's description: > Docked Magnifier Sends OnMagnifierBoundsChanged Events > > AX-Relnotes: N/A > Bug: 1151216 > Change-Id: I222ec5d29ae2fd06689d6d94876f4fa6973e4c2a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552163 > Commit-Queue: Josiah Krutz <josiahk@google.com> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830905} TBR=dtseng@chromium.org,afakhry@chromium.org,josiahk@google.com Change-Id: Ie16bef08dded2618730f63d3930bb46e884e7ea1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1151216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560332 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
-
Josiah K authored
Wires in screen_magnifier_focus_following preference added in crrev.com/c/2506771. AX-Relnotes: Allow Screen Magnifier Focus Following Pref to take effect in magnifier. Fixed: 1146583 Change-Id: Ieeb8b81d0852ce330f671f931cfa2bfb02fd4067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522905 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#831245}
-
Maggie Cai authored
This reverts commit a92eb9b7. Reason for revert: Looks like the test failure is still there for Linux ChromiumOS MSan Tests and Linux Chromium OS ASan LSan Tests (1) First fail occurance: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38932 and https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21447 Revert this CL so I can revert https://crrev.com/c/2552163 Original change's description: > Speculative fix for MagnifierE2ETest.MovesDockedMagnifierToActiveDescendant > > The test was failing/flaky on some MSAN bots, presumably because the > listener was registered after the event was fired. > > Introduce a helper class that allows us to easily register the listener, > perform the event, then wait for the listener to have fired. > > TBR=josiahk@chromium.org, dtseng@chromium.org > > Bug: 1145612 > Test: Runs locally but real test will be whether this fixes failures on > the 'Linux ChromiumOS MSan Tests bot' > > Change-Id: I16303d96b101113e80ab4f484b4e604faeab4c88 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560622 > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Commit-Queue: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830991} TBR=dtseng@chromium.org,pmarko@chromium.org,josiahk@chromium.org Change-Id: I609372a222b15106cd1bf3c2c7bb10758214e136 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1145612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560446Reviewed-by:
-
Tal Pressman authored
It was only used for sync compositing in Android WebViews, but those were converted to mojo, leaving this unused. Bug: 526842, 1111231 Change-Id: I491659a6a696da6a317f6ae9eda318e81be1c1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550145 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#831243}
-
Kenichi Ishibashi authored
Adds DidDeleteAndStartOver so that we can use CreateInvokerAndStartRemoteCall(). Bug: 1133143 Change-Id: I41282bdcaf1d28c5646449f66fd242c19d1293c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550015 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#831242}
-
Glen Robertson authored
Constants that were defined in chrome_browsing_data_remover_delegate.h have been moved to a separate header in its own gn target, so that dependents like profile can avoid taking a dependency on all of //chrome/browser:browser just for access to the constants. This is done in prep for moving profile out of the //c/b target. Bug: 1149277 Change-Id: I7a5a0108773cb75ba4c1514f6ccc086460046400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550846 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#831241}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8d78da910e45..39b4c86fe914 2020-11-26 reed@google.com Use sampling inside legacy bitmapprocstate If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Ifd73fc9aa63deab7db480fddae7d71c49949dfcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561450Reviewed-by:
-
David Stevens authored
Check that the visible size of a decoded buffer is smaller than the coded size. Returning an error here prevents a later crash due to VideoFrame::IsValidConfig failing. Bug: b:170727869 Test: android.security.cts.StagefrightTest#testStagefright_cve_2016_2454 on trogdor Change-Id: I2df5fcb345b925bca9804b5898b15d02df64ce4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551854Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: David Stevens <stevensd@chromium.org> Cr-Commit-Position: refs/heads/master@{#831239}
-
Rakina Zata Amni authored
Log some relevant info to make sure crashes reported are legitimate renderer kills. Bug: 1133115 Change-Id: I8fa1f6393fdf1db64f242d1d881e9f758410e0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558118Reviewed-by:
-
Sean Topping authored
AuraComponents is intended only to expose virtual interfaces for objects that only have valid implementations on Aura platforms. LayoutProvider is not pure virtual, so it must live in a subclass of AuraComponents. Bug: internal b/172316742 Test: CQ Change-Id: Id66e6b19e55154437967b1df6260e45ac51b337e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561738Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#831237}
-
Anton Bikineev authored
This CL gets rid of dynamic initialization of the bucket index lookup table and thereby avoids the data race that happens on reinitialization of the bucket index lookup table (when the malloc partition is being allocated from while another partition (e.g. wtf::) is being initialized). Change-Id: Ie7ceffec71862e1a5a95433e36b925b8a0122d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560625Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ib7e9a9cfb2caf34f15eb25d590cbe429279adf64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561825Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ie5ed5f32b996259108ae4ee712048dc38700a003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561449Reviewed-by:
-
Darren Shen authored
Some of the code from crrev/2537516 uses JS style rather than C++ style. Bug: b/172527471 Change-Id: Iee01a5eccc83b6c7060cb7c32aa51981cda09f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557702 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#831233}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f4a615fc8f0e..28a1c2ec8223 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1127088 Tbr: mxcai@google.com Change-Id: I115081c7e0aa45a7705813e17b1b27db86538dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561820Reviewed-by:
-
