- 21 Feb, 2019 40 commits
-
-
Ben Pastene authored
chromeos-kevin-rel is a simplechrome bot running tests on kevin DUTs: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel This will enable chromium sheriff alerts for its 3 suites: all_tast_tests, sanity_test, and base_unittests. (That third might not be the most useful; could be removed.) I'll send out a PSA prior to landing. R=jbudorick, martiniss Bug: 866062 Change-Id: I3d8f853aacc41d1f381d18939a1b26b3ed4adbbb Reviewed-on: https://chromium-review.googlesource.com/c/1478117Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#634332}
-
rbpotter authored
To ensure all automated tests are run with both configurations until the migration is completed, change test suites to run with Polymer 1 instead of Polymer 2, now that Polymer 2 has been enabled by default for all OSes. Bug: 931434 Change-Id: I9a6cc87fdc4c761b35907fbe6ccdbc826ec45589 Reviewed-on: https://chromium-review.googlesource.com/c/1469297 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Ryan Hansberry authored
The original commit (crrev.com/c/1479941) was reverted (crrev.com/c/1480309) because of usage of unitialized memory. Specifically, the MockProximityMonitor object had been deleted but was then derefenced. Patch 1 is the original commit, Patch 2 is the fix. Original commit message: UnlockManager was previously holding onto a stale ProximityMonitor from its first connection. That meant that if a disconnection and subsequent new connection occurred, the old ProximityMonitor, with an old reference to the previous connection (represented as a ClientChannel object) was used. This always resulted in a Smart Lock failure for a second connection, and occasionally, a crash. In order to correctly reset the ProximityMonitor object, the way that it is called had to be refactored (remove completely unneeded ScreenLockBridge logic), in order to consolidate calls to one place. Bug: 931929 Change-Id: If8d7b48efe0055b8d0afc2f4cd3954114c0b7a71 Reviewed-on: https://chromium-review.googlesource.com/c/1481613Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#634330}
-
Saman Sami authored
A child should not be throttled if the parent is blocked on it. Otherwise the parent is guaranteed to hit the deadline, causing jank. Bug: 933610 Change-Id: Id4cc7bcf6d942a2413a63986e9f10377543fb089 Reviewed-on: https://chromium-review.googlesource.com/c/1479427Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#634329}
-
Chase Phillips authored
The original one-off deleter for ChromeBlobStorageContext attempts to delete |this| directly when not called on the IO thread and the IO thread isn't available. This causes problems with objects it owns since some objects require being deleted on the IO thread. This manifested in flaky tests like EmptyBlob and Bug84933Test which started failing in a flaky way when IndexedDBDispatcherHost (which holds a scoped_refptr<ChromeBlobStorageContext>) was moved from the IO thread to the IDB task runner. The flaky crashes looked like: [8496:100:0221/084948.427:FATAL:memory_dump_manager.cc(247)] Check failed: (*mdp_iter)->task_runner && (*mdp_iter)->task_runner->RunsTasksInCurrentSequence(). MemoryDumpProvider "BlobStorageContext" attempted to unregister itself in a racy way. Please file a crbug. Backtrace: base::debug::CollectStackTrace [0x00007FF6F62CCAA2+18] base::debug::StackTrace::StackTrace [0x00007FF6F62CC002+18] logging::LogMessage::~LogMessage [0x00007FF6F62E7885+101] base::trace_event::MemoryDumpManager::UnregisterDumpProviderInternal [0x00007FF6F634BC2B+827] storage::BlobStorageContext::~BlobStorageContext [0x00007FF6F61D7362+34] storage::BlobStorageContext::`scalar deleting destructor' [0x00007FF6F61DA8F0+16] content::ChromeBlobStorageContext::`scalar deleting destructor' [0x00007FF6F46EF4F8+40] content::IndexedDBDispatcherHost::~IndexedDBDispatcherHost [0x00007FF6F48FC6BE+382] content::IndexedDBDispatcherHost::`scalar deleting destructor' [0x00007FF6F48FDFA0+16] Remove the one-off deleter for ChromeBlobStorageContext in favor of DeleteOnIOThread which always tries to delete the object on the IO thread and, if the IO thread isn't available, gives up since that indicates a leak on shutdown, which is generally okay in circumstances like this. Bug: 717812, 934243, 934250 Change-Id: Ibfda4b0b8f17d3eeb95773bb2a75f0e9a16e84b5 Reviewed-on: https://chromium-review.googlesource.com/c/1481597Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#634328}
-
Oystein Eftevaag authored
Events that only get filtered (i.e. memlog) shouldn't get sent to Perfetto. R=ssid@chromium.org BUG=839084 Change-Id: I2d1d9c421c3a726ce8bf6a62ee9ce28f4ec78b1c Reviewed-on: https://chromium-review.googlesource.com/c/1480705Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#634327}
-
Jun Mukai authored
Although a pinch event is a gesture event, it comes outside of the gesture recognition if it's generated from the touchpad. So ProxyWindow should send them. Bug: 933985 Test: the new test case Change-Id: I2c762d8564c37a1ae353f91badb84903e19d650c Reviewed-on: https://chromium-review.googlesource.com/c/1481712Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#634326}
-
Sebastien Marchand authored
Change-Id: Ibb3e697f515ca7e3dc7c8d5a93d495a9c315fdb7 Reviewed-on: https://chromium-review.googlesource.com/c/1474810 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#634325}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/575872e77e9c..84d35339f3bf git log 575872e77e9c..84d35339f3bf --date=short --no-merges --format='%ad %ae %s' 2019-02-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@84d35339f3bf The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I729faf847d800d5ec2a550ce535ccf3fd4cd4433 Reviewed-on: https://chromium-review.googlesource.com/c/1480981Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634324}
-
Oystein Eftevaag authored
Added a switch to force JSON-backed TracedValue writer mode and switch memlog to use it. R=erikchen@chromium.org,ssid@chromium.org Bug: 839084 Change-Id: I456b4a225112205993299ad98b39c75b55d59ca3 Reviewed-on: https://chromium-review.googlesource.com/c/1480825Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#634323}
-
Matt Menke authored
The way HTTP proxy auth works with tunnels is that we see an auth challenge, we return the proxy socket to the consumer (bypassing the SSL layer that would be layered on top of it), telling it of the auth challenge. It then provides credentials and calls restart with auth, while holding onto the socket. We then drain the response body of the original auth challenge, and if we can reuse the socket, we send the request again, with the new credentials. If we see another auth challege, we call back into the consumer (Which still owns the ProxyClientSocketWrapper), and it can provide more credentials. We repeat this until the user decides to proceed with no crentials, the server accepts the credentials, or there's a network error. If the server accepted the credentials, we have a useable socket, which we then toss back into the HTTP proxy socket pool, and then we request an SSL socket from the pool above that, so it can create an SSL socket layered on top of the proxy socket we just made. The way QUIC and HTTP2 cases work is different. As above, we pass the ProxyClientSocketWrapper up to the consumer, which provides credentials. However, when it tells the wrapper to restart with auth, the ProxyClientSocket closes the socket, and then claims auth succeeded. At that point, we return the socket to HTTP proxy socket pool, which notices the socket was closed, and destroys it. This effectively closes the stream layered on top of the H2/QUIC session, though the session itself remains in the session pool. Then the consumer, unaware of these shenanigans, requests a new SSL socket, which then results in requesting a new ProxyClientSocketWrapper (Since the old one was destroyed). When connecting, it will create a new stream on the same session as before (taken from the session pool), and preemptively sends the auth credentials provided earlier using a new stream. If another auth challenge is seen, this process repeats, again creating a new ProxyClientSocketWrapper. As part of flattening the socket pools, we'll always end up reusing a ProxyClientSocketWrapper for challenges. This CL modifies the QUIC and HTTP2 paths to more closely match the HTTP path. They will still make new streams for each new set of auth credentials, but all auth attempts will use the same ProxyClientSocketWrapper. Bug: 472729 Change-Id: I96791754480456908dda4595f9dc201fdbc41f13 Reviewed-on: https://chromium-review.googlesource.com/c/1481060 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#634322}
-
Elly Fong-Jones authored
This feature was launched, then unlaunched, and is now dead. Bug: 776409 Change-Id: I847be9180f7b3a991be0d67b88a0cdfae5d4bf8d Reviewed-on: https://chromium-review.googlesource.com/c/1479886 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#634321}
-
John Delaney authored
Measure the amount of bytes directly loaded in the main frame by the page. Record separately the total number of ad bytes loaded in the main frame. Main frame ad bytes per page are currently recorded in PageLoad.Clients.Ads.Resource.Bytes.TopLevelAds, but this only accounts for network bytes. Rather than adding more counters to AdsPLMO, main frame data will be stored in a separate FrameData object to reduce repetition. It makes sense at this point to also refactor all page bytes counts to a frame data object. This will help compartmentalize the two classes. This change should be a no-op to existing metrics. Bug: 919122 Change-Id: I83839cea1d01e375bb8d2a088be69d0911119966 Reviewed-on: https://chromium-review.googlesource.com/c/1478091 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#634320}
-
Andrew Comminos authored
Log usages of isInputPending, adding the appropriate entries in web_feature.mojom as well as the scheduling IDL. Bug: 910421 Change-Id: I28d9cef1190221931d41bf56422f1581c7290378 Reviewed-on: https://chromium-review.googlesource.com/c/1474268 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634319}
-
Aaron Colwell authored
Fixing a compiler error introduced in https://crrev.com/c/1356133 Change-Id: I78071bb195a6282a08ba9aa1b609a626d6e9db39 Reviewed-on: https://chromium-review.googlesource.com/c/1481585Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634318}
-
Robbie McElrath authored
It turns out this test's flakiness is due to its setup, so my previous attempt to early-out didn't actually fix it. This time I'm completely disabling the test. I've made progress on fixing the underlying issue, but I'll wait on sending that out until I can reproduce it somewhere. Bug: 933963 Change-Id: I89b0bfa3f94d32b9fc84943ab2d73217ae40d3fe Reviewed-on: https://chromium-review.googlesource.com/c/1479885Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#634317}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b0604e5c460c..9bb7f07652a6 git log b0604e5c460c..9bb7f07652a6 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3f48ecb3efb5..0eee33250ebb (1 commits) 2019-02-21 reed@google.com add subpixel tweaking 2019-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 9374ba7d790a..b7157d764389 (1 commits) 2019-02-21 reed@google.com remove old code behind SK_SUPPORT_LEGACY_SETLENGTH 2019-02-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c1fd4087ddc9..3f48ecb3efb5 (2 commits) 2019-02-21 thakis@chromium.org Remove another semicolon. 2019-02-21 reed@google.com add test for mac aa on fonts Created with: gclient setdep -r src/third_party/skia@9bb7f07652a6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:926235 TBR=jvanverth@chromium.org Change-Id: I496c40f119cddb56963baf081de3e32984fdc9d1 Reviewed-on: https://chromium-review.googlesource.com/c/1480976Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0db2fb2c1cac..bb774460bda0 Created with: gclient setdep -r src-internal@bb774460bda0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9e718860cc6b481447f8383663f4483845f5ab45 Reviewed-on: https://chromium-review.googlesource.com/c/1480980Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634315}
-
Egor Pasko authored
When "release official" builds crash, the Crashpad produces (among other things), detailed minidumps in the app's "cache" directory. Fetch the latest of those, extract the likely native library name for it, generate symbols for it, and print the (symbolized) stack traces. This script is intented to primarily be used by Catapult to provide more detailed information about native crashes. The output is more verbose than our usual stack traces, which is good for understanding what happens on remote bots. Bug: 925453 Change-Id: I15981d49b1072123a56b268f5a222311e6e7d1a0 Reviewed-on: https://chromium-review.googlesource.com/c/1477858Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#634314}
-
Evan Stade authored
This makes the app type available earlier (i.e. during initialization of NonClientFrameController). The app type check in MakeGestureDraggableInImmersiveMode depends on this. Bug: 931855 Change-Id: Ia54a006d12ea52e0147b50cf86394f3180e61e30 Reviewed-on: https://chromium-review.googlesource.com/c/1480112Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Sky Malice authored
Previously we assumed the PrefChangeRegistrar would only notify on an actual change, and an assert was in the code to verify this was the case. However, that assumption turned out to be incorrect, and this notification was called during sign in/out when the value was staying true. This would cause the entire article section of the NTP to be removed until chrome was restarted. Typically occur for dasher accounts. Bug: 934335 Change-Id: I67a6dbfe17a73208b85f91ce195e1d4ceb589563 Reviewed-on: https://chromium-review.googlesource.com/c/1481731Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#634312}
-
Sergio Villar Senin authored
This class will be used to obtain diagnostics about IdentityManager internals. In this CL we're adding a pure interface and an implementation backed by unit tests. It has the following methods and correspondencies: * OAuth2TokenServiceDelegate::LoadCredentialsState GetDetailedStateOfLoadingOfRefreshTokens() corresponds to OAuth2TokenServiceDelegate::load_credentials_state() * GetDelayBeforeMakingAccessTokenRequests() corresponds to ProfileOAuth2TokenService::GetDelegateBackoffEntry()::GetTimeUntilRelease() * GetDelayBeforeMakingCookieRequests() corresponds to GaiaCookieManagerService::GetBackoffEntry()::GetTimeUntilRelease() In order to make the unit test work, BackoffEntry support had to be added to FakeOAuth2TokenServiceDelegate as the current code does not need to modify it (it does not perform retries). A new API to simulate cookie merge session failures had to be added as well to IdentityTestEnvironment. Bug: 926833 Change-Id: I2f1fedccd0c69e6a8de2bd307e6c32b83f76fd84 Reviewed-on: https://chromium-review.googlesource.com/c/1461121 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#634311}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/e2381829e984..986b2bef7f47 $ git log e2381829e..986b2bef7 --date=short --no-merges --format='%ad %ae %s' 2019-02-18 jzern vpx_thread.h: remove unused sched_yield() 2019-02-19 yaowu Disable encoder builds when checking coeff ranges 2019-02-19 jianj vp9: Enable ml based partition for speed>=8 low res. 2019-01-05 aidansw added error messages in vpx_video_reader_open(). 2019-02-08 angiebird Fix compile warnings in non-greedy-mv 2019-02-08 angiebird Only discount new mv mode when tpl model is ready 2019-02-06 angiebird Check the new mv diff in discount_newmv_test() 2019-02-06 angiebird Use mv_mode_arr to decide the newmv discount place 2019-02-08 angiebird Fix the bug for feature_score computation 2019-01-30 deepa.kg Fix integer overflow issue in bits allocated Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I03b9ba8d8671f09d253780cda216ab3a25be2963 Reviewed-on: https://chromium-review.googlesource.com/c/1481579Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#634310}
-
David Bienvenu authored
Bug: 868341,869154 Change-Id: I068264b13048d55dbae0fe7f05318ffb8270230c Reviewed-on: https://chromium-review.googlesource.com/c/1478356Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#634309}
-
Sam McNally authored
Bug: 737821 Change-Id: I9ce8458b260ff1b4402923f6b8ee5f94464f340a Reviewed-on: https://chromium-review.googlesource.com/c/1480368Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
-
Etienne Bergeron authored
Adding categories for: https://cs.chromium.org/chromium/src/components/services/font/public/cpp/font_loader.cc?tl=35 https://cs.chromium.org/chromium/src/components/services/font/public/cpp/font_loader.cc?tl=42 R=oysteine@chromium.org Bug: 867931 Change-Id: Ie385b8c6034e974660c0e64a46f9df9b406918d7 Reviewed-on: https://chromium-review.googlesource.com/c/1478480Reviewed-by:
-
John Rummell authored
base::UnguessableToken doesn't allow serialization of Null(). So make the |origin_id| parameter of MediaDrmStorage::Initialize() optional. BUG=917527 TEST=new unit_tests pass Change-Id: I21e374b42e670220ea11166c77651f0d9c00ae12 Reviewed-on: https://chromium-review.googlesource.com/c/1475902Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634306}
-
Antoine Labour authored
Copy & Paste fail... Bug: 870116 Change-Id: I6da2195e87944f3c249acb1ac59957e5cd3fb773 Reviewed-on: https://chromium-review.googlesource.com/c/1480533 Auto-Submit: Antoine Labour <piman@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#634305}
-
Andrew Xu authored
Make the following changes: 1. SearchBoxViewBase::SetBackgroundColor is never used. So erase this function. In addition, SearchBoxViewBase::background_ color_ is modified only by SearchBoxViewBase::SetBackgroundColor. So |background_color_| is constant. Hence replace SearchBoxViewBase:: background_color() with kDefaultSearchBoxBackgroundColor, the initial value of |background_color_|. 2. SearchBoxViewBase::UpdateBackgroundColor and SearchBoxViewBase::Set SearchBoxBackgroundColor do very similar job. And the latter is only used by KsvSearchBoxView. So erase the function SetSearchBoxBackground- Color. Move that part to KsvSearchBoxView. Test: none Bug: 755219 Change-Id: I678f254dd2de9dfe2f59b5027b1f00405fbbe829 Reviewed-on: https://chromium-review.googlesource.com/c/1474380Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634304}
-
Sylvain Defresne authored
Update the implementation of JsFindinpageManager to use JSONReader::Read instead of JSONReader::ReadDeprecated. Bug: 925165 Change-Id: I3a36d9876e5a0e47975efc39b415c813601b5e60 Reviewed-on: https://chromium-review.googlesource.com/c/1477228Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#634303}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d6c6f16063b8..e11b7d2e8087 git log d6c6f16063b8..e11b7d2e8087 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 perkj@webrtc.org Replace field trials with WebRtcKeyValueConfig in RtpRtcpModule 2019-02-21 gustaf@webrtc.org AEC3: Use minimum ERLE during onsets Created with: gclient setdep -r src/third_party/webrtc@e11b7d2e8087 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:119942 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1dd6b2f6bf3379785c4abc83e14fda46da5011bb Reviewed-on: https://chromium-review.googlesource.com/c/1480978Reviewed-by:
-
Anne Lim authored
Clears all V2 strikes in a profile's StrikeDatabase when Autofill data is wiped out from Chrome Settings (chrome://settings -> Clear Browsing Data -> Advanced -> Autofill Form Data). Bug: 884817, 933826, 933705 Change-Id: Ic6565818fc473f3bca7111bafa3a8120dcd77093 Reviewed-on: https://chromium-review.googlesource.com/c/1479630Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#634301}
-
Alex Clarke authored
The callsites were removed in crrev.com/618761. Bug: 826465 Change-Id: If1b36e9b95b83183653bf5c927d8bdd8dbee7959 Reviewed-on: https://chromium-review.googlesource.com/c/1478893Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#634300}
-
Erik Chen authored
Bug: 926987 Change-Id: If17689c69a0c3f2ada5c40a844bea60376a96b61 Reviewed-on: https://chromium-review.googlesource.com/c/1480543Reviewed-by:
-
Andres Calderon Jaramillo authored
This CL takes VideoFrame-independent code from VaapiJpegDecodeAccelerator's DecodeTask() and OutputPicture() methods and puts it in VaapiJpegDecoder::DoDecode(). The idea is for VaapiJpegDecoder to be responsible for dealing with the VaapiWrapper, so now part of the initialization of the VaapiJpegDecodeAccelerator is delegated to VaapiJpegDecoder. Now, VaapiJpegDecoder::DoDecode() will take encoded data. It will do the parsing, VAAPI buffer submission, decode execution, and VAImage extraction. It will then return the decoded output as a ScopedVAImage. The intent is to have a VaapiJpegDecoder member in two classes: VaapiJpegDecodeAccelerator (existing) and the eventual implementation of gpu::ImageDecodeAcceleratorWorker. In the first case, we use the ScopedVAImage to copy the decoded data into a VideoFrame. In the second case, we use it to copy the decoded data into a vector. The unit tests are modified accordingly. Additionally, ::testing::FLAGS_gtest_death_test_style = "threadsafe" is added to two of the tests due to safety issues when using EXPECT_DCHECK_DEATH when there are multiple threads. The reason for introducing the grayscale image is that before, the DecodeFail test case was using a normal image and poking at the results of the JPEG parsing so that it failed. Now, the decoder interface doesn't take a JpegParseResult, so we can't do the same poking. Instead, we give it a real unsupported image. Bug: 924310 Test: jpeg_decode_accelerator_unittest passes on nocturne and grunt. Change-Id: I52d9760d233e63b2831408f60309803984784903 Reviewed-on: https://chromium-review.googlesource.com/c/1427457 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#634298}
-
Toni Barzic authored
Removes ExitReason enum: This is used to report screen exit, and was translated to the appropriate screen exit code in OnExit. Instead pass the ScreenExitCode directly to OnExit method (also, removes unnecessary update engine client status check from OnExit - the code is moved to the calling site, which already uses the update status). Removes UpdateScree::InstanceSet: The only remaining usage was to check whether a screen bound to a callback sent to UpdateEngineClient has been removed - the same can be achieved using a weak_ptr. BUG=None Change-Id: Ic5ccb3d280c6380b10a55dccfb3143278d421497 Reviewed-on: https://chromium-review.googlesource.com/c/1478264Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#634297}
-
Nico Weber authored
TBR=danakj,avi Bug: 926235 Change-Id: I83c82ee0d408dfd7489dcc0f9b50a50b399b6008 Reviewed-on: https://chromium-review.googlesource.com/c/1479838 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634296}
-
Marijn Kruisselbrink authored
This should make onion souping slightly easier, but also gets us closer to making sure that tasks run on the correct frame associated task runners. In a follow-up CL the AppCacheFrontend mojo binding can be changed to use correct per frame task runners. Also removes AppCacheFrontendProxy (in the browser) and AppCacheFrontendImpl (in the renderer), as those layers of indirection are no longer needed. Bug: 611938 Change-Id: I4d50a0f13f0d2624071b3c1734457be02483df60 Reviewed-on: https://chromium-review.googlesource.com/c/1478009 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#634295}
-
Tom Tan authored
RegisterNonABICompliantCodeRange needs to be implemented for arm64 is necessary. Bug: 893460, 933496 Change-Id: I12cb5a66dd2a9b9bd6df50b4463ecc9d982cbdb8 Reviewed-on: https://chromium-review.googlesource.com/c/1474637Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#634294}
-
Theresa authored
Merge IncognitoNewTabPageViewMD into IncognitoNewTabPageView and rename XML file. BUG=922690 Change-Id: I21e4c886fdbcc6dc666a985174803b8ad205695b Reviewed-on: https://chromium-review.googlesource.com/c/1480690Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#634293}
-
