- 19 Dec, 2019 40 commits
-
-
Joshua Peraza authored
b411976ca5f4 [log minidump] add tool to encode/decode minidump log 38f4bae3ad84 chromeos: fix minidump-dir-for-tests flag Change-Id: Ibd0d5fc15aa286951de9da2f3e923b45ad44fe13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976831 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#726534}
-
Amy Huang authored
Change-Id: I34125effba684908abb1a6983b641419d63242b6 Bug: 1035977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976019 Commit-Queue: Amy Huang <akhuang@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#726533}
-
Etienne Bergeron authored
The glyph_spacing(...) is only valid for Obscured text. As an example, this cannot work with arabic characters. It will break words in piece. The concept is only used for password. Let rename to ObscuredGlyphSpacing to make it obvious it is only working when the text is obscured. Also removing the DCHECK failing when the text is not obscured. It is assumed now that the width is not used for un-obscured text. That DCHECK was often failing while fuzzing. TBR=tbarzic@chromium.org Bug: 1025561 Change-Id: I1700b4047bec9090d5c6719381923f14d9cd8e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976013 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#726532}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mpearson@chromium.org Bug: 1023677 Change-Id: I8457197c508331469733229d84653115c9d77705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957559 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#726531}
-
minch authored
Separate the logic to add 'sign out', 'lock' and 'feedback' items to power button menu. This will help make the logic clear and easier to understand. The logic is based on current login status, do not show 'feedback' item while in login, lock screen or kiosk mode. We may have the plan to add 'feedback' to login and lock screen page. Add 'feedback' item to the menu in these two cases is not enough to support it, since the actual logic to send feedback is different while in login or lock screen. Tracked at crbug.com/1019743. Test: PowerButtonControllerTest* Bug: b/143769143 Change-Id: Id0d0327fc56bdd39c0d7f80b9313311e5f69837e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976435Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#726530}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9dec123fec99..7b55aac3b366 git log 9dec123fec99..7b55aac3b366 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 gary.sweet@broadcom.com Add Broadcom as a known vendor Created with: gclient setdep -r src/third_party/angle@7b55aac3b366 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I69501b9eed09cf98bb3cbcbdc32ee51ef6a61d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976660Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726529}
-
Yulun Wu authored
Bug: 1035139 Change-Id: I606d940b5939382b94f1b7f068729f58f0e2e3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972788 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#726528}
-
yjliu authored
Because blur turns out to be very expensive and we'd like to detect and remove double background blur when unnecessary for ui when DCheck is on and the command line switch --log-on-ui-double-background-blur is on. The calculation is done in CalculateDrawProperties() when the screen space rects are available to avoid double calculation at ui side. TEST=manual with dcheck on Bug: 1030115 Change-Id: I8caca0fa536553ff50a8ae5657e0387e7008c36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958586Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Auto-Submit: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726527}
-
Mike Wittman authored
Records timestamps along with samples and plumbs them through to the ProfileBuilder interface. The CallStackProfileBuilder subclass will be updated in a following CL to record the timestamps, to support retrospective tagging of metadata on the samples. Bug: 1034758 Change-Id: Ic631d47773db5ce8ed5117c08aba5d5931cb7884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972931Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#726526}
-
meacer authored
This CL adds a list of Ethiopic characters that look like Latin characters. A domain consisting only of these characters and not having .et or .er ccTLDs will be converted to punycode, as is done for other whole-script-confusables such as Cyrillic and Hebrew. This change doesn't affect any popular real world domain. Bug: 722167 Change-Id: I847e31d1d999a0ec8dafc699068797990636f45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976822 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#726525}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a8352ccaae37..e6d31bd0894c git log a8352ccaae37..e6d31bd0894c --date=short --first-parent --format='%ad %ae %s' 2019-12-19 benjaminwagner@google.com [infra] Use unbuffered I/O for run_recipe 2019-12-19 reed@google.com extend imageshader updater to handle perspective 2019-12-19 jvanverth@google.com Tweak smallpaths so new paths will show up in GM. Created with: gclient setdep -r src/third_party/skia@e6d31bd0894c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Ic86dc15fecf43e9f8058c4aae9cdb77645ba85d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726524}
-
Tomasz Wiszkowski authored
Bug: 992024, 991039 Change-Id: I3359e20a67c5a40d10a704c92525e6c7a1cc9f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976799Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#726523}
-
Eric Stevenson authored
This reverts commit 4ede9b9f. Reason for revert: Broke https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/7663 Original change's description: > Android: Clean up trichrome synchronized proguard build rules. > > * Remove static_library_proguard_disabled and instead separate > static_library_provider and static_library_synchronized_proguard > into separate flags. > * Only enable synchronized proguard for the most basic Trichrome > targets (can enable for others when we want to ship). > * Add a real dep on static library provider APKs (so that they don't > both need to be compiled explicitly). > * Clean up stale GN variables. > > Bug: 921284, 901465 > Change-Id: I346fe3e824ece041cd1df064e81b2939e64c6882 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955802 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726483} TBR=torne@chromium.org,cjgrant@chromium.org,agrieve@chromium.org,estevenson@chromium.org Change-Id: Ic3aaba93577e7f6b7bd92bc21bc72782cc4f981c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 921284, 901465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977063Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#726522}
-
Sergey Ulanov authored
Software video decoders were disabled in the default context used in cast_runner, but not in the isolated context. It should be disabled for all context instances used in cast. Bug: 1035226 Change-Id: I5c17196e590a07b4e9557f353912786fcd04c9b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971052 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#726521}
-
Henrique Nakashima authored
This reduces merge conflicts and makes it clearer where new constants should be placed. Change-Id: Ibc8cf11c84664ecfa43a4d9e6ddd245b81e7dcbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976819 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#726520}
-
Nicolás Peña Moreno authored
This change ships the buffered flag and implements the UseCounter to track how often the buffer becomes full. WindowPerformance is subscribed to observe longtasks upon construction, and only unsubscribed when the GC kicks in. This allows us to remove UpdateLongTaskInstrumentation() and should be performant assuming the counter confirms that most page loads do not fill up the buffer. First attempt: https://chromium-review.googlesource.com/c/chromium/src/+/1956075 Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/cX5ahS7nCFw Bug: 1016815 Change-Id: I1003c6cf8fc34dbf9dd1cca5d60e33c8df841b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975994 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#726519}
-
Gavin Williams authored
-Now in ChromeVox if navigated to, these icons will attempt to read out the current resolution. The desired behavior should be to read the name of the setting then state that its value is enforced by a policy. http://screenshot/wKGOLhctJpS Fixed: 988031 Change-Id: Ieac0155068696cd65fb6948328d8008b2c1c15cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954867 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#726518}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=dnicoara@chromium.org Bug: 1023677 Change-Id: Iaa5c632635dbd0bb834b4c98067fd257f6727f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957543 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#726517}
-
Stephen Chenney authored
The logic for LayoutUnit::SnapSizeToPixel maps the size to the closest pixel align edge given a location. When a size of width less than 1 happens to straddle a pixel aligned edge this forces the size to zero. Force the size to always be non-zero if the input size is non-zero, and change PhysicalRect to use the LayoutRect snapping to get correct cull rects. Bug: 793785 Change-Id: Ia4c30d10c389fb4677006441aac9ee380a7c2f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948057 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726516}
-
Kevin Qin authored
The old implementation was sort of a hack to be able to figure out what values to appropriately set based on the configured IPD that the device set (since one test set specific colors and also had a different IPD than the rest).The new implementation fix this by reading back from the texture. So the hack is no longer needed. These should instead store the pixels to a texture when the frame is submitted, and then read back from the texture. Tests affected as of 8/28/2019: WebXrVrOpenXrBrowserTest.TestPresentationPixels WebXrVrOpenXrBrowserTest.TestPresentationPoses WebXrVrOpenXrBrowserTest.TestLocationIndicatorWhenUserAskedToPrompt WebXrVrOpenXrBrowserTest,TestMultipleInitialIndicators_OneDeviceAllowed Fixed: 986621 Change-Id: I18421f1adc136bb4e1799026af486cfe85fbff05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970257 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#726515}
-
Ahmed Mehfooz authored
If notification bar isn't visible the focus is already on the first notification. Change-Id: Ibc707d40687b601598258b8f318321520f16eeaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974706Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#726514}
-
shrekshao authored
Manual roll of WebGL to certain commit (not latest) because https://github.com/KhronosGroup/WebGL/pull/2978 would cause bot failure and the fix https://github.com/KhronosGroup/WebGL/pull/2980 hasn't been merged. https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/dd55f3c..53655df TBR=kbr@chromium.org Bug: 1000354, 1003860 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I0164f91032d4c0ab21f059eff5bfbb81d85cf28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976152Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#726513}
-
sczs authored
-This CL is part of the history_ui_egtest migration, in which resetBrowsingDataPrefs used to live. -Cleans up un-used imports and DEPS from history_ui_egtest. Change-Id: Ie3683213564d22659a9118761206582f71ee502f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976154Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#726512}
-
Nick Harper authored
Removal was requested via email after a change of ownership of the domain. Removal request was verified via a DNS challenge. Change-Id: Ia528bcd2d6107eb827f431b4e944004930986bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976286 Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#726511}
-
Chris Lu authored
This situation can be triggered by the Translate Infobar being shown and the page is translated when the user taps on the Translate button in the Overflow menu. In this situation, the new step (AFTER_TRANSLATE) matches the current state. Bug: 1033888 Change-Id: I4f330e8b32d75931551273218017019baacac21c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975691 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#726510}
-
Adithya Srinivasan authored
It seems that unlike EvalJs, ExecJs doesn't wait for promises to resolve before returning. This fixes existing portal browsertests to use EvalJs when waiting for a promise. Change-Id: Ib1cdb50e79b19fd8296f6b29fd8fbf9931c92ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976193Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#726509}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ic9f85b749810bdfb685a71ce5163eb4d4335887f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976295Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#726508}
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers all of components/sync/ and the minimal set of necessary updates to client code elsewhere in the tree. Fixed: 1007739 Change-Id: I423028ab7b6f1b277b0a2e42a89a5a0ea09361c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975452 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#726507}
-
George Steel authored
Make target() return the originating element if target_ is a PseudoElement (EventTarget still returns the layout object). Add pseudoElement() property which returns the target pseudo-selector if the target is a pseudo-element (null otherwise). Invalid and unsupported pseudo-elements will still return a selector and the originating element (from target()) but will not animated (EventTarget returns null). Add pseudoElement option to KeyframeEffect constructor. Change-Id: Id7d16ea6966c533e56d1170462ff60a79b277fd5 Bug: 981894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921343 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#726506}
-
David Munro authored
* Capture every call to RestartCrostini so we can detect when we fail to reach the end (hang, crash, etc). * Move result logging to the destructor to close some gaps where we wouldn't log result * Default is_initial_install_ to false instead of true. When multiple restarts are queued only the first gets is_initial_install set correctly so we'd miss emitting metrics in that case. Now we rely on the installer to dedupe multiple installation requests and otherwise emit result for every run. Bug: chromium:1031925 Test: Unit tests. Change-Id: If348669a1e1e95f5bf24b148d2d6fd341078278e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965741Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#726505}
-
Koji Ishii authored
This patch fixes `text-overflow: ellipsis` to take the space occupied by `text-indent` into the account. Bug: 1006395 Change-Id: I417176efbc8f10fa3c073efa7695458fb2d302a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975372Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#726504}
-
Natalie Chouinard authored
Create separate Settings module, and build SettingsUtils.java in this new target. Bug: 1035928 Change-Id: I906b860d7486569305757acac0a56ec4a545d5e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976153Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#726503}
-
Caleb Rouleau authored
https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8893636477245975664/+/steps/dawn_perf_tests_on_ATI_GPU_on_Mac_on_Mac-10.13.3/0/logs/Merge_script_log/0 Traceback (most recent call last): File /b/s/w/ir/cache/builder/src/tools/perf/process_perf_results.py, line 361, in process_perf_results configuration_name, build_properties, extra_links, output_results_dir) File /b/s/w/ir/cache/builder/src/tools/perf/process_perf_results.py, line 548, in _handle_perf_results is_reference, upload_failure=not upload_succeed) File /b/s/w/ir/cache/builder/src/tools/perf/process_perf_results.py, line 580, in _write_perf_data_to_logfile json.dump(results, output_json_file, UnboundLocalError: local variable 'results' referenced before assignment Bug: 1035590 Change-Id: I6d0fd9373f94d6484ce42cf867a50e302ef428d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976294 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726502}
-
nancy authored
TBR=joelhockey@chromium.org BUG=1011235 Change-Id: Ia48be8b3e6b5d03bcb1c505ab405c536786cae7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975381Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726501}
-
Mario Sanchez Prada authored
This file contains references to old mojo types and so removing it will both reduce dead code in the repository and remove instances to old mojo types, so let's delete it. Bug: 955171 Change-Id: I04682b47cae9bc676c4da301b4e4337c12594a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975914Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#726500}
-
Tom Anderson authored
There were 32 linux documents in docs. It's getting out of hand, so lets move them to a subdirectory. R=sky,jorgelo CC=thestig BUG=None Change-Id: Ib7de415c72fe6ec3c51dc2b28f06b34487b5b6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974901 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#726499}
-
Mark Schillaci authored
Updated BrowserAccessibilityAndroid::IsClickable() to default to whether a node is a control on Android, rather than if a node is focusable. Added a test case to DumpAccessibilityTreeTests for non-focusable nodes (e.g. tabIndex=-1) with expected output. Bug: 1023229 Change-Id: I588df1f438f5391445c9ded514c526a06f3a65d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953646Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#726498}
-
Caleb Rouleau authored
Bug: 1035696 Change-Id: Ifb123b04337f3a899422ee0337dfde8ecf4f57d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975158 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#726497}
-
Caleb Rouleau authored
The upload for these is hanging on mac. My guess is that the root cause is the same as for windows where it hits a 403. However, the result is much worse for mac because it waits for over an hour before it hits the overall timeout. The longterm solution is to convert dawn_perf_tests to histograms. Bug: 1035590 Change-Id: I9070d04e527cc4387ba793963de78fa73141a0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976020 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#726496}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e020cf38f429..addc9bfc6cd1 git log e020cf38f429..addc9bfc6cd1 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 thestig@chromium.org Expose MakeTag() as CFX_FontMapper::MakeTag(). 2019-12-19 thestig@chromium.org Switch testing/image_diff/ code to use uint8_t instead of unsigned char. 2019-12-19 thestig@chromium.org Add core/fxcrt/byteorder.h. 2019-12-19 thestig@chromium.org Do less work in XFATestEnvironment::SetUp(). 2019-12-19 thestig@chromium.org Remove some references to fxcrt namespace. 2019-12-19 thestig@chromium.org Avoid using std::function to improve performance. 2019-12-19 nigi@chromium.org Remove parsing decimal numbers in StringToCode(). Created with: gclient setdep -r src/third_party/pdfium@addc9bfc6cd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I7b4b7ff062b46de17934f76ac304d66a44d4355e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976661Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726495}
-