- 26 Jan, 2018 40 commits
-
-
Steve Anton authored
https://webrtc-review.googlesource.com/c/src/+/41042 will change an error message in CreateAnswer which would break this WPT. Once the WebRTC CL has rolled in the test expectation will be updated and the test re-enabled. Bug: 806005 Change-Id: I53855be0dcc23bb76a6a6087761198beb82262dc Reviewed-on: https://chromium-review.googlesource.com/887371Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#532041}
-
Réda Housni Alaoui authored
Fixes for reland number 6: - "Win10 Tester" capture_unittests failure - "Win8 Tester" capture_unittests failure Fixes for reland number 5: - "Win10 Tester" browser_tests_functional failure - "Win8 Tester" browser_tests_functional failure Fixes for reland number 4: - "Win10 Tester" browser_tests_functional failure - "Win8 Tester" browser_tests_functional failure - "Win8 Tester" capture_unittests failure Fixes for reland number 3: - "Win10 Tester" browser_tests_functional failure - "Win10 Tester" capture_unittests failure - "Win8 Tester" browser_tests_functional failure - "Win8 Tester" capture_unittests failure Fixes for reland number 2: - "Win10 Tester" browser_tests_functional failure - "Win10 Tester" capture_unittests failure - "Win8 Tester" browser_tests_functional failure - "Win8 Tester" capture_unittests failure Fixes for reland number 1: - "Win8 Tester" browser_tests_functional failure - "Win8 Tester" capture_unittests failure Original description: - Full rewrite of the MediaFoundation implementation video part to use IMFCaptureEngine - Implementation of takePhoto, setPhotoOptions and getPhotoCapabilities - takePhoto triggers a still image capture with the highest available resolution without stopping the video stream thanks to IMFCaptureEngine TEST=adapted video_capture_device_unittest.cc and webrtc_image_capture_browsertest.cc; launch Chrome with --force-mediafoundation on Win8+ and capture video using e.g. https://webrtc.github.io/samples/src/content/getusermedia/gum/ R=mcasas@chromium.org Bug: 730068 Change-Id: I7b7ff88f2db8d71f46428a2ecbb733e18a25a334 Reviewed-on: https://chromium-review.googlesource.com/734042 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Original-Original-Original-Original-Original-Commit-Position: refs/heads/master@{#521435} Reviewed-on: https://chromium-review.googlesource.com/810766 Cr-Original-Original-Original-Original-Commit-Position: refs/heads/master@{#524417} Reviewed-on: https://chromium-review.googlesource.com/843974 Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#527139} Reviewed-on: https://chromium-review.googlesource.com/852455 Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#528005} Reviewed-on: https://chromium-review.googlesource.com/858138 Cr-Original-Commit-Position: refs/heads/master@{#531109} Reviewed-on: https://chromium-review.googlesource.com/885815 Cr-Commit-Position: refs/heads/master@{#532040}
-
Miriam Gershenson authored
The async resolver has some Android-version-specific problems. This will allow enabling it via Finch for newer Android before the problems with older Android are worked out. Bug: 768874, 805020 Change-Id: Iec9aeaa255dbb110103ae7ca7ffe8b19dbded235 Reviewed-on: https://chromium-review.googlesource.com/887601Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#532039}
-
Zhongyi Shi authored
No Flag update. Some changes to quic_connection_test, including: 1) fix stream offset to make it increases monotonically. 2) Refactor out SendRstStream. Merge internal change: 182410984 https://chromium-review.googlesource.com/c/chromium/src/+/879753/ relnote: Stores SpdyHeaderBlocks directly in QuicClientPromisedInfo, rather than holding them via unique_ptr. No functional change. Merge internal change: 182114281 https://chromium-review.googlesource.com/c/chromium/src/+/879841/ relnote: Add two new QUIC connection options to experiment with different max ack delay behaviors, one that ignores ack delay and one that sets the default to 25ms instead of 0ms. Protected by quic_reloadable_flag_quic_max_ack_delay. Merge internal change: 182103603 https://chromium-review.googlesource.com/c/chromium/src/+/879435 Change-Id: If84cf1ae1eb3609380e95a24aefd9d87b555f40e Reviewed-on: https://chromium-review.googlesource.com/883778 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#532038}
-
Brian White authored
Bug: 806050 Change-Id: Id1606fa8739937ff0dcdaec36f3a532a8a18155c Reviewed-on: https://chromium-review.googlesource.com/887641Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#532037}
-
Marijn Kruisselbrink authored
BlobEntryRegistry will DCHECK when presented with invalid blob URLs, so both make sure the renderer doesn't send such URLs, and kill the renderer if it does happen to do so. Bug: 756743 Change-Id: Ife653cc4d8687fc30c8a03336caa66905951556b Reviewed-on: https://chromium-review.googlesource.com/884522Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#532036}
-
Fady Samuel authored
This CL introduces the notion of a default lower bound deadline. Prior to this CL, if any SurfaceLayer specified a deadline lower than the default deadline then the whole CompositorFrame would get a deadline of that SurfaceLayer which could break synchronization expectations of other SurfaceLayers. Instead, now base::nullopt for the deadline parameter of SetPrimarySurfaceId indicates to use the default deadline as specified by the Viz service. The deadline of a CompositorFrame is effectively the max of all the deadlines of the SurfaceLayer without the non-specified deadline indicating use the default. Thus, if any SurfaceLayer has a lower deadline, that deadline will not be used unless it is the only activation dependency in the next produced CompositorFrame. If the CompositorFrame contains other changing surfaces, then the maximum of the deadlines (including default if base::nullopt) will be used. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iad6dd5a4d797705fcf02b9f02e45ee0994a6ee15 Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/884261 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#532035}
-
WC Leung authored
The captioned test is now fixed, so we enable the test again. This is a revert of https://chromium-review.googlesource.com/827006. Bug: 794821 Change-Id: Icabf8e2fed02d0b2c3220af7e1a1001afbaadbfd Reviewed-on: https://chromium-review.googlesource.com/883821Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#532034}
-
Tommy C. Li authored
This CL enables showing the elided permanent URLs when the flag is on. It also restores the full URL on focus and puts back the elided one on blur (assuming it hasn't been edited). No selection adjustment logic exists in this CL. Bug: 797354 Change-Id: I1fc6a8aa37aaf4582db2b6895a1292006da3114b Reviewed-on: https://chromium-review.googlesource.com/882617 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#532033}
-
Chris Nardi authored
CSS Color 4 states that all numbers should be parsed inside of the RGB and RGBA functions, instead of only integers as previously defined. This change updates our behavior to match this, with non-integers rounded to the nearest value. This additionally changes the behavior of percentage values, multiplying by 255 and rounding to match the spec instead of multiplying by 256 and flooring. The new spec is located at https://drafts.csswg.org/css-color-4/#rgb-functions. Bug: 703898 Change-Id: I826e92e7f81576240ad9b06f866df3300140b12c Reviewed-on: https://chromium-review.googlesource.com/885004Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532032}
-
Chris Harrelson authored
Bug: 798378 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic3c0b29430b06e76a3c81e654bc780e4a969592d Reviewed-on: https://chromium-review.googlesource.com/880403 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#532031}
-
Mike Wasserman authored
This refines my earlier work done in: http://crrev.com/c/842467 Move event target nulling and root location use to WindowTreeClient, to ensure events reach MusUnifiedEventTargeter. Otherwise, WindowEventDispatcher::GetInitialEventTarget will use the touch gesture recognizer's target (returned by GetPriorityTargetInRootWindow) before performing the mirror display transformation on the event's location. Inline DispatchEventToTarget for additional clarity. Bug: 805714 Test: Mus touch events work in Chrome OS's unified desktop mode. Change-Id: Ic4844c85cc24a9f9885e7705ff27cb57b305d245 Reviewed-on: https://chromium-review.googlesource.com/887250 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#532030}
-
Sammie Quon authored
Sometimes windows can be very long or very tall outside of overview mode. These windows will either become super wide or super skinny after entering overvie wmode. This is not ideal as too wide -> takes up too much space and too skinny -> users cannot see the title. Clamps the width to be within 0.5 and 2 times the height. Windows will still keep their aspect ratio, so the resulting window is centered in the window selector item. https://screenshot.googleplex.com/dSfEciJ5CPd The above screenshot shows the effect of this CL (minus the blue and red borders which help visualize). The extreme windows will look they are floating since the backdrop is not implemented yet. But this cl is all behind a switch. Test: ash_unittests WindowSelectorTest.ExtremeWindowBounds Bug: 782320 Change-Id: Id337eb091fcc4f1297ae8f864175c7f06b10b71c Reviewed-on: https://chromium-review.googlesource.com/869051 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#532029}
-
Alexei Filippov authored
Do not create Sample object ahead. Moved all the hooks into the SamplingNativeHeapProfiler class to improve code readability. BUG=803276 Change-Id: I88a920c338d19fc89689c3f797d2c002a3d976cb Reviewed-on: https://chromium-review.googlesource.com/879595 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#532028}
-
Ilya Sherman authored
When the safe seed and the latest seed have identical contents, use a sentinel value to avoid storing a duplicate value for the two seeds. This is purely a storage space optimization; no difference in observed functionality is expected. R=asvitkine@chromium.org Bug: 727984 Change-Id: Ica641a479228b0cdfcc4af2ec04ddfc54c36c5eb Reviewed-on: https://chromium-review.googlesource.com/880482 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#532027}
-
Wenzhao Zang authored
The criteria of opening wallpaper picker should be consistent between the settings page [1] and the shelf context menu [2]. Another pending CL [3] will combine these two places to avoid duplicate logic. The criteria of whether to show the 'shelf position' option remains unchanged and it should be separate from the logic of wallpaper picker. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/appearance_handler.cc?q=appearance_handler&sq=package:chromium&dr=C&l=76 [2] https://cs.chromium.org/chromium/src/chrome/browser/chromeos/background/ash_wallpaper_delegate.cc?dr=C&q=ash_wallpaper&sq=package:chromium&l=73 [3] https://chromium-review.googlesource.com/c/chromium/src/+/848193 Bug: 806051 Change-Id: I99da5e9bfef4dc02a2cdc53b33862d6310d88e14 Reviewed-on: https://chromium-review.googlesource.com/887251 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532026}
-
Elliot Glaysher authored
This resolves the problem where the hardware cursor is shown in one window when unified mode is turned on. We might not have an active pref service yet, so move the checks that don't depend on preferences before checking the pref service. Bug: 805719 Change-Id: I92c1ea1a47a0cd63f695fc792e1fe025ee715962 Reviewed-on: https://chromium-review.googlesource.com/887288 Commit-Queue: Elliot Glaysher <erg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#532025}
-
Theresa authored
BUG=805976 Change-Id: I7c3a973b52c512fef38398e3bc98c1e9c848ebe4 Reviewed-on: https://chromium-review.googlesource.com/887563 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#532024}
-
Alex Newcomer authored
UX request: - Don't dismiss AppList if the right click/two finger tap is on the shield of the AppList. - Added a test. Bug: 805937 Change-Id: Id38b5872c3836680d08adbcb84922fe62201be19 Reviewed-on: https://chromium-review.googlesource.com/887282Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#532023}
-
Jun Cai authored
Currently, the device motion/orientation event pump requests the sensor data reporting frequency to be 60Hz. However on some devices, this frequency is larger than the maximum frequency the device can provide. This CL modifies device event pump code to set the sensor frequency not exceed the maximum frequency the platform supports. Bug: 796518 Change-Id: I1cd6215f3b35498482ed3ca26cd9b44d4eb7eb1e Reviewed-on: https://chromium-review.googlesource.com/879586Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#532022}
-
Joe Downing authored
I've seen this issue on local builds sporadically and have also seen reports in the field. What appears to happen is the user starts an It2Me connection and while waiting for the connection to be established, remoting::ClientSession::OnConnectionClosed() is called and we clean up all of the connection classes. Since the connection was never accepted, we did not call 'Start()' on the InputInjector which means the underlying TouchInjector instance was never initialized. When 'Stop()' is called as part of shutdown, the TouchInjector* is null and we crash. BUG=722372 Change-Id: Idae60d7a6951d009a8ff82d3523840a8e719ac71 Reviewed-on: https://chromium-review.googlesource.com/887646Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#532021}
-
Ryan Landay authored
This CL adds support for inheriting the autocapitalize attribute from a form owner as described in the new spec for autocapitalize: https://html.spec.whatwg.org/multipage/interaction.html#autocapitalization This CL also adds tests for this new behavior. Bug: 776618 Change-Id: Ib96354fb320736255369bd2df3113e172dfdb42e Reviewed-on: https://chromium-review.googlesource.com/872090Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#532020}
-
Qiang(Joe) Xu authored
This reverts commit 32bff724. Reason for revert: causing chrome pfq HWTest failure: crbug.com/805966 Original change's description: > [subresource_filter] Enable SubresourceFilter experiment by default > > This also enables the filtering after a phishing interstitial by > default. > > Bug: None > Change-Id: Icb5a074575e2cf1ecd69d5e0ccfb573cf06cf799 > Reviewed-on: https://chromium-review.googlesource.com/729144 > Reviewed-by: Shivani Sharma <shivanisha@chromium.org> > Commit-Queue: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531639} TBR=csharrison@chromium.org,shivanisha@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 805966 Change-Id: Ie448e5e468d9f4b00eaf63754acac952acad06af Reviewed-on: https://chromium-review.googlesource.com/887290 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#532019}
-
Kenneth Russell authored
virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/ touchpad-scroll-impl-to-main.html is crashing, also, on Mac. Skip it until it's fixed. NOTRY=true TBR=sahel@chromium.org Bug: 800840 Change-Id: I1ad8fe7f8a5f226ca9253a11dea09b34c4596003 Reviewed-on: https://chromium-review.googlesource.com/889379Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#532018}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee5d9a0c..508734bf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Iea808b6dc0fe05dcfd15ba49f7ef9c1863ede12a Reviewed-on: https://chromium-review.googlesource.com/887401Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#532017}
-
Marijn Kruisselbrink authored
Or to be more precise, add a version of the CreateBlobInExtensionOrigin test that uses the mojo blob URL code path. Bug: 777585 Change-Id: Ife85fd3880994b2c2634dc7dbf54581ec0b7e30e Reviewed-on: https://chromium-review.googlesource.com/882560Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#532016}
-
Kinuko Yasuda authored
http/tests/devtools/network/oopif-targets.js failing since it's added in r531805 Looks like the same reason as the other oopif test (DCHECK(creator) crash in RFI::GetSubresourceLoaderFactories). TBR=yzshen@chromium.org NOTRY=true Bug: 805310 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9c2e957986ba3756e6d0c3f51a9135d426f601a5 Reviewed-on: https://chromium-review.googlesource.com/888227 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#532015}
-
Scott Graham authored
Updates clang toolchain_libs path to 7.0.0. Includes https://fuchsia-review.googlesource.com/c/zircon/+/115121 which should fix component builds crashes. Also renames calls from zx_time_get() to zx_clock_get() per recent Fuchsia syscall change. TBR=kmackay@chromium.org Bug: 724204, 707030, 803110 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If2cb1d320c27b60fb32b0337ce1c6d2886b45b33 Reviewed-on: https://chromium-review.googlesource.com/884822Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#532014}
-
Gabriel Charette authored
This CL saves 27KB in chrome.dll and 5KB in chrome_child.dll. https://chromium-review.googlesource.com/868013 had regressed size by 9KB and was caught as a performance regression. This CL should recover this 3X. Also removed an extra atomic operation in the simple case (used to atomic-load for check and atomic-load again for return, now only atomic-loads once). Also moved GetOrCreateLazyPointer() to a subtle:: namespace (now that calling it is tricky), also resolving recurring confusion about whether Needs/CompleteLazyInstance() are invoked outside of it (they're not, they're strictly helpers). R=fdoray@chromium.org, thakis@chromium.org Bug: 804034 Change-Id: I8de94fe742a8f9a68d4a66e0202a6fb276843af9 Reviewed-on: https://chromium-review.googlesource.com/883364Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#532013}
-
Theresa authored
Introduce a new AnchoredPopupWindow class, containing most of the logic previously in TextBubble, and refactor TextBubble to use this new class. Also introduces a ViewRectProvider that contains most of the logic previously in ViewAnchoredTextBubble. This lays the ground work for using AnchoredPopupWindow (with extra positioning customization/logic) for ListMenuButton to work around a bug in Android ListPopupWindow positioning introduced in Android N. BUG=709522 Change-Id: Ie6364ddcbd7b84736650ad3df8d433e1a75be6b6 Reviewed-on: https://chromium-review.googlesource.com/884328 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#532012}
-
Xing Liu authored
Refactor RunLoop::RunUntilIdle call in a while loop into an observer class that only hold one RunLoop. RunLoop::RunUntilIdle in a while loop may never return in multithread context on Android platform. Bug: 786626 Change-Id: Ic5deb53e892d9c6303346eb6a7f803c89eddd26d Reviewed-on: https://chromium-review.googlesource.com/882183 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#532011}
-
David Tseng authored
Bug: 800948 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia0a314d12ad121dd5748bbeb2ab5213920772d16 Reviewed-on: https://chromium-review.googlesource.com/881956Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#532010}
-
Leonard Grey authored
This came up in UX review. From Material Guidelines: "Clocks still turn clockwise for RTL languages. A clock icon or a circular refresh or progress indicator with an arrow pointing clockwise should not be mirrored." Bug: 805921 Change-Id: I1d345727b8656964b0574af9ccdc7d5dc26f8661 Reviewed-on: https://chromium-review.googlesource.com/887301Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#532009}
-
Zach Stein authored
These objects were not intended to be live. We still cache the objects returned by WebRTC here so that multiple calls to getContributingSources return the same objects when called multiple times in the same event loop. Further discussion here: https://github.com/w3c/webrtc-pc/issues/1533 Change-Id: Iada7583f7b30ae06477efe438e93ef4596d02ca1 Reviewed-on: https://chromium-review.googlesource.com/877336Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Zach Stein <zstein@google.com> Cr-Commit-Position: refs/heads/master@{#532008}
-
khmel authored
This forces ARC OptIn OOBE for all devices. Test: Manually + test_that minnie suite:bvt-arc Bug: b/69807512 Change-Id: Iab37c463cc2c65fd25879ca9df382304f581ccb3 Reviewed-on: https://chromium-review.googlesource.com/884375 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#532007}
-
Julia Tuttle authored
Cronet doesn't support controlling base::Features, so move the base::Feature to //services/network (in a tiny component, because things break otherwise), and move the feature check itself to NetworkContext. (A future change will add an experimental option to Cronet to enable Reporting and NEL.) This is a fixed re-land of https://chromium-review.googlesource.com/c/chromium/src/+/858176. Bug: 799616 Change-Id: I79c8a011c75d6b79a92f9ffe85bf5d53d509dcbc Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/879441 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#532006}
-
Andrew Wilson authored
I think we have enough local knowledge on the Chrome OS Enterprise team to be owners of the enrollment code - this will also speed up the review process by allowing us to cycle reviews locally. Bug: none Change-Id: I9986d0d7cd38c8c5c5ed0b6d8badbbbccf9e0c83 Reviewed-on: https://chromium-review.googlesource.com/878333Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#532005}
-
Hidehiko Abe authored
BUG=784732 TEST=Ran trybot. Change-Id: Iec5f9eaa7482d4e23f5bf2eea4b34c9cd867f89d Reviewed-on: https://chromium-review.googlesource.com/856021 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#532004}
-
Yoland Yan authored
Merge two TestCommon into ActivityTestRule since there is no long need for sharing the implementation with other classes Bug: 711517 Change-Id: I21c902f76891e2e75b4716a924871e0c2410f30f Reviewed-on: https://chromium-review.googlesource.com/887341Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532003}
-
edchin authored
The call to |-rootViewController| is used to calculate the size of the autocomplete popup view in tablet, relative to the keyboard being shown. We now convert to the mainScreen coordinate space, which is the intended use of |-rootViewController|. Bug: 791787 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib6c8a6de473005de9ec2ce899990653662c1b64f Reviewed-on: https://chromium-review.googlesource.com/882311 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#532002}
-