- 16 Oct, 2018 40 commits
-
-
Justin Cohen authored
This is a reland of eb25f32f The CL was reverted with https://chromium-review.googlesource.com/c/chromium/src/+/1282949 but it looks like an infra problem instead TBR=justincohen@chromium.org,jbudorick@chromium.org Original change's description: > [ios] Move xcode-clang builders to Xcode 10. > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Change-Id: Ie5bdc140b82f49151ca891b39f65112bf6210eac > Reviewed-on: https://chromium-review.googlesource.com/c/1278332 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599804} Change-Id: I335dff58404b7bab44a5eab3c5b0337b38a572e3 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/c/1283016 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#599957}
-
Luke Zielinski authored
This field is always true going forward. Bug: 662944 Change-Id: I4dc3a3ac5aa5d7abf6d1a33b5f1a21f046881250 Reviewed-on: https://chromium-review.googlesource.com/c/1277867Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#599956}
-
Hitoshi Yoshida authored
Before this CL, IDL parser didn't accept types with extended atttributes as union members. This CL makes it possible. For example, ([TreatNullAs=EmptyString] DOMString or [Clamp] long) was an error, but it became acceptable. Bug: 894469 Change-Id: I2980256f5090f4465bef1b2a8665b0a9a9643b76 Reviewed-on: https://chromium-review.googlesource.com/c/1278614 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#599955}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I897e124f0320106f49bc9f7f99533d7cfd0b125b Reviewed-on: https://chromium-review.googlesource.com/c/1282644Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#599954}
-
Brian Salomon authored
This also enables per-edge AA for tile quads in SkiaRenderer. Bug: skia:8444 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Iaa14e6bd74128b838a5fcfac86789777d1936a7f Reviewed-on: https://chromium-review.googlesource.com/c/1266902Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#599953}
-
Etienne Pierre-doray authored
This is a reland of 8aeb9cc9 Original change's description: > [TaskScheduler]: Add section to faq: when to annotate with ScopedBlockingCall. > > Developpers are often wondering whether or not ScopedBlockingCall is redundant. > > Change-Id: Ic7936ef805f43f7fc02d0ad3020c31d8364b099d > Reviewed-on: https://chromium-review.googlesource.com/c/1271878 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599626} Change-Id: I0850821994e3b4a1b0c3bb238725bc28867d18f5 Reviewed-on: https://chromium-review.googlesource.com/c/1280281 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#599952}
-
Lukasz Suder authored
It's the basic version, that asks for payment and shipping details. (billing address cannot be saved yet.) Bug: 806868 Change-Id: Ic2f55e659f8254b3088dd99d8b388446fcb0cf7d Reviewed-on: https://chromium-review.googlesource.com/c/1280767 Commit-Queue: Lukasz Suder <lsuder@google.com> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#599951}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/079a94f7aec0..70bac6b6f68d git log 079a94f7aec0..70bac6b6f68d --date=short --no-merges --format='%ad %ae %s' 2018-10-16 ahassani@chromium.org paygen: catch and ignore GSNoSuchKey exception when looking for payloads Created with: gclient setdep -r src/third_party/chromite@70bac6b6f68d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib0640877c41bffcfca312f49bf825d6bb467004b Reviewed-on: https://chromium-review.googlesource.com/c/1282352Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599950}
-
Rune Lillesveen authored
Change-Id: Iafcde04a7a212025204a64da2b089939b19d200e Reviewed-on: https://chromium-review.googlesource.com/c/1282067 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599949}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c98f7a176af9..03c087e3eafe Created with: gclient setdep -r src-internal@03c087e3eafe The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1174563ffcad092adee020c02ae2701dc513ff01 Reviewed-on: https://chromium-review.googlesource.com/c/1283169Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599948}
-
Patrik Höglund authored
This should make the chromium.webrtc waterfall work like the old test config in recipes. It incorporates some fixes made in the recipe code and creates composite test suites for the chromium.webrtc bots. Bug: 877018 Change-Id: I11b91c4e9516844086978b5a63b816576197585b Reviewed-on: https://chromium-review.googlesource.com/c/1280669Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#599947}
-
Olivier Robin authored
Disable BottomToTopExpanded and BottomToTopCollapsed TBR: marq, kkhorimoto Bug: 880672 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If4c71557240e8589b52d6fe53491d661a5ff3a26 Reviewed-on: https://chromium-review.googlesource.com/c/1283029Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#599946}
-
David Davidović authored
This is a reland of 48c7a842 Original change's description: > [sync::test] Add two client integration test for custom passphrase > > Add a Sync integration test which exercises custom passphrase flows in > an end-to-end manner with two clients. The test ensures that two clients > can sync data properly in the presence of custom passphrase-based > encryption and different key derivation methods. > > Refactor SetScryptFeatureState() from the single-client test to a scoped > feature toggler that resides in encryption_helper, because the > functionality now needs to also be used from the two-client test. > > Bug: 894148 > Change-Id: Ia211b221f89a99092d3b19690ecae6bb4fa77d02 > Reviewed-on: https://chromium-review.googlesource.com/c/1277648 > Commit-Queue: David Davidović <davidovic@google.com> > Reviewed-by: vitaliii <vitaliii@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599929} Bug: 894148 Change-Id: I425db59e1427f2c3ebf1cb9cd8b2ee440fd31ce1 Reviewed-on: https://chromium-review.googlesource.com/c/1283012Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: David Davidović <davidovic@google.com> Cr-Commit-Position: refs/heads/master@{#599945}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f0e926fbdd8f..1927dfafabc0 git log f0e926fbdd8f..1927dfafabc0 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 magjed@webrtc.org Add tool for aligning color space of video files Created with: gclient setdep -r src/third_party/webrtc@1927dfafabc0 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic041226cf06b7150fb4a320b72202eed70b8cc08 Reviewed-on: https://chromium-review.googlesource.com/c/1282333Reviewed-by:
-
Gauthier Ambard authored
This CL moves the existing SettingsDetailItem to Legacy and creates a new SettingsDetailItem which is now a subclass of the TableViewItem. The new SettingsDetailItem now support Dynamic Type. Bug: 894791 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia001bf2bdd59bb71a81d228ebf7f905f5600eebf Reviewed-on: https://chromium-review.googlesource.com/c/1251625Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#599943}
-
Chris Hamilton authored
A recent albatross build is showing that this DCHECK is firing. Splitting apart the DCHECK will allow diagnosing which condition is failing. BUG=895520 Change-Id: I4dcb6a819b308ab407666c81b90536b8fcfef7cb Reviewed-on: https://chromium-review.googlesource.com/c/1282728Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#599942}
-
Finnur Thorarinsson authored
Also fix a couple of comments and make sure all icons are the same height. We might want to enlarge them all in a future CL, but they should at least match. Bug: 860467 Change-Id: I78eb219771a94aa41d7eb312f072ebde8cc65d56 Reviewed-on: https://chromium-review.googlesource.com/c/1280768Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#599941}
-
Mohamed Amir Yosef authored
If a commit succeeds, but the response does not come back fast enough then the |bookmark_tracker_| might assume that it was never committed. The server will track the client that sent up the original commit and return this in a get updates response. This CL makes sure that the processor detects this case and updates the persisted server id accordingly. Bug: 516866 Change-Id: Ida0e66345b3f55b6ac8b595ddb5c676024698706 Reviewed-on: https://chromium-review.googlesource.com/c/1280434 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#599940}
-
Tsuyoshi Horo authored
This feature was launched in M67. Bug: 788621 Change-Id: I59aaf51c5b129d7c01d90076c779a0a747c81d28 Reviewed-on: https://chromium-review.googlesource.com/c/1282483Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#599939}
-
Tsuyoshi Horo authored
This feature was launched in M65. Bug: 788619 Change-Id: Ia6f9794301f05b91fbd3edc5bbeddfe24944eadd Reviewed-on: https://chromium-review.googlesource.com/c/1282684Reviewed-by:
-
Raphael Kubo da Costa authored
When DCHECKs are enabled, this test crashes the test runner (but not when content_shell is run manually) and blocks WPT imports. When DCHECKs are disabled, the runner treats it as a pixel test and produces wrong results. TBR=foolip, robertma Bug: 895777 Change-Id: Ia0cb5bcbfb56a67e10bfd93a01ab6995fb02d328 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/1283130Reviewed-by:
Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#599937}
-
Vadym Doroshenko authored
This CL implements: 1.Processing of presaving of the generated password in NewPasswordFormManager. 2.Processing of other generation related actions: PasswordNoLongerGenerated etc 3.Teaching PasswordManager to use the right form manager for generation related actions and adding new methods in PasswordFormManagerInterface. 4.Adding |driver| into arguments of generation related functions in PasswordManager (in order to match correctly NewPasswordFormManager and the form with the generated password). Bug: 831123 Change-Id: I285a93d8a6b9b9d79cecd2aac747461f1650779e Reviewed-on: https://chromium-review.googlesource.com/c/1261696 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#599936}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Iec1e83d31a7feba4c2b6093b0597772d96a70c4a Reviewed-on: https://chromium-review.googlesource.com/c/1282332Reviewed-by:
-
Peter E Conn authored
Bug: 888447 Change-Id: Ia1e4f56f6c4f764602ce9c03d54906810958d902 Reviewed-on: https://chromium-review.googlesource.com/c/1280603 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#599934}
-
A Olsen authored
This is a reland of aa6c62dc Original change's description: > Move InstallAttributes to chromeos/settings > > Necessary for moving CrosSettings to chromeos/settings, so it > can eventually be used by Mustash. > > The following changes were necessary: > 1. Move install_attributes{.h, .cc} and unit_test.cc > 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn > (destination) > 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h, > which is included by install_attributes.h > > 4. Unfortunately, that same dependency lead to a circular dependency. > I was able to avoid that by separating out a "common_constants" rule in > components/policy/core/common, so that chromeos/settings only depends on > that, and not on all of components/policy. So I had to change > components/policy/core/common/BUILD.gn > and I removed an unnecessary include from > components/policy/core/common/cloud/cloud_policy_constants.cc > > 5. Update #include directives for install_attributes to point to new > location. This is the other 22 files, all with diffs of +1 -1. > > Bug: 446937 > Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288 > Reviewed-on: https://chromium-review.googlesource.com/c/1264757 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Commit-Queue: A Olsen <olsen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599140} Bug: 446937 Change-Id: If20ad953b2cb9c3808415c7c112eec8d0e97915b Reviewed-on: https://chromium-review.googlesource.com/c/1278750Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599933}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c9e6b969a452..f0e926fbdd8f git log c9e6b969a452..f0e926fbdd8f --date=short --no-merges --format='%ad %ae %s' 2018-10-16 tzik@chromium.org Add missing #include and deps to absl/memory 2018-10-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0e821c2f..0cecb6ce (599702:599821) 2018-10-15 srte@webrtc.org Reland "Deprecates legacy transport feedback adapter." 2018-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0df2607f..0e821c2f (599562:599702) Created with: gclient setdep -r src/third_party/webrtc@f0e926fbdd8f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:752720,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib8cd893ebca559660e96d2ad5f854a56091dc325 Reviewed-on: https://chromium-review.googlesource.com/c/1282329Reviewed-by:
-
Christos Froussios authored
This reverts commit 48c7a842. Reason for revert: Broke compile step https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ASan%20LSan%20Builder/60281 Original change's description: > [sync::test] Add two client integration test for custom passphrase > > Add a Sync integration test which exercises custom passphrase flows in > an end-to-end manner with two clients. The test ensures that two clients > can sync data properly in the presence of custom passphrase-based > encryption and different key derivation methods. > > Refactor SetScryptFeatureState() from the single-client test to a scoped > feature toggler that resides in encryption_helper, because the > functionality now needs to also be used from the two-client test. > > Bug: 894148 > Change-Id: Ia211b221f89a99092d3b19690ecae6bb4fa77d02 > Reviewed-on: https://chromium-review.googlesource.com/c/1277648 > Commit-Queue: David Davidović <davidovic@google.com> > Reviewed-by: vitaliii <vitaliii@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599929} TBR=treib@chromium.org,vitaliii@chromium.org,davidovic@google.com Change-Id: I8913698d352dc65ea9da27b052425a53394ff879 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894148 Reviewed-on: https://chromium-review.googlesource.com/c/1283030Reviewed-by:
-
Vitaliy Rebrov authored
It's important to explicitly shutdown history service if it's using own thread. Otherwise thread will keep working after calling RunUntilIdle() and will be able to post tasks to UI thread. This tasks will not be processed which will lead to leaking of HistoryDBTask (which is destroyed in this tasks). Change-Id: I63495794c257983dfdae3f3c7671d89e96eea8f8 Reviewed-on: https://chromium-review.googlesource.com/c/1280545Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#599930}
-
David Davidović authored
Add a Sync integration test which exercises custom passphrase flows in an end-to-end manner with two clients. The test ensures that two clients can sync data properly in the presence of custom passphrase-based encryption and different key derivation methods. Refactor SetScryptFeatureState() from the single-client test to a scoped feature toggler that resides in encryption_helper, because the functionality now needs to also be used from the two-client test. Bug: 894148 Change-Id: Ia211b221f89a99092d3b19690ecae6bb4fa77d02 Reviewed-on: https://chromium-review.googlesource.com/c/1277648 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
-
Sam McNally authored
Change the following tests to use FakeExtensionProvider instead of Drive as their instance of an external filesystem: - ArcFileSystemBridgeTest - FileManagerFileAPIUtilTest - ExternalFileURLRequestJobTest DriveFS uses a mostly-native filesystem so won't be usable for these tests. FakeExtensionProvider will continue being usable after DriveFS is enabled. Change FileManagerPrivateApiTest.Mount to disable Drive. DriveFS relies on DiskMountManager to mount. This test mocks out DiskMountManager rendering DriveFS unable to mount. Set up and populate a fake DriveFS instance for each profile in MultiProfileDriveFileSystemExtensionApiTest. Update FileManagerUrlUtilTest.GetFileManagerMainPageUrlWithParams_NoFileTypes with correct expectations depending on whether DriveFS is enabled. Also change it to not compare pretty-printed JSON strings so the difference between DriveFS enabled and disabled is clear. Bug: 891197 Change-Id: I2c1e582d0750a2a91cd24004f8ac552688e2a811 Reviewed-on: https://chromium-review.googlesource.com/c/1275826 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#599928}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/642641d03012..c68a1753c53a git log 642641d03012..c68a1753c53a --date=short --no-merges --format='%ad %ae %s' 2018-10-16 tandrii@chromium.org git cl try-results: delete Rietveld support. 2018-10-16 tandrii@chromium.org git cl: delete no longer used Rietveld methods. 2018-10-16 tandrii@chromium.org git cl: rename and relocate CreateDescriptionFromLog func. 2018-10-16 tandrii@chromium.org git cl description: rename gerrit test. Created with: gclient setdep -r src/third_party/depot_tools@c68a1753c53a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:770408,chromium:770408,chromium:770408 TBR=agable@chromium.org Change-Id: Ic4f1250d1162d63fd94b4636004ba2ce4a2ffc17 Reviewed-on: https://chromium-review.googlesource.com/c/1282350Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit c3e902dd. Reason for revert: this cl causes linux MSAN cc_unittests failures: RasterizeWithGpuRasterizationCreatesResources.RunMultiThread_DelegatingRenderer RasterBufferProviderTests/RasterBufferProviderTest.MeasureGpuRasterDuration/2 LayerTreeHostPictureTestResizeViewportWithGpuRaster.RunSingleThread_DelegatingRenderer [ RUN ] RasterizeWithGpuRasterizationCreatesResources.RunMultiThread_DelegatingRenderer ==2667==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5974de0 in Do<long> ./../../base/numerics/safe_math_clang_gcc_impl.h:74:13 #1 0x5974de0 in Do<long> ./../../base/numerics/checked_math_impl.h:54:0 #2 0x5974de0 in MathOp<CheckedAddOp, long> ./../../base/numerics/checked_math.h:245:0 #3 0x5974de0 in operator+=<long> ./../../base/numerics/checked_math.h:339:0 #4 0x5974de0 in base::time_internal::SaturatedAdd(base::TimeDelta, long) ./../../base/time/time.cc:70:0 #5 0x49b3d8e in operator+ ./../../base/time/time.h:207:22 #6 0x49b3d8e in cc::GpuRasterBufferProvider::CheckRasterFinishedQueries() ./../../cc/raster/gpu_raster_buffer_provider.cc:558:0 Seems, GetQueryObjectuivEXT doesn't always initialize gpu_duration: GLuint gpu_duration; ri->GetQueryObjectuivEXT(it->query_id, GL_QUERY_RESULT_EXT, &gpu_duration); Original change's description: > gpu: Add UMA metric for measuring total raster task duration. > > Add an UMA metric which reports the accumulated time for a raster task > including the time from raster worker thread and the GPU main thread. > The GPU side timer takes care of only measuring time slices when the > decoder is processing commands. > > R=vmiura@chromium.org, piman@chromium.org > > BUG: 894200 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: If02a76420dbdf5ffb5041b8290412d144d787fb4 > Reviewed-on: https://chromium-review.googlesource.com/c/1267235 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599870} TBR=enne@chromium.org,vmiura@chromium.org,holte@chromium.org,sunnyps@chromium.org,khushalsagar@chromium.org,piman@chromium.org Change-Id: I25b54841dca13aaa94cfc8dded8a40254f90d8e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/1282519Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#599926}
-
Sergio Villar Senin authored
It was using SigninManagerBase API to get the primary (authenticated) account id. It's now using the IdentityManager API. Bug: 890808 Change-Id: Ifabe11ca68de07949fcad2f81c022723dcb842ef Reviewed-on: https://chromium-review.googlesource.com/c/1276769Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#599925}
-
Peter E Conn authored
Since Origin logic was moved to Java, we can make the tests JUnit tests. Change-Id: Ied7b7d53bddb1847e81c62995f12d8ca82472852 Reviewed-on: https://chromium-review.googlesource.com/c/1280607 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
-
Christos Froussios authored
This reverts commit eb25f32f. Reason for revert: Suspect for build failures on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-device-xcode-clang Original change's description: > [ios] Move xcode-clang builders to Xcode 10. > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Change-Id: Ie5bdc140b82f49151ca891b39f65112bf6210eac > Reviewed-on: https://chromium-review.googlesource.com/c/1278332 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599804} TBR=justincohen@chromium.org,jbudorick@chromium.org Bug: 895761 Change-Id: I9b1b83455bd9b27fdf9b6e7120467e3e87305007 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/c/1282949Reviewed-by:
-
Mathias Bynens authored
The well-formed JSON.stringify() proposal changes JSON.stringify() to produce JavaScript/JSON-compatible escape sequences for any lone surrogates in its input. Because the test runner's `shouldBeEqualToString` uses `JSON.stringify` before comparing strings, these tests would otherwise break when shipping the `JSON.stringify()` change. Bug: v8:7782 Change-Id: If6ace9c023be8997ed10c8f1dbc2dcaed18c4687 Reviewed-on: https://chromium-review.googlesource.com/c/1281965 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#599922}
-
Luciano Pacheco authored
Rename error_util.js to error_counter.js to better describe its usage and avoid the generic term "util". Bug: 893430 Change-Id: I9cbb7f2f5ee09bf02d190dfb27d05e762bdde59f Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/c/1282682 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#599921}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6ea4d08b905d..bb3f58dbcb71 git log 6ea4d08b905d..bb3f58dbcb71 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 thestig@chromium.org Add pdfium_test --show-pageinfo to dump page bounding boxes. 2018-10-16 thestig@chromium.org Use more unique_ptrs in cfx_psrenderer.cpp for FaxCompressData(). 2018-10-16 thestig@chromium.org Make {A85,RunLength}Encode()'s buffer out parameter a unique_ptr. Created with: gclient setdep -r src/third_party/pdfium@bb3f58dbcb71 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I632d5f7ef143a9f431663bd146884e8f2cf95263 Reviewed-on: https://chromium-review.googlesource.com/c/1282351Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f73b9a1f180..c98f7a176af9 Created with: gclient setdep -r src-internal@c98f7a176af9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id86a7a5d600f6a1160abb73aea29b6b0e7e92965 Reviewed-on: https://chromium-review.googlesource.com/c/1282328Reviewed-by:
-
Morten Stenshorne authored
And it's marked as such in the main expectations file. TBR=kojii@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I1ffa182d2ca9ccbd2ef73e8f3171c0ed0355c595 Reviewed-on: https://chromium-review.googlesource.com/c/1282065 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
