- 11 Apr, 2018 40 commits
-
-
Yuichiro Hanada authored
This reverts commit 6b3d6841. Reason for revert: Please refer to crbug.com/831521 . We need to pass tap events in the drag handle. Original change's description: > Floating Keyboard stops propagation of drag handle events > > If a touch/mouse event occurs and it is interpreted as a floating > keyboard drag event, do not propagate the event to the javascript > keyboard extension as there is no reason to. > > This was causing the drag event to cause the gesture swiping to be > active while dragging the keyboard around, particularly if the keyboard > was bounded to the bottom of the screen and the user's finger is able > to move around on the keys while still moving the keyboard (see > attached bug for repro/video). > > Bug: 826078 > Change-Id: I40c859f979d41a5d61e88ff0bd41808dcf3940c2 > Reviewed-on: https://chromium-review.googlesource.com/997195 > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Commit-Queue: Blake O'Hare <blakeo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548374} TBR=yhanada@chromium.org,blakeo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 826078 Bug: 831521 Change-Id: I9dded92a6e7b2ec1f97ebd169c463686c23d5d7c Reviewed-on: https://chromium-review.googlesource.com/1006715 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#549862}
-
Hayato Ito authored
Add new performance tests which measure the performance of slot assignment recalc and re-layout in several scenarios where slot assignment changes on a *long slot-assignment-chain*. This CL also cleans up existing functions so that they have common tree structures with added ones. Bug: 776656 Change-Id: Idff494392c13aca5b6eaf1dfeabb34ad41ffa556 Reviewed-on: https://chromium-review.googlesource.com/1005648 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549861}
-
Majid Valipour authored
Bug: 827194 Change-Id: Ib21f0c55e2a196f75f3aa27ee0d0bc997a5b4bd1 Reviewed-on: https://chromium-review.googlesource.com/986750 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549860}
-
Matt Falkenhagen authored
This reverts commit f3236937. Revert "service worker: Remove GetProviderHostIterator()." This reverts commit 8aba3ccd. Reverting the shared worker patch as a suspected culprit of bug 831255. The other patch landed on top of it so has to be reverted too. Original code review: https://chromium-review.googlesource.com/981845 Bug: 831255, 796819 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I106ad40605e6347ec5c2b797142881bace491545 TBR: kinuko Reviewed-on: https://chromium-review.googlesource.com/1006237 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549859}
-
Gauthier Ambard authored
This CL removes the experimental flags and associated code, added to experiment with different toolbar layout of search icons. Bug: 831113 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9a1cbcce2a1536773394c98a5bf31bb6bf2e127f Reviewed-on: https://chromium-review.googlesource.com/1006578Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#549858}
-
Gabriel Charette authored
This is cleaner than having individual tests manage their own FileDescriptorWatcher instances and it removes a few existing usages of MessageLoopForIO::current() as a MessageLoopForIO* (which will no longer be legal after : https://chromium-review.googlesource.com/c/chromium/src/+/957760). R=fdoray@chromium.org TBR=sergeyu@chromium.org (c/b/extensions/api/messaging side-effects) TBR=hidehiko@chromium.org (components/arc cleanup) Bug: 825327, 708584 Change-Id: I2c4507cc7a4af073afaf19cd3d802c3bb5fd7f39 Reviewed-on: https://chromium-review.googlesource.com/1005780 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#549857}
-
Takuto Ikuta authored
This flag is explained in this article. http://blog.llvm.org/2018/01/improving-link-time-on-windows-with.html I compared link time of some binaries in use_lld = true and is_component = true on Z840 Win10. * use_ghash = true blink_core.dll: 50.4647194s content.dll: 29.0251954s chrome.dll: 37.5983146s * use_ghash = false blink_core.dll: 62.2167861s content.dll: 37.7807734s chrome.dll: 43.1551229s Change-Id: I9d88e76b80e405345971d815097ffff7f6bd05d6 Reviewed-on: https://chromium-review.googlesource.com/1004335 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Zachary Turner <zturner@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#549856}
-
Findit authored
This reverts commit fc2d77d5. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 549780 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZjMmQ3N2Q1MGRjYzVkNDE4YWQxOTc1YjlhMDc4MjZiMTZkODcwOGEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5150 Sample Failed Step: ash_unittests Original change's description: > overivew: Animate blur when there are no maximized windows. > > See bug(s) for spec. This CL adds an animated blur on wallpaper when entering/existing > overview when no maximized/fullscreen windows. > > Bug: 823533, 812004 > Change-Id: Icf8bdababedaaefe869f62768aacf7abcb3643d2 > Reviewed-on: https://chromium-review.googlesource.com/979167 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549780} Change-Id: If1226fa286e8f82885cea814f5fb89e0253ef98a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 823533, 812004 Reviewed-on: https://chromium-review.googlesource.com/1006894 Cr-Commit-Position: refs/heads/master@{#549855}
-
Gabriel Charette authored
This was extracted from https://chromium-review.googlesource.com/c/chromium/src/+/957760/17 MessageLoopForIO::current() will soon stop returning a raw MessageLoopForIO*. In preparation for this, fix old code to use modern APIs instead of a direct MessageLoopForIO*. This CL was uploaded by git cl split. R=derat@chromium.org Bug: 825327 Change-Id: Ifeac947b8540468fc7c207916769ef0a7f3ac434 Reviewed-on: https://chromium-review.googlesource.com/1005911 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#549854}
-
Max Morin authored
Having four thread checkers and two locks in the same class is a bit extreme. Four thread checkers and one lock seems just right :D. Bug: None Change-Id: I69252bf90c5f1e17b71e2f3a2c068572e90ec648 Reviewed-on: https://chromium-review.googlesource.com/1005253Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549853}
-
Alexander Timin authored
R=skyostil@chromium.org Change-Id: I316852571bffe939b896d321fe058e58d26cf626 Reviewed-on: https://chromium-review.googlesource.com/1000701 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#549852}
-
Gabriel Charette authored
This was extracted from https://chromium-review.googlesource.com/c/chromium/src/+/957760/17 MessageLoopForIO::current() will soon stop returning a raw MessageLoopForIO*. In preparation for this, fix old code to use modern APIs instead of a direct MessageLoopForIO*. This CL was uploaded by git cl split. R=rsleevi@chromium.org Bug: 825327 Change-Id: I317b493f88da3bcede2171e41b67feb96f44bde2 Reviewed-on: https://chromium-review.googlesource.com/1005887 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549851}
-
Matt Falkenhagen authored
We are getting crash reports about "kBadMessageImproperOrigins" from the Register message, so emit a more detailed message to help debugging. These message are compact since there are only 256 characters available for bad message error messages. Bug: 831255 Change-Id: I932a78a625c92ffca626bb5b5dcb1128ecc623c0 Reviewed-on: https://chromium-review.googlesource.com/1004892Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549850}
-
Maksim Ivanov authored
Fix inconsistency in the code that parses this policy for the policy map (which is used for the chrome://policy page). The code shouldn't pretend to have the policy set (with the default value) when the enclosing proto message is present but with the actual policy proto field unset. Note that the fixed issue should have been a purely UI glitch - the actual policy application wasn't affected. BUG=chromium:800120 TEST=none Change-Id: I32d55dc6bfe64ec8b1cac7c090028f805c91560a Reviewed-on: https://chromium-review.googlesource.com/986096Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#549849}
-
Bence Béky authored
Remove HttpStreamRequest interface, and rename HttpStreamFactoryImpl::Request to HttpStreamRequest. Bug: 829429 Change-Id: Iaff3b5e5ee73d85185914b6713d68243acb98a54 Reviewed-on: https://chromium-review.googlesource.com/998541Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#549848}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a6818c5b704d..b272c6655f99 $ git log a6818c5b7..b272c6655 --date=short --no-merges --format='%ad %ae %s' 2018-04-09 briannorris chromeos-config: add gale-test-ap builder Created with: roll-dep src/third_party/chromite BUG=chromium:774808 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I27b426853f08717e8fd85fcbaf8f950ca13bd4f0 Reviewed-on: https://chromium-review.googlesource.com/1006532 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549847}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/100327a2..6b7f2a9c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I79eee3f9555219c21134a332ddb0d35d82defdb1 Reviewed-on: https://chromium-review.googlesource.com/1005107Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#549846}
-
Joel Hockey authored
This pref is already defined, but is not able to be set in <user-data-dir>/Default/Preferences. It is used often in conjunction with webkit.webprefs.dom_paste_enabled, and it is helpful to be able to set both during development with either cmdline switch or in prefs file. This field was added in CL https://chromium.googlesource.com/chromium/src/+/a4898ce4a26204138b0e47e1fb6ac59eeb00e1c8%5E%21/ Bug: 813477 Change-Id: I61769ca8fbd989b5833717d53c8cd2495d05028c Reviewed-on: https://chromium-review.googlesource.com/1006561Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#549845}
-
Darren Shen authored
Failures because we don't support some keywords (difference between CSS vs SVG?) Bug: 820299 Change-Id: I1da06c5dfbd847a08b43d0bae42f969b4c40f1d7 Reviewed-on: https://chromium-review.googlesource.com/1002492Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#549844}
-
Koji Ishii authored
This patch fixes when list marker is taller than the content of the list item, list markers not to intrude previous blocks. This behavior is not defined, but Blink, WebKit, and Edge do this by including list marker height into the first line box. This turned out to require a bit complex propagation. Instead, this patch includes list marker height into the list item. This is being tracked in https://github.com/w3c/csswg-drafts/issues/2418 but I think this patch has close enough behavior and turns following tests good enough to rebaseline. fast/css/first-child-pseudo-class.html fast/css/first-of-type-pseudo-class.html fast/css/last-child-pseudo-class.html fast/css/last-of-type-pseudo-class.html fast/css/only-child-pseudo-class.html fast/css/only-of-type-pseudo-class.html Bug: 725277 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic911a96f7804a91d6dccf2bf64bc6fd49169e8cb Reviewed-on: https://chromium-review.googlesource.com/994915Reviewed-by:
cathie chen <cathiechen@tencent.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549843}
-
Alan Cutter authored
This reverts commit 9e82c21a. Reason for revert: This change causes target_os="chromeos" to crash on start up: [82494:82494:0411/194350.042525:FATAL:media_transfer_protocol_manager.cc(704)] Check failed: g_media_transfer_protocol_manager. #0 0x7f8751f192ac base::debug::StackTrace::StackTrace() #1 0x7f8751f402eb logging::LogMessage::~LogMessage() #2 0x7f87500945b9 device::MediaTransferProtocolManager::GetInstance() #3 0x7f87500936a5 device::MtpDeviceManager::EnumerateStoragesAndSetClient() #4 0x7f874efb5c3a device::mojom::MtpManagerStubDispatch::AcceptWithResponder() #5 0x7f87500941b6 device::mojom::MtpManagerStub<>::AcceptWithResponder() #6 0x7f87511c5a77 mojo::InterfaceEndpointClient::HandleValidatedMessage() #7 0x7f87511c53e6 mojo::FilterChain::Accept() #8 0x7f87511c6dd5 mojo::InterfaceEndpointClient::HandleIncomingMessage() #9 0x7f87511cd53c mojo::internal::MultiplexRouter::ProcessIncomingMessage() #10 0x7f87511cc940 mojo::internal::MultiplexRouter::Accept() #11 0x7f87511c53e6 mojo::FilterChain::Accept() #12 0x7f87511c05c3 mojo::Connector::ReadSingleMessage() #13 0x7f87511c0ff1 mojo::Connector::ReadAllAvailableMessages() #14 0x7f87511c0e99 mojo::Connector::OnHandleReadyInternal() #15 0x7f87511c1727 mojo::SimpleWatcher::DiscardReadyState() #16 0x7f8751187e86 mojo::SimpleWatcher::OnHandleReady() #17 0x7f8751188391 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJN S_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequ enceImJXspT1_EEEE #18 0x7f8751f19c45 base::debug::TaskAnnotator::RunTask() #19 0x7f8751f4c559 base::internal::IncomingTaskQueue::RunTask() #20 0x7f8751f5009b base::MessageLoop::RunTask() #21 0x7f8751f5042a base::MessageLoop::DeferOrRunPendingTask() #22 0x7f8751f5068c base::MessageLoop::DoWork() #23 0x7f8751f52b29 base::MessagePumpLibevent::Run() #24 0x7f8751f4f9c9 base::MessageLoop::Run() #25 0x7f8751f86709 base::RunLoop::Run() #26 0x55ecab42c14a ChromeBrowserMainParts::MainMessageLoopRun() #27 0x7f874f125a37 content::BrowserMainLoop::RunMainMessageLoopParts() #28 0x7f874f128b36 content::BrowserMainRunnerImpl::Run() #29 0x7f874f121cc9 content::BrowserMain() #30 0x7f874fb09c8d content::ContentMainRunnerImpl::Run() #31 0x7f875245e292 service_manager::Main() #32 0x7f874fb08304 content::ContentMain() #33 0x55ecaa89c263 ChromeMain #34 0x7f87449822b1 __libc_start_main #35 0x55ecaa89c0da _start Original change's description: > Add MTP Mojo interfaces for talking to MediaTransferProtocolManager. > > This CL: > 1) Introduces 2 Mojo interfaces: device::mojom::MtpManager and > device::mojom::MtpManagerClient. The current implementation just > forwards MTP device access requests to the existing > MediaTransferProtocolManager.. > 2) Makes Device Service expose the above 2 Mojo interfaces. > 3) Create stubs to connect these 2 interfaces with the main user, > storage_monitor::StorageMonitor. > > More Mojo methods will be added to MtpManager and all users will be > converted to use Mojo interfaces in subsequent CLs. > > BUG=769630 > > Change-Id: Ibfffb2a45d13014ec3984ae9e242f49492e8b16a > Reviewed-on: https://chromium-review.googlesource.com/972668 > Commit-Queue: Donna Wu <donna.wu@intel.com> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549814} TBR=sky@chromium.org,thestig@chromium.org,blundell@chromium.org,rdevlin.cronin@chromium.org,tsepez@chromium.org,donna.wu@intel.com,leon.han@intel.com,ke.he@intel.com Change-Id: I9417d3d4be8952819faf638007b3efb21c8eb618 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769630 Reviewed-on: https://chromium-review.googlesource.com/1006774Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#549842}
-
Maksim Ivanov authored
In preparation for the addition of challenge-response key type, transform the existing non-special constructor of KeyDefinition into a factory method. This should help to make the code more readable after the challenge-response key type is introduced (https://crrev.com/c/1000492): having two named factory methods is cleaner than having constructor(s) with many arguments. This CL is expected to bring no change of behavior. TBR=bauerb@chromium.org (mechanical change after the API) Bug: 826417 Test: existing tests Change-Id: Ie1b5238b05bb112a7161e3cd75389293a932ceac Reviewed-on: https://chromium-review.googlesource.com/1005335 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#549841}
-
https://chromium.googlesource.com/angle/angle.git/+log/568fc39ba45a..ebd6e2df290a $ git log 568fc39ba..ebd6e2df2 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 oetuaho Take all attributes into account when checking for aliasing Created with: roll-dep src/third_party/angle BUG=chromium:829541 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I91f528e2012e1f198b8affe4a3f855d57a46bccd Reviewed-on: https://chromium-review.googlesource.com/1006531Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549840}
-
https://skia.googlesource.com/skia.git/+log/1eeeae0491ba..ff7fa50f0c95 $ git log 1eeeae049..ff7fa50f0 --date=short --no-merges --format='%ad %ae %s' 2018-04-10 egdaniel Add ctor to GrVkImageInfo. 2018-04-10 liyuqian Merge drawDevice and respect ctm for the paint 2018-04-10 mtklein skcms→dff16bc express ApproximateCurve error in input units 2018-04-10 csmartdalton ccpr: Clip quadratic hulls more efficiently 2018-04-10 mtklein allow rolling from anywhere 2018-04-10 jvanverth Add initial support for simple concave shadows. 2018-04-10 mtklein skcms→9ff49a5 use GaussNewton for 7-parameter approx 2018-04-06 liyuqian Do not use CTM for drawDevice or drawSprite 2018-04-10 csmartdalton ccpr: Improve CPU checks for collinear points 2018-04-10 csmartdalton ccpr: Remove fCurrAnchorPoint from GrCCGeometry 2018-04-10 mtklein give skcms rolls a helpful commit msg 2018-04-08 update-skps Update SKP version 2018-04-10 robertphillips Remove extra Vulkan submitCommandBuffer from deleteTestingOnlyBackendTexture 2018-04-10 mtklein hard-roll skcms into Skia 2018-04-10 egdaniel Update getBackendInfo calls on GrBackendTexture to support VkImageLayout better. 2018-04-10 caryclark one more path is rect bug 2018-04-09 caryclark fix path to rect when missing close verb 2018-04-09 benjaminwagner Omit skbug6653 on internal device. 2018-04-09 brianosman Remove SkDEBUGFAIL for non-invertible XYZ matrix 2018-04-09 angle-skia-autoroll Roll third_party/externals/angle2/ 6c59e4a15..0ce016c1b (2 commits) 2018-04-06 reed identify interesting cubic points Created with: roll-dep src/third_party/skia BUG=chromium:824145,chromium:824145,chromium:819192 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: If3760ced34d61fa366b7363a499b2fe04a8a450a Reviewed-on: https://chromium-review.googlesource.com/1005807Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549839}
-
Henrik Lundin authored
These two new histograms are calculated inside of WebRTC. Both relate to the packet-loss concealment that happens when audio packets are lost or late for decoding, and the jitter buffer (NetEq) must resort to extrapolating audio from the previously decoded data. Bug: webrtc:9126 Change-Id: Id3f9362974e4fc4dc1c141f8fddb56ba1e98376d Reviewed-on: https://chromium-review.googlesource.com/1002172Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Henrik Lundin <hlundin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549838}
-
Hans Wennborg authored
Official builds remove the strings passed to CHECKs, causing the expected string to not show up and breaking this test. Removing the expectation strings to unbreak the test for now. As Nico commented on https://crrev.com/c/999481 perhaps a better fix would be to not use a death test at all. TBR=jdoerrie Bug: 831494 Change-Id: Ic9e2ca4cfe4f5f05d47c00fb4727ea37d6fadcfc Reviewed-on: https://chromium-review.googlesource.com/1006582Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#549837}
-
David 'Digit' Turner authored
This CL performs a little cleanup of the content of third_party/android_platform/development/scripts/: - Add ToolPath() and GetAaptPath() methods to pylib.constants.host_paths, and remove the old versions from symbol.py, adjusting all callers. Note that ToolPath() now takes a second argument to specify the target CPU architecture, instead of relying on a hidden global variable. + Add new unit-test (host_paths_unittest.py). - Remove a few unused global variables in symbol.py, and document the few remaining one (especially that they are liberally modified from elsewhere!). Also make a few functions private by adding an underscore prefix to them. Remove Uname() which was completely unused. Remove FindToolchain() since its result was completely ignored. Add an optional cpu_arch parameter to SymbolInformationForSet(), and make asan_symbolize.py, its only user, pass a corresponding argument. - Cleanup asan_symbolize.py a little, and add an optional command-line argument --arch=ARCH to specify the target CPU architecture (default is 'arm', as in the previous implementation). - Remove CallCppFilt() from symbol.py and rewrite it directly into tools/cygprofile/symbol_extractor.py, its only user. Also run the unit tests correctly. BUG=NONE R=agrieve@chromium.org,lizeb@chromium.org,egeunis@chromium.org Change-Id: If172662461a2047d7485eedd4658149283fd1ca7 Reviewed-on: https://chromium-review.googlesource.com/1004635Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#549836}
-
Dean Liao authored
Data member output_mode_ is initialized in V4L2VideoDecodeAccelerator::Initialize(). However, SetupFormats(), which accesses output_mode_, is called before the assignment. The fix is trivial: initialize output_mode_ before calling SetupFormats(). BUG=b:73327993 TEST=run video_decode_accelerator_unittest /usr/local/autotest/deps/chrome_test/test_src/out/Release/video_decode_accelerator_unittest \ --test_video_data=/usr/local/autotest/deps/chrome_test/test_src/\ media/test/data/test-25fps.vp8:320:240:250:250:35:150:11 \ --thumbnail_output_dir=/usr/local/autotest/results/default/video_VideoDecodeAccelerator/results \ --ozone-platform=gbm \ --rendering_fps=0 Change-Id: Ib8afeb4e37aeb35213d6487ec233583f22f594f5 Reviewed-on: https://chromium-review.googlesource.com/1002348Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Cr-Commit-Position: refs/heads/master@{#549835}
-
Alan Cutter authored
This CL enables the following keyboard shortcuts for hosted app windows: - Shift-Alt-T: Focus window frame toolbar buttons - Alt-E and Alt-F: Open app menu - F6: Cycle focus between frame buttons and web contents. Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=330498&signed_aid=BFJfbOWHFSLjA4dEetB3SA==&inline=1 Bug: 822146 Change-Id: Ieb00735dc92c914cb2eb2022bdbd7d72e9c3b603 Reviewed-on: https://chromium-review.googlesource.com/977521 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#549834}
-
Eric Seckler authored
Some tests are flaky, let's see if this helps. Bug: 830823 Change-Id: I48f0c8284ee8f94518bb4cc4c955fae3edddcdf4 TBR: alexclarke@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1005006Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#549833}
-
Eliot Courtney authored
BUG=b/72806943 Change-Id: I6326cc8806984264011b807456fa45164f59d187 Reviewed-on: https://chromium-review.googlesource.com/956667 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#549832}
-
Yoshifumi Inoue authored
This patch changes "4922367.html" to utilize |selection_test()| for ease of maintenance. Following patch will rename "4922367.html" to "delete_paragraph_before_table.html" to provide a hint what this file tests. Bug: 679977 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia151ea3c821e63784f374b8d74db60208c11a7ae Reviewed-on: https://chromium-review.googlesource.com/1004885Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549831}
-
Yue Li authored
Currently WebDialogDelegate cannot hide the dialog title by setting ShouldShowDialogTitle. Bug: 828574 Test: Local Build Change-Id: I2d9abc21ef108ccd97dc4667c2d4b311f6ec3501 Reviewed-on: https://chromium-review.googlesource.com/993756Reviewed-by:
-
John Z Wu authored
Change-Id: I2cdbd0e9d721f7f2326f0d59b994607a45c96c4d Reviewed-on: https://chromium-review.googlesource.com/1005722 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549829}
-
Morten Stenshorne authored
Make sure everything fits in the screenshot (we were essentially testing only half of the test), and corrected a pass condition: In some of the tests a vertical gap is expected between the float and the block with 'clear'. However, it should be 20px, not 30px. The height of the float is 30px. The margin-top in front of the block with 'clear' is 50px. So the margin is 20px taller than the float. Change-Id: Ie182061a219a323ba2c674243d0be8b41236bb20 Reviewed-on: https://chromium-review.googlesource.com/1005182Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
-
Jun Choi authored
Add support for register/sign with CTAP2.0 tokens behind a feature flag. Bug: 780078 Change-Id: I3b0fe7ce2eaf48304300e4fed5d722cd5f87c6da Reviewed-on: https://chromium-review.googlesource.com/974796 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#549827}
-
Koji Ishii authored
This patch implements LayoutNG inline fragment support for InspectorCSSAgent::CollectPlatformFontsForLayoutObject(). This function is used for Inspector to show rendered fonts. Also some font fallback tests rely on this mechanism. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7e43fe1b50eef831fb77f6e4a4b2dc59b34569e9 Reviewed-on: https://chromium-review.googlesource.com/1003016Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#549826}
-
James Darpinian authored
UnmapBufferHelper assumed that the mapped buffer was still bound to the same binding point that it was first bound to, which isn't guaranteed. This fixes the WebGL conformance test transform_feedback/switching-objects.html Bug: 696345 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia06b8e3b2b4a7a7f1a38c4bcdb241a039dc36a80 Reviewed-on: https://chromium-review.googlesource.com/998845 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549825}
-
https://chromium.googlesource.com/catapult.git/+log/2c59f678c7ed..a22719853354 $ git log 2c59f678c..a22719853 --date=short --no-merges --format='%ad %ae %s' 2018-04-09 tiborg [vr] Increase VR Response UE to 1s Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I3183053fe518d238b1105805932b7e4218bcd674 Reviewed-on: https://chromium-review.googlesource.com/1006040Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549824}
-
Alexandr Ilin authored
This CL implements the CheckPlatformHandlePermissionsCorrespondToMode() function on Windows. There is no documented API to get the current access mask on a handle. To understand whether a handle has write access, we check the success status of the ::DuplicateHandle(dwDesiredAccess=FILE_MAP_WRITE) call. Bug: 825177 Change-Id: I6863e9ead390972601539c23f6e12674ee3b7736 Reviewed-on: https://chromium-review.googlesource.com/1005343Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
-
