- 22 Oct, 2019 40 commits
-
-
Adam Ettenberger authored
Recently there have been performance improvements in ui/accessibility. This CL creates BUILD.gn entry for accessibility_perftests.exe which will be used to run performance tests for this directory. With this CL, I'm adding perf tests for the following methods : AXPosition<>::AsTreePosition AXPosition<>::AsLeafTextPosition Bug: 928948 Change-Id: Iedbb274868a42009766de31d6f8b8731640847e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838264Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#708232}
-
Clemens Arbesser authored
Before this change, ratio calculations sometimes involved integer divisions, which usually resulted in 0. This means that for BottomSheetContents with enabled peek state, the calculated minimum size was 0 and the bottom sheet could be effectively dismissed. Bug: b/143138141 Change-Id: Ib80a858f0698d20beec3f13e7e0394766c3bc281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871603Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#708231}
-
Miguel Casas authored
This CL improves/adds some debugging info in case of failures in the chain of creation of a SharedImage; it helped debugging the Issue mentioned below. Bug: 1015435 Change-Id: I2c80c6879a4a6b54ce80e76929d1e52b29cf6dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869719 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#708230}
-
Tommy Li authored
Currently, when we restore focus to the omnibox by merely switching the window (Alt+Tab), we trigger on focus suggestions. This is not good. This CL does two things: 1) Fixes FocusManager so that it provides the correct |reason| for restoring the focus to Views. 2) Modifies OmniboxViewViews and OmniboxEditModel to only trigger on-focus suggestions for DIRECT focus events, and not RESTORE events. Bug: 1013287, 996516 Change-Id: I885162f29b43b052b3251f02c22c37c047a1bf64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865621Reviewed-by:Scott Violet <sky@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#708229}
-
Tommy Li authored
This CL allows proper reverting via arrow-key for On Focus Query Suggestions. Previously, we forbade reverting via arrow key for all on-focus suggestions, and this was to fix the NTP case, which does not have a verbatim match at as the default match. But for on-focus query refinements (on SERP), the first match is indeed a verbatim search match, so we should allow those. Bug: 1012990, 963173 Change-Id: I976ff4f39271ffd8fe84c5f12622733c41e0124b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873132 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708228}
-
Christopher Thompson authored
Bug: 1016105 Change-Id: Ieddc418b09939529ca53b6540bd067c1d8a4fb9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872297Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#708227}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1872e136d13b..e1b1491b05a2 git log 1872e136d13b..e1b1491b05a2 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 primiano@google.com Merge "Trace Processor: extract rpc class" 2019-10-22 nuskos@google.com Merge "Fix a deadlock in the tracing muxer and a use after free in the tracing service." 2019-10-22 eseckler@google.com Merge "processor: Make fuchsia trace parsing an optional compile-time dep" Created with: gclient setdep -r src/third_party/perfetto@e1b1491b05a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I009e379cf65f2cc47d81d12d7f93a6b9e0bbab85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873869Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708226}
-
Alexandre Frechette authored
Bug: 1015005 Change-Id: Ife3feceddf6e89949eb5ea4e612be71ac3c53ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850313 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#708225}
-
Olivier Li authored
Prepare ShortcutsProviderExtensionTest for imminent switching on of the HistoryServiceUsesTaskScheduler experiment. The feature will soon be flipped to ENABLED_BY_DEFAULT. This will make HistoryServiceBackend's task runner dispatch to the ThreadPool instead of a dedicated base::Thread. The tests need to be prepared to stay functional when that happens. This is done as the last mile of the chrome-wide effort to coalesce as much work as possible to the ThreadPool. Bug: 661143 Change-Id: Ic17ce4468b3de601763e1ebe5c36f1120313fb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873354Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#708224}
-
Torne (Richard Coles) authored
Downstream has been fixed to refer to the new class. Change-Id: If4a94e6335d7d6f199d7df0e770aad17a8d6e8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872843 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#708223}
-
Ahmed Fakhry authored
This was a rgression caused by a previous CL of mine https://crrev.com/c/1865543. Using the developer keyboard shortcut to enable tablet mode should force the overview tray button visible even though the internal input events are not being blocked. BUG=1016594, 925087 TEST=Manually, added a new test. Change-Id: Ic9046c07dcce9de03c5fc5acd10a2077d599c711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872468Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#708222}
-
Andrew Grieve authored
Was hitting this locally: 2019-10-22 04:06:38 -0400 ERROR at //chrome/android/BUILD.gn:2339:11: Assignment had no effect. 2019-10-22 04:06:38 -0400 "monochrome_public_bundle.android_manifest.failed" 2019-10-22 04:06:38 -0400 ^------------------------------------------------- Bug: 1011227 Change-Id: I850fc129d8c2e1c7190266735f2fab97f7efebc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873240 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#708221}
-
Mike Wittman authored
This class is POSIX-specific rather than Android-specific. Treating it as such will facilitate build configuration for future Android/Linux profiler work. Adds a StackSampler stub for iOS to avoid a dependency on ThreadDelegatePosix since that platform doesn't have pthread_getattr_np. Also cleans up some out of date comments. TBR=gab@chromium.org Bug: 988579 Change-Id: If4df5da23f4ba9664f33a097c5387f6725b8301d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854502 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#708220}
-
minch authored
Bug: 1002733 Change-Id: I79cff30c75781b5bb99aaf6d9d9a613506a23e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872446Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4ec0e215bc4a..0dbd897b2d65 Created with: gclient setdep -r src-internal@0dbd897b2d65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic2e1cc9991d01ceb916f649056deac0d1cfff6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873868Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708218}
-
Andrew Grieve authored
Bug: 1016766 Change-Id: I822ed63030f2af290141f95e05829647d0fd30f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872733 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#708217}
-
Steven Bennetts authored
This add 'gzip' compression to a handful of 'about' pages. Confirmed that these load OK and that there are no unusual references to the IDR constants in the code. Bug: 965089 Change-Id: I2feef1291e50583009c370133d6af0f9cdecf8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873145 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#708216}
-
Vadym Doroshenko authored
The problem is that success of submission is checked in any call of OnPasswordFormsRendered for any frame (which is called on DidFinishLoad for a frame). And if a not related frame is loaded it might lead to check of submission. This CL fixed it by checking only the main frame and the frame of the form. Bug: 1015793 Change-Id: I3e17736f20dcb0ebea70b50ec618c6820e8fc429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871511 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#708215}
-
Tomasz Wiszkowski authored
All platforms are shifting weather icons to Material design. This change introduces weather fallback icon for Android (consistency). Bug: 955558 Change-Id: Ic7d640d6b18d9be25da9907b62ee38ce6e2cdf91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872992 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#708214}
-
Mirko Bonadei authored
This is a reland of 7777033e This should be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1872785/1..2. Original change's description: > Introduce an empty WebRTC component. > > While testing the WebRTC component build in [1], there was a problem > with some testonly code Chromium depends on (which cannot be part of the > WebRTC component). > > In order to support this use case, [2] will make the testonly code > needed by Chromium depend on the WebRTC component and this CL is needed > in order to land everything in an incremental fashion. > > [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1868961 > [2] - https://webrtc-review.googlesource.com/c/src/+/157427 > > Bug: webrtc:9419 > Change-Id: Ie995af67a7ab4ba1a2e5bb012f2e9b33be056acb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872937 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707985} Bug: webrtc:9419 Change-Id: Idca3459d4abe35e7a2b4a646bb4fe336fb2d419d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872785Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#708213}
-
Ella Ge authored
This reverts commit 1b9a5e97. Reason for revert: test failing on linux-trusty-rel bot: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/3887 Original change's description: > Revert "Disable flaky system_health.memory_desktop/browse_accessibility:media:youtube" > > This reverts commit 02b03541. > > Reason for revert: Test no longer appears to fail. > > Original change's description: > > Disable flaky system_health.memory_desktop/browse_accessibility:media:youtube > > > > TBR=perezju@chromium.org > > > > Bug: 983326 > > Change-Id: I22be996f9054935f378a05b95f7f7924a9c5f63b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699097 > > Reviewed-by: danakj <danakj@chromium.org> > > Commit-Queue: danakj <danakj@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#677130} > > TBR=crouleau@chromium.org > > Bug: 983326 > Change-Id: If9cb5e9a1d674e49709edbbee4dd2ceafe5bb21b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871998 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708139} TBR=perezju@chromium.org,crouleau@chromium.org Change-Id: Ibdecece827edcd82efbfba5261e53c0a8e5585fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 983326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874054Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#708212}
-
Arthur Wang authored
R=jbudorick@chromium.org Bug: 1016804 Tbr: obrufau@igalia.com No-Try: true No-Tree-Checks: true Change-Id: Ic22d9998c1afc57b9cb060d05cbda8aecd8ca491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872307Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#708211}
-
Łukasz Anforowicz authored
This reverts commit 2875b7b9. Reason for revert: Seems to cause build failures - see https://ci.chromium.org/p/chromium/builders/ci/ios-device/139149 Original change's description: > SuperSize: 3x speedup by minimizing string allocations > > The previous bottleneck was allocating a million std::strings, so the > obvious fix is to not allocate a million strings - after unzipping the > .size file into a 100MB character buffer, we can insert null terminators > so that pointers into the middle of the buffer scan as symbol names. > > Hosting the website locally this brings the WebAssembly parsing time > down from 6s down to 2.2s. Considering that we're unzipping a 130MB file > and parsing it, I don't anticipate future big optimizations without > parallelizing parsing. > > Bug: 1011921 > Change-Id: I43eea11bda87012c40b47457457c6c649631df0c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863362 > Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708208} TBR=huangs@chromium.org,agrieve@chromium.org,jaspercb@chromium.org Change-Id: I7b92b476f48bc21d57ee4c94a783aef51e20e3c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874051Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#708210}
-
Andrew Grieve authored
Before: * ninja chrome_public_apk_incremental After: * gn gen --args='incremental_install=true ...' . * ninja chrome_public_apk Why make this change? * Simpler mental model (e.g. most other build things use GN args) * Reduces the load on bots that build all targets * "gn gen" on my machine goes from 7200ms -> 6500ms Bug: 1013688 Change-Id: I62c7c1cea2002a6932867ebf91b31ffbaa8d6a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856438 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#708209}
-
Jasper Chapman-Black authored
The previous bottleneck was allocating a million std::strings, so the obvious fix is to not allocate a million strings - after unzipping the .size file into a 100MB character buffer, we can insert null terminators so that pointers into the middle of the buffer scan as symbol names. Hosting the website locally this brings the WebAssembly parsing time down from 6s down to 2.2s. Considering that we're unzipping a 130MB file and parsing it, I don't anticipate future big optimizations without parallelizing parsing. Bug: 1011921 Change-Id: I43eea11bda87012c40b47457457c6c649631df0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863362 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#708208}
-
Xiaoqian Dai authored
When swiping up on the shelf to go to homescrene, the active window should collapse into its associated app item bounds. If the app item is not visible on the home screen, it should collapse into the center of the app grid. Bug: 997885 Change-Id: I40bb8c1b190958049044f6dbea823a31e7e02578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871897Reviewed-by:
-
Brian White authored
Change-Id: Ib63a04cc663011872f60bd04be420b3207dffb29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869451 Auto-Submit: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Donn Denman authored
Moves the vertical centering of the text and other content such as icons in the Bar by centering them the space below the Drag handle instead of the whole Bar height. BUG=1013333 Change-Id: Ib02b3d434e4f8ed2e4065b8f42219f0372c3f14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854362 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#708205}
-
Maks Orlovich authored
We're becoming picker about 1st party vs. 3rd party distinction, requiring explicit marking, so adjust tests. This doesn't help some of the metrics tests in URLRequest Bug: 1016512 Change-Id: Ib07d460840d7c7796810b57b0ee95d8676b7bb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872638 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#708204}
-
Felipe Andrade authored
Kerberos credentials manager should notify observers if at least one of the account addition succeed. Howerver, there should be at most one notification for a given list of accounts added. This CL adds a flag to manage this notifications. Change-Id: I6f40ed930dd98e9f760a9de9869452d94cec4295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871881 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#708203}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e3dcc758ca56..62b5cdc733cc git log e3dcc758ca56..62b5cdc733cc --date=short --no-merges --format='%ad %ae %s' 2019-10-22 vapier@chromium.org cgpt: fix output handling Created with: gclient setdep -r src/third_party/chromite@62b5cdc733cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic27bb11d84bebeea4c98270151630c535a41c80d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873867Reviewed-by:
-
Istiaque Ahmed authored
ScopedWorkerBasedExtensionsChannel was introduced recently to centralize worker's channel requirement for test. However, some tests are still using manual channel override with ScopedCurrentChannel, this CL updates them. This makes moving SWs to different channel in future easier. Bug: None Change-Id: Iacc9faa2dbaf3569c0988893c1c542c19800e4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869016Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#708201}
-
Stephen McGruer authored
This test is blocking the WPT importer, as it generates different output every time it fails. I'm not sure if it ever passes, but in the interest of getting the importer unblocked marking pass/fail. Bug: 1016762 Change-Id: Ibe8f5220ba55531ff4610da3ec6fdacc3074b1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873237 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#708200}
-
Henrique Nakashima authored
More logic related to tabs will be moved to TabFeatureUtilities in follow-ups. Bug: 1012975 Change-Id: Ib4aa13e2cc94340b733326140656c48d0a5e52c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857581 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
gogerald authored
Bug: 1016548 Change-Id: I5ec93b4081bc29c7a10b657859a9ff4e775e91d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872421Reviewed-by:
-
Juan Antonio Navarro Pérez authored
Revert "Disable flaky SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/play:media:soundcloud:2018" This reverts commit e955ed2d. Reason for revert: Attempt to gain more debug information. Sheriffs: Please do revert this CL if flakiness reoccurs. Original change's description: > Disable flaky SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/play:media:soundcloud:2018 > > TBR=perezju@chromium.org > > Bug: 987858 > Change-Id: I7dbd4dc300f38c9aacad4a214a6618c8120e0dd5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722578 > Reviewed-by: Rakina Zata Amni <rakina@chromium.org> > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681723} TBR=perezju@chromium.org,rakina@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR=crouleau@chromium.org Bug: 987858 Change-Id: I805d54768ca7eb571bef2bb0602fae8898d0236b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872101 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#708197}
-
Dave Tapuska authored
As outlined in https://docs.google.com/document/d/1QO99UstlPTY8eK4Lnc9qcNq3wQYTBDBsRZu6nGC4XG4/edit Create a RemoteFrame mojo interface in blink so the browser can talk directly to the RemoteFrame in blink. Since there aren't any other mojo interfaces on the remote frame in blink this required a bunch of InterfaceRegistry plumbing to be added. This change also moves the first message over WillEnterFullscreen. BUG=1008432 Change-Id: Ib386cdbf1de595dd622e6942e4ed4c3378a912f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865473 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#708196}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3f8ac37e468..e25df6cf7879 git log f3f8ac37e468..e25df6cf7879 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 kjlubick@google.com [canvaskit] Expose Malloc to save copies in some places Created with: gclient setdep -r src/third_party/skia@e25df6cf7879 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I8c22d54a01764dfb49bc3e31a383a3dd083a70c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873865Reviewed-by:
-
Francois Doray authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1804786. The difference is that we don't check thread priority in angle_deqp_tests_main, as these tests do change thread priority on purpose. This CL verifies that the thread priority is normal when a test process is launched and before/after each test. The goal is to avoid having tests that assume they run at normal priority be disabled because of other misbehaving tests (e.g. https://crbug.com/931706). TBR=sky@chromium.org,michaelpg@chromium.org,thakis@chromium.org,eseckler@chromium.org Bug: 931706 Change-Id: I92a827d014278b1f5b3504f48c2441ad2e83bc65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865405Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/528a03441eac..d15a0283d1d8 git log 528a03441eac..d15a0283d1d8 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 danilchap@webrtc.org Hide deprecated SingleThreadedTaskQueueForTest behind an accessor Created with: gclient setdep -r src/third_party/webrtc@d15a0283d1d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I8630a14ca5ba5d16c6e3c9c6b78ce7a8aa07fd13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873866Reviewed-by:
-
