- 27 Mar, 2019 40 commits
-
-
Avi Drissman authored
Also do some cleanup of naming, and use CFRunLoop calls rather than NSPorts to stop running NSRunLoops. BUG=496298 Change-Id: Iaa862268ae2a0b40e2eedfbc482da2cf4c69e4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540099 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#644849}
-
Michael Lippautz authored
This adds histograms that track incremental marking time on the main thread. We are interested in - Incremental duration of marking - Overall duration of marking Bug: 945806 Change-Id: Iadbce47ecf579bdf6ab7c247f47bbaf90d778ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539658 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#644848}
-
Ella Ge authored
Flaky on mac Tbr: brianosman@chromium.org Bug: 946323 Change-Id: I227f55a682480ee0bfb431211d3a52ee31035d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541938Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#644847}
-
Oleh Lamzin authored
Declare DeviceBootOnAcEnabled device policy. Boot on alternating current provides an opportunity for system to automatically boot up from OFF/Hibernate state when alternating current power is inserted. BUG=b:127455857 TEST=unit_tests/browser_tests Change-Id: Ic72fc8e6d0aef74531669efca92b7fb0cf065249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520836 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#644846}
-
Javier Ernesto Flores Robles authored
The test is not only disabled for iPads Change-Id: Iafbc46ee7008b221aafca52cbc775fda863cf002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541781Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#644845}
-
Stephen Chenney authored
TBR: wangxianzhu@chromium.org Bug: 946532 Change-Id: Ic2282f1b4b6fda00fc674378ed8420f3e2bf76f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541857Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644844}
-
Michael Ludwig authored
Change-Id: I717e3bd5ca1f04e622c6cf3648db6a2367dec9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531573 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#644843}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5c4690c2f4e8..2162ba335723 git log 5c4690c2f4e8..2162ba335723 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@2162ba335723 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I3d3a807b27e9abb9242b0cde9ea5962c00bc7011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541876Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644842}
-
Kurt Catti-Schmidt authored
This change implements ITextProvider::GetSelection based on existing selection data from AXTreeData. Unit tests were added. Bug: 928948 Change-Id: Ifa5695077e67b312b9efd23051841a29f8fa8e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534142 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#644841}
-
Brian Osman authored
These tests don't (appear to) need GL specifically, just Skia resources or a GrContext. Skia's NullGL context is deprecated, and we'd really like to remove it. Change-Id: Ie88a4c2ec63617285a724ed8587e6b02d8311f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540276Reviewed-by:
Brian Salomon <bsalomon@google.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#644840}
-
Matthew Jones authored
Bug: 901952 Change-Id: I664fdcf5abc7958f07ea97272231bcf245509746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539213Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#644839}
-
Stephane Zermatten authored
Before this patch, there could be a cancel button on the onboarding screen. With this patch, the button is gone. With the latest refactorings, UiControllerAndroid::UpdateActions() can now be called while in the inactive state, when showing onboarding. It needs to handle that state as well. Change-Id: I5b955ac8e7b854bb6a17798837f1ab1a6ea9e4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541777Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#644838}
-
Roman Sorokin authored
The files were moved from chromeos/login/auth to chrome/browser/chromeos/authpolicy. The class was renamed to AuthPolicyHelper. Helper functions are not login-related, so it doesn't make sense to keep the file in login/auth. This CL is a first step to add helper functions for ActiveDirectoryPolicyManager. TBR=xiyuan@chromium.org Bug: 843177 Change-Id: I7e440e49dfc0d170a53a8cb424c51e78d2f634a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541109Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#644837}
-
Arthur Hemery authored
Navigations use TaskType::kInternalIPC, which causes hanging issue in virtual time tests. They now use TaskType::kInternalNavigation which explicitly uses real time. Change-Id: I01b12f232e123137755b6ff1bcc934dd6896b459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511407 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#644836}
-
arthursonzogni authored
The bug happens when a |render_frame_host_| has been selected and the |loader_| call OnRequestFailed(). This shouldn't be possible, because |render_frame_host_| and |loader_| can't be non-null at the same time. This CL checks this each time any of these variables become non-null. Bug: 936962 Change-Id: I7bb7cda0287a0f7b87e2cca01cdc41ddb5172033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533903Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#644835}
-
Nicolás Peña Moreno authored
This CL adds a test for carousel images. The test contains a carousel of two images which has a timeout to change image every 50 ms. Because the images are completely removed from the page and then readded, Element Timing detects the new addition as a new element, so a new entry is dispatched every time. This is helpful for measuring latency, for example when the image carousel change is prompted by user input. Bug: 879270 Change-Id: I84a034d307c026ba50d12d8bb6241a7fceeadae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540457 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#644834}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f27b5ca150c5..d935763366ad Created with: gclient setdep -r src-internal@d935763366ad The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: I19b6a2de93b3f0aebbf144f71e94996b546e88cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541836Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644833}
-
Paul Meyer authored
This makes it more clear that this policy applies only to lossy image types (for now, just JPEG). This patch also makes the implementation more generic in order to make the policy compatible with parsed policy values and to pave the way for implementing a lossless-enforcing version of the unoptimized-images policy as well. This is a reland of this reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1531354 Bug: 942659 Change-Id: I7928de8a7f3e66841ec3792a4152a3570a709ca3 TBR: iclelland@chromium.org,pdr@chromium.org,kenrb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541579 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#644832}
-
Fabio Tirelo authored
Bug: 945225 Change-Id: I15646c1f1ecaff70bb269ab20d37b6773c4fba72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541657Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#644831}
-
Antoine Labour authored
Bug: 945009 Change-Id: Iac5a5b59dfc5100e8c47a1c46ec9c586eacfe88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536347Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644830}
-
Raul Tambre authored
Bug: 930523 Change-Id: I217f7ef6af0e2aa5d29f88ee1f4a4a1cb5b04815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536061 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#644829}
-
Joshua Peraza authored
8e222b90b727 fix report size computation in prune condition 8b1be541f50e mac: Support 32-bit x86 builds 17d024e7df68 fuchsia: Suspend process before manipulating it 3cc7ceaac513 [fuchsia] do not try to suspend crashed thread 75efc19dd0d5 Make most of the tests pass on Android Change-Id: Ic0c1b0be24908fcd5884d2f719793f69c0a27801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540147Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#644828}
-
Adam Langley authored
This is barely functional, but provides a framework which can be fleshed out. The important point to review is that functionality is unchanged when the feature flag is not set. Bug: 941120 Change-Id: I9c0d19458bb8d5e1872144722232041b9a398304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531530Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#644827}
-
James Lissiak authored
Small patch to fix an issue with the colors of the TreeOutine. Specifically, in the dark theme the selected item in the tree does not have sufficient contrast when focus is placed outside the tree. The following image shows the change: https://imgur.com/a/WXY2CtT The fix was to add a new css variable into inspectorStyle.css which is given the existing foreground color in the light theme, but is over- ridden in the dark theme with a better contrasting color. The new color is then applied in treeoutline.css to selected non-focused items. Change-Id: Iec42e6dbbc2264651dd9c6b0238a1e65ecf6246b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540270Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: James Lissiak <jalissia@microsoft.com> Cr-Commit-Position: refs/heads/master@{#644826}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/afa61c94e50e..53dd1f3c1a33 git log afa61c94e50e..53dd1f3c1a33 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 alessiob@webrtc.org PFFFT Wrapper: ordered transform. 2019-03-27 crodbro@webrtc.org Revert "Avoid calling OnRoundTripTimeUpdate with invalid RTTs." Created with: gclient setdep -r src/third_party/webrtc@53dd1f3c1a33 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1704765a91a9a27285c94d2b0b9f4517942bd337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541756Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644825}
-
Marc Treib authored
This reverts commit 35279220. Reason for revert: It looks like all the flakes were caused by unsubmitted code (i.e. pending CLs). Original change's description: > Disable SyncUIUtilTest.DistinctCasesReportUniqueMessageSets > > TBR=treib@chromium.org > > Bug: 945628 > Change-Id: I48f13c55991df57c29ae44e3db037b230de3f432 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535655 > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644185} TBR=horo@chromium.org,treib@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 945628 Change-Id: Iab4376dd047c482e43c6ef9105cc339415b3e418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541778Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#644824}
-
Ben Pastene authored
Decreases the CI bot from symbol_level=2 to 1. Increases the try bot from symbol_level=0 to 1. Needed to make room on disk for all the tests I'd want these bots to run. Bug: 932269 Change-Id: Iba35a386b3090da8f6fb424ad20ca864d24e6ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540480Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#644823}
-
Aaron Leventhal authored
* Return an empty list with S_OK, not S_FALSE, as this lets the screen reader process the end of the range of text. * Repeat previous text attributes when toggling aria-invalid:spelling in the next text range Bug: 944645 Change-Id: I89d7599ee282dd325e3ccee13ad3bd3ee5447552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539920Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#644822}
-
Sammie Quon authored
This reverts commit 9d6b2ab9. Reason for revert: Caused conflict with a cl that needs to be revered. Original change's description: > overview: Move "No recent items" label out of shield widget. > > Shield widget is getting removed. This is step one by moving the cannot > snap window out into its own separate widget owned by overview_session. > Since there is only ever one shown, it doesn't need to be owned by > overviewGrid. > > Test: ash_unittests OverviewSessionTest.* > Bug: 942759 > Change-Id: I5c9e40763a35d27f2e383effada0f4f6d8791320 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535131 > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644538} TBR=xdai@chromium.org,afakhry@chromium.org,sammiequon@chromium.org Change-Id: I36ca4d9bbe8a4c9901a4e94aca34689965410820 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541937Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#644821}
-
Natalie Chouinard authored
The Bookmark Suggestions feature is disabled and this code is no longer in use. A follow up change will mark the BOOKMARKS category as deprecated. Bug: 945439 Change-Id: I2ba9791d6eedc717b5670a50b09f2058399293a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538803Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#644820}
-
Karolina Soltys authored
I am migrating (heavily discouraged) non-test usages of ThreadUtils.runOnUiThreadBlocking in browser/ to PostTask.runSynchronously (this method is deprecated, to discourage further usage). This is a purely mechanical migration. Bug: 863341 Change-Id: Idc77228e2bee0b9f990c5ea524f6c980b4e3f2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541101Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Karolina Soltys <ksolt@chromium.org> Commit-Queue: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#644819}
-
Yashar Dabiran authored
This CL is part of the changes needed for this design doc: https://docs.google.com/document/d/1Qog5qwZ-6Rfx10AKkJxN-LrwhCw_GJ1xdLoQSnpsT1Q This CL provides a way to define feature policy features in a declarative way inside "feature_policy_features.json5" which generates the required code needed by the parser. The parser does not use the generated functions yet (it will be done in an upcoming CL). A few features are added to "feature_policy_features.json5" to manually test the generated code. Once all features are defined in the .json5 file and the parser uses the helper functions, the code will be tested against all existing tests for feature policy features. Bug: 934491 Change-Id: I44e5a919f1dbc0d6a5abae327f68ba3c90abb5d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534290 Commit-Queue: Yashar Dabiran <yashard@google.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#644818}
-
Nektarios Paisios authored
This currently doesn't work. Any help appreciated. 1. Modifying the selection by moving forward to the end of the current line works. I verified by using the same HTML in Chrome. 2. The affinity of the DOM selection is not set to upstream as it should have been. 3. As expected, the affinity of the AXSelection is also not set to upstream. 4. The width of the first line is not 15 characters, even though the width in the style rule is set to "15ch" and the font is a monospace one. R=dmazzoni@chromium.org, yosin@chromium.org Bug: 639340 Change-Id: I6b7254107c5f7ca96bf6bd38fe55e6824d05e614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536752 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#644817}
-
Tien Mai authored
Bug: 942539 Change-Id: I3b7226c5193a47664683b630300ac917df81d07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525989Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#644816}
-
Moe Ahmadi authored
This is a reland of e09772fe The original CL was reverted because testInfobarAutoNeverTranslateMaxTries was timing out. That test is disabled in this reland. Original change's description: > [iOS][Translate] Adds EarlGrey tests for the new translate infobar (part 2) > > Adds tests for: > > 1. Auto Always translate (incl. max tries) > 2. Never translate language > 3. Auto Never translate (incl. max tries) > 4. Never translate site > > > Bug: 910994 > Change-Id: Ice90d639afd1f48dbdace62f6da8932f7b78d185 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521592 > Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: anthonyvd <anthonyvd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642911} Bug: 910994 Change-Id: I06bbc66da0066690884706787b8fad1a543c455e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538708Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#644815}
-
Marc Treib authored
Previously, SupervisedUserService explicitly called SetEncryptEverythingAllowed, requiring a dependency to SyncService. Now, the "EncryptEverythingAllowed" bit is instead propagated via SyncTypePreferenceProvider, which SupervisedUserService already implements. After this, there is only one remaining dependency from SupervisedUserService to SyncService, namely adding/removing itself as a PreferenceProvider. That will be cleaned up in a followup by wiring it through the factories instead. Bug: 946473 Change-Id: I797abf14bc03aacf2e130a283f3a12c88a2cd358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541183 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#644814}
-
Moe Ahmadi authored
In some scenarios TranslateInfoBarDelegate gets destructed before the TranslateInfobarController and subsequently its TranslateInfoBarDelegateObserverBridge instance. This results in the delegate reference to be invalid in the observer bridge's destructor. TranslateInfoBarDelegate now notifies its observer before being so that it can stop observing the instance. Bug: 945433 Change-Id: I8b8644c66c84c3a4378f281d2937b931e3bd6f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536799 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#644813}
-
Moe Ahmadi authored
Signed-off-by:
Moe Ahmadi <mahmadi@chromium.org> Bug: 944829, 910994 Change-Id: I29d9e74b81cfc0b33397d32f8d9d212e2d736fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538896 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#644812}
-
Robert Sesek authored
Bug: 934930 Change-Id: I0c9bae607e06a921c4587fcfb50ebc574c830c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540281Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#644811}
-
Mike Wittman authored
This reverts commit f99a085f. Reason for revert: Broke iOS build Original change's description: > [Sampling profiler] Use cross-platform sampling implementation for Mac > > Refactors the Mac sampling to use the StackSamplerImpl implementation, > with the platform-specific aspects moved into ThreadDelegateMac. > > Bug: 931418 > Change-Id: I8f468fa09b9ddc85921f21563ff41000a5c968f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535178 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644804} TBR=thestig@chromium.org,wittman@chromium.org,lgrey@chromium.org Change-Id: I3f50a2117449abca9c58d89b13febab3889b421b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541586Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644810}
-