- 06 Feb, 2018 40 commits
-
-
Klaus Weidner authored
My fix for the slightly-wrong poses in WebVR unfortunately resulted in completely wrong (uninitialized) poses for VR browsing mode. Sorry about that. Use a mode-appropriate pose, and add comments. BUG=809608,808147 Change-Id: I2193fd6dfd6d2093b18c16b35680338a64bec5fe Reviewed-on: https://chromium-review.googlesource.com/905101Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#534758}
-
Shubhie Panicker authored
I2I link: https://groups.google.com/a/chromium.org/d/msg/blink-dev/1WFVPbRL640/TPPG9gs5AwAJ Bug: 809283 Change-Id: Id0942f146cffc07981b135ca0590a7fab1b23140 Reviewed-on: https://chromium-review.googlesource.com/903183Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Shubhie Panicker <panicker@chromium.org> Cr-Commit-Position: refs/heads/master@{#534757}
-
Peng Huang authored
Bug: 807632 Change-Id: I4ba225af77087aec951420e033c6e361f88f249d Reviewed-on: https://chromium-review.googlesource.com/905222Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#534756}
-
Emil A Eklund authored
Add flag-specific results for a number of layout tests that vary only in minor text kerning, list marker rendering or border radius antialiasing. Tbr: kojii@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I1c2770322d0c820de670e91802534abb19aea939 Reviewed-on: https://chromium-review.googlesource.com/902705 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#534755}
-
James Forshaw authored
Due to a bug in CreateProcess when enabling an AppContainer profile and setting process mitigations at the same time CreateProcess will fail with ERROR_INVALID_PARAMETER. This is due to CreateProcess internally enabling some mitigations such as force image relocation. To try and preserve the set mitigations we convert all possible to delayed mitigations instead. This CL also fixes a typo in a member variable name. Bug: 760977 Change-Id: I45f65c5ba5bab83270fcf113fbc6fbae66caa7a0 Reviewed-on: https://chromium-review.googlesource.com/902047Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#534754}
-
https://chromium.googlesource.com/catapult.git/+log/4c7a9a8e39f1..e6e84629dbe5 $ git log 4c7a9a8e3..e6e84629d --date=short --no-merges --format='%ad %ae %s' 2018-02-05 dtu Don't send browser or dimensions from dashboard to Pinpoint. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia1c7f88a7651e67eb456e544067c4f607691a622 Reviewed-on: https://chromium-review.googlesource.com/904962 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534753}
-
xdai authored
In M65, some ARC apps can be freely resized and thus are capable of displaying in splitscreen, however, the splitscreen is not supported for ARC apps windows in M65 yet, thus we should explictly disable it. Otherwise we may see issues as in crbug.com/808748. It will be reverted later in M66. Bug: 808748 Test: Manually Change-Id: I1d2a5efdb503aabaa2e0f2c519c89373c0c43f83 Reviewed-on: https://chromium-review.googlesource.com/904969Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#534752}
-
Chris Blume authored
The current README is unclear about when a .patch file must be generated and how we intend to isolate our changes from upstream changes. This patch clarifies how someone can contribute to third_party/zlib while minimizing risk of conflicts with upstream changes. BUG=807488 Change-Id: Iaa503b94f110cb83febbdd8d57527d606d3eb779 Reviewed-on: https://chromium-review.googlesource.com/894856Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#534751}
-
Colin Blundell authored
This CL converts SubscriptionManager from using //components/signin to using the Identity Service client library. The conversion is straightforward: - Observer IdentityManager rather than SigninManager. - Get info of primary account via IdentityManager rather than SigninManager. - Create PrimaryAccountAccessTokenFetcher via IdentityManager rather than directly. I tested the relevant behavior manually as follows, based on instructions from mamir@chromium.org: 1. Enabled Breaking News Push by turning on "enable-breaking-newspush on chrome://flags: https://cs.chromium.org/chromium/src/chrome/browser/about_flags.cc?type=cs&q=kEnableBreakingNewsPushName&sq=package:chromium&l=2497 2. Checked the about:histograms for the feature's metrics by doing "find in page" for "subscription". Saw no histogram entries after visiting the NTP when signed out but *did* see histogram entries after visiting the NTP when signed in. Metrics listed here: https://cs.chromium.org/chromium/src/components/ntp_snippets/breaking_news/breaking_news_metrics.cc?type=cs&l=17 A followup change will convert the test to use IdentityTestEnvironment. Bug: 798413 Change-Id: I9193d25c2793cf52fd825186cd5d875b352eb8bb Reviewed-on: https://chromium-review.googlesource.com/888520 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#534750}
-
David Benjamin authored
This makes for a much simpler and more uniform API. Replace the unused RSA-PSS-SHA1 test vectors (which was never an algorithm we used) with newly-generated RSA-PSS-SHA256 ones. Bug: none Change-Id: Id7010818f496952d07f81b152113a08460f1c2d5 Reviewed-on: https://chromium-review.googlesource.com/896810 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#534749}
-
Jonathan Metzman authored
TBR=aarya@chromium.org, mbarbella@chromium.org Change-Id: I2aae3d83db9365f0c429070386c671090b89943b Reviewed-on: https://chromium-review.googlesource.com/905224Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#534748}
-
Dominik Laskowski authored
Bug: 707170 Test: No DCHECK when mouse first enters gtk3-demo. Change-Id: Id8c7cd5834b8071384be2967c686988e16eadf9e Reviewed-on: https://chromium-review.googlesource.com/899912Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#534747}
-
Jiaquan He authored
The GetWallpaperProminentColors and GetContextMenuModel in AppListViewDelegate are interfaces with outputs, by returning values or updating pass-by-address params. This commit refactors them to use callback instead, to match the need of future mojo calls. For context menus, this commit also takes out relevant interfaces and structures to reuse. Bug: 733662 Change-Id: I196da33d1f040548e0f7643783d2b434c17174f1 Reviewed-on: https://chromium-review.googlesource.com/894667Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#534746}
-
Yuri Wiitala authored
Fixes the test SetUp() to use the instrumented software GL impl when the WebContentsVideoCaptureDevice browser tests are MSAN-built. This prevents false testing failures caused by memory bugs in the platform- specific libraries. Bug: 806715 Change-Id: Idec6245674b36d0c8b9cca0488e0601e02d932c8 Reviewed-on: https://chromium-review.googlesource.com/903584Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#534745}
-
Leon Scroggins III authored
Bug: 807324 Bug: 808665 An upgrade to libpng version 1.6.34 resulted in Chromium truncating some pngs. This pngs are technically incorrect, but according to libpng-manual.txt, "hundreds of PNG files in the wild that have" this error, and we previously displayed them properly, so we should continue to do so. That bug is fixed with crrev.com/c/901985, which is safe to land prior to the (re-)upgrade. crrev.com/c/904262 is a regression test that will ensure that this does not re-break these images. Along with that fix, revert d59d694c, taking us back to 1.6.34 along with the arm optimizations that were reverted in that commit. Change-Id: I9ee925e25d94d1ba0d27fb9ba65abf9606f13828 Reviewed-on: https://chromium-review.googlesource.com/902145Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
-
Sammie Quon authored
These two mostly copy and paste from WindowSelectorItem OnGesture and OnMouse, and only affect minmized windows. This cl removes minimized windows widget ability to accept events and let them fall through to the WindowSelectorItem, so the minimzed window have the same effect. Removed the press to select window for minimized, both minimized and non minimized windows now require click to select window. Test: manual, trybot Bug: 782320 Change-Id: Idb7ec4784990e32358fb76a4b067277c95318394 Reviewed-on: https://chromium-review.googlesource.com/896636Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#534743}
-
Scott Violet authored
This is a revert of most of https://chromium-review.googlesource.com/c/chromium/src/+/879029 (the test stays). I did that patch at a time when I thought I wouldn't create g_browser_process. I ended up creating g_browser_process though, which means these changes were unnecessary. BUG=800358 TEST=none Change-Id: I49eedf78abc7d6a19c49effb0c35450958dc558b Reviewed-on: https://chromium-review.googlesource.com/902683Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#534742}
-
Linkun Chen authored
Make chromecast load additional font files from fonts/. Bug: 69627595 Test: On chromecast, force HTML elements to use local font. Change-Id: Idcebbf197db2cbe9ebe8b88be8c690ae7440bc62 Reviewed-on: https://chromium-review.googlesource.com/902774Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Linkun Chen <lkchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#534741}
-
Antonio Gomes authored
src//c/b/wc/web_contents_view_aura.cc has its own function to map ui::EventFlags to blink::WebInputEvent::Modifiers. It duplicates the existing ui/events/blink/blink_event_util.h|cc. Driven by CL that removes this duplication. BUG=none Change-Id: I8f5ed74bbfa93fab5cd9192cbaf720977eb731ba Reviewed-on: https://chromium-review.googlesource.com/904402Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#534740}
-
Jonathan Metzman authored
TBR=mbarbella@chromium.org Bug: 769578 Change-Id: I2be935a18118c8e1880f3881d1f62e8978bf532b Reviewed-on: https://chromium-review.googlesource.com/905090Reviewed-by:
-
Xing Liu authored
When user downloads a file in Chrome and remove the file in other application, we check if the file is externally removed and call Android API DownloadManager.remove(id) to avoid a crash on Android. However, if the user rename the file, currently Chrome still deletes it via the id provided by Android DownloadManager. In this CL, we only let Android remove the file if it's deleted in Chrome. Bug: 774870 Change-Id: I5448a155c1e05e44ec3a812e93d3035d7061ecf7 Reviewed-on: https://chromium-review.googlesource.com/899770Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#534738}
-
Raymond Toy authored
When using the AudioParam value setter, the setter must behave as if setValueAtTime were called with the given value at the current audio context time. This includes throwing an error if the time is in the middle of a setValueCurveAtTime automation. This is a change in the old behavior where errors weren't thrown. This also clarifies the behavior of the value setter when automations are running. Previously, the interaction between the setter and automations were not very well specified. Bug: 764396 Test: AudioParam/audioparam-value-setter-error.html Change-Id: Ic1da32c27f9e4f29e2df3bcbb6dd0bd485409e0e Reviewed-on: https://chromium-review.googlesource.com/665318 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#534737}
-
Alexei Filippov authored
It is not necessary to hold a lock while looking for a sample in the samples_ std::unordered_map container unless container is modified. BUG=803276 Change-Id: I1305e848f01860f89d6c631b7af44ffa3a900f0b Reviewed-on: https://chromium-review.googlesource.com/891651 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#534736}
-
David Bokan authored
fast/events/scale-and-scroll-iframe-window.html was fixed in r533170 but the TestExpectation line wasn't removed to avoid interfering with landing r533694. Dashboard says it's been passing reliably. Bug: 781431 Change-Id: I92ff5c63246fd68556598a42b09e86477e983cdd Reviewed-on: https://chromium-review.googlesource.com/899644 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#534735}
-
Raphael Kubo da Costa authored
Small code cleanup to make it easier to land other changes related to this bug. |return_promise| was being passed around through different functions but not used anywhere since fbfdd53f ("IDL: Drop value conversion (V8 -> C++) macros from generated code"). |method| has not been used since 652e2642 ("binding: Retires ExceptionState::throwIfNeeded()"). Bug: 808995 Change-Id: I19567d796d5c706fd03acc960caca9a25b07d050 Reviewed-on: https://chromium-review.googlesource.com/904602Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#534734}
-
Charles Harrison authored
The histograms downsides (memory, binary size, server resources) probably outweigh their value. Bug: 809334 Change-Id: I8965007e67275d615abd3dba3a1505d99024a44f Reviewed-on: https://chromium-review.googlesource.com/904263Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#534733}
-
Evan Stade authored
TBR=bsep@chromium.org Bug: none Change-Id: I476b92e6ffe329632b6d9551b28bfea0ba1fb067 Reviewed-on: https://chromium-review.googlesource.com/902729Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#534732}
-
Maks Orlovich authored
Previous code both would perform very badly --- as it's scanning over 4K increments, which is iffy if there is a big hole in the middle --- and could also suffer from wrap around in index computations (an alternative may be to fix just that...) This change replace hash table keeping track of ranges with the ordered std::map, which makes finding adjacent kids easy. Bug: 808561 Change-Id: I3442bbbf6c0e4bc6089ba89265ebb27d739d7edc Reviewed-on: https://chromium-review.googlesource.com/901862 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#534731}
-
Raymond Toy authored
Bug: 745778 Change-Id: I3b7a5bf5928a412d64cd10eaff729de9dc5a1151 Reviewed-on: https://chromium-review.googlesource.com/903054Reviewed-by:
-
Evan Stade authored
Create an NDS for a generic/"system" profile on demand and asynchronously to service notification requests that aren't tied to a particular user. Apply this to WebUsbDetector, and also update some Chrome OS specific notifications which had been doing pretty much the same thing, but had assumed/forced synchronicity. Bug: 783018, 793877 Change-Id: I95f4434bd6557bf846f5ed89052d4cff7f6bcf21 Reviewed-on: https://chromium-review.googlesource.com/891488 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#534729}
-
Christos Froussios authored
Exporting an empty password list has no value for the user. Additionally, exporting while the password list is still loading is undefined behaviour. For these reasons, we only show the Export Passwords menu item only once the password list has been read and is non-empty. Bug: 789561,805534,807975 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ief82b4b46a231402dbaa7251e514c4078f7be31a Reviewed-on: https://chromium-review.googlesource.com/897486 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#534728}
-
https://webrtc.googlesource.com/src.git/+log/7092368982d3..5c8622fa2570 $ git log 709236898..5c8622fa2 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I72f6556dd4667fa2d7d0c873a72a62bfa350d36c Reviewed-on: https://chromium-review.googlesource.com/904849 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534727}
-
danakj authored
This adds a GpuBacking object to PoolResource, which holds ownership of all the GpuMemoryBuffer-based backing objects. The ZeroCopyRasterBufferImpl has a subclass with its own specific types in it, and populates them: a) When AcquireBufferForRaster is called it creates the GpuBacking and ensures the sync token is waited on if present. b) When the RasterBuffer is destroyed, back on the compositor thread, it binds the GpuMemoryBuffer to a mailbox, and stores those onto the GpuBacking. Then ResourcePool can export the GpuBacking by reading the mailbox of it. And when the resource is destroyed, the GpuBacking cleans up the ownership of the mailboxed texture and GpuMemoryBuffer. R=vmpstr@chromium.org Bug: 730660, 738190 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iac964108e2ab767239e9968e03f82bc80d6a6e3b Reviewed-on: https://chromium-review.googlesource.com/888844 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#534726}
-
Ian Vollick authored
This reverts commit 31c3e864. Reason for revert: looks like there are bugs in the serialization code. Reverting while I investigate. Original change's description: > [vr] Add not-web-exposed media feature for immersive mode. > > With this change, I've added a media feature that returns true when > in immersive mode (eg, in VR). I've added extra plumbing to ensure that > this new feature is not web exposed. > > More info on media features here: > https://www.w3.org/TR/css3-mediaqueries/#media1 > > The plumbing for this particular feature is very close to the plumbing > for -webkit-transform-3d. > > I've also changed the "page popups suppressed" setting (which was only > ever true in immersive mode) to be named immersive, accordingly. > However, the uses of the immersive mode setting for suppressing page > popups are meant to be temporary, so I've added comments referencing > the bug that explains the removals. > > Bug: 809021 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Ib46237b7c7f518830d0134c51baefeb3a1d89c11 > Reviewed-on: https://chromium-review.googlesource.com/901484 > Reviewed-by: Rick Byers <rbyers@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534497} TBR=avi@chromium.org,rbyers@chromium.org,vollick@chromium.org,kenrb@chromium.org Change-Id: Ieab8e1124aa92e98aeceb68504a16695024b08f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 809021 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/905062Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#534725}
-
Matthew Jones authored
This patch adds a new flag for Chrome Duplex since there is too much overhead in reusing the original Chrome Home flag. isChromeHomeEnabled now always returns false. Tests that depend on the bottom sheet have been removed with the exception of those related to suggestions, observers, and swipe logic (which are temporarily disabled). BUG=805070 Change-Id: I1ec39da11e1e7e0f14cbbe9e77a24f3cd16edd10 Reviewed-on: https://chromium-review.googlesource.com/876529 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#534724}
-
clamy authored
This CL fixes an issue where new navigations are wrongly considered a reload. Prior to this CL, a browser-initiated navigation would be converted to a reload if it matches the URL of the last attempted navigation. However, we should only compare to the URL of the last committed navigation, otherwise we will not create a new NavigationEntry when the navigation commits but will instead modify the last committed NavigationEntry. This is an issue since we did the comparison with the last pending NavigationEntry, not the last committed one, so it is quite likely that their URLs don't match. BUG=809040 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I86a3c2f9b933bc6eadd89a3e694e01b985ac4e91 Reviewed-on: https://chromium-review.googlesource.com/824663 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#534723}
-
Rohit Rao authored
UIStackView automatically positions views in a vertical column, which allows us to remove a number of positioning constraints. This also makes it possible to change individual pieces of the incognito ui without needing to modify any constraints. BUG=805521 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib746a91202946235e6de3c20f88947d8e85ee49b Reviewed-on: https://chromium-review.googlesource.com/900182 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#534722}
-
Evan Stade authored
Various changes: - Start adding DEPS exceptions in preparation for banning ui/message_center dependencies more broadly. - Remove a file full of constants in ui/message_center - delete some unnecessary message_center.h includes - remove some message center color constants in favor of direct use of Label::SetAutoColorReadabilityEnabled. BUG=783018,723882 TBR=rogerta@chromium.org Change-Id: Ia7b9332d575a77581691f65f98c945754820c212 Reviewed-on: https://chromium-review.googlesource.com/879501Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/a1303e46889b..4c7a9a8e39f1 $ git log a1303e468..4c7a9a8e3 --date=short --no-merges --format='%ad %ae %s' 2018-02-05 estevenson [Dashboard] Add M64-M65 milestones to speed releasing dashboard. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1d55b4af1eeaa37a6b5931d07407ee44e3ffe876 Reviewed-on: https://chromium-review.googlesource.com/904805 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Pavol Marko authored
Move parsing of the 'Certificates' section of ONC to the new class OncParsedCertificates. CertificateImporter uses this as its input. This is a preparation for not importing policy-provided server and authority certificates into the NSS database anymore, but only making them available as temporary NSS certificates. chromeos_unittests --gtest_filter=*CertificateImporter* && chromeos_unittests --gtest_filter=OncParsedCertificatesTest* Bug: 787602 Test: unit_tests --gtest_filter=*NetworkConfigurationUpdater* && Change-Id: Id42f512c9b2287eb582ef3f6ade6b31f32eaf024 Reviewed-on: https://chromium-review.googlesource.com/898963Reviewed-by:Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
