- 20 Apr, 2018 2 commits
-
-
Rob Wu authored
BUG=834055 Change-Id: I060d4e879f42416916bac8f2a5b5b3f487c0df1b Reviewed-on: https://chromium-review.googlesource.com/1019447Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Rob Wu <rob@robwu.nl> Cr-Commit-Position: refs/heads/master@{#552208}
-
Malay Keshav authored
This patch moves the flag base for enable display zoom slider from a switch to a feature and enables it by default. Bug: 790723,835030 Change-Id: I1b5ed5adac4febd1a0ca7a1aff36d5ac4e691b54 Component: display switches, chromeos switches, settings ui Reviewed-on: https://chromium-review.googlesource.com/1018145Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#552207}
-
- 19 Apr, 2018 38 commits
-
-
Jinsuk Kim authored
This is a preparatory CL for upcoming changes that will remove API getWebContents/getContainerView from ContentViewCore. Tab defines direct references to WebContents and container view. WebContents is passed to |initialize| and ContentView is created as the container view in |createContentViewCore|, so it doesn't need to access them indirectly through CVC. They are set in |setContentViewCore| and nulled out in |destroyContentViewCore| to keep their validity in sync. Accompanying changes for cleanup: - Deleted |getActiveContentViewCore|. Other method of similar name |getContentViewCore| returns null if Tab is showing native view or rendered content is already destroyed. So using it instead is enough for all the callsites that already have null checks or tests that know all the preconditions. - |getContentView| always returns container view for non-native page. In fact it is what it was already doing - just made it clearer by removing some dead code in it. Its return type is ViewGroup, and will be used as a replacement for CVC.getContainerView() in other classes. Bug: 598880 Change-Id: I0c5966b69f6871ce53aa5ffadb73a76214ad35b2 Reviewed-on: https://chromium-review.googlesource.com/1018561Reviewed-by:
Yash Malik <ymalik@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#552206}
-
Sergey Ulanov authored
Comments in callback.h were confusing because sample code was incorrect. Updated sample code to make it consistent with the documented behavior. Change-Id: Id42a9465c49b65937d7b34bf8c0b3664085a628f Reviewed-on: https://chromium-review.googlesource.com/1019870Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#552205}
-
Saman Sami authored
This method adds the right component id to snapshot-related latency info, We can just send the right component id to the renderer so that a correction browser-side is not necessary. Test: Lots of pixel tests take screenshots. Also tested Page.captureScreenshot manually. Bug: 810037, 775030 Change-Id: I61242ad63c5af8975331cb405fc629ce19ef92f8 Reviewed-on: https://chromium-review.googlesource.com/1019389 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552204}
-
Lily Houghton authored
This CL implements an HttpServer class for the network service, modeled after net::HttpServer, but using mojo tcp sockets. The goal is to convert existing embedders of net::HttpServer to using this wrapper class and eventually remove net::HttpServer. Bug: 821000 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0b567a932da0b4572d65f99e81c98ce1c79a1bb5 Reviewed-on: https://chromium-review.googlesource.com/973698 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#552203}
-
Kent Tamura authored
Bug: 829697 Change-Id: Iccf1ebcccad3f7670b65d7e52c7d1481d328b289 Reviewed-on: https://chromium-review.googlesource.com/1018783Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#552202}
-
Devlin Cronin authored
ExtensionFunction::GetAssociatedWebContents() returns a WebContents for ExtensionFunctions to use. However, *which* WebContents is returned is unclear and unpredictable. In *most* cases, it will return the sender WebContents; i.e., the WebContents associated with the RenderFrameHost from which the API call originated. This is what most callers expect. However, if this fails, it can also return other WebContents, including the WebContents for the currently-active tab. This is very unclear from the name and usages, and almost never what the APIs should be using. APIs which do require a WebContents other than the sender should explicitly retrieve that API (e.g., through TabStripModel::GetActiveWebContents(), etc). Explicitly mark the method as deprecated to discourage further use. Followup CLs will work on removing the remaining usages of this API. Bug: 461394 Change-Id: Ic636975e6ffe210cebcd15cdef99032ff16a1110 Reviewed-on: https://chromium-review.googlesource.com/1020194Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552201}
-
Kurt Horimoto authored
Bug: 805089 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If2a51c2f60c7dd42d4fa3275947c6876333e2dce Reviewed-on: https://chromium-review.googlesource.com/1018111 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552200}
-
Mark Pilgrim authored
BUG=773295 Change-Id: I8916ad1ff43dd420c07efa8de4f9a886468c0d39 Reviewed-on: https://chromium-review.googlesource.com/1010515Reviewed-by:
Pam Greene (Please send IM for reviews) <pam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#552199}
-
sczs authored
- Removes TableContainerVC, Creates TableViewNavigationController. - Renames TableContainerConstants to TableViewNavigationControllerConstants. - Creates HistoryLocalCommands Protocol. - Deletes HistoryTableContainer VC. - Deletes HistoryUpdaterDelegate and HistoryTableVCDelegate. - Updates Eg tests with new constant name, Bug: 805192 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I43e27dbc58d2ad788ab6f7f16c44685dcd6a6f05 Reviewed-on: https://chromium-review.googlesource.com/1020404 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#552198}
-
Demetrios Papadopoulos authored
Removing the --paper-button CSS mixin at r551209 changed the specificty of CSS rules being applied. Fixed by using the keyboard-focus class directly, instead of relying on yet another mixin --paper-button-flat-keyboard-focus. Bug: 834739 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iabd8f698a2b1ed65bb98af6a86fe2f957280ae61 Reviewed-on: https://chromium-review.googlesource.com/1019880Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#552197}
-
Shimi Zhang authored
We want to hide the active text handle when the HandleObserver is activated. We only want to make the handle invisible but still keep it functioning. So in this CL we are setting its alpha to control the visibility. Bug: 798017, 814868 Change-Id: I1d3018ab6a40307eae67c5f0146e84c0c297bcf3 Reviewed-on: https://chromium-review.googlesource.com/1011552Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#552196}
-
Chris Blume authored
When a child LSI allocation is being processed by the parent, the parent should not send extra IPCs which it will later overwrite. This suppression currently happens on Aura platforms but not Mac. This patch adds it to Mac. BUG=805073 Change-Id: I3bda7dbdb97afb982e031ac354f06ce1c385e07d Reviewed-on: https://chromium-review.googlesource.com/1011556 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#552195}
-
spqchan authored
Don't show the "Look Up" menu item in the textfield context menu if the textfield is a password field. Testing: views_unittests TextfieldTest.LookUpPassword. Bug: 832103 Change-Id: I1fd526b0e51b19ae6f118da1d628958f26da380b Reviewed-on: https://chromium-review.googlesource.com/1013782Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#552194}
-
Theresa authored
Add missing parenthesis BUG=834718 Change-Id: I5df5cd2866663e16ab58b04575b5e5fd5c8b25fe Reviewed-on: https://chromium-review.googlesource.com/1020148Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#552193}
-
Alexandr Ilin authored
This CL adds the support for passing PlatfromSharedMemoryRegions between processes via IPC messages. Bug: 795291 Change-Id: I13b22226866b0a4e5d97e66f4ce93e5ad28fdaac Reviewed-on: https://chromium-review.googlesource.com/937514 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#552192}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/161623779eaf..5c62ed59d2a3 $ git log 161623779..5c62ed59d --date=short --no-merges --format='%ad %ae %s' 2018-04-19 ehmaldonado owners: Add support for comments at the end of the line. 2018-04-19 tandrii [git-cl] make more informative error message. Created with: roll-dep src/third_party/depot_tools BUG=chromium:789773 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I9c55e9864502a0ec1895124e9ed8c4421d73e3f3 Reviewed-on: https://chromium-review.googlesource.com/1020234 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552191}
-
Miguel Casas authored
This reverts commit 5eec3679. Reason for revert: Caused regression in video_VideoSeek: https://crbug.com/834146 Bug: 834146 Original change's description: > RELAND: Vaapi: Remove ConditionVariables and use PostTask > > This CL relands the attached CL that got reverted due to scaling > issues, i.e. when the decode bitstream changed resolution, there > was the chance that before marking |awaiting_va_surfaces_recycle_|, > we could get an "old" resolution frame, that would confuse |decoder_|. > > The solution is to move |awaiting_va_surfaces_recycle_| marking to > DecodeTask(), and hold off any more Decode() operations until the > "old" resolution frames are processed. This in turn makes > InitiateSurfaceSetChange() superfluous, so it's moved into DecodeTask(). > The rest is comment update :-) > ** Changes can be found here: crrev.com/c/973684/3..9 > > TEST=http://crosvideo.appspot.com/?codec=vp9&cycle=true&loop=true&mute=true > and letting it roll through many many many resolution changes. > > Original CL description ------------------------------------------------ > > This CL removes the use of the ConditionVariables inside VaVDA and > uses instead PostTask()ing. This removes blocking the worker > thread, which allows for moving other tasks there, e.g. the > Surface Blit (as done in the follow up WIP CL crrev.com/c/947341) > > For all that goodness, this CL: > > - Refactors the waiting logic that on ToT is spread between > GetCurrInputBuffer_Locked() and WaitForSurfaces_Locked() and > simplifies it in DecodeTask() itself. > > - Moves the |curr_input_buffer_| filling logic in > GetCurrInputBuffer_Locked() into DecodeTask() proper. > > - Reduces the scoped of the |lock_| in DecodeTask() (note that > |curr_input_buffer_| and |decode_| are only used on the decoder > thread -- added a .h comment). > > Minor stuff: This CL also moves together the declaration of the > related member vars |input_buffers_|, |curr_input_buffer_| and > |available_va_surfaces_| > > TEST=simplechrome+crosvideo (including seeks) on soraka, and > v_d_a_unittest with h264, vp8, vp9 (with dcheck_always_on=true). > > Bug: 717265 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel > Change-Id: I86d179ac4d48c63b36787f5c7bdcb0da3839ed69 > Reviewed-on: https://chromium-review.googlesource.com/949283 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#542955} > Reviewed-on: https://chromium-review.googlesource.com/973684 > Cr-Commit-Position: refs/heads/master@{#546827} TBR=posciak@chromium.org,mcasas@chromium.org,dcastagna@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 717265 Change-Id: Ic31471daf757fd08ff2f420afc5be7e973a88c01 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1020040 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#552190}
-
Kevin Marshall authored
The logging levels for some of the major deployment steps were promoted from "debug" to "info". It should provide some insight into the status of the run without adding adding much clutter to the logs. Change-Id: I06fd1cf8a72a23bcb12a15be0d03c1f1587a4281 Reviewed-on: https://chromium-review.googlesource.com/1020285Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#552189}
-
Filip Gorski authored
Bug: 834035, 834391 Change-Id: I8eafb0da74638257719be7740455d9da5f2ad5c8 Reviewed-on: https://chromium-review.googlesource.com/1017595 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#552188}
-
https://skia.googlesource.com/skia.git/+log/c4e384e5ad85..b3a6959408e1 $ git log c4e384e5a..b3a695940 --date=short --no-merges --format='%ad %ae %s' 2018-04-18 csmartdalton ccpr: Clean up GrCCGeometry 2018-04-19 herb Adding pinning to the strike cache 2018-04-19 bsalomon Fix double counting of coverage in analytic round capped stroked circles. 2018-04-11 bungeman Document minimum OS requirements. 2018-04-19 angle-skia-autoroll Roll third_party/externals/angle2/ eeec3b14c..e24032a2c (2 commits) 2018-04-18 robertphillips rm SkRRectsGaussianEdgeMaskFilter 2018-04-19 borenet [skcms] Add version.sha1 2018-04-19 mtklein crash rather than overflow in SkTDArray Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I1993ae84dc847f2b4cff9f4dad8bd48296c97df5 Reviewed-on: https://chromium-review.googlesource.com/1020192 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552187}
-
Kurt Horimoto authored
This CL adds "Add Tab", "Refresh", and "Close Tab" buttons to the OverscrollActionView for the UI refresh. Bug: 805092 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8e562bccf7f6cb062f96d4ae0c0e43872fdeb25b Reviewed-on: https://chromium-review.googlesource.com/1018008 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Michael Lippautz authored
... on incremental marking builds. Tbr: haraken@chromium.org No-try: true Bug: chromium:831541 Change-Id: I3c1e3f4b244eaead7824aee43386807ec5eb8d62 Reviewed-on: https://chromium-review.googlesource.com/1019971Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#552185}
-
https://pdfium.googlesource.com/pdfium.git/+log/54e6da1ee793..9914d4dc1e7a $ git log 54e6da1ee..9914d4dc1 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 thestig Make CPDF_StitchFunc use more vectors. 2018-04-19 thestig Do more validation in CPDF_StitchFunc::v_Init(). 2018-04-19 thestig Do a bit more validation in CPDF_ExpIntFunc::v_Init(). Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2fd362f290bf89b3f70a0ecff9ec3a320e2ece2e Reviewed-on: https://chromium-review.googlesource.com/1020188Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552184}
-
Ned Nguyen authored
This reverts commit 0ef4af14. Reason for revert: break Telemetry tests BUG:834833 Original change's description: > Update top offset of motion events on hover in CompositorViewHolder > > When entering VR we hide the browser controls. However, it can take some > time for this state update to reach the FullscreenManager. As a > consequence, hover move events may have a false offset depending on > whether the initial hover enter event was processed with the updated > browser controls state or not. To fix that, also update the top offset > for hover move events. > > Bug: 822384 > Change-Id: I196a38098f736d6a9c8066b0a48cafa774ea1864 > Reviewed-on: https://chromium-review.googlesource.com/1014708 > Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551502} TBR=mdjones@chromium.org,jinsukkim@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 822384 Change-Id: Ibb0dd8b2fe110e9f7ecd7785604f956fede4bfd3 Reviewed-on: https://chromium-review.googlesource.com/1020240Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#552183}
-
danakj authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1019614 the test is no longer failing flakily. R=piman@chromium.org Bug: 834613 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9a26d5e4833e5566d5fd184894d2b6b951226fe1 Reviewed-on: https://chromium-review.googlesource.com/1020287Reviewed-by:
-
Miguel Casas authored
This CL is a refry of crrev.com/c/1018020, but including only the VP9.2 MD5SUM. "Original" CL description ---------------------------------------------- This CL corrects the MD5 values for two video_decode_accelerator_unittest cases: [ ... ] - VP9 Profile 2: the last round of MD5 updates missed this one (causing the autotest runs to be red; this was not obvious due to other test issues). This CL simply updates this value. Bug: 834156 TBR=hoegsberg@chromium.org, since it's a trivial part of an already landed CL. Bug: 834954 Change-Id: I19c7c59de437a99c6e29d42020bc0993619f804b Reviewed-on: https://chromium-review.googlesource.com/1020024Reviewed-by:
-
Matt Menke authored
This API has proven problematic in the past, and the NetworkService has better defined NetworkContext lifetime semantics, so it's not needed. Bug: 810776 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6f49a7d7bab973e591e27bb55f17d3fe468d5f20 Reviewed-on: https://chromium-review.googlesource.com/1015823Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#552180}
-
Gabriel Charette authored
This is another scripted pass done by a slightly modified version of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which has a better notion of "scope". The script should have replaced a MessageLoop::ScopedNestableTaskAllower in the same scope as a RunLoop with a RunLoop of Type::kNestableTasksAllowed. Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=flackr@chromium.org Bug: 781352 Change-Id: Ica51fdb505201c8f1944b160ef6dba8553b0c338 Reviewed-on: https://chromium-review.googlesource.com/1013215Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#552179}
-
David Reveman authored
Use base::Optional for startup and application ID in order to handle null values properly. Setting one of these to null will now clear the window property. Bug: 834971 Test: exo_unittests --gtest_filter=ShellSurfaceTest.Set*Id Change-Id: I395fb02200f310b027060eb28e0132d8976532ab Reviewed-on: https://chromium-review.googlesource.com/1020042Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552178}
-
https://chromium.googlesource.com/catapult.git/+log/4fe4dbb4de4b..28f445af33ee $ git log 4fe4dbb4d..28f445af3 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 nednguyen Disable TracingControllerTest.testFlushTracing on Win Created with: roll-dep src/third_party/catapult BUG=chromium:829976 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ic9c8c155db319df4a98b55d8593c3089cae84549 Reviewed-on: https://chromium-review.googlesource.com/1020154 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552177}
-
https://chromium.googlesource.com/angle/angle.git/+log/1d97a4d0363d..025aafdfc4af $ git log 1d97a4d03..025aafdfc --date=short --no-merges --format='%ad %ae %s' 2017-10-30 geofflang Make EGL image extensions enableable. 2017-11-07 geofflang Make EXT_texture_storage enableable. 2018-03-28 geofflang The 'format' of unsized SRGB internal formats should be SRGB too. Created with: roll-dep src/third_party/angle BUG=chromium:693090 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Id036eb947993a00093291ad5dfa30663529e3471 Reviewed-on: https://chromium-review.googlesource.com/1020149 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552176}
-
Wenzhao Zang authored
Bug: 832867 Change-Id: Ie93bb1a9aa2ed051c437a56fe9aec25b6b99c60c Reviewed-on: https://chromium-review.googlesource.com/1017540 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#552175}
-
Jian Li authored
The content:// URL can contain SPACE and other characters that are not escaped. To deal with this, we base64 encode the value. Bug: 830983 Change-Id: I8737fb1f94f1a498429af42ef53d61adfe237cc2 Reviewed-on: https://chromium-review.googlesource.com/1013087Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#552174}
-
Siddhartha authored
The unwind file is included in some channels and not in other channels. It is only added to 32-bit apk since 64-bit ones have frame pointers. Add use-unwind-cfi argument to use the file when needed. BUG=819888 Change-Id: Ia4560815b2c7ef0e5ba852c8a31f7b132d86c11c Reviewed-on: https://chromium-review.googlesource.com/998309Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#552173}
-
Erik Chen authored
This CL has no intended behavior change. It addresses some comments from gab@ on another CL that already landed: https://chromium-review.googlesource.com/c/chromium/src/+/978393. Bug: 825218 Change-Id: I78fee61253c6b885350774b774477060580984be Reviewed-on: https://chromium-review.googlesource.com/998313 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/8d7393bb2893..06d094f3e621 $ git log 8d7393bb2..06d094f3e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:b/73147161,chromium:834255,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ied4fd21c1ec0052642513344fb45ebac61f2782e Reviewed-on: https://chromium-review.googlesource.com/1019868 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552171}
-
James Cook authored
Internals>MUS was renamed to Internals>Services>WindowService in the bug tracker. Rename the references in OWNERS files so that clusterfuzz auto-filed bugs apply the correct component. TBR=sky@chromium.org TBR=rjkroege@chromium.org Bug: none Change-Id: I4ab9d9862cd8d005c3a12ed97edae1dc5903d8df Reviewed-on: https://chromium-review.googlesource.com/1020364Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#552170}
-
Dominic Mazzoni authored
Revert "Android Accessibility: Set flag to enable jump to last element on ACTION_PREVIOUS_HTML_ELEMENT" This reverts commit 90d35140. Reason for revert: infinite loop (crbug.com/834866) Original change's description: > Android Accessibility: Set flag to enable jump to last element on ACTION_PREVIOUS_HTML_ELEMENT > > This CL is a followup on the following CL: > https://chromium-review.googlesource.com/736043 > > The above CL returns the deepest child of web view on ACTION_PREVIOUS_HTML_ELEMENT if > can_wrap_to_last_element flag in OneShotAccessibilityTreeSearch is set to true. > This CL sets that flag for Android. Assuming a web view is in between native elements, the > following order will be followed for a11y focus: > Native elements -> web view container -> inside web view container -> native elements. > So web view container will always be focused only in the above order. > > Bug: 661793 > Change-Id: I62dbcb143ed5a152172dc7cde9355f4b7eed79e1 > Reviewed-on: https://chromium-review.googlesource.com/884302 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536742} TBR=dmazzoni@chromium.org,ibobra@google.com NOTRY=true Bug: 661793, 834866 Change-Id: I3dc34c17908aa06c33a904415d10fc0d5a56fc2c Reviewed-on: https://chromium-review.googlesource.com/1019960 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#552169}
-
