- 28 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e44b5225dbfd..d6f6ff7083d1 git log e44b5225dbfd..d6f6ff7083d1 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 perezju@chromium.org [Telemetry] Stop doing metric computation. Created with: gclient setdep -r src/third_party/catapult@d6f6ff7083d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:981349 Change-Id: I9aec6e822dc2ec114b45c6b2f27f3323f9bf1e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883774Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709919}
-
Matt Jones authored
This patch calls the previously manually called destroy method on BottomSheetContent. This is triggered when the sheet is hidden (and not suppressed), regardless of whether the sheet has a custom lifecycle. Change-Id: I392fd98e384cfbdc73422959417e20b246da2f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879688Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#709918}
-
Nektarios Paisios authored
When a RenderFrameHost is being swapped out, it will be in the process of being deleted. Before any requests from accessibility should be serviced, we should check if the RenderFrameHost is not being swapped out. Otherwise, parts of the class instance, such as its RenderViewHost, might have been destroyed, or the renderer associated with the RenderFrameHost instance might not be able to receive IPCs. R=dmazzoni@chromium.org Change-Id: I08a87cad7b789f0752adbcc1564b748456d5d338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881324Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#709917}
-
Manu Cornet authored
When the overview mode ends, calculate a bit more accurately whether the app list is about to be shown. Bug: 1018346 Change-Id: Id269a90a58f2d7db9af494ea0fbd7b1ea91e715e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882318 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#709916}
-
Jochen Eisinger authored
Bug: 1018108 Change-Id: Ib6e14fa2ff814ebaec419cf768b11633015c2298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879290Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709915}
-
kylechar authored
Adjust the events to be more accurate. "WaitForSwap" starts when display compositor thread starts issuing the swap buffers command. "Swap" starts when the GPU thread starts running the swap buffers task. "WaitForPresentation" starts when the swap buffers command has been issued and ends at presentation time. Bug: none Change-Id: Ia1aa9f64f946c24b03b8c720b72ca35673f86e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876973Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#709914}
-
Olivier Robin authored
Tbr: eugenebut@chromium.org Bug: 987646 Change-Id: I10f44d136c205c6259a96cc5079b57bf720fab39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881232 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709913}
-
John Delaney authored
This CL adds a chrome://flags entry for the heavy ad intervention. There is an additional option provided to enable the intervention without mitigations for debugging purposes. Bug: 1012293 Change-Id: I70dee3ec0f8d22bf4032bf03ac713e21320ff430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854169 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#709912}
-
Sergio Villar Senin authored
In order to remove the WebContextMenuData dependency from chrome/browser we need to extract all the data types used in c/b from web_context_menu_data.h and move them to different files under third_party/blink/public/common. WebContextMenuData::InputFieldType is converted to a strongly typed enum class and moved to a different file under public/common so that chrome/browser does not depend on public/web. Bug: 1014517 Change-Id: If4f90dbd69943c5d14bb12594a1a0a46cdb15a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876088 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Andrew Grieve authored
This class exists in the default bootclasspath in JDK8, but not in JDK 11. This dep makes the annotation processor work when used with JDK 11's javac. Bug: 693079 Change-Id: Ic5258aa0fd1b438d7ba0dd393f95b3a2b78d5c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882066 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709910}
-
Leonard Grey authored
It's not doing enough to justify a subclass anymore IMO. Bug: None Change-Id: I8cfc07e6c1f7eb3ca11f097db5fdcaf147522c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881718Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#709909}
-
Andrew Grieve authored
This allows them to process code targeting JDK11. Bug: 693079 Change-Id: If638e78796d2f2098cb0c0f0fc0b89739b5d43e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882627 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Mikel Astiz authored
Many flaky sync tests cannot be reproduced locally and even flake occasionally on bots. Hence, let's be verbose when they do fail, and print a detailed trace of the sync traffic as experienced by the FakeServer. This is achieved by leveraging gTest's ScopedTrace. Such detailed log should be, in many cases, sufficient to understand what caused the flake. Bug: 1017645,1014086 Change-Id: Icd9bf9637cfb6dd7da789aa0adee5c7161339b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883651 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#709907}
-
Henrique Nakashima authored
This reverts commit 5f4571dc. Reason for revert: Another metric, TaskStartedNative, is logged incorrectly. Original change's description: > Fix crash when Background Memory metrics task is scheduled immediately. > > It is scheduled with a random delay between 0ms and 59999ms. When it is > exactly 0, the delayed task is actually executed as a regular task, > and since it is scheduled just before the task that starts native, > it runs without native, causing a crash. > > Moving recordMetrics() to after native is initialized fixes the issue. > > Bug: 1017130 > Change-Id: Ica5d0a125b93433bd2291a6c73ac30d3fd890aa8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880172 > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709269} TBR=hnakashima@chromium.org,mheikal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1017130 Change-Id: Ie5bef0866b02530232aeb383adfaae5feaf6511a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883044Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#709906}
-
Nico Weber authored
GOOGLE_CHROME_BUILD is more a branding thing. Since Google Chrome builds set both GOOGLE_CHROME_BUILD and OFFICIAL_BUILD, this doesn't have an effect in practice. People who do non-Google Chrome-branded OFFICIAL_BUILD asan builds will now get the different flags, which seems like a good change. While here, also deduplicate the common flags and add a comment saying that the OFFICIAL_BUILD asan flags are basically never used. Bug: 961769 Change-Id: I42491c1d4d3ab876b0de92d0746266580dafe1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882109 Commit-Queue: Alexander Potapenko <glider@chromium.org> Reviewed-by:
Alexander Potapenko <glider@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#709905}
-
Richard Knoll authored
This behaviour will move to the InstanceID infrastructure, but in order to mitigate risk for M79 let's start off in a more localized fashion. Bug: 1006279 Change-Id: I29695df8cbb044cd51b0aee399362fc771197c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880037Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#709904}
-
Justin Cohen authored
Don't trigger the initial load for restored WebStates since the number of WKWebViews is unbounded and may lead to an OOM crash. Instead, disable and re-enable WebUsageEnabler SetTriggersInitialLoad Bug: 1018337 Change-Id: Iaccecc3c0a1e68465b31b8503eee7b6d061d4f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879205Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709903}
-
Kevin Bailey authored
There were some reported oom's, so curb size to something reasonable. This CL only affects the fuzzer. Bug: 1018506, 1018522 Change-Id: I051da49d510fb108dea95925104c839d11ef5aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883871Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#709902}
-
Luke Zielinski authored
Bug: 937369 Change-Id: Id8d3c7cb738b8c871b76a23cee23fd7dd43d6981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879601 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#709901}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/99564c9b..f9d7f08e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iec8c63863c6120b57ed3b44e20ebe78e7182c0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882939Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709900}
-
Ioana Pandele authored
This CL removes the subtitle of the toggle when signed in or when signed out with the feature disabled. Bug: 1014660 Change-Id: I6e9913c889aed461a4adb10e7a4169f09936409e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883071 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#709899}
-
Olivier Li authored
This change is the last mile of of the Chrome-wide effort to prefer Sequences to Physical Threads (https://chromium.googlesource.com/chromium/src/+/master/docs/threading_and_tasks.md#Prefer-Sequences-to-Physical-Threads) This change is intended to be a no-op from sync's point of view. Change-Id: Ie771c3a681b0483711ec1232544b92f2766caf47 Bug: 1014464 Change-Id: Ie771c3a681b0483711ec1232544b92f2766caf47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856922 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#709898}
-
Michael Ludwig authored
In the most common case, texture draw quads are just images and can be bypassed very much like tiles or video quads. When it has a background blend, we can still apply the RPDQ parameters but it's no longer appropriate to merge the background alpha with the layer's opacity. Unfortunately, it starts getting really tricky to sort out the proper order of operations for per-vertex opacity, layer opacity, and other forms of masking. This seems like a pretty rare corner case for texture quad usage (I only found unit tests and one place in Chrome that uses it), so CanPassBeDrawnDirectly just prevents quads with per-vertex opacities form being bypassed. Bug: 1013735 Change-Id: I504d9492f5261c4930776c8d91504c9b71e1df70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863590 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#709897}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/97bcfab8abdd..91527d03092e Created with: gclient setdep -r src-internal@91527d03092e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I073d8470c1ad839a0053907611a418782a8d7938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883772Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709896}
-
Nico Weber authored
Changes some new uses, and does fairly harmless modifications to keep GOOGLE_CHROME_BRANDING out of .h files. Bug: 961769 Change-Id: Ia273654e515c1ba07cbd91b51937422d792a9f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882110Reviewed-by:
-
Yuki Shiino authored
Use of "${ x | trim }" of Mako template unconditionally removes whitespaces including newlines. It makes it hard to insert empty lines in generated code. This patch revisits the newline problem again, and improves it. Bug: 839389 Change-Id: If838b4766fe8938e7f7c2bfb2ff8802d56ac9441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883830Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#709894}
-
Jeremy Roman authored
Inspired by https://groups.google.com/a/chromium.org/d/topic/chromium-dev/Y8kOXPOqA9A/discussion Tbr: dcheng@chromium.org No-Presubmit: true Change-Id: Ib83a4c72028fe7a36f7cb68b0399bb1a84dec902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844059 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#709893}
-
Javier Ernesto Flores Robles authored
Bug: 1017690 Change-Id: I68b0643a099456c41c1abd483c1ae66edc957398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878411 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
henrika authored
Trivial change which only cleans up WebRTC logs containing the string "request_id=n". We used to mix "request_id=n" and "request_id = n" but now all white-spaces are removed to make the logs more consistent and easier to parse. Bug: 1017219 Change-Id: I0aed5cccb7c77d14a63b8a972ae92ce748ba88cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878368Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#709891}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id2c18902346490fa5b66a711c2bd7ee7a71281c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883771Reviewed-by:
-
Matt Falkenhagen authored
So it's not split between two files. Change-Id: Ib39b2e1147a6424884f7f26cdcd505681a51fc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880989 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#709889}
-
Francois Doray authored
LockObserver browser tests were disabled on Android Kit Kat because of flaky failures of the navigation performed in SetUpOnMainThread(). Since it is not important to perform the navigation from SetUpOnMainThread(), this CL moves it to the test body. The failure seems related to this comment: https://cs.chromium.org/chromium/src/content/public/test/browser_test_base.cc?l=650-664&rcl=786a9194459684dc7a6fded9cabfc0c9b9b37174 This CL also removes the ContentMockCertVerifier in LockManager browser tests, and instead specifies the switches::kIgnoreCertificateErrors command-line flag, which is simpler. Bug: 1011765, 1014015 Change-Id: Ia1e140605a6734a95012f5c6019c6cef4918f372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854901 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#709888}
-
Richard Knoll authored
This is a temporary workaround as the XPC used to show alert style notifications does not work on 10.15+. Showing those as banners is not ideal as they auto dismiss into the notifications center but it is better than not showing them at all. Bug: 1007418 Change-Id: Ib50ed9f2125b7bdf5885b5ffd63e81137e50e2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883648Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#709887}
-
Andreas Haas authored
We want to use V8::BackingStore as the backing store implementation for WTF::ArrayBuffer to clarify memory ownership. However, libwtf, where WTF::ArrayBuffer is at the moment, does not load libv8. Therefore this CL moves the implementation of WTF::ArrayBuffer to DOMArrayBuffer, which is the only real user of WTF::ArrayBuffer anyways. Note that in the long run we want to remove WTF::ArrayBuffer completely. This CL is one step to enable that removal.d This CL did the following changes: * Move the implementation of WTF::ArrayBuffer and co from /platform/wtf/typed_arrays/* to /core/typed_arrays/array_buffer/*. * Adjust includes where necessary. * Adjust the include guards. * Introduce a new DEPS file. * Adjust BUILD.gn files. * Add exception to third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py. * Change the namespace of all moved classes from WTF:: to blink:: R=haraken@chromium.org Bug: chromium:1008840 Change-Id: Iaee4937d3acce7ea578fbf2e278b6fa91f3b4627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875731Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This dialog's button labels can change as its model is updated, so always reset them in UpdateUIForCurrentSheet() before calling DialogModelChanged(). Bug: 1011446 Change-Id: I3125ffe6e9b13c5f365c473de0b5eb226a7ebfb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878629 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709885}
-
Jinsong Fan authored
In GetSelectionStart|Endpoint, the rect local to the layoutObject at the selection start or end might be empty. The CL add checks for that. Bug: 1018679 Change-Id: I203ca1c6683e984699691f5d99a4f3bc3353f5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880362Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#709884}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c189ace20a43..3eae7e4e3cdf git log c189ace20a43..3eae7e4e3cdf --date=short --no-merges --format='%ad %ae %s' 2019-10-28 sprang@webrtc.org Add exponential backoff of retransmissions for a given packet 2019-10-28 perkj@webrtc.org Ignore low probe results when using NetworkStateEstimator under field trial 2019-10-28 jonaso@webrtc.org ICE : add field trial for initial select dampening Created with: gclient setdep -r src/third_party/webrtc@3eae7e4e3cdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I10fc5def882475142265c4c84623c43a46041989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883130Reviewed-by:
-
Yutaka Hirano authored
This is (3) in https://docs.google.com/document/d/1sMG4xAT-myWtFaNa0kuLjRqsyxSy12ahgRIbffy1Bxk/. Bug: 1018050 Change-Id: Ib265bd86153842b4f90c836fb0b06d200e94a787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880361 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/04863c42bedd..f6281a5530c0 git log 04863c42bedd..f6281a5530c0 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 enga@chromium.org perf_tests: Add missing trace event "id" Created with: gclient setdep -r src/third_party/dawn@f6281a5530c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I14e626ecbacb15ff32818334cf4b11bc6a30497a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883129Reviewed-by:
-
Gabriel Charette authored
Only start monitoring after BrowserMainLoop::PreMainMessageLoopRun() invokes base::DisallowUnresponsiveTasks(). R=erikchen@chromium.org, rkaplow@chromium.org Bug: 1018359 Change-Id: I597c4b6a45797c66c0fa1b30fc3efdc9108aa81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881709 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709880}
-
