- 19 Aug, 2019 40 commits
-
-
Stephen McGruer authored
Bug: 900581 Change-Id: Ic4e14f4add81f40add7d80906ca402cdd1ed6334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756984Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#688099}
-
Thomas Tangl authored
Bug: 966388 Change-Id: Iae349be84fb52d489a733beb4629107d4821909c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757020 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#688098}
-
Francois Doray authored
This reverts commit dfede5ad. Reason for revert: No explanation of the failure was provided when this test was disabled. Re-enabling to get more details. It is very possible that the test will no longer fail, since base::ThreadPool code has changed a lot since the test was disabled. Original change's description: > Conditionally Disable HostResolverImplTest.DeleteWithinAbortedCallback_ResolveHost > > TBR=ericorth@chromium.org > > Bug: 930483 > Change-Id: I3d34d27e5e866704778b85e7dc7a83cec7b2110a > Reviewed-on: https://chromium-review.googlesource.com/c/1462798 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630730} TBR=jdoerrie@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 930483 Change-Id: Ic0eaf36dcb56e7fc4252c4849ace77310bade1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758329 Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#688097}
-
Alan Screen authored
JavaScript window.print() requests have been returning back to the renderer process before the print has actually completed. When the print preview is disabled it is easier to expose a race condition between serving the print logic and whatever comes next in the JavaScript. If the script has a popup window to be printed, which has window.close() immediately after the window.print(), then the document to be printed has its destruction racing against being printed - and will typically lose that race, resulting in a lost or empty print job. Resolve by ensuring that the renderer process does not proceed past window.print() until the DidPrintDocument message is sufficiently completed. Making this message synchonous achieves this effect. This means that the renderer process will be blocked for all sites which it serves for slightly longer than it already does. [1] [1] https://www.chromium.org/developers/design-documents/printing Bug: 974480 Change-Id: I3ef08899e1792cc291aa8dd3d740da095e2c73bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700275Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688096}
-
Francois Doray authored
Tests were disabled for a crash that seems unrelated: [ RUN ] TabMetricsLoggerTest.GetHasFormEntry [14286:14286:0404/024920.550507:15005211132:ERROR:render_widget_host_view_base.cc(183)] Not implemented reached in virtual uint32_t content::RenderWidgetHostViewBase::GetCaptureSequenceNumber() const [14286:14413:0404/024920.559998:15005220584:ERROR:database.cc(1599)] Predictor sqlite error 1802, errno 0: disk I/O error, sql: CREATE VIEW MmapStatus (value) AS SELECT -1 [14286:14411:0404/024920.560201:15005220787:ERROR:model_type_store_service_impl.cc(35)] Failed to initialize ModelTypeStore backend: Init@../../components/sync/model_impl/model_type_store_backend.cc:99: IO error: /b/s/w/it3Us7EL/.org.chromium.Chromium.IVwXVq/Sync Data/LevelDB/MANIFEST-000001: Unable to create writable file (ChromeMethodBFE: 9::NewWritableFile::4) [14286:14411:0404/024920.561178:15005221763:ERROR:simple_index_file_posix.cc(36)] opendir /b/s/w/it3Us7EL/.org.chromium.Chromium.IVwXVq/Code Cache/js: No such file or directory (2) [14286:14411:0404/024920.561352:15005221935:ERROR:simple_index_file.cc(612)] Could not reconstruct index from disk [14286:14413:0404/024920.560039:15005220621:FATAL:database.cc(1612)] disk I/O error https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/248217 Before spending more time in investigating the failure, I will re-enable the test and see if it is still flaky. Bug: 949288 Change-Id: I36f63724108358098499c812f1b5fad2f717992f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758327 Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#688095}
-
Alexandre Courbot authored
http://crrev.com/c/1724562 queries the currently focused window at a time where there is possibly no window being focused at all. This results in a NULL window pointer that is then dereferenced. Fix this by checking that we got a non-NULL window before using it. Bug: b:139524595 Bug: chromium:962848 Test: UI starts without crashing on Kukui. Change-Id: I7a65f26a13d6b6f67c866a49175a47eea1228cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760570 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#688094}
-
Vasiliy Telezhnikov authored
Re-enabling BluetoothLowEnergyApiTest and NavigationPredictorBrowserTest for skia_renderer_browser_tests. TEST=skia_renderer_browser_tests Bug: 982933 Change-Id: I08cb6e286987ea0d2e3973adf554b651afb842ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759010Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#688093}
-
Antonio Gomes authored
... rather than a weak pointer to UserMediaProcessor. This is a preliminary step to mo UserMediaProcessor to be GC-able by OilPan. In a follow up, the WebPtrFactory in user_media_processor.h will be completely removed, and UserMediaProcessor will be Oilpan GC-ed. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I067ea8a4c58c8758c474d39a3d4d50c06821ad8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757494 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688092}
-
Yi Gu authored
This test is flaky. See bug for details. TBR=eirage@chromium.org Bug: 995285 Change-Id: Ib6bb14387756bbd9db83f88267c84c8ae909655f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760892Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688091}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9648b419f5cf..f8221786d088 git log 9648b419f5cf..f8221786d088 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 egdaniel@google.com Remove incorrect metal assert. Created with: gclient setdep -r src/third_party/skia@f8221786d088 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: I8804534c980879acf09c1ba1f510ecc3b181a40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760890Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688090}
-
Mike West authored
The `CorsRFC1918` flag currently controls both the CORS-preflight behavior and the `.addressSpace` getter. As the latter is something much more likely to be shippable in the somewhat-near future (as part of [1]), this patch splits it into a distinct runtime feature that can be enabled independent from the larger CORS-RFC1918 framework. The new `AddressSpace` runtime flag controls both the `.addressSpace` getters on Document and Worker interfaces, and also the `treat-as-public-address` CSP directive. [1]: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/EeGg7TxW6U4/9aohper3BQAJ Bug: 986744 Change-Id: I309b64e75901952dd649c19e558ed6484407edbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760734 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#688089}
-
Sean Gilhuly authored
filter-repaint-blur.html, filter-repaint-child-layers.html, and filter-repaint.html have minor visual differences due to blur, so add them to crbug.com/972621. Bug: 954328 Change-Id: I058282af69291f89205bc583e005b3a5cddb6352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756715 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
-
Nicolás Peña Moreno authored
This CL adds tests where there is a bunch of content and LCP must observe the largest (one for when image is largest, one for text). Bug: 994414 Change-Id: I9330f238e1f8a2a8227dce7a04fd741d2dc666d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757165Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#688087}
-
Gabriel Charette authored
(well half of them because git cl upload wouldn't let me do them all at once...) This is step #1 of the mass migration. Some of these will be backported to SingleThreadTaskEnvironment in a later phase. scoped_task_environment.h will also only move in a follow-up CL. TBR=dcheng@chromium.org Bug: 992483 Change-Id: I44bc376deee9b6c95bafac8d54165174d86a5001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756247Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#688086}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/7c66ab5c1445..2906c3c5b3bf git log 7c66ab5c1445..2906c3c5b3bf --date=short --no-merges --format='%ad %ae %s' 2019-08-19 rsmoore@google.com {Git LFS} Correct `.gitattributes` to use path and not glob. (#8338) Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@2906c3c5b3bf The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Bug: None Change-Id: Ibdefe3a6aa230fb8ff58ea2630caf25be5410eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760887Reviewed-by:
-
Robbie Gibson authored
Bug: 992896 Change-Id: Ie589e60a99ccabb0a06ea3875360e684b3048960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760305 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#688084}
-
Rouslan Solomakhin authored
The quota for hasEnrolledInstrument() must be based on the requested autofill data when Basic Card payment method is being used, so the merchant cannot iterate over all options (requestShipping, requestPayerEmail, requestPayerName, requestPayerPhone) and learn about user's autofill data. Disabled by default behind "StrictHasEnrolledAutofillInstrument" feature. Explainer: https://gist.github.com/rsolomakhin/d6d242cbb9306864ada5a29de7ab271e Design (Googlers only): https://docs.google.com/document/d/1VVggx4cy_QFsSEWtnZ9yhvtI4lNPONA4rnJKH3VV9jQ/preview Bug: 993390 Change-Id: I4c2070572a43e7423ba43736741a62546fd8fb8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757293 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#688083}
-
Abigail Klein authored
When text track styles were first being introduced, it was decided that any time user styles are present, all author styles for the text track will be ignored (discussed in https://codereview.chromium.org/921833003). There was a complaint by a customer about this policy, and we can also observe that Safari does not follow. For this reason, we are undoing this decision in this patch. Bug: 979649 Change-Id: I944eeb75d765e7899850ef65337786a6913c59d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733928Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#688082}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7b861aca..92433291 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1d612aa639215cfcaf0f657f78c6f3eb90348d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760412Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688081}
-
Christopher Grant authored
Prior to enabling native code partitioning, the VR DFM was equipped with a small dummy library to soak the delivery and opening mechanism. Now that the real library is present, we can pull out the dummy version. Bug: None Change-Id: I4b2b4d576e5428c2eedae47159a55ad4dcccb784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751829Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#688080}
-
Thomas Tangl authored
- The logic of the link actions remains in ProfileMenuView. - The link handling is done in ProfileMenuViewBase. Bug: 966388 Change-Id: I54100962956bd6acc873b88d1da1b196f967ffd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757842Reviewed-by:
-
Yi Gu authored
This reverts commit 97622f89. Reason for revert: Sufficient information has been collected. Original change's description: > [VizHitTesting V2] Add dump without crash to identify sites with mismatch results > > Collect data after fixing the outdated hit test data issue at > crbug.com/992064 for future investigation. > > Bug: 976284 > Change-Id: I2a59f2902908c09162ccbe41ebbd860b0331ac4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756625 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687744} TBR=rjkroege@chromium.org,yigu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 976284, 977092 Change-Id: I3f26396a09bd7b6ab41406c22cd648dab7b85047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760867Reviewed-by:
-
Benoît Lizé authored
The chromium linker doesn't have static initializers, which make assert_static_initializers.py fail. Instead of adding it to the list of libraries that should be skipped, make sure that it has none. Bug: 979638 Change-Id: I5450031a2e49dbfbf21d991ac6b901ddbb5c7008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760215Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#688077}
-
Dominik Röttsches authored
Replace the snowman emoji (U+2603) with the sum sign (U+2211) in order to avoid situations in which a color fallback font is chosen for the emoji, which cannot be colored white and the reftest thus failing, since the test case shows and emoji, while the reference content does not contain any characters. Bug: 976737 Change-Id: I342d81870418e56575700d3c0941a16544121a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760304 Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#688076}
-
Sahel Sharify authored
This reverts commit bbe68ab3. Reason for revert: Find it founds this cl with 100% confidence to be the cause of CrostiniInstallerViewBrowserTest.InstallFlow failure on MSAN Original change's description: > Factor non-ui logic out of CrostiniInstallerView > > The current CrostiniInstallerView contains a lot of non-ui logic such as > histogram recording and somewhat complex interaction with CrostiniManager. This > CL factors out the non-ui logic into new class CrostiniInstaller. This not only > makes the code cleaner, but also allows us to port the installer UI to WebUI > much more easily. > > > Bug: 912638 > Change-Id: Ie0195c8580518aa39e59aa539ef2fb614978776b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701024 > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: Timothy Loh <timloh@chromium.org> > Commit-Queue: Jason Lin <lxj@google.com> > Cr-Commit-Position: refs/heads/master@{#688021} TBR=benwells@chromium.org,timloh@chromium.org,lxj@google.com Change-Id: I751183d3e79e4455535750c0d700a7e35ee407a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759680Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688075}
-
Himanshu Jaju authored
Change-Id: I00276f97946577bbd15c51ceb5eb64df9975daf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760222Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#688074}
-
Tanisha Mandre authored
- Directory will contain generic superclass files required for both QR and credit code scanner. - This refactoring is required to help use common elements of the QR scanner in the credit card scanner from a shared abstract class. Bug: 990744 Change-Id: I830eb4b34cb10fdf940dc28ab1390270d91c12cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760302Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Cr-Commit-Position: refs/heads/master@{#688073}
-
Yi Gu authored
The test may miss a frame occasionally. See bug for details. TBR=flackr@chromium.org NOTRY=true Bug: 986019 Change-Id: I6bb3e35c26b3d2914a135d52b0b0bb758565da38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760888Reviewed-by:
-
Yaron Friedman authored
There's no specialized knowledge for this and it's a single function. Change-Id: I2d994ff6eac6f26482287b200491b813870d6144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758659 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688071}
-
Thiemo Nagel authored
virtual/omt-worker-fetch/external/wpt/xhr/responsexml-document-properties.htm external/wpt/html/dom/documents/resource-metadata-management/document-lastModified-01.html virtual/blink-cors/external/wpt/xhr/responsexml-document-properties.htm virtual/omt-worker-fetch/external/wpt/xhr/responsexml-document-properties.htm https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fomt-worker-fetch%2Fexternal%2Fwpt%2Fxhr%2Fresponsexml-document-properties.htm TBR=robertma@chromium.org Bug: 626703 Change-Id: I718f35346a8d20f5872d9592a44686b35db8dd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757925 Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688070}
-
Miyoung Shin authored
This CL converts SharedWorkerPtr and SharedWorkerRequest in content to new Mojo types, and uses pending_remote<SharedWorker> in shared_worker_factory.mojom. Bug: 955171, 978694 Change-Id: I15bb365ec38415c575cfb1accaba4664bb60e3e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757259 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#688069}
-
Stephen McGruer authored
Bug: 900581 Change-Id: I610cfe981f2dee98bc22a450a893e452ff9cbe91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760671Reviewed-by:
-
Javier Ernesto Flores Robles authored
Since the refactor to the form input accessory last year, moving the UI files to ios/c/b/ui/ was due. This CL aims to do that and at the same time organize the form input accessory files in their own folder. Creates a new form_input_accessory folder in ios/chrome/browser/ui/autofill/ to organize the input accessory UI files. Moves the UI files from ios/chrome/browser/ui/autofill and ios/chrome/browser/autofill to this folder. Adds OWNERS file to the new folder. Change-Id: I1b5c4c504a4c9e4ca0d5cfb06f96d4851ce5791c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753008 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Thiemo Nagel authored
virtual/cross-origin-embedder-policy/external/wpt/html/cross-origin-embedder-policy/require-corp.https.html Sample failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/82496 Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fcross-origin-embedder-policy%2Fexternal%2Fwpt%2Fhtml%2Fcross-origin-embedder-policy%2Frequire-corp.https.html TBR=robertma@chromium.org Bug: 995129, 626703 Change-Id: I2865dbc00a6f3bf3a605372c948ed009af62a16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760787Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688066}
-
Francois Doray authored
The worker is joined to prevent memory leaks. Bug: 846121 Change-Id: I0a89d7a39cc411d098c12be9e60ea000619a2f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757317 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
This requires to be compiled with Xcode 11 (iOS SDK 13). Bug 976682 Change-Id: I1b33eded1d0df7bda09cc9abb38e04d4de7ba1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731943 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#688064}
-
Christian Dullweber authored
This is a reland of b21dff94 This CL wasn't the cause of renderer crashes. crbug.com/994537#c21 Original change's description: > Pass top frame origin to cookie settings > > In order to correctly apply content settings with secondary patterns, > CookieSettings needs to know the TopFrameOrigin of a request. > Currently it only has access to SiteForCookies, which can be an empty > url for cross-origin iframes. > This CL passes TopFrameOrigin from UrlRequests to CookieSettings and > uses this value to look up ContentSettings. SiteForOrigin is still > used to determine whether the cookie is used in a third-party context. > > As TopFrameOrigin is not yet always available, this new behavior is > behind the ImprovedCookieControls flag. > > Bug: 988398 > Change-Id: Ibb6180b68ae9f4780046be6fb2a9dcbb39f9ccf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698419 > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686759} TBR=rogerta@chromium.org,engedy@chromium.org,jrummell@chromium.org,sdefresne@chromium.org,ntfschr@chromium.org,dullweber@chromium.org,mkwst@chromium.org,morlovich@chromium.org,arthursonzogni@chromium.org Bug: 988398, 994557 Change-Id: I9adf51d62326e75374bc41145e30f377c540f82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760212Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#688063}
-
Ivana Zuzic authored
Add an icon to PasswordEntryEditor layout so passwords could be unmasked and masked, like in PasswordEntryViewer. The unmasking/masking logic is going to be implemented in a future CL. The positioning of the icon might slightly change in the future, but it's going to stay in this fragment. Bug: 377410 Change-Id: I9fbd6295d23901b1c825d2758c56d990656d2052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748894Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ivana Zuzic <izuzic@google.com> Cr-Commit-Position: refs/heads/master@{#688062}
-
Stephen McGruer authored
Bug: 900581 Change-Id: I35db0f6dbadea7f490cbf770b1700621bd5a35d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757291Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 42d0334d. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ib8a1fef0e4ec310c8b7e9fda5bbd4c9881c552e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760411Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688060}
-
