- 31 Aug, 2018 24 commits
-
-
siyua authored
1) Added legal message (clickable) to the offer dialog. 2) Added a Close Button which will be shown when the user clicks save button and the migration process lasts for more than 5 secs. 3) Modified ChromeAutofillClient to enable passing legal message to the LocalCardMigrationDialogControllerImpl. 4) Adjusted format/style of the dialog contents according to the mock: go/autofill-paradise. 5) Added an experiment flag (disabled by default) to control whether we want to show migration feedback to the user. Bug: 852904 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic0ca348fc689486a21d53a76921ee5954cb08295 Reviewed-on: https://chromium-review.googlesource.com/1192688 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#587886}
-
S. Ganesh authored
TBR=thakis@chromium.org BUG=833687 Change-Id: I2e8fedc25facc470d9ece26f5699fb236d044784 Reviewed-on: https://chromium-review.googlesource.com/1171735 Commit-Queue: Will Harris <wfh@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#587885}
-
Weilun Shi authored
Link icon will be enlarged when there is only one line of attribution. The size of the link icon will still correspond to the text size when there are two lines of attribution. Screencast: https://screencast.googleplex.com/cast/NTQwNTYzNTc2NDAyNzM5Mnw1ZjlmZGVjNC04Yg Bug: 878917 Change-Id: I351569a1c260b4e5d0524c44bebdcdc8f67a4522 Reviewed-on: https://chromium-review.googlesource.com/1197425Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#587884}
-
Raymond Toy authored
Just update the messages to say M71 for when the media element nodes will be removed from an OfflineAudioContext, as required by the WebAudio spec. We're still gathering some UMA stats on this. Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/H29uXnsIN54/BKXDqxoJAQAJ Chrome feature entry: https://www.chromestatus.com/feature/5258622686724096 Bug: 845913 Change-Id: Id6b5803533a96bca509d4b5b2b8c4dd2d8ecd7a3 Reviewed-on: https://chromium-review.googlesource.com/1194737Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587883}
-
Scott Chen authored
If a settings-subpage doesn't have a valid associated-control attribute value, searching would crash. This CL fixes a couple of those instances. Bug: 876280 Change-Id: I4be99c6d6e29e5019409f0fde056847e68d34d9e Reviewed-on: https://chromium-review.googlesource.com/1197907Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#587882}
-
Han Leon authored
Removing an unused function: Response* Response::Create( ScriptState* script_state, const WebServiceWorkerResponse& web_response); BUG=879019 Change-Id: I23878fd116cfee6acf6442f854f75b825d08cba4 Reviewed-on: https://chromium-review.googlesource.com/1195732Reviewed-by:Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#587881}
-
Wez authored
In future the fidlc tool will require explicit 'using' declarations for all dependencies. Bug: 879388 Change-Id: Ic82e6c7338d31e045ab20f24044fb97fbc151bbf Reviewed-on: https://chromium-review.googlesource.com/1198012 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#587880}
-
Xiaohui Chen authored
It is possible that the callback from libassistant comes right after assistant_manager is stopped/reset. Let's guard this case. Bug: 879390 Test: locally build Change-Id: Iea2fe174a02627e6d61406a1319d172470028afd Reviewed-on: https://chromium-review.googlesource.com/1198105Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#587879}
-
Findit authored
This reverts commit 15b15db4. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 587871 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzE1YjE1ZGI0NzQ3YzNlOTI2MzgwZTJiZDg4MmNjN2E0OGUzNjRmZTUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.gpu/GPU%20Linux%20Builder/128717 Sample Failed Step: compile Original change's description: > [Extensions] Remove an unused param from StartTestFromBackgroundPage. > > The param was always passed with nullptr value, so remove it entirely. > > Bug: None > Test: None, test cleanup. > Change-Id: If8cd3c4c7e0bd77fabbc545dcbd5fda69a9c0703 > Reviewed-on: https://chromium-review.googlesource.com/1196143 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587871} Change-Id: Iced35e86429f566d79c2ab7807d34c69b6456a35 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/1198563 Cr-Commit-Position: refs/heads/master@{#587878}
-
Bailey Berro authored
The browser_tests for the Add New Services menu make the assumption that there are no native FSPs installed, so this change disables NativeSmb in those tests. Bug: chromium:757625 Change-Id: I0d4d5d20fd71b3d537b0ef58a109a37ca4fc0cf3 Reviewed-on: https://chromium-review.googlesource.com/1197222 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#587877}
-
Xiaohui Chen authored
Bug: 879401 Test: eve does not have assistant button Change-Id: Ie65d700eb6c052d2089bef6ec2a209bdd12dbc9b Reviewed-on: https://chromium-review.googlesource.com/1198282Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#587876}
-
Daniel Hung-yu Wu authored
Make camera metadata tags mojo interface so that it matches the HAL adapter mojo modified for portrait mode (Bokeh). BUG=b:79901482 TEST=CCA works on Soraka R=jcliang@chromium.com Change-Id: I5aaf263efa863f569477cf30a4a63b93f242ab30 Reviewed-on: https://chromium-review.googlesource.com/1195187Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Hung-yu Wu <hywu@chromium.org> Cr-Commit-Position: refs/heads/master@{#587875}
-
Ben Wells authored
This means if a PWA is installed on one machine and synced to another machine such that it isn't locally installed (i.e. it is synced to a non-Chrome OS machine), it won't be treated as an installed PWA. This affects features such as the navigation options available. Bug: 874841 Change-Id: I42667edbd7d9ac7dbe2a088d4b11bda422beee8b Reviewed-on: https://chromium-review.googlesource.com/1195382Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#587874}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eabc276ceacd..01bd09d56fbd git log eabc276ceacd..01bd09d56fbd --date=short --no-merges --format='%ad %ae %s' 2018-08-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-30 nodir@google.com [bot_update] Fix initialization from buildbucket 2018-08-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@01bd09d56fbd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:877161 TBR=agable@chromium.org Change-Id: I6abb911ab1aa454dcd6d86d4fd60990c9333caad Reviewed-on: https://chromium-review.googlesource.com/1198123Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587873}
-
Giovanni Ortuño Urquidi authored
UninstallApps adds uninstallation tasks to the queue of tasks and uninstalls the corresponding extension for the provided URL. Bug: 876174 Change-Id: Id79adb12a0999332aaec830acb48eadbf62b2abb Reviewed-on: https://chromium-review.googlesource.com/1196782 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#587872}
-
Istiaque Ahmed authored
The param was always passed with nullptr value, so remove it entirely. Bug: None Test: None, test cleanup. Change-Id: If8cd3c4c7e0bd77fabbc545dcbd5fda69a9c0703 Reviewed-on: https://chromium-review.googlesource.com/1196143Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587871}
-
Aaron Leventhal authored
Invalidate the object when aria-haspopup changes. Explanation: The cached native_role_ value, which is computed from NativeAccessibilityRoleIgnoringAria(), must not return a different result depending on whether aria-haspopup changes before/after the caching. This affects CanHaveChildren() for a button that changes its aria-haspopup value. This in turn affects many other things for the button, such such as aria-activedescendant computation. Bug: 879032 Change-Id: I2b929623f7dfbc0ba926088add4d747af1f77ef7 Reviewed-on: https://chromium-review.googlesource.com/1196864 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#587870}
-
Miguel Casas authored
This CL moves V4L2SliceVDA to use DecodeSurfaceHandler interface. This needs moving the inner V4L2DecodeSurface out of V4L2VDA, which causes a ripple of mechanic substitutions in the .cc file. Note that the inner classes still have the * to V4L2VDA because other methods are needed in addition to the interface. Partial diagram before: https://goo.gl/LBxH3h, after: https://goo.gl/E6sDrc. Bug: 875005 Test: v_d_a_unittests and simplechrome on kevin Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibed94b8763e02ffbfef3b5137684306761e5d748 Reviewed-on: https://chromium-review.googlesource.com/1178667Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#587869}
-
Anne Lim authored
Removing implementation for "Send first six digits of PAN when determining whether to offer to save". The original plan to avoid offering to save credit cards when Payments cannot support the given card type by sending first six digits of PAN has been abandoned in favor of somehow doing it entirely client-side in the future. Change-Id: I3e95293626d11a07dedb80bd6b5013149cb2dfbc Reviewed-on: https://chromium-review.googlesource.com/1188587 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#587868}
-
Raymond Toy authored
Implements AudioContextManager mojo interface that can be obtained from a frame so that audible playback from WebAudio can be recorded by the browser. Whenever audible playback starts or stops, a message is sent to the browser indicating such. Bug: 855069 Change-Id: Ib236a9506a2a6d9b53e95948eb5519145805a2cb Reviewed-on: https://chromium-review.googlesource.com/1114147Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587867}
-
Yao Xiao authored
Change-Id: I0deb1e45f2e76ac887e9a03d6e48d151211b1c97 Reviewed-on: https://chromium-review.googlesource.com/1191726 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#587866}
-
Matt Falkenhagen authored
It can be used for both network service enabled and disabled. The factory also can't be sent to the renderer. Change-Id: I443179fbb5dcb9e1325614e5bc04bf8fe20db2d9 Reviewed-on: https://chromium-review.googlesource.com/1195296Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#587865}
-
Stephen McGruer authored
The bot currently times out on webkit_layout_tests. I noticed that most other bots use 'chromium_webkit_isolated_scripts' rather than 'webkit_layout_tests_isolated_scripts'. The former has a swarming size argument of 12, whilst the latter has none (and thus seems to use a swarm of size 1). Hopefully switching to 'chromium_webkit_isolated_scripts' will enable the bot to finish the tests. Bug: 876029 Change-Id: I35c77992b28e5a108bee65c1ea91bb39d66c9bd2 Reviewed-on: https://chromium-review.googlesource.com/1197267Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#587864}
-
Jeffrey Kardatzke authored
This receives MIME type information from Crostini and uses that as a secondary lookup technique for file associations. This information is only referenced when a file has been detected to have one of the default MIME types of either text/plain or application/octet-stream. This is stored in a new preferences location as well with a unit test for that. Bug: 869747 Test: Verified Open With associations on eve, unit tests pass Change-Id: Ie631ae609b04c72e37c205e6d5c214816ba47563 Reviewed-on: https://chromium-review.googlesource.com/1195045 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#587863}
-
- 30 Aug, 2018 16 commits
-
-
Scott Chen authored
A bug occured when searching through settings page, because one of the controls associated with the "edit person" subpage does not exist if DICE is enabled. This CL points it to a different control when DICE is enabled. Bug: 876280 Change-Id: I24049100f2b2357ada85b07a44c893a39fd1b66b Reviewed-on: https://chromium-review.googlesource.com/1198006 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#587862}
-
Sam McNally authored
Bug: 844298 Change-Id: I318dbeab7f0badd6d2cf06d22ddf197d590662af Reviewed-on: https://chromium-review.googlesource.com/1196286Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#587861}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7a770735549a..cd6bcbe53ba7 git log 7a770735549a..cd6bcbe53ba7 --date=short --no-merges --format='%ad %ae %s' 2018-08-30 benjhayden@chromium.org Make SparseDiagnostic.GetMostRecentDataByNamesAsync more tolerant. Created with: gclient setdep -r src/third_party/catapult@cd6bcbe53ba7 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:877809 TBR=sullivan@chromium.org Change-Id: Iaeb976d7508515e648353c3b77fdc6c078098bee Reviewed-on: https://chromium-review.googlesource.com/1198122Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587860}
-
Bailey Berro authored
- Updates the CrSearchableDropDown element to support the autofocus property. Bug: chromium:757625 Change-Id: I2df07bd7dde0a22a7b724c2bd9132c7df321a5fb Reviewed-on: https://chromium-review.googlesource.com/1196017Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#587859}
-
Will Harris authored
The old name for this was 'no_size_t_to_int_warning' which was specific to MSVC. clang does not have a specific warning for just 64-bit size_t -> 32-bit value, but instead it has a warning for any conversion from 64-bit to 32-bit (-Wshorten-64-to-32). As part of re-enabling this warning, fixes will be landed to get Chromium warning-clean with -Wshorten-64-to-32 on 64-bit builds only (as tackling for 32-bit builds too, which was never covered by any previous MSVC warning would be too big a first step). For those projects that are e.g. third party or can be tackled at a later date, they can include this new config. The name is different from 'no_size_t_to_int_warning' because that name is confusing (as the new warning enables more than just this). New exceptions will be added with 'no_shorten_64_warnings' and old 'no_size_t_to_int_warning' will be slowly removed or migrated over time. Then the old config will be removed. BUG=588506 Change-Id: I3a6ce9b19e52c7bdc724c7fd326f6afe7b509219 Reviewed-on: https://chromium-review.googlesource.com/1197404 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#587858}
-
Anand K. Mistry authored
Within MTPDeviceDelegateImplLinux::ReadDirectoryInternal, the call to PendingRequestDone at the end of the function allowed for another task to run and potentially delete the file_id from the cache prior to the directory listing being done. This would then cause a nullptr dereference in OnDidReadDirectory which expects the cache entry to exist. Since ReadDirectoryInternal is only run from a task, just continue the task instead of posting it to the request queue. BUG=817523 Change-Id: I9df651864ba1ef3c26365832b149871b027f99d5 Reviewed-on: https://chromium-review.googlesource.com/1195202Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#587857}
-
Justin Cohen authored
Bug: 856516 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I52bee9bcd13d835eab5592bee12c48b95c25c233 Reviewed-on: https://chromium-review.googlesource.com/1197923Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#587856}
-
David Quiroz Marin authored
Our current implementation of canvas textBaseline alignment for top middle and bottom doesn't do what the spec says it should, i.e. align with the EM square. https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-textbaseline This has been a bug on FF side for quite some years: https://bugzilla.mozilla.org/show_bug.cgi?id=737852 This change fixes this misalignment by using the EM square ascent and descent from SimpleFontData instead of the font's max ascent/descent. Also fixing the EM related metrics in canvas TextMetrics. Bug:607053,277215 Change-Id: Id6374e6fcd4e46fa989a7e23a80dc1f5bf961b94 Reviewed-on: https://chromium-review.googlesource.com/1194494 Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#587855}
-
Fabio Tirelo authored
Bug: 879342 Change-Id: Ic2451cdbaa221f0dcd844c29ed8b732d68dc7d76 Reviewed-on: https://chromium-review.googlesource.com/1197360 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#587854}
-
Philip Rogers authored
This patch cleans up the expectations file for blink-gen-property-trees and starts running more tests. Bug: 836886 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7a6252bfa6a1fa5fb3ca8f5c4cc6d01ad7eec8e5 Reviewed-on: https://chromium-review.googlesource.com/1196906Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587853}
-
Mohsen Izadi authored
Now that viz::mojom::GpuHost implementation has moved out of content, viz::GpuClient can directly call on that to establish a gpu channel and we can remove the functionality from GpuClientDelegate. BUG=709332 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ied5a8ead810973068190e3ce485609f68f5826d5 Reviewed-on: https://chromium-review.googlesource.com/1188883 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#587852}
-
khmel@google.com authored
This fix crash when App Launcher is opened next time and having results for Answer Cards from the previous opening. This cleans search result on App Launcher close and adds extra protection to prevent handling views in Answer Cards not attached to the app list view. TEST=Manually, no crash, no error reported BUG=878987 Change-Id: I06fb0d8898161228b95a9001d2dc9b79690fe0c5 Reviewed-on: https://chromium-review.googlesource.com/1197328 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#587851}
-
khmel@google.com authored
This is required for cheets_AuthPerf test that waits until Play Store window is shown. Before we used implicit check that some property file was created. That was bit flaky due background nature of creating this file and did not work on all platforms. This CL introduces explicit way by checking if app is actually shown on Chrome. BUG=b:110060284 TEST=cheets_AuthPerf passes for Scarlet (where was failing before) + few other boards. Change-Id: Ia372b4939853a1c99fdd70a68079e080e14111c3 Reviewed-on: https://chromium-review.googlesource.com/1194735 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#587850}
-
Manu Cornet authored
See what it looks like in comment #15 of the linked bug. Bug: 874161 Change-Id: I42a81c93742fb68720e237e34e2b66b68b3e9de5 Reviewed-on: https://chromium-review.googlesource.com/1197730 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#587849}
-
Ryan Hamilton authored
Change-Id: I307c05133fc9188997cd010ce8dd1dcf0657835c Reviewed-on: https://chromium-review.googlesource.com/1197784 Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#587848}
-
Istiaque Ahmed authored
Bug: None Test: None, internal only cleanup. Change-Id: I5e29e662450c6b7a5ee14d332caa1d76ea14b7b1 Reviewed-on: https://chromium-review.googlesource.com/1144538Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587847}
-